Herbert Xu wrote:
> In fact that reminds me, because tg3 is no longer lockless, we can do
> a nicer bug fix for it than e1000 (it has the same bug).
>
Do you mean the same race condition bug between tg3_start_xmit()
and tg3_tx() that I brought up? I don't think tg3 has that problem.
Did I miss
Herbert Xu wrote:
> Yes it has the problem in two places. First of all the first
> netif_stop_queue in tg3_start_xmit doesn't take the tx_lock at
> all so it's obviously vulnerable.
Oh, that first one near the top of tg3_start_xmit()? That
condition is not supposed to happen and is a bug condit
On Tue, 2006-08-08 at 00:43 +0200, Bernd Schubert wrote:
> Hi,
>
> I have seen a few reports like this, but now broadcom seems to actively
> support tg3, so I decided to send this.
>
> ... [many hamilton not responding messages]
> 4554928.798000] nfs: server hamilton not responding, still trying
On Tue, 2006-08-08 at 01:24 +0200, Bernd Schubert wrote:
>
> tg3.c:v3.49 (Feb 2, 2006)
> acpi_bus-0201 [01] bus_set_power : Device is not power manageable
> eth1: Tigon3 [partno(BCM95704A6) rev 2003 PHY(5704)] (PCIX:100MHz:64-bit)
> 10/100/1000BaseT Ethernet 00:e0:81:2b:aa:28
> eth1: RXc
-state condition.
6. Update version to 3.65.
Signed-off-by: Michael Chan <[EMAIL PROTECTED]>
diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
index 6f97962..0eece29 100644
--- a/drivers/net/tg3.c
+++ b/drivers/net/tg3.c
@@ -68,8 +68,8 @@
#define DRV_MODULE_NAME"
On Tue, 2006-08-08 at 12:51 +1000, Herbert Xu wrote:
> > 2. Eliminate the private tx_lock altogether and rely solely on
> > netif_tx_lock. This eliminates one spinlock in tg3_start_xmit()
> > when the ring is full.
>
> Why not get rid of the lock altogether? By making sure memory
> barriers are
ing is full in a steady-state condition.
6. Update version to 3.65.
Signed-off-by: Michael Chan <[EMAIL PROTECTED]>
diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
index 6f97962..b72c138 100644
--- a/drivers/net/tg3.c
+++ b/drivers/net/tg3.c
@@ -68,8 +68,8 @@
#define DRV
Theodore Tso wrote:
> Thanks, that description was very helpful. Would you accept a patch
> with adding a comment describing this?
I will put it on my queue to add some comments for ASF.
>
> It appears that there is no way of disabling ASF; is that a true
> statement?
>
Turning off ASF is ju
his reduces the number of unnecessary
spinlocks when the tx ring is full in a steady-state condition.
Signed-off-by: Michael Chan <[EMAIL PROTECTED]>
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index db73de0..2099edb 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -209,
[BNX2]: Convert to netdev_alloc_skb()
Convert dev_alloc_skb() to netdev_alloc_skb() and increase default
rx ring size to 255. The old ring size of 100 was too small.
Update version to 1.4.44.
Signed-off-by: Michael Chan <[EMAIL PROTECTED]>
diff --git a/drivers/net/bnx2.c b/drivers/net/
On Tue, 2007-11-13 at 18:04 -0800, Joe Perches wrote:
> Remove defconfig ptr comparison to 0
>
> Remove sparse warning: Using plain integer as NULL pointer
>
> Signed-off-by: Joe Perches <[EMAIL PROTECTED]>
>
Acked-by: Michael Chan <[EMAIL PROTECTED]>
Thanks.
-
On Thu, 2007-11-15 at 13:17 -0600, Jon Nelson wrote:
> Is this what you mean? I pulled this from the quoted text:
>
> Nov 10 22:45:52 frank kernel: NETDEV WATCHDOG: eth0: transmit timed out
>
Right. This explains the reset at 22:45:52, but not the earlier reset
at 22:24:40. Link never came up
On Thu, 2007-11-15 at 10:47 +0100, Jarek Poplawski wrote:
> On 13-11-2007 19:57, Jon Nelson wrote:
> > The best info I've got is this:
It looks like the card is being reset periodically. Every time the card
gets reset, you'll see those PM messages in the version of the driver
you're using. Do yo
On Thu, 2007-11-15 at 14:41 -0800, David Miller wrote:
> From: "Matt Carlson" <[EMAIL PROTECTED]>
> Date: Thu, 15 Nov 2007 14:20:10 -0800
> >
> > Keeping the MRRS at 512 introduces DMA latencies that effectively
> > prevent us from achieving linerate. With a packet size of ~1.5K and the
> > MRRS a
On Thu, 2007-11-15 at 16:32 -0800, Rick Jones wrote:
> I'm going to get very rapidly out of my PCI depth, but on one or the
> other (e vs X) isn't is possible from the standpoint of PCI for a device
> to have multiple transactions outstanding at a time?
Yes, see my other response. Multiple out
Jon Nelson wrote:
> The lspci is exactly as it was output. The dmesg is shortened only
> slightly. The kernel is the latest available for openSUSE 10.3. No MSI
> because this is an Athlon XP (read: 32bit, single core, regular old
> 33MHz, 32bit PCI).
>
The lspci doesn't look correct to me either
[EMAIL PROTECTED] wrote:
> (a) the Dell factory default is WOL disabled and (b)
> if it wasn't
> the default, I'd have *set* it to disabled, and (c) I even
> went back and
> rebooted and checked the BIOS setting - disabled. Nonetheless:
>
> # ethtool eth0 | grep Wake
> Supports Wake-on:
On Tue, 2007-11-27 at 01:35 -0800, [EMAIL PROTECTED] wrote:
>
> Issue:
>
> I (for unrelated reasons) run powertop, and it suggests I conserve power
> by doing 'ethtool -s eth0 wol d'. I look at it, and think that it's daft,
> because (a) the Dell factory default is WOL disabled and (b) if it wa
[BNX2]: Add PHY_DIS_EARLY_DAC workaround.
5709 Ax and Bx chips all need this workaround.
Signed-off-by: Michael Chan <[EMAIL PROTECTED]>
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index da767d3..a4f3832 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -6685,8 +
we later check for more work using this stored rx index.
The fix is to not store this latest hw index and only store the
processed rx index. We use a new function bnx2_get_hw_rx_cons()
to fetch the latest hw rx index.
Signed-off-by: Michael Chan <[EMAIL PROTECTED]>
diff --git a/drivers/ne
[BNX2]: Update version to 1.6.9.
Signed-off-by: Michael Chan <[EMAIL PROTECTED]>
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index f9eea6e..4e7b46e 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -56,8 +56,8 @@
#define DRV_MODULE_NAME"bnx2&qu
[BNX2]: Add ring constants.
Define the various ring constants to make the code cleaner.
Signed-off-by: Michael Chan <[EMAIL PROTECTED]>
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index 4e7b46e..dfe50c2 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -468,8
[BNX2]: Add init. code to handle RX pages.
Add new fields to keep track of the pages and the page rings.
Add functions to allocate and free pages.
Signed-off-by: Michael Chan <[EMAIL PROTECTED]>
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index db3b750..38e8e31 100644
--- a/drive
[BNX2]: Add S/G jumbo RX support.
David, 8 patches will follow to implement S/G for jumbo RX packets.
Please review for 2.6.25. Thanks.
Signed-off-by: Michael Chan <[EMAIL PROTECTED]>
---
drivers/net/bnx2.c | 510 +++-
drivers/net/bnx2.h | 43 +-
drivers/net/bnx2_fw.h
[BNX2]: Restructure RX fast path handling.
Add a new function to handle new SKB allocation and to prepare the
completed SKB. This makes it easier to add support for non-linear
SKB.
Signed-off-by: Michael Chan <[EMAIL PROTECTED]>
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
. Copybreak will be turned off when pages are used.
Signed-off-by: Michael Chan <[EMAIL PROTECTED]>
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index 14119fb..81971b1 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -2117,15 +2117,12 @@ bnx2_init_context(struct bn
[BNX2]: Add fast path code to handle RX pages.
Add function to reuse a page in case of allocation or other errors.
Add code to construct the completed SKB with the additional data in
the pages.
Signed-off-by: Michael Chan <[EMAIL PROTECTED]>
diff --git a/drivers/net/bnx2.c b/drivers/net/
uring loopback test.
Signed-off-by: Michael Chan <[EMAIL PROTECTED]>
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index 6c0fc8a..ae081c8 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -4493,15 +4493,32 @@ static u32 bnx2_find_max_ring(u32 ring_size, u32
max_size)
[BNX2]: Update version to 1.6.9.
Signed-off-by: Michael Chan <[EMAIL PROTECTED]>
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index ae081c8..469d259 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -56,8 +56,8 @@
#define DRV_MODULE_NAME"bnx2&qu
On Tue, 2007-08-28 at 19:07 -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, Aug 28, 2007 at 10:39:26PM +0100, Christoph Hellwig escreveu:
> > On Tue, Aug 28, 2007 at 02:32:50PM -0700, David Miller wrote:
> > > From: "Michael Chan" <[EMAIL PROTECTED]>
> >
On Tue, 2007-08-28 at 17:25 -0700, David Miller wrote:
> The new NAPI struct patch is in there, one caveat of the new
> behavior is that in drivers that conditionalize NAPI support
> we can't be lazy and do the napi_{enable,disable}() outside
> of the ifdefs any longer. I tried to audit all the dr
open-iscsi driver to support iSCSI offload on bnx2 devices.
Signed-off-by: Anil Veerabhadrappa <[EMAIL PROTECTED]>
Signed-off-by: Michael Chan <[EMAIL PROTECTED]>
---
drivers/net/Kconfig | 10 +
drivers/net/Makefile |1 +
driver
workaround the
problem by disabling MSI on ServerWorks HT1000 bridge chips commonly
found with the 5714.
We workaround this chip bug by enabling INTX after we enable MSI and
after we resume from suspend.
Update version to 3.81.
This problem was discovered by David Miller.
Signed-off-by: Michael
Andy Gospodarek wrote:
> This patch was designed to address tg3 and bnx2 messages printed on
> systems with HT1000 chips IIRC. Are we going back to those
> messages on
> bnx2 or is there a workaround in that driver needed too?
>
Andy, I've checked all the Broadcom chips including bnx2 chips, o
On Thu, 2007-09-06 at 11:41 -0400, Andy Gospodarek wrote:
> On Thu, Sep 06, 2007 at 07:34:23AM -0700, David Miller wrote:
> > From: Andy Gospodarek <[EMAIL PROTECTED]>
> > Date: Thu, 6 Sep 2007 09:45:16 -0400
> >
> > > Is is really necessary to get rid of the HT1000 patch?
> >
> > Yes, absolutely
On Thu, 2007-09-06 at 12:50 -0700, David Miller wrote:
> From: "Michael Chan" <[EMAIL PROTECTED]>
> Date: Thu, 06 Sep 2007 12:05:30 -0700
>
> > The HT1000 bridge may very well have an MSI issue. I'm checking with
> > ServerWorks and I will do some
Christoph Hellwig wrote:
> Most of it should just go away, and the other bits shouldn't
> change over
> the lifetime of the driver except for additions. So there
> really isn't
> any point in auto-generating it.
>
Yes, I agree with Mike Christie on this. These values in
question are defined
Lucas Nussbaum wrote:
> This used to work, and broke between 2.6.16 and 2.6.17. Using
> git bissect,
> I could trace this back to that commit:
> commit bc1c756741b065cfebf850e4164c0e2aae9d527f
> Author: Michael Chan <[EMAIL PROTECTED]>
> Date: Mon Mar 20 17:48:
On Thu, 2007-09-13 at 17:41 +0200, Lucas Nussbaum wrote:
> # ethtool -i eth0
> driver: tg3
> version: 3.65
> firmware-version: 5703-v2.21a
> bus-info: :02:02.0
The firmware is quite old and needs to be upgraded to fix the problem.
I'll have someone contact you to get it upgraded.
>
> What d
On Thu, 2007-09-13 at 21:28 +0200, Lucas Nussbaum wrote:
> Erm, Wouldn't it be possible to print a warning when the driver loads,
> saying that the firmware is outdated ?
It's possible, but would require the driver to parse the version string.
The driver currently reports the version string for i
On Thu, 2007-09-13 at 14:11 -0700, Roland Dreier wrote:
>
> I've been meaning to track down the bnx2 iscsi offload patch to look
> and see if this issue is addressed, since the same problem seems to
> exist: it seems an iscsi connection and a main stack tcp connection
> might share the same 4-tup
On Fri, 2007-09-14 at 10:14 +0200, Ingo Oeser wrote:
> Michael Chan schrieb:
> > On Thu, 2007-09-13 at 21:28 +0200, Lucas Nussbaum wrote:
> > > Erm, Wouldn't it be possible to print a warning when the driver loads,
> > > saying that the firmware is outdated ?
&
On Fri, 2007-09-14 at 09:18 -0700, Roland Dreier wrote:
> However, do you have any plans to support iSCSI offload for targets?
> Also, looking at the first CNIC patch, I can't help but notice that
> you seem to have at least some support for iWARP there. How does the
> CNIC look? Does it share t
On Tue, 2007-09-18 at 18:23 +0100, Denys Vlasenko wrote:
> Hi Michael,
>
> In bnx2_fw.h I see the following:
>
> static u32 bnx2_RXP_b06FwBss[(0x13dc/4) + 1] = { 0x0 };
>
> static struct fw_info bnx2_rxp_fw_06 = {
> ...
> .bss= bnx2_RXP_b06FwBss,
> ...
> };
>
On Tue, 2007-09-18 at 18:55 +0100, Denys Vlasenko wrote:
> On Tuesday 18 September 2007 19:45, Michael Chan wrote:
> > We can compress all the different sections of the firmware. Currently,
> > we only compress the biggest chunks and the rest are uncompressed.
>
> > The
On Tue, 2007-09-18 at 11:23 -0700, David Miller wrote:
> I don't like it because it means people have to setup full initrd's
> in order to do network booting with such network cards.
>
> But the days of my opinion mattering on that issue are long gone,
> the momentum is just too greatly behind us
On Tue, 2007-09-18 at 23:37 +0200, Willy Tarreau wrote:
> > > Michael, doesn't a functional-yet-suboptimal firmware exist ? I mean,
> > > just the same principle as we all have kernels, boot CDs, statically
> > > built tools, etc... which run everywhere. If you have such a beast,
> > > maybe it wo
On Wed, 2007-09-19 at 09:30 +0100, Denys Vlasenko wrote:
+ /* gzip header (1f,8b,08... 10 bytes total + possible asciz filename)
+* is stripped, 32-bit unpacked size (LE) is prepended instead */
+ sz = *zbuf++;
+ sz = (sz << 8) + *zbuf++;
+ sz = (sz << 8) + *zbuf++;
On Wed, 2007-09-19 at 21:29 +0100, Denys Vlasenko wrote:
> Are you saying that you successfully run-tested it?
I've only reviewed the code. Let's resolve these issues first before
testing the code.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [
[BNX2]: Add PHY workaround for 5709 A1.
Add the DIS_EARLY_DAC PHY workaround for 5709 A1. Without it, link
sometimes does not come up.
Update version to 1.6.5.
Signed-off-by: Michael Chan <[EMAIL PROTECTED]>
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index 854d80c..66eed22
On Thu, 2007-09-20 at 15:49 +0100, Denys Vlasenko wrote:
>
>
> Please test these two patches.
> I updated them according to your comments.
>
>
I've only tested patch #1. It worked after some minor modifications
below.
>
>
>
>
>
> plain text
> document
> attachment
> (linux-2.6.23-
> rc6
ook and I'll try to do so as well
> tonight.
>
I've already reviewed the earlier versions of the patch and have made
some suggestions. This latest one looks ok to me and tested ok.
I'll follow up later with another patch to remove all the zeros in other
firmware sections, an
On Sun, 2007-09-30 at 14:11 -0400, jamal wrote:
> Here are some non-batching related changes that i have in my batching
> tree. Like the e1000e, they make the xmit code more readable.
> I wouldnt mind if you take them over.
>
Jamal, in tg3_enqueue_buggy(), we may have to call tg3_tso_bug() which
seems reasonable to me. Thanks.
Acked-by: Michael Chan <[EMAIL PROTECTED]>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 2007-10-02 at 08:37 -0400, jamal wrote:
> The simplest solution seems to me to modify the definition of
> TG3_SKB_CB
> as i did for e1000 from:
> (struct tg3_tx_cbdata *)&((__skb)->cb[0])
> to:
> (struct tg3_tx_cbdata *)&((__skb)->cb[8])
>
> that way the vlan tags are always present and no
[BNX2]: Add missing napi_disable() in bnx2_close().
bnx2_close() -> bnx2_netif_stop() will not call napi_disable() because
the netif_state is not running in bnx2_close(). To avoid confusion,
we change it to disable interrupt and napi directly in bnx2_close().
Signed-off-by: Michael Chan <
2. We eliminate the BSS and SBSS firmware sections in bnx2_fw*.h since
these are always zeros.
Signed-off-by: Michael Chan <[EMAIL PROTECTED]>
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index 4887c31..c50e4c8 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -2810
[BNX2]: Update version to 1.6.6.
Signed-off-by: Michael Chan <[EMAIL PROTECTED]>
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index c50e4c8..db14f35 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -56,8 +56,8 @@
#define DRV_MODULE_NAME"bnx2&qu
NetArt - Grzegorz Nosek wrote:
>
> I have encountered an error which looks tg3-related. Upon adding some
> htb queue rules (which I don't have handy ATM but can provide if
> needed), after some time we get such messages in the kernel log:
>
Please provide the HTB queue rules and the type of tra
On Mon, 2007-04-02 at 17:41 +1000, CaT wrote:
> On Mon, Apr 02, 2007 at 12:13:00AM -0700, Andrew Morton wrote:
> > On Mon, 2 Apr 2007 11:43:19 +1000 CaT <[EMAIL PROTECTED]> wrote:
> >
> > > I take minute by minute snapshots of network traffic by sampling
> > > /proc/net/dev and most of the time ev
Jamie webb wrote:
>
> Well, so far so good. I'll let you know if it happens again, but it
> looks like that's fixed it.
>
> Further testing showed that I also had to disable rx checksumming,
> otherwise I was getting random kernel crashes. Presumably it was not
> only reading data from random
Andi Kleen wrote:
> tg3s never use the IOMMU on AMD systems with production kernels
> because they have a suitably large DMA mask. IOMMU is only used
> there to remap memory that doesn't fit a device's DMA mask.
> There is a debugging mode to force iommu always, but it is not used
> unless you co
On Sat, 2007-04-14 at 17:20 -0700, Michael Chan wrote:
> I also like Andi's idea of using change_page_attr() to isolate the
> problem. I'll try to send you a debug patch in the next few days to try
> that out. Thanks.
>
Here's the debug patch for x86 only that will c
[BNX2]: Fix occasional NETDEV WATCHDOG on 5709.
Tweak a register setting to prevent the tx mailbox from halting.
Update version to 1.5.8.
Signed-off-by: Michael Chan <[EMAIL PROTECTED]>
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index 0b7aded..e85f5ec 100644
--- a/drivers/net/
David, please review and apply the following patches that will follow.
The firmware patches 6-11 will be sent to you off-list due to large
size.
[PATCH 1/20][BNX2]: Block MII access when ifdown.
[PATCH 2/20][BNX2]: Fix register and memory test on 5709.
[PATCH 3/20][BNX2]: Add 40-bit DMA workaround
[BNX2]: Block MII access when ifdown.
The device may be in D3hot state and should not allow MII register
access.
Signed-off-by: Michael Chan <[EMAIL PROTECTED]>
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index f98a220..9f0a067 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/
[BNX2]: Fix register and memory test on 5709.
Tweak registers and memory test range for 5709.
Signed-off-by: Michael Chan <[EMAIL PROTECTED]>
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index 9f0a067..6d05397 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -3763,10 +3
[BNX2]: Add 40-bit DMA workaround for 5708.
The internal PCIE-to-PCIX bridge of the 5708 has the same 40-bit DMA
limitation as some of the tg3 chips. Use the same workaround used in
tg3. On 64-bit systems without IOMMU, linearize the SKB if any
address is > 40-bit.
Signed-off-by: Michael C
bnx2_open() to avoid race conditions with
the irq.
Signed-off-by: Michael Chan <[EMAIL PROTECTED]>
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index dba4088..971607c 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -4350,6 +4350,8 @@ bnx2_open(struct net_devic
[BNX2]: Save PCI state during suspend.
This is needed to save the MSI state which will be lost during
suspend.
Signed-off-by: Michael Chan <[EMAIL PROTECTED]>
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index 971607c..8520967 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/
[BNX2]: Put MII register offsets in the bnx2 struct.
The 5709 Serdes device uses non-standard MII register offsets. This
re-structuring will make it easier to support 5709 Serdes.
Signed-off-by: Michael Chan <[EMAIL PROTECTED]>
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index 8
[BNX2]: Add ipv6 TSO and checksum for 5709.
Signed-off-by: Michael Chan <[EMAIL PROTECTED]>
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index 8520967..8610f7f 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -4624,35 +4624,49 @@ bnx2_start_xmit(struct sk_buff *skb,
[BNX2]: Re-structure the 2.5G Serdes code.
Add some common procedures to handle enabling and disabling 2.5G.
Add some missing code to resolve flow control.
Add SUPPORTED_2500baseX_Full and ADVERTISED_2500baseX_Full in
ethtool.h.
Signed-off-by: Michael Chan <[EMAIL PROTECTED]>
diff -
[BNX2]: Add support for 5709 Serdes.
Add PCI ID and code to support the 5709 Serdes PHY.
Signed-off-by: Michael Chan <[EMAIL PROTECTED]>
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index eac52a1..ffd6976 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -84,6 +84,7 @@ t
[BNX2]: Add indirect spinlock.
The indirect register access method will be used by more than one
caller in BH context (NAPI poll and timer), so a spinlock is required.
Signed-off-by: Michael Chan <[EMAIL PROTECTED]>
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index ffd6976..3
[BNX2]: Enhance the heartbeat.
In addition to the periodic heartbeat, we're adding a heartbeat
request interrupt when the heartbeat is late. This is useful
especially in -rt kernels where the timer frequently runs late.
Signed-off-by: Michael Chan <[EMAIL PROTECTED]>
diff --git a/
: Michael Chan <[EMAIL PROTECTED]>
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index 3d41357..5869e2b 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -2273,6 +2273,23 @@ bnx2_msi(int irq, void *dev_instance)
}
static irqreturn_t
+bnx2_msi_1shot(int irq, void *dev_in
[BNX2]: Print bus information for PCIE devices.
Fix the code to print PCI or PCIE bus information for all devices.
Signed-off-by: Michael Chan <[EMAIL PROTECTED]>
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index 5869e2b..fc25d2c 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/
[BNX2]: Update version and reldate.
Update version to 1.5.10.
Signed-off-by: Michael Chan <[EMAIL PROTECTED]>
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index fc25d2c..7da6340 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -1,6 +1,6 @@
/* bnx2.c: Broadcom NX2 n
David Miller wrote:
> From: Jeff Garzik <[EMAIL PROTECTED]>
> Date: Wed, 02 May 2007 03:06:43 -0400
>
> > Second, CONFIG_HIGHMEM is a bad test for IOMMU presence. I don't
> > think you /can/ test for IOMMU presence. Maybe DaveM knows a way
> > that I do not?
>
> You really can't.
>
> We have
On Wed, 2007-05-02 at 11:29 -0400, Jeff Garzik wrote:
> Michael Chan wrote:
> > A non-IOMMU system using 64-bit dma_addr_t will always set
> > CONFIG_HIGHMEM, right?
>
> No.
>
May be I misunderstood the code in illegal_highdma() in net/core/dev.c
where it is checki
On Wed, 2007-05-02 at 14:24 -0400, Jeff Garzik wrote:
> Michael Chan wrote:
> > On Wed, 2007-05-02 at 11:29 -0400, Jeff Garzik wrote:
> >> Michael Chan wrote:
> >>> A non-IOMMU system using 64-bit dma_addr_t will always set
> >>> CONFIG_HIGHMEM, right?
&g
On Wed, 2007-05-02 at 12:40 -0700, David Miller wrote:
> From: "Michael Chan" <[EMAIL PROTECTED]>
> Date: Wed, 2 May 2007 08:23:40 -0700
>
> > A non-IOMMU system using 64-bit dma_addr_t will always set
> > CONFIG_HIGHMEM, right?
>
> Nope, IA-64 is at l
On Wed, 2007-05-02 at 14:45 -0700, David Miller wrote:
> From: "Michael Chan" <[EMAIL PROTECTED]>
> Date: Wed, 02 May 2007 14:27:49 -0700
>
> > I see. So IA64 always uses the SWIOTLB when it doesn't have IOMMU then?
> >
> > I'm a bit confu
On Wed, 2007-05-02 at 03:07 -0400, Jeff Garzik wrote:
> Michael Chan wrote:
> >
> > @@ -6195,6 +6197,18 @@ bnx2_init_one(struct pci_dev *pdev, const struct
> > pci_device_id *ent)
> > dev->poll_controller = poll_bnx2;
> > #endif
>
[ETHTOOL]: Add 2.5G bit definitions.
Add 2.5G supported and advertising bit definitions. 2.5G is supported
by the bnx2 driver.
Signed-off-by: Michael Chan <[EMAIL PROTECTED]>
diff --git a/include/linux/ethtool.h b/include/linux/ethtool.h
index c6310ae..f2d248f 100644
--- a/include
Add 2.5G Serdes support to ethtool user program and ethtool.8 man
page. The missing pause bits are also added to keep ethtool-copy.h
in sync with the kernel's version.
Signed-off-by: Michael Chan <[EMAIL PROTECTED]>
diff --git a/ethtool-copy.h b/ethtool-copy.h
index 30f5e05..461
Version 2 of the BNX2 patchset. I've modified the 40-bit workaround to
just set the dma masks, combined the 5709 firmware into 1 patch which is
now 500K, pulled out the heartbeat chnages, and separated the patch for
ethtool.h. Earlier, I sent 1 patch for ethtool.h for the kernel, and
another patc
[BNX2]: Block MII access when ifdown.
The device may be in D3hot state and should not allow MII register
access.
Signed-off-by: Michael Chan <[EMAIL PROTECTED]>
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index f98a220..9f0a067 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/
[BNX2]: Fix register and memory test on 5709.
Tweak registers and memory test range for 5709.
Signed-off-by: Michael Chan <[EMAIL PROTECTED]>
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index 9f0a067..6d05397 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -3763,10 +3
[BNX2]: Add 40-bit DMA workaround for 5708.
The internal PCIE-to-PCIX bridge of the 5708 has the same 40-bit DMA
limitation as some of the tg3 chips. Set dma_mask and persistent DMA
mask to 40-bit to workaround.
Signed-off-by: Michael Chan <[EMAIL PROTECTED]>
diff --git a/drivers/net/bn
bnx2_open() to avoid race conditions with
the irq.
Signed-off-by: Michael Chan <[EMAIL PROTECTED]>
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index 679ee66..cffdec3 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -4350,6 +4350,8 @@ bnx2_open(struct net_devic
[BNX2]: Save PCI state during suspend.
This is needed to save the MSI state which will be lost during
suspend.
Signed-off-by: Michael Chan <[EMAIL PROTECTED]>
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index cffdec3..89681b3 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/
[BNX2]: Add ipv6 TSO and checksum for 5709.
Signed-off-by: Michael Chan <[EMAIL PROTECTED]>
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index 89681b3..01977de 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -4537,35 +4537,49 @@ bnx2_start_xmit(struct sk_buff *skb,
[BNX2]: Put MII register offsets in the bnx2 struct.
The 5709 Serdes device uses non-standard MII register offsets. This
re-structuring will make it easier to support 5709 Serdes.
Signed-off-by: Michael Chan <[EMAIL PROTECTED]>
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index 0
[BNX2]: Re-structure the 2.5G Serdes code.
Add some common procedures to handle enabling and disabling 2.5G.
Add some missing code to resolve flow control.
Signed-off-by: Michael Chan <[EMAIL PROTECTED]>
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index a634315..944f547 100644
[BNX2]: Add support for 5709 Serdes.
Add PCI ID and code to support the 5709 Serdes PHY.
Signed-off-by: Michael Chan <[EMAIL PROTECTED]>
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index 944f547..ab58909 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -84,6 +84,7 @@ t
[BNX2]: Add indirect spinlock.
The indirect register access method will be used by more than one
caller in BH context (NAPI poll and timer), so a spinlock is required.
Signed-off-by: Michael Chan <[EMAIL PROTECTED]>
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index ab58909..c
[BNX2]: Restructure PHY event handling.
Restructure by adding bnx2_phy_event_is_set() to make code cleaner
and easier to understand.
Signed-off-by: Michael Chan <[EMAIL PROTECTED]>
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index cb74f12..f072028 100644
--- a/drivers/net/bnx2.c
: Michael Chan <[EMAIL PROTECTED]>
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index f072028..97ed400 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -2262,6 +2262,23 @@ bnx2_msi(int irq, void *dev_instance)
}
static irqreturn_t
+bnx2_msi_1shot(int irq, void *dev_in
901 - 1000 of 1880 matches
Mail list logo
