Re: [PATCH tip/core/rcu 21/21] drivers/vhost: Remove now-redundant read_barrier_depends()

On Tue, Dec 05, 2017 at 10:17:35PM +0100, Peter Zijlstra wrote: > On Tue, Dec 05, 2017 at 10:28:38PM +0200, Michael S. Tsirkin wrote: > > On Tue, Dec 05, 2017 at 08:57:52PM +0100, Peter Zijlstra wrote: > > > On Tue, Dec 05, 2017 at 09:51:48PM +0200, Michael S. Tsirkin wrote: >

Re: [PATCH tip/core/rcu 21/21] drivers/vhost: Remove now-redundant read_barrier_depends()

On Tue, Dec 05, 2017 at 08:57:52PM +0100, Peter Zijlstra wrote: > On Tue, Dec 05, 2017 at 09:51:48PM +0200, Michael S. Tsirkin wrote: > > > > WRITE_ONCE(obj->val, 1); > > > > smp_wmb(); > > > > WRITE_ONCE(*foo, obj); > > > > > > I belie

Re: [PATCH tip/core/rcu 21/21] drivers/vhost: Remove now-redundant read_barrier_depends()

On Tue, Dec 05, 2017 at 11:33:39AM -0800, Paul E. McKenney wrote: > On Tue, Dec 05, 2017 at 09:24:21PM +0200, Michael S. Tsirkin wrote: > > On Tue, Dec 05, 2017 at 08:17:33PM +0100, Peter Zijlstra wrote: > > > On Tue, Dec 05, 2017 at 08:57:46PM +0200, Michael S. Tsirkin wrote

Re: [PATCH tip/core/rcu 21/21] drivers/vhost: Remove now-redundant read_barrier_depends()

On Tue, Dec 05, 2017 at 01:36:44PM -0800, Paul E. McKenney wrote: > On Tue, Dec 05, 2017 at 11:24:49PM +0200, Michael S. Tsirkin wrote: > > On Tue, Dec 05, 2017 at 12:08:01PM -0800, Paul E. McKenney wrote: > > > On Tue, Dec 05, 2017 at 09:51:48PM +0200, Michael S. Tsirkin wro

Re: [RFC] virtio-net: help live migrate SR-IOV devices

On Tue, Dec 05, 2017 at 01:52:26PM -0800, Jesse Brandeburg wrote: > On Tue, 5 Dec 2017 21:20:07 +0200 > "Michael S. Tsirkin" <m...@redhat.com> wrote: > > > On Tue, Dec 05, 2017 at 11:59:17AM +0200, achiad shochat wrote: > > > Then we'll have a single solu

Re: [PATCH tip/core/rcu 21/21] drivers/vhost: Remove now-redundant read_barrier_depends()

On Tue, Dec 05, 2017 at 10:57:00PM +0100, Peter Zijlstra wrote: > On Tue, Dec 05, 2017 at 11:24:49PM +0200, Michael S. Tsirkin wrote: > > READ_ONCE is really all over the place (some code literally replaced all > > memory accesses with READ/WRITE ONCE). > > Yeah, so? Oh my p

Re: [PATCH tip/core/rcu 21/21] drivers/vhost: Remove now-redundant read_barrier_depends()

On Tue, Dec 05, 2017 at 07:39:46PM +0100, Peter Zijlstra wrote: > On Tue, Dec 05, 2017 at 08:31:20PM +0200, Michael S. Tsirkin wrote: > > > Apropos, READ_ONCE is now asymmetrical with WRITE_ONCE. > > > > I can read a pointer with READ_ONCE and be sure the value > &g

Re: [PATCH tip/core/rcu 21/21] drivers/vhost: Remove now-redundant read_barrier_depends()

On Tue, Dec 05, 2017 at 08:17:33PM +0100, Peter Zijlstra wrote: > On Tue, Dec 05, 2017 at 08:57:46PM +0200, Michael S. Tsirkin wrote: > > > I don't see WRITE_ONCE inserting any barriers, release or > > write. > > Correct, never claimed there was. > > Just saying th

Re: [PATCH tip/core/rcu 21/21] drivers/vhost: Remove now-redundant read_barrier_depends()

McKenney <paul...@linux.vnet.ibm.com> > Cc: "Michael S. Tsirkin" <m...@redhat.com> > Cc: Jason Wang <jasow...@redhat.com> > Cc: <k...@vger.kernel.org> > Cc: <virtualizat...@lists.linux-foundation.org> > Cc: <netdev@vger.kernel.org> A

Re: [RFC] virtio-net: help live migrate SR-IOV devices

On Tue, Dec 05, 2017 at 11:59:17AM +0200, achiad shochat wrote: > Then we'll have a single solution for both netvsc and virtio (and any > other PV device). > And we could handle the VF DMA dirt issue agnostically. For the record, I won't block patches adding this kist to virtio on the basis that

Re: [PATCH net-next V2] tuntap: fix possible deadlock when fail to register netdev

. > > Fixes: 96f84061620c ("tun: add eBPF based queue selection method") > Reported-by: Eric Dumazet <eric.duma...@gmail.com> > Cc: Eric Dumazet <eric.duma...@gmail.com> > Cc: Willem de Bruijn <will...@google.com> > Signed-off-by: Jason Wang <jasow.

[PULL] vhost: cleanups and fixes

nus for you to fetch changes up to 03e9f8a05bce7330bcd9c5cc54c8e42d0fcbf993: virtio_net: fix return value check in receive_mergeable() (2017-12-07 18:34:52 +0200) virtio: bugfixes A couple of minor bugfixes. Signed-off-by: Michae

Re: [PATCH net,stable v4 0/3] vhost: fix a few skb leaks

s://www.mail-archive.com/netdev@vger.kernel.org/msg187936.html Series Acked-by: Michael S. Tsirkin <m...@redhat.com> > v4: > - fix zero iov iterator count in tap/tap_do_read()(Jason) > - don't put tun in case of EBADFD(Jason) > - Replace msg->msg_control with new 'skb' whe

Re: [PATCH net,stable v4 0/3] vhost: fix a few skb leaks

On Fri, Dec 01, 2017 at 09:54:02AM -0500, Matthew Rosato wrote: > On 12/01/2017 09:47 AM, Michael S. Tsirkin wrote: > > On Fri, Dec 01, 2017 at 05:10:35AM -0500, w...@redhat.com wrote: > >> From: Wei Xu <w...@redhat.com> > >> > >> Matthew found a roughly

Re: [PATCH 2/3] tun: free skb in early errors

freed no matter how far it can go > along, otherwise it would be leaked. > > This patch fixes several missed cases. > > Signed-off-by: Wei Xu <w...@redhat.com> > Reported-by: Matthew Rosato <mjros...@linux.vnet.ibm.com> Acked-by: Michael

Re: [PATCH 1/3] vhost: fix skb leak in handle_rx()

ro > headcount a bit ahead. > > Signed-off-by: Wei Xu <w...@redhat.com> > Reported-by: Matthew Rosato <mjros...@linux.vnet.ibm.com> Acked-by: Michael S. Tsirkin <m...@redhat.com> > --- > drivers/vhost/net.c | 20 ++-- > 1 file changed,

Re: [PATCH 3/3] tap: free skb if flags error

ld be freed within the function, otherwise > it would be leaked. > > Signed-off-by: Wei Xu <w...@redhat.com> > Reported-by: Matthew Rosato <mjros...@linux.vnet.ibm.com> Acked-by: Michael S. Tsirkin <m...@redhat.com> > --- > drivers/net/tap.c | 14 ++

Re: [PATCH 1/3] vhost: fix skb leak in handle_rx()

On Fri, Dec 01, 2017 at 03:11:05PM +0800, Jason Wang wrote: > > > On 2017年12月01日 13:54, w...@redhat.com wrote: > > From: Wei Xu > > > > Matthew found a roughly 40% tcp throughput regression with commit > > c67df11f(vhost_net: try batch dequing from skb array) as discussed > >

Re: [PATCH 2/3] tun: free skb in early errors

On Fri, Dec 01, 2017 at 03:07:44PM +0800, Jason Wang wrote: > > > On 2017年12月01日 13:54, w...@redhat.com wrote: > > From: Wei Xu > > > > tun_recvmsg() supports accepting skb by msg_control after > > commit ac77cfd4258f ("tun: support receiving skb through msg_control"), > > the

Re: [RFC] virtio-net: help live migrate SR-IOV devices

On Fri, Dec 01, 2017 at 12:08:59PM -0800, Shannon Nelson wrote: > On 11/30/2017 6:11 AM, Michael S. Tsirkin wrote: > > On Thu, Nov 30, 2017 at 10:08:45AM +0200, achiad shochat wrote: > > > Re. problem #2: > > > Indeed the best way to address it seems to be to enslave

Re: [PATCH net-next] virtio_net: Disable interrupts if napi_complete_done rescheduled napi

2 60.00 32794646 06436.49 > 212992 60.00 32793501 6436.27 > > Interrupts on guest: 4941299 > Packets/interrupt: 6.64 > > Signed-off-by: Toshiaki Makita <makita.toshi...@lab.ntt.co.jp> Acked-by: Michael S. Tsirkin <m...@redhat.com

Re: [PATCH] ptr_ring: add barriers

On Wed, Dec 06, 2017 at 10:31:39AM +0800, Jason Wang wrote: > > > On 2017年12月06日 03:29, Michael S. Tsirkin wrote: > > Users of ptr_ring expect that it's safe to give the > > data structure a pointer and have it be available > > to consumers, but that a

Re: [RFC] virtio-net: help live migrate SR-IOV devices

On Thu, Dec 07, 2017 at 08:45:33AM -0800, Alexander Duyck wrote: > As far as indicating that the interfaces are meant to be enslaved I > wonder if we couldn't look at tweaking the PCI layout of the guest and > use that to indicate that a given set of interfaces are meant to be > bonded. For

Re: [PATCH] ptr_ring: Add barriers to fix NULL-pointer exception

On Wed, Dec 06, 2017 at 02:08:54PM +, Cherian, George wrote: > > @@ -275,6 +281,13 @@ static inline void *__ptr_ring_consume(struct ptr_ring > *r) > > if (ptr) > > __ptr_ring_discard_one(r); > > > > + /* > > + * This barrier is necessary in order to prevent race condition with > > + * with

Re: [PATCH] ptr_ring: Add barriers to fix NULL-pointer exception

On Wed, Dec 06, 2017 at 09:57:41AM +, George Cherian wrote: > While running a multiple VM testscase with each VM running iperf > traffic between others the following kernel NULL pointer exception > was seen. > > Race appears when the tun driver instance of one VM calls skb_array_produce >

Re: [bpf] 3ea693a925: BUG:unable_to_handle_kernel

On Thu, Oct 26, 2017 at 12:53:23AM +0800, kernel test robot wrote: > FYI, we noticed the following commit (built with gcc-6): > > commit: 3ea693a925e14c1fc54c7d8bebe6f9fd9441b47d ("bpf: introduce new bpf cpu > map type BPF_MAP_TYPE_CPUMAP") > url: >

Re: [PATCH net-next] vhost_net: conditionally enable tx polling

On Tue, Oct 31, 2017 at 06:27:20PM +0800, Jason Wang wrote: > We always poll tx for socket, this is sub optimal since: > > - we only want to be notified when sndbuf is available > - this will slightly increase the waitqueue traversing time and more > important, vhost could not benefit from

Re: [PATCH net-next V2 3/3] tun: add eBPF based queue selection method

On Tue, Oct 31, 2017 at 06:32:18PM +0800, Jason Wang wrote: > This patch introduces an eBPF based queue selection method based on > the flow steering policy ops. Userspace could load an eBPF program > through TUNSETSTEERINGEBPF. This gives much more flexibility compare > to simple but hard coded

Re: [PATCH net] vhost: Use kzalloc() to allocate vhost_msg_node

P_KERNEL); > + struct vhost_msg_node *node = kzalloc(sizeof *node, GFP_KERNEL); > if (!node) > return NULL; > node->vq = vq; Let's just init the msg though. OK it seems this is the best we can do for now, we need a new feature bit to fix it for 32 bit us

Re: [PATCH net] vhost: Use kzalloc() to allocate vhost_msg_node

On Fri, Apr 27, 2018 at 06:11:31PM +0200, Dmitry Vyukov wrote: > On Fri, Apr 27, 2018 at 6:05 PM, Michael S. Tsirkin <m...@redhat.com> wrote: > > On Fri, Apr 27, 2018 at 11:45:02AM -0400, Kevin Easton wrote: > >> The struct vhost_msg within struct vhost_msg_node is copi

[PATCH] vhost: make msg padding explicit

There's a 32 bit hole just after type. It's best to give it a name, this way compiler is forced to initialize it with rest of the structure. Reported-by: Kevin Easton <ke...@guarana.org> Signed-off-by: Michael S. Tsirkin <m...@redhat.com> --- include/uapi/linux/vhost.h | 1 + 1 fil

Re: [PATCH net] vhost: Use kzalloc() to allocate vhost_msg_node

On Fri, Apr 27, 2018 at 11:45:02AM -0400, Kevin Easton wrote: > The struct vhost_msg within struct vhost_msg_node is copied to userspace, > so it should be allocated with kzalloc() to ensure all structure padding > is zeroed. > > Signed-off-by: Kevin Easton > Reported-by:

Re: [PATCH net] vhost: Use kzalloc() to allocate vhost_msg_node

On Fri, Apr 27, 2018 at 06:11:31PM +0200, Dmitry Vyukov wrote: > On Fri, Apr 27, 2018 at 6:05 PM, Michael S. Tsirkin <m...@redhat.com> wrote: > > On Fri, Apr 27, 2018 at 11:45:02AM -0400, Kevin Easton wrote: > >> The struct vhost_msg within struct vhost_msg_node is copi

Re: [PATCH net V2] tun: fix use after free for ptr_ring

was introduced by commit 4df0bfc79904 ("tun: fix a memory leak > for tfile->tx_array"). > > Reported-by: syzbot+e8b902c3c3fadf0a9...@syzkaller.appspotmail.com > Cc: Eric Dumazet <eric.duma...@gmail.com> > Cc: Cong Wang <xiyou.wangc...@gmail.com> > Cc: Micha

Re: [PATCH net] tun: fix use after free for ptr_ring

was introduced by commit 4df0bfc79904 ("tun: fix a memory leak > for tfile->tx_array"). > > Reported-by: syzbot+e8b902c3c3fadf0a9...@syzkaller.appspotmail.com > Cc: Eric Dumazet <eric.duma...@gmail.com> > Cc: Cong Wang <xiyou.wangc...@gmail.com> > Cc: Micha

Re: [PATCH net-next v10 2/4] net: Introduce generic failover module

On Mon, May 07, 2018 at 03:39:19PM -0700, Randy Dunlap wrote: > Hi, > > On 05/07/2018 03:10 PM, Sridhar Samudrala wrote: > > > > Signed-off-by: Sridhar Samudrala > > --- > > MAINTAINERS|7 + > > include/linux/netdevice.h | 16 + > >

Re: [PATCH net-next v10 2/4] net: Introduce generic failover module

On Mon, May 07, 2018 at 05:24:27PM -0700, Samudrala, Sridhar wrote: > > > On 5/7/2018 4:53 PM, Stephen Hemminger wrote: > > On Mon, 7 May 2018 15:10:44 -0700 > > Sridhar Samudrala wrote: > > > > > +static struct net_device *net_failover_get_bymac(u8 *mac, > > > +

Re: [PATCH net-next 2/2] pfifo_fast: drop unneeded additional lock on dequeue

On Wed, May 16, 2018 at 09:56:16AM +0200, Paolo Abeni wrote: > On Tue, 2018-05-15 at 23:17 +0300, Michael S. Tsirkin wrote: > > On Tue, May 15, 2018 at 04:24:37PM +0200, Paolo Abeni wrote: > > > After the previous patch, for NOLOCK qdiscs, q->seqlock is > > >

Re: [PATCH net-next 2/2] pfifo_fast: drop unneeded additional lock on dequeue

On Tue, May 15, 2018 at 04:24:37PM +0200, Paolo Abeni wrote: > After the previous patch, for NOLOCK qdiscs, q->seqlock is > always held when the dequeue() is invoked, we can drop > any additional locking to protect such operation. > > Signed-off-by: Paolo Abeni > --- >

Re: KASAN: use-after-free Read in vhost_chr_write_iter

On Mon, May 21, 2018 at 10:38:10AM +0800, Jason Wang wrote: > > > On 2018年05月18日 17:24, Jason Wang wrote: > > > > > > On 2018年05月17日 21:45, DaeRyong Jeong wrote: > > > We report the crash: KASAN: use-after-free Read in vhost_chr_write_iter > > > > > > This crash has been found in v4.17-rc1

Re: [PATCH net 2/4] virtio-net: correctly transmit XDP buff after linearizing

p the refcnt of original page and go for xmit path. > > Fixes: 72979a6c3590 ("virtio_net: xdp, add slowpath case for non contiguous > buffers") > Cc: John Fastabend <john.fastab...@gmail.com> > Signed-off-by: Jason Wang <jasow...@redhat.com> Acked-by: Michael S

Re: [PATCH net 1/4] virtio-net: correctly redirect linearized packet

riginal page. > > Fixes: 186b3c998c50 ("virtio-net: support XDP_REDIRECT") > Reported-by: David Ahern <dsah...@gmail.com> > Tested-by: David Ahern <dsah...@gmail.com> > Signed-off-by: Jason Wang <jasow...@redhat.com> Acked-by: Michael S. Tsirkin <m...@

Re: [PATCH net 3/4] virtio-net: reset num_buf to 1 after linearizing packet

On Mon, May 21, 2018 at 04:35:05PM +0800, Jason Wang wrote: > If we successfully linearize the packets, num_buf were set to zero > which was wrong since we now have only 1 buffer to be used for e.g in > the error path of receive_mergeable(). Zero num_buf will lead the code > try to pop the buffers

Re: [RFC PATCH net-next 12/12] vhost_net: batch submitting XDP buffers to underlayer sockets

On Mon, May 21, 2018 at 05:04:33PM +0800, Jason Wang wrote: > This patch implements XDP batching for vhost_net with tun. This is > done by batching XDP buffs in vhost and submit them when: > > - vhost_net can not build XDP buff (mostly because of the size of packet) > - #batched exceeds the

Re: [RFC PATCH net-next 06/12] tuntap: enable premmption early

On Mon, May 21, 2018 at 05:04:27PM +0800, Jason Wang wrote: > Signed-off-by: Jason Wang typo in subject > --- > drivers/net/tun.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/tun.c b/drivers/net/tun.c > index 44d4f3d..24ecd82

Re: [PATCH net 0/4] Fix several issues of virtio-net mergeable XDP

On Mon, May 21, 2018 at 04:35:02PM +0800, Jason Wang wrote: > Hi: > > Please review the patches that tries to fix sevreal issues of > virtio-net mergeable XDP. > > Thanks I think we should do 3/4 differently. The rest looks good, and probably needed on stable. Thanks! > Jason Wang (4): >

Re: [PATCH net 4/4] virito-net: fix leaking page for gso packet during mergeable XDP

On Mon, May 21, 2018 at 04:35:06PM +0800, Jason Wang wrote: > We need to drop refcnt to xdp_page if we see a gso packet. Otherwise > it will be leaked. Fixing this by moving the check of gso packet above > the linearizing logic. > > Cc: John Fastabend > Fixes:

Re: [PATCH net] tuntap: raise EPOLLOUT on device up

On Mon, May 21, 2018 at 11:47:42AM -0400, David Miller wrote: > From: Jason Wang > Date: Fri, 18 May 2018 21:00:43 +0800 > > > We return -EIO on device down but can not raise EPOLLOUT after it was > > up. This may confuse user like vhost which expects tuntap to raise > >

Re: [PATCH net] tuntap: raise EPOLLOUT on device up

On Sat, May 19, 2018 at 09:09:11AM +0800, Jason Wang wrote: > > > On 2018年05月18日 22:46, Michael S. Tsirkin wrote: > > On Fri, May 18, 2018 at 10:11:54PM +0800, Jason Wang wrote: > > > > > > On 2018年05月18日 22:06, Michael S. Tsirkin wrote: > > > > On

Re: [RFC PATCH net-next 10/12] vhost_net: build xdp buff

On Mon, May 21, 2018 at 09:56:11AM -0700, Jesse Brandeburg wrote: > On Mon, 21 May 2018 17:04:31 +0800 Jason wrote: > > This patch implement build XDP buffers in vhost_net. The idea is do > > userspace copy in vhost_net and build XDP buff based on the > > page. Vhost_net can then submit one or an

Re: Shepherd request (P83): Multipath TCP: Present Use Cases and an Upstream Future

On Tue, May 22, 2018 at 05:36:14PM +0200, Jiri Pirko wrote: > Tue, May 22, 2018 at 05:28:42PM CEST, sridhar.samudr...@intel.com wrote: > > > >On 5/22/2018 2:08 AM, Jiri Pirko wrote: > >> Tue, May 22, 2018 at 11:06:37AM CEST, j...@resnulli.us wrote: > >> > Tue, May 22, 2018 at 04:06:18AM CEST,

Re: [PATCH net-next v11 2/5] netvsc: refactor notifier/event handling code to use the failover framework

On Tue, May 22, 2018 at 05:13:43PM +0200, Jiri Pirko wrote: > Tue, May 22, 2018 at 03:39:33PM CEST, m...@redhat.com wrote: > >On Tue, May 22, 2018 at 03:26:26PM +0200, Jiri Pirko wrote: > >> Tue, May 22, 2018 at 03:17:37PM CEST, m...@redhat.com wrote: > >> >On Tue, May 22, 2018 at 03:14:22PM

Re: [PATCH net-next v11 2/5] netvsc: refactor notifier/event handling code to use the failover framework

On Tue, May 22, 2018 at 03:26:26PM +0200, Jiri Pirko wrote: > Tue, May 22, 2018 at 03:17:37PM CEST, m...@redhat.com wrote: > >On Tue, May 22, 2018 at 03:14:22PM +0200, Jiri Pirko wrote: > >> Tue, May 22, 2018 at 03:12:40PM CEST, m...@redhat.com wrote: > >> >On Tue, May 22, 2018 at 11:08:53AM

Re: [PATCH net-next v11 2/5] netvsc: refactor notifier/event handling code to use the failover framework

On Tue, May 22, 2018 at 11:08:53AM +0200, Jiri Pirko wrote: > Tue, May 22, 2018 at 11:06:37AM CEST, j...@resnulli.us wrote: > >Tue, May 22, 2018 at 04:06:18AM CEST, sridhar.samudr...@intel.com wrote: > >>Use the registration/notification framework supported by the generic > >>failover

Re: [PATCH net-next v11 2/5] netvsc: refactor notifier/event handling code to use the failover framework

On Tue, May 22, 2018 at 03:14:22PM +0200, Jiri Pirko wrote: > Tue, May 22, 2018 at 03:12:40PM CEST, m...@redhat.com wrote: > >On Tue, May 22, 2018 at 11:08:53AM +0200, Jiri Pirko wrote: > >> Tue, May 22, 2018 at 11:06:37AM CEST, j...@resnulli.us wrote: > >> >Tue, May 22, 2018 at 04:06:18AM CEST,

Re: [PATCH net-next v11 2/5] netvsc: refactor notifier/event handling code to use the failover framework

On Tue, May 22, 2018 at 05:45:01PM +0200, Jiri Pirko wrote: > Tue, May 22, 2018 at 05:32:30PM CEST, m...@redhat.com wrote: > >On Tue, May 22, 2018 at 05:13:43PM +0200, Jiri Pirko wrote: > >> Tue, May 22, 2018 at 03:39:33PM CEST, m...@redhat.com wrote: > >> >On Tue, May 22, 2018 at 03:26:26PM

Re: [PATCH net] tuntap: raise EPOLLOUT on device up

On Tue, May 22, 2018 at 11:22:11AM +0800, Jason Wang wrote: > > > On 2018年05月22日 06:08, Michael S. Tsirkin wrote: > > On Mon, May 21, 2018 at 11:47:42AM -0400, David Miller wrote: > > > From: Jason Wang <jasow...@redhat.com> > > > Date: Fri, 18 May 2018

Re: KASAN: use-after-free Read in vhost_chr_write_iter

On Tue, May 22, 2018 at 11:50:29AM +0800, Jason Wang wrote: > > > On 2018年05月21日 22:42, Michael S. Tsirkin wrote: > > On Mon, May 21, 2018 at 10:38:10AM +0800, Jason Wang wrote: > > > On 2018年05月18日 17:24, Jason Wang wrote: > > > > On 2018年05月17日 21:45, DaeRy

Re: [PATCH net] tuntap: raise EPOLLOUT on device up

On Tue, May 22, 2018 at 11:22:11AM +0800, Jason Wang wrote: > > > On 2018年05月22日 06:08, Michael S. Tsirkin wrote: > > On Mon, May 21, 2018 at 11:47:42AM -0400, David Miller wrote: > > > From: Jason Wang <jasow...@redhat.com> > > > Date: Fri, 18 May 2018

Re: [PATCH net-next v11 2/5] netvsc: refactor notifier/event handling code to use the failover framework

On Tue, May 22, 2018 at 07:38:44PM +0200, Jiri Pirko wrote: > >> >> In private > >> >> flag. I don't see no reason to break this pattern here. > >> > > >> >Other masters are setup from userspace, this one is set up automatically > >> >by kernel. So the bar is higher, we need an interface that

Re: [RFC PATCH net-next 00/12] XDP batching for TUN/vhost_net

On Mon, May 21, 2018 at 05:04:21PM +0800, Jason Wang wrote: > Hi all: > > We do not support XDP batching for TUN since it can only receive one > packet a time from vhost_net. This series tries to remove this > limitation by: > > - introduce a TUN specific msg_control that can hold a pointer to

Re: [PATCH net-next v12 0/5] Enable virtio_net to act as a standby for a passthru device

the guest to switch over to VF datapath. > > This patch is based on the discussion initiated by Jesse on this thread. > https://marc.info/?l=linux-virtualization=151189725224231=2 Series: Acked-by: Michael S. Tsirkin <m...@redhat.com> > v12: > - Tested live migration

Re: [PATCH net] vhost: synchronize IOTLB message with dev cleanup

t;vhost: new device IOTLB API") > Signed-off-by: Jason Wang <jasow...@redhat.com> We should think of a way to have a per-vq lock here, but for now: Acked-by: Michael S. Tsirkin <m...@redhat.com> > --- > drivers/vhost/vhost.c | 3 +++ > 1 file changed, 3

Re: [PATCH net] tuntap: raise EPOLLOUT on device up

On Fri, May 18, 2018 at 10:00:31PM +0800, Jason Wang wrote: > > > On 2018年05月18日 21:26, Jason Wang wrote: > > > > > > On 2018年05月18日 21:13, Michael S. Tsirkin wrote: > > > On Fri, May 18, 2018 at 09:00:43PM +0800, Jason Wang wrote: > > > >

Re: [PATCH net] tuntap: raise EPOLLOUT on device up

On Fri, May 18, 2018 at 10:11:54PM +0800, Jason Wang wrote: > > > On 2018年05月18日 22:06, Michael S. Tsirkin wrote: > > On Fri, May 18, 2018 at 10:00:31PM +0800, Jason Wang wrote: > > > > > > On 2018年05月18日 21:26, Jason Wang wrote: > > > > > >

Re: [PATCH net] tuntap: raise EPOLLOUT on device up

On Fri, May 18, 2018 at 09:00:43PM +0800, Jason Wang wrote: > We return -EIO on device down but can not raise EPOLLOUT after it was > up. This may confuse user like vhost which expects tuntap to raise > EPOLLOUT to re-enable its TX routine after tuntap is down. This could > be easily reproduced by

Re: [PATCH net] failover: eliminate callback hell

On Wed, Jun 06, 2018 at 09:25:12AM +0200, Jiri Pirko wrote: > Tue, Jun 05, 2018 at 05:42:31AM CEST, step...@networkplumber.org wrote: > >The net failover should be a simple library, not a virtual > >object with function callbacks (see callback hell). > > Why just a library? It should do a common

Re: [PATCH net] failover: eliminate callback hell

On Tue, Jun 05, 2018 at 08:51:18PM -0700, Stephen Hemminger wrote: > > I think the push back was with the usage of the delay, not bringing up the > > primary/standby > > device in the name change event handler. > > Can't netvsc use this mechanism instead of depending on the delay? > > > > > >

Re: [PATCH net] failover: eliminate callback hell

On Mon, Jun 11, 2018 at 11:56:56AM -0700, Siwei Liu wrote: > The current implementation may only work with new userspace, even so > the eth0/eth0nsby naming is not consistenly persisted due to races in > bus probing. Which race do you mean exactly? -- MST

Re: [PATCH net] failover: eliminate callback hell

On Wed, Jun 06, 2018 at 03:24:08PM -0700, Stephen Hemminger wrote: > On Thu, 7 Jun 2018 00:47:52 +0300 > "Michael S. Tsirkin" wrote: > > > On Wed, Jun 06, 2018 at 02:24:47PM -0700, Stephen Hemminger wrote: > > > On Wed, 6 Jun 2018 15:30:27 +0300

Re: [PATCH net] failover: eliminate callback hell

rala, Sridhar" wrote: > > > > > >> On 6/6/2018 2:24 PM, Stephen Hemminger wrote: > > >> > On Wed, 6 Jun 2018 15:30:27 +0300 > > >> > "Michael S. Tsirkin" wrote: > > >> > > > >> >> On Wed, Jun

Re: [PATCH net] failover: eliminate callback hell

On Fri, Jun 08, 2018 at 11:30:08AM -0700, Stephen Hemminger wrote: > * what about nested KVM on Hyper-V? Would it make sense to > have a way to pass subset of VF queues to guest? No as long as hyper-v doesn't have a vIOMMU. -- MST

Re: [PATCH net] failover: eliminate callback hell

On Thu, Jun 07, 2018 at 09:17:42AM -0700, Stephen Hemminger wrote: > On Thu, 7 Jun 2018 18:41:31 +0300 > "Michael S. Tsirkin" wrote: > > > > > Why would DPDK care what we do in the kernel? Isn't it just slapping > > > > vfio-pci on the netdevs it

Re: [PATCH net] failover: eliminate callback hell

On Mon, Jun 04, 2018 at 08:42:31PM -0700, Stephen Hemminger wrote: > * Set permanent and current address of net_failover device > to match the primary. > > * Carrier should be marked off before registering device > the net_failover device. Sridhar, do we want to address this? If yes,

Re: [PATCH net] failover: eliminate callback hell

On Wed, Jun 06, 2018 at 03:21:21PM -0700, Stephen Hemminger wrote: > > > > > > I think you need to get rid of triggering off of the name change. > > > > Worth considering down the road since it's a bit of a hack but it's one > > we won't have trouble supporting, unlike the delayed uplink. > >

Re: [PATCH net] failover: eliminate callback hell

; > > > > >> On Wed, Jun 6, 2018 at 2:24 PM, Stephen Hemminger > > >> wrote: > > >> > On Wed, 6 Jun 2018 15:30:27 +0300 > > >> > "Michael S. Tsirkin" wrote: > > >> > > > >> >> On Wed, Jun

Re: [PATCH net] failover: eliminate callback hell

Thanks, I think this is nice patch but I wonder whether it can be split up somewhat. Not all of it is uncontroversial. On Mon, Jun 04, 2018 at 08:42:31PM -0700, Stephen Hemminger wrote: > * The matching of secondary device to primary device policy > is up to the network device. Both

Re: [PATCH net] failover: eliminate callback hell

On Tue, Jun 05, 2018 at 11:53:05AM -0700, Stephen Hemminger wrote: > > > * Now, netvsc and net_failover use the same delayed work type > > > mechanism for setup. Previously, net_failover code was triggering off > > > name change but a similar policy was rejected for netvsc. > > >

Re: [PATCH net] failover: eliminate callback hell

dhar" wrote: > > > > > >> On 6/5/2018 8:51 PM, Stephen Hemminger wrote: > > >>> On Tue, 5 Jun 2018 16:52:22 -0700 > > >>> "Samudrala, Sridhar" wrote: > > >>> > > >>>> On 6/5/2018 2:52

Re: [PATCH net] failover: eliminate callback hell

On Wed, Jun 06, 2018 at 02:24:47PM -0700, Stephen Hemminger wrote: > On Wed, 6 Jun 2018 15:30:27 +0300 > "Michael S. Tsirkin" wrote: > > > On Wed, Jun 06, 2018 at 09:25:12AM +0200, Jiri Pirko wrote: > > > Tue, Jun 05, 2018 at 05:42:31AM CEST, step...@networkp

Re: [PATCH] vhost: make msg padding explicit

On Tue, May 01, 2018 at 11:28:22AM -0400, David Miller wrote: > From: "Michael S. Tsirkin" <m...@redhat.com> > Date: Fri, 27 Apr 2018 19:02:05 +0300 > > > There's a 32 bit hole just after type. It's best to > > give it a name, this way compiler is

Re: [PATCH V2 net-next 5/6] macvlan/macvtap: Add support for SCTP checksum offload.

On Tue, May 01, 2018 at 10:07:38PM -0400, Vladislav Yasevich wrote: > Since we now have support for software CRC32c offload, turn it on > for macvlan and macvtap devices so that guests can take advantage > of offload SCTP checksums to the host or host hardware. > > Signed-off-by: Vladislav

Re: [PATCH V2 net-next 1/6] virtio: Add support for SCTP checksum offloading

On Tue, May 01, 2018 at 10:07:34PM -0400, Vladislav Yasevich wrote: > To support SCTP checksum offloading, we need to add a new feature > to virtio_net, so we can negotiate support between the hypervisor > and the guest. > The HOST feature bit signifies offloading support for transmit and >

Re: [PATCH] vhost: make msg padding explicit

On Wed, May 02, 2018 at 02:28:09AM -0400, Kevin Easton wrote: > On Tue, May 01, 2018 at 02:05:51PM -0400, David Miller wrote: > > From: "Michael S. Tsirkin" <m...@redhat.com> > > Date: Tue, 1 May 2018 20:19:19 +0300 > > > > > On Tue, May 01

Re: [PATCH V2 net-next 5/6] macvlan/macvtap: Add support for SCTP checksum offload.

On Wed, May 02, 2018 at 09:27:00AM -0400, Vlad Yasevich wrote: > On 05/01/2018 11:24 PM, Michael S. Tsirkin wrote: > > On Tue, May 01, 2018 at 10:07:38PM -0400, Vladislav Yasevich wrote: > >> Since we now have support for software CRC32c offload, turn it on > >> for mac

Re: [RFC v3 4/5] virtio_ring: add event idx support in packed ring

On Wed, May 02, 2018 at 03:28:19PM +0800, Tiwei Bie wrote: > On Wed, May 02, 2018 at 10:51:06AM +0800, Jason Wang wrote: > > On 2018年04月25日 13:15, Tiwei Bie wrote: > > > This commit introduces the event idx support in packed > > > ring. This feature is temporarily disabled, because the > > >

Re: [PATCH V2 net-next 1/6] virtio: Add support for SCTP checksum offloading

On Wed, May 02, 2018 at 11:14:13AM -0300, Marcelo Ricardo Leitner wrote: > On Wed, May 02, 2018 at 06:16:45AM +0300, Michael S. Tsirkin wrote: > > On Tue, May 01, 2018 at 10:07:34PM -0400, Vladislav Yasevich wrote: > > > To support SCTP checksum offloading, we need to

Re: [PATCH] vhost: make msg padding explicit

On Wed, May 02, 2018 at 10:04:46AM -0400, David Miller wrote: > From: "Michael S. Tsirkin" <m...@redhat.com> > Date: Wed, 2 May 2018 16:36:37 +0300 > > > Ouch. True - and in particular the 32 bit ABI on 64 bit kernels doesn't > > work at all. Hmm. It's rela

Re: [PATCH V2 net-next 5/6] macvlan/macvtap: Add support for SCTP checksum offload.

On Wed, May 02, 2018 at 10:00:14AM -0400, Vlad Yasevich wrote: > On 05/02/2018 09:46 AM, Michael S. Tsirkin wrote: > > On Wed, May 02, 2018 at 09:27:00AM -0400, Vlad Yasevich wrote: > >> On 05/01/2018 11:24 PM, Michael S. Tsirkin wrote: > >>> On Tue, May 01, 2018

Re: [RFC v3 4/5] virtio_ring: add event idx support in packed ring

On Wed, May 02, 2018 at 11:12:55PM +0800, Tiwei Bie wrote: > On Wed, May 02, 2018 at 04:51:01PM +0300, Michael S. Tsirkin wrote: > > On Wed, May 02, 2018 at 03:28:19PM +0800, Tiwei Bie wrote: > > > On Wed, May 02, 2018 at 10:51:06AM +0800, Jason Wang wrote: > > > > O

[PATCH] Revert "vhost: make msg padding explicit"

This reverts commit 93c0d549c4c5a7382ad70de6b86610b7aae57406. Unfortunately the padding will break 32 bit userspace. Ouch. Need to add some compat code, revert for now. Signed-off-by: Michael S. Tsirkin <m...@redhat.com> --- include/uapi/linux/vhost.h | 1 - 1 file changed, 1 deletion(-)

Re: [PATCH net-next v9 3/4] virtio_net: Extend virtio to use VF datapath when available

On Wed, May 02, 2018 at 09:50:21AM +0200, Jiri Pirko wrote: > Wed, May 02, 2018 at 02:20:26AM CEST, sridhar.samudr...@intel.com wrote: > >On 4/30/2018 12:20 AM, Jiri Pirko wrote: > >> > >> > > Now I try to change mac of the failover master: > >> > > [root@test1 ~]# ip link set ens3 addr

Re: [PATCH net-next v9 2/4] net: Introduce generic failover module

On Wed, May 02, 2018 at 10:51:12AM -0700, Samudrala, Sridhar wrote: > > > On 5/2/2018 9:15 AM, Jiri Pirko wrote: > > Sat, Apr 28, 2018 at 11:06:01AM CEST, j...@resnulli.us wrote: > > > Fri, Apr 27, 2018 at 07:06:58PM CEST, sridhar.samudr...@intel.com wrote: > > [...] > > > > > > > > + > > > >

Re: [RFC v3 4/5] virtio_ring: add event idx support in packed ring

On Thu, May 03, 2018 at 09:11:16AM +0800, Tiwei Bie wrote: > On Wed, May 02, 2018 at 06:42:57PM +0300, Michael S. Tsirkin wrote: > > On Wed, May 02, 2018 at 11:12:55PM +0800, Tiwei Bie wrote: > > > On Wed, May 02, 2018 at 04:51:01PM +0300, Michael S. Tsirkin wrote: > >

Re: [dm-devel] [PATCH v5] fault-injection: introduce kvmalloc fallback options

On Thu, Apr 26, 2018 at 12:07:25PM -0400, Mikulas Patocka wrote: > > IIUC debug kernels mainly exist so people who experience e.g. memory > > corruption can try and debug the failure. In this case, CONFIG_DEBUG_SG > > will *already* catch a failure early. Nothing special needs to be done. > > The

Re: [dm-devel] [PATCH v5] fault-injection: introduce kvmalloc fallback options

On Thu, Apr 26, 2018 at 02:58:08PM -0400, Mikulas Patocka wrote: > > > On Thu, 26 Apr 2018, Michael S. Tsirkin wrote: > > > How do you make sure QA tests a specific corner case? Add it to > > the test plan :) > > BTW. how many "lines of code" of corporat

Re: [dm-devel] [PATCH v5] fault-injection: introduce kvmalloc fallback options

On Thu, Apr 26, 2018 at 11:44:21AM -0400, Mikulas Patocka wrote: > > > On Thu, 26 Apr 2018, James Bottomley wrote: > > > On Thu, 2018-04-26 at 11:05 -0400, Mikulas Patocka wrote: > > > > > > On Thu, 26 Apr 2018, James Bottomley wrote: > > [...] > > > > Perhaps find out beforehand instead of

Re: [PATCH v7 net-next 4/4] netvsc: refactor notifier/event handling code to use the failover framework

On Wed, Apr 25, 2018 at 03:57:57PM -0700, Siwei Liu wrote: > On Wed, Apr 25, 2018 at 3:22 PM, Michael S. Tsirkin <m...@redhat.com> wrote: > > On Wed, Apr 25, 2018 at 02:38:57PM -0700, Siwei Liu wrote: > >> On Mon, Apr 23, 2018 at 1:06 PM, Michael S. Tsirkin <m

Re: [PATCH net-next v8 4/4] netvsc: refactor notifier/event handling code to use the failover framework

On Wed, Apr 25, 2018 at 05:08:37PM -0700, Stephen Hemminger wrote: > On Wed, 25 Apr 2018 16:59:28 -0700 > Sridhar Samudrala wrote: > > > Use the registration/notification framework supported by the generic > > failover infrastructure. > > > > Signed-off-by: Sridhar

Re: [PATCH v7 net-next 4/4] netvsc: refactor notifier/event handling code to use the failover framework

On Wed, Apr 25, 2018 at 05:18:31PM -0700, Stephen Hemminger wrote: > On Wed, 25 Apr 2018 15:57:57 -0700 > Siwei Liu wrote: > > > > > > > I think ideally the infrastructure should suppport flexible matching of > > > NICs - netvsc is already reported to be moving to some kind

<    3   4   5   6   7   8   9   10   11   >