Re: [PATCH iproute2-next 1/9] libnetlink: Set NLA_F_NESTED in rta_nest

2019-05-30 Thread Michal Kubecek
On Thu, May 30, 2019 at 11:50:59AM -0600, David Ahern wrote: > On 5/30/19 11:43 AM, Stephen Hemminger wrote: > > > > I assume older kernels ignore the attribute? > > > > Also, how is this opt-in for running iproute2-next on old kernels? > > from what I can see older kernel added the flag when ge

Re: [PATCH V1 net-next 02/11] net: ena: ethtool: add extra properties retrieval via get_priv_flags

2019-05-31 Thread Michal Kubecek
n (which happened once on init) each time userspace makes ETHTOOL_GSTRINGS request for private flags. > + > + for (i = 0; i < adapter->ena_extra_properties_count; i++) { > + snprintf(data, ETH_GSTRING_LEN, "%s", > + strings + ENA_ADMIN_EXTRA_PROPERTIES_STRING_LEN * i); snprintf() is a bit overkill here, what you are doing is rather strlcpy() or strscpy(). Or maybe strncpy() as strings returned by ->get_strings() do not have to be null terminated. > + data += ETH_GSTRING_LEN; > + } > +} Michal Kubecek

Re: [PATCH 2/2] ethtool: Add 100BaseT1 and 1000BaseT1 link modes

2019-05-31 Thread Michal Kubecek
On Thu, May 30, 2019 at 08:06:16PM +0200, Andrew Lunn wrote: > The kernel can now indicate if the PHY supports operating over a > single pair at 100Mbps or 1000Mbps. > > Signed-off-by: Andrew Lunn > --- > ethtool.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/ethtool.c b/ethto

Re: [PATCH v2 2/2] ethtool: Add 100BaseT1 and 1000BaseT1 link modes

2019-05-31 Thread Michal Kubecek
On Fri, May 31, 2019 at 03:57:48PM +0200, Andrew Lunn wrote: > The kernel can now indicate if the PHY supports operating over a > single pair at 100Mbps or 1000Mbps. > > Signed-off-by: Andrew Lunn > --- Reviewed-by: Michal Kubecek > ethtool.8.in | 2 ++ > ethtool.c

Re: [PATCH v2 1/2] ethtool: sync ethtool-copy.h with linux-next from 30/05/2019

2019-05-31 Thread Michal Kubecek
On Fri, May 31, 2019 at 03:57:47PM +0200, Andrew Lunn wrote: > Sync ethtool-copy.h with linux-next from 22/05/2019. This provides > access to the new link modes for 100BaseT1 and 1000BaseT1. > > Signed-off-by: Andrew Lunn > --- Reviewed-by: Michal Kubecek BtW, this differs from

Re: [PATCH V1 net-next 02/11] net: ena: ethtool: add extra properties retrieval via get_priv_flags

2019-05-31 Thread Michal Kubecek
On Fri, May 31, 2019 at 09:57:51PM +, Machulsky, Zorik wrote: > > > > +int ena_com_extra_properties_strings_init(struct ena_com_dev *ena_dev) > > +{ > > + struct ena_admin_get_feat_resp resp; > > + struct ena_extra_properties_strings *extra_properties_strings =

Re: [PATCH net] ethtool: fix potential userspace buffer overflow

2019-06-03 Thread Michal Kubecek
On Fri, May 31, 2019 at 07:12:21PM -0400, Vivien Didelot wrote: > ethtool_get_regs() allocates a buffer of size ops->get_regs_len(), > and pass it to the kernel driver via ops->get_regs() for filling. > > There is no restriction about what the kernel drivers can or cannot do > with the open ethtoo

Re: [PATCH net] ethtool: fix potential userspace buffer overflow

2019-06-03 Thread Michal Kubecek
On Mon, Jun 03, 2019 at 01:42:19PM -0400, Vivien Didelot wrote: > Hi Michal, > > On Mon, 3 Jun 2019 19:15:12 +0200, Michal Kubecek wrote: > > On Fri, May 31, 2019 at 07:12:21PM -0400, Vivien Didelot wrote: > > > ethtool_get_regs() allocates a buffer of size ops->get_re

Re: [PATCH net v2] ethtool: fix potential userspace buffer overflow

2019-06-05 Thread Michal Kubecek
en(). > > While at it, remove the redundant check for non-null regbuf. > > Signed-off-by: Vivien Didelot Reviewed-by: Michal Kubecek I believe we should also unify returned regs.len value as discussed before. While the easiest way to do that would be copying regs.len to reglen uncodit

Re: [PATCH V1 net-next 5/6] net: ena: add ethtool function for changing io queue sizes

2019-06-06 Thread Michal Kubecek
RING_SIZE, > + adapter->max_rx_ring_size); > + new_rx_size = rounddown_pow_of_two(new_rx_size); For the same reason, clamping from below would suffice here. Michal Kubecek > + > + if (new_tx_size == adapter->requested_tx_ring_size && > + new_rx_size == adapter->requested_rx_ring_size) > + return 0; > + > + return ena_update_queue_sizes(adapter, new_tx_size, new_rx_size); > +}

Re: [PATCH V1 net-next 5/6] net: ena: add ethtool function for changing io queue sizes

2019-06-06 Thread Michal Kubecek
t_io_rings(adapter); > + return dev_up ? ena_up(adapter) : 0; > +} This function is called with u32 values as arguments by its only caller and copies them into u32 members of struct ena_adapter. Why are its arguments new_tx_size and new_rx_size declared as int? Michal Kubecek

Re: [PATCH V1 net-next 5/6] net: ena: add ethtool function for changing io queue sizes

2019-06-10 Thread Michal Kubecek
On Mon, Jun 10, 2019 at 07:46:08AM +, Jubran, Samih wrote: > > -Original Message- > > From: Michal Kubecek > > Sent: Thursday, June 6, 2019 5:48 PM > > To: netdev@vger.kernel.org > > Cc: Jubran, Samih ; da...@davemloft.net; > > Woodhouse, David

Re: [PATCH] ethtool: igb: dump RR2DCDELAY register

2019-07-15 Thread Michal Kubecek
On Mon, Jul 15, 2019 at 09:52:28AM +0300, Artem Bityutskiy wrote: > Decode 'RR2DCDELAY' register which Linux kernel provides starting from version > 5.3. The corresponding commit in the Linux kernel is: > cd502a7f7c9c igb: add RR2DCDELAY to ethtool registers dump > > The RR2DCDELAY register is

Re: [PATCH v2] ethtool: igb: dump RR2DCDELAY register

2019-07-15 Thread Michal Kubecek
+ fprintf(stdout, > + "0x05BF4: RR2DCDELAY (Max. DMA read delay) > 0x%08X\n", > + regs_buff[739]); > + > return 0; > } > Reviewed-by: Michal Kubecek

[PATCH ethtool] gitignore: ignore vim swapfiles and patches

2019-07-29 Thread Michal Kubecek
The .*.swp files are created by vim to hold the undo/redo log. Add them to .gitignore to prevent "git status" or "git gui" from showing them whenever some file is open in editor. Add also *.patch to hide patches created by e.g. "git format-patch". Signed-off-by: M

Re: [PATCH ethtool] ethtool: dump nested registers

2019-08-05 Thread Michal Kubecek
return dump_regs(gregs_dump_raw, gregs_dump_hex, info, regs); > + } > + > return 0; > } > For raw and hex dumps, this will dump only the payloads without any metadata allowing to identify what are the additional blocks for the other related objects, i.e. where they start, how long they are and what they belong to. That doesn't seem very useful. Michal Kubecek

Re: [PATCH ethtool] ethtool: dump nested registers

2019-08-05 Thread Michal Kubecek
On Mon, Aug 05, 2019 at 10:52:16AM -0400, Vivien Didelot wrote: > Hi Michal! > > On Mon, 5 Aug 2019 10:04:48 +0200, Michal Kubecek wrote: > > On Fri, Aug 02, 2019 at 03:34:54PM -0400, Vivien Didelot wrote: > > > Usually kernel drivers set the regs->len value to th

Re: [patch net-next rfc 3/7] net: rtnetlink: add commands to add and delete alternative ifnames

2019-08-09 Thread Michal Kubecek
On Fri, Aug 09, 2019 at 08:40:25AM -0700, Roopa Prabhu wrote: > to that point, I am also not sure why we have a new API For multiple > names. I mean why support more than two names (existing old name and > a new name to remove the length limitation) ? One use case is to allow "predictable names"

Re: [PATCH ethtool] ethtool: dump nested registers

2019-08-09 Thread Michal Kubecek
On Fri, Aug 09, 2019 at 12:23:36PM -0400, John W. Linville wrote: > On Fri, Aug 02, 2019 at 03:34:54PM -0400, Vivien Didelot wrote: > > Usually kernel drivers set the regs->len value to the same length as > > info->regdump_len, which was used for the allocation. In case where > > regs->len is small

Re: [patch net-next rfc 3/7] net: rtnetlink: add commands to add and delete alternative ifnames

2019-08-10 Thread Michal Kubecek
On Sat, Aug 10, 2019 at 06:46:57AM -0700, Roopa Prabhu wrote: > On Fri, Aug 9, 2019 at 8:46 AM Michal Kubecek wrote: > > > > On Fri, Aug 09, 2019 at 08:40:25AM -0700, Roopa Prabhu wrote: > > > to that point, I am also not sure why we have a new API For multiple > &g

Re: [patch net-next rfc 3/7] net: rtnetlink: add commands to add and delete alternative ifnames

2019-08-11 Thread Michal Kubecek
On Sat, Aug 10, 2019 at 12:39:31PM -0700, Roopa Prabhu wrote: > On Sat, Aug 10, 2019 at 8:50 AM Michal Kubecek wrote: > > > > On Sat, Aug 10, 2019 at 06:46:57AM -0700, Roopa Prabhu wrote: > > > On Fri, Aug 9, 2019 at 8:46 AM Michal Kubecek wrote: > > > > &

Re: [patch net-next rfc 3/7] net: rtnetlink: add commands to add and delete alternative ifnames

2019-08-12 Thread Michal Kubecek
On Mon, Aug 12, 2019 at 08:21:31AM -0700, Roopa Prabhu wrote: > On Sun, Aug 11, 2019 at 3:10 PM Michal Kubecek wrote: > > > > Not all of them are hardware based, there are also links based on > > filesystem label or UUID. But my point is rather that udev creates > > mu

Re: [PATCH iproute2] iplink: work around rtattr length limits for IFLA_VFINFO_LIST

2021-01-16 Thread Michal Kubecek
On Fri, Jan 15, 2021 at 03:53:25PM -0800, Jakub Kicinski wrote: > On Fri, 15 Jan 2021 14:59:50 -0800 Edwin Peer wrote: > > The maximum possible length of an RTNL attribute is 64KB, but the > > nested VFINFO list exceeds this for more than about 220 VFs (each VF > > consumes approximately 300 bytes,

Re: [PATCH iproute2] iplink: work around rtattr length limits for IFLA_VFINFO_LIST

2021-01-18 Thread Michal Kubecek
On Mon, Jan 18, 2021 at 10:20:35AM -0800, Edwin Peer wrote: > On Mon, Jan 18, 2021 at 9:49 AM David Ahern wrote: > > > Different bug, different solution required. The networking stack hits > > these kind of scalability problems from time to time with original > > uapis, so workarounds are needed.

Re: [PATCH ethtool] ethtool: do_sset return correct value on fail

2020-12-14 Thread Michal Kubecek
On Sun, Dec 13, 2020 at 04:25:03PM +0200, Tariq Toukan wrote: > From: Roy Novich > > The return value for do_sset was constant and returned 0. > This value is misleading when returned on operation failure. > Changed return value to the correct function err status. > > Fixes: 32c8037055f5 ("Initi

[PATCH net] ethtool: fix string set id check

2020-12-14 Thread Michal Kubecek
tring sets with STRSET_GET request") Reported-by: syzbot+96523fb438937cd01...@syzkaller.appspotmail.com Signed-off-by: Michal Kubecek --- net/ethtool/strset.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ethtool/strset.c b/net/ethtool/strset.c index 0baad0ce1832..c3

Re: [PATCH net] ethtool: fix error paths in ethnl_set_channels()

2020-12-15 Thread Michal Kubecek
On Tue, Dec 15, 2020 at 10:08:10AM +0100, Ivan Vecera wrote: > Fix two error paths in ethnl_set_channels() to avoid lock-up caused > but unreleased RTNL. > > Fixes: e19c591eafad ("ethtool: set device channel counts with CHANNELS_SET > request") > Cc: Michal Kub

ethtool 5.10 released

2020-12-16 Thread Michal Kubecek
Hello, ethtool 5.10 has been released. Home page: https://www.kernel.org/pub/software/network/ethtool/ Download link: https://www.kernel.org/pub/software/network/ethtool/ethtool-5.10.tar.xz Release notes: * Feature: infrastructure for JSON output * Feature: separate FLAGS in -h

Re: [PATCH iproute2-next 0/5] iproute2: add libbpf support

2020-11-30 Thread Michal Kubecek
dn't go in right now in the > development cycle anyway, all features for 5.10 had to be in linux-next > before 5.9 was released. >From the context, I believe Stephen meant merging into iproute2 5.10, not kernel. Michal Kubecek

Re: [PATCH v2] net/af_unix: don't create a path for a binded socket

2020-12-01 Thread Michal Kubecek
On Mon, Nov 30, 2020 at 05:30:00PM -0800, Jakub Kicinski wrote: > On Mon, 30 Nov 2020 16:27:47 +0300 Denis Kirjanov wrote: > > in the case of the socket which is bound to an adress ^ address > > there is no sense to create a path in the next attem

Re: LRO: creating vlan subports affects parent port's LRO settings

2020-12-06 Thread Michal Kubecek
On Sat, Dec 05, 2020 at 07:04:06PM -0500, Jarod Wilson wrote: > On Mon, Nov 23, 2020 at 7:27 PM Jakub Kicinski wrote: > > > > On Thu, 19 Nov 2020 20:37:27 -0500 Limin Wang wrote: > > > Under relatively recent kernels (v4.4+), creating a vlan subport on a > > > LRO supported parent NIC may turn LRO

Re: [PATCH ethtool v2] Improve error message when SFP module is missing

2020-12-06 Thread Michal Kubecek
On Wed, Dec 02, 2020 at 07:22:14PM +0200, Baruch Siach wrote: > ETHTOOL_GMODULEINFO request success indicates that SFP cage is present. > Failure of ETHTOOL_GMODULEEEPROM is most likely because SFP module is > not plugged in. Add an indication to the user as to what might be the > reason for the fa

Re: [PATCH net-next v1 1/9] ethtool: Add support for configuring frame preemption

2020-12-07 Thread Michal Kubecek
On Mon, Dec 07, 2020 at 02:11:48PM -0800, Vinicius Costa Gomes wrote: > Jakub Kicinski writes: > >> + * @min_frag_size_mult: Minimum size for all non-final fragment size, > >> + * expressed in terms of X in '(1 + X)*64 + 4' > > > > Is this way of expressing the min frag size from the standard? > >

[PATCH net] ethtool: fix stack overflow in ethnl_parse_bitset()

2020-12-08 Thread Michal Kubecek
recognize), we also need to cap change_bits to nbits so that we don't try to write past the prepared bitmaps. Fixes: 88db6d1e4f62 ("ethtool: add ethnl_parse_bitset() helper") Reported-by: syzbot+9d39fa49d4df294aa...@syzkaller.appspotmail.com Signed-off-by: Michal Kubecek --- net/e

Re: [RFC net-next 1/2] ethtool: add support for controling the type of adaptive coalescing

2020-11-19 Thread Michal Kubecek
On Thu, Nov 19, 2020 at 05:15:57AM +0100, Andrew Lunn wrote: > > diff --git a/include/uapi/linux/ethtool_netlink.h > > b/include/uapi/linux/ethtool_netlink.h > > index e2bf36e..e3458d9 100644 > > --- a/include/uapi/linux/ethtool_netlink.h > > +++ b/include/uapi/linux/ethtool_netlink.h > > @@ -366,

Re: [RFC net-next 1/2] ethtool: add support for controling the type of adaptive coalescing

2020-11-19 Thread Michal Kubecek
On Thu, Nov 19, 2020 at 04:56:42PM +0800, tanhuazhong wrote: > On 2020/11/19 12:15, Andrew Lunn wrote: > > > diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h > > > index 9ca87bc..afd8de2 100644 > > > --- a/include/uapi/linux/ethtool.h > > > +++ b/include/uapi/linux/ethtool.h

Re: [RFC net-next 1/2] ethtool: add support for controling the type of adaptive coalescing

2020-11-19 Thread Michal Kubecek
On Fri, Nov 20, 2020 at 10:59:59AM +0800, tanhuazhong wrote: > On 2020/11/20 6:02, Michal Kubecek wrote: > > > > We could use a similar approach as struct ethtool_link_ksettings, e.g. > > > > struct kernel_ethtool_coalesce { > >

Re: [RFC net-next 1/2] ethtool: add support for controling the type of adaptive coalescing

2020-11-20 Thread Michal Kubecek
On Fri, Nov 20, 2020 at 02:39:38PM +0100, Andrew Lunn wrote: > On Fri, Nov 20, 2020 at 08:23:22AM +0100, Michal Kubecek wrote: > > On Fri, Nov 20, 2020 at 10:59:59AM +0800, tanhuazhong wrote: > > > On 2020/11/20 6:02, Michal Kubecek wrote: > > > > > > > >

Re: [PATCH net-next 1/6] ethtool: Extend link modes settings uAPI with lanes

2020-11-24 Thread Michal Kubecek
On Mon, Nov 23, 2020 at 09:47:53AM +, Danielle Ratson wrote: > > > > -Original Message- > > From: Michal Kubecek > > Sent: Thursday, October 22, 2020 7:28 PM > > To: Danielle Ratson > > Cc: Jiri Pirko ; Andrew Lunn ; Jakub > > Kicinski ;

Re: [PATCH net-next 1/6] ethtool: Extend link modes settings uAPI with lanes

2020-11-26 Thread Michal Kubecek
On Wed, Nov 25, 2020 at 10:35:35AM +, Danielle Ratson wrote: > > > What do you think of passing the link modes you have suggested as a > > > bitmask, similar to "supported", that contains only one positive bit? > > > Something like that: > > Hi Michal, > > Thanks for your response. > > Actua

[PATCH ethtool 0/2] netlink: data lifetime error fixes

2020-11-09 Thread Michal Kubecek
Fixes of two data lifetime bugs found by testing with valgrind: one use after free, one memory leak. Michal Kubecek (2): netlink: fix use after free in netlink_run_handler() netlink: fix leaked instances of struct nl_socket netlink/netlink.c | 21 +++-- netlink/nlsock.c

[PATCH ethtool 1/2] netlink: fix use after free in netlink_run_handler()

2020-11-09 Thread Michal Kubecek
ecide about fallback") Signed-off-by: Michal Kubecek --- netlink/netlink.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/netlink/netlink.c b/netlink/netlink.c index f655f6ea25b7..bdd3048e 100644 --- a/netlink/netlink.c +++ b/netlink/netlink.c @@ -45

[PATCH ethtool 2/2] netlink: fix leaked instances of struct nl_socket

2020-11-09 Thread Michal Kubecek
to by struct nl_context members. Fixes: 50efb3cdd2bb ("netlink: netlink socket wrapper and helpers") Fixes: 87307c30724d ("netlink: initialize ethtool netlink socket") Fixes: 7f3585b22a4b ("netlink: add handler for permaddr (-P)") Signed-off-by: Michal K

[PATCH ethtool 2/2] ethtool: Improve compatibility between netlink and ioctl interfaces

2020-11-09 Thread Michal Kubecek
ransceiver: internal MDI-X: on (auto) Supports Wake-on: umbg Wake-on: d Current message level: 0x0007 (7) drv probe link Link detected: yes Signed-off-by: Ido Schimmel Signed-off-by: Michal Kubecek --- net

[PATCH ethtool 1/2] netlink: do not send messages and process replies in nl_parser()

2020-11-09 Thread Michal Kubecek
. Signed-off-by: Michal Kubecek --- netlink/cable_test.c | 2 +- netlink/channels.c | 2 +- netlink/coalesce.c | 2 +- netlink/eee.c| 2 +- netlink/parser.c | 43 --- netlink/parser.h | 3 ++- netlink/pause.c | 2 +- netlink

[PATCH ethtool 0/2] netlink: improve compatibility with ioctl interface

2020-11-09 Thread Michal Kubecek
tch cleans up the parser interface; it allows nl_sset() to inspect the composed message and append an attribute to it if needed. Ido Schimmel (1): ethtool: Improve compatibility between netlink and ioctl interfaces Michal Kubecek (1): netlink: do not send messages and process replies in

Re: [PATCH v2 net] ethtool: netlink: add missing netdev_features_change() call

2020-11-09 Thread Michal Kubecek
netdev features with FEATURES_SET request") > Signed-off-by: Alexander Lobakin Reviewed-by: Michal Kubecek > --- > net/ethtool/features.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/ethtool/features.c b/net/ethtool/features.c > index 8e

Re: [PATCH net-next 1/1] netdevsim: support ethtool ring and coalesce settings

2020-11-13 Thread Michal Kubecek
On Thu, Nov 12, 2020 at 04:12:29PM +0100, Antonio Cardace wrote: > Add ethtool ring and coalesce settings support for testing. > > Signed-off-by: Antonio Cardace > --- > drivers/net/netdevsim/ethtool.c | 65 +++ > drivers/net/netdevsim/netdevsim.h | 9 - > 2 fi

Re: [PATCH net-next v3 1/4] ethtool: add ETHTOOL_COALESCE_ALL_PARAMS define

2020-11-16 Thread Michal Kubecek
On Sat, Nov 14, 2020 at 12:16:52AM +0100, Antonio Cardace wrote: > This bitmask represents all existing coalesce parameters. > > Signed-off-by: Antonio Cardace Reviewed-by: Michal Kubecek > --- > include/linux/ethtool.h | 1 + > 1 file changed, 1 insertion(+) > > di

Re: [PATCH net-next v3 2/4] netdevsim: support ethtool ring and coalesce settings

2020-11-16 Thread Michal Kubecek
On Sat, Nov 14, 2020 at 12:16:53AM +0100, Antonio Cardace wrote: > Add ethtool ring and coalesce settings support for testing. > > Signed-off-by: Antonio Cardace Reviewed-by: Michal Kubecek signature.asc Description: PGP signature

Re: [PATCH net-next v3 3/4] selftests: extract common functions in ethtool-common.sh

2020-11-16 Thread Michal Kubecek
On Sat, Nov 14, 2020 at 12:16:54AM +0100, Antonio Cardace wrote: > Factor out some useful functions so that they can be reused > by other ethtool-netdevsim scripts. > > Signed-off-by: Antonio Cardace Reviewed-by: Michal Kubecek Just one comment: [...] > +function

Re: [PATCH net-next v4 5/6] selftests: refactor get_netdev_name function

2020-11-17 Thread Michal Kubecek
On Tue, Nov 17, 2020 at 04:20:14PM +0100, Antonio Cardace wrote: > As pointed out by Michal Kubecek, getting the name > with the previous approach was racy, it's better > and easier to get the name of the device with this > patch's approach. > > Essentialy the fu

Re: "ethtool" missing "master-slave" args in "do_sset" function.[TEXT/PLAIN]

2020-12-27 Thread Michal Kubecek
On Sun, Dec 27, 2020 at 12:34:09PM +0800, Bruce LIU wrote: > Hi Michal Kubecek and Network dev team, > > Good day! Hope you are doing well. > This is Bruce from China, and please allow me to cc Rudy from Cisco Systems > in China team. > > We are facing a weird behavio

regression in iwlwifi: page fault in iwl_dbg_tlv_alloc_region() (commit ba8f6f4ae254)

2020-12-28 Thread Michal Kubecek
FYI, there is a regression in iwlwifi driver caused by commit ba8f6f4ae254 ("iwlwifi: dbg: add dumping special device memory") reported at https://bugzilla.kernel.org/show_bug.cgi?id=210733 https://bugzilla.suse.com/show_bug.cgi?id=1180344 The problem seems to be an attempt to write terminati

Re: [PATCH net-next 1/6] ethtool: Extend link modes settings uAPI with lanes

2020-10-19 Thread Michal Kubecek
On Mon, Oct 19, 2020 at 07:19:34AM +, Danielle Ratson wrote: > > -Original Message- > > From: Andrew Lunn > > Sent: Saturday, October 17, 2020 1:16 AM > > > > I'm not sure i fully understand all these different link modes, but > > i thought these 5 are all 100G using 2 lanes? So why c

Re: [PATCH ethtool v3 0/7] pause frame stats

2020-10-19 Thread Michal Kubecek
On Sun, Oct 18, 2020 at 02:31:44PM -0700, Jakub Kicinski wrote: > Hi! > > Sorry about the delay from v2. Actually, I'm rather surprised you were able to get back to this so early, given the situation. > This set adds support for pause frame statistics. > > First pause frame info is extended to

Re: [PATCH net-next 1/6] ethtool: Extend link modes settings uAPI with lanes

2020-10-19 Thread Michal Kubecek
On Mon, Oct 19, 2020 at 02:26:43PM +0200, Jiri Pirko wrote: > Mon, Oct 19, 2020 at 01:04:22PM CEST, mkube...@suse.cz wrote: > > > >It would be quite easy to extend the ethtool command line parser to > >allow also > > > > ethtool -s advertise ... > > > >in addition to already supported > > > > e

[PATCH ethtool 3/4] netlink: add descriptions for genetlink policy dumps

2020-10-19 Thread Michal Kubecek
Add GENL_ID_CTRL message descriptions for messages and attributes used for policy dumps. Signed-off-by: Michal Kubecek --- netlink/desc-genlctrl.c | 57 + 1 file changed, 57 insertions(+) diff --git a/netlink/desc-genlctrl.c b/netlink/desc-genlctrl.c

[PATCH ethtool 4/4] netlink: add message descriptions for pause stats

2020-10-19 Thread Michal Kubecek
Add message descriptions for pretty printing of new attributes used for pause statistics. Signed-off-by: Michal Kubecek --- netlink/desc-ethtool.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/netlink/desc-ethtool.c b/netlink/desc-ethtool.c index ee8fc4796987..96291b9bdd3b 100644

[PATCH ethtool 1/4] netlink: support u32 enumerated types in pretty printing

2020-10-19 Thread Michal Kubecek
, numeric attribute value is shown. Signed-off-by: Michal Kubecek --- netlink/prettymsg.c | 9 + netlink/prettymsg.h | 18 -- 2 files changed, 25 insertions(+), 2 deletions(-) diff --git a/netlink/prettymsg.c b/netlink/prettymsg.c index f992dcaf071f..d5d999fddfbb 100644

[PATCH ethtool 2/4] netlink: support 64-bit attribute types in pretty printed messages

2020-10-19 Thread Michal Kubecek
Add NLA_U64 (unsigned), NLA_X64 (unsigned, printed as hex) and NLA_S64 (signed) attribute types in pretty printing code. Signed-off-by: Michal Kubecek --- netlink/prettymsg.c | 10 ++ netlink/prettymsg.h | 6 ++ 2 files changed, 16 insertions(+) diff --git a/netlink/prettymsg.c b

[PATCH ethtool 0/4] add missing message descriptions

2020-10-19 Thread Michal Kubecek
enumerated types (shown as symbolic names rather than numeric values). Michal Kubecek (4): netlink: support u32 enumerated types in pretty printing netlink: support 64-bit attribute types in pretty printed messages netlink: add descriptions for genetlink policy dumps netlink: add message

Re: [PATCH net-next 1/6] ethtool: Extend link modes settings uAPI with lanes

2020-10-21 Thread Michal Kubecek
On Tue, Oct 20, 2020 at 07:39:13AM +, Danielle Ratson wrote: > > -Original Message- > > From: Michal Kubecek > > Sent: Monday, October 19, 2020 4:25 PM > > > > As I said, I meant the extension suggested in my mail as independent of what > > t

Re: [PATCH net-next 1/6] ethtool: Extend link modes settings uAPI with lanes

2020-10-21 Thread Michal Kubecek
On Wed, Oct 21, 2020 at 07:20:22AM +, Danielle Ratson wrote: > > -Original Message- > > From: Michal Kubecek > > Sent: Wednesday, October 21, 2020 10:08 AM > > > > On Tue, Oct 20, 2020 at 07:39:13AM +, Danielle Ratson wrote: > > > > -

Re: [PATCH net-next 1/6] ethtool: Extend link modes settings uAPI with lanes

2020-10-22 Thread Michal Kubecek
On Thu, Oct 22, 2020 at 06:15:48AM +, Danielle Ratson wrote: > > -Original Message- > > From: Michal Kubecek > > Sent: Wednesday, October 21, 2020 11:48 AM > > > > Ah, right, it does. But as you extend struct ethtool_link_ksettings > > and driver

Re: [RFC PATCH net-next v3] ethtool: Improve compatibility between netlink and ioctl interfaces

2020-10-28 Thread Michal Kubecek
On Tue, Oct 27, 2020 at 02:53:05PM -0700, Jakub Kicinski wrote: > On Tue, 27 Oct 2020 16:51:14 +0200 Ido Schimmel wrote: > > From: Ido Schimmel > > > > With the ioctl interface, when autoneg is enabled, but without > > specifying speed, duplex or link modes, the advertised link modes are > > set

Re: [RFC PATCH net-next v3] ethtool: Improve compatibility between netlink and ioctl interfaces

2020-10-29 Thread Michal Kubecek
On Wed, Oct 28, 2020 at 07:34:36PM +0200, Ido Schimmel wrote: > On Wed, Oct 28, 2020 at 01:53:39AM +0100, Michal Kubecek wrote: > > On Tue, Oct 27, 2020 at 02:53:05PM -0700, Jakub Kicinski wrote: > > > > > > I did not look at the legacy code but I'm confused by w

Re: [RFC PATCH ethtool] ethtool: Improve compatibility between netlink and ioctl interfaces

2020-11-02 Thread Michal Kubecek
On Mon, Nov 02, 2020 at 08:40:36PM +0200, Ido Schimmel wrote: > From: Ido Schimmel > > With the ioctl interface, when autoneg is enabled, but without > specifying speed, duplex or link modes, the advertised link modes are > set to the supported link modes by the ethtool user space utility. > > T

Re: [RFC PATCH ethtool] ethtool: Improve compatibility between netlink and ioctl interfaces

2020-11-03 Thread Michal Kubecek
On Tue, Nov 03, 2020 at 04:24:30PM +0200, Ido Schimmel wrote: > > I have the changes you requested here: > https://github.com/idosch/ethtool/commit/b34d15839f2662808c566c04eda726113e20ee59 > > Do you want to integrate it with your nl_parse() rework or should I? I pushed the combined series to

Re: [PATCH net v3] net: sched: fix packet stuck problem for lockless qdisc

2021-04-18 Thread Michal Kubecek
On Thu, Mar 25, 2021 at 11:13:11AM +0800, Yunsheng Lin wrote: > Lockless qdisc has below concurrent problem: > cpu0 cpu1 > . . > q->enqueue . > . . > qdisc_run_begin() . > . . > d

Re: [PATCH net v3] net: sched: fix packet stuck problem for lockless qdisc

2021-04-19 Thread Michal Kubecek
On Mon, Apr 19, 2021 at 10:04:27AM +0800, Yunsheng Lin wrote: > > > > I tried this patch o top of 5.12-rc7 with real devices. I used two > > machines with 10Gb/s Intel ixgbe NICs, sender has 16 CPUs (2 8-core CPUs > > with HT disabled) and 16 Rx/Tx queues, receiver has 48 CPUs (2 12-core > > CPUs

Re: [Linuxarm] Re: [PATCH net v3] net: sched: fix packet stuck problem for lockless qdisc

2021-04-19 Thread Michal Kubecek
On Mon, Apr 19, 2021 at 08:21:38PM +0800, Yunsheng Lin wrote: > On 2021/4/19 10:04, Yunsheng Lin wrote: > > On 2021/4/19 6:59, Michal Kubecek wrote: > >> I tried this patch o top of 5.12-rc7 with real devices. I used two > >> machines with 10Gb/s Intel ixgbe NICs, sender

Re: [PATCH net v4 1/2] net: sched: fix packet stuck problem for lockless qdisc

2021-04-19 Thread Michal Kubecek
On Fri, Apr 16, 2021 at 09:16:48AM +0800, Yunsheng Lin wrote: > Lockless qdisc has below concurrent problem: > cpu0 cpu1 > . . > q->enqueue . > . . > qdisc_run_begin() . > . . > d

Re: [PATCH net v4 1/2] net: sched: fix packet stuck problem for lockless qdisc

2021-04-19 Thread Michal Kubecek
On Mon, Apr 19, 2021 at 05:29:46PM +0200, Michal Kubecek wrote: > > As pointed out in the discussion on v3, this patch may result in > significantly higher CPU consumption with multiple threads competing on > a saturated outgoing device. I missed this submission so that I haven't

Re: [PATCH net v4 1/2] net: sched: fix packet stuck problem for lockless qdisc

2021-04-20 Thread Michal Kubecek
On Tue, Apr 20, 2021 at 01:55:03AM +0200, Michal Kubecek wrote: > On Mon, Apr 19, 2021 at 05:29:46PM +0200, Michal Kubecek wrote: > > > > As pointed out in the discussion on v3, this patch may result in > > significantly higher CPU consumption with multiple threads competi

Re: [PATCH ethtool v3 0/5] Extend uAPI with lanes parameter

2021-02-14 Thread Michal Kubecek
On Wed, Feb 10, 2021 at 03:48:35PM +0200, Danielle Ratson wrote: > Currently, there is no way of knowing how many lanes will be use to > achieve a wanted speed. > For example, 100G speed can be achieved using: 2X50 or 4X25. > > In order to solve that, extend ethtool uAPI with lanes as a new link >

[PATCH ethtool] ioctl: less confusing error message for master-slave parameter

2021-02-21 Thread Michal Kubecek
eported-by: Bruce LIU Signed-off-by: Michal Kubecek --- ethtool.c | 12 1 file changed, 12 insertions(+) diff --git a/ethtool.c b/ethtool.c index fb90e9e456b9..15e9d34831b3 100644 --- a/ethtool.c +++ b/ethtool.c @@ -72,6 +72,16 @@ static void exit_bad_args(void) exit(1); } +s

Re: [PATCH net] ethtool: fix the check logic of at least one channel for RX/TX

2021-02-23 Thread Michal Kubecek
On Tue, Feb 23, 2021 at 09:01:06AM -0800, Jakub Kicinski wrote: > On Tue, 23 Feb 2021 14:24:40 +0100 Simon Horman wrote: > > From: Yinjun Zhang > > > > The command "ethtool -L combined 0" may clean the RX/TX channel > > count and skip the error path, since the attrs > > tb[ETHTOOL_A_CHANNELS_RX_

Re: [PATCH net] ethtool: fix the check logic of at least one channel for RX/TX

2021-02-23 Thread Michal Kubecek
] > are NULL in this case when recent ethtool is used. > > Tested using ethtool v5.10. > > Fixes: 7be92514b99c ("ethtool: check if there is at least one channel for > TX/RX in the core") > Signed-off-by: Yinjun Zhang > Signed-off-by: Simon Horman > Signed-of

Re: [PATCH net] ethtool: fix the check logic of at least one channel for RX/TX

2021-02-23 Thread Michal Kubecek
On Tue, Feb 23, 2021 at 05:02:06PM -0800, Jakub Kicinski wrote: > On Wed, 24 Feb 2021 01:32:51 +0100 Michal Kubecek wrote: > > On Tue, Feb 23, 2021 at 02:24:40PM +0100, Simon Horman wrote: > > > From: Yinjun Zhang > > > > > > The command "ethtool -L

Re: Packet gets stuck in NOLOCK pfifo_fast qdisc

2021-04-06 Thread Michal Kubecek
On Tue, Apr 06, 2021 at 08:55:41AM +0800, Yunsheng Lin wrote: > > Hi, Jiri > Do you have a reproducer that can be shared here? > With reproducer, I can debug and test it myself too. I'm afraid we are not aware of a simple reproducer. As mentioned in the original discussion, the race window is ext

Re: Packet gets stuck in NOLOCK pfifo_fast qdisc

2021-04-06 Thread Michal Kubecek
On Tue, Apr 06, 2021 at 10:46:29AM +0800, Yunsheng Lin wrote: > On 2021/4/6 9:49, Cong Wang wrote: > > On Sat, Apr 3, 2021 at 5:23 AM Jiri Kosina wrote: > >> > >> I am still planning to have Yunsheng Lin's (CCing) fix [1] tested in the > >> coming days. If it works, then we can consider proceeding

Re: [PATCH net v1 1/1] ethtool: fix incorrect datatype in set_eee ops

2021-04-06 Thread Michal Kubecek
.tx_lpi_enabled, .tx_lpi_timer value is interpreted as a number, not a logical value (those two are also __u32). But I don't think it's necessary to resubmit. Reviewed-by: Michal Kubecek > Fixes: fd77be7bd43c ("ethtool: set EEE settings with EEE_SET request") > Cc: # 5.10.x &

Re: [PATCH net-next v2 3/9] ethtool: add a new command for reading standard stats

2021-04-17 Thread Michal Kubecek
On Sat, Apr 17, 2021 at 12:18:08PM -0700, Jakub Kicinski wrote: > On Sat, 17 Apr 2021 12:15:20 -0700 Jakub Kicinski wrote: > > On Sat, 17 Apr 2021 21:53:40 +0300 Ido Schimmel wrote: > > > On Sat, Apr 17, 2021 at 11:13:51AM -0700, Jakub Kicinski wrote: > > > > On Sat, 17 Apr 2021 10:57:42 -0700 Ja

Re: [PATCH ethtool] Fix help message for master-slave option

2021-01-24 Thread Michal Kubecek
On Wed, Jan 20, 2021 at 09:21:22PM +0900, Yuusuke Ashizuka wrote: > Fixes: 558f7cc33daf ("netlink: add master/slave configuration support") > Signed-off-by: Yuusuke Ashizuka Applied, thank you. Michal > --- > ethtool.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/e

Re: [PATCH net-next v3 2/7] ethtool: Get link mode in use instead of speed and duplex parameters

2021-01-28 Thread Michal Kubecek
> ; Andrew Lunn ; f.faine...@gmail.com; > > Michal Kubecek ; mlxsw > > ; Ido Schimmel > > Subject: Re: [PATCH net-next v3 2/7] ethtool: Get link mode in use instead > > of speed and duplex parameters > > > > For one thing, it's cleaner if the driver

Re: [PATCH ethtool v2 2/5] netlink: settings: Add netlink support for lanes parameter

2021-02-09 Thread Michal Kubecek
On Tue, Feb 02, 2021 at 08:25:10PM +0200, Danielle Ratson wrote: > Add support for "ethtool -s lanes N ..." for setting a specific > number of lanes. > > Signed-off-by: Danielle Ratson > Reviewed-by: Jiri Pirko > --- > ethtool.c | 1 + > netlink/settings.c | 8 > 2 files chan

Re: [PATCH ethtool v2 1/5] ethtool: Extend ethtool link modes settings uAPI with lanes

2021-02-09 Thread Michal Kubecek
On Tue, Feb 02, 2021 at 08:25:09PM +0200, Danielle Ratson wrote: > Add ETHTOOL_A_LINKMODES_LANES, expand ethtool_link_settings with > lanes attribute and define valid lanes in order to support a new > lanes-selector. > > Signed-off-by: Danielle Ratson > --- When updating the UAPI header copies,

Re: [PATCH ethtool v2 0/5] Extend uAPI with lanes parameter

2021-02-09 Thread Michal Kubecek
On Tue, Feb 02, 2021 at 08:25:08PM +0200, Danielle Ratson wrote: > Currently, there is no way of knowing how many lanes will be use to > achieve a wanted speed. > For example, 100G speed can be achieved using: 2X50 or 4X25. > > In order to solve that, extend ethtool uAPI with lanes as a new link >

Re: [PATCH ethtool v2 1/5] ethtool: Extend ethtool link modes settings uAPI with lanes

2021-02-10 Thread Michal Kubecek
On Wed, Feb 10, 2021 at 12:06:04PM +, Danielle Ratson wrote: > > When updating the UAPI header copies, please do it in a separate > > commit which updates the whole uapi/ subdirectory to the state of a > > specific kernel commit. You can use the script at > > > > https://www.kernel.org/pub/s

Re: [RFC PATCH V3 net-next 1/5] ethtool: Allow network drivers to dump arbitrary EEPROM data

2021-03-18 Thread Michal Kubecek
On Thu, Mar 18, 2021 at 02:03:02PM +0100, Andrew Lunn wrote: > On Mon, Mar 15, 2021 at 07:12:39PM +0200, Moshe Shemesh wrote: > > > > +EEPROM_DATA > > +=== > > + > > +Fetch module EEPROM data dump. > > + > > +Request contents: > > + > > + = == ==

[PATCH ethtool 7/7] build: add -Wextra to default CFLAGS

2020-08-09 Thread Michal Kubecek
As a result of previous commits, ethtool source now builds with gcc versions 7-11 without any compiler warning with "-Wall -Wextra". Add "-Wextra" to default cflags to make sure that any new warnings are caught as early as possible. Suggested-by: Andrew Lunn Signed-of

[PATCH ethtool 3/7] ioctl: get rid of signed/unsigned comparison warnings

2020-08-09 Thread Michal Kubecek
: Michal Kubecek --- ethtool.c | 45 - 1 file changed, 24 insertions(+), 21 deletions(-) diff --git a/ethtool.c b/ethtool.c index 4fa7a2c1716f..d9dcd0448c02 100644 --- a/ethtool.c +++ b/ethtool.c @@ -225,8 +225,8 @@ static void parse_generic_cmdline

[PATCH ethtool 0/7] compiler warnings cleanup, part 2

2020-08-09 Thread Michal Kubecek
handled by using named field initializers; in link_mode_info[] array, helper macros are also used to make code easier to read and check. As the final step, add "-Wextra" to default CFLAGS to catch any future warnings as early as possible. Michal Kubecek (7): netlink: get rid of signe

[PATCH ethtool 2/7] ioctl: check presence of eeprom length argument properly

2020-08-09 Thread Michal Kubecek
g to let parser tell us if the argument was used. Signed-off-by: Michal Kubecek --- ethtool.c | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/ethtool.c b/ethtool.c index c4ad186cd390..4fa7a2c1716f 100644 --- a/ethtool.c +++ b/ethtool.c @@ -3184,10 +3

[PATCH ethtool 5/7] settings: simplify link_mode_info[] initializers

2020-08-09 Thread Michal Kubecek
Use macro helpers to make link_mode_info[] initializers easier to read and less prone to mistakes. As a bonus, this gets rid of "missing field initializer" warnings in netlink/settings.c This commit should have no effect on resulting code (checked with gcc-11 and -O2). Signed-off-

[PATCH ethtool 4/7] get rid of signed/unsigned comparison warnings in register dump parsers

2020-08-09 Thread Michal Kubecek
All of these are avoided by declaring a variable (mostly loop iterators) holding only unsigned values as unsigned. Signed-off-by: Michal Kubecek --- dsa.c | 2 +- fec.c | 2 +- ibm_emac.c | 2 +- marvell.c | 2 +- natsemi.c | 2 +- rxclass.c | 8 +--- sfpdiag.c | 2 +- tg3.c

[PATCH ethtool 1/7] netlink: get rid of signed/unsigned comparison warnings

2020-08-09 Thread Michal Kubecek
Get rid of compiler warnings about comparison between signed and unsigned integer values in netlink code. Signed-off-by: Michal Kubecek --- netlink/features.c | 4 ++-- netlink/netlink.c | 4 ++-- netlink/netlink.h | 2 +- netlink/nlsock.c | 2 +- netlink/parser.c | 2 +- netlink

[PATCH ethtool 6/7] ioctl: convert cmdline_info arrays to named initializers

2020-08-09 Thread Michal Kubecek
11 and -O2). Signed-off-by: Michal Kubecek --- ethtool.c | 378 ++ 1 file changed, 296 insertions(+), 82 deletions(-) diff --git a/ethtool.c b/ethtool.c index d9dcd0448c02..40868d064e28 100644 --- a/ethtool.c +++ b/ethtool.c @@ -1825,10 +1825,24 @@

Re: [PATCH ethtool 1/7] netlink: get rid of signed/unsigned comparison warnings

2020-08-11 Thread Michal Kubecek
On Mon, Aug 10, 2020 at 04:11:22PM +0200, Andrew Lunn wrote: > On Sun, Aug 09, 2020 at 11:24:19PM +0200, Michal Kubecek wrote: > > Get rid of compiler warnings about comparison between signed and > > unsigned integer values in netlink code. > > > > Si

  1   2   3   4   5   6   7   >