Re: [PATCH] net/macb: add support for resetting PHY using GPIO

Hi Gregory, so far dealt with this in u-boot. The power down the PHY part makes sense, though. Minor nit down inline. Will need to test on hardware (Zynq). On Wed, Dec 9, 2015 at 9:49 AM, Gregory CLEMENT wrote: > With device tree it is no more possible to

Re: Supporting C45 PHY without ID registers

Hi Andrew, On Mon, Jun 27, 2016 at 5:56 PM, Andrew Lunn wrote: > Does it have any ID registers at all? There is a vendor specific (to my knowledge) register at device 1 register 65535 ([1]) that could be read back. I haven't seen anyone else do that. Thanks, Moritz [1]

Supporting C45 PHY without ID registers

Hi all, I have a 10GigE PHY that I'm working with that has most of it's functionality availabile via MDIO in a clause 45 compliant fashion, however the usual probe method fails since the id registers are not implemented. I hacked up drivers/of/of_mdio.c to include something similar to

Re: [PATCH 0/3] net: macb: Fix coding style issues

Hi all, thanks for the feedback. On Wed, Mar 9, 2016 at 8:29 AM, Michal Simek wrote: > On 7.3.2016 18:13, Nicolas Ferre wrote: >> I'm not usually fond of this type of patches, but I must admit that this >> series corrects some style issues. While I was playing around

[PATCH 3/5] net: macb: Address checkpatch 'check' suggestions

This commit deals with a bunch of checkpatch suggestions that without changing behavior make checkpatch happier. Signed-off-by: Moritz Fischer <moritz.fisc...@ettus.com> --- drivers/net/ethernet/cadence/macb.c | 46 +++-- 1 file changed, 24 insertions(

[PATCH 2/5] net: macb: Fix coding style warnings

This commit takes care of the coding style warnings that are mostly due to a different comment style and lines over 80 chars, as well as a dangling else. Signed-off-by: Moritz Fischer <moritz.fisc...@ettus.com> --- drivers/net/ethernet/cadence/macb.c | 101 +++--

[PATCH 0/5] net: macb: Checkpatch cleanups

Hi all, I backed out the variable scope changes and made a separate patch for the ether_addr_copy change. Changes from v1: * Backed out variable scope changes * Separated out ether_addr_copy into it's own commit * Fixed typo in comments as suggested by Joe Cheers, Moritz Moritz Fischer (5

[PATCH 5/5] net: macb: Fix simple typo.

Signed-off-by: Moritz Fischer <moritz.fisc...@ettus.com> --- drivers/net/ethernet/cadence/macb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c index a0c01e5..681e5bf 100644 --- a/drivers/net/et

[PATCH 4/5] net: macb: Use ether_addr_copy over memcpy

Checkpatch suggests using ether_addr_copy over memcpy to copy the mac address. Signed-off-by: Moritz Fischer <moritz.fisc...@ettus.com> --- drivers/net/ethernet/cadence/macb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/cadence/macb.c b/drive

[PATCH 1/5] net: macb: Fix coding style error message

checkpatch.pl gave the following error: ERROR: space required before the open parenthesis '(' + for(; p < end; p++, offset += 4) Signed-off-by: Moritz Fischer <moritz.fisc...@ettus.com> --- drivers/net/ethernet/cadence/macb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [PATCH 0/5] net: macb: Checkpatch cleanups

Nicolas, On Wed, Mar 16, 2016 at 6:39 AM, Nicolas Ferre <nicolas.fe...@atmel.com> wrote: > Le 13/03/2016 20:10, Moritz Fischer a écrit : >> Hi all, >> >> I backed out the variable scope changes and made a separate >> patch for the ether_addr_copy change. >

[RFC] net: macb: Attempt to make fixed link working on macb

Signed-off-by: Moritz Fischer <moritz.fisc...@ettus.com> --- drivers/net/ethernet/cadence/macb.c | 63 - drivers/net/ethernet/cadence/macb.h | 1 + 2 files changed, 43 insertions(+), 21 deletions(-) diff --git a/drivers/net/ethernet/cadence/macb.c b/d

[RFC] Attempt to add fixed link functionality to macb

for pointers on obvious mistakes than for a thorough code review. Thanks in advance, Moritz Moritz Fischer (1): net: macb: Attempt to make fixed link working on macb drivers/net/ethernet/cadence/macb.c | 63 - drivers/net/ethernet/cadence/macb.h | 1 + 2

[PATCH 1/3] net: macb: Fix coding style error message

checkpatch.pl gave the following error: ERROR: space required before the open parenthesis '(' + for(; p < end; p++, offset += 4) Signed-off-by: Moritz Fischer <moritz.fisc...@ettus.com> --- drivers/net/ethernet/cadence/macb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH 3/3] net: macb: Address checkpatch 'check' suggestions

This commit deals with a bunch of checkpatch suggestions that without changing behavior make checkpatch happier. Signed-off-by: Moritz Fischer <moritz.fisc...@ettus.com> --- drivers/net/ethernet/cadence/macb.c | 46 +++-- 1 file changed, 24 insertions(

Re: [PATCH 2/3] net: macb: Fix more coding style issues

Hi Joe, David, On Mon, Mar 7, 2016 at 10:49 AM, David Miller <da...@davemloft.net> wrote: > From: Moritz Fischer <moritz.fisc...@ettus.com> > Date: Mon, 7 Mar 2016 08:17:38 -0800 > >> @@ -945,6 +943,7 @@ static int macb_rx_frame(struct macb *bp, unsigned int &g

[PATCH 0/3] net: macb: Fix coding style issues

into one commit. Cheers, Moritz Moritz Fischer (3): net: macb: Fix coding style error message net: macb: Fix more coding style issues net: macb: Address checkpatch 'check' suggestions drivers/net/ethernet/cadence/macb.c | 157 1 file changed, 71

[PATCH 3/3] net: macb: Cleanup checkpatch checks

This commit deals with a bunch of check suggestions that without changing behavior make checkpatch hapy. Signed-off-by: Moritz Fischer <moritz.fisc...@ettus.com> --- drivers/net/ethernet/cadence/macb.c | 46 +++-- 1 file changed, 24 insertions(+), 22 del

[PATCH 2/3] net: macb: Fix more coding style issues

This commit takes care of the coding style warnings that are mostly due to a different comment style and lines over 80 chars. Notable exceptions are ether_addr_copy vs memcpy, as well as a dangling else after a return. Signed-off-by: Moritz Fischer <moritz.fisc...@ettus.com> --- drive

Re: [PATCH 3/3] net: macb: Cleanup checkpatch checks

Derp, it's monday morning. Ignore the second [3/3] patch... Sorry for the noise. Moritz

[PATCH v3 4/5] net: macb: Use ether_addr_copy over memcpy

Checkpatch suggests using ether_addr_copy over memcpy to copy the mac address. Acked-by: Michal Simek <michal.si...@xilinx.com> Acked-by: Nicolas Ferre <nicolas.fe...@atmel.com> Signed-off-by: Moritz Fischer <moritz.fisc...@ettus.com> --- drivers/net/ethernet/cadence/mac

[PATCH v3 1/5] net: macb: Fix coding style error message

checkpatch.pl gave the following error: ERROR: space required before the open parenthesis '(' + for(; p < end; p++, offset += 4) Acked-by: Nicolas Ferre <nicolas.fe...@atmel.com> Acked-by: Michal Simek <michal.si...@xilinx.com> Signed-off-by: Moritz Fischer <moritz

[PATCH v3 0/5] macb: Codingstyle cleanups

as suggested by Joe Cheers, Moritz Moritz Fischer (5): net: macb: Fix coding style error message net: macb: Fix coding style warnings net: macb: Fix coding style suggestions net: macb: Use ether_addr_copy over memcpy net: macb: Fix simple typo drivers/net/ethernet/cadence/macb.c

[PATCH v3 2/5] net: macb: Fix coding style warnings

This commit takes care of the coding style warnings that are mostly due to a different comment style and lines over 80 chars, as well as a dangling else. Acked-by: Nicolas Ferre <nicolas.fe...@atmel.com> Signed-off-by: Moritz Fischer <moritz.fisc...@ettus.com> --- drivers/net/ethe

[PATCH v3 5/5] net: macb: Fix simple typo

Acked-by: Michal Simek <michal.si...@xilinx.com> Acked-by: Nicolas Ferre <nicolas.fe...@atmel.com> Signed-off-by: Moritz Fischer <moritz.fisc...@ettus.com> --- drivers/net/ethernet/cadence/macb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ne

[PATCH v3 3/5] net: macb: Fix coding style suggestions

This commit deals with a bunch of checkpatch suggestions that without changing behavior make checkpatch happier. Acked-by: Michal Simek <michal.si...@xilinx.com> Acked-by: Nicolas Ferre <nicolas.fe...@atmel.com> Signed-off-by: Moritz Fischer <moritz.fisc...@ettus.com> --- dr

Re: [PATCH] net: ethernet: cadence: Add fixed-link functionality

Hi Florian, thanks for the quick reply. On Wed, Feb 15, 2017 at 12:57 PM, Florian Fainelli <f.faine...@gmail.com> wrote: > On 02/15/2017 12:44 PM, m...@kernel.org wrote: >> From: Moritz Fischer <m...@kernel.org> >> >> This allows 'fixed-link' dire

Re: [PATCH] net: ethernet: cadence: Add fixed-link functionality

Andrew, On Wed, Feb 15, 2017 at 2:12 PM, Andrew Lunn wrote: >> @@ -3342,8 +3371,18 @@ static int macb_probe(struct platform_device *pdev) >> macb_get_hwaddr(bp); >> >> /* Power up the PHY if there is a GPIO reset */ >> - phy_node =

Re: [PATCH] net: macb: NULL out phydev after removing mdio bus

macb > driver without first taking its interface down, since unregister_netdev > will end up calling macb_close. > > Signed-off-by: Xander Huff <xander.h...@ni.com> > Signed-off-by: Nathan Sullivan <nathan.sulli...@ni.com> > Signed-off-by: Brad Mouring <brad.mour...@ni.com> Reviewed-by: Moritz Fischer <moritz.fisc...@ettus.com>

[PATCH 2/2] net: ethernet: nixge: Add support for National Instruments XGE netdev

Add support for the National Instruments XGE 1/10G network device. It uses the EEPROM on the board via NVMEM. Signed-off-by: Moritz Fischer <m...@kernel.org> --- drivers/net/ethernet/Kconfig |1 + drivers/net/ethernet/Makefile|1 + drivers/net/ethernet/ni/Kconfig

[PATCH 1/2] dt-bindings: net: Add bindings for National Instruments XGE netdev

This adds bindings for the NI XGE 1G/10G network device. Signed-off-by: Moritz Fischer <m...@kernel.org> --- Documentation/devicetree/bindings/net/nixge.c | 32 +++ 1 file changed, 32 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/nixge.c

Re: [PATCH 2/2] net: ethernet: nixge: Add support for National Instruments XGE netdev

Hi Andrew, On Thu, Jul 13, 2017 at 6:34 PM, Andrew Lunn wrote: >> > > + /* not sure if this is the correct way of dealing with this ... */ >> > > + ndev->phydev->supported &= ~(SUPPORTED_Autoneg); >> > > + ndev->phydev->advertising = ndev->phydev->supported; >> > > +

Re: [PATCH 1/2] dt-bindings: net: Add bindings for National Instruments XGE netdev

Hi Yuan, On Thu, Jul 13, 2017 at 5:33 PM, YUAN Linyu <linyu.y...@alcatel-sbell.com.cn> wrote: > > >> -Original Message- >> From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] >> On Behalf Of Moritz Fischer >> Sent: Friday,

Re: [PATCH 2/2] net: ethernet: nixge: Add support for National Instruments XGE netdev

Hi Andrew, thanks for the quick response. On Fri, Jul 14, 2017 at 12:36:36AM +0200, Andrew Lunn wrote: > > +++ b/drivers/net/ethernet/ni/nixge.c > > @@ -0,0 +1,1246 @@ > > +/* > > + * Copyright (c) 2016-2017, National Instruments Corp. > > + * > > + * Network Driver for Ettus Research XGE MAC >

Re: [PATCH v2 1/2] dt-bindings: net: Add bindings for National Instruments XGE netdev

On Sat, Jul 15, 2017 at 09:48:32PM +0200, Andrew Lunn wrote: > > > > + ethernet_phy1: ethernet-phy@4 { > > > > + compatible = "ethernet-phy-ieee802.3-c45"; > > > > + reg = <4>; > > > > + devices = <0xa>; > > > > +

[PATCH v2 2/2] net: ethernet: nixge: Add support for National Instruments XGE netdev

Add support for the National Instruments XGE 1/10G network device. It uses the EEPROM on the board via NVMEM. Signed-off-by: Moritz Fischer <m...@kernel.org> --- Changes from v1: - Added dependency on ARCH_ZYNQ (Kbuild) - Removed unused variables - Use of_phy_connect as suggested - R

[PATCH v2 1/2] dt-bindings: net: Add bindings for National Instruments XGE netdev

This adds bindings for the NI XGE 1G/10G network device. Signed-off-by: Moritz Fischer <m...@kernel.org> --- Documentation/devicetree/bindings/net/nixge.txt | 32 + 1 file changed, 32 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/nixge.txt

Re: [PATCH v2 1/2] dt-bindings: net: Add bindings for National Instruments XGE netdev

Hi Andrew, On Sat, Jul 15, 2017 at 08:37:45PM +0200, Andrew Lunn wrote: > On Fri, Jul 14, 2017 at 01:48:45PM -0700, Moritz Fischer wrote: > > This adds bindings for the NI XGE 1G/10G network device. > > > > Signed-off-by: Moritz Fischer <m...@kernel.org> > >

[PATCH 1/2] net: nixge: Fix error path for obtaining mac address

. Fixes commit 492caffa8a1a ("net: ethernet: nixge: Add support for National Instruments XGE netdev") Reported-by: Alex Williams <alex.willi...@ni.com> Signed-off-by: Moritz Fischer <m...@kernel.org> --- drivers/net/ethernet/ni/nixge.c | 8 +--- 1 file changed, 5 inse

[PATCH 2/2] net: nixge: Address compiler warnings about signedness

r, mac_addr); ^~~~ expected ‘const u8 * {aka const unsigned char *}’ but argument is of type ‘const char *’ static inline void ether_addr_copy(u8 *dst, const u8 *src) Signed-off-by: Moritz Fischer <m...@kernel.org> --- drivers/net/ethernet/ni/nixge.c | 2 +- 1 file changed,

[RFC/PATCH] net: ethernet: nixge: Use of_get_mac_address()

Make nixge driver work with 'mac-address' property instead of 'address' property. There are currently no in-tree users and the only users of this driver are devices that use overlays we control to instantiate the device together with the corresponding FPGA images. Signed-off-by: Moritz Fischer &l

Re: [RFC/PATCH] net: ethernet: nixge: Use of_get_mac_address()

On Thu, Apr 26, 2018 at 02:57:42PM -0700, Moritz Fischer wrote: > Make nixge driver work with 'mac-address' property instead of > 'address' property. There are currently no in-tree users and > the only users of this driver are devices that use overlays > we control to instantiat

[PATCH v3 2/2] net: ethernet: nixge: Add support for National Instruments XGE netdev

Add support for the National Instruments XGE 1/10G network device. It uses the EEPROM on the board via NVMEM. Signed-off-by: Moritz Fischer <m...@kernel.org> --- Changes from v2: - Implement recv side NAPI - Improved error handling - Implemented C45 writes - Added ethtool callbacks &

[PATCH v3 1/2] dt-bindings: net: Add bindings for National Instruments XGE netdev

This adds bindings for the NI XGE 1G/10G network device. Signed-off-by: Moritz Fischer <m...@kernel.org> --- Changes from v2: - Addressed Rob's comments w.r.t to IRQ names and typo Changes from v1: - Corrected from nixge -> nixge.txt --- Documentation/devicetree/bindings/net/nixge

[RFC/PATCH]] net: nixge: Add support for 64-bit ZynqMP platform

Add support for 64-bit (ZynqMP) platform to driver. The hardware only supports 32-bit register accesses so the accesses need to be split up into two writes when setting the current and tail descriptor values. Signed-off-by: Moritz Fischer Cc: Florian Fainelli --- Hi all, I'm working

[PATCH] net: nixge: Add support for 64-bit platforms

Add support for 64-bit platforms to driver. The hardware only supports 32-bit register accesses so the accesses need to be split up into two writes when setting the current and tail descriptor values. Cc: Florian Fainelli Signed-off-by: Moritz Fischer --- Changes from RFC: - Work around

Re: [PATCH net-next 5/5] net: phy: marvell10g: Utilize gen10g_soft_reset()

Florian, On Wed, Feb 28, 2018 at 11:44 AM, Russell King wrote: > On Wed, Feb 28, 2018 at 11:36:12AM -0800, Florian Fainelli wrote: >> We do the same thing as the generic function: nothing, so utilize it. >> >> Signed-off-by: Florian Fainelli >> --- >>

Re: [PATCH v5 2/2] net: ethernet: nixge: Add support for National Instruments XGE netdev

Hi David, On Mon, Mar 26, 2018 at 11:38:30AM -0400, David Miller wrote: > From: Moritz Fischer <m...@kernel.org> > Date: Fri, 23 Mar 2018 13:41:28 -0700 > > > +static void nixge_hw_dma_bd_release(struct net_device *ndev) > > +{ > > + int i; > > + str

[PATCH v6 1/2] dt-bindings: net: Add bindings for National Instruments XGE netdev

This adds bindings for the NI XGE 1G/10G network device. Reviewed-by: Rob Herring <r...@kernel.org> Signed-off-by: Moritz Fischer <m...@kernel.org> --- Changes from v5: - None Changes from v4: - None Changes from v3: - Added Rob's Reviewed-by Changes from v2: - Addressed Rob's co

[PATCH v6 2/2] net: ethernet: nixge: Add support for National Instruments XGE netdev

Add support for the National Instruments XGE 1/10G network device. It uses the EEPROM on the board via NVMEM. Signed-off-by: Moritz Fischer <m...@kernel.org> --- Changes from v5: - Fixed up indents according to David's feedback - Fixed KConfig ---help--- -> help Changes from v4:

[PATCH v5 2/2] net: ethernet: nixge: Add support for National Instruments XGE netdev

Add support for the National Instruments XGE 1/10G network device. It uses the EEPROM on the board via NVMEM. Signed-off-by: Moritz Fischer <m...@kernel.org> --- Changes from v4: - Worked on consistency for constants - Removed unused constants - Removed unused includes Changes from v3: -

[PATCH v5 1/2] dt-bindings: net: Add bindings for National Instruments XGE netdev

This adds bindings for the NI XGE 1G/10G network device. Reviewed-by: Rob Herring <r...@kernel.org> Signed-off-by: Moritz Fischer <m...@kernel.org> --- Changes from v4: - None Changes from v3: - Added Rob's Reviewed-by Changes from v2: - Addressed Rob's comments w.r.t to IRQ na

[RESEND PATCH v4 2/2] net: ethernet: nixge: Add support for National Instruments XGE netdev

Add support for the National Instruments XGE 1/10G network device. It uses the EEPROM on the board via NVMEM. Signed-off-by: Moritz Fischer <m...@kernel.org> --- Changes from v3: - Added NIXGE prefix to MDIO constants - Removed NIXGE_MAX_PHY_ADDR (unused) - Consistency for NIXGE_MDIO_CX

[RESEND PATCH v4 1/2] dt-bindings: net: Add bindings for National Instruments XGE netdev

This adds bindings for the NI XGE 1G/10G network device. Reviewed-by: Rob Herring <r...@kernel.org> Signed-off-by: Moritz Fischer <m...@kernel.org> --- Changes from v3: - Added Rob's Reviewed-by Changes from v2: - Addressed Rob's comments w.r.t to IRQ names and typo Cha

[PATCH net-next] net: nixge: Address compiler warnings when building for i386

forms") Signed-off-by: Moritz Fischer Cc: Arnd Bergmann --- drivers/net/ethernet/ni/nixge.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/ni/nixge.c b/drivers/net/ethernet/ni/nixge.c index 74cf52e3fb09..0611f2335b4a 100644 --- a/d