Re: [2.6 patch] net/sunrpc/xdr.c: remove xdr_decode_string()

2005-11-23 Thread Neil Brown
On Wednesday November 23, [EMAIL PROTECTED] wrote: On Wed, Nov 23, 2005 at 04:31:14AM -0800, Lever, Charles wrote: so i don't remember why you are removing xdr_decode_string. are we sure that no-one will need this functionality in the future? it is harmless to remove today, but i wonder

TCP stack sometimes loses ACKs ... or something

2006-11-06 Thread Neil Brown
I upgraded my notebook from 2.6.16 to 2.6.18 recently and noticed that I couldn't talk to my VOIP device (which has a WEB interface). Watching traffic I see the three-way-handshake working perfectly, and then the first data packet is sent (a partial HTTP request: GET / HTTP/1.1 ) and an ACK

Re: [ANNOUNCE] d80211 based driver for Intel PRO/Wireless 3945ABG

2007-02-09 Thread Neil Brown
On Friday February 9, [EMAIL PROTECTED] wrote: Ok. Now... any questions? Yes. Does this require a closed user-space helper like the other 3945ABG driver, or is it completely open (maybe excepting firmware)? Thanks, NeilBrown - To unsubscribe from this list: send the line unsubscribe

Re: 2.6.20-git8 fails compile -- net/built-in.o __ipv6_addr_type

2007-02-12 Thread Neil Brown
On Monday February 12, [EMAIL PROTECTED] wrote: Quoting YOSHIFUJIHideaki/=?iso-2022-jp?B?GyRCNUhGIzFRTEAbKEI=?= In article [EMAIL PROTECTED] (at Mon, 12 Feb 2007 18:12:16 -0800), Andrew Morton [EMAIL PROTECTED] says: On Mon, 12 Feb 2007 20:10:13 -0500 (EST) Pete Clements [EMAIL

Re: [NFS] [PATCH 001 of 3] knfsd: Use recv_msg to get peer address for NFSD instead of code-copying

2007-03-05 Thread Neil Brown
On Monday March 5, [EMAIL PROTECTED] wrote: Hi Neil, here's another minor comment: On Friday 02 March 2007 05:28, NeilBrown wrote: +static inline void svc_udp_get_dest_address(struct svc_rqst *rqstp, + struct cmsghdr *cmh) { switch

Re: [NFS] [PATCH 001 of 3] knfsd: Use recv_msg to get peer address for NFSD instead of code-copying

2007-03-05 Thread Neil Brown
On Monday March 5, [EMAIL PROTECTED] wrote: On Friday 02 March 2007 05:28, NeilBrown wrote: The sunrpc server code needs to know the source and destination address for UDP packets so it can reply properly. It currently copies code out of the network stack to pick the pieces out of the

Re: [RFC][PATCH 2/9] deadlock prevention core

2006-08-14 Thread Neil Brown
On Monday August 14, [EMAIL PROTECTED] wrote: On Sun, 2006-08-13 at 22:22 -0700, Andrew Morton wrote: We could track dirty anonymous memory and throttle. Also, there must be some value of /proc/sys/vm/min_free_kbytes at which a machine is no longer deadlockable with any of these

Re: [RFC][PATCH 2/9] deadlock prevention core

2006-08-17 Thread Neil Brown
On Thursday August 17, [EMAIL PROTECTED] wrote: Andrew Morton wrote: Daniel Phillips [EMAIL PROTECTED] wrote: What happened to the case where we just fill memory full of dirty file pages backed by a remote disk? Processes which are dirtying those pages throttle at

Re: [PATCH 1/1] NFS: change the ip_map cache code to handle IPv6 addresses

2007-08-09 Thread Neil Brown
On Thursday August 9, [EMAIL PROTECTED] wrote: Here is a small part of missing pieces of IPv6 support for the server. It deals with the ip_map caching code part. It changes the ip_map structure to be able to store INET6 addresses. It adds also the changes in address hashing, and mapping to

Re: [PATCH 1/1] NFS: change the ip_map cache code to handle IPv6 addresses

2007-08-09 Thread Neil Brown
On Thursday August 9, [EMAIL PROTECTED] wrote: How have you tested the effectiveness of the new hash function? I have not tested that point but I can easily imagine there are better solutions. Perhaps we can keep the same function for an IPv4 address (only taking the 32 bits of

Re: Oops in 2.6.22.1: skb_copy_and_csum_datagram_iovec()

2007-09-05 Thread Neil Brown
On Wednesday August 22, [EMAIL PROTECTED] wrote: Chuck Ebbert [EMAIL PROTECTED] wrote: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=253290 18:57:54 osama kernel: [c05be67f] kernel_recvmsg+0x31/0x40 18:57:54 osama kernel: [e0bc52d4] svc_udp_recvfrom+0x114/0x368 [sunrpc]

Re: Oops in 2.6.22.1: skb_copy_and_csum_datagram_iovec()

2007-09-05 Thread Neil Brown
On Wednesday September 5, [EMAIL PROTECTED] wrote: On Wednesday August 22, [EMAIL PROTECTED] wrote: Chuck Ebbert [EMAIL PROTECTED] wrote: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=253290 18:57:54 osama kernel: [c05be67f] kernel_recvmsg+0x31/0x40 18:57:54 osama kernel:

Re: [OOPS] 2.6.23-rc5 in tcp/net/nfsd

2007-09-11 Thread Neil Brown
On Tuesday September 11, [EMAIL PROTECTED] wrote: This oops appeared over night on a box running 2.6.23-rc5 (recent with the tcp_input.c fix). I can't find a similar one reported. Okay. this is weird. Mark BUG: unable to handle kernel NULL pointer dereference at virtual address

Re: [patch] sunrpc: make closing of old temporary sockets work (was: problems with lockd in 2.6.22.6)

2007-09-12 Thread Neil Brown
gets closed because they are old (they might get closed if the client closed them). This bug has existed since 2.6.21-rc1. Thanks to Wolfgang Walter for finding and reporting the bug. Cc: Wolfgang Walter [EMAIL PROTECTED] Signed-off-by: Neil Brown [EMAIL PROTECTED] ### Diffstat output ./net

Re: [PATCH 2/2] NFS: handle IPv6 addresses in nfs ctl

2007-10-29 Thread Neil Brown
On Monday October 22, [EMAIL PROTECTED] wrote: Here is a second missing part of the IPv6 support in NFS server code concerning knfd syscall interface. It updates write_getfd and write_getfd to accept IPv6 addresses. Sorry for not replying to this earlier - I saw the Oct 12 post and thought

Re: [BUG] New Kernel Bugs

2007-11-14 Thread Neil Brown
On Wednesday November 14, [EMAIL PROTECTED] wrote: On Wed, Nov 14, 2007 at 09:38:20AM -0800, Randy Dunlap wrote: On Wed, 14 Nov 2007 15:08:47 +0100 Ingo Molnar wrote: so please stop this too busy and too noisy nonsense already. It was nonsense 10 years ago and it's nonsense today. In 10

Re: [BUG] New Kernel Bugs

2007-11-14 Thread Neil Brown
On Tuesday November 13, [EMAIL PROTECTED] wrote: On Tuesday 13 November 2007 07:08, Mark Lord wrote: Ingo Molnar wrote: .. This is all QA-101 that _cannot be argued against on a rational basis_, it's just that these sorts of things have been largely ignored for years, in favor of

Re: Top 10 kernel oopses for the week ending January 5th, 2008

2008-01-09 Thread Neil Brown
On Tuesday January 8, [EMAIL PROTECTED] wrote: FWIW, I'm going to go through Arjan's collection and post blow-by-blow analysis of some of those suckers. Tonight, probably... Let's take e.g. http://www.kerneloops.org/raw.php?rawid=2618 Thanks for that analysis. ... Humm... So we have

Re: Top 10 kernel oopses for the week ending January 5th, 2008

2008-01-13 Thread Neil Brown
On Thursday January 10, [EMAIL PROTECTED] wrote: On Thu, Jan 10, 2008 at 03:13:48PM +1100, Neil Brown wrote: What guarantees that it doesn't happen before we get to callback? AFAICS, nothing whatsoever... Yes, that's bad isn't it :-) I think I should be using

Re: [PATCH 00/28] Swap over NFS -v16

2008-02-25 Thread Neil Brown
On Saturday February 23, [EMAIL PROTECTED] wrote: On Wed, 20 Feb 2008 15:46:10 +0100 Peter Zijlstra [EMAIL PROTECTED] wrote: Another posting of the full swap over NFS series. Well I looked. There's rather a lot of it and I wouldn't pretend to understand it. But pretending is fun :-)

Re: [PATCH v2] sunrpc: fix waitqueue_active without memory barrier in sunrpc

2015-10-15 Thread Neil Brown
"J. Bruce Fields" writes: > On Thu, Oct 15, 2015 at 11:44:20AM +, Kosuke Tatsukawa wrote: >> Tatsukawa Kosuke wrote: >> > J. Bruce Fields wrote: >> >> Thanks for the detailed investigation. >> >> >> >> I think it would be worth adding a comment if that might help

Re: [PATCH v2] sunrpc: fix waitqueue_active without memory barrier in sunrpc

2015-10-08 Thread Neil Brown
Kosuke Tatsukawa writes: > There are several places in net/sunrpc/svcsock.c which calls > waitqueue_active() without calling a memory barrier. Add a memory > barrier just as in wq_has_sleeper(). > > I found this issue when I was looking through the linux source code > for