Re: Sending ipv6 packets from a kernel module

2007-05-21 Thread Neil Horman
On Mon, May 21, 2007 at 02:04:33PM +0930, Anton wrote: Hi all, Please excuse me if the following question has already been asked on the mailing list, I am a little new to this. I am trying to send IPv6 packets from a kernel module. As far as I understand, I would have to use the

[PATCH] ipvs: Fix state variable on failure to start ipvs threads

2007-06-08 Thread Neil Horman
Thanks Regards Neil Signed-off-by: Neil Horman [EMAIL PROTECTED] ip_vs_sync.c | 41 +++-- 1 file changed, 39 insertions(+), 2 deletions(-) diff --git a/net/ipv4/ipvs/ip_vs_sync.c b/net/ipv4/ipvs/ip_vs_sync.c index 7ea2d98..ff4df68 100644 --- a/net/ipv4

Re: [PATCH] ixgbe: Introduce new 10GbE driver for Intel 82598 based PCI Express adapters...

2007-07-03 Thread Neil Horman
guessing the use of fake netdevs is still a problem. I've not checked this driver for all of the potential problems we found, but I will, and let you know if I see any. Regards Neil -- /*** *Neil Horman *Software Engineer *Red Hat, Inc. [EMAIL

Re: [PATCH] ixgbe: Introduce new 10GbE driver for Intel 82598 based PCI Express adapters...

2007-07-05 Thread Neil Horman
On Tue, Jul 03, 2007 at 08:53:46AM -0400, Neil Horman wrote: On Mon, Jul 02, 2007 at 12:00:29PM -0700, Veeraiyan, Ayyappan wrote: On 7/2/07, Jeff Garzik [EMAIL PROTECTED] wrote: Ayyappan Veeraiyan wrote: +#define IXGBE_TX_FLAGS_VLAN_MASK 0x +#define

Re: [PATCH] fix ifenslave to not fail on lack of IP information

2005-11-05 Thread Neil Horman
On Fri, Nov 04, 2005 at 11:08:32PM -0800, Jason R. Martin wrote: On 11/4/05, Neil Horman [EMAIL PROTECTED] wrote: On Fri, Nov 04, 2005 at 12:25:49PM -0800, Jay Vosburgh wrote: [dropped linux-kernel; added netdev] Neil Horman [EMAIL PROTECTED] wrote: The current version

[PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-01-19 Thread Neil Horman
-By: Neil Horman [EMAIL PROTECTED] include/linux/if_addr.h|1 include/linux/sysctl.h |1 include/net/addrconf.h |4 ++- include/net/ipv6.h |1 net/ipv6/addrconf.c| 50 +++--- net/ipv6/mcast.c |4 +-- net/ipv6

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-01-19 Thread Neil Horman
On Sat, Jan 20, 2007 at 08:05:07AM +0900, YOSHIFUJI Hideaki / 吉藤英明 wrote: Hello. In article [EMAIL PROTECTED] (at Fri, 19 Jan 2007 16:23:14 -0500), Neil Horman [EMAIL PROTECTED] says: Patch to Implement IPv6 RFC 4429 (Optimistic Duplicate Address Detection). In Good work. We

[PATCH] select: fix sys_select to not leak ERESTARTNOHAND to userspace

2007-01-22 Thread Neil Horman
is incorrect. This patch moves that check outside of the conditional, and prevents the errno leak. Thanks Regards Neil Signed-off-by: Neil Horman [EMAIL PROTECTED] select.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/fs/select.c b/fs/select.c index

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-01-22 Thread Neil Horman
On Sat, Jan 20, 2007 at 08:05:07AM +0900, YOSHIFUJI Hideaki / 吉藤英明 wrote: Hello. In article [EMAIL PROTECTED] (at Fri, 19 Jan 2007 16:23:14 -0500), Neil Horman [EMAIL PROTECTED] says: Patch to Implement IPv6 RFC 4429 (Optimistic Duplicate Address Detection). In Good work. We

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-01-22 Thread Neil Horman
On Mon, Jan 22, 2007 at 08:39:24PM +0200, Mika Penttilä wrote: Neil Horman wrote: snip I think you should remove / modify the : if (!dad) goto out; which makes the rfc4429 tests not functional. --Mika Yeah, I think you're right. In fact, as I look at it more closely I think

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-01-23 Thread Neil Horman
reads more cleanly. New patch attached Regards Neil Signed-off-by: Neil Horman [EMAIL PROTECTED] include/linux/if_addr.h |1 include/linux/ipv6.h|1 include/linux/sysctl.h |1 include/net/addrconf.h |4 +- net/ipv6/addrconf.c | 55

Re: [PATCH] select: fix sys_select to not leak ERESTARTNOHAND to userspace

2007-01-23 Thread Neil Horman
On Tue, Jan 23, 2007 at 10:02:49AM +1100, Andi Kleen wrote: On Tuesday 23 January 2007 00:00, Neil Horman wrote: As it is currently written, sys_select checks its return code to convert ERESTARTNOHAND to EINTR. However, the check is within an if (tvp) clause, and so if select is called

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-01-23 Thread Neil Horman
, but from looking at them both, they should be equivalent. Thanks Regards Neil Signed-off-by: Neil Horman [EMAIL PROTECTED] include/linux/if_addr.h |1 include/linux/ipv6.h|2 + include/linux/sysctl.h |1 include/net/addrconf.h |4 +- net/ipv6/addrconf.c | 56

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-01-25 Thread Neil Horman
, Neil Horman wrote: On Tue, Jan 23, 2007 at 09:18:20AM +0900, YOSHIFUJI Hideaki / 吉藤英明 wrote: Hello. snip New patch attached, incorporating Yoshijui and Vlads latest comments. I didn't follow guidance on the ndisc_recv_ns comment, Yoshifuji, since Vlad had already suggested

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-01-25 Thread Neil Horman
fashion by checking for both flags appropriately during source address selection. Thoughts welcome. Thanks Regards Neil Signed-off-by: Neil Horman [EMAIL PROTECTED] include/linux/if_addr.h |1 include/linux/ipv6.h|2 + include/linux/sysctl.h |1 include/net/addrconf.h |4

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-01-25 Thread Neil Horman
-by: Neil Horman [EMAIL PROTECTED] include/linux/if_addr.h |1 include/linux/ipv6.h|2 + include/linux/sysctl.h |1 include/net/addrconf.h |4 +- net/ipv6/addrconf.c | 69 net/ipv6/mcast.c|4 +- net/ipv6/ndisc.c

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-01-26 Thread Neil Horman
On Thu, Jan 25, 2007 at 05:13:57PM -0500, Vlad Yasevich wrote: Hi Neil I prefer to be more explicit in my order of operation, but that does seem more consistent with the prevaling style. New patch attached. Looks good to me. One question thought. What causes the stack to

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-01-26 Thread Neil Horman
On Sat, Jan 27, 2007 at 12:44:29AM +0900, YOSHIFUJI Hideaki / 吉藤英明 wrote: In article [EMAIL PROTECTED] (at Fri, 26 Jan 2007 09:27:30 -0500), Neil Horman [EMAIL PROTECTED] says: I'm looking for it at the moment, but I too had assumed that redirecting the outgoing packet to the default

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-01-26 Thread Neil Horman
On Fri, Jan 26, 2007 at 09:13:31AM +0900, YOSHIFUJI Hideaki / 吉藤英明 wrote: In article [EMAIL PROTECTED] (at Thu, 25 Jan 2007 14:45:00 -0500), Neil Horman [EMAIL PROTECTED] says: New patch attached with most of your suggestions incorporated. I've a few comments mixed in for some

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-01-26 Thread Neil Horman
On Fri, Jan 26, 2007 at 03:28:40PM -0500, Vlad Yasevich wrote: Hi Neil Neil Horman wrote: On Fri, Jan 26, 2007 at 09:13:31AM +0900, YOSHIFUJI Hideaki / 吉藤英明 wrote: In article [EMAIL PROTECTED] (at Thu, 25 Jan 2007 14:45:00 -0500), Neil Horman [EMAIL PROTECTED] says: New patch

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-01-29 Thread Neil Horman
On Fri, Jan 26, 2007 at 04:42:41PM -0500, Vlad Yasevich wrote: Neil Horman wrote: On Fri, Jan 26, 2007 at 03:28:40PM -0500, Vlad Yasevich wrote: Hi Neil Neil Horman wrote: On Fri, Jan 26, 2007 at 09:13:31AM +0900, YOSHIFUJI Hideaki / 吉藤英明 wrote: In article [EMAIL PROTECTED] (at Thu

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-01-29 Thread Neil Horman
Quick reality check here. In thinking about how best to go about this redirection of frames to the default router, based on Dave M.s input, I think that the best solution would be in ndisc_send_ns. What I was thinking was that in ndisc_send_ns, we already detect if a source address is

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-01-30 Thread Neil Horman
On Tue, Jan 30, 2007 at 07:25:36AM +0900, YOSHIFUJI Hideaki / 吉藤英明 wrote: In article [EMAIL PROTECTED] (at Mon, 29 Jan 2007 16:30:13 -0500), Neil Horman [EMAIL PROTECTED] says: Quick reality check here. In thinking about how best to go about this redirection of frames to the default

[PATCH] IPv6: Fix up some CONFIG typos

2007-01-30 Thread Neil Horman
Hey- Noticed some typos in some configurable options while going through the IPv6 code. Patch attached to clean them up. Thanks Regards Neil Signed-off-by: Neil Horman [EMAIL PROTECTED] addrconf.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ipv6

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-01-31 Thread Neil Horman
On Wed, Jan 31, 2007 at 01:16:29AM +0900, YOSHIFUJI Hideaki / 吉藤英明 wrote: In article [EMAIL PROTECTED] (at Tue, 30 Jan 2007 08:02:08 -0500), Neil Horman [EMAIL PROTECTED] says: I do not think we should copy neighbor information from (one of) default routers, but use temporary neigh

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-02-02 Thread Neil Horman
to incomplete neighbors by instead looking up a default router in ip6_dst_lookup_tail, as I described in my previous note. Thoughts and comments appreciated Thanks Regards Neil Signed-off-by: Neil Horman [EMAIL PROTECTED] include/linux/if_addr.h |1 include/linux/ipv6.h|4 ++ include

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-02-02 Thread Neil Horman
On Fri, Feb 02, 2007 at 11:46:08AM -0800, David Miller wrote: From: Neil Horman [EMAIL PROTECTED] Date: Fri, 2 Feb 2007 14:06:34 -0500 Ok, I'm still testing it, but heres a new patch for review. Significant changes include the addition of a CONFIG_IPV6_OPTIMISTIC_DAD option

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-02-03 Thread Neil Horman
On Fri, Feb 02, 2007 at 05:22:31PM -0500, Vlad Yasevich wrote: Neil Horman wrote: On Fri, Feb 02, 2007 at 11:46:08AM -0800, David Miller wrote: From: Neil Horman [EMAIL PROTECTED] Date: Fri, 2 Feb 2007 14:06:34 -0500 Ok, I'm still testing it, but heres a new patch for review

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-02-03 Thread Neil Horman
On Fri, Feb 02, 2007 at 04:50:35PM -0500, Vlad Yasevich wrote: Neil Horman wrote: Ok, I'm still testing it, but heres a new patch for review. Significant changes include the addition of a CONFIG_IPV6_OPTIMISTIC_DAD option that is dependent on the inclusion of both IPPV6

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-02-03 Thread Neil Horman
On Fri, Feb 02, 2007 at 06:57:37PM -0500, Brian Haley wrote: Hi Vlad, Vlad Yasevich wrote: Brian Haley wrote: Hi Neil, @@ -830,7 +836,8 @@ retry: ift = !max_addresses || ipv6_count_addresses(idev) max_addresses ? ipv6_add_addr(idev, addr, tmp_plen, -

Re: [PATCH 1/2] e1000: fix netpoll with NAPI

2006-06-06 Thread Neil Horman
://vger.kernel.org/majordomo-info.html -- /*** *Neil Horman *Software Engineer *gpg keyid: 1024D / 0x92A74FA1 - http://pgp.mit.edu ***/ - To unsubscribe from this list: send the line unsubscribe netdev

Re: [PATCH 1/2] e1000: fix netpoll with NAPI

2006-06-06 Thread Neil Horman
On Tue, Jun 06, 2006 at 09:39:25AM -0700, Mitch Williams wrote: On Tue, 2006-06-06 at 09:52 -0400, Neil Horman wrote: I've been speaking about this fix with a Jeff Moyer, and we've come up with some concerns regarding its implementation. Specifically the call to adapter-clean_rx

Re: [PATCH 1/2] e1000: fix netpoll with NAPI

2006-06-07 Thread Neil Horman
. This fixes the netdump regression, and eliminates the layering violation and the potential race that we've been discussing. I've just tested it with netdump here and it works quite well. Thoughts appreciated. Thanks Regards Neil Signed-off-by: Neil Horman [EMAIL PROTECTED] e1000_main.c | 54

Re: [PATCH 1/2] e1000: fix netpoll with NAPI

2006-06-07 Thread Neil Horman
: Signed-off-by: Neil Horman [EMAIL PROTECTED] e1000_main.c | 54 +- 1 files changed, 45 insertions(+), 9 deletions(-) --- linux-2.6.9/drivers/net/e1000/e1000_main.c.neil 2006-06-06 10:37:42.0 -0400 +++ linux-2.6.9/drivers/net

Re: [PATCH 1/2] e1000: fix netpoll with NAPI

2006-06-11 Thread Neil Horman
On Thu, Jun 08, 2006 at 01:29:00PM -0400, Jeff Moyer wrote: == Regarding Re: [PATCH 1/2] e1000: fix netpoll with NAPI; Mitch Williams [EMAIL PROTECTED] adds: mitch.a.williams On Wed, 2006-06-07 at 11:44 -0700, Jeff Moyer wrote: That patch locks around the tx clean routine. As such, it

Re: [PATCH 1/2] e1000: fix netpoll with NAPI

2006-06-12 Thread Neil Horman
On Mon, Jun 12, 2006 at 09:42:14AM -0700, Mitch Williams wrote: On Sun, 2006-06-11 at 17:13 -0700, Neil Horman wrote: Any further thoughts on this guys? I still think my last solution solves all of the netpoll problems, and isn't going to have any noticable impact on performance. I

Re: [PATCH] netpoll: break recursive loop in netpoll rx path

2006-06-12 Thread Neil Horman
On Mon, Jun 12, 2006 at 10:51:21AM -0500, Matt Mackall wrote: On Mon, Jun 12, 2006 at 11:40:29AM -0400, Neil Horman wrote: Hey there- the netpoll system currently has a rx to tx path via: netpoll_rx __netpoll_rx arp_reply netpoll_send_skb dev-hard_start_tx

Re: [PATCH 1/2] e1000: fix netpoll with NAPI

2006-06-14 Thread Neil Horman
On Mon, Jun 12, 2006 at 02:06:00PM -0400, Neil Horman wrote: On Mon, Jun 12, 2006 at 09:42:14AM -0700, Mitch Williams wrote: On Sun, 2006-06-11 at 17:13 -0700, Neil Horman wrote: Any further thoughts on this guys? I still think my last solution solves all of the netpoll problems

Re: [Bonding-devel] Re: [PATCH] fix ifenslave to not fail on lack of IP information

2005-11-22 Thread Neil Horman
: Invalid argument. Of course works fine with Mr. Horman's patch, too :-) I would appreciate any comment. Best Regards, Tomoe Sugihara At Fri, 4 Nov 2005 23:08:32 -0800, Jason R. Martin wrote: On 11/4/05, Neil Horman [EMAIL PROTECTED] wrote

Re: static ARP doesnt work

2005-11-28 Thread Neil Horman
. I just tried this against 2.6.15, and it works fine. I imagine if you looked through the git history you could find the patch that fixed it up. Regards Neil -- /*** *Neil Horman *Software Engineer *gpg keyid: 1024D / 0x92A74FA1 - http

Re: static ARP doesnt work

2005-11-28 Thread Neil Horman
On Mon, Nov 28, 2005 at 07:35:24PM +0200, andrei.popa wrote: On Mon, 2005-11-28 at 10:15 -0500, Neil Horman wrote: On Mon, Nov 28, 2005 at 05:00:44PM +0200, andrei.popa wrote: On Mon, 2005-11-28 at 07:47 -0500, Neil Horman wrote: On Mon, Nov 28, 2005 at 12:26:41PM +0200, andrei.popa

Re: static ARP doesnt work

2005-11-28 Thread Neil Horman
is 10.3.191.191 and netmask is 255.255.0.0, the same netmask has 10.3.0.1 Very odd. I'll try building a kernel with your config and let you know the results. Neil -- /*** *Neil Horman *Software Engineer *gpg keyid: 1024D / 0x92A74FA1 - http://pgp.mit.edu

[PATCH] ARP: Update Kconfig to allow configuration of CONFIG_IP_ACCEPT_UNSOLICITED_ARP

2006-01-31 Thread Neil Horman
. Thanks Regards Neil Signed-off-by: Neil Horman [EMAIL PROTECTED] Kconfig | 10 ++ 1 files changed, 10 insertions(+) diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig --- a/net/ipv4/Kconfig +++ b/net/ipv4/Kconfig @@ -231,6 +231,16 @@ config IP_PNP_RARP operating on your network

Re: [PATCH] ARP: Update Kconfig to allow configuration of CONFIG_IP_ACCEPT_UNSOLICITED_ARP

2006-02-01 Thread Neil Horman
if they want this on and everyone is happy. Note that this probably belongs next to arp_{announce,filter,ignore}, when deciding where to put the sysctl. Will do, I'll repost this today. Thanks! Neil -- /*** *Neil Horman *Software Engineer

Re: [PATCH] ARP: Update Kconfig to allow configuration of CONFIG_IP_ACCEPT_UNSOLICITED_ARP

2006-02-01 Thread Neil Horman
As promised, new patch attached, that makes accepting gratuitous arps a dynamically configurable option. Tested successfully by me. Thanks Regards Neil Signed-off-by: Neil Horman [EMAIL PROTECTED] include/linux/inetdevice.h |1 + include/linux/sysctl.h |3 ++- net/ipv4/arp.c

Re: [PATCH] ARP: Update Kconfig to allow configuration of CONFIG_IP_ACCEPT_UNSOLICITED_ARP

2006-02-01 Thread Neil Horman
On Wed, Feb 01, 2006 at 08:54:36PM -0500, John W. Linville wrote: On Wed, Feb 01, 2006 at 04:37:53PM -0500, Neil Horman wrote: As promised, new patch attached, that makes accepting gratuitous arps a dynamically configurable option. Tested successfully by me. Probably need some

[PATCH] Docs: documentation for new arp_accept sysctl variable

2006-02-02 Thread Neil Horman
As John pointed out, I had not added documentation to describe the arp_accpet sysctl that I posted in my last patch. This patch adds that documentation. Thanks Regards Neil Signed-off-by: Neil Horman [EMAIL PROTECTED] ip-sysctl.txt |5 + 1 files changed, 5 insertions(+) diff --git

[PATCH] sis900: Allocate rx replacement buffer before rx operation

2007-04-20 Thread Neil Horman
skbuf in the rx ring is recycled, dropping the current frame, but keeping the NIC operational. Thanks Regards Neil Signed-off-by: Neil Horman [EMAIL PROTECTED] sis900.c | 44 1 file changed, 20 insertions(+), 24 deletions(-) commit

Re: sysctls

2007-04-25 Thread Neil Horman
On Wed, Apr 25, 2007 at 01:45:19PM -0600, Eric W. Biederman wrote: Andrew Morton [EMAIL PROTECTED] writes: I note that the networking tree is adding new sysctls: HEAD/include/linux/sysctl.h NET_IPV6_ACCEPT_SOURCE_ROUTE=25, === NET_IPV6_OPTIMISTIC_DAD=24,

Re: sysctls

2007-04-26 Thread Neil Horman
On Wed, Apr 25, 2007 at 04:47:34PM -0700, David Miller wrote: From: Andrew Morton [EMAIL PROTECTED] Date: Wed, 25 Apr 2007 14:50:18 -0700 On Wed, 25 Apr 2007 15:53:19 -0400 Neil Horman [EMAIL PROTECTED] wrote: I did the optimistic dad sysctl, and have no strict use for numbered

Re: [PATCH] sis900: Allocate rx replacement buffer before rx operation

2007-04-26 Thread Neil Horman
On Tue, Apr 24, 2007 at 12:43:20PM -0400, Jeff Garzik wrote: Neil Horman wrote: Hey there- The sis900 driver appears to have a bug in which the receive routine passes the skbuff holding the received frame to the network stack before refilling the buffer in the rx ring. If a new skbuff

Re: [PATCH] sis900: Allocate rx replacement buffer before rx operation

2007-04-26 Thread Neil Horman
On Thu, Apr 26, 2007 at 01:47:36PM -0400, Neil Horman wrote: On Tue, Apr 24, 2007 at 12:43:20PM -0400, Jeff Garzik wrote: Neil Horman wrote: Hey there- The sis900 driver appears to have a bug in which the receive routine passes the skbuff holding the received frame to the network stack

Re: [PATCH] sis900: Allocate rx replacement buffer before rx operation

2007-04-28 Thread Neil Horman
diff --git a/drivers/net/sis900.c b/drivers/net/sis900.c index a6a0f09..7e44939 100644 --- a/drivers/net/sis900.c +++ b/drivers/net/sis900.c @@ -1754,6 +1754,7 @@ static int sis900_rx(struct net_device *net_dev) sis_priv-rx_ring[entry].cmdsts = RX_BUF_SIZE;

Re: [Lksctp-developers] Question about skb clones and frag_list

2006-04-05 Thread Neil Horman
-- /*** *Neil Horman *Software Engineer *gpg keyid: 1024D / 0x92A74FA1 - http://pgp.mit.edu ***/ - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-02-06 Thread Neil Horman
On Tue, Feb 06, 2007 at 10:24:05AM +0900, YOSHIFUJI Hideaki / 吉藤英明 wrote: Hello. snip Thank you Yoshifuji. To be honest, I've been focused on functionality rather than pretty so far, figuring I'd clean up the tabbing from my various patch inclusions/reversions when we had agreed that the

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-02-06 Thread Neil Horman
On Tue, Feb 06, 2007 at 07:51:44AM -0500, Neil Horman wrote: On Tue, Feb 06, 2007 at 10:24:05AM +0900, YOSHIFUJI Hideaki / 吉藤英明 wrote: Hello. snip Thank you Yoshifuji. To be honest, I've been focused on functionality rather Ok, New patch attached, taking Vlad and Yoshifujis latest

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-02-07 Thread Neil Horman
! Thanks Regards Neil Signed-off-by: Neil Horman [EMAIL PROTECTED] include/linux/if_addr.h |1 include/linux/ipv6.h|4 ++ include/linux/sysctl.h |1 include/net/addrconf.h |4 +- net/ipv6/Kconfig| 10 + net/ipv6/addrconf.c | 90

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-02-08 Thread Neil Horman
On Thu, Feb 08, 2007 at 06:52:06AM +0900, YOSHIFUJI Hideaki / 吉藤英明 wrote: In article [EMAIL PROTECTED] (at Wed, 7 Feb 2007 15:55:03 -0500), Neil Horman [EMAIL PROTECTED] says: diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c index 7b7bd44..8a1ea96 100644 --- a/net/ipv6

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-02-08 Thread Neil Horman
On Thu, Feb 08, 2007 at 07:26:20AM +0900, YOSHIFUJI Hideaki / 吉藤英明 wrote: In article [EMAIL PROTECTED] (at Wed, 7 Feb 2007 15:55:03 -0500), Neil Horman [EMAIL PROTECTED] says: @@ -559,7 +562,7 @@ void ndisc_send_ns(struct net_device *dev, struct neighbour *neigh, return

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-02-08 Thread Neil Horman
On Fri, Feb 09, 2007 at 02:10:37AM +0900, YOSHIFUJI Hideaki / 吉藤英明 wrote: In article [EMAIL PROTECTED] (at Thu, 8 Feb 2007 11:41:52 -0500), Neil Horman [EMAIL PROTECTED] says: snip These should be placed } here. No? Yes, you're right. After re-reading the logic, its pretty

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-02-12 Thread Neil Horman
New patch attached with these fixes included Ping? Any further thoughts here? My (allbeit limited) testing seems to be going fairly well so far... Neil Thanks Regards Neil Signed-off-by: Neil Horman [EMAIL PROTECTED] include/linux/if_addr.h |1 include/linux/ipv6.h

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-02-13 Thread Neil Horman
On Tue, Feb 13, 2007 at 08:27:59AM +0900, YOSHIFUJI Hideaki / 吉藤英明 wrote: In article [EMAIL PROTECTED] (at Thu, 8 Feb 2007 08:07:15 -0500), Neil Horman [EMAIL PROTECTED] says: I still have a question. Now, who will install the kernel route for the incoming packet? Can we get packet

Re: /proc/sys/net/ipv[46]/conf/ issue unsolved

2007-02-13 Thread Neil Horman
On Tue, Feb 13, 2007 at 07:49:50PM +, Hugo Santos wrote: Yes, I understand that, but until the IFF_UP flag is set on the interface, it doesn't really have any effect on the system as a whole. You should be able to undo any default setting that you want before you call ifup on the

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-02-13 Thread Neil Horman
it in ipv6_ifa_notify if the route has not already been added. Route deltion should still be common with non-optimistic cases since the route is removed on interface deletion from ipv6_ifa_notify, which occurs in the common code path ipv6_del_addr. Thanks Regards Neil Signed-off-by: Neil Horman [EMAIL

Re: /proc/sys/net/ipv[46]/conf/ issue unsolved

2007-02-13 Thread Neil Horman
On Tue, Feb 13, 2007 at 03:29:04PM +0200, Hasso Tepper wrote: There is long standing issue in kernel which makes using /etc/sysctl.conf useless for boottime configuration of specific interface properties and breaks probably any software relying on unconditional existence of the conf trees like

Re: /proc/sys/net/ipv[46]/conf/ issue unsolved

2007-02-13 Thread Neil Horman
On Tue, Feb 13, 2007 at 02:43:32PM -0500, Vlad Yasevich wrote: Neil Horman wrote: On Tue, Feb 13, 2007 at 03:29:04PM +0200, Hasso Tepper wrote: There is long standing issue in kernel which makes using /etc/sysctl.conf useless for boottime configuration of specific interface properties

Re: sky2 bonding problem, 802.3ad

2007-02-15 Thread Neil Horman
On Thu, Feb 15, 2007 at 10:09:40PM +0100, Holger Eitzenberger wrote: Jay Vosburgh [EMAIL PROTECTED] writes: I'm unfamiliar with your particular switch, but usually this kind of problem with bonding 802.3ad is in the switch interaction. The switches I have (Cisco) require that 802.3ad

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-02-21 Thread Neil Horman
On Wed, Feb 21, 2007 at 01:30:31AM -0800, David Miller wrote: From: YOSHIFUJI Hideaki [EMAIL PROTECTED] Date: Wed, 21 Feb 2007 17:15:45 +0900 (JST) In article [EMAIL PROTECTED] (at Wed, 21 Feb 2007 00:02:22 -0800 (PST)), David Miller [EMAIL PROTECTED] says: So, I think it is ready.

[PATCH] sky2: fix trucated collision threshold mask

2006-07-07 Thread Neil Horman
Patch to correct broken collision threshold mask in sky2 driver. Should be three bits wide, but the mask only allows for 1 bit to be set. Thanks Regards Neil Signed-off-by: Neil Horman [EMAIL PROTECTED] sky2.h |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

Re: [PATCH] Create IP100A Driver

2006-07-27 Thread Neil Horman
*pci_dev; + UCHAR pci_rev_id; + UCHAR ProbeDone; Definately need to use the kernel internal types, and may want to change ProbeDone to be stylistically in line with the other variables in this struct (i.e. probe_done). -- /*** *Neil

Re: [PATCH] Create IP100A Driver

2006-07-27 Thread Neil Horman
from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html -- /*** *Neil Horman *Software Engineer *gpg keyid: 1024D / 0x92A74FA1 - http

Re: [PATCH] ixgbe: Introduce new 10GbE driver for Intel 82598 based PCI Express adapters...

2007-07-09 Thread Neil Horman
On Mon, Jul 09, 2007 at 07:21:24AM -0700, Veeraiyan, Ayyappan wrote: From: Neil Horman [mailto:[EMAIL PROTECTED] Replying to myself... I've looked through the driver pretty throughly with regards to my above concern, and it appears the driver is reasonably free of netpoll issues

Re: tg3 issues

2007-07-19 Thread Neil Horman
) executes a switch_root or pivot_root operation That way you can calibrate a delay between steps (A) and (B) in your initramfs init script Regards Neil -- /*** *Neil Horman *Software Engineer *Red Hat, Inc. [EMAIL PROTECTED] *gpg keyid: 1024D

Re: [Lksctp-developers] [PATCH] SCTP: drop SACK if ctsn is not less than the next tsn of assoc

2007-07-31 Thread Neil Horman
-developers -- /*** *Neil Horman *Software Engineer *Red Hat, Inc. [EMAIL PROTECTED] *gpg keyid: 1024D / 0x92A74FA1 *http://pgp.mit.edu ***/ - To unsubscribe from this list: send the line unsubscribe

Re: [Lksctp-developers] [PATCH] SCTP: drop SACK if ctsn is not less than the next tsn of assoc

2007-08-01 Thread Neil Horman
security holes. Neil -- /*** *Neil Horman *Software Engineer *Red Hat, Inc. [EMAIL PROTECTED] *gpg keyid: 1024D / 0x92A74FA1 *http://pgp.mit.edu ***/ - To unsubscribe from this list: send

Re: [PATCH for 2.6.24] SCTP: Rewrite of sctp buffer management code

2007-08-10 Thread Neil Horman
window still has room. This might happen if small message sizes are used, which is common in telecom environmens. New tunables are introduced that provide limits to buffer growth and memory pressure is entered if to much buffer spaces is used. Signed-off-by: Neil Horman [EMAIL PROTECTED

Re: [PATCH for 2.6.24] SCTP: Rewrite of sctp buffer management code

2007-08-10 Thread Neil Horman
On Fri, Aug 10, 2007 at 04:37:59PM -0700, David Miller wrote: From: Neil Horman [EMAIL PROTECTED] Date: Fri, 10 Aug 2007 19:01:26 -0400 Thanks for applying this Dave, but something seems to have occured during your application. The commitdiff: http://git.kernel.org/?p=linux/kernel

Re: [PATCH for 2.6.24] SCTP: Rewrite of sctp buffer management code

2007-08-13 Thread Neil Horman
-- /*** *Neil Horman *Software Engineer *Red Hat, Inc. [EMAIL PROTECTED] *gpg keyid: 1024D / 0x92A74FA1 *http://pgp.mit.edu ***/ - To unsubscribe from this list: send the line unsubscribe netdev in the body

[PATCH] xfrm: export sysctl_xfrm_acq_expires

2007-08-22 Thread Neil Horman
handles that. Thanks Regards Neil Signed-off-by: Neil Horman [EMAIL PROTECTED] xfrm_state.c |1 + 1 file changed, 1 insertion(+) diff --git a/net/xfrm/xfrm_state.c b/net/xfrm/xfrm_state.c index d4356e6..62ae5a2 100644 --- a/net/xfrm/xfrm_state.c +++ b/net/xfrm/xfrm_state.c @@ -34,6 +34,7

Re: [Lksctp-developers] [2.6 patch] make sctp_addto_param() static

2007-09-10 Thread Neil Horman
On Sun, Sep 09, 2007 at 10:25:50PM +0200, Adrian Bunk wrote: sctp_addto_param() can become static. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] ACK, seems reasonable to me. Neil -- /*** *Neil Horman [EMAIL PROTECTED] *gpg keyid: 1024D

Re: [Lksctp-developers] [-mm patch] net/sctp/socket.c: make 3 variables static

2007-09-10 Thread Neil Horman
: - sctp_memory_pressure - sctp_memory_allocated - sctp_sockets_allocated Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Looks fine to me Acked-by: Neil Horman [EMAIL PROTECTED] Neil -- /*** *Neil Horman [EMAIL PROTECTED] *gpg keyid: 1024D / 0x92A74FA1 *http

Re: Linux IPv6 DAD not full conform to RFC 4862 ?

2008-01-09 Thread Neil Horman
On Wed, Jan 09, 2008 at 04:36:56PM +0100, Karsten Keil wrote: Hi, I tried to run the 1.5.0 Beta2 TAHI Selftest on recent Linux kernel. It fails in the Stateless Address Autoconfiguration section with 6 tests. These tests are for Duplicate Address Detection (DAD). They are detect for the

Re: Linux IPv6 DAD not full conform to RFC 4862 ?

2008-01-09 Thread Neil Horman
On Thu, Jan 10, 2008 at 01:38:57AM +0900, YOSHIFUJI Hideaki / 吉藤英明 wrote: In article [EMAIL PROTECTED] (at Wed, 9 Jan 2008 16:36:56 +0100), Karsten Keil [EMAIL PROTECTED] says: So I think we should disable the interface now, if DAD fails on a hardware based LLA. I don't want to do

Re: Linux IPv6 DAD not full conform to RFC 4862 ?

2008-01-10 Thread Neil Horman
On Wed, Jan 09, 2008 at 04:09:57PM -0500, Vlad Yasevich wrote: Neil Horman wrote: On Thu, Jan 10, 2008 at 01:38:57AM +0900, YOSHIFUJI Hideaki / 吉藤英明 wrote: In article [EMAIL PROTECTED] (at Wed, 9 Jan 2008 16:36:56 +0100), Karsten Keil [EMAIL PROTECTED] says: So I think we should disable

Re: [Lksctp-developers] [PATCH] SCTP: Fix kernel panic while received AUTH chunk with BAD shared key identifier

2008-01-24 Thread Neil Horman
endpoint_shared_keys. Since that list_head isn't surrounded by an actuall data structure, the last iteration through list_for_each_entry will do a container_of on key, and we wind up returning a bogus pointer, instead of NULL, as we should. Wei's patch corrects that. Regards Neil Acked-by: Neil Horman [EMAIL

Re: [PATCH v3 1/2] sctp: rcu-ify addr_waitq

2015-06-09 Thread Neil Horman
On Mon, Jun 08, 2015 at 05:37:05PM +0200, Hannes Frederic Sowa wrote: On Mo, 2015-06-08 at 11:19 -0400, Neil Horman wrote: On Mon, Jun 08, 2015 at 04:59:18PM +0200, Hannes Frederic Sowa wrote: On Mon, Jun 8, 2015, at 16:46, Hannes Frederic Sowa wrote: Hi Marcelo, a few hints

Re: [PATCH] sctp: Simplify and make the function sctp_assoc_lookup_laddr bool

2015-06-05 Thread Neil Horman
and thus remove the no longer required if statement due to this function now being declared as bool. Signed-off-by: Nicholas Krause xerofo...@gmail.com Acked-by: Neil Horman nhor...@tuxdriver.com -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord

Re: [PATCH] sctp: Simplify and make the function sctp_assoc_lookup_laddr bool

2015-06-06 Thread Neil Horman
of us to see what is in his patch. Thanks. Sure, though that begs the question, why is he banned from vger? Is it his gmail address, or something more directed? Neil On 06/05/2015 03:16 PM, Neil Horman wrote: This makes the function sctp_assoc_lookup_laddr bool due to it only returning

Re: [PATCH v3 1/2] sctp: rcu-ify addr_waitq

2015-06-08 Thread Neil Horman
for cmd:%d, addr:%pISc in wq:%p\n, __func__, addrw-state, addrw-a.sa, net-sctp.addr_waitq); -- 2.4.1 Acked-by: Neil Horman nhor...@tuxdriver.com -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More

Re: [PATCH v3 1/2] sctp: rcu-ify addr_waitq

2015-06-08 Thread Neil Horman
On Mon, Jun 08, 2015 at 04:59:18PM +0200, Hannes Frederic Sowa wrote: On Mon, Jun 8, 2015, at 16:46, Hannes Frederic Sowa wrote: Hi Marcelo, a few hints on rcuification, sorry I reviewed the code so late: On Fri, Jun 5, 2015, at 19:08, mleit...@redhat.com wrote: From: Marcelo

Re: [PATCH] sctp: Make the function sctp_chunk_abandoned bool

2015-06-03 Thread Neil Horman
; - return 0; + return false; } /* This chunk (and consequently entire message) has failed in its sending. */ -- 2.1.4 Seems reasonable Acked-by: Neil Horman nhor...@tuxdriver.com -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message

Re: [PATCH net-next] net: change fib behavior based on interface link status

2015-06-03 Thread Neil Horman
On Wed, Jun 03, 2015 at 04:13:08PM +0200, Hannes Frederic Sowa wrote: On Mi, 2015-06-03 at 09:53 -0400, Neil Horman wrote: On Tue, Jun 02, 2015 at 11:07:19PM -0400, Andy Gospodarek wrote: This patch adds the ability to have the Linux kernel track whether or not a particular route should

Re: [PATCH net-next] net: change fib behavior based on interface link status

2015-06-03 Thread Neil Horman
On Tue, Jun 02, 2015 at 11:07:19PM -0400, Andy Gospodarek wrote: This patch adds the ability to have the Linux kernel track whether or not a particular route should be used based on the link-status of the interface associated with the next-hop. Before this patch any link-failure on an

Re: [PATCH net-next] net: change fib behavior based on interface link status

2015-06-03 Thread Neil Horman
On Wed, Jun 03, 2015 at 10:46:22AM -0400, Andy Gospodarek wrote: On Wed, Jun 03, 2015 at 10:21:31AM -0400, Neil Horman wrote: On Wed, Jun 03, 2015 at 04:13:08PM +0200, Hannes Frederic Sowa wrote: On Mi, 2015-06-03 at 09:53 -0400, Neil Horman wrote: On Tue, Jun 02, 2015 at 11:07:19PM

Re: [PATCH v2 1/2] sctp: rcu-ify addr_waitq

2015-06-04 Thread Neil Horman
On Wed, Jun 03, 2015 at 01:54:01PM -0300, mleit...@redhat.com wrote: From: Marcelo Ricardo Leitner marcelo.leit...@gmail.com That's needed for the next patch, so we break the lock inversion between netns_sctp-addr_wq_lock and socket lock on sctp_addr_wq_timeout_handler(). With this, we can

Re: [PATCH] sctp:Make the function sctp_assoc_lookup_laddr bool

2015-06-04 Thread Neil Horman
On Wed, Jun 03, 2015 at 08:51:07AM -0400, Nicholas Krause wrote: This makes the function sctp_assoc_lookup_laddr bool due to this function only returning either one or zero as its return value. Signed-off-by: Nicholas Krause xerofo...@gmail.com --- include/net/sctp/structs.h | 4 ++--

Re: [PATCH v3 1/2] sctp: rcu-ify addr_waitq

2015-06-10 Thread Neil Horman
On Wed, Jun 10, 2015 at 10:31:42AM -0300, Marcelo Ricardo Leitner wrote: On Tue, Jun 09, 2015 at 04:32:59PM -0300, Marcelo Ricardo Leitner wrote: On Tue, Jun 09, 2015 at 07:36:38AM -0400, Neil Horman wrote: On Mon, Jun 08, 2015 at 05:37:05PM +0200, Hannes Frederic Sowa wrote: On Mo, 2015

Re: [PATCH] sctp: allow authenticating DATA chunks that are bundled with COOKIE_ECHO

2015-06-12 Thread Neil Horman
would move some chunks to a packet, but not flush it to the network layer yet (due to not being full), and that would result in the same condition. But since this only happens with a COOKIE_ECHO chunk (which is a control chunk), we should be ok, as those are sent immediately. Acked-by: Neil Horman

Re: [RFC PATCH 0/2] sctp: add new getsockopt option SCTP_SOCKOPT_PEELOFF_KERNEL

2015-06-17 Thread Neil Horman
On Wed, Jun 17, 2015 at 10:40:26AM -0300, Marcelo Ricardo Leitner wrote: On 17-06-2015 10:16, Neil Horman wrote: On Wed, Jun 17, 2015 at 09:40:32AM -0300, Marcelo Ricardo Leitner wrote: On 17-06-2015 09:20, Neil Horman wrote: On Wed, Jun 17, 2015 at 08:38:10AM -0300, Marcelo Ricardo Leitner

Re: [RFC PATCH 0/2] sctp: add new getsockopt option SCTP_SOCKOPT_PEELOFF_KERNEL

2015-06-17 Thread Neil Horman
On Wed, Jun 17, 2015 at 08:38:10AM -0300, Marcelo Ricardo Leitner wrote: On 17-06-2015 07:21, Neil Horman wrote: On Tue, Jun 16, 2015 at 07:42:31PM -0300, Marcelo Ricardo Leitner wrote: Hi, I'm trying to remove a direct dependency of dlm module on sctp one. Currently dlm code is calling

  1   2   3   4   5   >