Signed-off-by: Phil Sutter <p...@nwl.cc>
---
.gitignore | 1 +
doc/Makefile | 2 +-
doc/tc-filters.tex | 529 +
3 files changed, 531 insertions(+), 1 deletion(-)
create mode 100644 doc/tc-filters.tex
diff --git a/.gitig
Cc: Felix Fietkau <n...@openwrt.org>
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
man/man8/tc-connmark.8 | 55 ++
1 file changed, 55 insertions(+)
create mode 100644 man/man8/tc-connmark.8
diff --git a/man/man8/tc-connmark.8 b/man/man8
Cc: Alexey Kuznetsov <kuz...@ms2.inr.ac.ru>
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
man/man8/tc-police.8 | 127 +++
1 file changed, 127 insertions(+)
create mode 100644 man/man8/tc-police.8
diff --git a/man/man8/tc-police.8 b
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
man/man8/tc-pedit.8 | 230
1 file changed, 230 insertions(+)
create mode 100644 man/man8/tc-pedit.8
diff --git a/man/man8/tc-pedit.8 b/man/man8/tc-pedit.8
new file mode 100644
index 000
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
man/man8/tc-simple.8 | 76
1 file changed, 76 insertions(+)
create mode 100644 man/man8/tc-simple.8
diff --git a/man/man8/tc-simple.8 b/man/man8/tc-simple.8
new file mode 100644
index 000
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
man/man8/Makefile | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/man/man8/Makefile b/man/man8/Makefile
index 2f77640676df5..d3fdf66ab11d4 100644
--- a/man/man8/Makefile
+++ b/man/man8/Makefile
@@ -14,7 +14,9 @@ MAN
The following series adds a set of man pages for previously
undocumented tc actions. On top of that, it adds an article about the
same topic to the docs directory I wrote a little while ago.
Phil Sutter (12):
man: Add a man page for the connmark action
man: Add a man page for the csum action
Cc: Jiri Pirko <j...@resnulli.us>
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
man/man8/tc-vlan.8 | 54 ++
1 file changed, 54 insertions(+)
create mode 100644 man/man8/tc-vlan.8
diff --git a/man/man8/tc-vlan.8 b/man/man8/tc-vla
Cc: Gregoire Baron <baronc...@n7mm.org>
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
man/man8/tc-csum.8 | 54 ++
1 file changed, 54 insertions(+)
create mode 100644 man/man8/tc-csum.8
diff --git a/man/man8/tc-csum.8 b/man/man8/t
Cc: Herbert Xu <herb...@gondor.apana.org.au>
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
man/man8/tc-nat.8 | 78 +++
1 file changed, 78 insertions(+)
create mode 100644 man/man8/tc-nat.8
diff --git a/man/man8/tc-nat.8 b/man/man8/
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
man/man8/tc-mirred.8 | 89
1 file changed, 89 insertions(+)
create mode 100644 man/man8/tc-mirred.8
diff --git a/man/man8/tc-mirred.8 b/man/man8/tc-mirred.8
new file mode 100644
index 000
This diff was generated by using the fix-inplace option of checkpatch.pl
and breaking the overlong lines of parse_ip() and parse_ip6()
signatures.
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
tc/p_ip.c | 36 +++-
1 file changed, 19 insertions(+), 17 del
We commonly use bold font for terminals and italic for non-terminals.
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
man/man8/ip-link.8.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/man/man8/ip-link.8.in b/man/man8/ip-link.8.in
index 221831e52bc9a..2376f1653a8f2
Also drop the non-terminal 'TIME' description as it is not referenced
anywhere.
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
man/man8/ip-tunnel.8 | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/man/man8/ip-tunnel.8 b/man/man8/ip-tunnel.8
index 8b746cb
to added 'trust' option
Phil Sutter (20):
ip: align help text with manpage
ipaddrlabel: Improve help text precision
iplink: fix help text syntax
ipneigh: add missing proxy keyword to help text
ipntable: Fix typo in help text
iproute: TYPE keyword is not optional, fix help text
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
man/man8/ip-neighbour.8 | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/man/man8/ip-neighbour.8 b/man/man8/ip-neighbour.8
index c9b0256e12207..19c6d9d8bf605 100644
--- a/man/man8/ip-neighbour.8
+++ b/man/m
Listing generic 'ip' options in subcommand man pages is redundant and
error-prone, as they won't be kept in sync anyway. Since many other man
pages don't list them either, drop references to them in the remaining
ones.
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
man/man8/ip-addrlabel.
Although the ip command accepts both "neighbor" and "neighbour" as
subcommand, I assume it's sufficient to list it in help text as just
"neigh" like ip.8 does.
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
ip/ip.c | 2 +-
1 file changed, 1 insertion(+), 1 de
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
ip/ipntable.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ip/ipntable.c b/ip/ipntable.c
index 6eb84e797b263..2763570ae34d7 100644
--- a/ip/ipntable.c
+++ b/ip/ipntable.c
@@ -52,7 +52,7 @@ static void usag
Drop unnecessary curly braces around single action keywords, point out
that 'dev' parameter to 'ip token get' is optional and clarify that 'ip
token' defaults to 'list' action.
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
man/man8/ip-token.8 | 12 ++--
1 file changed, 6 insertions
Get rid of extraneous closing brackets and while here, merge the double
netns parameter.
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
ip/iplink.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/ip/iplink.c b/ip/iplink.c
index 69f50572633b1..33d7c0ad0e827
The 'ADDR' part of 'local' and 'remote' parameters is not optional, but
may also consist of the word 'any'. While at it, add missing whitespace
and fix fonts.
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
man/man8/ip-l2tp.8 | 24 +---
1 file changed, 9 insertions(
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
ip/iprule.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/ip/iprule.c b/ip/iprule.c
index 33b71976e7b5c..7e3b38b64c6e1 100644
--- a/ip/iprule.c
+++ b/ip/iprule.c
@@ -39,6 +39,7 @@ static void usage(void)
fprintf(stderr, &qu
Clarify that 'ip rule' defaults to action 'list', that 'flush' and
'save' actions don't accept additional parameters, add missing 'not' and
'goto' keywords and finally fix fonts used in 'fwmark' and 'realms'
parameters.
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
man/man8/ip-rule.
Since the IP Header Length field is just half a byte, adjust retain to
only match these bits so the Version field is not overwritten by
accident.
The whole concept is actually broken due to dependency on endianness
which pedit ignores.
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
tc/p_ip
After lookup of the layered op submodule, pedit would pass argv and argc
including the layered op identifier at first position which confused the
submodule parser. Fix this by calling NEXT_ARG() before calling the
parse_peopt() callback.
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
tc/m_p
key*() variants.
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
tc/m_pedit.c | 23 +++
1 file changed, 7 insertions(+), 16 deletions(-)
diff --git a/tc/m_pedit.c b/tc/m_pedit.c
index 455e4ffd4b2bb..a314f482cd9c0 100644
--- a/tc/m_pedit.c
+++ b/tc/m_pedit.c
@@ -152,8 +152,6 @@ pack_ke
Namely, 'extra-flag' of 'ip xfrm state' and 'flag' of 'ip xfrm policy'.
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
man/man8/ip-xfrm.8 | 11 +++
1 file changed, 11 insertions(+)
diff --git a/man/man8/ip-xfrm.8 b/man/man8/ip-xfrm.8
index dae0728811b2e..11f710470377f 100644
---
Reflect that it is possible to pass multiple parameters at the same
time, also use the same trick the help text uses to emphasize vf
specific parameters.
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
man/man8/ip-link.8.in | 100 +++---
1 file c
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
man/man8/ip.8 | 29 -
1 file changed, 28 insertions(+), 1 deletion(-)
diff --git a/man/man8/ip.8 b/man/man8/ip.8
index b1f6907367275..aa2bc68c81ab6 100644
--- a/man/man8/ip.8
+++ b/man/man8/ip.8
@@ -21,7 +21,7 @@ ip \
'.
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
man/man8/ip-address.8.in | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/man/man8/ip-address.8.in b/man/man8/ip-address.8.in
index 159d9065f0c9b..ff3fe0b96b02a 100644
--- a/man/man8/ip-address.8.in
+++ b/man/man8/ip-add
Neither 'list' nor 'flush' actions accept parameters, and with given
prefix the action keyword is not optional anymore.
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
ip/ipaddrlabel.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/ip/ipaddrlabel.c b/ip/ipaddrlabel.c
And while we're at it, add whitespace around braces and pipe symbol.
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
ip/ipneigh.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ip/ipneigh.c b/ip/ipneigh.c
index 92b7cd6f2a75b..9b1499b08b060 100644
--- a/ip/ipneigh.c
++
Use brackets to show that 'ip netns' defaults to action 'list', drop
superfluous curly braces around 'set' action keyword.
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
man/man8/ip-netns.8 | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/man/man8/ip-netns.8 b/man/m
The first line contained a c'n'p error, incorrectly listing 'ip address'
syntax. Since PARAMS is used just once and there are not many other
parameters to 'ip ntable change', state them inline and in addition to
that clarify the possibility to pass multiple parameters at once.
Signed-off-by: Phil
This is a bit pedantic, but brackets ([]) show optional values and since
TYPE must not become empty, they're not suited to surround the type
keyword choices. Use curly braces instead.
Also add some missing whitespace to the parameter list above.
Signed-off-by: Phil Sutter <p...@nwl.cc>
-
8<---------
Changes since v1:
- rebased onto current master
- added required whitespace after comma in patch 3
- new patch 4 fixing remaining checkpatch.pl issues in tc/p_ip.c
Phil Sutter (4):
tc: pedit: Fix laye
To not make the output overly confusing, list them in a definition of
the STATE placeholder which is already used in the show/flush syntax but
wasn't explained before.
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
ip/ipneigh.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
The following aims at documenting all nud states 'ip neigh' supports, not just
the most common ones. This includes describing them in the relevant man page as
well as extending 'ip neigh help' output.
Phil Sutter (2):
man: ip-neighbour.8: Document all known nud states
ipneigh: List all nud
ust double the buffer size to 32k.
Feels like this opportunistic buffer size selection is rather
workarounding a design flaw in libnetlink or maybe even the netlink
protocol itself.
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
lib/libnetlink.c | 2 +-
1 file changed, 1 insertion(+), 1 d
Not sure how useful they are in practice, but as 'ip neigh' supports
setting them all, they deserve to be described as well.
While at it, also add a missing layer of indentation to the subordinate
nud state list.
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
man/man8/ip-neighbour.
then.
* With the last change to the algorithm in place, it does not make sense
to call update_db() before returning data to the connected client.
Actually, it never does otherwise we could skip the periodic updates
in the first place.
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
misc/if
On Wed, Mar 02, 2016 at 11:05:33AM -0800, Stephen Hemminger wrote:
> On Wed, 2 Mar 2016 19:45:39 +0100
> Phil Sutter <p...@nwl.cc> wrote:
>
> > While implementing an implementation example for a pedit man page, I
> > noticed several issues with the current code. The
From: Phil Sutter <p...@nwl.cc>
Before calling the destroy() or target() callbacks, the family parameter
field has to be initialized. Otherwise at least the LOG target will
refuse to work and upon removal oops the kernel.
Cc: Jamal Hadi Salim <j...@mojatatu.com>
Signed-off-by: Ph
On Thu, Mar 03, 2016 at 09:28:27AM -0500, Jamal Hadi Salim wrote:
> Phil, there is one thing i noticed in your patch - dont think
> it is a big deal but you are doing htons on an int
> (instead of u16).
Indeed, I totally overlooked that. Does not look like there's an easy
fix though, as all
On Thu, Mar 03, 2016 at 09:21:55AM -0500, Jamal Hadi Salim wrote:
> On 16-03-02 01:19 PM, Phil Sutter wrote:
> > + fprintf(stderr, " unreachable | prohibit | blackhole | nat
> > }\n");
>
> Dont think nat exists anymore...
But iproute2 seems to still s
Hi,
On Thu, Mar 03, 2016 at 09:21:23AM -0500, Jamal Hadi Salim wrote:
> On 16-03-02 12:54 PM, Stephen Hemminger wrote:
> > On Wed, 2 Mar 2016 11:20:31 +
> > Phil Sutter <p...@nwl.cc> wrote:
> >
> >> + res = parse_cmd(, , 1, TU32,0x0f,sel,tkey);
&
On Fri, Mar 04, 2016 at 05:40:13PM -0800, Alexei Starovoitov wrote:
> On Fri, Mar 04, 2016 at 01:11:47PM +0100, Phil Sutter wrote:
> > Signed-off-by: Phil Sutter <p...@nwl.cc>
>
> great to see TC doc!
> Few comments:
Thanks for cross-reading! I'll wait a few days to a
On Fri, Mar 04, 2016 at 03:35:53PM -0800, Stephen Hemminger wrote:
> On Fri, 4 Mar 2016 18:57:28 +
> Phil Sutter <p...@nwl.cc> wrote:
>
> > There have been reports about 'ip addr' printing "Message truncated" on
> > systems with large numbers of VFs. Altho
After lookup of the layered op submodule, pedit would pass argv and argc
including the layered op identifier at first position which confused the
submodule parser. Fix this by calling NEXT_ARG() before calling the
parse_peopt() callback.
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
tc/m_p
c ip src preserve
prove 0x3fff 0x3fff 12
prove 0x12340030 0x12340030 12
prove 0xee6af1ff 0xee6af1ff 12
prove 0x 0x 12
run_tc ip src invert
prove 0x3fff 0xc000 12
prove 0x12340030 0xedcbffcf 12
prove 0xee6af1ff 0x11950e00 12
prove 0x 0x 12
-
Since the IP Header Length field is just half a byte, adjust retain to
only match these bits so the Version field is not overwritten by
accident.
The whole concept is actually broken due to dependency on endianness
which pedit ignores.
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
tc/p_ip
key*() variants.
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
tc/m_pedit.c | 23 +++
1 file changed, 7 insertions(+), 16 deletions(-)
diff --git a/tc/m_pedit.c b/tc/m_pedit.c
index 455e4ffd4b2bb..a314f482cd9c0 100644
--- a/tc/m_pedit.c
+++ b/tc/m_pedit.c
@@ -152,8 +152,6 @@ pack_ke
Hi,
I am trying to fix a bug in ss filter code, but feel quite lost right
now. The issue is this:
| ss -nl -f inet '( sport = :22 )'
prints not only listening sockets (as requested by -l flag), but
established ones as well (reproduce by opening ssh connection to
127.0.0.1 before calling above).
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
tc/m_vlan.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tc/m_vlan.c b/tc/m_vlan.c
index 8d97963f351bc..3233d207375bf 100644
--- a/tc/m_vlan.c
+++ b/tc/m_vlan.c
@@ -22,9 +22,10 @@
static void explain(void)
{
f
As Jamal pointed out, there are two different approaches to bandwidth
measurement. Try to make this clear by separating them in synopsis and
also documenting the way to fine-tune avrate.
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
man/man8/tc-police.8 | 29 +
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
man/man8/tc-csum.8 | 15 +++
1 file changed, 15 insertions(+)
diff --git a/man/man8/tc-csum.8 b/man/man8/tc-csum.8
index 9d00aae346af0..3a64c82f09ba8 100644
--- a/man/man8/tc-csum.8
+++ b/man/man8/tc-csum.8
@@ -49,6 +49,21 @@ U
The following patch series aims at addressing feedback provided by Jamal
and Alexei. Thanks a lot for your input!
Changes since v1:
- Rebased onto current master.
- Dropped some leftover TODO note from tc-skbedit.8
Phil Sutter (8):
doc/tc-filters.tex: Drop overly subjective paragraphs
tc
This should be made generic and part of a common tc-actions man page.
Though leave it here for now to not confuse readers of the example which
uses it.
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
man/man8/tc-vlan.8 | 56 +-
1 file chang
As Jamal suggested, BRANCH is the wrong name, as these keywords go
beyond simple branch control - e.g. loops are possible, too. Therefore
rename the non-terminal to CONTROL instead which should be more
appropriate.
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
man/man8/tc-connmark
Cc: Alexei Starovoitov <alexei.starovoi...@gmail.com>
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
doc/tc-filters.tex | 23 ---
1 file changed, 4 insertions(+), 19 deletions(-)
diff --git a/doc/tc-filters.tex b/doc/tc-filters.tex
index 59127d6672ed7..54cc0c99
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
man/man8/tc-skbedit.8 | 12
1 file changed, 12 insertions(+)
diff --git a/man/man8/tc-skbedit.8 b/man/man8/tc-skbedit.8
index b585a4d4253ba..e6902960eee27 100644
--- a/man/man8/tc-skbedit.8
+++ b/man/man8/tc-skbedit.8
@@ -17,6
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
man/man8/tc-mirred.8 | 26 +++---
1 file changed, 19 insertions(+), 7 deletions(-)
diff --git a/man/man8/tc-mirred.8 b/man/man8/tc-mirred.8
index 52d98bc416563..bba96e0e5d8c0 100644
--- a/man/man8/tc-mirred.8
+++ b/man/m
This adds a new item to VF lines of a PF, stating whether the VF is
trusted or not.
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
ip/ipaddress.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/ip/ipaddress.c b/ip/ipaddress.c
index 3998d8cec4ab2..2f1d55c115dde 100644
--
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
drivers/net/macsec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/macsec.c b/drivers/net/macsec.c
index 84d3e5ca88171..6caa72402de7d 100644
--- a/drivers/net/macsec.c
+++ b/drivers/net/macsec.c
@@ -2826,7 +
On Sat, Apr 30, 2016 at 06:58:04AM -0400, Jamal Hadi Salim wrote:
> From: Lucas Bates <luc...@mojatatu.com>
>
> Signed-off-by: Lucas Bates <luc...@mojatatu.com>
> Signed-off-by: Jamal Hadi Salim <j...@mojatatu.com>
Acked-by: Phil Sutter <p...@nwl.cc>
Nit-pic
On Fri, May 06, 2016 at 04:14:11PM +0100, Edward Cree wrote:
> On 06/05/16 15:43, Phil Sutter wrote:
> > On Fri, May 06, 2016 at 03:28:25PM +0100, Edward Cree wrote:
> >> Since we can only configure unicast, we probably want to be able to
> >> display uni
On Fri, May 06, 2016 at 03:28:25PM +0100, Edward Cree wrote:
> Since we can only configure unicast, we probably want to be able to
> display unicast, rather than multicast.
Furthermore, the kernel even rejects multicast peer addresses.
> I'm assuming this is what was intended, but tbh I don't
Cc: Jakub Sitnicki <jsitni...@gmail.com>
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
drivers/staging/rtl8188eu/os_dep/mon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/mon.c
b/drivers/staging/rtl8188eu/os_dep/mon.c
index 6
Cc: Pravin Shelar <pshe...@nicira.com>
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
net/openvswitch/vport-internal_dev.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/openvswitch/vport-internal_dev.c
b/net/openvswitch/vport-internal_dev.c
index 7
then, no idea why.
Phil Sutter (2):
staging: rtl8188eu: Convert to using IFF_NO_QUEUE
openvswitch: Convert to using IFF_NO_QUEUE
drivers/staging/rtl8188eu/os_dep/mon.c | 2 +-
net/openvswitch/vport-internal_dev.c | 3 +--
2 files changed, 2 insertions(+), 3 deletions(-)
--
2.8.0
On Fri, Apr 15, 2016 at 05:28:58PM -0400, David Miller wrote:
> Feedback was given here not to mix the changelog and the commit message.
>
> And I want to explicitly state that I totally and _COMPLETELY_ disagree
> with this.
>
> It is absolutely essential information and belongs in the commit
Hi Xin Long,
On Thu, Apr 14, 2016 at 03:35:30PM +0800, Xin Long wrote:
> sctp_diag will dump some important details of sctp's assoc or ep, we use
> sctp_info to describe them, sctp_get_sctp_info to get them, and export
> it to sctp_diag.ko.
>
> v2->v3:
> - we will not use list_for_each_safe in
On Thu, Apr 14, 2016 at 08:44:40AM -0700, Eric Dumazet wrote:
> On Thu, 2016-04-14 at 17:34 +0200, Jiri Kosina wrote:
> > On Thu, 14 Apr 2016, Phil Sutter wrote:
> >
> > > OTOH some qdiscs (CBQ, DRR, DSMARK, HFSC, HTB, QFQ) assign the default
> > > one upon deleti
An expression of the form '(a | b) & b' will evaluate to the value of b
for any value of a or b.
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
misc/ss.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/misc/ss.c b/misc/ss.c
index 38cf3312a746e..d6090018c5dbb 100644
the formerly ineffective call to filter_states_set()
to restore the state filter as it was before the call to
filter_af_set().
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
misc/ss.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/misc/ss.c b/misc/ss.c
index d609001
While looking for a solution to the problem described in patch 2/2, I
discovered the overly complicated assignment in filter_states_set() which
is simplified in patch 1/2.
Phil Sutter (2):
ss: Drop silly assignment
ss: Fix accidental state filter override
misc/ss.c | 5 +++--
1 file changed
On Thu, Apr 14, 2016 at 08:01:39AM -0700, Eric Dumazet wrote:
> On Thu, 2016-04-14 at 16:44 +0200, Jiri Kosina wrote:
> > Hi,
> >
> > I've came across the behavior where adding a child qdisc and then deleting
> > it again makes the networking dysfunctional (I guess that's because all of
> > a
he somewhat
intricate man page markup:
Acked-by: Phil Sutter <p...@nwl.cc>
Description copied from related kernel support commit message with a
little tailoring to fit.
While at it, fix font of non-terminal CONFFLAG-LIST in synopsis.
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
Changes since v1:
- Set commands/flags in bold font instead of quotes.
- Make capitali
strictly means to
eliminate all bits from the value, but the opposite is the case.
Cc: Thomas Graf <tg...@suug.ch>
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
tc/em_meta.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/tc/em_meta.c b/tc/em_meta.c
index 9
don't consider this series as the final word, but rather a
base for early review/testing and feedback.
Phil Sutter (2):
include: Add linux/sctp.h
ss: Add support for SCTP protocol
include/linux/sctp.h | 1005 ++
misc/ss.c| 212
This makes use of the sctp_diag interface recently added to the kernel.
Joint work with Xin Long who provided the PoC implementation which I
merely polished up a bit.
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
misc/ss.c | 212 +++
This header does not exist in this form upstream yet, as it contains
struct sctp_info which is required for SCTP support in 'ss' and hasn't
been exported yet.
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
include/linux/sctp.h | 1005 ++
On Sat, Jul 30, 2016 at 10:33:48AM -0300, Marcelo Ricardo Leitner wrote:
>
>
> Em 30-07-2016 10:25, Xin Long escreveu:
> >>> diff --git a/net/sctp/sctp_diag.c b/net/sctp/sctp_diag.c
> >>> index f69edcf219e51..0ad6033a7330c 100644
> >>> --- a/net/sctp/sctp_diag.c
> >>> +++ b/net/sctp/sctp_diag.c
Hi Stephen,
On Sun, Jul 31, 2016 at 02:18:24PM -0700, Stephen Hemminger wrote:
> On Fri, 29 Jul 2016 18:59:38 +0200
> Phil Sutter <p...@nwl.cc> wrote:
>
> > This is required to correctly interpret INET_DIAG_INFO messages exported
> > by sctp_diag module.
> >
or not.
Fixes: d17b136f7d7dd ("Use C99 style initializers everywhere")
Reported-by: Stas Nichiporovich <stas...@gmail.com>
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
tc/tc_qdisc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tc/tc_qdisc.c b/tc/tc_qdisc
On Thu, Aug 11, 2016 at 02:46:26PM +0100, Edward Cree wrote:
> On 10/08/16 12:14, Phil Sutter wrote:
> > Instead of printing 'expires -23sec' for expired (but not yet garbage
> > collected) routes, print 'expired 23sec' instead.
> >
> > Signed-off-by: Phil Sutter &l
This adds missing documentation of geneve type options:
- dstport
- external
- udpcsum
- udp6zerocsumtx
- udp6zerocsumrx
The bits for the last three was just copy and pasted from vxlan section.
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
man/man8/ip-link.8.i
Instead of printing 'expires -23sec' for expired (but not yet garbage
collected) routes, print 'expired 23sec' instead.
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
ip/iproute.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/ip/iproute.c b/ip/iproute.c
On Wed, Aug 03, 2016 at 04:46:52PM -0300, Marcelo Ricardo Leitner wrote:
> On Wed, Aug 03, 2016 at 09:28:13PM +0200, Phil Sutter wrote:
> > Hi,
> >
> > On Sat, Jul 30, 2016 at 09:25:42PM +0800, Xin Long wrote:
> > [...]
> > > Now for the transport's info,
This is required to correctly interpret INET_DIAG_INFO messages exported
by sctp_diag module.
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
include/linux/sctp.h | 64 ---
include/uapi/linux/sctp.
The following series contains a number of fixes necessary to make my yet
unpublished 'ss' support patch functional.
Changes since v1:
- Fixed patch 2/3
- Rebased whole series onto current net-next/master
Phil Sutter (3):
sctp: Export struct sctp_info to userspace
sctp_diag: export timer
Since 'ss' always adds TCPF_CLOSE to idiag_states flags, sctp_diag can't
rely upon TCPF_LISTEN flag solely being present when listening sockets
are requested.
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
net/sctp/sctp_diag.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
Since it is exported as unsigned value, userspace has no way detecting
whether it is negative or just very large. Therefore do this in kernel
space where it is a simple comparison.
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
Changes since v1:
- Introduce local variable to shorten long
Hi,
On Sat, Jul 30, 2016 at 09:25:42PM +0800, Xin Long wrote:
[...]
> Now for the transport's info, we only choose primary_path to dump.
> It means we should fix this by getting the left time to expire from
> primary transport t->T3_rtx_timer. like:
>
> r->idiag_expires =
The following series contains a number of fixes necessary to make my yet
unpublished 'ss' support patch functional.
Changes since v1:
- Fixed patch 2/3
- Rebased whole series onto current net-next/master
Changes since v2:
- Improved description of patch 2/3
Phil Sutter (3):
sctp: Export
off-by: Phil Sutter <p...@nwl.cc>
---
Changes since v1:
- Introduce local variable to shorten long lines.
- Use timer_pending() to decide whether to export the timer value.
- Export the primary path's value instead of garbage.
- If not exporting, zero fields to not confuse userspace.
Changes
This is required to correctly interpret INET_DIAG_INFO messages exported
by sctp_diag module.
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
include/linux/sctp.h | 64 ---
include/uapi/linux/sctp.
Looks like a simple copy'n'paste error.
Fixes: 1aa661f5c3df1 ("rhashtable-test: Measure time to insert, remove &
traverse entries")
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
lib/test_rhashtable.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/tes
401 - 500 of 1052 matches
Mail list logo
