> From: Jakub Kicinski [mailto:jakub.kicin...@netronome.com]
>
> On Mon, 11 Dec 2017 13:46:48 +0900, Prashant Bhole wrote:
> > > From: David Miller [mailto:da...@davemloft.net]
> > >
> > > From: Prashant Bhole <bhole_prashant...@lab.ntt.co.jp>
&
- Checking return value with IS_ERROR_OR_NULL
- Added error handling where it was not handled
Signed-off-by: Prashant Bhole <bhole_prashant...@lab.ntt.co.jp>
---
drivers/net/netdevsim/bpf.c| 8
drivers/net/netdevsim/netdev.c | 12
2 files changed, 12 insertions
> From: Jakub Kicinski [mailto:jakub.kicin...@netronome.com]
>
> On Wed, 20 Dec 2017 09:16:01 +0900, Prashant Bhole wrote:
> > > From: David Miller [mailto:da...@davemloft.net]
> > >
> > > From: "Prashant Bhole" <bhole_prashant...@lab.ntt.c
> From: David Miller [mailto:da...@davemloft.net]
>
> From: "Prashant Bhole" <bhole_prashant...@lab.ntt.co.jp>
> Date: Tue, 19 Dec 2017 13:45:47 +0900
>
> > I tried to evaluate whether fixing return value of
> > debugfs_create_dir() (and
> > frien
> From: Jakub Kicinski [mailto:jakub.kicin...@netronome.com]
>
> On Wed, 20 Dec 2017 09:54:59 +0900, Prashant Bhole wrote:
> > > Ah, I would just error out in case we can't create any of the
> > > sub-directories as well.
> >
> > Does that
- Checking return value with IS_ERROR_OR_NULL
- Added error handling where it was not handled
Signed-off-by: Prashant Bhole <bhole_prashant...@lab.ntt.co.jp>
Acked-by: Jakub Kicinski <jakub.kicin...@netronome.com>
---
v3: nit-pick: directly returning error instead of going to label
> From: Jakub Kicinski [mailto:jakub.kicin...@netronome.com]
>
> On Wed, 20 Dec 2017 09:38:52 +0900, Prashant Bhole wrote:
> > > > 2) In case sim0 or bpf_bound_progs are fail to create, we need to
> > > > add checks before creating any file in them.
> > &g
> From: Quentin Monnet [mailto:quentin.mon...@netronome.com]
>
> 2017-11-02 16:59 UTC+0900 ~ Prashant Bhole
> <bhole_prashant...@lab.ntt.co.jp>
> > Added support to show filenames of pinned objects.
> >
> > For example:
> >
>
> […]
>
&g
ine break indentation
Prashant Bhole (3):
tools: bpftool: open pinned object without type check
tools: bpftool: show filenames of pinned objects
tools: bpftool: optionally show filenames of pinned objects
tools/bpf/bpftool/Documentation/bpftool-map.rst | 5 +-
tools/bpf/bpftool/Documentatio
This was needed for opening any file in bpf-fs without knowing
its object type
Signed-off-by: Prashant Bhole <bhole_prashant...@lab.ntt.co.jp>
---
v2:
- No change
v3:
- No change
tools/bpf/bpftool/common.c | 15 +--
tools/bpf/bpftool/main.h | 1 +
2 files chang
Making it optional to show file names of pinned objects because
it scans complete bpf-fs filesystem which is costly.
Added option -f|--bpffs. Documentation updated.
Signed-off-by: Prashant Bhole <bhole_prashant...@lab.ntt.co.jp>
---
v2:
- Change command line option from {-l|--pinned}
h",
"name": "start",
"flags": 0,
"bytes_key": 4,
"bytes_value": 16,
"max_entries": 10240,
"bytes_memlock": 1003520,
"pinned": ["/sys/fs/bpf/softirq_map1&q
Making it optional to show file names of pinned objects because
it scans complete bpf-fs filesystem which is costly.
Added option -f|--bpffs. Documentation updated.
Signed-off-by: Prashant Bhole <bhole_prashant...@lab.ntt.co.jp>
---
v2:
- Change command line option from {-l|--pinned}
h",
"name": "start",
"flags": 0,
"bytes_key": 4,
"bytes_value": 16,
"max_entries": 10240,
"bytes_memlock": 1003520,
"pinned": ["/sys/fs/bpf/softirq_map1&q
This was needed for opening any file in bpf-fs without knowing
its object type
Signed-off-by: Prashant Bhole <bhole_prashant...@lab.ntt.co.jp>
---
tools/bpf/bpftool/common.c | 15 +--
tools/bpf/bpftool/main.h | 1 +
2 files changed, 14 insertions(+), 2 deletions(-)
diff
ing on error
- Change command line option from {-l|--pinned} to {-f|--bpffs}
- Updated documentation
- Fixed line break for proper output formatting
- Code style: wrapped lines > 80, used reverse christmastree style
Prashant Bhole (3):
tools: bpftool: open pinned object without type check
> From: Quentin Monnet [mailto:quentin.mon...@netronome.com]
>
> 2017-10-31 16:36 UTC+0900 ~ Prashant Bhole
> <bhole_prashant...@lab.ntt.co.jp>
> > Added support to show filenames of pinned objects.
> >
> > For example:
> >
> > r
Making it optional to show file names of pinned objects because
it scans complete bpf-fs filesystem which is costly.
Added option -f|--bpffs. Documentation updated.
Signed-off-by: Prashant Bhole <bhole_prashant...@lab.ntt.co.jp>
---
v2:
- Change command line option from {-l|--pinned}
This was needed for opening any file in bpf-fs without knowing
its object type
Signed-off-by: Prashant Bhole <bhole_prashant...@lab.ntt.co.jp>
---
v2:
- No change
v3:
- No change
v4:
- No change
tools/bpf/bpftool/common.c | 15 +--
tools/bpf/bpftool/main.h | 1 +
2
h",
"name": "start",
"flags": 0,
"bytes_key": 4,
"bytes_value": 16,
"max_entries": 10240,
"bytes_memlock": 1003520,
"pinned": ["/sys/fs/bpf/softirq_map1&q
ine break indentation
v3->v4:
- Removed unnecessary hash empty check
- Code style changes
Prashant Bhole (3):
tools: bpftool: open pinned object without type check
tools: bpftool: show filenames of pinned objects
tools: bpftool: optionally show filenames of pinned objects
tools/bpf/bpftool/D
> -Original Message-
> From: Jakub Kicinski [mailto:jakub.kicin...@netronome.com]
>
> On Mon, 6 Nov 2017 15:06:31 +0900, Prashant Bhole wrote:
> > Added support to show filenames of pinned objects.
> > ...
> > Signed-off-by: Prashant Bhole <bhole_prash
Use PATH_MAX instead of hardcoded array size 256
Signed-off-by: Prashant Bhole <bhole_prashant...@lab.ntt.co.jp>
---
tools/bpf/bpf_jit_disasm.c | 3 ++-
tools/bpf/bpftool/jit_disasm.c | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/tools/bpf/bpf_jit_disasm.c b
> From: Jakub Kicinski [mailto:jakub.kicin...@netronome.com]
>
> On Fri, 8 Dec 2017 09:52:50 +0900, Prashant Bhole wrote:
> > Return value is now checked with IS_ERROR_OR_NULL because
> > debugfs_create_dir doesn't return error value. It either returns NULL
&
Return value is now checked with IS_ERROR_OR_NULL because
debugfs_create_dir doesn't return error value. It either returns
NULL or a valid pointer.
Signed-off-by: Prashant Bhole <bhole_prashant...@lab.ntt.co.jp>
---
drivers/net/netdevsim/netdev.c | 2 +-
1 file changed, 1 insertion
Initial discussion started about correct handling of this condition.
Later it was decided to remove this check altogether to make it
consistent.
Removal of this check isn't fatal to this driver.
Signed-off-by: Prashant Bhole <bhole_prashant...@lab.ntt.co.jp>
---
drivers/net/netdevsim/ne
to remove error handling altogether to
make it consistent and removal of this check isn't fatal to the driver.
Signed-off-by: Prashant Bhole <bhole_prashant...@lab.ntt.co.jp>
---
drivers/net/netdevsim/bpf.c| 5 -
drivers/net/netdevsim/netdev.c | 2 --
2 files changed, 7 deletions(-)
> From: Jakub Kicinski [mailto:jakub.kicin...@netronome.com]
>
> On Thu, 7 Dec 2017 10:02:13 +0900, Prashant Bhole wrote:
> > - Handled debugfs_create_dir failure in nsim_init()
> > - Fixed return value of nsim_module_init() when debugfs_create_dir
> > fails
>
> From: Jakub Kicinski [mailto:jakub.kicin...@netronome.com]
>
> On Thu, 7 Dec 2017 13:10:39 +0900, Prashant Bhole wrote:
> > > From: Jakub Kicinski [mailto:jakub.kicin...@netronome.com]
> > >
> > > On Thu, 7 Dec 2017 10:02:13 +0900, Prashant Bhole wrote:
t_name cannot be NULL since it is an array field of a struct.
Replacing null check on static array with string length check using
strnlen()
Signed-off-by: Prashant Bhole <bhole_prashant...@lab.ntt.co.jp>
---
net/rds/connection.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
> From: David Miller [mailto:da...@davemloft.net]
>
> From: Prashant Bhole <bhole_prashant...@lab.ntt.co.jp>
> Date: Fri, 8 Dec 2017 09:52:50 +0900
>
> > Return value is now checked with IS_ERROR_OR_NULL because
> > debugfs_create_dir doesn't return er
- Handled debugfs_create_dir failure in nsim_init()
- Fixed return value of nsim_module_init() when debugfs_create_dir fails
Signed-off-by: Prashant Bhole <bhole_prashant...@lab.ntt.co.jp>
---
drivers/net/netdevsim/netdev.c | 18 ++
1 file changed, 14 insertions(+), 4 del
This was needed for opening any file in bpf-fs without knowing
its object type
Signed-off-by: Prashant Bhole <bhole_prashant...@lab.ntt.co.jp>
---
tools/bpf/bpftool/common.c | 15 +--
tools/bpf/bpftool/main.h | 1 +
2 files changed, 14 insertions(+), 2 deletions(-)
diff
Making it optional to show file names of pinned objects because
it scans complete bpf-fs filesystem which is costly.
Added option -l|--pinned
Signed-off-by: Prashant Bhole <bhole_prashant...@lab.ntt.co.jp>
---
tools/bpf/bpftool/main.c | 14 +++---
tools/bpf/bpftool/main.h | 3 ++-
may be
associated with multiple paths because an object can be pinned multiple times
Patch3 adds command line option to enable this functionality. Making it optional
because scanning bpf-fs can be costly.
Prashant Bhole (3):
tools: bpftool: open pinned object without type check
tools: bpftool
h",
"name": "start",
"flags": 0,
"bytes_key": 4,
"bytes_value": 16,
"max_entries": 10240,
"bytes_memlock": 1003520,
"pinned": ["/sys/fs/bpf/softirq_
Hi,
Recently I tried tools/testing/selftests/net/rtnetlink.sh with KASAN
enabled and encountered following BUG.
kernel: ==
kernel: BUG: KASAN: null-ptr-deref in tcf_block_put+0x8c/0xc0
kernel: Read of size 8 at addr
The default memlock rlimit is 64KB, which causes failure in
creating a map
For example:
test@test# ./sampleip
failed to create a map: 1 Operation not permitted
ERROR: loading BPF program (errno 1):
Try: ulimit -l unlimited
Signed-off-by: Prashant Bhole <bhole_prashant...@lab.ntt.co
Updated optstring parameter for getopt_long() to accept short options.
Also updated usage() function.
Signed-off-by: Prashant Bhole <bhole_prashant...@lab.ntt.co.jp>
---
samples/bpf/xdp_monitor_user.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sampl
On 5/12/2018 1:31 AM, Jesper Dangaard Brouer wrote:
On Fri, 11 May 2018 10:37:51 +0900
Prashant Bhole <bhole_prashant...@lab.ntt.co.jp> wrote:
updated optstring accept short options
Signed-off-by: Prashant Bhole <bhole_prashant...@lab.ntt.co.jp>
---
samples/bpf/xdp_monito
sync the header from include/uapi/linux/bpf.h which was updated to add
fib lookup helper function. This fixes selftests/bpf build failure
Signed-off-by: Prashant Bhole <bhole_prashant...@lab.ntt.co.jp>
---
tools/include/uapi/linux/bpf.h | 84 +-
updated optstring accept short options
Signed-off-by: Prashant Bhole <bhole_prashant...@lab.ntt.co.jp>
---
samples/bpf/xdp_monitor_user.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/samples/bpf/xdp_monitor_user.c b/samples/bpf/xdp_monitor_user.c
index 894bc6
, add selftests")
Signed-off-by: Prashant Bhole <bhole_prashant...@lab.ntt.co.jp>
---
tools/testing/selftests/bpf/test_sockmap.c | 25 +++--
1 file changed, 19 insertions(+), 6 deletions(-)
diff --git a/tools/testing/selftests/bpf/test_sockmap.c
b/tools/testi
seen.
Note: Even after fixing above problems there are issues with tests
which set cork parameter. Tests fail (RX thread timeout) when cork
value is non-zero and overall data sent by TX thread isn't multiples
of cork value.
Prashant Bhole (5):
selftests/bpf: test_sockmap, check test failure
ntime of test_sockmap tests")
Signed-off-by: Prashant Bhole <bhole_prashant...@lab.ntt.co.jp>
---
tools/testing/selftests/bpf/test_sockmap.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/bpf/test_sockmap.c
b/tools/testing/selftests/bpf/test
In case of selftest mode, temporary cgroup environment is created but
cgroup is not joined. It causes test failures. Fixed by joining the
cgroup
Fixes: 16962b2404ac ("bpf: sockmap, add selftests")
Signed-off-by: Prashant Bhole <bhole_prashant...@lab.ntt.co.jp>
---
tools/testi
Print values of test options like apply, cork, start, end so that
individual failed tests can be identified for manual run
Signed-off-by: Prashant Bhole <bhole_prashant...@lab.ntt.co.jp>
---
tools/testing/selftests/bpf/test_sockmap.c | 28 +++-
1 file chang
: 16962b2404ac ("bpf: sockmap, add selftests")
Signed-off-by: Prashant Bhole <bhole_prashant...@lab.ntt.co.jp>
---
tools/testing/selftests/bpf/test_sockmap.c | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/bpf/test_sockmap.c
On 5/22/2018 2:08 AM, John Fastabend wrote:
On 05/20/2018 10:13 PM, Prashant Bhole wrote:
On 5/19/2018 1:42 AM, John Fastabend wrote:
On 05/18/2018 12:17 AM, Prashant Bhole wrote:
This series fixes bugs in test_sockmap code. They weren't caught
previously because failure in RX/TX thread
On 5/23/2018 6:44 PM, Prashant Bhole wrote:
On 5/22/2018 2:08 AM, John Fastabend wrote:
On 05/20/2018 10:13 PM, Prashant Bhole wrote:
On 5/19/2018 1:42 AM, John Fastabend wrote:
On 05/18/2018 12:17 AM, Prashant Bhole wrote:
This series fixes bugs in test_sockmap code. They weren't
On 5/24/2018 1:58 PM, John Fastabend wrote:
On 05/23/2018 09:47 PM, Prashant Bhole wrote:
On 5/23/2018 6:44 PM, Prashant Bhole wrote:
On 5/22/2018 2:08 AM, John Fastabend wrote:
On 05/20/2018 10:13 PM, Prashant Bhole wrote:
On 5/19/2018 1:42 AM, John Fastabend wrote:
On 05/18/2018
On 5/19/2018 1:42 AM, John Fastabend wrote:
On 05/18/2018 12:17 AM, Prashant Bhole wrote:
This series fixes bugs in test_sockmap code. They weren't caught
previously because failure in RX/TX thread was not notified to the
main thread.
Also fixed data verification logic and slightly improved
On 5/19/2018 1:45 AM, John Fastabend wrote:
On 05/18/2018 12:17 AM, Prashant Bhole wrote:
In case of selftest mode, temporary cgroup environment is created but
cgroup is not joined. It causes test failures. Fixed by joining the
cgroup
Fixes: 16962b2404ac ("bpf: sockmap, add self
On 5/19/2018 1:47 AM, John Fastabend wrote:
On 05/18/2018 12:17 AM, Prashant Bhole wrote:
In order to reduce runtime of tests, recently timout for select() call
was reduced from 1sec to 10usec. This was causing many tests failures.
It was caught with failure handling commits in this series
On 5/19/2018 1:54 AM, Shuah Khan wrote:
On 05/18/2018 01:17 AM, Prashant Bhole wrote:
This series fixes bugs in test_sockmap code. They weren't caught
previously because failure in RX/TX thread was not notified to the
main thread.
Also fixed data verification logic and slightly improved test
Print values of test options like apply, cork, start, end so that
individual failed tests can be identified for manual run
Acked-by: John Fastabend
Signed-off-by: Prashant Bhole
---
tools/testing/selftests/bpf/test_sockmap.c | 28 +++---
1 file changed, 19 insertions(+), 9
On 5/31/2018 4:59 AM, John Fastabend wrote:
On 05/30/2018 12:29 PM, Alexei Starovoitov wrote:
On Wed, May 30, 2018 at 02:56:09PM +0900, Prashant Bhole wrote:
In order to reduce runtime of tests, recently timout for select() call
was reduced from 1sec to 10usec. This was causing many tests
In case of selftest mode, temporary cgroup environment is created but
cgroup is not joined. It causes test failures. Fixed by joining the
cgroup
Fixes: 16962b2404ac ("bpf: sockmap, add selftests")
Acked-by: John Fastabend
Signed-off-by: Prashant Bhole
---
tools/testing/sel
: 16962b2404ac ("bpf: sockmap, add selftests")
Acked-by: John Fastabend
Signed-off-by: Prashant Bhole
---
tools/testing/selftests/bpf/test_sockmap.c | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/bpf/test_sockmap.c
b/tools/testing
as they are expected to timeout
Fixes: 16962b2404ac ("bpf: sockmap, add selftests")
Signed-off-by: Prashant Bhole
---
tools/testing/selftests/bpf/test_sockmap.c | 27 +-
1 file changed, 21 insertions(+), 6 deletions(-)
diff --git a/tools/testing/selftests/bpf/test_so
and reduce
run time by reducing number of iterations in some tests
Changes in v3:
- Skipped error checking for corked tests
Prashant Bhole (5):
selftests/bpf: test_sockmap, check test failure
selftests/bpf: test_sockmap, join cgroup in selftest mode
selftests/bpf: test_sockmap, timing
("bpf: reduce runtime of test_sockmap tests")
Signed-off-by: Prashant Bhole
---
tools/testing/selftests/bpf/test_sockmap.c | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/tools/testing/selftests/bpf/test_sockmap.c
b/tools/testing/selftests/bpf/test_sockm
On 5/30/2018 12:48 AM, John Fastabend wrote:
On 05/27/2018 09:37 PM, Prashant Bhole wrote:
This series fixes error handling, timeout and data verification in
test_sockmap. Previously it was not able to detect failure/timeout in
RX/TX thread because error was not notified to the main thread
On 5/30/2018 2:12 PM, John Fastabend wrote:
On 05/29/2018 05:44 PM, Prashant Bhole wrote:
On 5/30/2018 12:48 AM, John Fastabend wrote:
On 05/27/2018 09:37 PM, Prashant Bhole wrote:
This series fixes error handling, timeout and data verification in
test_sockmap. Previously it was not able
that parameters for all tests are displayed.
Changes in v3:
- Skipped error checking for corked tests
Prashant Bhole (5):
selftests/bpf: test_sockmap, check test failure
selftests/bpf: test_sockmap, join cgroup in selftest mode
selftests/bpf: test_sockmap, fix test timeout
selftests/bpf
as they are expected to timeout
Fixes: 16962b2404ac ("bpf: sockmap, add selftests")
Signed-off-by: Prashant Bhole
---
tools/testing/selftests/bpf/test_sockmap.c | 25 --
1 file changed, 19 insertions(+), 6 deletions(-)
diff --git a/tools/testing/selftests/bpf/test_so
ntime of test_sockmap tests")
Signed-off-by: Prashant Bhole
---
tools/testing/selftests/bpf/test_sockmap.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/bpf/test_sockmap.c
b/tools/testing/selftests/bpf/test_sockmap.c
index 64f9e25c451f..9d01f5c2a
: 16962b2404ac ("bpf: sockmap, add selftests")
Acked-by: John Fastabend
Signed-off-by: Prashant Bhole
---
tools/testing/selftests/bpf/test_sockmap.c | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/bpf/test_sockmap.c
b/tools/testing
Print values of test options like apply, cork, start, end so that
individual failed tests can be identified for manual run
Acked-by: John Fastabend
Signed-off-by: Prashant Bhole
---
tools/testing/selftests/bpf/test_sockmap.c | 28 +++---
1 file changed, 19 insertions(+), 9
In case of selftest mode, temporary cgroup environment is created but
cgroup is not joined. It causes test failures. Fixed by joining the
cgroup
Fixes: 16962b2404ac ("bpf: sockmap, add selftests")
Acked-by: John Fastabend
Signed-off-by: Prashant Bhole
---
tools/testing/sel
[ 345.432629] ? kasan_report+0xb4/0x410
[ 345.432629] kasan_report.cold.4+0x8f/0x91
[ 345.432629] ? rtnl_newlink+0x400/0x1110
[ 345.432629] rtnl_newlink+0x400/0x1110
[...]
Fixes: ccf8dbcd062a ("rtnetlink: Remove VLA usage")
Signed-off-by: Prashant Bhole
---
net/core/rtnetlink.c | 2
On 5/25/2018 11:01 PM, John Fastabend wrote:
On 05/25/2018 01:28 AM, Prashant Bhole wrote:
On 5/24/2018 1:58 PM, John Fastabend wrote:
On 05/23/2018 09:47 PM, Prashant Bhole wrote:
On 5/23/2018 6:44 PM, Prashant Bhole wrote:
On 5/22/2018 2:08 AM, John Fastabend wrote:
On 05/20/2018 10
that parameters for all tests are displayed.
Prashant Bhole (5):
selftests/bpf: test_sockmap, check test failure
selftests/bpf: test_sockmap, join cgroup in selftest mode
selftests/bpf: test_sockmap, fix test timeout
selftests/bpf: test_sockmap, fix data verification
selftests/bpf
ntime of test_sockmap tests")
Signed-off-by: Prashant Bhole <bhole_prashant...@lab.ntt.co.jp>
---
tools/testing/selftests/bpf/test_sockmap.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/bpf/test_sockmap.c
b/tools/testing/selftests/bpf/test
In case of selftest mode, temporary cgroup environment is created but
cgroup is not joined. It causes test failures. Fixed by joining the
cgroup
Fixes: 16962b2404ac ("bpf: sockmap, add selftests")
Acked-by: John Fastabend <john.fastab...@gmail.com>
Signed-off-by: Prashant Bhole
: 16962b2404ac ("bpf: sockmap, add selftests")
Acked-by: John Fastabend <john.fastab...@gmail.com>
Signed-off-by: Prashant Bhole <bhole_prashant...@lab.ntt.co.jp>
---
tools/testing/selftests/bpf/test_sockmap.c | 14 +-
1 file changed, 13 insertions(+), 1 deletion(
, add selftests")
Signed-off-by: Prashant Bhole <bhole_prashant...@lab.ntt.co.jp>
---
tools/testing/selftests/bpf/test_sockmap.c | 25 --
1 file changed, 19 insertions(+), 6 deletions(-)
diff --git a/tools/testing/selftests/bpf/test_sockmap.c
b/tools/testi
Print values of test options like apply, cork, start, end so that
individual failed tests can be identified for manual run
Acked-by: John Fastabend <john.fastab...@gmail.com>
Signed-off-by: Prashant Bhole <bhole_prashant...@lab.ntt.co.jp>
---
tools/testing/selftests/bpf/test_so
] ? ip_local_deliver_finish+0xfc/0x770
[ 195.716967] ? raw_rcv+0x2b0/0x2b0
[ 195.718856] ? lock_release+0xa00/0xa00
[ 195.720938] ip_local_deliver_finish+0x1b9/0x770
[...]
Fixes: 2c205dd3981f ("netfilter: add struct nf_nat_hook and use it")
Signed-off-by: Prashant Bhole <bhole_prashant...@
On 1/16/2018 2:57 PM, Cong Wang wrote:
On Mon, Jan 15, 2018 at 9:47 PM, Prashant Bhole
<bhole_prashant...@lab.ntt.co.jp> wrote:
On 1/16/2018 2:08 PM, Cong Wang wrote:
On Sun, Jan 14, 2018 at 9:52 PM, Prashant Bhole
<bhole_prashant...@lab.ntt.co.jp> wrote:
About bug:
On 1/16/2018 2:08 PM, Cong Wang wrote:
On Sun, Jan 14, 2018 at 9:52 PM, Prashant Bhole
<bhole_prashant...@lab.ntt.co.jp> wrote:
About bug:
During init of clsact/ingress, it links qdisc's cpu_bstats,cpu_qstats
with mini qdisc. TCQ_F_CPUSTATS is set in qdisc->flags during init and
On 1/23/2018 1:38 PM, Alexei Starovoitov wrote:
On Tue, Jan 23, 2018 at 01:30:44PM +0900, Prashant Bhole wrote:
Bug: BPF programs and maps related to sockmaps test exist in
memory even after test_maps ends
This patch fixes it by empyting sockmaps when test ends.
Fixes: 6f6d33f3b3d0f (&quo
t fastpath")
Signed-off-by: Prashant Bhole <bhole_prashant...@lab.ntt.co.jp>
---
net/sched/sch_api.c | 3 ++-
net/sched/sch_ingress.c | 6 ++
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c
index 8a04c36e579f..de99a5e80944 100644
-
While building samples/sockmap, undefined reference error is thrown
for `nla_dump_errormsg'.
Linking tools/lib/bpf/nlattr.o as a fix
Signed-off-by: Prashant Bhole <bhole_prashant...@lab.ntt.co.jp>
---
samples/sockmap/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
samples/sockops program keeps the sock_ops program attached to cgroup.
Fixed this by detaching program before exit.
Signed-off-by: Prashant Bhole <bhole_prashant...@lab.ntt.co.jp>
---
samples/sockmap/sockmap_user.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/samples/s
eBPF test fails due to verifier failure because log_buf is too small
Fixed by increasing log_buf size
Signed-off-by: Prashant Bhole <bhole_prashant...@lab.ntt.co.jp>
---
tools/testing/selftests/net/psock_fanout.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/t
eBPF test fails due to verifier failure because log_buf is too small.
Fixed by increasing log_buf size
Signed-off-by: Prashant Bhole <bhole_prashant...@lab.ntt.co.jp>
---
v2: log_buf is statically allocated
tools/testing/selftests/net/psock_fanout.c | 3 ++-
1 file changed, 2 insertions
s/ENOTSUPP/EOPNOTSUPP/ in function umem_assign_dev().
This function's return value is directly returned by xsk_bind().
EOPNOTSUPP is bind()'s possible return value.
Fixes: f734607e819b ("xsk: refactor xdp_umem_assign_dev()")
Signed-off-by: Prashant Bhole
---
net/xdp/xdp_umem.c | 4 ++
On 7/25/2018 8:02 AM, Yonghong Song wrote:
On 7/24/18 3:40 PM, John Fastabend wrote:
On 07/24/2018 08:45 AM, Yonghong Song wrote:
In one of our production machines, tools/testing/selftests/bpf
test_sockmap failed randomly like below:
...
[TEST 78]: (512, 1, 1, sendmsg, pass,apply 1,): rx
Since xdp_umem_query() was added one assignment of bpf.command was
missed from cleanup. Removing the assignment statement.
Fixes: 84c6b86875e01a0 ("xsk: don't allow umem replace at stack level")
Signed-off-by: Prashant Bhole
---
net/xdp/xdp_umem.c | 2 --
1 file changed, 2 deletion
- xsks_map size was fixed to 4, changed it MAX_SOCKS
- Remove redundant definition of MAX_SOCKS in xdpsock_user.c
- In dump_stats(), add NULL check for xsks[i]
Signed-off-by: Prashant Bhole
---
samples/bpf/xdpsock_kern.c | 2 +-
samples/bpf/xdpsock_user.c | 3 +--
2 files changed, 2 insertions
When listed all maps, bpftool currently shows (null) for xskmap.
Added xskmap type in map_type_name[] to show correct type.
Signed-off-by: Prashant Bhole
---
tools/bpf/bpftool/map.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/bpf/bpftool/map.c b/tools/bpf/bpftool/map.c
index
uced possibility of this bug.
This patch moves ipv6hdr pointer assignment after skb_cow_head() call.
Fixes: 5a963eb61b7c ("ip6_gre: Add ERSPAN native tunnel support")
Signed-off-by: Prashant Bhole
---
net/ipv6/ip6_gre.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
On 7/12/2018 7:39 AM, Tyler Hicks wrote:
Starting with the following net-next commit, I see a BUG when starting a
LXD container inside of a KVM guest using virtio-net:
d4546c2509b1 net: Convert GRO SKB handling to list_head.
Recently I encountered KASAN:use-after-free BUG and git bisect
0011 0001
[ 148.529547] page dumped because: kasan: bad access detected
Fixes: d4546c2509b1 ("net: Convert GRO SKB handling to list_head.")
Signed-off-by: Prashant Bhole
Reported-by: Tyler Hicks
---
net/core/dev.c | 6 --
1 file changed, 4 insertions(+), 2 dele
Bug: BPF programs and maps related to sockmaps test exist in
memory even after test_maps ends
This patch fixes it by empyting sockmaps when test ends.
Fixes: 6f6d33f3b3d0f ("bpf: selftests add sockmap tests")
Signed-off-by: Prashant Bhole <bhole_prashant...@lab.ntt.co.jp>
--
test_cgrp2_sock.sh and test_cgrp2_sock2.sh tests keep the program
attached to cgroup even after completion.
Using detach functionality of test_cgrp2_sock in both scripts.
Signed-off-by: Prashant Bhole <bhole_prashant...@lab.ntt.co.jp>
---
samples/bpf/test_cgrp2_sock.sh | 1 +
sampl
On 3/27/2018 12:15 PM, John Fastabend wrote:
On 03/25/2018 11:54 PM, Prashant Bhole wrote:
When CONFIG_DEBUG_SG is set, sg->sg_magic is initialized to SG_MAGIC,
when sg table is initialized using sg_init_table(). Magic is checked
while navigating the scatterlist. We hit BUG_ON when ma
On 3/27/2018 6:05 PM, Daniel Borkmann wrote:
On 03/27/2018 10:41 AM, Prashant Bhole wrote:
On 3/27/2018 12:15 PM, John Fastabend wrote:
On 03/25/2018 11:54 PM, Prashant Bhole wrote:
When CONFIG_DEBUG_SG is set, sg->sg_magic is initialized to SG_MAGIC,
when sg table is initialized us
off-by: Prashant Bhole <bhole_prashant...@lab.ntt.co.jp>
---
kernel/bpf/sockmap.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/kernel/bpf/sockmap.c b/kernel/bpf/sockmap.c
index 69c5bccabd22..8a848a99d768 100644
--- a/kernel/bpf/sockmap.c
+++ b/kernel/bpf/sockmap.c
1 - 100 of 143 matches
Mail list logo
