[PATCH 5/5] net core: fix kernel-doc for new function parameters

2007-10-12 Thread Randy Dunlap
From: Randy Dunlap [EMAIL PROTECTED] Fix networking code kernel-doc for newly added parameters. Warning(linux-2.6.23-git2//net/core/sock.c:879): No description found for parameter 'net' Warning(linux-2.6.23-git2//net/core/dev.c:570): No description found for parameter 'net' Warning(linux

atm: panic when loading clip 2nd time

2007-10-16 Thread Randy Dunlap
2.6.23-git7, using SLAB (not SLUB) [config attached]: # modprobe clip # rmmod clip # modprobe clip results in panic: kmem_cache_create: duplicate cache clip_arp_cache Call Trace: [8028c682] kmem_cache_create+0x3bf/0x3fd [8046ba1d] neigh_table_init_no_netlink+0x6c/0x242

[PATCH] phy/bitbang: missing MODULE_LICENSE

2007-10-18 Thread Randy Dunlap
From: Randy Dunlap [EMAIL PROTECTED] Missing MODULE_LICENSE(), loading this module taints the kernel. Signed-off-by: Randy Dunlap [EMAIL PROTECTED] --- drivers/net/phy/mdio-bitbang.c |2 ++ 1 file changed, 2 insertions(+) --- linux-2.6.23-git7.orig/drivers/net/phy/mdio-bitbang.c +++ linux

Re: atm: panic when loading clip 2nd time

2007-10-19 Thread Randy Dunlap
On Tue, 16 Oct 2007 14:33:38 -0700 Nish Aravamudan wrote: On 10/16/07, Randy Dunlap [EMAIL PROTECTED] wrote: 2.6.23-git7, using SLAB (not SLUB) [config attached]: # modprobe clip # rmmod clip # modprobe clip results in panic: kmem_cache_create: duplicate cache clip_arp_cache

[PATCH] [Bug 9187] ir-functions.c:(.text+0xbce18): undefined reference to `input_event'

2007-10-18 Thread Randy Dunlap
[EMAIL PROTECTED] wrote:] From: Randy Dunlap [EMAIL PROTECTED] Drivers that use lro functions should depend on INET, otherwise they may not link correctly. Let's not select INET. Select should be used only for library-like code, not to enable subsystems. ERROR: lro_flush_all [drivers/net

[PATCH] NAPI: kconfig prompt and deleted doc file

2007-10-18 Thread Randy Dunlap
From: Randy Dunlap [EMAIL PROTECTED] - make the kconfig NAPI option prompt consistent across all net drivers (other than EXPERIMENTAL; can it now be removed also, or is the new napi_struct implementation now EXPERIMENTAL ?) - remove comment about the now-deleted NAPI_HOWTO.txt file - clean up

[PATCH] net: QoS/Sched as menuconfig

2007-10-18 Thread Randy Dunlap
From: Randy Dunlap [EMAIL PROTECTED] Convert QoS and/or fair queueing to menuconfig. This makes it easy for someone to disable all sub-options with one config symbol. Signed-off-by: Randy Dunlap [EMAIL PROTECTED] --- net/sched/Kconfig | 10 +++--- 1 file changed, 3 insertions(+), 7

Re: [PATCH] [Bug 9187] ir-functions.c:(.text+0xbce18): undefined reference to `input_event'

2007-10-18 Thread Randy Dunlap
On Thu, 18 Oct 2007 22:02:22 -0700 (PDT) David Miller wrote: From: Randy Dunlap [EMAIL PROTECTED] Date: Thu, 18 Oct 2007 21:53:50 -0700 [EMAIL PROTECTED] wrote:] From: Randy Dunlap [EMAIL PROTECTED] Drivers that use lro functions should depend on INET, otherwise they may

Re: [PATCH] wan: new driver retina

2007-10-22 Thread Randy Dunlap
On Mon, 22 Oct 2007 04:14:57 -0700 (PDT) Matti Linnanvuori wrote: From: Matti Linnanvuori [EMAIL PROTECTED] Retina G.703 and G.SHDSL driver. Signed-off-by: Matti Linnanvuori [EMAIL PROTECTED] --- Hi, Just a few basic questions... I'm not reviewing any of the code parts. Fixed Kconfig

Re: [PATCH] net: docbook fixes for netif_ functions

2007-10-31 Thread Randy Dunlap
On Wed, 31 Oct 2007 14:08:48 -0700 Stephen Hemminger wrote: Documentation updates for network interfaces. 1. Add doc for netif_napi_add 2. Remove doc for unused returns from netif_rx 3. Add doc for netif_receive_skb Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] ---

Re: build #337 failed for 2.6.24-rc1-gb1d08ac In function `usbnet_set_settings':

2007-11-01 Thread Randy Dunlap
On Thu, 1 Nov 2007 20:24:54 +0100 Toralf Förster wrote: [adding netdev] Hello, the build with the attached .config failed, make ends with: ... CC arch/x86/lib/usercopy_32.o AR arch/x86/lib/lib.a GEN .version CHK include/linux/compile.h UPD

[PATCH 2.6.24-rc2] net: net_free implicit declaration

2007-11-06 Thread Randy Dunlap
From: Randy Dunlap [EMAIL PROTECTED] Just move the function so that is it known before it is used. net/core/net_namespace.c: In function 'copy_net_ns': net/core/net_namespace.c:97: error: implicit declaration of function 'net_free' net/core/net_namespace.c: At top level: net/core/net_namespace.c

Re: build #337 failed for 2.6.24-rc1-gb1d08ac In function `usbnet_set_settings':

2007-11-08 Thread Randy Dunlap
On Thu, 8 Nov 2007 04:30:10 +0100 Adrian Bunk wrote: On Wed, Nov 07, 2007 at 11:52:32PM +0100, Adrian Bunk wrote: On Wed, Nov 07, 2007 at 02:34:52PM -0800, David Brownell wrote: But on the other hand, it seems that only the ASIX code will work right; the DM9601 and MCS7830 Kconfig is

Re: [BUG] New Kernel Bugs

2007-11-13 Thread Randy Dunlap
On Tue, 13 Nov 2007 14:40:29 +0100 Ingo Molnar wrote: * Andrew Morton [EMAIL PROTECTED] wrote: Do you believe that our response to bug reports is adequate? Do you feel that making us feel and look like shit helps? That doesn't answer my question. See, first we need to

Re: [BUG] New Kernel Bugs

2007-11-13 Thread Randy Dunlap
On Tue, 13 Nov 2007 09:33:21 -0600 James Bottomley wrote: On Tue, 2007-11-13 at 03:15 -0800, Andrew Morton wrote: SCSI== qla2xxx: driver initialization does not complete when booting with Port connected

Re: [PATCH] Fix warning for token-ring from sysctl checker

2007-11-14 Thread Randy Dunlap
On Wed, 14 Nov 2007 08:56:20 -0700 Eric W. Biederman wrote: David Miller [EMAIL PROTECTED] writes: From: Olof Johansson [EMAIL PROTECTED] Date: Tue, 13 Nov 2007 01:23:13 -0600 As seen when booting ppc64_defconfig: sysctl table check failed: /net/token-ring .3.14 procname does not

Re: [BUG] New Kernel Bugs

2007-11-14 Thread Randy Dunlap
On Wed, 14 Nov 2007 15:08:47 +0100 Ingo Molnar wrote: * Randy Dunlap [EMAIL PROTECTED] wrote: (and this is in no way directed at the networking folks - it holds for all of us. I have one main complaint about networking: the separate netdev list is a bad idea - networking

Re: [BUG] New Kernel Bugs

2007-11-14 Thread Randy Dunlap
On Wed, 14 Nov 2007 21:16:39 +0100 Ingo Molnar wrote: countered by the underlined sentences above, just in case you missed it. I didn't miss your claim. --- ~Randy - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo

Re: [BUG] New Kernel Bugs

2007-11-14 Thread Randy Dunlap
On Wed, 14 Nov 2007 21:37:37 +0100 Ingo Molnar wrote: ok, then you conceded it by not replying to it? good ;-) No, I don't intend to carry on this discussion, but I appreciate the smiley. --- ~Randy - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to

Re: [PATCH 1/3] Remove trailing NULs from network bonding sysfs interface.

2007-11-28 Thread Randy Dunlap
Wagner Ferenc wrote: Randy Dunlap [EMAIL PROTECTED] writes: On Wed, 28 Nov 2007 01:49:54 +0100 =?utf-8?q?Ferenc_W=C3=A1gner?= wrote: Patches 1 3 use if (res) statement; but the preferred form is if (res) statement; Even if this style was already used

Re: [PATCH 4/3] net/bonding: Adhere to coding style: break line after the if condition

2007-11-28 Thread Randy Dunlap
=?utf-8?q?Ferenc_W=C3=A1gner?= wrote: Signed-off-by: Ferenc Wágner [EMAIL PROTECTED] Acked-by: Randy Dunlap [EMAIL PROTECTED] Thanks. --- Randy Dunlap [EMAIL PROTECTED] writes: drivers/net/bonding/bond_sysfs.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git

Re: 2.6.24-rc4-mm1

2007-12-11 Thread Randy Dunlap
E1000. I don't know how one would do this in Kconfig. ditto. I doubt that SELECT E1000E would be a good idea here (maybe not even work), and I can't think of anything else. default E1000 in E1000E seems to work for me. --- From: Randy Dunlap [EMAIL PROTECTED] Make E1000E default to the same

Re: [PATCH] e1000: Dump the eeprom when a user encounters a bad checksum

2007-12-14 Thread Randy Dunlap
On Fri, 14 Dec 2007 15:35:30 -0800 Auke Kok wrote: To help supporting users with a bad eeprom checksum, dump the eeprom info when such a situation is encountered by a user. Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000/e1000_main.c | 90

Re: [PATCH] bridge: assign random address

2007-12-16 Thread Randy Dunlap
On Sun, 16 Dec 2007 15:26:06 -0800 (PST) David Miller wrote: From: Andrew Morton [EMAIL PROTECTED] Date: Sun, 16 Dec 2007 14:29:15 -0800 On Sun, 16 Dec 2007 13:37:17 -0800 (PST) David Miller [EMAIL PROTECTED] wrote: From: Stephen Hemminger [EMAIL PROTECTED] Date: Tue, 11 Dec

Re: [PATCH] New driver sfc for Solarstorm SFC4000 controller - 3nd try

2007-12-21 Thread Randy Dunlap
On Fri, 21 Dec 2007 16:53:40 + Robert Stonehouse wrote: This is a resubmission of a new driver for Solarflare network controllers. The driver supports several types of PHY (10Gbase-T, XFP, CX4) on six different 10G and 1G boards. The previous thread was: [PATCH] [RFC] New driver

Re: [PATCH 2.6.23.12] net/bonding: option to specify initial bond interface number

2008-01-02 Thread Randy Dunlap
On Wed, 2 Jan 2008 16:20:48 -0500 Jari Takkala wrote: Allow the user to specify an initial interface number when loading the bonding driver. This is useful when loading multiple instances of the bonding driver and you want to control the interface number assignment. For example, if the

Re: Top 10 kernel oopses for the week ending January 5th, 2008

2008-01-08 Thread Randy Dunlap
On Mon, 7 Jan 2008 19:26:12 -0800 (PST) Linus Torvalds wrote: On Mon, 7 Jan 2008, Kevin Winchester wrote: J. Bruce Fields wrote: Is there any good basic documentation on this to point people at? I would second this question. I see people decode oops on lkml often enough, but

[PATCH] hamradio: fix dmascc section mismatch

2008-01-25 Thread Randy Dunlap
From: Randy Dunlap [EMAIL PROTECTED] cc: Klaus Kudielka [EMAIL PROTECTED] hw[] is used in both init and exit functions so it cannot be initdata (section mismatch is when CONFIG_MODULES=n and CONFIG_DMASCC=y). WARNING: vmlinux.o(.exit.text+0xba7): Section mismatch: reference to .init.data

2.6.24-git6 net build failure when SYSFS=n, PROC_FS=n

2008-01-29 Thread Randy Dunlap
linux-2.6.24-git6/net/ipv4/fib_frontend.c: In function 'fib_net_init': linux-2.6.24-git6/net/ipv4/fib_frontend.c:1024: error: implicit declaration of function 'fib_proc_init' linux-2.6.24-git6/net/ipv4/fib_frontend.c: In function 'fib_net_exit': linux-2.6.24-git6/net/ipv4/fib_frontend.c:1039:

Re: sis190 build breakage

2008-01-29 Thread Randy Dunlap
On Wed, 30 Jan 2008 00:12:23 +0100 maximilian attems wrote: On Tue, Jan 29, 2008 at 11:27:48PM +0100, Francois Romieu wrote: maximilian attems [EMAIL PROTECTED] : [...] probably i should to get interesting info. Don't bother. $ less +/devinitdata Documentation/pci.txt [...]

[PATCH 4/4] docbook: make a networking book and fix a few errors

2008-02-11 Thread Randy Dunlap
From: Randy Dunlap [EMAIL PROTECTED] Move networking (core and drivers) docbook to its own networking book. Fix a few kernel-doc errors in header and source files. Signed-off-by: Randy Dunlap [EMAIL PROTECTED] --- Documentation/DocBook/Makefile|2 Documentation/DocBook/kernel

[PATCH 2/4] docbook: sunrpc filenames and notation fixes

2008-02-11 Thread Randy Dunlap
From: Randy Dunlap [EMAIL PROTECTED] Use updated file list for docbook files and fix kernel-doc warnings in sunrpc: Warning(linux-2.6.24-git12//net/sunrpc/rpc_pipe.c:689): No description found for parameter 'rpc_client' Warning(linux-2.6.24-git12//net/sunrpc/rpc_pipe.c:765): No description found

Re: [PATCH 2/2] add rcu_assign_index() if ever needed

2008-02-14 Thread Randy Dunlap
On Wed, 13 Feb 2008 14:05:15 -0800 Paul E. McKenney wrote: Hello again! This is a speculative patch that as far as I can tell is not yet required. If anyone applies RCU to a data structure allocated out of an array, using array indexes in place of pointers to link the array elements

[PATCH] net: fix kernel-doc warnings in header files

2008-02-18 Thread Randy Dunlap
From: Randy Dunlap [EMAIL PROTECTED] Add missing structure kernel-doc descriptions to sock.h skbuff.h to fix kernel-doc warnings. (I think that Stephen H. sent a similar patch, but I can't find it. I just want to kill the warnings, with either patch.) Signed-off-by: Randy Dunlap [EMAIL

Re: [PATCH 22/28] mm: add support for non block device backed swap files

2008-02-20 Thread Randy Dunlap
On Wed, 20 Feb 2008 15:46:32 +0100 Peter Zijlstra wrote: Signed-off-by: Peter Zijlstra [EMAIL PROTECTED] --- Documentation/filesystems/Locking | 19 + Documentation/filesystems/vfs.txt | 17 include/linux/buffer_head.h |2 - include/linux/fs.h

Re: [PATCH v2 net-next] documentation: bring vxlan documentation more up-to-date

2015-08-12 Thread Randy Dunlap
On 08/12/15 10:23, Rick Jones wrote: From: Rick Jones rick.jon...@hp.com A few things have changed since the previous version of the vxlan documentation was written, so update it and correct some grammer and if there are more updates: grammar such while we

Re: linux-next: Tree for Jul 27 (net/mpls/af_mpls.c)

2015-07-27 Thread Randy Dunlap
On 07/26/15 23:02, Stephen Rothwell wrote: Hi all, Changes since 20150724: on i386 or x86_64: when CONFIG_IPV6 is not enabled: net/built-in.o: In function `find_outdev': af_mpls.c:(.text+0x1e8ddd): undefined reference to `ip6_route_output' af_mpls.c:(.text+0x1e8e90): undefined reference

Re: linux-next: Tree for Nov 13 (netfilter)

2015-11-13 Thread Randy Dunlap
On 11/12/15 18:23, Stephen Rothwell wrote: > Hi all, > > Please do *not* add any material intended for v4.5 to your linux-next > included branches until after v4.4-rc1 has been released. > > Changes since 20151112: > on x86_64: net/built-in.o: In function `tee_tg6': xt_TEE.c:(.text+0x4b28b):

Re: [PATCH net-next v2 2/2] Documentation: networking: dsa: Add Broadcom SF2 document

2015-08-25 Thread Randy Dunlap
On 08/25/15 10:40, Florian Fainelli wrote: Add a document describing the Broadcom Starfigther 2 switch hardware, its specifics, and how the driver is implemented and its specifics. Signed-off-by: Florian Fainelli f.faine...@gmail.com --- Documentation/networking/dsa/bcm_sf2.txt | 113

Re: linux-next: Tree for Sep 8 (netfilter build error)

2015-09-08 Thread Randy Dunlap
On 09/07/15 22:21, Stephen Rothwell wrote: > Hi all, > > Please do not add material for v4.4 until after v4.3-rc1 is out. > > Changes since 20150903: > on i386: net/built-in.o: In function `nf_dup_ipv6': (.text+0x16dfba): undefined reference to `nf_conntrack_untracked' net/built-in.o: In

[PATCH net-next] net: fix cdc-phonet.c dependency and build error

2015-09-16 Thread Randy Dunlap
From: Randy Dunlap <rdun...@infradead.org> Fix build error caused by missing Kconfig dependency: ERROR: "cdc_parse_cdc_header" [drivers/net/usb/cdc-phonet.ko] undefined! Reported-by: Fengguang Wu <fengguang...@intel.com> Signed-off-by: Randy Dunlap <rdun...@infradead.

Re: linux-next: Tree for Oct 1 (ipvs)

2015-10-01 Thread Randy Dunlap
On 09/30/15 23:50, Stephen Rothwell wrote: > Hi all, > > Changes since 20150930: > on x86_64: ../net/netfilter/ipvs/ip_vs_core.c: In function 'ip_vs_leave': ../net/netfilter/ipvs/ip_vs_core.c:584:6: error: implicit declaration of function 'ip_vs_addr_is_unicast'

Re: linux-next: Tree for Sep 23 (netfilter)

2015-09-23 Thread Randy Dunlap
On 09/22/15 21:23, Stephen Rothwell wrote: > Hi all, > > Changes since 20150922: > on x86_64: net/built-in.o: In function `nf_dup_ipv4': (.text+0xed24d): undefined reference to `nf_conntrack_untracked' net/built-in.o: In function `nf_dup_ipv4': (.text+0xed267): undefined reference to

Re: linux-next: Tree for Dec 31 (net/xfrm/xfrm_input.c)

2015-12-31 Thread Randy Dunlap
On 12/31/15 04:30, Stephen Rothwell wrote: > Hi all, > > Changes since 20151223: > seen on i386 or x86_64: In file included from ../net/xfrm/xfrm_input.c:17:0: ../include/net/ip6_tunnel.h: In function 'ip6tunnel_xmit': ../include/net/ip6_tunnel.h:93:2: error: implicit declaration of function

Re: Regarding VRF support in Linux Kernel

2016-06-22 Thread Randy Dunlap
On 06/22/16 14:05, Ajith Adapa wrote: > Hi, > > I am following the steps present in > (https://www.kernel.org/doc/Documentation/networking/vrf.txt) and > trying to create IPv4 VRF in latest Fedora 24 distribution with 4.5 > Linux kernel. > > [root@localhost ip]# uname -a > Linux

Re: [PATCH] of_mdio: select fixed phy support unconditionally

2016-06-25 Thread Randy Dunlap
gt; a small increase in code size for cases that do not need fixed phy > support, but it should avoid all of the link-time problems. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> > Fixes: d1bd330a229f ("of_mdio: Enable fixed PHY support if driver is a > module")

Re: linux-next: Tree for Mar 9 (net: bpf)

2016-03-09 Thread Randy Dunlap
On 03/08/16 21:38, Stephen Rothwell wrote: > Hi all, > > Changes since 20160308: > on x86_64: ../net/core/filter.c: In function 'bpf_skb_get_tunnel_opt': ../net/core/filter.c:1824:2: error: implicit declaration of function 'ip_tunnel_info_opts_get' [-Werror=implicit-function-declaration]

Re: linux-next: Tree for Mar 9 (net: bpf)

2016-03-09 Thread Randy Dunlap
On 03/09/16 08:48, Daniel Borkmann wrote: > On 03/09/2016 05:44 PM, Randy Dunlap wrote: >> On 03/08/16 21:38, Stephen Rothwell wrote: >>> Hi all, >>> >>> Changes since 20160308: >> >> on x86_64: >> >> ../net/core/filter.c: In function 'bp

Re: linux-next: Tree for Mar 9 (net: bpf)

2016-03-09 Thread Randy Dunlap
On 03/09/16 09:07, Randy Dunlap wrote: > On 03/09/16 08:48, Daniel Borkmann wrote: >> On 03/09/2016 05:44 PM, Randy Dunlap wrote: >>> On 03/08/16 21:38, Stephen Rothwell wrote: >>>> Hi all, >>>> >>>> Changes since 20160308: >&g

Re: linux-next: Tree for Mar 21 (openvswitch)

2016-03-21 Thread Randy Dunlap
On 03/20/16 21:13, Stephen Rothwell wrote: > Hi all, > > Please do not add any v4.7 related material to your linux-next included > trees until after v4.6-rc1 is released. > > Changes since 20160318: > on i386: ERROR: "nf_nat_icmp_reply_translation" [net/openvswitch/openvswitch.ko] undefined!

Re: [patch net-next 2/2] devlink: fix trace format string

2016-07-14 Thread Randy Dunlap
acing facility") > Signed-off-by: Jiri Pirko <j...@mellanox.com> Acked-by: Randy Dunlap <rdun...@infradead.org> Thanks. > --- > include/trace/events/devlink.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/trace/events/devlink

Re: [patch net-next 1/2] tracing: change owner name to driver name for devlink hwmsg tracepoint

2016-07-14 Thread Randy Dunlap
On 07/14/16 02:37, Jiri Pirko wrote: > From: Jiri Pirko <j...@mellanox.com> > > Turned on that driver->owner which is struct module is not available when > modules are disabled. Better to depend on a driver name which is > always available. > > Reported-by: Randy

Re: [PATCH] net: bfin_mac: Fix a few spelling fixes

2016-08-14 Thread Randy Dunlap
On 08/12/16 05:58, LABBE Corentin wrote: > This patch respell some word badly spelled. > - Invidate instead of Invalidate > - proble instead of probe > > Signed-off-by: LABBE Corentin > --- > drivers/net/ethernet/adi/bfin_mac.c | 8 > 1 file changed, 4

Re: [RFC PATCH 30/30] Documentation/networking: Document net policy

2016-07-18 Thread Randy Dunlap
On 07/17/16 23:56, kan.li...@intel.com wrote: > From: Kan Liang > > Signed-off-by: Kan Liang > --- > Documentation/networking/netpolicy.txt | 158 > + > 1 file changed, 158 insertions(+) > create mode 100644

Re: linux-next: Tree for Jul 13 (net/core/devlink with Tracing)

2016-07-13 Thread Randy Dunlap
On 07/12/16 23:47, Stephen Rothwell wrote: > Hi all, > > Changes since 20160712: > on x86_64: (full randconfig file is attached) CC net/core/devlink.o In file included from ../include/trace/define_trace.h:95:0, from ../include/trace/events/devlink.h:51,

Re: [RFC V2 PATCH 01/25] net: introduce NET policy

2016-08-04 Thread Randy Dunlap
On 08/04/16 12:36, kan.li...@intel.com wrote: > From: Kan Liang > > This patch introduce NET policy subsystem. If proc is supported in the > system, it creates netpolicy node in proc system. > > Signed-off-by: Kan Liang > --- >

[PATCH -next] net/phy: fix phy_bcm_nsp_usb3.c build and kconfig

2017-01-30 Thread Randy Dunlap
From: Randy Dunlap <rdun...@infradead.org> This driver uses mdio* (PHYLIB) interfaces, so it should select PHYLIB. PHYLIB depends on NETDEVICES to this driver should also depend on NETDEVICES. Fixes these build errors: drivers/built-in.o: In function `nsp_usb3_phy_init': phy-bcm-nsp-

Re: linux-next: Tree for Aug 16 (mellanox/mlx5 & sound/oss/)

2016-08-16 Thread Randy Dunlap
On 08/15/16 21:01, Stephen Rothwell wrote: > Hi all, > > Changes since 20160815: > on i386: sound/built-in.o:(.data+0x5c): multiple definition of `dev_list' drivers/built-in.o:(.data+0x6aee8): first defined here ld: Warning: size of symbol `dev_list' changed from 8 in drivers/built-in.o to 16

Re: [net-next RFC v2 9/9] doc: Add LSM / BPF Checmate docs

2016-08-29 Thread Randy Dunlap
On 08/29/16 04:47, Sargun Dhillon wrote: > This adds documentation on how to operate, and develop against the > Checmate LSM and Cgroup controller. > > Signed-off-by: Sargun Dhillon > --- > Documentation/security/Checmate.txt | 54 > + > 1

Re: linux-next: Tree for Nov 8 (netdev, netfilter)

2016-11-08 Thread Randy Dunlap
CH_SOCKET) || \ IS_ENABLED(CONFIG_NETFILTER_XT_TARGET_TPROXY) and CONFIG_NF_SOCKET_IPV4=y See net/ipv4/netfilter/nf_socket_ipv4.c. Reported-by: Randy Dunlap <rdun...@infradead.org> -- ~Randy

Re: linux-next: Tree for Nov 9 (netdev, netfilter v6)

2016-11-09 Thread Randy Dunlap
On 11/08/16 20:40, Stephen Rothwell wrote: > Hi all, > > Changes since 20161108: > > The drm-misc tree gained a build failure, so I used the version from > next-20161108. > > The sound-asoc tree still had its build failure, so I used the version > from next-20161028. (similar to yesterday,

[PATCH] netdevice.h: fix kernel-doc warning

2016-11-21 Thread Randy Dunlap
From: Randy Dunlap <rdun...@infradead.org> Fix kernel-doc warning in (missing ':'): ..//include/linux/netdevice.h:1904: warning: No description found for parameter 'prio_tc_map[TC_BITMASK + 1]' Signed-off-by: Randy Dunlap <rdun...@infradead.org> --- include/linux/netdevice.h

Re: Coding Style: Reverse XMAS tree declarations ? (was Re: [PATCH net-next v6 02/10] dpaa_eth: add support for DPAA Ethernet)

2016-11-04 Thread Randy Dunlap
On 11/03/16 23:53, Joe Perches wrote: > On Thu, 2016-11-03 at 15:58 -0400, David Miller wrote: >> From: Madalin Bucur >> Date: Wed, 2 Nov 2016 22:17:26 +0200 >> >>> This introduces the Freescale Data Path Acceleration Architecture >>> +static inline size_t

Re: linux-next: Tree for Dec 1 (ethernet/mellanox)

2016-12-01 Thread Randy Dunlap
On 11/30/16 22:42, Stephen Rothwell wrote: > Hi all, > > Changes since 20161130: > on i386: when CONFIG_INET is not enabled: drivers/built-in.o: In function `mlx5e_test_loopback': en_selftest.c:(.text+0x690bde): undefined reference to `ip_send_check' en_selftest.c:(.text+0x690c42): undefined

Re: [PATCH net-next] net: dsa: select NET_SWITCHDEV

2017-01-09 Thread Randy Dunlap
On 01/09/17 08:32, Vivien Didelot wrote: > Hi Randy, > > Randy Dunlap <rdun...@infradead.org> writes: > >> On 01/08/17 17:18, Florian Fainelli wrote: >>> On 01/08/2017 03:17 PM, Vivien Didelot wrote: >>>> DSA wraps SWITCHDEV, thus select it ins

Re: [PATCH net-next] net: dsa: select NET_SWITCHDEV

2017-01-08 Thread Randy Dunlap
On 01/08/17 17:18, Florian Fainelli wrote: > On 01/08/2017 03:17 PM, Vivien Didelot wrote: >> DSA wraps SWITCHDEV, thus select it instead of depending on it. >> >> Signed-off-by: Vivien Didelot > > Reviewed-by: Florian Fainelli > but

Re: [PATCH] Adding-Agile-SD-TCP-module-and-modifying-Kconfig-and-makefile

2017-08-15 Thread Randy Dunlap
On 08/15/2017 06:51 AM, Neal Cardwell wrote: > On Tue, Aug 15, 2017 at 9:08 AM, mohamedalrshah > wrote: > >> +static void agilesdtcp_cong_avoid(struct sock *sk, u32 ack, u32 in_flight) >> +{ >> + struct tcp_sock *tp = tcp_sk(sk); >> + struct agilesdtcp *ca

Re: [PATCH] Adding-Agile-SD-TCP-module-and-modifying-Kconfig-and-makefile

2017-08-15 Thread Randy Dunlap
On 08/15/2017 06:08 AM, mohamedalrshah wrote: > diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig > index 91a2557..474f72c 100644 > --- a/net/ipv4/Kconfig > +++ b/net/ipv4/Kconfig > @@ -677,6 +677,17 @@ config TCP_CONG_BBR > bufferbloat, policers, or AQM schemes that do not provide a delay >

Re: [PATCH] Adding-Agile-SD-TCP-module-and-modifying-Kconfig-and-makefile

2017-08-15 Thread Randy Dunlap
On 08/15/2017 10:36 AM, David Miller wrote: > From: Randy Dunlap <rdun...@infradead.org> > Date: Tue, 15 Aug 2017 09:41:53 -0700 > >> On 08/15/2017 06:51 AM, Neal Cardwell wrote: >>> On Tue, Aug 15, 2017 at 9:08 AM, mohamedalrshah >>> <mohamed.a.alrs

Re: linux-next: Tree for Apr 26 (net/can/bcm.c)

2017-04-26 Thread Randy Dunlap
On 04/26/17 01:03, Stephen Rothwell wrote: > Hi all, > > Changes since 20170424: > on x86_64: when CONFIG_PROC_FS is not enabled: ../net/can/bcm.c:1541:14: error: 'struct netns_can' has no member named 'bcmproc_dir' ../net/can/bcm.c:1601:14: error: 'struct netns_can' has no member named

Re: linux-next: Tree for May 16 (net/core)

2017-05-16 Thread Randy Dunlap
On 05/15/17 18:21, Stephen Rothwell wrote: > Hi all, > > Changes since 20170515: > on i386 or x86_64: when CONFIG_INET is not enabled: ../net/core/sock.c: In function 'skb_orphan_partial': ../net/core/sock.c:1810:2: error: implicit declaration of function 'skb_is_tcp_pure_ack'

Re: [Regression, 4.12-rc1] Address family not supported by protocol

2017-06-09 Thread Randy Dunlap
[adding netdev] Hi Paul, Did you get anywhere with this? The only difference that I see in the kernel config files is 4.12-rc1 says: # CONFIG_NET_SCH_DEFAULT is not set and 4.11 does not have that kconfig option. On 05/15/17 05:53, Paul Menzel wrote: > Dear Linux folks, > > > When building

Re: mdio-thunder.c:undefined reference to `mdiobus_unregister'

2017-06-12 Thread Randy Dunlap
On 06/11/17 19:14, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: 32c1431eea4881a6b17bd7c639315010aeefa452 > commit: 90eff9096c01ba90cdae504a6b95ee87fe2556a3 net: phy: Allow splitting > MDIO bus/device support from PHYs >

[PATCH] net/phy: fix mdio-octeon dependency and build

2017-05-23 Thread Randy Dunlap
From: Randy Dunlap <rdun...@infradead.org> Fix build errors by making this driver depend on OF_MDIO, like several other similar drivers do. drivers/built-in.o: In function `octeon_mdiobus_remove': mdio-octeon.c:(.text+0x196ee0): undefined reference to `mdiobus_unregister' mdio-octeon.c:

[PATCH] net: phy: fix kernel-doc warnings

2017-06-04 Thread Randy Dunlap
From: Randy Dunlap <rdun...@infradead.org> Fix kernel-doc warnings (typo) in drivers/net/phy/phy.c: ..//drivers/net/phy/phy.c:259: warning: No description found for parameter 'features' ..//drivers/net/phy/phy.c:259: warning: Excess function parameter 'feature' descr

Re: [PATCH net] net: phy: Fix MDIO_THUNDER dependencies

2017-06-13 Thread Randy Dunlap
: 90eff9096c01 ("net: phy: Allow splitting MDIO bus/device support from > PHYs") > Signed-off-by: Florian Fainelli <f.faine...@gmail.com> Tested-by: Randy Dunlap <rdun...@infradead.org> Thanks. > --- > drivers/net/phy/Kconfig | 1 + > 1 file changed, 1 insertion(+

[PATCH] Documentation: networking: fix ASCII art in switchdev.txt

2017-09-16 Thread Randy Dunlap
From: Randy Dunlap <rdun...@infradead.org> Fix ASCII art in Documentation/networking/switchdev.txt: Change non-ASCII "spaces" to ASCII spaces. Change 2 erroneous '+' characters in ASCII art to '-' (at the '*' characters

Re: [PATCH] Documentation: fix ascii art in networking docs

2017-09-16 Thread Randy Dunlap
On 09/16/17 11:18, Andreas Schwab wrote: > On Sep 16 2017, Pavel Machek wrote: > >> diff --git a/Documentation/networking/switchdev.txt >> b/Documentation/networking/switchdev.txt >> index 5e40e1f..6309e90 100644 >> --- a/Documentation/networking/switchdev.txt >> +++

Re: [PATCH v4 4/4] samples/bpf: Add documentation on cross compilation

2017-09-20 Thread Randy Dunlap
On 09/20/17 09:11, Joel Fernandes wrote: > Acked-by: Alexei Starovoitov > Signed-off-by: Joel Fernandes > --- > samples/bpf/README.rst | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/samples/bpf/README.rst b/samples/bpf/README.rst >

Re: [PATCH] tests: Remove bashisms (s/source/.)

2017-10-11 Thread Randy Dunlap
On 10/11/17 11:01, Stephen Hemminger wrote: > On Sun, 8 Oct 2017 16:39:16 +0200 > Petr Vorel wrote: > >> Signed-off-by: Petr Vorel > > Ok, applied. But iproute2 is really limited to Linux and bash is lingua > franca on Linux > no French, please.

Re: [PATCH v5 next 1/5] modules:capabilities: add request_module_cap()

2017-11-27 Thread Randy Dunlap
Hi, Mostly typos/spellos... On 11/27/2017 09:18 AM, Djalal Harouni wrote: > Cc: Serge Hallyn > Cc: Andy Lutomirski > Suggested-by: Rusty Russell > Suggested-by: Kees Cook > Signed-off-by: Djalal Harouni

Re: [PATCH] leds: trigger: Introduce a NETDEV trigger

2017-11-28 Thread Randy Dunlap
On 11/28/2017 01:54 PM, Ben Whitten wrote: > diff --git a/drivers/leds/trigger/Kconfig b/drivers/leds/trigger/Kconfig > index 3f9ddb9..4ec1853 100644 > --- a/drivers/leds/trigger/Kconfig > +++ b/drivers/leds/trigger/Kconfig > @@ -126,4 +126,11 @@ config LEDS_TRIGGER_PANIC > a different

Re: [PATCH v1] Bluetooth: introduce DEFINE_SHOW_ATTRIBUTE() macro

2017-11-22 Thread Randy Dunlap
On 11/22/2017 02:04 PM, Randy Dunlap wrote: > On 11/22/2017 01:15 PM, Andy Shevchenko wrote: >> This macro deduplicates a lot of similar code across the hci_debugfs.c >> module. Targeting to be moved to seq_file.h eventually. >> >> Signed-off-by: Andy Shevchenko <and

Re: [PATCH v1] Bluetooth: introduce DEFINE_SHOW_ATTRIBUTE() macro

2017-11-22 Thread Randy Dunlap
On 11/22/2017 01:15 PM, Andy Shevchenko wrote: > This macro deduplicates a lot of similar code across the hci_debugfs.c > module. Targeting to be moved to seq_file.h eventually. > > Signed-off-by: Andy Shevchenko > --- > net/bluetooth/hci_debugfs.c | 184 >

[PATCH] cfg80211: fix kernel-doc warnings

2017-12-03 Thread Randy Dunlap
From: Randy Dunlap <rdun...@infradead.org> Drop kernel-doc comment for this value since this value was dropped in a previous commit. Fixes >100 of these warnings: ../include/net/cfg80211.h:3278: warning: Excess enum value 'WIPHY_FLAG_SUPPORTS_SCHED_SCAN' description in 'wiphy_flag

net/wireless/certs/*.x509 binary files

2017-12-18 Thread Randy Dunlap
This is just an FYI/acknowledgment that net/wireless/certs/*.x509 binary file(s) practically kills use of Linux kernel tarballs. Of course, someone can always enable EXPERT and CFG80211_CERTIFICATION_ONUS and disable the REGDB kconfig symbols to get around this. Oh, and then chmod +x

Re: [PATCH v1] net: pasemi: Replace mac address parsing

2017-12-19 Thread Randy Dunlap
On 12/19/2017 11:27 AM, Andy Shevchenko wrote: > On Tue, 2017-12-19 at 11:19 -0800, Randy Dunlap wrote: >> On 12/19/2017 10:31 AM, Andy Shevchenko wrote: >>> Replace sscanf() with mac_pton(). >>> >>> Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.in

Re: [PATCH v4 04/36] nds32: Kernel booting and initialization

2017-12-19 Thread Randy Dunlap
On 12/17/2017 10:46 PM, Greentime Hu wrote: > From: Greentime Hu > > This patch includes the kernel startup code. It can get dtb pointer > passed from bootloader. It will create a temp mapping by tlb > instructions at beginning and goto start_kernel. > > Signed-off-by:

Re: [PATCH v1] net: pasemi: Replace mac address parsing

2017-12-19 Thread Randy Dunlap
On 12/19/2017 10:31 AM, Andy Shevchenko wrote: > Replace sscanf() with mac_pton(). > > Signed-off-by: Andy Shevchenko You don't need to select GENERIC_NET_UTILS for that? > --- > drivers/net/ethernet/pasemi/pasemi_mac.c | 4 +--- > 1 file changed, 1

Re: [PATCH v1] bridge: Use helpers to handle MAC address

2017-12-19 Thread Randy Dunlap
On 12/19/2017 10:10 AM, Andy Shevchenko wrote: > Use > %pM to print MAC > mac_pton() to convert it from ASCII to binary format, and > ether_addr_copy() to copy. > > Signed-off-by: Andy Shevchenko (same) select GENERIC_NET_UTILS ? >

Re: linux-next: Tree for Nov 14 (net/sched/sch_netem)

2017-11-14 Thread Randy Dunlap
On 11/13/2017 10:20 PM, Stephen Rothwell wrote: > Hi all, > > Please do not add any v4.16 material to your linux-next included trees > until v4.15-rc1 has been released. > > Changes since 20171113: on i386: ERROR: "__moddi3" [net/sched/sch_netem.ko] undefined! -- ~Randy

Re: [PATCH net-next v2 0/2] netem: fix compilation on 32 bit

2017-11-14 Thread Randy Dunlap
> 1 file changed, 7 insertions(+), 10 deletions(-) > Acked-by: Randy Dunlap <rdun...@infradead.org> Thanks. -- ~Randy

Re: [PATCH] netem: fix 64 bit divide

2017-11-14 Thread Randy Dunlap
er in > nanoseconds") > Reported-by: Randy Dunlap <rdun...@infradead.org> > Signed-off-by: Stephen Hemminger <step...@networkplumber.org> Hi Stephen, I still get it. Maybe it's this % operator: skb->data[prandom_u32() % skb_headlen(skb)] ^=

Re: [PATCH V11 4/5] vsprintf: add printk specifier %px

2017-12-05 Thread Randy Dunlap
On 11/30/2017 02:38 AM, David Laight wrote: > From: Kees Cook >> Sent: 29 November 2017 22:28 >> On Wed, Nov 29, 2017 at 2:07 AM, David Laight >> wrote: >>> From: Linus Torvalds Sent: 29 November 2017 02:29 On Tue, Nov 28, 2017 at 6:05 PM, Tobin C. Harding

Re: Linux 4.15-rc3 (uml + bpf_perf_event.h)

2017-12-10 Thread Randy Dunlap
On 12/10/2017 06:08 PM, Linus Torvalds wrote: > Another week, another rc. > um (uml) won't build on i386 or x86_64: CC init/main.o In file included from ../include/linux/perf_event.h:18:0, from ../include/linux/trace_events.h:10, from

Re: Linux 4.15-rc3 (uml + bpf_perf_event.h)

2017-12-11 Thread Randy Dunlap
On 12/11/2017 02:19 AM, Daniel Borkmann wrote: > Hi Randy, hi Richard, [ +Hendrik for c895f6f703ad7dd2f ] > > On 12/11/2017 09:32 AM, Richard Weinberger wrote: >> Randy, >> >> Am Montag, 11. Dezember 2017, 03:42:12 CET schrieb Randy Dunlap: >>> On 12/10

Re: Linux 4.15-rc3 (uml + bpf_perf_event.h)

2017-12-11 Thread Randy Dunlap
;> Am Montag, 11. Dezember 2017, 03:42:12 CET schrieb Randy Dunlap: >>>> On 12/10/2017 06:08 PM, Linus Torvalds wrote: >>>>> Another week, another rc. >>>> >>>> um (uml) won't build on i386 or x86_64: >>>> CC init/main.o >&

Re: [net 1/1] net/mlx5: Fix build break when CONFIG_SMP=n

2018-05-14 Thread Randy Dunlap
y_hint’: > include/linux/mlx5/driver.h:1299:13: error: > ‘struct irq_desc’ has no member named ‘affinity_hint’ > > Fixes: 6082d9c9c94a ("net/mlx5: Fix mlx5_get_vector_affinity function") > Signed-off-by: Saeed Mahameed <sae...@mellanox.com> > CC: Randy Du

Re: [PATCH v1 1/4] media: rc: introduce BPF_PROG_IR_DECODER

2018-05-14 Thread Randy Dunlap
On 05/14/2018 02:10 PM, Sean Young wrote: > Add support for BPF_PROG_IR_DECODER. This type of BPF program can call Kconfig file below uses IR_BPF_DECODER instead of the symbol name above. and then patch 3 says a third choice: The context provided to a BPF_PROG_RAWIR_DECODER is a struct

Re: [PATCH net-next v10 2/4] net: Introduce generic failover module

2018-05-07 Thread Randy Dunlap
Hi, On 05/07/2018 03:10 PM, Sridhar Samudrala wrote: > > Signed-off-by: Sridhar Samudrala > --- > MAINTAINERS|7 + > include/linux/netdevice.h | 16 + > include/net/net_failover.h | 52 +++ > net/Kconfig| 10 + >

<    1   2   3   >