[PATCH WIP RFC 3/3] mpls: register lwtunnel ops

2015-06-03 Thread Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com - This is just part of the patch. Unfortunately i realized that my tree has other changes for mpls unrelated to ler - also, The nla_put and nla_get label are different in the patch than upstream because of some other changes in my tree Signed-off

[PATCH WIP RFC 2/3] ipv4 fib: lwtunnel handling

2015-06-03 Thread Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com - parse RTA_ENCAP - store lwtstate in every nexthop - set dst-output to point to lwtunnel output Signed-off-by: Roopa Prabhu ro...@cumulusnetworks.com --- include/net/dst.h|2 ++ include/net/ip_fib.h |5 - net/ipv4

[PATCH WIP RFC 0/3] mpls: support for ler

2015-06-03 Thread Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com This is still WIP and incomplete. Posting it here because of the other discussions happening around mpls ler in the context of Roberts code and I happened to mention this implementation. This was in response to earlier email thread with Eric on net

[PATCH WIP RFC 1/3] lwtunnels: basic infra for light weight tunnels like mpls

2015-06-03 Thread Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com Still in the works. Not fully functional. And in some cases me going back and forth on a few things. Started with thinking the tunnel hdr can be shared and refcounted. Its somewhere mid way now. Signed-off-by: Roopa Prabhu ro...@cumulusnetworks.com

[PATCH net iproute2 v4] mpls: always set type RTN_UNICAST and scope RT_SCOPE_UNIVERSE for route add/deletes

2015-06-02 Thread Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com This patch fixes incorrect -EINVAL errors due to invalid scope and type during mpls route deletes. $ip -f mpls route add 100 as 200 via inet 10.1.1.2 dev swp1 $ip -f mpls route show 100 as to 200 via inet 10.1.1.2 dev swp1 $ip -f mpls route del 100

[PATCH net-next RFC v2 2/3] ipv4: add support for light weight tunnel encap attributes

2015-06-18 Thread Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com Introduces two netlink attributes RTA_ENCAP_TYPE and RTA_ENCAP to support attaching encap information to ipv4 routes. RTA_ENCAP is a nested attribute as suggested by Thomas (and also as Robert had it in his series). RTA_ENCAP netlink policy

[PATCH net-next RFC v2 1/3] lwt: infrastructure to support light weight tunnels

2015-06-18 Thread Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com provides ops to parse, build and output encaped packets for drivers that want to attach tunnel encap information to routes. Signed-off-by: Roopa Prabhu ro...@cumulusnetworks.com --- include/linux/lwtunnel.h |6 ++ include/net/lwtunnel.h

[PATCH net-next RFC v2 0/3] light weight tunnel infrastructure and driver

2015-06-18 Thread Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com This series implements infrastructure for light weight tunnels to support mpls label edge routers (ie mpls ip tunnels). As previously discussed having netdevices will not scale. Hence this series introduces new RTA_ENCAP* attributes to attach encap

[PATCH net] ipv4: include NLM_F_APPEND flag in append route notifications

2015-06-16 Thread Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com This patch adds NLM_F_APPEND flag to struct nlmsg_hdr-nlmsg_flags in newroute notifications if the route add was an append. (This is similar to how NLM_F_REPLACE is already part of new route replace notifications today) This helps userspace determine

[PATCH net-next] ipv4: include NLM_F_APPEND flag in append route notifications

2015-06-16 Thread Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com This patch adds NLM_F_APPEND flag to struct nlmsg_hdr-nlmsg_flags in newroute notifications if the route add was an append. (This is similar to how NLM_F_REPLACE is already part of new route replace notifications today) This helps userspace determine

[PATCH net-next v2] ipv4: include NLM_F_APPEND flag in append route notifications

2015-06-17 Thread Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com This patch adds NLM_F_APPEND flag to struct nlmsg_hdr-nlmsg_flags in newroute notifications if the route add was an append. (This is similar to how NLM_F_REPLACE is already part of new route replace notifications today) This helps userspace determine

[PATCH net iproute2 v2 1/2] mpls: always set type as RTN_UNICAST for route add/deletes

2015-05-27 Thread Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com Kernel expects type RTN_UNICAST for mpls route/dels Signed-off-by: Vivek Venkataraman vi...@cumulusnetworks.com Signed-off-by: Roopa Prabhu ro...@cumulusnetworks.com --- ip/iproute.c |5 + 1 file changed, 5 insertions(+) diff --git a/ip

[PATCH net v2 0/2] mpls: fix route del errors on wrong scope and type

2015-05-27 Thread Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com This patch fixes incorrect -EINVAL errors due to invalid scope and type during mpls route deletes. $ip -f mpls route add 100 as 200 via inet 10.1.1.2 dev swp1 $ip -f mpls route show 100 as to 200 via inet 10.1.1.2 dev swp1 $ip -f mpls route del 100

[PATCH net v2 2/2] mpls: fix mpls route deletes to not check for route scope

2015-05-27 Thread Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com Ignore scope for route del messages Signed-off-by: Vivek Venkataraman vi...@cumulusnetworks.com Signed-off-by: Roopa Prabhu ro...@cumulusnetworks.com --- net/mpls/af_mpls.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[PATCH net v3 0/2] mpls: fix route del errors on wrong scope and type

2015-06-02 Thread Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com This patch fixes incorrect -EINVAL errors due to invalid scope and type during mpls route deletes. $ip -f mpls route add 100 as 200 via inet 10.1.1.2 dev swp1 $ip -f mpls route show 100 as to 200 via inet 10.1.1.2 dev swp1 $ip -f mpls route del 100

[PATCH net v3 2/2] mpls: fix mpls route deletes to not check for route scope

2015-06-02 Thread Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com Ignore scope for route del messages Signed-off-by: Vivek Venkataraman vi...@cumulusnetworks.com Signed-off-by: Roopa Prabhu ro...@cumulusnetworks.com Reviewed-by: Robert Shearman rshea...@brocade.com --- net/mpls/af_mpls.c |3 ++- 1 file changed

[PATCH net iproute2 v3 1/2] mpls: always set type as RTN_UNICAST for route add/deletes

2015-06-02 Thread Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com Kernel expects type RTN_UNICAST for mpls route/dels Signed-off-by: Vivek Venkataraman vi...@cumulusnetworks.com Signed-off-by: Roopa Prabhu ro...@cumulusnetworks.com Reviewed-by: Robert Shearman rshea...@brocade.com --- ip/iproute.c |5 + 1

[PATCH net] mpls: fix mpls route deletes to not check for route scope and type

2015-05-26 Thread Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com This patch fixes incorrect -EINVAL error due to invalid scope and type for mpls route deletes. iproute2 route modify code does not set protocol/scope/type for RTM_DELROUTE msgs. mpls code can skip checking for these too. $ip -f mpls route add 100

[PATCH net-next 2/3] mpls: consistently use u8 to store number of labels

2015-08-11 Thread Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com change all types representing number of labels to u8 to be consistent. This also changes labels to u8 in the light weight mpls_tunnel_encap structure. This is because the light weight mpls iptunnel code shares some of the label encoding functions like

[PATCH net-next 1/3] mpls: move mpls_route nexthop fields to a new nhlfe struct

2015-08-11 Thread Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com moves mpls_route nexthop fields to a new mpls_nhlfe struct. mpls_nhlfe represents a mpls nexthop label forwarding entry. It prepares mpls route structure for multipath support. In the process moves mpls_route structure into internal.h. Moves some

[PATCH net-next 0/3] mpls: multipath support

2015-08-11 Thread Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com This patch series adds multipath support to mpls routes. resembles ipv4 multipath support. The multipath route nexthop selection algorithm is the same code as in ipv4 fib code. I understand that the multipath algorithm in ipv4 is undergoing some

[PATCH net-next 3/3] mpls: add multipath route support

2015-08-11 Thread Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com Adds support for MPLS multipath routes. supports parse/fill of RTA_MULTIPATH netlink attribute for multipath routes similar to ipv4 fib. Mostly based on multipath handling in ipv4 fib code. The multipath route nexthop selection algorithm is the same

[PATCH net-next v5 2/2] af_mpls: fix undefined reference to ip6_route_output

2015-07-28 Thread Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com Undefined reference to ip6_route_output and ip_route_output was reported with CONFIG_INET=n and CONFIG_IPV6=n. This patch uses ipv6_stub_impl.ipv6_dst_lookup instead of ip6_route_output. And wraps affected code under IS_ENABLED(CONFIG_INET

[PATCH net-next v5 0/2] af_mpls: fix undefined reference to ip6_route_output with CONFIG_IPV6=n

2015-07-28 Thread Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com This patch series uses ipv6_stub_impl.ipv6_dst_lookup instead of ip6_route_output. Follows the vxlan drivers usage of ipv6_stub_impl.ipv6_dst_lookup. There is no sk in the af_mpls context from where ipv6_stub_impl.ipv6_dst_lookup is used. sk appears

[PATCH net-next v5 1/2] ipv6: change ipv6_stub_impl.ipv6_dst_lookup to take net argument

2015-07-28 Thread Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com This patch adds net argument to ipv6_stub_impl.ipv6_dst_lookup for use cases where sk is not available (like mpls). sk appears to be needed to get the namespace 'net' and is optional otherwise. This patch series changes ipv6_stub_impl.ipv6_dst_lookup

[PATCH iproute2] bridge fdb: add 'use' option to set NTF_USE flag in fdb add requests

2015-07-29 Thread Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com This is similar to command options corresponding to other NTF_* flags already exposed to the user space (examples self/master). Also updates bridge man page (The man page patch also includes a fix to the 'self' entry and documents 'master' for fdb

[PATCH net-next v6 1/2] ipv6: change ipv6_stub_impl.ipv6_dst_lookup to take net argument

2015-07-30 Thread Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com This patch adds net argument to ipv6_stub_impl.ipv6_dst_lookup for use cases where sk is not available (like mpls). sk appears to be needed to get the namespace 'net' and is optional otherwise. This patch series changes ipv6_stub_impl.ipv6_dst_lookup

[PATCH net-next v6 0/2] af_mpls: fix undefined reference to ip6_route_output with CONFIG_IPV6=n

2015-07-30 Thread Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com This patch series uses ipv6_stub_impl.ipv6_dst_lookup instead of ip6_route_output. Follows the vxlan drivers usage of ipv6_stub_impl.ipv6_dst_lookup. There is no sk in the af_mpls context from where ipv6_stub_impl.ipv6_dst_lookup is used. sk appears

[PATCH net-next v6 2/2] af_mpls: fix undefined reference to ip6_route_output

2015-07-30 Thread Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com Undefined reference to ip6_route_output and ip_route_output was reported with CONFIG_INET=n and CONFIG_IPV6=n. This patch uses ipv6_stub_impl.ipv6_dst_lookup instead of ip6_route_output. And wraps affected code under IS_ENABLED(CONFIG_INET

[PATCH iproute2 v2] bridge fdb: add 'use' option to set NTF_USE flag in fdb add requests

2015-07-30 Thread Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com This is similar to command options corresponding to other NTF_* flags already exposed to the user space (examples self/master). Also updates bridge man page (The man page patch also includes a fix to the 'self' entry and documents 'master' for fdb

[PATCH net-next v6] af_mpls: add null dev check in find_outdev

2015-08-04 Thread Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com This patch adds null dev check for the 'cfg-rc_via_table == NEIGH_LINK_TABLE or dev_get_by_index() failed' case Reported-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Roopa Prabhu ro...@cumulusnetworks.com --- net/mpls/af_mpls.c |3

[PATCH net-next v2] af_mpls: add null dev check in find_outdev

2015-08-04 Thread Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com This patch adds null dev check for the 'cfg-rc_via_table == NEIGH_LINK_TABLE or dev_get_by_index() failed' case Reported-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Roopa Prabhu ro...@cumulusnetworks.com --- v1-v2 : fixed patch version

[PATCH net-next v4] af_mpls: fix undefined reference to ip6_route_output

2015-07-28 Thread Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com Undefined reference to ip6_route_output and ip_route_output was reported with CONFIG_INET=n and CONFIG_IPV6=n. This patch adds new CONFIG_MPLS_NEXTHOP_DEVLOOKUP to lookup nexthop device if user has not specified it in RTA_OIF attribute. Make

[PATCH net-next v3] af_mpls: fix undefined reference to ip6_route_output

2015-07-27 Thread Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com This patch fixes undefined reference to ip6_route_output and ip_route_output with CONFIG_INET=n and CONFIG_IPV6=n. The patch adds new CONFIG_MPLS_NEXTHOP_DEVLOOKUP to lookup nexthop device if user has not specified it in RTA_OIF attribute. Make

[PATCH net-next] mpls: make RTA_OIF optional

2015-07-21 Thread Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com If user did not specify an oif, try and get it from the via address. If failed to get device, return with -ENODEV. Signed-off-by: Roopa Prabhu ro...@cumulusnetworks.com --- net/mpls/af_mpls.c | 67

[PATCH net-next] mpls_iptunnel: fix sparse warn: remove incorrect rcu_dereference

2015-07-21 Thread Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com fix for: net/mpls/mpls_iptunnel.c:73:19: sparse: incompatible types in comparison expression (different address spaces) remove incorrect rcu_dereference possibly left over from earlier revisions of the code. Reported-by: kbuild test robot fengguang

[PATCH net-next] af_mpls: fix undefined reference to ip6_route_output

2015-07-22 Thread Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com seen with CONFIG_IPV6 disabled. Wrap the code around IS_ENABLED(CONFIG_IPV6) Reported-by: kbuild test robot fengguang...@intel.com Signed-off-by: Roopa Prabhu ro...@cumulusnetworks.com --- net/mpls/af_mpls.c |7 +++ 1 file changed, 7

[PATCH net-next] af_mpls: fix undefined reference to ip6_route_output

2015-07-22 Thread Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com seen with CONFIG_IPV6 disabled. Wrap the code around IS_BUILTIN(CONFIG_IPV6). Also fixes undefined reference to ip_route_output with CONFIG_INET=n Reported-by: kbuild test robot fengguang...@intel.com Reported-by: Thomas Graf tg...@suug.ch Signed-off

[PATCH net-next iproute2] support batching of ip route get commands

2015-07-15 Thread Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com This patch replaces exits with returns in ip route get command handling. This allows batching of ip route get commands. $cat route_get_batch.txt route get 10.0.14.2 route get 12.0.14.2 route get 10.0.14.4 $ip -batch route_get_batch.txt local

[PATCH net-next v6 1/2] mpls: multipath route support

2015-10-23 Thread Roopa Prabhu
From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch adds support for MPLS multipath routes. Includes following changes to support multipath: - splits struct mpls_route into 'struct mpls_route + struct mpls_nh' - 'struct mpls_nh' represents a mpls nexthop label forwarding entry -

[PATCH net-next v6 0/2] mpls: multipath support

2015-10-23 Thread Roopa Prabhu
From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch adds support for MPLS multipath routes. Includes following changes to support multipath: - splits struct mpls_route into 'struct mpls_route + struct mpls_nh'. - struct mpls_nh represents a mpls nexthop label forwarding entry

[PATCH net-next v6 2/2] mpls: flow-based multipath selection

2015-10-23 Thread Roopa Prabhu
<rshea...@brocade.com> Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> --- net/mpls/af_mpls.c | 87 +++--- 1 file changed, 83 insertions(+), 4 deletions(-) diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c index ee3097a..cc972e3 100

[PATCH net-next v5 0/2] mpls: multipath support

2015-10-22 Thread Roopa Prabhu
From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch adds support for MPLS multipath routes. Includes following changes to support multipath: - splits struct mpls_route into 'struct mpls_route + struct mpls_nh'. - struct mpls_nh represents a mpls nexthop label forwarding entry

[PATCH net-next v5 1/2] mpls: multipath route support

2015-10-22 Thread Roopa Prabhu
From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch adds support for MPLS multipath routes. Includes following changes to support multipath: - splits struct mpls_route into 'struct mpls_route + struct mpls_nh' - 'struct mpls_nh' represents a mpls nexthop label forwarding entry -

[PATCH net-next v5 2/2] mpls: flow-based multipath selection

2015-10-22 Thread Roopa Prabhu
From: Robert Shearman Change the selection of a multipath route to use a flow-based hash. This more suitable for traffic sensitive to reordering within a flow (e.g. TCP, L2VPN) and whilst still allowing a good distribution of traffic given enough flows. Selection of the

[PATCH net-next] bridge: set is_local and is_static before fdb entry is added to the fdb hashtable

2015-10-26 Thread Roopa Prabhu
From: Roopa Prabhu <ro...@cumulusnetworks.com> Problem Description: We can add fdbs pointing to the bridge with NULL ->dst but that has a few race conditions because br_fdb_insert() is used which first creates the fdb and then, after the fdb has been published/linked, sets "

[PATCH net-next v2] bridge: set is_local and is_static before fdb entry is added to the fdb hashtable

2015-10-27 Thread Roopa Prabhu
From: Roopa Prabhu <ro...@cumulusnetworks.com> Problem Description: We can add fdbs pointing to the bridge with NULL ->dst but that has a few race conditions because br_fdb_insert() is used which first creates the fdb and then, after the fdb has been published/linked, sets "

[PATCH net-next RFC] mpls: support for dead routes

2015-10-29 Thread Roopa Prabhu
From: Roopa Prabhu <ro...@cumulusnetworks.com> Adds support for both RTNH_F_DEAD and RTNH_F_LINKDOWN flags. This resembles ipv4 fib code. I also picked fib_rebalance from ipv4. Enabled weights support for nexthop, just because the infrastructure is already there. Signed-off-by: Roopa Prab

[PATCH net-next v3] bridge: set is_local and is_static before fdb entry is added to the fdb hashtable

2015-10-27 Thread Roopa Prabhu
From: Roopa Prabhu <ro...@cumulusnetworks.com> Problem Description: We can add fdbs pointing to the bridge with NULL ->dst but that has a few race conditions because br_fdb_insert() is used which first creates the fdb and then, after the fdb has been published/linked, sets "

[PATCH net-next v2] mpls: support for dead routes

2015-11-02 Thread Roopa Prabhu
From: Roopa Prabhu <ro...@cumulusnetworks.com> Adds support for RTNH_F_DEAD and RTNH_F_LINKDOWN flags on mpls routes due to link events. Also adds code to ignore dead routes during route selection Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> --- RFC to v1: Add

[PATCH net-next] mpls: support for dead routes

2015-11-02 Thread Roopa Prabhu
From: Roopa Prabhu <ro...@cumulusnetworks.com> Adds support for RTNH_F_DEAD and RTNH_F_LINKDOWN flags on mpls routes due to link events. Also adds code to ignore dead routes during route selection Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> --- RFC to v1: Add

[PATCH net-next v3] mpls: support for dead routes

2015-11-03 Thread Roopa Prabhu
From: Roopa Prabhu <ro...@cumulusnetworks.com> Adds support for RTNH_F_DEAD and RTNH_F_LINKDOWN flags on mpls routes due to link events. Also adds code to ignore dead routes during route selection Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> --- Dave, I know you are onl

[PATCH net-next v4 1/2] mpls: multipath route support

2015-10-18 Thread Roopa Prabhu
From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch adds support for MPLS multipath routes. Includes following changes to support multipath: - splits struct mpls_route into 'struct mpls_route + struct mpls_nh' - 'struct mpls_nh' represents a mpls nexthop label forwarding entry -

[PATCH net-next v4 0/2] mpls: multipath support

2015-10-18 Thread Roopa Prabhu
From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch adds support for MPLS multipath routes. Includes following changes to support multipath: - splits struct mpls_route into 'struct mpls_route + struct mpls_nh'. - struct mpls_nh represents a mpls nexthop label forwarding entry

[PATCH net-next v4 2/2] mpls: flow-based multipath selection

2015-10-18 Thread Roopa Prabhu
From: Robert Shearman Change the selection of a multipath route to use a flow-based hash. This more suitable for traffic sensitive to reordering within a flow (e.g. TCP, L2VPN) and whilst still allowing a good distribution of traffic given enough flows. Selection of the

[PATCH iproute2] bridge: add batch command support

2015-10-07 Thread Roopa Prabhu
From: Wilson Kok <w...@cumulusnetworks.com> This patch adds support to batch bridge commands. Follows ip batch code. Signed-off-by: Wilson Kok <w...@cumulusnetworks.com> Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> --- brid

[PATCH net-next v3] bridge: allow adding of fdb entries pointing to the bridge device

2015-10-08 Thread Roopa Prabhu
From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch enables adding of fdb entries pointing to the bridge device. This can be used to propagate mac address of vlan interfaces configured on top of the vlan filtering bridge. Before: $bridge fdb add 44:38:39:00:27:9f dev bridge RTN

[PATCH net-next] ipv6 route: use err pointers instead of returning pointer by reference

2015-10-08 Thread Roopa Prabhu
From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch makes ip6_route_info_create return err pointer instead of returning the rt pointer by reference as suggested by Dave Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> --- Dave, sorry abt the delay on this one. net-nex

[PATCH iproute2] bridge: add calls to fflush in fdb and mdb print functions

2015-10-15 Thread Roopa Prabhu
From: Wilson Kok <w...@cumulusnetworks.com> This patch adds fflush in fdb and mdb print functions Signed-off-by: Wilson Kok <w...@cumulusnetworks.com> Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> --- bridge/fdb.c | 2 ++ bridge/mdb.c | 2 ++ 2 files changed, 4 i

[PATCH iproute2] ip route get: change exit to return to support batch commands

2015-10-15 Thread Roopa Prabhu
From: Roopa Prabhu <ro...@cumulusnetworks.com> replace exit with return -2 on rtnl_talk failure Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> --- ip/iproute.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ip/iproute.c b/ip/iproute.c index da25548..b1

[PATCH iproute2] ip monitor neigh: Change 'delete' to 'Deleted' to be consistent with ip route

2015-10-15 Thread Roopa Prabhu
From: Roopa Prabhu <ro...@cumulusnetworks.com> It helps to grep for one string "Deleted" when monitoring all events. Fixes: 6ea3ebafe077 ("iproute2: inform user when a neighbor is removed") Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> ---

[PATCH net-next v2] ipv6 route: use err pointers instead of returning pointer by reference

2015-10-10 Thread Roopa Prabhu
From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch makes ip6_route_info_create return err pointer instead of returning the rt pointer by reference as suggested by Dave Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> --- v1 - v2: remove unnecessary NULL initiali

[PATCH net-next v3 1/2] mpls: multipath route support

2015-10-11 Thread Roopa Prabhu
From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch adds support for MPLS multipath routes. Includes following changes to support multipath: - splits struct mpls_route into 'struct mpls_route + struct mpls_nh' - 'struct mpls_nh' represents a mpls nexthop label forwarding entry -

[PATCH net-next v3 0/2] mpls: multipath support

2015-10-11 Thread Roopa Prabhu
From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch adds support for MPLS multipath routes. Includes following changes to support multipath: - splits struct mpls_route into 'struct mpls_route + struct mpls_nh'. - struct mpls_nh represents a mpls nexthop label forwarding entry

[PATCH net-next v3 2/2] mpls: flow-based multipath selection

2015-10-11 Thread Roopa Prabhu
From: Robert Shearman Change the selection of a multipath route to use a flow-based hash. This more suitable for traffic sensitive to reordering within a flow (e.g. TCP, L2VPN) and whilst still allowing a good distribution of traffic given enough flows. Selection of the

[PATCH iproute2 v2] bridge: add batch command support

2015-10-11 Thread Roopa Prabhu
From: Wilson Kok <w...@cumulusnetworks.com> This patch adds support to batch bridge commands. Follows ip batch code. Signed-off-by: Wilson Kok <w...@cumulusnetworks.com> Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> Acked-by: Christophe Gouault <christophe.goua

[PATCH net-next] bridge: allow adding of fdb entries pointing to the bridge device

2015-10-06 Thread Roopa Prabhu
From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch enables adding of fdb entries pointing to the bridge device. This can be used to propagate mac address of vlan interfaces configured on top of the vlan filtering bridge. Before: $bridge fdb add 44:38:39:00:27:9f dev bridge RTN

[PATCH net-next v2 1/2] mpls: multipath support

2015-10-06 Thread Roopa Prabhu
From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch adds support for MPLS multipath routes. Includes following changes to support multipath: - splits struct mpls_route into 'struct mpls_route + struct mpls_nh' - 'struct mpls_nh' represents a mpls nexthop label forwarding entry -

[PATCH net-next v2 0/2] mpls: multipath support

2015-10-06 Thread Roopa Prabhu
From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch adds support for MPLS multipath routes. Includes following changes to support multipath: - splits struct mpls_route into 'struct mpls_route + struct mpls_nh'. - struct mpls_nh represents a mpls nexthop label forwarding entry

[PATCH net-next v2 2/2] mpls: flow-based multipath selection

2015-10-06 Thread Roopa Prabhu
From: Robert Shearman Change the selection of a multipath route to use a flow-based hash. This more suitable for traffic sensitive to reordering within a flow (e.g. TCP, L2VPN) and whilst still allowing a good distribution of traffic given enough flows. Selection of the

[PATCH net-next] iproute2: document -timestamp option

2015-10-06 Thread Roopa Prabhu
From: Satish Ashok This patch documents bridge and ip -timestamp option Signed-off-by: Satish Ashok --- man/man8/bridge.8 | 3 +++ man/man8/ip.8 | 4 2 files changed, 7 insertions(+) diff --git a/man/man8/bridge.8

[PATCH net-next] ipv6: fix multipath route replace error recovery

2015-09-01 Thread Roopa Prabhu
From: Roopa Prabhu <ro...@cumulusnetworks.com> Problem: The ecmp route replace support for ipv6 in the kernel, deletes the existing ecmp route too early, ie when it installs the first nexthop. If there is an error in installing the subsequent nexthops, its too late to recover the already d

[PATCH net v3] ipv6: fix multipath route replace error recovery

2015-09-06 Thread Roopa Prabhu
From: Roopa Prabhu <ro...@cumulusnetworks.com> Problem: The ecmp route replace support for ipv6 in the kernel, deletes the existing ecmp route too early, ie when it installs the first nexthop. If there is an error in installing the subsequent nexthops, its too late to recover the already d

[PATCH net-next v2] ipv6: fix multipath route replace error recovery

2015-09-02 Thread Roopa Prabhu
From: Roopa Prabhu <ro...@cumulusnetworks.com> Problem: The ecmp route replace support for ipv6 in the kernel, deletes the existing ecmp route too early, ie when it installs the first nexthop. If there is an error in installing the subsequent nexthops, its too late to recover the already d

[PATCH net v4] ipv6: fix multipath route replace error recovery

2015-09-08 Thread Roopa Prabhu
From: Roopa Prabhu <ro...@cumulusnetworks.com> Problem: The ecmp route replace support for ipv6 in the kernel, deletes the existing ecmp route too early, ie when it installs the first nexthop. If there is an error in installing the subsequent nexthops, its too late to recover the already d

[PATCH net] ipv6: include NLM_F_REPLACE in route replace notifications

2015-09-13 Thread Roopa Prabhu
From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch adds NLM_F_REPLACE flag to ipv6 route replace notifications. This makes nlm_flags in ipv6 replace notifications consistent with ipv4. Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> --- Submitting this to net since it

[PATCH net v2] rtnetlink: catch -EOPNOTSUPP errors from ndo_bridge_getlink

2015-09-15 Thread Roopa Prabhu
From: Roopa Prabhu <ro...@cumulusnetworks.com> problem reported: kernel 4.1.3 # bridge vlan portvlan ids eth0 1 PVID Egress Untagged 90 91 92 93

[PATCH net] rtnetlink: catch -EOPNOTSUPP errors from ndo_bridge_getlink

2015-09-15 Thread Roopa Prabhu
From: Roopa Prabhu <ro...@cumulusnetworks.com> problem reported: kernel 4.1.3 # bridge vlan portvlan ids eth0 1 PVID Egress Untagged 90 91 92 93

[PATCH net-next] rtnl_fdb_dump: catch errors from ndo_fdb_dump and ndo_dflt_fdb_dump

2015-09-23 Thread Roopa Prabhu
return the status and pass the idx by reference for update. The dump aborts if non-zero status is returned. Signed-off-by: Wilson Kok <w...@cumulusnetworks.com> Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 6 +++--- d

[PATCH net] fib_rules: fix fib rule dumps across multiple skbs

2015-09-22 Thread Roopa Prabhu
Wilson Kok <w...@cumulusnetworks.com> Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> --- net/core/fib_rules.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/net/core/fib_rules.c b/net/core/fib_rules.c index bf77e36..365de66 100644 --- a/net/core

[PATCH net-next v2] bridge: allow adding of fdb entries pointing to the bridge device

2015-10-06 Thread Roopa Prabhu
From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch enables adding of fdb entries pointing to the bridge device. This can be used to propagate mac address of vlan interfaces configured on top of the vlan filtering bridge. Before: $bridge fdb add 44:38:39:00:27:9f dev bridge RTN

[PATCH net-next] mpls_iptunnel: add static qualifier to mpls_output

2015-12-09 Thread Roopa Prabhu
From: Roopa Prabhu <ro...@cumulusnetworks.com> This gets rid of the following compile warn: net/mpls/mpls_iptunnel.c:40:5: warning: no previous prototype for mpls_output [-Wmissing-prototypes] Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> --- net/mpls/mpls_iptunnel.c |

[PATCH net-next v7] mpls: support for dead routes

2015-12-01 Thread Roopa Prabhu
From: Roopa Prabhu <ro...@cumulusnetworks.com> Adds support for RTNH_F_DEAD and RTNH_F_LINKDOWN flags on mpls routes due to link events. Also adds code to ignore dead routes during route selection. Unlike ip routes, mpls routes are not deleted when the route goes dead. This is curren

[PATCH net-next v5] mpls: support for dead routes

2015-11-24 Thread Roopa Prabhu
From: Roopa Prabhu <ro...@cumulusnetworks.com> Adds support for RTNH_F_DEAD and RTNH_F_LINKDOWN flags on mpls routes due to link events. Also adds code to ignore dead routes during route selection. Unlike ip routes, mpls routes are not deleted when the route goes dead. This is curren

[PATCH net-next v6] mpls: support for dead routes

2015-11-28 Thread Roopa Prabhu
From: Roopa Prabhu <ro...@cumulusnetworks.com> Adds support for RTNH_F_DEAD and RTNH_F_LINKDOWN flags on mpls routes due to link events. Also adds code to ignore dead routes during route selection. Unlike ip routes, mpls routes are not deleted when the route goes dead. This is curren

[PATCH net-next v4] mpls: support for dead routes

2015-11-20 Thread Roopa Prabhu
From: Roopa Prabhu <ro...@cumulusnetworks.com> Adds support for RTNH_F_DEAD and RTNH_F_LINKDOWN flags on mpls routes due to link events. Also adds code to ignore dead routes during route selection. Unlike ip routes, mpls routes are not deleted when the route goes dead. This is curren

[PATCH iproute2 net-next 1/5] json_writer: allow base json data type to be array or object

2016-05-27 Thread Roopa Prabhu
From: Anuradha Karuppiah This patch adds a type qualifier to json_writer. Type can be a json object or array. This can be extended to other types like json-string, json-number etc in the future. Signed-off-by: Anuradha Karuppiah ---

[PATCH iproute2 net-next 2/5] bridge: add json support for bridge vlan show

2016-05-27 Thread Roopa Prabhu
From: Roopa Prabhu <ro...@cumulusnetworks.com> $bridge -c vlan show portvlan ids swp1 1 PVID Egress Untagged 10-13 swp2 1 PVID Egress Untagged 10-13 br0 1 PVID Egress Untagged $bridge -j vlan show { "swp1": [{ "vlan&qu

[PATCH iproute2 net-next 5/5] bridge: update man page

2016-05-27 Thread Roopa Prabhu
From: Roopa Prabhu <ro...@cumulusnetworks.com> Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> --- man/man8/bridge.8 | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/man/man8/bridge.8 b/man/man8/bridge.8 index 08e8a5b..abaee63 100644 --- a/man/m

[PATCH iproute2 net-next 3/5] bridge: add json support for bridge fdb show

2016-05-27 Thread Roopa Prabhu
},{ "mac": "44:38:39:00:69:89", "dev": "swp2s1", "vlan": 2, "master": "br0", "state": "permanent" },{ "mac": "44:38:39:00:69:88",

[PATCH iproute2 net-next 4/5] bridge: add json schema for bridge fdb show

2016-05-27 Thread Roopa Prabhu
From: Anuradha Karuppiah we think storing the schema file for the json format will be useful. Signed-off-by: Anuradha Karuppiah --- schema/bridge_fdb_schema.json | 62 +++ 1 file changed, 62

[PATCH iproute2 net-next 0/5] bridge: json support for fdb and vlan show

2016-05-27 Thread Roopa Prabhu
From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch series adds json support for a few bridge show commands. We plan to follow up with json support for additional commands soon. Anuradha Karuppiah (3): json_writer: allow base json data type to be array or object bridge: ad

[PATCH iproute2 net-next v2 3/5] bridge: add json support for bridge fdb show

2016-05-30 Thread Roopa Prabhu
},{ "mac": "44:38:39:00:69:89", "dev": "swp2s1", "vlan": 2, "master": "br0", "state": "permanent" },{ "mac": "44:38:39:00:69:88",

[PATCH iproute2 net-next v2 1/5] json_writer: allow base json data type to be array or object

2016-05-30 Thread Roopa Prabhu
From: Anuradha Karuppiah This patch adds a type qualifier to json_writer. Type can be a json object or array. This can be extended to other types like json-string, json-number etc in the future. Signed-off-by: Anuradha Karuppiah ---

[PATCH iproute2 net-next v2 4/5] bridge: add json schema for bridge fdb show

2016-05-30 Thread Roopa Prabhu
From: Anuradha Karuppiah we think storing the schema file for the json format will be useful. Signed-off-by: Anuradha Karuppiah --- schema/bridge_fdb_schema.json | 62 +++ 1 file changed, 62

[PATCH iproute2 net-next v2 0/5] bridge: json support for fdb and vlan show

2016-05-30 Thread Roopa Prabhu
From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch series adds json support for a few bridge show commands. We plan to follow up with json support for additional commands soon. Anuradha Karuppiah (3): json_writer: allow base json data type to be array or object bridge: ad

[PATCH iproute2 net-next v2 2/5] bridge: add json support for bridge vlan show

2016-05-30 Thread Roopa Prabhu
From: Roopa Prabhu <ro...@cumulusnetworks.com> $bridge -c vlan show portvlan ids swp1 1 PVID Egress Untagged 10-13 swp2 1 PVID Egress Untagged 10-13 br0 1 PVID Egress Untagged $bridge -json vlan show { "swp1": [{ "vlan&qu

[PATCH iproute2 net-next v2 5/5] bridge: update man page

2016-05-30 Thread Roopa Prabhu
From: Roopa Prabhu <ro...@cumulusnetworks.com> Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> --- man/man8/bridge.8 | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/man/man8/bridge.8 b/man/man8/bridge.8 index 08e8a5b..abaee63 100644 --- a/man/m

Re: [PATCH iproute2 net-next 2/5] bridge: add json support for bridge vlan show

2016-05-30 Thread Roopa Prabhu
On 5/29/16, 5:43 PM, Toshiaki Makita wrote: > On 2016/05/28 13:37, Roopa Prabhu wrote: >> From: Roopa Prabhu <ro...@cumulusnetworks.com> >> >> $bridge -c vlan show >> port vlan ids >> swp1 1 PVID Egress Untagged >> 10-13 >> >> swp2

[PATCH iproute2 net-next v4 3/5] bridge: add json support for bridge fdb show

2016-06-22 Thread Roopa Prabhu
ot; },{ "mac": "44:38:39:00:69:89", "dev": "swp2s1", "vlan": 2, "master": "br0", "state": "permanent" },{ "mac": "44:38:39:00:69:88",

  1   2   3   4   5   6   7   >