Re: [PATCH net-next 4/8] net/mlx5e: Consider IRQ affinity changes in NAPI poll

Hi Dave, We agree with you, we will drop this patch for now and will think of a cleaner approach to fix this in the future. > From: David Miller [mailto:da...@davemloft.net] > Sent: Monday, November 02, 2015 12:34 AM > To: Or Gerlitz <ogerl...@mellanox.com> > Cc: netdev@vger

Re: [PATCH net-next 0/2] mlx5 minor SRIOV fixes

On Wed, Dec 9, 2015 at 4:41 AM, David Miller wrote: > > Don't do this, submitting two disconnected patch series for the same > driver (mlx5), for the same tree (net-next). > for next time ? or you want me to re-submit those two patch sets ? > Just submit them all in one

[PATCH net-next 3/7] net/mlx5_core: Add flow steering lookup algorithms

e flow table of some priority Signed-off-by: Maor Gottlieb <ma...@mellanox.com> Signed-off-by: Moni Shoua <mo...@mellanox.com> Signed-off-by: Matan Barak <mat...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mella

[PATCH net-next 1/7] net/mlx5_core: Introduce flow steering firmware commands

t;mat...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/Makefile |2 +- drivers/net/ethernet/mellanox/mlx5/core/fs_cmd.c | 239 + drivers/net/ethernet/mellanox/mlx5/core/fs_cmd.h | 65 ++ driv

[PATCH net-next 2/7] net/mlx5_core: Add flow steering base data structures

types will be used and explained once the usage is added in the following patches. Signed-off-by: Maor Gottlieb <ma...@mellanox.com> Signed-off-by: Moni Shoua <mo...@mellanox.com> Signed-off-by: Matan Barak <mat...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com

[PATCH net-next 4/7] net/mlx5_core: Introduce flow steering API

ma...@mellanox.com> Signed-off-by: Moni Shoua <mo...@mellanox.com> Signed-off-by: Matan Barak <mat...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 464 + drivers/net/ethernet/mellanox

[PATCH net-next 0/7] mlx5 improved flow steering management

Hi Dave, This patch series modifies the driver's code that manages flow steering rules with Connectx-4 devices. Basic introduction: The flow steering device specification model is composed of the following entities: Destination (either a TIR/Flow table/vport), where TIR is RSS end-point,

[PATCH net-next 7/7] net/mlx5e: Rename en_flow_table.c to en_fs.c

lanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/Makefile |2 +- .../ethernet/mellanox/mlx5/core/en_flow_table.c| 1224 drivers/net/ethernet/mellanox/mlx5/core/en_fs.c| 1224 3

[PATCH net-next 5/7] net/mlx5_core: Flow steering tree initialization

off-by: Moni Shoua <mo...@mellanox.com> Signed-off-by: Matan Barak <mat...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 366 + drivers/net/ethernet/mellanox/mlx5/core/fs_core.h |4

[PATCH net-next 6/7] net/mlx5: Use flow steering infrastructure for mlx5_en

m> Signed-off-by: Moni Shoua <mo...@mellanox.com> Signed-off-by: Matan Barak <mat...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/Makefile |2 +- drivers/net/ethernet/mellanox/mlx5/core/en.h | 23

[PATCH net-next 1/2] net/mlx5: Fix query E-Switch capabilities

E-Switch capabilities should be queried only if E-Switch flow table is supported and not only when vport group manager. Fixes: d753c6e8 ("net/mlx5: E-Switch, Introduce HCA cap and E-Switch vport context") Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/e

[PATCH net-next 0/2] mlx5 minor SRIOV fixes

Hi Dave, This short series fixes some minor issues in recently introduced SRIOV code. Saeed. Saeed Mahameed (2): net/mlx5: Fix query E-Switch capabilities net/mlx5e: Assign random MAC address if needed drivers/net/ethernet/mellanox/mlx5/core/en_main.c |5 + drivers/net/ethernet

[PATCH net-next 2/2] net/mlx5e: Assign random MAC address if needed

Under SRIOV there might be a case where VFs are loaded without pre-assigned MAC address. In this case, the VF will randomize its own MAC. This will address the case of administrator not assigning MAC to the VF through the PF OS APIs and keep udev happy. Signed-off-by: Saeed Mahameed <

[PATCH net-next 2/2] net/mlx5_en: Add HW timestamping (TS) support

ge.net/) on a Mellanox ConnectX-4 card. Signed-off-by: Eran Ben Elisha <era...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/Kconfig|1 + drivers/net/ethernet/mellanox/mlx5/core/Makefile |2 +- drivers/net/ethe

[PATCH net-next 0/2] Introduce mlx5 ethernet timestamping

Hi Dave, This patch series introduces the support for ConnectX-4 timestamping and the PTP kernel interface. First patch fixes a bug in SKB data pointer in device xmit function. Second patch adds the needed low level helpers for: - Fetching the hardware clock (hardware internal timer)

[PATCH net-next 1/2] net/mlx5_en: Restore the skb data pointer after xmit is finished

era...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_tx.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tx.c b/drivers/net/ethernet/mellanox/mlx

[PATCH net-next V1 7/9] net/mlx5_core: Flow steering tree initialization

off-by: Moni Shoua <mo...@mellanox.com> Signed-off-by: Matan Barak <mat...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 374 + drivers/net/ethernet/mellanox/mlx5/core/fs_core.h |4

[PATCH net-next V1 6/9] net/mlx5_core: Introduce flow steering API

ma...@mellanox.com> Signed-off-by: Moni Shoua <mo...@mellanox.com> Signed-off-by: Matan Barak <mat...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 464 + drivers/net/ethernet/mellanox

[PATCH net-next V1 0/9] mlx5 improved flow steering management

lx5_core: Introduce flow steering API net/mlx5_core: Flow steering tree initialization net/mlx5: Use flow steering infrastructure for mlx5_en net/mlx5e: Rename en_flow_table.c to en_fs.c Saeed Mahameed (2): net/mlx5: Fix query E-Switch capabilities net/mlx5e: Assign random MAC address if neede

[PATCH net-next V1 9/9] net/mlx5e: Rename en_flow_table.c to en_fs.c

lanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/Makefile |2 +- .../ethernet/mellanox/mlx5/core/en_flow_table.c| 1224 drivers/net/ethernet/mellanox/mlx5/core/en_fs.c| 1224 3

[PATCH net-next V1 4/9] net/mlx5_core: Add flow steering base data structures

types will be used and explained once the usage is added in the following patches. Signed-off-by: Maor Gottlieb <ma...@mellanox.com> Signed-off-by: Moni Shoua <mo...@mellanox.com> Signed-off-by: Matan Barak <mat...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com

[PATCH net-next V1 1/9] net/mlx5: Fix query E-Switch capabilities

E-Switch capabilities should be queried only if E-Switch flow table is supported and not only when vport group manager. Fixes: d753c6e8 ("net/mlx5: E-Switch, Introduce HCA cap and E-Switch vport context") Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/e

[PATCH net-next V1 8/9] net/mlx5: Use flow steering infrastructure for mlx5_en

m> Signed-off-by: Moni Shoua <mo...@mellanox.com> Signed-off-by: Matan Barak <mat...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/Makefile |2 +- drivers/net/ethernet/mellanox/mlx5/core/en.h | 23

[PATCH net-next V1 5/9] net/mlx5_core: Add flow steering lookup algorithms

e flow table of some priority Signed-off-by: Maor Gottlieb <ma...@mellanox.com> Signed-off-by: Moni Shoua <mo...@mellanox.com> Signed-off-by: Matan Barak <mat...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mella

[PATCH net-next V1 3/9] net/mlx5_core: Introduce flow steering firmware commands

t;mat...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/Makefile |2 +- drivers/net/ethernet/mellanox/mlx5/core/fs_cmd.c | 239 + drivers/net/ethernet/mellanox/mlx5/core/fs_cmd.h | 65 ++ driv

[PATCH net-next V1 2/9] net/mlx5e: Assign random MAC address if needed

Under SRIOV there might be a case where VFs are loaded without pre-assigned MAC address. In this case, the VF will randomize its own MAC. This will address the case of administrator not assigning MAC to the VF through the PF OS APIs and keep udev happy. Signed-off-by: Saeed Mahameed <

Re: [PATCH net-next V3 0/4] Introduce mlx5 ethernet timestamping

Hi Dave, Any chance you are giving this a shot ? On Tue, Dec 29, 2015 at 2:58 PM, Saeed Mahameed <sae...@mellanox.com> wrote: > Hi Dave, > > This patch series introduces the support for ConnectX-4 timestamping > and the PTP kernel interface. > > Changes from V2: > net/

Re: [PATCH net-next V3 0/4] Introduce mlx5 ethernet timestamping

Sorry my mistake, please ignore my last email, just got your response on the matter, On Mon, Jan 4, 2016 at 11:57 PM, Saeed Mahameed <sae...@dev.mellanox.co.il> wrote: > Hi Dave, > > Any chance you are giving this a shot ? > > On Tue, Dec 29, 2015 at 2:58 PM, Saeed Mahameed

Re: [PATCH net-next V3 0/4] Introduce mlx5 ethernet timestamping

Thank you David and Richard. On Tue, Jan 5, 2016 at 9:12 PM, David Miller <da...@davemloft.net> wrote: > From: Saeed Mahameed <sae...@mellanox.com> > Date: Tue, 29 Dec 2015 14:58:28 +0200 > >> This patch series introduces the support for ConnectX-4 timestamping >

[PATCH net-next 03/12] net/mlx5_core: Managing root flow table

table. Signed-off-by: Maor Gottlieb <ma...@mellanox.com> Signed-off-by: Moni Shoua <mo...@mellanox.com> Signed-off-by: Matan Barak <mat...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/fs_cmd.c | 18 driv

[PATCH net-next 05/12] net/mlx5_core: Connect flow tables

lanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/fs_cmd.c |7 +- drivers/net/ethernet/mellanox/mlx5/core/fs_cmd.h |3 +- drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 104 +++-- 3 files changed, 104 insert

[PATCH net-next 02/12] net/mlx5_core: Add utilities to find next and prev flow-tables

e tree. These utility functions are used for chaining flow table from different priorities. Signed-off-by: Maor Gottlieb <ma...@mellanox.com> Signed-off-by: Moni Shoua <mo...@mellanox.com> Signed-off-by: Matan Barak <mat...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...

[PATCH net-next 00/12] net/mlx5_core: Enhance flow steering support

Hi Dave, This series adds three new functionalists to the driver flow-steering infrastructure: auto-grouped flow tables, chaining of flow tables and updates for the root flow table. 1. Auto-grouped flow tables - Flow table with auto grouping management. When a flow table is created, hints

[PATCH net-next 12/12] IB/mlx5: Add flow steering support

ni Shoua <mo...@mellanox.com> Signed-off-by: Matan Barak <mat...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/infiniband/hw/mlx5/main.c| 285 ++ drivers/infiniband/hw/mlx5/mlx5_ib.h | 45 +- 2 files

[PATCH net-next 11/12] IB/mlx5: Add flow steering utilities

eaders in flow match criteria to zeros. Signed-off-by: Maor Gottlieb <ma...@mellanox.com> Signed-off-by: Moni Shoua <mo...@mellanox.com> Signed-off-by: Matan Barak <mat...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/in

[PATCH net-next 04/12] net/mlx5_core: Introduce modify flow table command

in any of the flow table entries in the current flow table. Signed-off-by: Maor Gottlieb <ma...@mellanox.com> Signed-off-by: Moni Shoua <mo...@mellanox.com> Signed-off-by: Matan Barak <mat...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethern

[PATCH net-next 09/12] net/mlx5_core: Make ipv4/ipv6 location more clear

: Matan Barak <mat...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- include/linux/mlx5/mlx5_ifc.h | 20 ++-- 1 files changed, 18 insertions(+), 2 deletions(-) diff --git a/include/linux/mlx5/mlx5_ifc.h b/include/linux/mlx5/mlx5_ifc.h index 7f16695..68d7

[PATCH net-next 01/12] net/mlx5_core: Introduce flow steering autogrouped flow table

table into required_groups + 1, in order to reserve a part of the flow table for rules which don't match any existing group. Signed-off-by: Maor Gottlieb <ma...@mellanox.com> Signed-off-by: Moni Shoua <mo...@mellanox.com> Signed-off-by: Matan Barak <mat...@mellanox.com> Signed-off

[PATCH net-next 10/12] net/mlx5_core: Export flow steering API

delete flow rule from its flow table. 5. mlx5_get_flow_namespace - used to get a handle to the required namespace sub-tree. Signed-off-by: Maor Gottlieb <ma...@mellanox.com> Signed-off-by: Moni Shoua <mo...@mellanox.com> Signed-off-by: Matan Barak <mat...@mellanox.com> Signed-off

[PATCH net-next 06/12] net/mlx5_core: Set priority attributes

; Signed-off-by: Moni Shoua <mo...@mellanox.com> Signed-off-by: Matan Barak <mat...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 71 +++-- drivers/net/ethernet/mellanox/mlx5/core/fs_core.h

[PATCH net-next 08/12] net/mlx5_core: Enable flow steering support for the IB driver

by any preceding rules. Signed-off-by: Maor Gottlieb <ma...@mellanox.com> Signed-off-by: Moni Shoua <mo...@mellanox.com> Signed-off-by: Matan Barak <mat...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mella

[PATCH net-next 07/12] net/mlx5_core: Initialize namespaces only when supported by device

ni Shoua <mo...@mellanox.com> Signed-off-by: Matan Barak <mat...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 70 ++-- 1 files changed, 49 insertions(+), 21 deletions(-) diff --git a/driv

[PATCH net-next V1 00/12] net/mlx5_core: Enhance flow steering support

Hi Dave, This series adds three new functionalists to the driver flow-steering infrastructure: auto-grouped flow tables, chaining of flow tables and updates for the root flow table. Changes since V0: - Fixed improperly formatted comments. - Compare value of

[PATCH net-next V1 03/12] net/mlx5_core: Managing root flow table

table. Signed-off-by: Maor Gottlieb <ma...@mellanox.com> Signed-off-by: Moni Shoua <mo...@mellanox.com> Signed-off-by: Matan Barak <mat...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/fs_cmd.c | 18 driv

[PATCH net-next V1 07/12] net/mlx5_core: Initialize namespaces only when supported by device

ni Shoua <mo...@mellanox.com> Signed-off-by: Matan Barak <mat...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 70 ++-- 1 files changed, 49 insertions(+), 21 deletions(-) diff --git a/driv

[PATCH net-next V1 01/12] net/mlx5_core: Introduce flow steering autogrouped flow table

table into required_groups + 1, in order to reserve a part of the flow table for rules which don't match any existing group. Signed-off-by: Maor Gottlieb <ma...@mellanox.com> Signed-off-by: Moni Shoua <mo...@mellanox.com> Signed-off-by: Matan Barak <mat...@mellanox.com> Signed-off

[PATCH net-next V1 02/12] net/mlx5_core: Add utilities to find next and prev flow-tables

e tree. These utility functions are used for chaining flow table from different priorities. Signed-off-by: Maor Gottlieb <ma...@mellanox.com> Signed-off-by: Moni Shoua <mo...@mellanox.com> Signed-off-by: Matan Barak <mat...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...

[PATCH net-next V1 08/12] net/mlx5_core: Enable flow steering support for the IB driver

by any preceding rules. Signed-off-by: Maor Gottlieb <ma...@mellanox.com> Signed-off-by: Moni Shoua <mo...@mellanox.com> Signed-off-by: Matan Barak <mat...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mella

[PATCH net-next V1 11/12] IB/mlx5: Add flow steering utilities

eaders in flow match criteria to zeros. Signed-off-by: Maor Gottlieb <ma...@mellanox.com> Signed-off-by: Moni Shoua <mo...@mellanox.com> Signed-off-by: Matan Barak <mat...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/in

[PATCH net-next V1 09/12] net/mlx5_core: Make ipv4/ipv6 location more clear

: Matan Barak <mat...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- include/linux/mlx5/mlx5_ifc.h | 20 ++-- 1 files changed, 18 insertions(+), 2 deletions(-) diff --git a/include/linux/mlx5/mlx5_ifc.h b/include/linux/mlx5/mlx5_ifc.h index 7f16695..68d7

[PATCH net-next V1 04/12] net/mlx5_core: Introduce modify flow table command

in any of the flow table entries in the current flow table. Signed-off-by: Maor Gottlieb <ma...@mellanox.com> Signed-off-by: Moni Shoua <mo...@mellanox.com> Signed-off-by: Matan Barak <mat...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethern

[PATCH net-next V1 06/12] net/mlx5_core: Set priority attributes

; Signed-off-by: Moni Shoua <mo...@mellanox.com> Signed-off-by: Matan Barak <mat...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 71 +++-- drivers/net/ethernet/mellanox/mlx5/core/fs_core.h

[PATCH net-next V1 12/12] IB/mlx5: Add flow steering support

ni Shoua <mo...@mellanox.com> Signed-off-by: Matan Barak <mat...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/infiniband/hw/mlx5/main.c| 285 ++ drivers/infiniband/hw/mlx5/mlx5_ib.h | 45 +- 2 files

[PATCH net-next V1 05/12] net/mlx5_core: Connect flow tables

lanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/fs_cmd.c |7 +- drivers/net/ethernet/mellanox/mlx5/core/fs_cmd.h |3 +- drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 104 +++-- 3 files changed, 104 insert

[PATCH net-next V1 10/12] net/mlx5_core: Export flow steering API

delete flow rule from its flow table. 5. mlx5_get_flow_namespace - used to get a handle to the required namespace sub-tree. Signed-off-by: Maor Gottlieb <ma...@mellanox.com> Signed-off-by: Moni Shoua <mo...@mellanox.com> Signed-off-by: Matan Barak <mat...@mellanox.com> Signed-off

[PATCH net-next V2 3/4] net/mlx5e: Add HW timestamping (TS) support

Elisha <era...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/Makefile |2 +- drivers/net/ethernet/mellanox/mlx5/core/en.h | 19 +++ drivers/net/ethernet/mellanox/mlx5/core/en_clock.c | 134

[PATCH net-next V2 4/4] net/mlx5e: Add PTP Hardware Clock (PHC) support

<richardcoch...@gmail.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/Kconfig|1 + drivers/net/ethernet/mellanox/mlx5/core/en.h |3 + drivers/net/ethernet/mellanox/mlx5/core/en_clock.c | 104 .../net/eth

[PATCH net-next V2 2/4] net/mlx5_core: Add support for reading hardware timestamp

From: Eran Ben Elisha <era...@mellanox.com> A preparation step which adds support for reading the hardware timestamp from the internal clock and from the CQE. In addition, advertize device_frequency_khz HCA capability. Signed-off-by: Eran Ben Elisha <era...@mellanox.com> Signed-o

[PATCH net-next V2 1/4] net/mlx5e: Do not modify the TX SKB

From: Achiad Shochat <ach...@mellanox.com> If the SKB is cloned, or has an elevated users count, someone else can be looking at it at the same time. Signed-off-by: Achiad Shochat <ach...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethe

[PATCH net-next V2 0/4] Introduce mlx5 ethernet timestamping

Hi Dave, This patch series introduces the support for ConnectX-4 timestamping and the PTP kernel interface. This version addresses all the comments received on v1. The first patch was replaced with a one that addresses the SKB data issue and fixes it in the right way (By Achiad), Also Addressed

Re: [PATCH net-next V1 4/4] net/mlx5e: Add PTP Hardware Clock (PHC) support

On Thu, Dec 17, 2015 at 10:20 PM, Richard Cochran <richardcoch...@gmail.com> wrote: > On Thu, Dec 17, 2015 at 02:35:35PM +0200, Saeed Mahameed wrote: >> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c >> b/drivers/net/ethernet/mellanox/mlx5/core/en_ethto

Re: [PATCH net-next V1 1/4] net/mlx5e: Restore the skb data pointer after xmit is finished

On Thu, Dec 17, 2015 at 10:21 PM, David Miller <da...@davemloft.net> wrote: > From: Saeed Mahameed <sae...@mellanox.com> > Date: Thu, 17 Dec 2015 14:35:32 +0200 > >> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tx.c >> b/drivers/net/ethernet/mellanox/m

Re: [PATCH net-next V1 3/4] net/mlx5e: Add HW timestamping (TS) support

On Thu, Dec 17, 2015 at 10:11 PM, Richard Cochran <richardcoch...@gmail.com> wrote: > On Thu, Dec 17, 2015 at 02:35:34PM +0200, Saeed Mahameed wrote: >> @@ -63,6 +65,7 @@ >> #define MLX5E_TX_CQ_POLL_BUDGET128 >> #define MLX5E_UPDATE_STATS_INTERVAL

Re: [PATCH net-next V2 3/4] net/mlx5e: Add HW timestamping (TS) support

On Mon, Dec 21, 2015 at 11:15 AM, Richard Cochran <richardcoch...@gmail.com> wrote: > On Sun, Dec 20, 2015 at 11:46:30PM +0200, Saeed Mahameed wrote: >> +/* Should run once every mlx5e_tstamp->overflow_period */ >> +static void mlx5e_timestamp_overflow(

Re: [PATCH net-next V2 3/4] net/mlx5e: Add HW timestamping (TS) support

On Mon, Dec 21, 2015 at 8:35 PM, Richard Cochran <richardcoch...@gmail.com> wrote: > On Mon, Dec 21, 2015 at 04:35:23PM +0200, Saeed Mahameed wrote: >> think of a case where: >> CPU1: is just about to call >> "schedule_delayed_work(>overflow_work, &g

Re: [PATCH net-next V2 3/4] net/mlx5e: Add HW timestamping (TS) support

On Mon, Dec 21, 2015 at 11:15 AM, Richard Cochran <richardcoch...@gmail.com> wrote: > On Sun, Dec 20, 2015 at 11:46:30PM +0200, Saeed Mahameed wrote: >> +/* Should run once every mlx5e_tstamp->overflow_period */ >> +static void mlx5e_timestamp_overflow(

[PATCH net-next V1 4/4] net/mlx5e: Add PTP Hardware Clock (PHC) support

<richardcoch...@gmail.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/Kconfig|1 + drivers/net/ethernet/mellanox/mlx5/core/en.h |4 + drivers/net/ethernet/mellanox/mlx5/core/en_clock.c | 107 .../net/eth

[PATCH net-next V1 2/4] net/mlx5_core: Add support for reading hardware timestamp

From: Eran Ben Elisha <era...@mellanox.com> A preparation step which adds support for reading the hardware timestamp from the internal clock and from the CQE. In addition, advertize device_frequency_khz HCA capability. Signed-off-by: Eran Ben Elisha <era...@mellanox.com> Signed-o

[PATCH net-next V1 0/4] Introduce mlx5 ethernet timestamping

Hi Dave, This patch series introduces the support for ConnectX-4 timestamping and the PTP kernel interface. This version addresses all the comments received on v0 and breaks the original series to four patches. First patch fixes a bug in SKB data pointer in device xmit function. Second patch

[PATCH net-next V1 1/4] net/mlx5e: Restore the skb data pointer after xmit is finished

era...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_tx.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tx.c b/drivers/net/ethernet/mellanox/mlx

[PATCH net-next V1 3/4] net/mlx5e: Add HW timestamping (TS) support

Elisha <era...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/Makefile |2 +- drivers/net/ethernet/mellanox/mlx5/core/en.h | 21 drivers/net/ethernet/mellanox/mlx5/core/en_clock.c | 119 +++

[PATCH net-next V3 3/4] net/mlx5e: Add HW timestamping (TS) support

Elisha <era...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/Makefile |2 +- drivers/net/ethernet/mellanox/mlx5/core/en.h | 23 +++ drivers/net/ethernet/mellanox/mlx5/core/en_clock.c | 187

[PATCH net-next V3 1/4] net/mlx5e: Do not modify the TX SKB

From: Achiad Shochat <ach...@mellanox.com> If the SKB is cloned, or has an elevated users count, someone else can be looking at it at the same time. Signed-off-by: Achiad Shochat <ach...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethe

[PATCH net-next V3 4/4] net/mlx5e: Add PTP Hardware Clock (PHC) support

<richardcoch...@gmail.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/Kconfig|1 + drivers/net/ethernet/mellanox/mlx5/core/en.h |3 + drivers/net/ethernet/mellanox/mlx5/core/en_clock.c | 100 .../net/eth

[PATCH net-next V3 0/4] Introduce mlx5 ethernet timestamping

Hi Dave, This patch series introduces the support for ConnectX-4 timestamping and the PTP kernel interface. Changes from V2: net/mlx5_core: Introduce access function to read internal_timer - Remove one line function - Change function name net/mlx5e: Add HW timestamping (TS)

[PATCH net-next V3 2/4] net/mlx5_core: Introduce access function to read internal timer

; Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/main.c | 13 + .../net/ethernet/mellanox/mlx5/core/mlx5_core.h|1 + include/linux/mlx5/device.h| 20 +--- include/lin

Re: [PATCH net-next 10/18] net/mlx5e: Write vlan list into vport context

On Mon, Nov 23, 2015 at 7:30 PM, Alexander Duyck <alexander.du...@gmail.com> wrote: > On 11/23/2015 03:11 AM, Or Gerlitz wrote: >> >> From: Saeed Mahameed <sae...@mellanox.com> >> >> Each Vport/vNIC must notify underlying e-Switch layer >> for vla

Re: [PATCH net-next 09/18] net/mlx5e: Write UC/MC list and promisc mode into vport context

On Mon, Nov 23, 2015 at 7:23 PM, Alexander Duyck <alexander.du...@gmail.com> wrote: > On 11/23/2015 03:11 AM, Or Gerlitz wrote: >> >> From: Saeed Mahameed <sae...@mellanox.com> >> >> Each Vport/vNIC must notify underlying e-Switch layer >> for

[PATCH net-next] nfnetlink_queue: enable PID info retrieval

tgoing connection in userspace, without the need to parse procfs. Signed-off-by: Matthew Finlay <m...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> CC: Pablo Neira Ayuso <pa...@netfilter.org> CC: Patrick McHardy <ka...@trash.net> CC: Jozsef Kadlecsik <kad..

[PATCH net 02/13] net/mlx5: Fix masking of reserved bits in XRCD number

From: Majd Dibbiny <m...@mellanox.com> Mask the reserved bits when reading the number of newly created XRCD. Fixes: e126ba97dba9 ('mlx5: Add driver for Mellanox Connect-IB adapters') Signed-off-by: Majd Dibbiny <m...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.co

[PATCH net 00/13] Mellanox 100G mlx5 fixes for 4.7-rc

Hi Dave, The following series provides some small fixes for mlx5 driver. Two small fixes for the mlx5e netdev, the 1st is for the blue flame quota accounting and the 2nd is a small refactoring in shutdown flow. Five trivial fixes for mlx5 E-Switch. - Allmulti mc_promisc flag was not

[PATCH net 04/13] net/mlx5: Fix root flow table update

494a6c ('net/mlx5_core: Managing root flow table') Signed-off-by: Maor Gottlieb <ma...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethe

[PATCH net 03/13] net/mlx5: Fix MLX5_CMD_OP_MAX to be defined correctly

Fixes: 34a40e689393 ('net/mlx5_core: Introduce modify flow table command') Signed-off-by: Shahar Klein <shah...@mellanox.com> Signed-off-by: Or Gerlitz <ogerl...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- include/linux/mlx5/device.h | 2 -- include/linux/mlx5/mlx

[PATCH net 06/13] net/mlx5: Fix E-Switch flow steering capabilities check

; Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 28 --- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c b/drivers/net/ethernet/mellanox/mlx5/co

[PATCH net 01/13] net/mlx5: Fix the size of modify QP mailbox

From: Majd Dibbiny <m...@mellanox.com> Add 16 reserved bytes at the end of mlx5_modify_qp_mbox_in to match the hardware spec definition. Fixes: e126ba97dba9 ('mlx5: Add driver for Mellanox Connect-IB adapters') Signed-off-by: Majd Dibbiny <m...@mellanox.com> Signed-off-by: Saeed M

[PATCH net 05/13] net/mlx5: Fix flow steering NIC capabilities check

of NIC RX flow tables. Fixes: 2530236303d9 ('net/mlx5_core: Flow steering tree initialization') Signed-off-by: Maor Gottlieb <ma...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 10 +- include/l

[PATCH net 13/13] net/mlx5e: Fix blue flame quota logic

lanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_tx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tx.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tx.c inde

[PATCH net 10/13] net/mlx5: E-Switch, Modify node guid on vf set MAC

d from it and set it as well in the following way: MAC: e4:1d:2d:b3:f4:01 -> node_guid: e4:1d:2d:ff:fe:b3:f4:01 Fixes: 77256579c6b43 ('net/mlx5: E-Switch, Introduce Vport...') Signed-off-by: Noa Osherovich <no...@mellanox.com> Signed-off-by: Majd Dibbiny <m...@mellanox.com> Signed-o

[PATCH net 09/13] net/mlx5: E-Switch, Fix vport enable flow

h, Use vport event handler for vport cleanup') Signed-off-by: Mohamad Haj Yahia <moha...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/eswitch.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/dr

[PATCH net 08/13] net/mlx5: E-Switch, Use the correct error check on returned pointers

') Signed-off-by: Or Gerlitz <ogerl...@mellanox.com> Reported-by: Ilya Lesokhin <il...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/eswitch.c | 34 +++ 1 file changed, 17 insertions(+), 17 deletio

[PATCH net 11/13] net/mlx5: E-Switch, always set mc_promisc for allmulti vports

lanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/eswitch.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c index 9b185

[PATCH net 12/13] net/mlx5e: Use ndo_stop explicitly at shutdown flow

From: Eran Ben Elisha <era...@mellanox.com> The current implementation copies the flow of ndo_stop instead of calling it explicitly, Fixed it. Fixes: 5fc7197d3a25 ("net/mlx5: Add pci shutdown callback") Signed-off-by: Eran Ben Elisha <era...@mellanox.com> Signed-off-b

[PATCH net 07/13] net/mlx5: E-Switch, Use the correct free() function

lx5_en') Signed-off-by: Or Gerlitz <ogerl...@mellanox.com> Reported-by: Ilya Lesokhin <il...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/eswitch.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --gi

Re: [PATCH 1/2] mlx5: only register devlink when ethernet is available

On Wed, Jun 15, 2016 at 6:27 PM, Arnd Bergmann wrote: > We get a build error with the mlx5 driver when the ethernet > support (CONFIG_MLX5_CORE_EN) is disabled: > > drivers/net/ethernet/mellanox/mlx5/core/main.c:1320:22: error: > 'mlx5_devlink_eswitch_mode_set' undeclared here

Re: [PATCH] net/mlx5: use mlx5_buf_alloc_node insteaf of mlx5_buf_alloc in mlx5_wq_ll_create

On Wed, Jun 22, 2016 at 11:06 AM, Wang Sheng-Hui wrote: > This patch introduces 2 changes: > * use mlx5_buf_alloc_node() insteaf of mlx5_buf_alloc() in insteaf => instead > mlx5_wq_ll_create > * Update the failure warn messages with _node postfix

[PATCH net-next 1/9] net/mlx5: Rate limit tables support

ported functions are mlx5_rl_add_rate and mlx5_rl_remove_rate. Number of different rates and their values are derived from HW capabilities. Signed-off-by: Yevgeny Petrilin <yevge...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/c

[PATCH net-next 0/9] Mellanox 100G mlx5e Ethernet extensions

Hi Dave, This series includes multiple features extensions for mlx5 Ethernet netdevice driver. Namely, TX Rate limiting, RX interrupt moderation, ethtool settings. TX Rate limiting: - ConnectX-4 rate limiting infrastructure - Set max rate NDO support RX interrupt moderation:

[PATCH net-next 7/9] net/mlx5e: Add 50G missing link mode to ethtool and mlx5 driver

From: Gal Pressman <g...@mellanox.com> Add ETHTOOL_LINK_MODE_5baseSR2_Full_BIT and MLX5E_50GBASE_SR2 bits. Signed-off-by: Gal Pressman <g...@mellanox.com> CC: Ben Hutchings <b...@kernel.org> CC: David Decotigny <de...@googlers.com> Signed-off-by: Saeed Maham

[PATCH net-next 6/9] net/mlx5e: Toggle link only after modifying port parameters

; Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_dcbnl.c | 9 + drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c | 7 +-- drivers/net/ethernet/mellanox/mlx5/core/port.c | 12 include

[PATCH net-next 4/9] net/mlx5e: CQE based moderation

@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Signed-off-by: Gal Pressman <g...@mellanox.com> Signed-off-by: Gil Rockah <g...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 20 +--- .../net/ethernet/mellanox/mlx5/core/en_ethtool.c | 5

  1   2   3   4   5   6   7   8   9   10   >