Re: [PATCH net-next v3 1/4] bpf, mlx5: fix mlx5e_create_rq taking reference on prog

pport") > Signed-off-by: Daniel Borkmann <dan...@iogearbox.net> Acked-by: Saeed Mahameed <sae...@mellanox.com>

[PATCH net-next 4/7] devlink: Add E-Switch inline mode control

From: Roi Dayan <r...@mellanox.com> Some HWs need the VF driver to put part of the packet headers on the TX descriptor so the e-switch can do proper matching and steering. The supported modes: none, link, network, transport. Signed-off-by: Roi Dayan <r...@mellanox.com> Signed-o

[PATCH net-next 2/7] net/mlx5e: Support HW (offloaded) and SW counters for SRIOV switchdev mode

we're in the switchdev mode, we return the uplink stats and SW stats if asked, otherwise as before. The uplink stats are implemented using the PPCNT 802_3 counters which are already being read/cached by the driver. Signed-off-by: Or Gerlitz <ogerl...@mellanox.com> Signed-off-by: Saeed M

[PATCH net-next 0/7] Mellanox 100G mlx5 SRIOV switchdev update

Hi Dave, This series from Roi and Or further enhances the new SRIOV switchdev mode. Roi's patches deal with allowing users to configure though devlink the level of inline headers that the VF should be setting in order for the eswitch HW to do proper matching. We also enforce that the matching

[PATCH net-next 6/7] net/mlx5: E-Switch, Add control for inline mode

Signed-off-by: Roi Dayan <r...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/eswitch.c | 1 + drivers/net/ethernet/mellanox/mlx5/core/eswitch.h | 4 + .../ethernet/mellanox/mlx5/core/eswitc

[PATCH net-next 5/7] net/mlx5: Enable to query min inline for a specific vport

From: Roi Dayan <r...@mellanox.com> Also move the inline capablities enum to a shared header vport.h Signed-off-by: Roi Dayan <r...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 6 -- drivers/net

[PATCH net-next 3/7] net/mlx5e: Support VF vport link state control for SRIOV switchdev mode

arrier accordingly. Signed-off-by: Or Gerlitz <ogerl...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 33 ++-- 1 file changed, 31 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethe

[PATCH net-next 7/7] net/mlx5e: Enforce min inline mode when offloading flows

From: Roi Dayan <r...@mellanox.com> A flow should be offloaded only if the matches are allowed according to min inline mode. Signed-off-by: Roi Dayan <r...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5

[PATCH net-next 1/7] net: Add net-device param to the get offloaded stats ndo

From: Or Gerlitz <ogerl...@mellanox.com> Some drivers would need to check few internal matters for that. To be used in downstream mlx5 commit. Signed-off-by: Or Gerlitz <ogerl...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellano

[PATCH net-next 7/8] net/mlx5: Add MPCNT register infrastructure

From: Gal Pressman <g...@mellanox.com> Add the needed infrastructure for future use of MPCNT register. Signed-off-by: Gal Pressman <g...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- include/linux/mlx5/device.h | 5 +++ include/linux/mlx5/driver.h

[PATCH net-next 2/8] net/mlx5: Port module event hardware structures

From: Huy Nguyen <h...@mellanox.com> Add hardware structures and constants definitions needed for module events support. Signed-off-by: Huy Nguyen <h...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Signed-off-by: Leon Romanovsky <leo...@mellanox.com>

[PATCH net-next 0/8] Mellanox 100G mlx5 update 2016-11-15

more flexible Saeed Mahameed (1): net/mlx5: Set driver version infrastructure drivers/net/ethernet/mellanox/mlx5/core/cmd.c | 145 ++--- .../net/ethernet/mellanox/mlx5/core/en_ethtool.c | 40 +- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 24 drivers

[PATCH net-next 8/8] net/mlx5e: Expose PCIe statistics to ethtool

From: Gal Pressman <g...@mellanox.com> This patch exposes two groups of PCIe counters: - Performance counters. - Timers and states counters. Queried with ethtool -S . Signed-off-by: Gal Pressman <g...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> ---

[PATCH net-next 1/8] net/mlx5: Make the command interface cache more flexible

<moha...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/cmd.c | 145 -- include/linux/mlx5/driver.h | 14 +-- 2 files changed, 76 insertions(+), 83 deletions(-) diff --git a/dr

[PATCH net-next 6/8] net/mlx5: Set driver version into firmware

From: Huy Nguyen <h...@mellanox.com> If driver_version capability bit is enabled, set driver version to firmware after the init HCA command, for display purposes. Example of driver version: "Linux,mlx5_core,3.0-1" Signed-off-by: Huy Nguyen <h...@mellanox.com> Signed-off-b

Re: [PATCH net 2/3] bpf, mlx5: fix various refcount/prog issues in mlx5e_xdp_set

On 11/14/2016 02:43 AM, Daniel Borkmann wrote: > There are multiple issues in mlx5e_xdp_set(): > > 1) prog can be NULL, so calling unconditionally into bpf_prog_add(prog, >priv->params.num_channels) can end badly. not correct, if prog is null we will never get to bpf_prog_add:

Re: [PATCH net 1/3] bpf, mlx5: fix mlx5e_create_rq taking reference on prog

On 11/14/2016 02:43 AM, Daniel Borkmann wrote: > In mlx5e_create_rq(), when creating a new queue, we call bpf_prog_add() but > without checking the return value. bpf_prog_add() can fail, so we really Didn't know this, thanks for noticing, I wonder why taking a reference for an object would

[PATCH for-next V2 03/15] net/mlx5: Ensure SRQ physical address structure endianness

From: Artemy Kovalyov <artem...@mellanox.com> SRQ physical address structure field should be in big-endian format. Signed-off-by: Artemy Kovalyov <artem...@mellanox.com> Signed-off-by: Leon Romanovsky <leo...@mellanox.com> Signed-off-by: Leon Romanovsky <l...@kernel.org&

[PATCH for-next V2 05/15] net/mlx5: Add ConnectX-5 PCIe 4.0 VF device ID

For the mlx5 driver to support ConnectX-5 PCIe 4.0 VFs, we add the device ID "0x101a" to mlx5_core_pci_table. Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Signed-off-by: Leon Romanovsky <l...@kernel.org> --- drivers/net/ethernet/mellanox/mlx5/core/main.c | 1 + 1 fil

[PATCH for-next V2 15/15] net/mlx5e: Add tc support for FWD rule with counter

From: Mark Bloch <ma...@mellanox.com> When creating a FWD rule using tc create also a HW counter for this rule. Signed-off-by: Mark Bloch <ma...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Signed-off-by: Leon Romanovsky <l...@kernel.org> --- drive

[PATCH for-next V2 07/15] net/mlx5: Introduce E-switch QoS management

From: Mohamad Haj Yahia <moha...@mellanox.com> Add TSAR to the eswitch which will act as the vports rate limiter. Create/Destroy TSAR on Enable/Dsiable SRIOV. Attach/Detach vport to eswitch TSAR on Enable/Disable vport. Signed-off-by: Mohamad Haj Yahia <moha...@mellanox.com> Signed-o

[PATCH for-next V2 09/15] net/mlx5: Don't unlock fte while still using it

nox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Signed-off-by: Leon Romanovsky <l...@kernel.org> --- drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/fs_core.

[PATCH for-next V2 13/15] net/mlx5: Add multi dest support

e core point of view, we now need to use a loop when allocating and deleting rules (e.g given to us a flow handler). Signed-off-by: Mark Bloch <ma...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Signed-off-by: Leon Romanovsky <l...@kernel.org> --- dri

[PATCH for-next V2 06/15] net/mlx5: Introduce TSAR manipulation firmware commands

tached to the TSAR is (optionally) assigned with a rate limit. TSAR will not allow scheduling for an agent exceeding its defined rate limit. In this patch we implement the API of manipulating the TSAR. Signed-off-by: Mohamad Haj Yahia <moha...@mellanox.com> Signed-off-by: Saeed Mahameed <sae.

[PATCH for-next V2 10/15] net/mlx5: Use fte status to decide on firmware command

d only to update it. Signed-off-by: Mark Bloch <ma...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Signed-off-by: Leon Romanovsky <l...@kernel.org> --- drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --gi

[PATCH for-next V2 12/15] net/mlx5: Group similer rules under the same fte

action of an existing fte, we must tell the firmware we are doing so. Signed-off-by: Mark Bloch <ma...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Signed-off-by: Leon Romanovsky <l...@kernel.org> --- drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 22 ++

[PATCH for-next V2 14/15] net/mlx5: Add option to add fwd rule with counter

From: Mark Bloch <ma...@mellanox.com> Currently the code supports only drop rules to possess counters, add that ability also for fwd rules. Signed-off-by: Mark Bloch <ma...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Signed-off-by: Leon Romanovsk

[PATCH for-next V2 04/15] net/mlx5: Fix length of async_event_mask

From: Eugenia Emantayev <euge...@mellanox.com> According to PRM async_event_mask have to be 64 bits long. Signed-off-by: Eugenia Emantayev <euge...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Signed-off-by: Leon Romanovsky <l...@kernel.org> -

[PATCH for-next V2 02/15] net/mlx5: Update struct mlx5_ifc_xrqc_bits

From: Artemy Kovalyov <artem...@mellanox.com> Update struct mlx5_ifc_xrqc_bits according to last specification Signed-off-by: Artemy Kovalyov <artem...@mellanox.com> Signed-off-by: Leon Romanovsky <l...@kernel.org> Signed-off-by: Saeed Mahameed <sae...@mellanox.com>

[PATCH for-next V2 01/15] IB/mlx5: Skip handling unknown events

Do not dispatch unknown mlx5 core events on mlx5_ib_event. Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Signed-off-by: Eugenia Emantayev <euge...@mellanox.com> Signed-off-by: Leon Romanovsky <l...@kernel.org> --- drivers/infiniband/hw/mlx5/main.c | 2 ++ 1 file cha

[PATCH for-next V2 00/15][PULL request] Mellanox mlx5 core driver updates 2016-10-25

and rdma subsystems. Updates and Fixes: >From Saeed Mahameed (2): - mlx5 IB: Skip handling unknown mlx5 events - Add ConnectX-5 PCIe 4.0 VF device ID >From Artemy Kovalyov (2): - Update struct mlx5_ifc_xrqc_bits - Ensure SRQ physical address structure endianness >From Eugenia Ema

[PATCH for-next V2 11/15] net/mlx5: Refactor find_flow_rule

From: Mark Bloch <ma...@mellanox.com> The way we compare between two dests will need to be used in other places in the future, so we factor out the comparison logic between two dests into a separate function. Signed-off-by: Mark Bloch <ma...@mellanox.com> Signed-off-by: Saeed M

[PATCH for-next V2 08/15] net/mlx5: Add SRIOV VF max rate configuration support

From: Mohamad Haj Yahia <moha...@mellanox.com> Implement the vf set rate ndo by modifying the TSAR vport rate limit. Signed-off-by: Mohamad Haj Yahia <moha...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Signed-off-by: Leon Romanovsky <l...@kernel.

Re: [PATCH net-next 2/2] net/mlx4_en: Refactor the XDP forwarding rings scheme

On Mon, Oct 31, 2016 at 1:11 AM, Saeed Mahameed <sae...@dev.mellanox.co.il> wrote: > On Mon, Oct 31, 2016 at 12:44 AM, Alexei Starovoitov > <alexei.starovoi...@gmail.com> wrote: >> On Sun, Oct 30, 2016 at 06:03:06PM +0200, Tariq Toukan wrote: >>> >>> Note

Re: [PATCH net-next 2/2] net/mlx4_en: Refactor the XDP forwarding rings scheme

On Mon, Oct 31, 2016 at 12:44 AM, Alexei Starovoitov wrote: > On Sun, Oct 30, 2016 at 06:03:06PM +0200, Tariq Toukan wrote: >> >> Note that the XDP TX rings are no longer shown in ethtool -S. > > ouch. Can you make it to show them as some large TX numbers instead? >

Re: [PATCH] net/mlx5: Simplify a test

On 11/01/2016 09:10 AM, Christophe JAILLET wrote: 'create_root_ns()' does not return an error pointer, so the test can be simplified to be more consistent. Signed-off-by: Christophe JAILLET <christophe.jail...@wanadoo.fr> Acked-by: Saeed Mahameed <sae...@mellanox.com>

Re: [PATCH net-next V2 1/3] net/mlx4_en: Add TX_XDP for CQ types

On 11/01/2016 01:36 PM, Tariq Toukan wrote: Support XDP CQ type, and refactor the CQ type enum. Rename the is_tx field to match the change. Signed-off-by: Tariq Toukan <tar...@mellanox.com> Reviewed-by: Saeed Mahameed <sae...@mellanox.com>

Re: [PATCH net-next V2 2/3] net/mlx4_en: Refactor the XDP forwarding rings scheme

-by: Tariq Toukan <tar...@mellanox.com> Reviewed-by: Saeed Mahameed <sae...@mellanox.com>

[PATCH] MAINTAINERS: Update MELLANOX MLX5 core VPI driver maintainers

Add myself as a maintainer for mlx5 core driver as well. Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 4012c2f..53964ad 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -8053,6 +8053,

Re: [PATCH net-next V2 3/3] net/mlx4_en: Add ethtool statistics for XDP cases

. In addition, all packets that are dropped/forwarded by XDP are no longer accounted in rx_packets/rx_bytes of the ring, so that they count traffic that is passed to the stack. Signed-off-by: Tariq Toukan <tar...@mellanox.com> Reviewed-by: Saeed Mahameed <sae...@mellanox.com>

[PATCH net 4/6] net/mlx5e: Handle matching on vlan priority for offloaded TC rules

From: Or Gerlitz <ogerl...@mellanox.com> We ignored the vlan priority in offloaded TC rules matching part, fix that. Fixes: 095b6cfd69ce ('net/mlx5e: Add TC vlan match parsing') Signed-off-by: Or Gerlitz <ogerl...@mellanox.com> Reported-by: Paul Blakey <pa...@mellanox.com> Si

[PATCH net 0/6] Mellanox 100G mlx5 fixes 2016-11-04

when prof_sel parameter is invalid Or Gerlitz (3): net/mlx5e: Disallow changing name-space for VF representors net/mlx5e: Handle matching on vlan priority for offloaded TC rules net/mlx5: E-Switch, Set the actions for offloaded rules properly Saeed Mahameed (2): net/mlx5e: Fix XDP error

[PATCH net 1/6] net/mlx5e: Fix XDP error path of mlx5e_open_channel()

ing it. In addition we now close the xdp_sq.cq as well. Fixes: b5503b994ed5 ("net/mlx5e: XDP TX forwarding support") Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Reported-by: Jesper Dangaard Brouer <bro...@redhat.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 5

[PATCH net 5/6] net/mlx5: E-Switch, Set the actions for offloaded rules properly

ed-off-by: Or Gerlitz <ogerl...@mellanox.com> Reported-by: Paul Blakey <pa...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/eth

[PATCH net 2/6] net/mlx5e: Re-arrange XDP SQ/CQ creation

In mlx5e_open_channel CQs must be created before napi is enabled. Here we move the XDP CQ creation to satisfy that fact. mlx5e_close_channel is already working according to the right order. Fixes: b5503b994ed5 ("net/mlx5e: XDP TX forwarding support") Signed-off-by: Saeed Mah

[PATCH net 6/6] net/mlx5: Fix invalid pointer reference when prof_sel parameter is invalid

Nguyen <h...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/main.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/main.c b/drivers/net/ethernet/mellanox/mlx5/core

[PATCH net 3/6] net/mlx5e: Disallow changing name-space for VF representors

From: Or Gerlitz <ogerl...@mellanox.com> VF reps should be altogether on the same NS as they were created. Signed-off-by: Or Gerlitz <ogerl...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 2 +-

Re: mlx5: ifup failure due to huge allocation

On Wed, Nov 2, 2016 at 3:37 PM, Sebastian Ott wrote: > Hi, > > Ifup on an interface provided by CX4 (MLX5 driver) on s390 fails with: > > [ 22.318553] [ cut here ] > [ 22.318564] WARNING: CPU: 1 PID: 399 at mm/page_alloc.c:3421 >

Re: mlx5 bug in error path of mlx5e_open_channel()

On 11/01/2016 04:44 PM, Jesper Dangaard Brouer wrote: > > In driver mlx5 function mlx5e_open_channel() does not handle error > path correctly. (Tested by letting mlx5e_create_rq fail with -ENOMEM, > propagates to mlx5e_open_rq) > > This first seemed related to commit b5503b994ed5 ("net/mlx5e:

Re: [PATCH net-next] mlx5: Add MLX5_SET64_VCHK to fix BUILD_BUG_ON

On Tue, Oct 11, 2016 at 7:50 PM, David Laight wrote: > From: Tom Herbert >> Sent: 11 October 2016 05:22 > ... >> Fix is to create MLX5_SET64_VCHK that takes an additional argument >> that is a constant. There are two callers of MLX5_SET64 that are >> trying to get a

Re: [PATCH net-next] mlx5: Add MLX5_SET64_VCHK to fix BUILD_BUG_ON

On Wed, Oct 12, 2016 at 4:40 AM, Leon Romanovsky <l...@kernel.org> wrote: > On Tue, Oct 11, 2016 at 08:46:45AM -0700, Tom Herbert wrote: >> On Tue, Oct 11, 2016 at 4:57 AM, Saeed Mahameed >> <sae...@dev.mellanox.co.il> wrote: >> > On Tue, Oct 11, 2016

[PATCH V2 net-next] net/mlx5: Add MLX5_ARRAY_SET64 to fix BUILD_BUG_ON

Fixes: a533ed5e179cd ("net/mlx5: Pages management commands via mlx5 ifc") Signed-off-by: Tom Herbert <t...@herbertland.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- Hi Dave, I hope this version of this patch will make it to -rc1, I made some changes to the original versi

Re: [PATCH net-next] mlx5: Add MLX5_SET64_VCHK to fix BUILD_BUG_ON

of MLX5_SET64 that are trying to get a variable offset, change those to call MLX5_SET64_VCHK passing pas[0] as the argument to use in the offset check. Fixes: a533ed5e179cd ("net/mlx5: Pages management commands via mlx5 ifc") Signed-off-by: Tom Herbert <t...@herbertland.com> Acked-by: Sae

Re: BUILD_BUG_ON error in mlx5/core/pagealloc.c

On Tue, Oct 11, 2016 at 12:58 PM, Tom Herbert <t...@herbertland.com> wrote: > On Mon, Oct 10, 2016 at 8:17 PM, Saeed Mahameed > <sae...@dev.mellanox.co.il> wrote: >> >> >> On Tuesday, October 11, 2016, Tom Herbert <t...@herbertland.com> wrote: >>&g

[PATCH net-next 6/7] net/mlx5e: Refactor tc del flow to accept mlx5e_tc_flow instance

yan <r...@mellanox.com> Reviewed-by: Or Gerlitz <ogerl...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/me

[PATCH net-next 7/7] net/mlx5e: Remove flow encap entry in the correct place

lanox.com> Reviewed-by: Or Gerlitz <ogerl...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 43 + 1 file changed, 22 insertions(+), 21 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/co

[PATCH net-next 3/7] net/mlx5e: Create UMR MKey per RQ

so we can scale to any number of rings, with the maximum buffer size in each. Signed-off-by: Tariq Toukan <tar...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 12 ++--- .../net/ethernet/mellanox/mlx5/core/e

[PATCH net-next 2/7] net/mlx5e: Move function mlx5e_create_umr_mkey

From: Tariq Toukan <tar...@mellanox.com> In next patch we are going to create a UMR MKey per RQ, we need mlx5e_create_umr_mkey declared before mlx5e_create_rq. Signed-off-by: Tariq Toukan <tar...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net

[PATCH net-next 4/7] net/mlx5e: Remove redundant hashtable lookup in configure flower

t;r...@mellanox.com> Reviewed-by: Hadar Hen Zion <had...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 26 +++-- 1 file changed, 7 insertions(+), 19 deletions(-) diff --git a/drivers/net/e

[PATCH net-next 0/7] Mellanox 100G mlx5 updates 2016-11-29

Hi Dave, The following series from Tariq and Roi, provides some critical fixes and updates for the mlx5e driver. >From Tariq: - Fix driver coherent memory huge allocation issues by fragmenting completion queues, in a way that is transparent to the netdev driver by providing a new buffer

[PATCH net-next 1/7] net/mlx5e: Implement Fragmented Work Queue (WQ)

inux.vnet.ibm.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/alloc.c | 66 +++ drivers/net/ethernet/mellanox/mlx5/core/en.h | 2 +- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 10 ++-- drivers/ne

[PATCH net-next 5/7] net/mlx5e: Correct cleanup order when deleting offloaded TC rules

gned-off-by: Roi Dayan <r...@mellanox.com> Reviewed-by: Or Gerlitz <ogerl...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethe

[PATCH net V2 1/6] net/mlx5: Verify module parameters

l Heib <kam...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/main.c | 27 +- .../net/ethernet/mellanox/mlx5/core/mlx5_core.h| 2 +- 2 files changed, 17 insertions(+), 12 deletions(-) diff -

[PATCH net V2 5/6] net/mlx5e: Don't flush SQ on error

We are doing SQ descriptors cleanup in driver. Fixes: 6e8dd6d6f4bd ("net/mlx5e: Don't wait for SQ completions on close") Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 1 - 1 file changed, 1 deletion(-) diff --g

[PATCH net V2 6/6] net/mlx5e: Change the SQ/RQ operational state to positive logic

on close") Signed-off-by: Mohamad Haj Yahia <moha...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 4 ++-- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 14 +- drivers/net/ethe

[PATCH net V2 0/6] Mellanox 100G mlx5 fixes 2016-12-04

1): net/mlx5e: Change the SQ/RQ operational state to positive logic Saeed Mahameed (2): net/mlx5e: Don't notify HW when filling the edge of ICO SQ net/mlx5e: Don't flush SQ on error drivers/net/ethernet/mellanox/mlx5/core/cmd.c | 5 --- drivers/net/ethernet/mellanox/mlx5/core/en.h

[PATCH net V2 2/6] net/mlx5: Remove duplicate pci dev name print

From: Kamal Heib <kam...@mellanox.com> Remove duplicate pci dev name printing from mlx5_core_warn/dbg. Fixes: 5a7883989b1c ('net/mlx5_core: Improve mlx5 messages') Signed-off-by: Kamal Heib <kam...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- dr

[PATCH net V2 3/6] net/mlx5: Fix query ISSI flow

kam...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/cmd.c | 5 - drivers/net/ethernet/mellanox/mlx5/core/main.c | 15 +-- drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.h | 5 + 3 files c

[PATCH net V2 4/6] net/mlx5e: Don't notify HW when filling the edge of ICO SQ

We are going to do this a couple of steps ahead anyway. Fixes: d3c9bc2743dc ("net/mlx5e: Added ICO SQs") Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

Re: [PATCH v4 net-next 3/4] mlx4: xdp: Reserve headroom for receiving packet when XDP prog is active

tin KaFai Lau <ka...@fb.com> Acked-by: Saeed Mahameed <sae...@mellanox.com>

Re: [PATCH v4 net-next 2/4] mlx4: xdp: Allow raising MTU up to one page minus eth and vlan hdrs

isting guard > to ensure the page/pkt scheme only applies when XDP is active > in mlx4. > > Signed-off-by: Martin KaFai Lau <ka...@fb.com> Acked-by: Saeed Mahameed <sae...@mellanox.com>

Re: [PATCH net-next 0/2] Add ethtool set regs support

On Wed, Dec 7, 2016 at 4:57 AM, David Miller <da...@davemloft.net> wrote: > From: Andrew Lunn <and...@lunn.ch> > Date: Wed, 7 Dec 2016 03:41:43 +0100 > >> On Wed, Dec 07, 2016 at 12:33:08AM +0200, Saeed Mahameed wrote: >>> Hi Dave, >>> >>> Thi

Re: [PATCH net-next 0/2] Add ethtool set regs support

On Wed, Dec 7, 2016 at 4:41 AM, Andrew Lunn <and...@lunn.ch> wrote: > On Wed, Dec 07, 2016 at 12:33:08AM +0200, Saeed Mahameed wrote: >> Hi Dave, >> >> This series adds the support for setting device registers from user >> space ethtool. > > Is this not th

Re: [PATCH net-next 0/2] Add ethtool set regs support

On Wed, Dec 7, 2016 at 12:45 AM, Stephen Hemminger <step...@networkplumber.org> wrote: > On Wed, 7 Dec 2016 00:33:08 +0200 > Saeed Mahameed <sae...@mellanox.com> wrote: > >> This simple ethool change will give HW vendors the flexibility to set >> pure HW con

Re: mlx5: net_device.addr_list_lock usage before initialization

On Tue, Dec 13, 2016 at 3:22 PM, Sebastian Ott wrote: > Hi, > > I ran into the following lockdep complaint: > > [7.059561] INFO: trying to register non-static key. > [7.059566] the code is fine but needs lockdep annotation. > [7.059570] turning off the

Re: [PATCH v2 net-next 3/4] mlx4: xdp: Reserve headroom for receiving packet when XDP prog is active

On Mon, Dec 5, 2016 at 9:55 PM, Martin KaFai Lau <ka...@fb.com> wrote: > On Mon, Dec 05, 2016 at 02:54:06AM +0200, Saeed Mahameed wrote: >> On Sun, Dec 4, 2016 at 5:17 AM, Martin KaFai Lau <ka...@fb.com> wrote: >> > Reserve XDP_PACKET_HEADROOM and honor bpf_xdp_ad

[PATCH net-next 0/2] Add ethtool set regs support

Hi Dave, This series adds the support for setting device registers from user space ethtool. Currently ethtool only allows to get device registers, we extend ethtool functionality to also set device registers, by introducing set_regs to ethtool_ops which will be invoked when user space requests

[PATCH net-next 2/2] net/mlx5e: Add ethtool get/set reg support

; Signed-off-by: Dmitry Teif <di...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/Makefile | 2 +- drivers/net/ethernet/mellanox/mlx5/core/cmd.c | 19 drivers/net/ethernet/mellanox/mlx5/core/en.h |

[PATCH net-next 1/2] ethtool: Add set regs -D option support

s data provided via stdin/file. Changes made by this option can be queried using get regs -d flag. Example: $ ethtool -D eth1 file /tmp/mlx5_regs Signed-off-by: Gal Pressman <g...@mellanox.com> Signed-off-by: Dmitry Teif <di...@mellanox.com> CC: John W. Linville <linvi...@tuxdriver.com&

Re: [PATCH net-next 1/3] net/mlx5e: use %pad format string for dma_addr_t

print the correct address and avoid the warning. > > Fixes: 1c1b522808a1 ("net/mlx5e: Implement Fragmented Work Queue (WQ)") > Signed-off-by: Arnd Bergmann <a...@arndb.de> Thank you Arnd !! Acked-by: Saeed Mahameed <sae...@mellanox.com>

Re: [pull request][for-next] Mellanox mlx5 Reorganize core driver directory layout

On Fri, Jan 13, 2017 at 7:14 PM, David Miller <da...@davemloft.net> wrote: > From: Saeed Mahameed <sae...@mellanox.com> > Date: Thu, 12 Jan 2017 19:22:34 +0200 > >> This pull request includes one patch from Leon, this patch as described >> below will chan

Re: [pull request][for-next] Mellanox mlx5 Reorganize core driver directory layout

On Sat, Jan 14, 2017 at 12:06 AM, Tom Herbert <t...@herbertland.com> wrote: > On Fri, Jan 13, 2017 at 12:29 PM, Leon Romanovsky <l...@kernel.org> wrote: >> On Fri, Jan 13, 2017 at 12:14:07PM -0500, David Miller wrote: >>> From: Saeed Mahameed <sae...@mellanox.com&

Re: [PATCH net-next] net/mlx5e: Support bpf_xdp_adjust_head()

On Sat, Jan 14, 2017 at 12:31 AM, Martin KaFai Lau <ka...@fb.com> wrote: > On Fri, Jan 13, 2017 at 03:58:46PM +0200, Saeed Mahameed wrote: >> >> > @@ -680,7 +687,7 @@ static inline void mlx5e_xmit_xdp_frame(struct >> >> > mlx5e_rq *rq, >

[PATCH net 08/10] net/mlx5e: Un-register uplink representor on nic_disable

The code before this patch registered uplink e-Switch representor on nic_enable and unregistered on nic_cleanup, the right place for this unregister is in nic_disable. Fixes: 127ea380acc9 ("net/mlx5: Add Representors registration API") Signed-off-by: Saeed Mahameed <sae...@mellanox.

[PATCH net 03/10] net/mlx5e: TC ipv4 tunnel encap offload error flow fixes

Fixes: a54e20b4fcae ('net/mlx5e: Add basic TC tunnel set action for SRIOV offloads') Signed-off-by: Or Gerlitz <ogerl...@mellanox.com> Reviewed-by: Hadar Hen Zion <had...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellano

[PATCH net 06/10] net/mlx5e: Fix kbuild warnings for uninitialized parameters

From: Hadar Hen Zion <had...@mellanox.com> kbuild warn about parameters that may be used uninitialized, fix it. Fixes: a54e20b4fcae ('net/mlx5e: Add basic TC tunnel set action for SRIOV offloads') Signed-off-by: Hadar Hen Zion <had...@mellanox.com> Signed-off-by: Saeed M

[PATCH net 04/10] net/mlx5e: Properly get address type of encapsulation IP headers

tunnel release action for SRIOV offloads') Signed-off-by: Or Gerlitz <ogerl...@mellanox.com> Reviewed-by: Hadar Hen Zion <had...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 13 + 1 file cha

[PATCH net 09/10] net/mlx5e: Remove WARN_ONCE from adaptive moderation code

e been inserted only under debug. We avoid such call traces by removing those WARN_ONCE. Fixes: cb3c7fd4f839 ("net/mlx5e: Support adaptive RX coalescing") Signed-off-by: Gil Rockah <g...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net

[PATCH net 10/10] net/mlx5: Only cancel recovery work when cleaning up device

oading, it must be explicitly canceled in the AER flow. fixes: 689a248df83b ("net/mlx5: Cancel recovery work in remove flow") Signed-off-by: Daniel Jurgens <dani...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/main.c |

[PATCH net 00/10] Mellanox mlx5 fixes and cleanups 2017-01-10

ipv4 tunnel encap offload error flow fixes net/mlx5e: Properly get address type of encapsulation IP headers net/mlx5e: Set inline mode requirements for matching on IP fragments net/mlx5e: Properly handle FW errors while adding TC rules Saeed Mahameed (1): net/mlx5e: Un-register uplink

[PATCH net 02/10] net/mlx5e: Warn when rejecting offload attempts of IP tunnels

Fixes: a54e20b4fcae ('net/mlx5e: Add basic TC tunnel set action for SRIOV offloads') Fixes: bbd00f7e2349 ('net/mlx5e: Add TC tunnel release action for SRIOV offloads') Signed-off-by: Or Gerlitz <ogerl...@mellanox.com> Reviewed-by: Hadar Hen Zion <had...@mellanox.com> Signed-off-by: S

[PATCH net 05/10] net/mlx5e: Set inline mode requirements for matching on IP fragments

<ogerl...@mellanox.com> Reviewed-by: Roi Dayan <r...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/ne

[PATCH net 01/10] net/mlx5e: Properly handle offloading of source udp port for IP tunnels

..@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/co

Re: [PATCH net v2] mlx4: Return EOPNOTSUPP instead of ENOTSUPP

("mlx4: xdp: Allow raising MTU up to one page minus eth > and vlan hdrs") > Signed-off-by: Martin KaFai Lau <ka...@fb.com> Acked-by: Saeed Mahameed <sae...@mellanox.com> Thank you martin. Small question though, is it essential for the upper layer to get the correct errno ? or this is just a cleanup ?

[PATCH net 07/10] net/mlx5e: Properly handle FW errors while adding TC rules

lanox.com> Reviewed-by: Roi Dayan <r...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/cor

Re: [PATCH net-next] net/mlx5e: Support bpf_xdp_adjust_head()

On Thu, Jan 12, 2017 at 4:09 AM, Martin KaFai Lau wrote: > This patch adds bpf_xdp_adjust_head() support to mlx5e. Hi Martin, Thanks for the patch ! you can find some comments below. > > 1. rx_headroom is added to struct mlx5e_rq. It uses >an existing 4 byte hole in the

Re: [PATCH net-next] net/mlx5e: Support bpf_xdp_adjust_head()

On Fri, Jan 13, 2017 at 1:25 AM, Martin KaFai Lau <ka...@fb.com> wrote: > On Thu, Jan 12, 2017 at 03:10:30PM +0200, Saeed Mahameed wrote: >> On Thu, Jan 12, 2017 at 4:09 AM, Martin KaFai Lau <ka...@fb.com> wrote: >> > This patch adds bpf_xdp_adjust_head() support to

[pull request][for-next] Mellanox mlx5 Reorganize core driver directory layout

Hi Dave and Doug, This pull request includes one patch from Leon, this patch as described below will change the driver directory structure and layout for better, logical and modular driver files separation. This change is important to both rdma and net maintainers in order to have smoother

[for-next V2 1/1] {net, IB}/mlx5: Reorganize driver file layout

- Saeed, Matan and Leon * include/uapi/rdma/mlx5-abi.h - Matan and Leon Signed-off-by: Leon Romanovsky <leo...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- MAINTAINERS | 11 ++- drivers/infiniband

[pull request][for-next V2 0/1] Mellanox mlx5 Reorganize core driver directory layout

Hi Dave and Doug, This pull request includes one patch from Leon, this patch as described below will change the driver directory structure and layout for better, logical and modular driver files separation. This change is important to both rdma and net maintainers in order to have smoother

<    6   7   8   9   10   11   12   13   14   15   >