Re: [PATCH v2 net-next 3/4] mlx4: xdp: Reserve headroom for receiving packet when XDP prog is active

On Tue, Dec 6, 2016 at 8:27 PM, Martin KaFai Lau <ka...@fb.com> wrote: > On Tue, Dec 06, 2016 at 06:50:47PM +0200, Saeed Mahameed wrote: >> On Mon, Dec 5, 2016 at 9:55 PM, Martin KaFai Lau <ka...@fb.com> wrote: >> > On Mon, Dec 05, 2016 at 02:54:06AM +0200, Saeed Mah

Re: [BUG] ethernet:mellanox:mlx5: Oops in health_recover get_nic_state(dev)

On Tue, Mar 28, 2017 at 2:45 AM, Goel, Sameer wrote: > Stack frame: > [ 1744.418958] [] get_nic_state+0x24/0x40 [mlx5_core] > [ 1744.425273] [] health_recover+0x28/0x80 [mlx5_core] > [ 1744.431496] [] process_one_work+0x150/0x460 > [ 1744.437218] [] worker_thread+0x50/0x4b8

[PATCH net 1/1] net/mlx5: Avoid dereferencing uninitialized pointer

Aviv Heller <av...@mellanox.com> Reviewed-by: Moni Shoua <mo...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- Hi Dave, I will appreciate it if you queue up this patch for v4.9-stable. Thanks in advance, Saeed. drivers/net/ethernet/mellanox/mlx5/core/l

Re: [PATCH net-next 00/12] Mellanox mlx5e XDP performance optimization

On Sat, Mar 25, 2017 at 6:54 PM, Tom Herbert <t...@herbertland.com> wrote: > On Fri, Mar 24, 2017 at 2:52 PM, Saeed Mahameed <sae...@mellanox.com> wrote: >> Hi Dave, >> >> This series provides some preformancee optimizations for mlx5e >> driver, espec

[PATCH net-next 12/12] net/mlx5e: Different SQ types

-by: Saeed Mahameed <sae...@mellanox.com> Reviewed-by: Tariq Toukan <tar...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 99 +++-- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 464 +- drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 33

[PATCH net-next 03/12] net/mlx5e: Single bfreg (UAR) for all mlx5e SQs and netdevs

One is sufficient since Blue Flame is not supported anymore. This will also come in handy for switchdev mode to save resources, since VF representors will use same single UAR as well for their own SQs. Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Reviewed-by: Tariq Touka

[PATCH net-next 00/12] Mellanox mlx5e XDP performance optimization

Drop (1 core) 3.45Mpps 3.6Mpps 5% XDP Drop (1 core) 14Mpps16.9Mpps20% XDP TX(1 core) 10.4Mpps 13.7Mpps31% Thanks, Saeed. Saeed Mahameed (12): net/mlx5e: Use dma_rmb rather than rmb in CQE fetch routine net/mlx5e: Xmit, no write

[PATCH net-next 09/12] net/mlx5e: Generalize tx helper functions for different SQ types

In the next patches we will introduce different SQ types, for that we here generalize some TX helper functions to work with more basic SQ parameters, in order to re-use them for the different SQ types. Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Reviewed-by: Tariq Touka

[PATCH net-next 08/12] net/mlx5e: Optimize XDP frame xmit

-by: Saeed Mahameed <sae...@mellanox.com> Reviewed-by: Tariq Toukan <tar...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 5 --- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 43 +++ drivers/net/ethernet/mellanox/mlx5/core/en

[PATCH net-next 02/12] net/mlx5e: Xmit, no write combining

case Before Now improvement --- TX packets (24 threads) 50Mpps 54Mpps8% Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Reviewed-by: Tariq Toukan <tar...@mellanox.com> --- drivers/

[PATCH net-next 05/12] net/mlx5e: Move mlx5e_rq struct declaration

Move struct mlx5e_rq and friends to appear after mlx5e_sq declaration in en.h. We will need this for next patch to move the mlx5e_sq instance into mlx5e_rq struct for XDP SQs. Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Reviewed-by: Tariq Toukan <tar...@mellanox.com> ---

[PATCH net-next 10/12] net/mlx5e: Proper names for SQ/RQ/CQ functions

semantics. Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Reviewed-by: Tariq Toukan <tar...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 126 +++--- 1 file changed, 63 insertions(+), 63 deletions(-) diff --git a/drivers/net/ethernet/mellan

[PATCH net-next 04/12] net/mlx5e: Move XDP completion functions to rx file

XDP code belongs to RX path, move mlx5e_poll_xdp_tx_cq and mlx5e_free_xdp_tx_descs to en_rx.c. Rename them to mlx5e_poll_xdpsq_cq and mlx5e_free_xdpsq_descs. Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Reviewed-by: Tariq Toukan <tar...@mellanox.com> --- drivers/net/ether

[PATCH net-next 01/12] net/mlx5e: Use dma_rmb rather than rmb in CQE fetch routine

12Mpps 15% Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Reviewed-by: Tariq Toukan <tar...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_txrx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_txrx.

[PATCH net-next 06/12] net/mlx5e: Move XDP SQ instance into RQ

To save many rq->channel->sq dereferences in fast-path. And rename it to xdpsq. Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Reviewed-by: Tariq Toukan <tar...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 4 +++- drivers/net/ethernet/mellanox/m

[PATCH net-next 07/12] net/mlx5e: Poll XDP TX CQ before RX CQ

--- XDP Drop (1 core) 16.9Mpps 16.9MppsNo change XDP TX (1 core) 12Mpps13Mpps 8% Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Reviewed-by: Tariq Toukan <tar...@mellanox.com> --- drivers/net/ethernet/mellan

[PATCH net-next 11/12] net/mlx5e: Generalize SQ create/modify/destroy functions

In the next patches we will introduce different SQ types, and we would want to reuse those functions, in this patch we make them agnostic to SQ type (txq, xdp, ico). Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Reviewed-by: Tariq Toukan <tar...@mellanox.com> --- drivers/

Re: [PATCH net-next 00/12] Mellanox mlx5e XDP performance optimization

On Sat, Mar 25, 2017 at 2:26 AM, Alexei Starovoitov <a...@fb.com> wrote: > On 3/24/17 2:52 PM, Saeed Mahameed wrote: >> >> Hi Dave, >> >> This series provides some preformancee optimizations for mlx5e >> driver, especially for XDP TX flows. >> >

[net-next 03/12] net/mlx5e: Add intermediate struct for TC flow parsing attributes

patch. This patch doesn't change any functionality. Signed-off-by: Or Gerlitz <ogerl...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 29 +++-- 1 file changed, 17 insertions(+), 12 deletions(-) di

[net-next 11/12] net/mlx5e: Add offloading of NIC TC pedit (header re-write) actions

erlitz <ogerl...@mellanox.com> Reviewed-by: Hadar Hen Zion <had...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 35 + 1 file changed, 35 insertions(+) diff --git a/drivers/net/eth

[net-next 02/12] net/mlx5e: Add NIC attributes for offloaded TC flows

erlitz <ogerl...@mellanox.com> Reviewed-by: Hadar Hen Zion <had...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 51 +++-- 1 file changed, 31 insertions(+), 20 deletions(-) diff --gi

[net-next 06/12] net/mlx5: Reorder few command cases to reflect their natural order

erlitz <ogerl...@mellanox.com> Reviewed-by: Hadar Hen Zion <had...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/cmd.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drive

[net-next 09/12] net/sched: Add accessor functions to pedit keys for offloading drivers

com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- include/net/tc_act/tc_pedit.h | 45 +++ 1 file changed, 45 insertions(+) diff --git a/include/net/tc_act/tc_pedit.h b/include/net/tc_act/tc_pedit.h index dfbd6ee0bc7c..a46c3f2ace70 100644

[net-next 05/12] net/mlx5: Add helper to initialize a flow steering actions struct instance

nality. Signed-off-by: Or Gerlitz <ogerl...@mellanox.com> Reviewed-by: Hadar Hen Zion <had...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c | 14 +++--- drivers/net/ethernet/mellanox/

[net-next 10/12] net/mlx5e: Add parsing of TC pedit actions to HW format

wed-by: Amir Vadai <a...@vadai.me> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 273 1 file changed, 273 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/eth

[net-next 01/12] net/mlx5e: Add prefix for e-switch offloaded TC flow attributes

where 100Ks (or Ms) of flows are offloaded. This patch doesn't change any functionality. Signed-off-by: Or Gerlitz <ogerl...@mellanox.com> Reviewed-by: Hadar Hen Zion <had...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellano

[net-next 12/12] net/mlx5e: Add offloading of E-Switch TC pedit (header re-write) actions

erlitz <ogerl...@mellanox.com> Reviewed-by: Hadar Hen Zion <had...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_tc.c| 37 -- drivers/net/ethernet/mellanox/mlx5/core/eswitch.h | 1 + .../eth

[net-next 07/12] net/mlx5: Introduce modify header structures, commands and steering action definitions

values for the emulated actions are at the end of the possible range. Signed-off-by: Or Gerlitz <ogerl...@mellanox.com> Reviewed-by: Hadar Hen Zion <had...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/eswitch.h | 4

[net-next 04/12] net/mlx5e: Properly deal with resource cleanup when adding TC flow fails

ed-by: Hadar Hen Zion <had...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_tc.c| 59 +- .../ethernet/mellanox/mlx5/core/eswitch_offloads.c | 23 + 2 files changed, 50 insertions(+), 32

[net-next 08/12] net/mlx5: Introduce alloc/dealloc modify header context commands

From: Or Gerlitz <ogerl...@mellanox.com> Implement the low-level commands to support packet header re-write. Signed-off-by: Or Gerlitz <ogerl...@mellanox.com> Reviewed-by: Hadar Hen Zion <had...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drive

[pull request][net-next 00/12] Mellanox mlx5 offloading of TC pedit (header re-write) action

Hi Dave, The following changes from Or Gerlitz provide mlx5 offloading support of TC pedit (header re-write) action. For more information please see below. Please pull and let me know if there's any problem. Thanks, Saeed. --- The following changes since commit

[net-next 08/14] net/mlx5e: CQ and RQ don't need priv pointer

Remove mlx5e_priv pointer from CQ and RQ structs, it was needed only to access mdev pointer from priv pointer. Instead we now pass mdev where needed. Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Reviewed-by: Tariq Toukan <tar...@mellanox.com> --- drivers/net/ethernet/mellan

[net-next 07/14] net/mlx5e: Isolate open_channels from priv->params

_params field to mlx5e_channels structure and use it down the road to mlx5e_open_{cq,rq,sq} and so on. Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Reviewed-by: Tariq Toukan <tar...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 22 +- drivers/net/ethernet/mell

[net-next 02/14] net/mlx5e: Set netdev->rx_cpu_rmap on netdev creation

To simplify mlx5e_open_locked flow we set netdev->rx_cpu_rmap on netdev creation rather on netdev open, it is redundant to set it every time on mlx5e_open_locked. Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Reviewed-by: Tariq Toukan <tar...@mellanox.com> --- drivers/net/et

[net-next 03/14] net/mlx5e: Introduce mlx5e_channels

and switch to the new channels on the fly. Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Reviewed-by: Tariq Toukan <tar...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 9 ++- .../net/ethernet/mellanox/mlx5/core/en_ethtool.c | 27 +++ drivers/net/ether

[net-next 09/14] net/mlx5e: Minimize mlx5e_{open/close}_locked

with new ones without the need to call mlx5e_close/open. Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Reviewed-by: Tariq Toukan <tar...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 40 +++ drivers/net/ethernet/mellanox/mlx5/core/en

[pull request][net-next 00/14] Mellanox mlx5e Fail-safe config

riv flags) ndos: - tc setup - set features: LRO - change mtu ---- Saeed Mahameed (14): net/mlx5e: Set SQ max rate on mlx5e_open_txqsq rather on open_channel net/mlx5e: Set netdev->rx_cpu_rmap on netdev creation

[net-next 05/14] net/mlx5e: Refactor refresh TIRs

Rename mlx5e_refresh_tirs_self_loopback to mlx5e_refresh_tirs, as it will be used in downstream (Safe config flow) patches, and make it fail safe on mlx5e_open. Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Reviewed-by: Tariq Toukan <tar...@mellanox.com> --- drivers/net/ether

[net-next 12/14] net/mlx5e: Fail safe cqe compressing/moderation mode setting

Use the new fail-safe channels switch mechanism to set new CQE compressing and CQE moderation mode settings. We also move RX CQE compression modify function out of en_rx file to a more appropriate place. Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Reviewed-by: Tariq Touka

[net-next 14/14] net/mlx5e: Fail safe mtu and lro setting

features, we now pass to it a modify HW function pointer to be invoked directly after old channels are de-activated and before new channels are activated. Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Reviewed-by: Tariq Toukan <tar...@mellanox.com> --- drivers/net/ethernet/mellan

[net-next 01/14] net/mlx5e: Set SQ max rate on mlx5e_open_txqsq rather on open_channel

Instead of iterating over the channel SQs to set their max rate, do it on SQ creation per TXQ SQ. Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Reviewed-by: Tariq Toukan <tar...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 22 ++ 1

[net-next 04/14] net/mlx5e: Redirect RQT refactoring

(direct/indirect). Demonstrated the usage with mlx5e_redirect_rqts_to_channels which will be called on mlx5e_open and with mlx5e_redirect_rqts_to_drop which will be called on mlx5e_close. Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Reviewed-by: Tariq Toukan <tar...@mellanox.com>

[net-next 06/14] net/mlx5e: Split open/close channels to stages

return "SUCCESS"; } Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Reviewed-by: Tariq Toukan <tar...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 5 +- .../net/ethernet/mellanox/mlx5/core/en_ethtool.c | 2 +- drivers/net/ethernet/mellanox

[net-next 11/14] net/mlx5e: Fail safe ethtool settings

Use the new fail-safe channels switch mechanism to set new ethtool settings: - ring parameters - coalesce parameters - tx copy break parameters Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Reviewed-by: Tariq Toukan <tar...@mellanox.com> --- .../net/ethernet/mellan

[net-next 13/14] net/mlx5e: Fail safe tc setup

Use the new fail-safe channels switch mechanism to set up new tc parameters. Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Reviewed-by: Tariq Toukan <tar...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 20 1 file changed, 12 inse

[net-next 10/14] net/mlx5e: Introduce switch channels

w_channels); return "SUCCESS"; } Demonstrate mlx5e_switch_priv_channels usage in set channels ethtool callback and make it fail-safe using the new switch channels mechanism. Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Reviewed-by: Tariq Toukan <tar...@mellanox.c

Re: mlx5e backports for v4.9 -stable

5e: Fix broken CQE compression initialization > > > and > > > From 6dc4b54e77282caf17f0ff72aa32dd296037fbc0 Mon Sep 17 00:00:00 2001 > From: Saeed Mahameed <sae...@mellanox.com> > Date: Wed, 22 Feb 2017 17:20:15 +0200

[PATCH net 0/8] Mellanox mlx5 fixes 2017-03-21

Hi Dave, This series contains some mlx5 core and ethernet driver fixes. For -stable: net/mlx5e: Count LRO packets correctly (for kernel >= 4.2) net/mlx5e: Count GSO packets correctly (for kernel >= 4.2) net/mlx5: Increase number of max QPs in default profile (for kernel >= 4.0) net/mlx5e: Avoid

[PATCH net 8/8] net/mlx5e: Count LRO packets correctly

gical statistics: $ ethtool -S ens6 | egrep "rx_packets|rx_lro_packets" rx_packets: 1935066 rx_lro_packets: 35847 rx_packets_phy: 1935066 Fixes: e586b3b0baee ("net/mlx5: Ethernet Datapath files") Signed-off-by: Gal Pressman <g...@mellanox.com> Cc: kernel-t...

[PATCH net 5/8] net/mlx5e: Avoid supporting udp tunnel port ndo for VF reps

vxlan1 type vxlan id 44 dev ens5f0 dstport ip link set vxlan1 up ip link del dev vxlan1 Fixes: 4a25730eb202 ('net/mlx5e: Add ndo_udp_tunnel_add to VF representors') Signed-off-by: Paul Blakey <pa...@mellanox.com> Reviewed-by: Or Gerlitz <ogerl...@mellanox.com> Signed-off-by: S

[PATCH net 4/8] net/mlx5e: Use the proper UAPI values when offloading TC vlan actions

ted-by: Petr Machata <pe...@mellanox.com> Reviewed-by: Jiri Pirko <j...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet

[PATCH net 6/8] net/mlx5: Increase number of max QPs in default profile

: Maor Gottlieb <ma...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/main.c b/drivers/net/ethernet/mellano

[PATCH net 7/8] net/mlx5e: Count GSO packets correctly

gical statistics: $ ethtool -S ens6 | egrep "tx_packets|tx_tso_packets" tx_packets: 2451115 tx_tso_packets: 60954 tx_packets_phy: 2451115 Fixes: e586b3b0baee ("net/mlx5: Ethernet Datapath files") Signed-off-by: Gal Pressman <g...@mellanox.com> Cc: kernel-t...

Re: mlx5e backports for v4.9 -stable

On Mon, Mar 20, 2017 at 11:32 PM, Saeed Mahameed <sae...@mellanox.com> wrote: > > > On 03/17/2017 02:06 AM, David Miller wrote: >> >> Commits: >> >> >> From b0d4660b4cc52e6477ca3a43435351d565dfcedc Mon Sep 17 00:00:00 2001 >&g

[PATCH net 3/8] net/mlx5: E-Switch, Don't allow changing inline mode when flows are configured

se inline mode changes if this isn't zero. Fixes: bffaa916588e ("net/mlx5: E-Switch, Add control for inline mode") Signed-off-by: Roi Dayan <r...@mellanox.com> Reviewed-by: Or Gerlitz <ogerl...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- dr

[PATCH net 1/8] net/mlx5: Add missing entries for set/query rate limit commands

lanox.com> Reviewed-by: Hadar Hen Zion <had...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/cmd.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/cmd.c b/drivers/net/eth

[PATCH net 2/8] net/mlx5e: Change the TC offload rule add/del code path to be per NIC or E-Switch

Fixes: bffaa916588e ("net/mlx5: E-Switch, Add control for inline mode") Signed-off-by: Or Gerlitz <ogerl...@mellanox.com> Reviewed-by: Roi Dayan <r...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_tc.c| 59 +

Re: [PATCH net-next] net/mlx5e: fix build error without CONFIG_SYSFS

eues != num_txqs) > - netif_set_real_num_tx_queues(netdev, num_txqs); > - if (netdev->real_num_rx_queues != priv->channels.num) > - netif_set_real_num_rx_queues(netdev, priv->channels.num); > + netif_set_real_num_tx_queues(netdev, num_txqs); > + netif_set_real_num_rx_

Re: [PATCH net-next] mlx4: trust shinfo->gso_segs

f-by: Eric Dumazet <eduma...@google.com> > Cc: Tariq Toukan <tar...@mellanox.com> > Cc: Saeed Mahameed <sae...@mellanox.com> > --- > drivers/net/ethernet/mellanox/mlx4/en_tx.c |3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/driv

[PATCH net-next 09/16] net/mlx5e: IPoIB, Basic netdev ndos open/close

Implement open/close of IPoIB netdevice ndos using mlx5e's channels API to manage data path resources (RQs/SQs/CQs). Set IPoIB netdev address on dev_init ndo. Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Reviewed-by: Erez Shitrit <ere...@mellanox.com> --- drivers/net/ether

[PATCH net-next 07/16] net/mlx5e: IPoIB, RSS flow steering tables

of those tables is identical to mlx5e ethernet mode, hence the use of mlx5e_create_ttc_table and mlx5e_arfs_create_tables. Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Reviewed-by: Erez Shitrit <ere...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en.h| 4 +++

[PATCH net-next 04/16] net/mlx5e: More generic netdev management API

callbacks. Also some of the logic was moved only to NIC profile since it is not right to have this logic for representor net device (e.g. set port MTU). Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Reviewed-by: Erez Shitrit <ere...@mellanox.com> --- drivers/net/ethernet/mellan

[PATCH net-next 02/16] net/mlx5: Refactor create flow table method to accept underlay QP

lanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c | 10 ++- drivers/net/ethernet/mellanox/mlx5/core/en_fs.c| 25 +-- drivers/net/ethernet/mellanox/mlx5/core/eswitch.c | 5 +- .../ethernet/mellanox/mlx5/core/eswit

[PATCH net-next 00/16] Mellanox, mlx5 RDMA net device support

table method to accept underlay QP net/mlx5: Enable flow-steering for IB link hw/mlx5: Add New bit to check over QP creation Saeed Mahameed (12): net/mlx5e: More generic netdev management API net/mlx5e: IPoIB, Add netdevice profile skeleton net/mlx5e: IPoIB, RX steering RSS RQTs and TIRs

[PATCH net-next 03/16] net/mlx5: Enable flow-steering for IB link

From: Erez Shitrit <ere...@mellanox.com> Get the relevant capabilities if supports ipoib_enhanced_offloads and init the flow steering table accordingly. Signed-off-by: Erez Shitrit <ere...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethe

[PATCH net-next 08/16] net/mlx5e: IPoIB, TX TIS creation

Modify mlx5e tis creation function to accept underlay qp number, which will be needed by IPoIB. Implement mlx5i (IPoIB) tx init/cleanup netdevice profile flows to create one TIS with the IPoIB underlay qp, for IPoIB TX SQs. Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Reviewed-by

[PATCH net-next 13/16] net/mlx5e: RX handlers per netdev profile

in mlx5e_alloc_rq code that mlx5e_priv->ppriv is of the type vport_rep. Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Reviewed-by: Erez Shitrit <ere...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 5 +++- drivers/net/ethernet/mellanox/mlx5/core

[PATCH net-next 12/16] net/mlx5e: IPoIB, Xmit flow

handling. Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Reviewed-by: Erez Shitrit <ere...@mellanox.com> --- drivers/infiniband/hw/mlx5/mlx5_ib.h| 10 --- drivers/net/ethernet/mellanox/mlx5/core/en_tx.c | 87 + drivers/net/ethernet/mellanox/mlx5/

[PATCH net-next 15/16] net/mlx5e: E-switch vport manager is valid for ethernet only

Currently the driver support only ethernet eswitch, and we want to protect downstream IPoIB netdev from trying to access it in IB link. Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Reviewed-by: Erez Shitrit <ere...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en

[PATCH net-next 14/16] net/mlx5e: IPoIB, RX handler

Implement IPoIB RX SKB handler. Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Reviewed-by: Erez Shitrit <ere...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 78 + drivers/net/ethernet/mellanox/mlx5/core/ipoib.c | 2 + drivers/

[PATCH net-next 06/16] net/mlx5e: IPoIB, RX steering RSS RQTs and TIRs

in init/cleanup_rx IPoIB netdevice profile callbacks. Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Reviewed-by: Erez Shitrit <ere...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 12 - drivers/net/ethernet/mellanox/mlx5/core/en

[PATCH net-next 01/16] net/mlx5: Add IPoIB enhanced offloads bits to mlx5_ifc

IB QPs and flow steering tables. Signed-off-by: Erez Shitrit <ere...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- include/linux/mlx5/mlx5_ifc.h | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/include/linux/mlx5/mlx5_ifc.h b/

[PATCH net-next 05/16] net/mlx5e: IPoIB, Add netdevice profile skeleton

. Same as already done in mlx5e NIC netdevice and switchdev mode VF representors. Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Reviewed-by: Erez Shitrit <ere...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/Kconfig| 7 + drivers/net/ethernet/mellanox/mlx5/core/Make

[PATCH net-next 10/16] net/mlx5e: IPoIB, Underlay QP

for later RDMA netdev use. Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Reviewed-by: Erez Shitrit <ere...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/ipoib.c | 126 +++- 1 file changed, 124 insertions(+), 2 deletions(-) diff --git a/drivers/

[PATCH net-next 16/16] hw/mlx5: Add New bit to check over QP creation

From: Erez Shitrit <ere...@mellanox.com> Add check for bit IB_QP_CREATE_NETIF_QP while creating QP. Signed-off-by: Erez Shitrit <ere...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/infiniband/hw/mlx5/qp.c | 1 + 1 file changed, 1 insert

[PATCH net-next 11/16] net/mlx5e: Xmit flow break down

Break current mlx5e xmit flow into smaller blocks (helper functions) in order to reuse them for IPoIB SKB transmission. Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Reviewed-by: Erez Shitrit <ere...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 2 +-

Re: [PATCH net v2] net/mlx5e: Fix race in mlx5e_sw_stats and mlx5e_vport_stats

00070 0 47116 15596138 > 87539300 0 3 0 > > Cc: Saeed Mahameed <sae...@mellanox.com> > Suggested-by: Eric Dumazet <eric.duma...@gmail.com> > Signed-off-by: Martin KaFai Lau <ka...@fb.com> > --- > d

Re: [PATCH net v2] net/mlx5e: Fix race in mlx5e_sw_stats and mlx5e_vport_stats

On Thu, Apr 20, 2017 at 5:15 PM, Martin KaFai Lau <ka...@fb.com> wrote: > On Thu, Apr 20, 2017 at 05:00:13PM +0300, Saeed Mahameed wrote: >> On Thu, Apr 20, 2017 at 2:32 AM, Martin KaFai Lau <ka...@fb.com> wrote: >> > We have observed a sudden spike in rx/tx_packets

Re: [RFC PATCH net] net/mlx5e: Race between mlx5e_update_stats() and getting the stats

On Thu, Apr 20, 2017 at 2:35 AM, Eric Dumazet wrote: > On Wed, 2017-04-19 at 14:53 -0700, Martin KaFai Lau wrote: > >> Right, a temp and a memcpy should be enough to solve our spike problem. >> It may be the right fix for net. >> >> Agree that using a spinlock is better

[net 1/7] net/mlx5: Fix driver load bad flow when having fw initializing timeout

ed-off-by: Mohamad Haj Yahia <moha...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Cc: kernel-t...@fb.com --- drivers/net/ethernet/mellanox/mlx5/core/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/mai

[net 4/7] net/mlx5e: Make sure the FW max encap size is enough for ipv6 tunnels

<ogerl...@mellanox.com> Reviewed-by: Roi Dayan <r...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 42 ++--- 1 file changed, 23 insertions(+), 19 deletions(-) diff --git a/drivers/net/ethernet/mella

[net 6/7] net/mlx5e: Fix small packet threshold

er to totally avoid the expand header flow for performance reasons. Tested regular TCP_STREAM with iperf for 1 and 8 streams, no degradation was found. Fixes: 461017cb006a ("net/mlx5e: Support RX multi-packet WQE (Striding RQ)") Signed-off-by: Eugenia Emantayev <euge...@mellanox.com>

[pull request][net 0/7] Mellanox, mlx5 fixes 2017-04-22

Hi Dave, This series contains some mlx5 fixes for net. For your convenience, the series doesn't introduce any conflict with the ongoing net-next pull request. Please pull and let me know if there's any problem. For -stable: ("net/mlx5: E-Switch, Correctly deal with inline mode on ConnectX-5")

[net 3/7] net/mlx5e: Make sure the FW max encap size is enough for ipv4 tunnels

lanox.com> Reviewed-by: Roi Dayan <r...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 42 ++--- 1 file changed, 23 insertions(+), 19 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5

[net 2/7] net/mlx5: E-Switch, Correctly deal with inline mode on ConnectX-5

required. Fixes: bffaa916588e ('net/mlx5: E-Switch, Add control for inline mode') Signed-off-by: Or Gerlitz <ogerl...@mellanox.com> Reviewed-by: Roi Dayan <r...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_tc.c

[net 7/7] net/mlx5e: Fix ETHTOOL_GRXCLSRLALL handling

tool -N ens8 delete 55 Fixes: f913a72aa008 ("net/mlx5e: Add support to get ethtool flow rules") Signed-off-by: Ilan Tayari <il...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Cc: kernel-t...@fb.com --- drivers/net/ethernet/mellanox/mlx5/core/en_fs_

[net 5/7] net/mlx5: Fix UAR memory leak

eb <ma...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/uar.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/uar.c b/drivers/net/ethernet/mellanox/mlx5/core/uar.c index 2e6b0f290ddc..2

[pull request][net-next 0/5] Mellanox, mlx5 updates 2017-04-22

Hi Dave, This series contains some updates to mlx5 driver. Sparse and compiler warnings fixes from Stephen Hemminger. >From Roi Dayan and Or Gerlitz, Add devlink and mlx5 support for controlling E-Switch encapsulation mode, this knob will enable HW support for applying

[net-next 4/5] mlx5: hide unused functions

; Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/ipoib.c | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/ipoib.c b/drivers/net/ethernet/mellanox/mlx5/core/ipoib.c

[net-next 5/5] mlx5: fix warning about missing prototype

From: Stephen Hemminger <step...@networkplumber.org> Fix sparse warning about missing prototypes. The rx/tx code path defines functions with prototypes in ipoib.h. Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com>

[net-next 1/5] net/devlink: Add E-Switch encapsulation control

rules, e.g as done when offloading the TC tunnel key action. Signed-off-by: Roi Dayan <r...@mellanox.com> Reviewed-by: Or Gerlitz <ogerl...@mellanox.com> Acked-by: Jiri Pirko <j...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- include/net/devlink.

[net-next 3/5] net/mlx5: E-Switch, Add control for encapsulation

gt; Reviewed-by: Or Gerlitz <ogerl...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/eswitch.c | 5 ++ drivers/net/ethernet/mellanox/mlx5/core/eswitch.h | 3 ++ .../ethernet/mellanox/mlx5/core

[net-next 2/5] net/mlx5: E-Switch, Refactor fast path FDB table creation in switchdev mode

legacy mode. This patch doesn't change any functionality. Signed-off-by: Or Gerlitz <ogerl...@mellanox.com> Reviewed-by: Roi Dayan <r...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- .../ethernet/mellanox/mlx5/core/eswitch_offloads.c | 69 +++---

Re: [PATCH v3 net-next 08/14] mlx4: use order-0 pages for RX

On Sun, Mar 12, 2017 at 5:29 PM, Eric Dumazet wrote: > On Sun, 2017-03-12 at 07:57 -0700, Eric Dumazet wrote: > >> Problem is XDP TX : >> >> I do not see any guarantee mlx4_en_recycle_tx_desc() runs while the NAPI >> RX is owned by current cpu. >> >> Since TX completion is

Re: [PATCH v3 net-next 08/14] mlx4: use order-0 pages for RX

On Sun, Mar 12, 2017 at 6:49 PM, Eric Dumazet <eric.duma...@gmail.com> wrote: > On Sun, 2017-03-12 at 17:49 +0200, Saeed Mahameed wrote: >> On Sun, Mar 12, 2017 at 5:29 PM, Eric Dumazet <eric.duma...@gmail.com> wrote: >> > On Sun, 2017-03-12 at 07:57 -0700, Eric Dum

[PATCH net 2/5] net/mlx5: Don't save PCI state when PCI error is detected

e info. Fixes: 05ac2c0b7438 ('net/mlx5: Fix race between PCI error handlers and health work') Signed-off-by: Daniel Jurgens <dani...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/main.c | 5 +++-- 1 file changed, 3 insertio

[PATCH net 4/5] net/mlx5e: Avoid wrong identification of rules on deletion

Roi Dayan <r...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 33 ++--- 1 file changed, 18 insertions(+), 15 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/eth

[PATCH net 1/5] net/mlx5: Fix create autogroup prev initializer

Blakey <pa...@mellanox.com> Reviewed-by: Mark Bloch <ma...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/c

[PATCH net 0/5] Mellanox mlx5 fixes 2017-03-09

Hi Dave, This series contains some mlx5 core and ethernet driver fixes. For -stable: net/mlx5e: remove IEEE/CEE mode check when setting DCBX mode (for kernel >= 4.10) net/mlx5e: Avoid wrong identification of rules on deletion (for kernel >= 4.9) net/mlx5: Don't save PCI state when PCI error is

[PATCH net 5/5] net/mlx5e: Fix loopback selftest

opback test SKB, which will be validated on xmit as well, and we don't want that. Tested with: ethtool -t ethX validated that the loopback test passes. Fixes: 0952da791c97 ('net/mlx5e: Add support for loopback selftest') Signed-off-by: Eugenia Emantayev <euge...@mellanox.com> Signed-off-by: Sa

<    8   9   10   11   12   13   14   15   16   17   >