[PATCH net-next V2 01/10] net/mlx5: Store counters in rbtree instead of list

2016-07-14 Thread Saeed Mahameed
From: Amir Vadai <a...@vadai.me> In order to use bulk counters, we need to have counters sorted by id. Signed-off-by: Amir Vadai <a...@vadai.me> Reviewed-by: Or Gerlitz <ogerl...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/eth

[PATCH net-next V2 02/10] net/mlx5: Introduce bulk reading of flow counters

2016-07-14 Thread Saeed Mahameed
.me> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/fs_cmd.c | 67 + drivers/net/ethernet/mellanox/mlx5/core/fs_cmd.h | 12 .../net/ethernet/mellanox/mlx5/core/fs_counters.c | 83 -- inclu

[PATCH net-next V2 05/10] net/mlx5: E-Switch, Add API to configure rules for the offloaded mode

2016-07-14 Thread Saeed Mahameed
m> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/eswitch.h | 6 +++ .../ethernet/mellanox/mlx5/core/eswitch_offloads.c | 43 ++ 2 files changed, 49 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/es

[PATCH net-next V2 03/10] net/mlx5e: Offload TC flow counters only when supported

2016-07-14 Thread Saeed Mahameed
erlitz <ogerl...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox

[PATCH net-next V2 07/10] net/switchdev: Export the same parent ID service function

2016-07-14 Thread Saeed Mahameed
From: Or Gerlitz <ogerl...@mellanox.com> This helper serves to know if two switchdev port netdevices belong to the same HW ASIC, e.g to figure out if forwarding offload is possible between them. Signed-off-by: Or Gerlitz <ogerl...@mellanox.com> Signed-off-by: Saeed Mahameed <sae.

[PATCH net-next V2 08/10] net/mlx5e: Add TC drop and mirred/redirect action parsing for SRIOV offloads

2016-07-14 Thread Saeed Mahameed
Signed-off-by: Or Gerlitz <ogerl...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 53 + 1 file changed, 53 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/dr

[PATCH net-next V2 04/10] net/mlx5: E-Switch, Use two priorities for SRIOV offloads mode

2016-07-14 Thread Saeed Mahameed
; Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/eswitch.h | 1 + .../ethernet/mellanox/mlx5/core/eswitch_offloads.c | 34 +- drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 22 +- 3 files changed, 42 insertion

[PATCH net-next V2 10/10] net/mlx5e: Add TC offload support for the VF representors netdevice

2016-07-14 Thread Saeed Mahameed
From: Or Gerlitz <ogerl...@mellanox.com> The VF representors support only TC filter/action offloads (not mqprio) and this is enabled for them by default. Signed-off-by: Or Gerlitz <ogerl...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethe

[PATCH net-next V2 09/10] net/mlx5e: Add TC HW support for FDB (SRIOV e-switch) offloads

2016-07-14 Thread Saeed Mahameed
<ogerl...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 5 drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 35 2 files changed, 34 insertions(+), 6 deletions(-) diff --git a/drivers/net

[PATCH net-next V2 06/10] net/mlx5e: Adjustments in the TC offload code towards reuse for SRIOV

2016-07-14 Thread Saeed Mahameed
he use-case in downstream patch. Signed-off-by: Or Gerlitz <ogerl...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 32 - 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/dr

[PATCH net-next V2 00/10] Mellanox 100G mlx5 Bulk flow statistics and SRIOV TC offloads

2016-07-14 Thread Saeed Mahameed
Hi Dave, This series from Amir and Or deals with two enhancements for the mlx5 TC offloads. The 1st two patches add bulk reading of flow counters. Few bulk counter queries are used instead of issuing thousands firmware commands per second to get statistics of all flows set to HW. The next

Re: mlx5 PF and VF Vlan Restrictions

2016-07-14 Thread Saeed Mahameed
On Thu, Jul 14, 2016 at 11:27 AM, domingo montoya wrote: > Hello, > > Can we have VLAN restrictions at both PF and VF level in mlx5 CX4 driver? > > For a particular VF, I would like to restrict VLANs from the PF driver > > For e.g, Let's say there is VF0. I would

[PATCH net V2] net/mlx5e: Fix del vxlan port command buffer memset

2016-07-20 Thread Saeed Mahameed
memset the command buffers rather than the pointers to them. Fixes: b3f63c3d5e2c ("net/mlx5e: Add netdev support for VXLAN tunneling") Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- V2: - Improved log message. drivers/net/ethernet/mellanox/mlx5/core/vxlan.c | 4 ++--

[PATCH net-next 0/2] Mellanox 100G mlx5 minimum inline header mode

2016-07-20 Thread Saeed Mahameed
Hi Dave, This small series from Hadar adds the support for minimum inline header mode query in mlx5e NIC driver. Today on TX the driver copies to the HW descriptor only up to L2 header which is the default required mode and sufficient for today's needs. The header in the HW descriptor is used

[PATCH net-next 2/2] net/mlx5e: Query minimum required header copy during xmit

2016-07-20 Thread Saeed Mahameed
ellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 7 +++ drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 24 +++ drivers/net/ethernet/mellanox/mlx5/core/vport.c | 18 + i

[PATCH net-next 1/2] net/mlx5e: Check the minimum inline header mode before xmit

2016-07-20 Thread Saeed Mahameed
; Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en.h| 1 + drivers/net/ethernet/mellanox/mlx5/core/en_tx.c | 49 +++-- include/linux/mlx5/device.h | 7 3 files changed, 53 insertions(+), 4

Re: [PATCH net V2] net/mlx5e: Fix del vxlan port command buffer memset

2016-07-21 Thread Saeed Mahameed
On Thu, Jul 21, 2016 at 3:53 AM, Alexei Starovoitov <alexei.starovoi...@gmail.com> wrote: > On Thu, Jul 21, 2016 at 12:39:53AM +0300, Saeed Mahameed wrote: >> memset the command buffers rather than the pointers to them. > > that is still wrong commit log. > This pat

[PATCH net V2] net/bonding: Enforce active-backup policy for IPoIB bonds

2016-07-21 Thread Saeed Mahameed
ned-off-by: Mark Bloch <ma...@mellanox.com> Signed-off-by: Or Gerlitz <ogerl...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- Changes from v0: - Set res to -EOPNOTSUPP before jumping to err_undo_flags. drivers/net/bonding/bond_main.c | 11 ++- 1 file changed,

Re: [PATCH net-next 2/2] net/mlx5e: Query minimum required header copy during xmit

2016-07-21 Thread Saeed Mahameed
On Thu, Jul 21, 2016 at 8:15 AM, Alexei Starovoitov <alexei.starovoi...@gmail.com> wrote: > On Thu, Jul 21, 2016 at 01:20:02AM +0300, Saeed Mahameed wrote: >> From: Hadar Hen Zion <had...@mellanox.com> >> >> Add support for query the minimum inline mode fro

Re: [PATCH net-next 2/2] net/mlx5e: Query minimum required header copy during xmit

2016-07-21 Thread Saeed Mahameed
On Thu, Jul 21, 2016 at 7:15 PM, David Miller <da...@davemloft.net> wrote: > From: Saeed Mahameed <sae...@dev.mellanox.co.il> > Date: Thu, 21 Jul 2016 11:22:32 +0300 > >> On Thu, Jul 21, 2016 at 8:15 AM, Alexei Starovoitov >> <alexei.starovoi...@gmail.com> w

[PATCH net] net/bonding: Enforce active-backup policy for IPoIB bonds

2016-07-20 Thread Saeed Mahameed
ned-off-by: Mark Bloch <ma...@mellanox.com> Signed-off-by: Or Gerlitz <ogerl...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/bonding/bond_main.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/net/bonding/bond_main.c b/d

[PATCH net] net/mlx5e: Fix del vxlan port command

2016-07-20 Thread Saeed Mahameed
mlx5e_vxlan_core_del_port_cmd cleared the wrong address, the address of the pointer of the buffer rather than clearing the buffer itself. This can lead to a serious stack corruption. Fixes: b3f63c3d5e2c ("net/mlx5e: Add netdev support for VXLAN tunneling") Signed-off-by: Saeed Mah

Re: [PATCH net] net/mlx5e: Fix del vxlan port command

2016-07-20 Thread Saeed Mahameed
On Wed, Jul 20, 2016 at 7:15 PM, Alexei Starovoitov <alexei.starovoi...@gmail.com> wrote: > On Wed, Jul 20, 2016 at 05:48:48PM +0300, Saeed Mahameed wrote: >> mlx5e_vxlan_core_del_port_cmd cleared the wrong address, the address of >> the pointer of the buffer rather than clear

[PATCH net 5/7] net/mlx5e: Prevent adding the same vxlan port

2016-06-27 Thread Saeed Mahameed
From: Matthew Finlay <m...@mellanox.com> Do not allow the same vxlan udp port to be added to the device more than once. Fixes: b3f63c3d5e2c ("net/mlx5e: Add netdev support for VXLAN tunneling") Signed-off-by: Matthew Finlay <m...@mellanox.com> Signed-off-by: Saeed Mahamee

[PATCH net 7/7] net/mlx5e: Reorganize ethtool statistics

2016-06-27 Thread Saeed Mahameed
g...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- .../net/ethernet/mellanox/mlx5/core/en_ethtool.c | 30 ++- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 27 ++- drivers/net/ethernet/mellanox/mlx5/core/en_rx.c| 4 +- drivers/net/ethern

[PATCH net 6/7] net/mlx5e: Fix number of PFC counters reported to ethtool

2016-06-27 Thread Saeed Mahameed
group to PPort counters') Signed-off-by: Gal Pressman <g...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5

[PATCH net 3/7] net/mlx5e: Change enum to better reflect usage

2016-06-27 Thread Saeed Mahameed
hen <e...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 2 +- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/mellanox

[PATCH net 1/7] net/mlx5: Update command strings

2016-06-27 Thread Saeed Mahameed
From: Eli Cohen <e...@mellanox.com> Add command string for MODIFY_FLOW_TABLE which is used by the driver. Signed-off-by: Eli Cohen <e...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/cmd.c | 1 + 1 file ch

[PATCH net 4/7] net/mlx5e: Check for BlueFlame capability before allocating SQ uar

2016-06-27 Thread Saeed Mahameed
From: Gal Pressman <g...@mellanox.com> Previous to this patch mapping was always set to write combining without checking whether BlueFlame is supported in the device. Fixes: 0ba422410bbf ('net/mlx5: Fix global UAR mapping') Signed-off-by: Gal Pressman <g...@mellanox.com> Signed-o

[PATCH net 0/7] Mellanox 100G mlx5 fixes#2 for 4.7-rc

2016-06-27 Thread Saeed Mahameed
Hi Dave, The following series provides one-liners fixes for mlx5 driver plus one medium patch to reorganize ethtool counters reporting. Highlights: - Added MODIFY_FLOW_TABLE to command strings table - Add ConnectX-5 PCIe 4.0 to list of supported devices - Rename

[PATCH net 2/7] net/mlx5: Add ConnectX-5 PCIe 4.0 to list of supported devices

2016-06-27 Thread Saeed Mahameed
From: Majd Dibbiny <m...@mellanox.com> Add the upcoming ConnectX-5 PCIe 4.0 device to the list of supported devices by the mlx5 driver. Signed-off-by: Majd Dibbiny <m...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/ml

Re: mlx5 SRIOV VLAN support

2016-07-05 Thread Saeed Mahameed
On Tue, Jul 5, 2016 at 10:37 AM, domingo montoya wrote: > Hi, > > Is VLAN supported in SRIOV mode for mlx5? > For VGT mode vlan is supported by default same as bare-metal. For VST you need to use ip tool to configure VST vlan: ip link set eth vf 1 vlan 2 qos 2

[PATCH net] bonding: fix enslavement slave link notifications

2016-07-05 Thread Saeed Mahameed
ink_state() ignoring this transition. This patch sets the default value of slave->link to BOND_LINK_NOCHANGE, assuring it will count as a state transition and thus trigger notification logic. Signed-off-by: Aviv Heller <av...@mellanox.com> Reviewed-by: Jiri Pirko <j...@mellanox.com&

Re: mlx5 SRIOV VLAN support

2016-07-05 Thread Saeed Mahameed
ULT qlen 1000 > link/ether e4:1d:2d:c9:c8:9a brd ff:ff:ff:ff:ff:ff > > # ethtool -k enp1s0f0 > Features for enp1s0f0: [...] > rx-vlan-filter: on I was basically looking for this and it looks ok. > > > > > On Tue, Jul 5, 2016 at 1:41 PM, Saeed Mahameed > <sa

Re: [PATCH] net/mlx5: Avoid setting unused var when modifying vport node GUID

2016-07-05 Thread Saeed Mahameed
On Tue, Jul 5, 2016 at 12:17 PM, Or Gerlitz <ogerl...@mellanox.com> wrote: > GCC complains on unused-but-set-variable, clean this up. > > Fixes: 23898c763f4a ('net/mlx5: E-Switch, Modify node guid on vf set MAC') > Signed-off-by: Or Gerlitz <ogerl...@mellanox.com> Acked

Re: [PATCH v6 05/12] Add sample for adding simple drop program to link

2016-07-09 Thread Saeed Mahameed
On Fri, Jul 8, 2016 at 5:15 AM, Brenden Blanco wrote: > Add a sample program that only drops packets at the BPF_PROG_TYPE_XDP_RX > hook of a link. With the drop-only program, observed single core rate is > ~20Mpps. > > Other tests were run, for instance without the dropcnt

Re: [PATCH v6 04/12] net/mlx4_en: add support for fast rx drop bpf program

2016-07-09 Thread Saeed Mahameed
On Fri, Jul 8, 2016 at 5:15 AM, Brenden Blanco wrote: > Add support for the BPF_PROG_TYPE_XDP hook in mlx4 driver. > > In tc/socket bpf programs, helpers linearize skb fragments as needed > when the program touchs the packet data. However, in the pursuit of > speed, XDP

Re: [PATCH v6 04/12] net/mlx4_en: add support for fast rx drop bpf program

2016-07-11 Thread Saeed Mahameed
On Sun, Jul 10, 2016 at 7:05 PM, Brenden Blanco <bbla...@plumgrid.com> wrote: > On Sun, Jul 10, 2016 at 06:25:40PM +0300, Tariq Toukan wrote: >> >> On 09/07/2016 10:58 PM, Saeed Mahameed wrote: >> >On Fri, Jul 8, 2016 at 5:15 AM, Brenden Blanc

[PATCH net-next 3/8] net/mlx5: Properly remove all steering objects

2016-07-04 Thread Saeed Mahameed
From: Maor Gottlieb <ma...@mellanox.com> Instead of explicitly cleaning up the well known parts of the steering tree, we use the generic tree structure to traverse for cleanup. No functional changes. Signed-off-by: Maor Gottlieb <ma...@mellanox.com> Signed-off-by: Saeed M

[PATCH net-next 2/8] net/mlx5: Introduce mlx5_flow_steering structure

2016-07-04 Thread Saeed Mahameed
From: Maor Gottlieb <ma...@mellanox.com> Instead of having all steering private name spaces and steering module fields flat in mlx5_core_priv, we wrap them in mlx5_flow_steering for better modularity and API exposure. Signed-off-by: Maor Gottlieb <ma...@mellanox.com> Signed-o

[PATCH net-next 5/8] net/mlx5e: Support l3/l4 flow type specs in ethtool flow steering

2016-07-04 Thread Saeed Mahameed
: Maor Gottlieb <ma...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 2 + .../ethernet/mellanox/mlx5/core/en_fs_ethtool.c| 161 - drivers/net/ethernet/mellanox/mlx5/core/fs_core.c

[PATCH net-next 8/8] net/mlx5e: Expose flow control counters to ethtool

2016-07-04 Thread Saeed Mahameed
From: Gal Pressman <g...@mellanox.com> Just like per prio counters, the global flow counters are queried from per priority counters register. Global flow control counters are stored in priority 0 PFC counters. Signed-off-by: Gal Pressman <g...@mellanox.com> Signed-off-by: Saeed M

[PATCH net-next 7/8] net/mlx5e: Expose RDMA VPort counters to ethtool

2016-07-04 Thread Saeed Mahameed
From: Gal Pressman <g...@mellanox.com> Add the needed descriptors to expose RoCE RDMA counters. Signed-off-by: Gal Pressman <g...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_stats.h | 16

[PATCH net-next 4/8] net/mlx5e: Add ethtool flow steering support

2016-07-04 Thread Saeed Mahameed
lanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/Makefile | 2 +- drivers/net/ethernet/mellanox/mlx5/core/en.h | 20 ++ .../net/ethernet/mellanox/mlx5/core/en_ethtool.c | 21 ++ drivers/net/ethernet/mellanox/mlx5/cor

[PATCH net-next 6/8] net/mlx5e: Add support to get ethtool flow rules

2016-07-04 Thread Saeed Mahameed
From: Maor Gottlieb <ma...@mellanox.com> Enhance the existing get_rxnfc callback: 1. Get flow rule of specific ID. 2. Get all flow rules. 3. Get number of rules. Signed-off-by: Maor Gottlieb <ma...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- dr

[PATCH net-next 1/8] net/mlx5: Refactor mlx5_add_flow_rule

2016-07-04 Thread Saeed Mahameed
From: Maor Gottlieb <ma...@mellanox.com> Reduce the set of arguments passed to mlx5_add_flow_rule by introducing flow_spec structure. Signed-off-by: Maor Gottlieb <ma...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/infinib

[PATCH net-next 0/8] Mellanox 100G mlx5 ethtool ntuple steering

2016-07-04 Thread Saeed Mahameed
Hi Dave, This series adds Ethernet ethtool ntuple steering 'ethtool -N|U' and exposes two more counter sets to Ethtool statistics, RDMA vport and global flow control statistics. We start from three refactoring patches of the flow steering infrastructure - mlx5_add_flow_rule will now

[PATCH net] net: poll tx timeout only on active tx queues

2016-06-30 Thread Saeed Mahameed
queue aware tests throughout.') Signed-off-by: Mohamad Haj Yahia <moha...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- net/sched/sch_generic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sched/sch_generic.c b/net/sched/sch_generic.c inde

[PATCH net 09/13] net/mlx5e: Handle RQ flush in error cases

2016-06-30 Thread Saeed Mahameed
posted receive resources when closing the RQ. Fixes: f62b8bb8f2d3 ('net/mlx5: Extend mlx5_core to support ConnectX-4 Ethernet functionality') Signed-off-by: Daniel Jurgens <dani...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mella

[PATCH net 10/13] net/mlx5e: Copy all L2 headers into inline segment

2016-06-30 Thread Saeed Mahameed
Fixes: e586b3b0baee ("net/mlx5: Ethernet Datapath files") Signed-off-by: Matthew Finlay <m...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_tx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH net 12/13] net/mlx5e: Validate BW weight values of ETS

2016-06-30 Thread Saeed Mahameed
From: Rana Shahout <ra...@mellanox.com> Valid weight assigned to ETS TClass values are 1-100 Fixes: 08fb1dacdd76 ('net/mlx5e: Support DCBNL IEEE ETS') Signed-off-by: Rana Shahout <ra...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/

[PATCH net 04/13] net/mlx5: Fix wait_vital for VFs and remove fixed sleep

2016-06-30 Thread Saeed Mahameed
start incrementing. Also remove the 1s sleep at the beginning. fixes: 89d44f0a6c73 ('net/mlx5_core: Add pci error handlers to mlx5_core driver') Signed-off-by: Daniel Jurgens <dani...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx

[PATCH net 08/13] net/mlx5e: Implement ndo_tx_timeout callback

2016-06-30 Thread Saeed Mahameed
From: Daniel Jurgens <dani...@mellanox.com> Add callback to handle TX timeouts. Fixes: f62b8bb8f2d3 ('net/mlx5: Extend mlx5_core to support ConnectX-4 Ethernet functionality') Signed-off-by: Daniel Jurgens <dani...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.co

[PATCH net 00/13] Mellanox 100G mlx5 resiliency and xmit path fixes

2016-06-30 Thread Saeed Mahameed
Hi Dave, This series provides two set of fixes to the mlx5 driver: - Resiliency fixes for reset flow and internal pci errors - xmit path fixes Please consider queuing those patches for -stable (4.6). Reset flow fixes for core driver: - Add more commands to the list of

[PATCH net 11/13] net/mlx5e: Fix select queue callback

2016-06-30 Thread Saeed Mahameed
fallback result and normalize it to the desired range. Fixes: 08fb1dacdd76 ('net/mlx5e: Support DCBNL IEEE ETS') Signed-off-by: Rana Shahout <ra...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Reported-by: Doug Ledford <dledf...@redhat.com> --- drivers/net/ethernet/

[PATCH net 06/13] net/mlx5: Add timeout handle to commands with callback

2016-06-30 Thread Saeed Mahameed
<moha...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/cmd.c | 38 ++- include/linux/mlx5/driver.h | 1 + 2 files changed, 32 insertions(+), 7 deletions(-) diff --git a/drivers/net

[PATCH net 03/13] net/mlx5: Fix incorrect page count when in internal error

2016-06-30 Thread Saeed Mahameed
error handlers to mlx5_core driver') Signed-off-by: Daniel Jurgens <dani...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- .../net/ethernet/mellanox/mlx5/core/pagealloc.c| 63 +++--- 1 file changed, 44 insertions(+), 19 deletions(-) diff -

[PATCH net 02/13] net/mlx5: Avoid calling sleeping function by the health poll thread

2016-06-30 Thread Saeed Mahameed
th dev->intf_state_lock Fixes: 89d44f0a6c73 ('net/mlx5_core: Add pci error handlers to mlx5_core driver') Signed-off-by: Mohamad Haj Yahia <moha...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/health.c | 11 -

[PATCH net 05/13] net/mlx5: Fix potential deadlock in command mode change

2016-06-30 Thread Saeed Mahameed
ect-IB adapters') Signed-off-by: Mohamad Haj Yahia <moha...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/cmd.c | 79 +++ 1 file changed, 33 insertions(+), 46 deletions(-) diff --git a/drivers/net

Re: [PATCH net] net: poll tx timeout only on active tx queues

2016-06-30 Thread Saeed Mahameed
On Thu, Jun 30, 2016 at 5:28 PM, Eric Dumazet <eric.duma...@gmail.com> wrote: > On Thu, 2016-06-30 at 16:58 +0300, Saeed Mahameed wrote: >> - for (i = 0; i < dev->num_tx_queues; i++) { >> + for (i = 0; i &

[PATCH net 07/13] net/mlx5e: Timeout if SQ doesn't flush during close

2016-06-30 Thread Saeed Mahameed
<dani...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 2 ++ drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 25 +++--- drivers/net/ethernet/mellanox/mlx5/core/en_tx.c | 32 ++

[PATCH net 13/13] net/mlx5e: Log link state changes

2016-06-30 Thread Saeed Mahameed
From: Shaker Daibes <shak...@mellanox.com> Add Link UP/Down prints to kernel log when link state changes Signed-off-by: Shaker Daibes <shak...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 7 +--

[PATCH net 01/13] net/mlx5: Fix teardown errors that happen in pci error handler

2016-06-30 Thread Saeed Mahameed
memory leaks that happen because we skip teardown stages due to failed fw commands. Fixes: 89d44f0a6c73 ('net/mlx5_core: Add pci error handlers to mlx5_core driver') Signed-off-by: Mohamad Haj Yahia <moha...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- dr

[PATCH net-next V2 12/16] net/mlx5e: TIRs management refactoring

2016-06-30 Thread Saeed Mahameed
n <had...@mellanox.com> Reviewed-by: Or Gerlitz <ogerl...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 12 +++-- drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c | 14 +++--- .../net/ethernet/mellanox/mlx5/

[PATCH net-next V2 05/16] net/mlx5: Introduce offloads steering namespace

2016-06-30 Thread Saeed Mahameed
; Signed-off-by: Amir Vadai <a...@vadai.me> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 11 ++- include/linux/mlx5/fs.h | 1 + 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/drive

[PATCH net-next V2 13/16] net/mlx5e: Mark enabled RQTs instances explicitly

2016-06-30 Thread Saeed Mahameed
ity. Signed-off-by: Hadar Hen Zion <had...@mellanox.com> Reviewed-by: Or Gerlitz <ogerl...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 13 +-- .../net/ethernet/mellanox/mlx5/core/en_ethtool.c

[PATCH net-next V2 03/16] net/mlx5: E-Switch, Add miss rule for offloads mode

2016-06-30 Thread Saeed Mahameed
s the HW to send the packet to vport 0 where the e-switch manager runs. Signed-off-by: Or Gerlitz <ogerl...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/eswitch.h | 1 + .../ethernet/mellanox/mlx5/

[PATCH net-next V2 16/16] net/mlx5e: Introduce SRIOV VF representors

2016-06-30 Thread Saeed Mahameed
r{phys_port_name}" where phys_switch_id is exposed by the PF (and VF reps) and $PF_NIC is the name of the PF netdevice. Signed-off-by: Hadar Hen Zion <had...@mellanox.com> Signed-off-by: Or Gerlitz <ogerl...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> ---

[PATCH net-next V2 15/16] net/mlx5: Add Representors registration API

2016-06-30 Thread Saeed Mahameed
Switch database that will hold the vport represntors upon creation. This patch doesn't add any new functionality. Signed-off-by: Hadar Hen Zion <had...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 3 +- drivers/net

[PATCH net-next V2 14/16] net/mlx5e: Add support for multiple profiles

2016-06-30 Thread Saeed Mahameed
ny new functionality. Signed-off-by: Hadar Hen Zion <had...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 17 ++ drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 341 ++ 2 files chang

[PATCH net-next V2 10/16] net/mlx5e: Add devlink based SRIOV mode changes

2016-06-30 Thread Saeed Mahameed
urning to legacy mode, we remove the VF reps and the offloads table, and re-initiate the e-switch in it's legacy mode. The actual creation/removal of the VF reps is done in downstream patches. Signed-off-by: Or Gerlitz <ogerl...@mellanox.com> Signed-off-by: Saeed Mahameed <sae.

[PATCH net-next V2 08/16] net/devlink: Add E-Switch mode control

2016-06-30 Thread Saeed Mahameed
sing standard tools such as tc, bridge, openvswitch etc. To allow working with the tools, for each VF, a VF representor netdevice is created by the E-Switch manager vendor device driver instance (e.g PF). Signed-off-by: Or Gerlitz <ogerl...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@me

[PATCH net-next V2 04/16] net/mlx5: E-Switch, Add API to create send-to-vport rules

2016-06-30 Thread Saeed Mahameed
llanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/eswitch.h | 3 +- .../ethernet/mellanox/mlx5/core/eswitch_offloads.c | 39 ++ 2 files changed, 41 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethern

[PATCH net-next V2 07/16] net/mlx5: E-Switch, Add API to create vport rx rules

2016-06-30 Thread Saeed Mahameed
nd should be received into the host OS through the netdevice that represents the VF they were sent from. Signed-off-by: Or Gerlitz <ogerl...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/eswitch.h | 4 + .../ethern

[PATCH net-next V2 11/16] net/mlx5e: Create NIC global resources only once

2016-06-30 Thread Saeed Mahameed
nox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/Makefile | 6 +- drivers/net/ethernet/mellanox/mlx5/core/en.h | 6 +- .../net/ethernet/mellanox/mlx5/core/en_common.c| 112 +++ drivers/net/ethernet/mell

Re: [PATCH net 08/13] net/mlx5e: Implement ndo_tx_timeout callback

2016-06-30 Thread Saeed Mahameed
On Thu, Jun 30, 2016 at 6:15 PM, Yuval Mintz wrote: >> Add callback to handle TX timeouts. >> >> Fixes: f62b8bb8f2d3 ('net/mlx5: Extend mlx5_core to support ConnectX-4 >> Ethernet functionality') > > Not that I mind, but does implementing ndo_tx_timeout actually counts as

[PATCH net-next V2 06/16] net/mlx5: E-Switch, Add offloads table

2016-06-30 Thread Saeed Mahameed
From: Or Gerlitz <ogerl...@mellanox.com> Belongs to the NIC offloads name-space, and to be used as part of the SRIOV offloads logic to steer packets that hit the e-switch miss rule to the TIR of the relevant VF representor. Signed-off-by: Or Gerlitz <ogerl...@mellanox.com> Signed-o

[PATCH net-next V2 09/16] net/mlx5: Add devlink interface

2016-06-30 Thread Saeed Mahameed
From: Or Gerlitz <ogerl...@mellanox.com> The devlink interface is initially used to set/get the mode of the SRIOV e-switch. Currently, these are only stubs for get/set, down-stream patch will actually fill them out. Signed-off-by: Or Gerlitz <ogerl...@mellanox.com> Signed-o

[PATCH net-next V2 02/16] net/mlx5: E-Switch, Add support for the sriov offloads mode

2016-06-30 Thread Saeed Mahameed
ackets toward the e-switch manager. Further logic will trap these packets such that the receiving net-device as seen by the networking stack is the representor of the vport that sent the packet over the e-switch data-path. Signed-off-by: Or Gerlitz <ogerl...@mellanox.com> Signed-off-by: Saeed M

[PATCH net-next V2 01/16] net/mlx5: E-Switch, Add operational mode to the SRIOV e-Switch

2016-06-30 Thread Saeed Mahameed
where steering rules are of the form: destination mac --> VF vport This patch does not change any functionality. Signed-off-by: Or Gerlitz <ogerl...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx

[PATCH net-next V2 00/16] Mellanox 100G SRIOV E-Switch offload and VF representors

2016-06-30 Thread Saeed Mahameed
+ solution (software and firmware) work were done by a team consisting of Ilya Lesokhin, Haggai Eran, Rony Efraim, Tal Anker, Natan Oppenheimer, Saeed Mahameed, Hadar and Or, thanks you all! v1 --> v2 fixes: * removed unneeded variable (patch #3) * removed unused value DEVLINK_ESWITCH_MODE

[PATCH net-next V3 13/16] net/mlx5e: Mark enabled RQTs instances explicitly

2016-07-01 Thread Saeed Mahameed
ity. Signed-off-by: Hadar Hen Zion <had...@mellanox.com> Reviewed-by: Or Gerlitz <ogerl...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 13 +-- .../net/ethernet/mellanox/mlx5/core/en_ethtool.c

[PATCH net-next V3 12/16] net/mlx5e: TIRs management refactoring

2016-07-01 Thread Saeed Mahameed
n <had...@mellanox.com> Reviewed-by: Or Gerlitz <ogerl...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 12 +++-- drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c | 14 +++--- .../net/ethernet/mellanox/mlx5/

[PATCH net-next V3 15/16] net/mlx5: Add Representors registration API

2016-07-01 Thread Saeed Mahameed
Switch database that will hold the vport represntors upon creation. This patch doesn't add any new functionality. Signed-off-by: Hadar Hen Zion <had...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 3 +- drivers/net

Re: [PATCH net] net: poll tx timeout only on active tx queues

2016-07-01 Thread Saeed Mahameed
On Fri, Jul 1, 2016 at 8:18 AM, Eric Dumazet wrote: > On Fri, 2016-07-01 at 04:50 +, Yuval Mintz wrote: >> > currently all the device driver call netif_tx_start_all_queues(dev) >> > on open to W/A this issue. which is strange since only >> > real_num_tx_queues are

[PATCH net-next V3 04/16] net/mlx5: E-Switch, Add API to create send-to-vport rules

2016-07-01 Thread Saeed Mahameed
llanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/eswitch.h | 3 +- .../ethernet/mellanox/mlx5/core/eswitch_offloads.c | 39 ++ 2 files changed, 41 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethern

[PATCH net-next V3 01/16] net/mlx5: E-Switch, Add operational mode to the SRIOV e-Switch

2016-07-01 Thread Saeed Mahameed
where steering rules are of the form: destination mac --> VF vport This patch does not change any functionality. Signed-off-by: Or Gerlitz <ogerl...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx

[PATCH net-next V3 00/16] Mellanox 100G SRIOV E-Switch offload and VF representors

2016-07-01 Thread Saeed Mahameed
+ solution (software and firmware) work were done by a team consisting of Ilya Lesokhin, Haggai Eran, Rony Efraim, Tal Anker, Natan Oppenheimer, Saeed Mahameed, Hadar and Or, thanks you all! v1 --> v2 fixes: * removed unneeded variable (patch #3) * removed unused value DEVLINK_ESWITCH_MODE

[PATCH net-next V3 03/16] net/mlx5: E-Switch, Add miss rule for offloads mode

2016-07-01 Thread Saeed Mahameed
s the HW to send the packet to vport 0 where the e-switch manager runs. Signed-off-by: Or Gerlitz <ogerl...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/eswitch.h | 1 + .../ethernet/mellanox/mlx5/

[PATCH net-next V3 11/16] net/mlx5e: Create NIC global resources only once

2016-07-01 Thread Saeed Mahameed
nox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/Makefile | 6 +- drivers/net/ethernet/mellanox/mlx5/core/en.h | 6 +- .../net/ethernet/mellanox/mlx5/core/en_common.c| 112 +++ drivers/net/ethernet/mell

[PATCH net-next V3 09/16] net/mlx5: Add devlink interface

2016-07-01 Thread Saeed Mahameed
From: Or Gerlitz <ogerl...@mellanox.com> The devlink interface is initially used to set/get the mode of the SRIOV e-switch. Currently, these are only stubs for get/set, down-stream patch will actually fill them out. Signed-off-by: Or Gerlitz <ogerl...@mellanox.com> Signed-o

[PATCH net-next V3 02/16] net/mlx5: E-Switch, Add support for the sriov offloads mode

2016-07-01 Thread Saeed Mahameed
ackets toward the e-switch manager. Further logic will trap these packets such that the receiving net-device as seen by the networking stack is the representor of the vport that sent the packet over the e-switch data-path. Signed-off-by: Or Gerlitz <ogerl...@mellanox.com> Signed-off-by: Saeed M

[PATCH net-next V3 08/16] net/devlink: Add E-Switch mode control

2016-07-01 Thread Saeed Mahameed
sing standard tools such as tc, bridge, openvswitch etc. To allow working with the tools, for each VF, a VF representor netdevice is created by the E-Switch manager vendor device driver instance (e.g PF). Signed-off-by: Or Gerlitz <ogerl...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@me

[PATCH net-next V3 16/16] net/mlx5e: Introduce SRIOV VF representors

2016-07-01 Thread Saeed Mahameed
r{phys_port_name}" where phys_switch_id is exposed by the PF (and VF reps) and $PF_NIC is the name of the PF netdevice. Signed-off-by: Hadar Hen Zion <had...@mellanox.com> Signed-off-by: Or Gerlitz <ogerl...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> ---

[PATCH net-next V3 14/16] net/mlx5e: Add support for multiple profiles

2016-07-01 Thread Saeed Mahameed
ny new functionality. Signed-off-by: Hadar Hen Zion <had...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 17 ++ drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 341 ++ 2 files chang

[PATCH net-next V3 07/16] net/mlx5: E-Switch, Add API to create vport rx rules

2016-07-01 Thread Saeed Mahameed
nd should be received into the host OS through the netdevice that represents the VF they were sent from. Signed-off-by: Or Gerlitz <ogerl...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/eswitch.h | 4 + .../ethern

[PATCH net-next V3 06/16] net/mlx5: E-Switch, Add offloads table

2016-07-01 Thread Saeed Mahameed
From: Or Gerlitz <ogerl...@mellanox.com> Belongs to the NIC offloads name-space, and to be used as part of the SRIOV offloads logic to steer packets that hit the e-switch miss rule to the TIR of the relevant VF representor. Signed-off-by: Or Gerlitz <ogerl...@mellanox.com> Signed-o

[PATCH net-next V3 05/16] net/mlx5: Introduce offloads steering namespace

2016-07-01 Thread Saeed Mahameed
; Signed-off-by: Amir Vadai <a...@vadai.me> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 11 ++- include/linux/mlx5/fs.h | 1 + 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/drive

[PATCH net-next V3 10/16] net/mlx5e: Add devlink based SRIOV mode changes

2016-07-01 Thread Saeed Mahameed
urning to legacy mode, we remove the VF reps and the offloads table, and re-initiate the e-switch in it's legacy mode. The actual creation/removal of the VF reps is done in downstream patches. Signed-off-by: Or Gerlitz <ogerl...@mellanox.com> Signed-off-by: Saeed Mahameed <sae.

Re: [PATCH net 00/13] Mellanox 100G mlx5 resiliency and xmit path fixes

2016-07-01 Thread Saeed Mahameed
On Fri, Jul 1, 2016 at 1:14 PM, David Miller <da...@davemloft.net> wrote: > From: Saeed Mahameed <sae...@mellanox.com> > Date: Thu, 30 Jun 2016 17:34:37 +0300 > >> This series provides two set of fixes to the mlx5 driver: >> - Resiliency fixes for r

<    1   2   3   4   5   6   7   8   9   10   >