[PATCH RFC 08/11] net/mlx5e: XDP fast RX drop bpf programs support

2016-09-07 Thread Saeed Mahameed
nd it seems that XDP drop can handle more. Signed-off-by: Rana Shahout <ra...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 2 + drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 100 -

[PATCH RFC 05/11] net/mlx5e: Union RQ RX info per RQ type

2016-09-07 Thread Saeed Mahameed
the sizeof(struct mlx5e_rq), in this patch we define them as a union. Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 14 ++ drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 32 +++ drivers/net/ethernet/me

Re: [PATCH RFC 08/11] net/mlx5e: XDP fast RX drop bpf programs support

2016-09-07 Thread Saeed Mahameed
On Wed, Sep 7, 2016 at 4:32 PM, Or Gerlitz <gerlitz...@gmail.com> wrote: > On Wed, Sep 7, 2016 at 3:42 PM, Saeed Mahameed <sae...@mellanox.com> wrote: > >> Packet rate performance testing was done with pktgen 64B packets and on >> TX side and, TC drop action on RX

Re: [iovisor-dev] [PATCH RFC 11/11] net/mlx5e: XDP TX xmit more

2016-09-07 Thread Saeed Mahameed
On Wed, Sep 7, 2016 at 4:44 PM, John Fastabend via iovisor-dev <iovisor-...@lists.iovisor.org> wrote: > On 16-09-07 05:42 AM, Saeed Mahameed wrote: >> Previously we rang XDP SQ doorbell on every forwarded XDP packet. >> >> Here we introduce a xmit more like mechan

Re: [PATCH RFC 11/11] net/mlx5e: XDP TX xmit more

2016-09-07 Thread Saeed Mahameed
On Wed, Sep 7, 2016 at 5:41 PM, Eric Dumazet <eric.duma...@gmail.com> wrote: > On Wed, 2016-09-07 at 15:42 +0300, Saeed Mahameed wrote: >> Previously we rang XDP SQ doorbell on every forwarded XDP packet. >> >> Here we introduce a xmit more like mechanism that will queue

[PATCH net 2/5] net/mlx5e: Move an_disable_cap bit to a new position

2016-09-07 Thread Saeed Mahameed
is off, while newer firmware will allow this and it is indicated in the new capability location. Signed-off-by: Bodong Wang <bod...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- include/linux/mlx5/mlx5_ifc.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deleti

[PATCH net 3/5] net/mlx5e: Prevent casting overflow

2016-09-07 Thread Saeed Mahameed
t link ksettings API') Signed-off-by: Gal Pressman <g...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/co

[PATCH net 1/5] net/mlx5e: Fix xmit_more counter race issue

2016-09-07 Thread Saeed Mahameed
From: Tariq Toukan <tar...@mellanox.com> Update the xmit_more counter before notifying the HW, to prevent a possible use-after-free of the skb. Fixes: c8cf78fe100b ("net/mlx5e: Add ethtool counter for TX xmit_more") Signed-off-by: Tariq Toukan <tar...@mellanox.com> Signed-

[PATCH net 4/5] net/mlx5e: Fix global PFC counters replication

2016-09-07 Thread Saeed Mahameed
dex (i). Fixes: e989d5a532ce ('net/mlx5e: Expose flow control counters to ethtool') Signed-off-by: Gal Pressman <g...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

[PATCH net 0/5] Mellanox 100G mlx5 fixes 2016-09-07

2016-09-07 Thread Saeed Mahameed
Hi Dave, The following series contains bug fixes for the mlx5e driver. from Gal, - Static code checker cleanup (casting overflow) - Fix global PFC counter statistics reading - Fix HW LRO when vlan stripping is off >From Bodong, - Deprecate old autoneg capability

[PATCH net 5/5] net/mlx5e: Fix parsing of vlan packets when updating lro header

2016-09-07 Thread Saeed Mahameed
ipping is off). Fixes: e586b3b0baee ('net/mlx5: Ethernet Datapath files') Signed-off-by: Gal Pressman <g...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 22 +++--- 1 file changed, 15 insertions(+), 7

Re: [PATCH net-next V2 6/6] net/mlx5: Add handling for port module event

2016-09-07 Thread Saeed Mahameed
On Tue, Sep 6, 2016 at 7:15 PM, Joe Perches <j...@perches.com> wrote: > On Tue, 2016-09-06 at 19:04 +0300, Saeed Mahameed wrote: >> From: Huy Nguyen <h...@mellanox.com> > > [] > >> +void mlx5_port_module_event(struct mlx5_core_dev *dev, struct

Re: [iovisor-dev] [PATCH RFC 08/11] net/mlx5e: XDP fast RX drop bpf programs support

2016-09-07 Thread Saeed Mahameed
On Wed, Sep 7, 2016 at 11:55 PM, Or Gerlitz via iovisor-dev <iovisor-...@lists.iovisor.org> wrote: > On Wed, Sep 7, 2016 at 3:42 PM, Saeed Mahameed <sae...@mellanox.com> wrote: >> From: Rana Shahout <ra...@mellanox.com> >> >> Add support for the BPF_

Re: [PATCH net-next V2 0/6] Mellanox 100G mlx5 DCBX CEE and firmware support

2016-09-07 Thread Saeed Mahameed
On Tue, Sep 6, 2016 at 7:04 PM, Saeed Mahameed <sae...@mellanox.com> wrote: > Hi Dave, > Hi Dave, Sorry to bother, but i would like to drop this series for now Huy is working to define and come up with a better mechanism to enable/disable the new DCBX hybrid mode he is add

Re: [PATCH RFC 11/11] net/mlx5e: XDP TX xmit more

2016-09-07 Thread Saeed Mahameed
On Wed, Sep 7, 2016 at 9:19 PM, Eric Dumazet <eric.duma...@gmail.com> wrote: > On Wed, 2016-09-07 at 19:57 +0300, Saeed Mahameed wrote: > >> Jesper has a similar Idea to make the qdisc think it is under >> pressure, when the device >> TX ring is idle most of the t

Re: [PATCH RFC 11/11] net/mlx5e: XDP TX xmit more

2016-09-07 Thread Saeed Mahameed
On Wed, Sep 7, 2016 at 6:32 PM, Eric Dumazet <eric.duma...@gmail.com> wrote: > On Wed, 2016-09-07 at 18:08 +0300, Saeed Mahameed wrote: >> On Wed, Sep 7, 2016 at 5:41 PM, Eric Dumazet <eric.duma...@gmail.com> wrote: >> > On Wed, 2016-09-07 at 15:42 +0300, Saeed Maham

Re: [PATCH RFC 08/11] net/mlx5e: XDP fast RX drop bpf programs support

2016-09-07 Thread Saeed Mahameed
On Wed, Sep 7, 2016 at 7:54 PM, Tom Herbert <t...@herbertland.com> wrote: > On Wed, Sep 7, 2016 at 7:48 AM, Saeed Mahameed > <sae...@dev.mellanox.co.il> wrote: >> On Wed, Sep 7, 2016 at 4:32 PM, Or Gerlitz <gerlitz...@gmail.com> wrote: >>> On Wed, Sep

[PATCH net-next 5/6] net/mlx5e: Add DCBX control interface

2016-08-30 Thread Saeed Mahameed
DCBX is forced to firmware mode. Signed-off-by: Huy Nguyen <h...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 2 ++ drivers/net/ethernet/mellanox/mlx5/core/en_dcbnl.c | 24 - .../net/et

[PATCH net-next 6/6] net/mlx5: Add handling for port module event

2016-08-30 Thread Saeed Mahameed
From: Huy Nguyen <h...@mellanox.com> Add dmesg log for asynchronous port module event. Signed-off-by: Huy Nguyen <h...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/eq.c | 12 +++ .../net/ethernet/

[PATCH net-next 1/6] net/mlx5e: Support DCBX CEE API

2016-08-30 Thread Saeed Mahameed
verCX4 document section 6.4 Signed-off-by: Huy Nguyen <h...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 24 ++ drivers/net/ethernet/mellanox/mlx5/core/en_dcbnl.c | 301 - drivers/net/ethernet/

[PATCH net-next 2/6] net/mlx5e: Read ETS settings directly from firmware

2016-08-30 Thread Saeed Mahameed
switch. Signed-off-by: Huy Nguyen <h...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 6 ++-- drivers/net/ethernet/mellanox/mlx5/core/en_dcbnl.c | 35 ++ drivers/net/ethernet/mellanox/mlx5/co

[PATCH net-next 4/6] net/mlx5e: ConnectX-4 firmware support for DCBX

2016-08-30 Thread Saeed Mahameed
X back to host controlled mode. This patch sets up the infrastructure to support changing DCBX control mode. Signed-off-by: Huy Nguyen <h...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 6 + drivers/net/ethe

[PATCH net-next 0/6] Mellanox 100G mlx5 DCBX CEE and firmware support

2016-08-30 Thread Saeed Mahameed
Hi Dave, This series from Huy provides mlx5 DCBX updates to support DCBX CEE API and DCBX firmware/host modes support. 1st patch adds the support for CEE interfaces into mlx5 dcbnl_rtnl_ops. 2nd patch refactors ETS query to read ETS configuration directly from firmware rather than having a

[PATCH net-next 3/6] net/mlx5: Add DCBX firmware commands support

2016-08-30 Thread Saeed Mahameed
From: Huy Nguyen <h...@mellanox.com> Add set/query commands for DCBX_PARAM register Signed-off-by: Huy Nguyen <h...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/port.c | 22 ++ include/l

Re: [PATCH] net/mlx4_en: protect ring->xdp_prog with rcu_read_lock

2016-08-30 Thread Saeed Mahameed
On Mon, Aug 29, 2016 at 8:46 PM, Tom Herbert wrote: > On Mon, Aug 29, 2016 at 8:55 AM, Brenden Blanco wrote: >> On Mon, Aug 29, 2016 at 05:59:26PM +0300, Tariq Toukan wrote: >>> Hi Brenden, >>> >>> The solution direction should be XDP specific that

Re: [PATCH net-next 3/6] net/mlx5: Add DCBX firmware commands support

2016-08-31 Thread Saeed Mahameed
On Wed, Aug 31, 2016 at 2:24 PM, zhuyj wrote: > + u32 in[MLX5_ST_SZ_DW(dcbx_param)]; > + > + memset(in, 0, sizeof(in)); > > can we replace the above with "u32 in[MLX5_ST_SZ_DW(dcbx_param)] = {0};"? yes, we will change it in V2. Thanks.

[PATCH net-next 11/11] net/mlx5: Organize device list API in one place

2016-09-09 Thread Saeed Mahameed
From: Mohamad Haj Yahia <moha...@mellanox.com> Hide the exposed (external) mlx5_dev_list and mlx5_intf_mutex and expose an organized modular API to manage and manipulate mlx5 devices list. Signed-off-by: Mohamad Haj Yahia <moha...@mellanox.com> Signed-off-by: Saeed Mahameed <sae.

[PATCH net-next 09/11] net/mlx5e: Implement mlx5e interface attach/detach callbacks

2016-09-09 Thread Saeed Mahameed
bjects initialzing/destroying is kept in add/remove callbacks. Signed-off-by: Mohamad Haj Yahia <moha...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 7 +- drivers/net/ethernet/mellanox/mlx5/co

[PATCH net-next 03/11] net/mlx5: Introduce attach/detach to interface API

2016-09-09 Thread Saeed Mahameed
locate the hardware needed resources upon attach. Signed-off-by: Mohamad Haj Yahia <moha...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/main.c | 149 + include/linux/mlx5/driver.h| 2

[PATCH net-next 04/11] net/mlx5: Split the load/unload flow into hardware and software flows

2016-09-09 Thread Saeed Mahameed
ror do the unload/load flows without releasing the software objects. In this way we perserve the sw core state and it help us restoring old driver state after PCI error/shutdown. Signed-off-by: Mohamad Haj Yahia <moha...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com>

[PATCH net-next 07/11] net/mlx5: Align sriov/eswitch modules with the new load/unload flow.

2016-09-09 Thread Saeed Mahameed
From: Mohamad Haj Yahia <moha...@mellanox.com> Init/cleanup sriov/eswitch in the core software context init/cleanup flows. Attach/detach sriov/eswitch in the core load/unload flows. Signed-off-by: Mohamad Haj Yahia <moha...@mellanox.com> Signed-off-by: Saeed Mahameed <sae.

[PATCH net-next 06/11] net/mlx5: Implement eswitch attach/detach flows

2016-09-09 Thread Saeed Mahameed
n only handle eswitch software context allocation and destruction. Signed-off-by: Mohamad Haj Yahia <moha...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/eswitch.c | 24 --- drivers/net/ethernet/mellanox/m

[PATCH net-next 05/11] net/mlx5: Implement SRIOV attach/detach flows

2016-09-09 Thread Saeed Mahameed
leanup function only handles sriov software context allocation and destruction. Signed-off-by: Mohamad Haj Yahia <moha...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- .../net/ethernet/mellanox/mlx5/core/mlx5_core.h| 2 ++ drivers/net/ethernet/mellanox

[PATCH net-next 00/11] Mellanox 100G mlx5 seamless error recovery

2016-09-09 Thread Saeed Mahameed
Hi Dave, This series from Mohamad improves the driver load/unload flows to seamlessly handle pci errors and device internal errors recovery reset flows. Current pci and internal error handling is too heavy and is done with a full restart of the driver by unregistering mlx5 interfaces (mlx5e

[PATCH net-next 01/11] net/mlx5: Skip waiting for vf pages in internal error

2016-09-09 Thread Saeed Mahameed
From: Mohamad Haj Yahia <moha...@mellanox.com> In case of device in internal error state there is no need to wait for vf pages since they will be reclaimed manually later in the unload flow. Signed-off-by: Mohamad Haj Yahia <moha...@mellanox.com> Signed-off-by: Saeed M

[PATCH net-next 02/11] net/mlx5: SRIOV core code refactoring

2016-09-09 Thread Saeed Mahameed
; Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/main.c | 12 +- .../net/ethernet/mellanox/mlx5/core/mlx5_core.h| 2 + drivers/net/ethernet/mellanox/mlx5/core/sriov.c| 216 + include/l

[PATCH net-next 08/11] net/mlx5: Implement vports admin state backup/restore

2016-09-09 Thread Saeed Mahameed
From: Mohamad Haj Yahia <moha...@mellanox.com> Save the user configuration in the vport sturct. Restore saved old configuration upon vport enable. Signed-off-by: Mohamad Haj Yahia <moha...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethe

[PATCH net-next 10/11] net/mlx5e: Restore vlan filter after seamless reset

2016-09-09 Thread Saeed Mahameed
From: Mohamad Haj Yahia <moha...@mellanox.com> When detaching the mlx5e interface clear all the vlans rules from the vlan flow table. When attaching it back restore all the active vlans rules to the HW. Signed-off-by: Mohamad Haj Yahia <moha...@mellanox.com> Signed-off-by: Saeed M

Re: [iovisor-dev] README: [PATCH RFC 11/11] net/mlx5e: XDP TX xmit more

2016-09-09 Thread Saeed Mahameed
perhaps align your single >> XDP_TX destination data structure to this future development. >> >> [1] http://info.iet.unipi.it/~luigi/papers/20150617-mswitch-paper.pdf > > I don't see how this particular paper applies to the existing kernel code. > It's great to take ideas f

Re: [PATCH RFC 00/11] mlx5 RX refactoring and XDP support

2016-09-09 Thread Saeed Mahameed
On Wed, Sep 7, 2016 at 3:42 PM, Saeed Mahameed <sae...@mellanox.com> wrote: > Hi All, > > This patch set introduces some important data path RX refactoring > addressing mlx5e memory allocation/management improvements and XDP support. > > Submitting as RFC since we wo

Re: [PATCH] mlx5: Add ndo_poll_controller() implementation

2016-09-24 Thread Saeed Mahameed
On Fri, Sep 23, 2016 at 11:13 PM, Calvin Owens wrote: > This implements ndo_poll_controller in net_device_ops for mlx5, which is > necessary to use netconsole with this driver. > > Signed-off-by: Calvin Owens > --- >

[PATCH net-next 3/9] net/mlx5: E-Switch, Set vport representor fields explicitly on registration

2016-09-22 Thread Saeed Mahameed
patch doesn't add new functionality. Signed-off-by: Or Gerlitz <ogerl...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/eswitch.h | 5 +++-- drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c | 8 +++- 2

[PATCH net-next 8/9] net/mlx5e: Add TC vlan action for SRIOV offloads

2016-09-22 Thread Saeed Mahameed
From: Or Gerlitz <ogerl...@mellanox.com> Parse TC vlan actions and set the required elements to allow offloading. Signed-off-by: Or Gerlitz <ogerl...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5

[PATCH net-next 1/9] net_sched: act_vlan: add helper inlines to access tcf_vlan info

2016-09-22 Thread Saeed Mahameed
From: Or Gerlitz <ogerl...@mellanox.com> Needed e.g for offloading drivers to pick the relevant attributes. Signed-off-by: Or Gerlitz <ogerl...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- include/net/tc_act/tc_vlan.h | 25 +

[PATCH net-next 7/9] net/mlx5: E-Switch, Support VLAN actions in the offloads mode

2016-09-22 Thread Saeed Mahameed
ly offloaded, the packets from the 2nd flow seen by the VF representor on the host have vlan. The VF rep driver removes such vlan before calling into the host networking stack. Signed-off-by: Or Gerlitz <ogerl...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/ne

[PATCH net-next 2/9] net/mlx5: E-Switch, Set the vport when registering the uplink rep

2016-09-22 Thread Saeed Mahameed
; Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 6 ++--- drivers/net/ethernet/mellanox/mlx5/core/en_tc.c| 10 ++-- drivers/net/ethernet/mellanox/mlx5/core/eswitch.h | 3 ++- .../ethernet/mellanox/mlx5/core/eswit

[PATCH net-next 6/9] net/mlx5e: Refactor retrival of skb from rx completion element (cqe)

2016-09-22 Thread Saeed Mahameed
commit. This patch doesn't change any functionality. Signed-off-by: Or Gerlitz <ogerl...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 41 + 1 file changed, 28 insertions(+), 13 deleti

[PATCH net-next 0/9] Mellanox 100G SRIOV offloads vlan push/pop

2016-09-22 Thread Saeed Mahameed
Hi Dave, >From Or Gerlitz: This series further enhances the SRIOV TC offloads of mlx5 to handle the TC vlan push and pop actions. This serves a common use-case in virtualization systems where the virtual switch add (push) vlan tags to packets sent from VMs and removes (pop) vlan tags before the

[PATCH net-next 4/9] net/mlx5: E-Switch, Allow fine tuning of eswitch vport push/pop vlan

2016-09-22 Thread Saeed Mahameed
; Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/eswitch.c | 33 +++ drivers/net/ethernet/mellanox/mlx5/core/eswitch.h | 5 2 files changed, 27 insertions(+), 11 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5

[PATCH net-next 9/9] net/mlx5e: Add TC vlan match parsing

2016-09-22 Thread Saeed Mahameed
From: Or Gerlitz <ogerl...@mellanox.com> Enhance the parsing of offloaded TC rules matches to handle vlans. Signed-off-by: Or Gerlitz <ogerl...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 19 +

[PATCH net-next 5/9] net/mlx5: Put elements related to offloaded TC rule in one struct

2016-09-22 Thread Saeed Mahameed
; Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_tc.c| 51 -- drivers/net/ethernet/mellanox/mlx5/core/eswitch.h | 10 - .../ethernet/mellanox/mlx5/core/eswitch_offloads.c | 9 ++-- 3 files changed, 44 insertion

[PATCH net 7/9] net/mlx5e: Fix memory leak if refreshing TIRs fails

2016-08-28 Thread Saeed Mahameed
From: Kamal Heib <kam...@mellanox.com> Free 'in' command object also when mlx5_core_modify_tir fails. Fixes: 724b2aa15126 ("net/mlx5e: TIRs management refactoring") Signed-off-by: Kamal Heib <kam...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com&g

[PATCH net 3/9] net/mlx5e: Don't post fragmented MPWQE when RQ is disabled

2016-08-28 Thread Saeed Mahameed
). Cleanup in-progress UMR MPWQE on mlx5e_free_rx_descs if needed. Fixes: bc77b240b3c5 ('net/mlx5e: Add fragmented memory support for RX multi packet WQE') Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 4 drivers/net/et

[PATCH net 6/9] net/mlx5e: Add ethtool counter for TX xmit_more

2016-08-28 Thread Saeed Mahameed
From: Tariq Toukan <tar...@mellanox.com> Add a counter in ethtool for the number of times that TX xmit_more was used. Signed-off-by: Tariq Toukan <tar...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_main.c

[PATCH net 2/9] net/mlx5e: Don't wait for RQ completions on close

2016-08-28 Thread Saeed Mahameed
flush in error cases') Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 4 +-- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 37 +++ drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 23 ++ 3

[PATCH net 4/9] net/mlx5e: Don't wait for SQ completions on close

2016-08-28 Thread Saeed Mahameed
mlx5e_free_tx_descs to the end of en_tx.c for tx critical code locality. Fixes: 29429f3300a3 ('net/mlx5e: Timeout if SQ doesn't flush during close') Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 3 +- drivers/net/ethernet/me

[PATCH net 1/9] net/mlx5e: Limit UMR length to the device's limitation

2016-08-28 Thread Saeed Mahameed
RX rings value guarantees that we are in range, dynamically (on set_ringparam/set_channels) we will check if the new required UMR length (num mtts) is still in range, if not, fail the request. Fixes: bc77b240b3c5 ('net/mlx5e: Add fragmented memory support for RX multi packet WQE') Signed-off-by: Sa

[PATCH net 9/9] net/mlx5: Increase number of ethtool steering priorities

2016-08-28 Thread Saeed Mahameed
ed-off-by: Maor Gottlieb <ma...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c b/drivers/net/ethernet/

[PATCH net 5/9] net/mlx5e: Fix ethtool -g/G rx ring parameter report with striding RQ

2016-08-28 Thread Saeed Mahameed
a <era...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> --- .../net/ethernet/mellanox/mlx5/core/en_ethtool.c | 76 +++--- 1 file changed, 67 insertions(+), 9 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c b/dr

[PATCH net 8/9] net/mlx5: Add error prints when validate ETS failed

2016-08-28 Thread Saeed Mahameed
From: Eran Ben Elisha <era...@mellanox.com> Upon set ETS failure due to user invalid input, add error prints to specify the exact error to the user. Fixes: cdcf11212b22 ('net/mlx5e: Validate BW weight values of ETS') Signed-off-by: Eran Ben Elisha <era...@mellanox.com> Signed-o

[PATCH net 0/9] Mellanox 100G mlx5 fixes 2016-08-29

2016-08-28 Thread Saeed Mahameed
t/mlx5: Increase number of ethtool steering priorities Saeed Mahameed (4): net/mlx5e: Limit UMR length to the device's limitation net/mlx5e: Don't wait for RQ completions on close net/mlx5e: Don't post fragmented MPWQE when RQ is disabled net/mlx5e: Don't wait for SQ completions on close

[PATCH for-next V3 13/15] net/mlx5: Enable setting minimum inline header mode for VFs

2016-08-23 Thread Saeed Mahameed
From: Hadar Hen Zion <had...@mellanox.com> Implement the low-level part of the PF side in setting minimum inline header mode for VFs. Signed-off-by: Hadar Hen Zion <had...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Signed-off-by: Leon Romanovsk

[PATCH for-next V3 10/15] {net,IB}/mlx5: Modify QP commands via mlx5 ifc

2016-08-23 Thread Saeed Mahameed
if needed. This way the caller is not required to provide the command inbox layout and it will be generated automatically. mlx5_core_qp_modify will generate the command inbox/outbox layouts according to the requested transition and will fill the requested parameters. Signed-off-by: Saeed Mahameed <

[PATCH for-next V3 14/15] net/mlx5: Update mlx5_ifc.h for vxlan encap/decap

2016-08-23 Thread Saeed Mahameed
From: Hadar Hen Zion <had...@mellanox.com> Add the required definitions related to vxlan encap/decap. Signed-off-by: Hadar Hen Zion <had...@mellanox.com> Signed-off-by: Ilya Lesokhin <il...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Signed-of

[PATCH for-next V3 15/15] net/mlx5: Introduce alloc_encap and dealloc_encap commands

2016-08-23 Thread Saeed Mahameed
From: Ilya Lesokhin <il...@mellanox.com> Implement low-level commands to support vxlan encapsulation. Signed-off-by: Ilya Lesokhin <il...@mellanox.com> Signed-off-by: Hadar Hen Zion <had...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Signed-of

[PATCH for-next V3 12/15] net/mlx5: Improve driver log messages

2016-08-23 Thread Saeed Mahameed
Remove duplicate pci dev name printing in mlx5_core_err. Use mlx5_core_{warn,info,err} where possible to have the pci info in the driver log messages. Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Signed-off-by: Parvi Kaustubhi <par...@mellanox.com> Signed-off-by: Leon R

[PATCH for-next V2 08/17] {net,IB}/mlx5: MKey/PSV commands via mlx5 ifc

2016-08-22 Thread Saeed Mahameed
Remove old representation of manually created MKey/PSV commands layout, and use mlx5_ifc canonical structures and defines. Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Signed-off-by: Leon Romanovsky <l...@kernel.org> --- drivers/infiniband/hw/mlx5/mlx5_ib.h | 2

[PATCH for-next V2 11/17] net/mlx5: Unify and improve command interface

2016-08-22 Thread Saeed Mahameed
output. Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Signed-off-by: Leon Romanovsky <l...@kernel.org> --- drivers/infiniband/hw/mlx5/main.c | 10 +- drivers/infiniband/hw/mlx5/qp.c| 5 +- drivers/net/ethernet/mellanox/mlx5/core/cmd.

[PATCH for-next V2 17/17] net/mlx5: Update struct mlx5_ifc_xrqc_bits

2016-08-22 Thread Saeed Mahameed
From: Artemy Kovalyov <artem...@mellanox.com> Update struct mlx5_ifc_xrqc_bits according to last specification Signed-off-by: Artemy Kovalyov <artem...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Signed-off-by: Leon Romanovsky <l...@kernel.org>

[PATCH for-next V2 15/17] net/mlx5: Introduce alloc_encap and dealloc_encap commands

2016-08-22 Thread Saeed Mahameed
From: Ilya Lesokhin <il...@mellanox.com> Implement low-level commands to support vxlan encapsulation. Signed-off-by: Ilya Lesokhin <il...@mellanox.com> Signed-off-by: Hadar Hen Zion <had...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Signed-of

[PATCH for-next V2 16/17] net/mlx5: Modify RQ bitmask from mlx5 ifc

2016-08-22 Thread Saeed Mahameed
From: Alex Vesker <va...@mellanox.com> Use mlx5 ifc MODIFY_BITMASK_VSD in mlx5e_modify_rq_vsd and expose counter set capability bit in hca caps structure. Signed-off-by: Alex Vesker <va...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Signed-off-by:

[PATCH for-next V2 01/17] net/mlx5: Init/Teardown hca commands via mlx5 ifc

2016-08-22 Thread Saeed Mahameed
Remove old representation of manually created Init/Teardown hca commands layout and use mlx5_ifc canonical structures and defines. Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Signed-off-by: Leon Romanovsky <l...@kernel.org> --- drivers/net/ethernet/mellanox/mlx5/co

[PATCH for-next V2 14/17] net/mlx5: Update mlx5_ifc.h for vxlan encap/decap

2016-08-22 Thread Saeed Mahameed
From: Hadar Hen Zion <had...@mellanox.com> Add the required definitions related to vxlan encap/decap. Signed-off-by: Hadar Hen Zion <had...@mellanox.com> Signed-off-by: Ilya Lesokhin <il...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Signed-of

[PATCH for-next V2 05/17] net/mlx5: Pages management commands via mlx5 ifc

2016-08-22 Thread Saeed Mahameed
Remove old representation of manually created Pages management commands layout, and use mlx5_ifc canonical structures and defines. Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Signed-off-by: Leon Romanovsky <l...@kernel.org> --- .../net/ethernet/mellanox/mlx5/core/pageallo

[PATCH for-next V2 12/17] net/mlx5: Improve driver log messages

2016-08-22 Thread Saeed Mahameed
Remove duplicate pci dev name printing in mlx5_core_err. Use mlx5_core_{warn,info,err} where possible to have the pci info in the driver log messages. Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Signed-off-by: Parvi Kaustubhi <par...@mellanox.com> Signed-off-by: Leon R

[PATCH for-next V2 04/17] net/mlx5: MCG commands via mlx5 ifc

2016-08-22 Thread Saeed Mahameed
Remove old representation of manually created MCG commands layout and use mlx5_ifc canonical structures and defines. Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Signed-off-by: Leon Romanovsky <l...@kernel.org> --- drivers/net/ethernet/mellanox/mlx5/core/cmd.c | 4 +-

[PATCH for-next V2 06/17] net/mlx5: EQ commands via mlx5 ifc

2016-08-22 Thread Saeed Mahameed
Remove old representation of manually created EQ commands layout, and use mlx5_ifc canonical structures and defines. Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Signed-off-by: Leon Romanovsky <l...@kernel.org> --- drivers/net/ethernet/mellanox/mlx5/core/debugfs.c | 18 +++---

[PATCH for-next V2 02/17] net/mlx5: Access register and MAD IFC commands via mlx5 ifc

2016-08-22 Thread Saeed Mahameed
Remove old representation of manually created ACCESS_REG/MAD_IFC commands layout and use mlx5_ifc canonical structures and defines. Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Signed-off-by: Leon Romanovsky <l...@kernel.org> --- drivers/net/ethernet/mellanox/mlx5/core

[PATCH for-next V2 03/17] net/mlx5: PD and UAR commands via mlx5 ifc

2016-08-22 Thread Saeed Mahameed
Remove old representation of manually created PD/UAR commands layouts and use mlx5_ifc canonical structures and defines. Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Signed-off-by: Leon Romanovsky <l...@kernel.org> --- drivers/net/ethernet/mellanox/mlx5/cor

[for-next V2 00/17][PULL request] Mellanox mlx5 core driver updates 2016-08-20

2016-08-22 Thread Saeed Mahameed
esokhin (1): net/mlx5: Introduce alloc_encap and dealloc_encap commands Saeed Mahameed (12): net/mlx5: Init/Teardown hca commands via mlx5 ifc net/mlx5: Access register and MAD IFC commands via mlx5 ifc net/mlx5: PD and UAR commands via mlx5 ifc net/mlx5: MCG commands via mlx5 ifc net

[PATCH for-next V2 10/17] {net,IB}/mlx5: Modify QP commands via mlx5 ifc

2016-08-22 Thread Saeed Mahameed
if needed. This way the caller is not required to provide the command inbox layout and it will be generated automatically. mlx5_core_qp_modify will generate the command inbox/outbox layouts according to the requested transition and will fill the requested parameters. Signed-off-by: Saeed Mahameed <

[PATCH for-next V2 07/17] {net,IB}/mlx5: CQ commands via mlx5 ifc

2016-08-22 Thread Saeed Mahameed
Remove old representation of manually created CQ commands layout, and use mlx5_ifc canonical structures and defines. Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Signed-off-by: Leon Romanovsky <l...@kernel.org> --- drivers/infiniband/hw/mlx5/cq.c

[PATCH for-next V2 09/17] {net,IB}/mlx5: QP/XRCD commands via mlx5 ifc

2016-08-22 Thread Saeed Mahameed
Remove old representation of manually created QP/XRCD commands layout amd use mlx5_ifc canonical structures and defines. Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Signed-off-by: Leon Romanovsky <l...@kernel.org> --- drivers/infiniband/hw/mlx5/qp.c

[PATCH for-next V2 13/17] net/mlx5: Enable setting minimum inline header mode for VFs

2016-08-22 Thread Saeed Mahameed
From: Hadar Hen Zion <had...@mellanox.com> Implement the low-level part of the PF side in setting minimum inline header mode for VFs. Signed-off-by: Hadar Hen Zion <had...@mellanox.com> Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Signed-off-by: Leon Romanovsk

Re: [for-next V2 00/17][PULL request] Mellanox mlx5 core driver updates 2016-08-20

2016-08-22 Thread Saeed Mahameed
On Mon, Aug 22, 2016 at 8:11 PM, David Miller wrote: > > Sorry, too many patches. > > Please keep your series to 10 to 15 patches maximum. > > Please do not push back on this, I made several other submitters do > the same exact thing over the past few days. Sure. Rules are

[PATCH for-next V3 02/15] net/mlx5: Access register and MAD IFC commands via mlx5 ifc

2016-08-23 Thread Saeed Mahameed
Remove old representation of manually created ACCESS_REG/MAD_IFC commands layout and use mlx5_ifc canonical structures and defines. Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Signed-off-by: Leon Romanovsky <l...@kernel.org> --- drivers/net/ethernet/mellanox/mlx5/core

[for-next V3 00/15][PULL request] Mellanox mlx5 core driver updates 2016-08-20

2016-08-23 Thread Saeed Mahameed
: net/mlx5: Enable setting minimum inline header mode for VFs net/mlx5: Update mlx5_ifc.h for vxlan encap/decap Ilya Lesokhin (1): net/mlx5: Introduce alloc_encap and dealloc_encap commands Saeed Mahameed (12): net/mlx5: Init/Teardown hca commands via mlx5 ifc net/mlx5: Access register

[PATCH for-next V3 03/15] net/mlx5: PD and UAR commands via mlx5 ifc

2016-08-23 Thread Saeed Mahameed
Remove old representation of manually created PD/UAR commands layouts and use mlx5_ifc canonical structures and defines. Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Signed-off-by: Leon Romanovsky <l...@kernel.org> --- drivers/net/ethernet/mellanox/mlx5/cor

[PATCH for-next V3 05/15] net/mlx5: Pages management commands via mlx5 ifc

2016-08-23 Thread Saeed Mahameed
Remove old representation of manually created Pages management commands layout, and use mlx5_ifc canonical structures and defines. Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Signed-off-by: Leon Romanovsky <l...@kernel.org> --- .../net/ethernet/mellanox/mlx5/core/pageallo

[PATCH for-next V3 06/15] net/mlx5: EQ commands via mlx5 ifc

2016-08-23 Thread Saeed Mahameed
Remove old representation of manually created EQ commands layout, and use mlx5_ifc canonical structures and defines. Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Signed-off-by: Leon Romanovsky <l...@kernel.org> --- drivers/net/ethernet/mellanox/mlx5/core/debugfs.c | 18 +++---

[PATCH for-next V3 07/15] {net,IB}/mlx5: CQ commands via mlx5 ifc

2016-08-23 Thread Saeed Mahameed
Remove old representation of manually created CQ commands layout, and use mlx5_ifc canonical structures and defines. Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Signed-off-by: Leon Romanovsky <l...@kernel.org> --- drivers/infiniband/hw/mlx5/cq.c

[PATCH for-next V3 04/15] net/mlx5: MCG commands via mlx5 ifc

2016-08-23 Thread Saeed Mahameed
Remove old representation of manually created MCG commands layout and use mlx5_ifc canonical structures and defines. Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Signed-off-by: Leon Romanovsky <l...@kernel.org> --- drivers/net/ethernet/mellanox/mlx5/core/cmd.c | 4 +-

[PATCH for-next V3 01/15] net/mlx5: Init/Teardown hca commands via mlx5 ifc

2016-08-23 Thread Saeed Mahameed
Remove old representation of manually created Init/Teardown hca commands layout and use mlx5_ifc canonical structures and defines. Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Signed-off-by: Leon Romanovsky <l...@kernel.org> --- drivers/net/ethernet/mellanox/mlx5/co

[PATCH for-next V3 11/15] net/mlx5: Unify and improve command interface

2016-08-23 Thread Saeed Mahameed
output. Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Signed-off-by: Leon Romanovsky <l...@kernel.org> --- drivers/infiniband/hw/mlx5/main.c | 10 +- drivers/infiniband/hw/mlx5/qp.c| 5 +- drivers/net/ethernet/mellanox/mlx5/core/cmd.

[PATCH for-next V3 09/15] {net,IB}/mlx5: QP/XRCD commands via mlx5 ifc

2016-08-23 Thread Saeed Mahameed
Remove old representation of manually created QP/XRCD commands layout amd use mlx5_ifc canonical structures and defines. Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Signed-off-by: Leon Romanovsky <l...@kernel.org> --- drivers/infiniband/hw/mlx5/qp.c

[PATCH for-next V3 08/15] {net,IB}/mlx5: MKey/PSV commands via mlx5 ifc

2016-08-23 Thread Saeed Mahameed
Remove old representation of manually created MKey/PSV commands layout, and use mlx5_ifc canonical structures and defines. Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Signed-off-by: Leon Romanovsky <l...@kernel.org> --- drivers/infiniband/hw/mlx5/mlx5_ib.h | 2

Re: [PATCH v2] mlx5: Add ndo_poll_controller() implementation

2016-09-28 Thread Saeed Mahameed
On Wed, Sep 28, 2016 at 1:23 AM, Calvin Owens <calvinow...@fb.com> wrote: > This implements ndo_poll_controller in net_device_ops callback for mlx5, > which is necessary to use netconsole with this driver. > > Cc: Saeed Mahameed <sae...@dev.mellanox.co.il> > Signed-off

Re: [PATCH for-next 00/14][PULL request] Mellanox mlx5 core driver updates 2016-10-25

2016-10-30 Thread Saeed Mahameed
On Fri, Oct 28, 2016 at 7:53 PM, David Miller wrote: > > I really disalike pull requests of this form. > > You add lots of datastructures and helper functions but no actual > users of these facilities to the driver. > > Do this instead: > > 1) Add TSAR infrastructure

Re: [PATCH RFC 0/2] ethtool: Add actual port speed reporting

2016-11-09 Thread Saeed Mahameed
On Wed, Nov 2, 2016 at 5:50 PM, Mintz, Yuval wrote: >> Sending RFC to get feedback for the following ethtool proposal: >> >> In some cases such as virtual machines and multi functions (SR-IOV), the >> actual >> bandwidth exposed for each machine is not accurately shown in

[PATCH net-next 00/13] Mellanox 100G SRIOV offloads tunnel_key set/release

2016-11-07 Thread Saeed Mahameed
Hi Dave, >From Hadar Hen Zion: This series further enhances the SRIOV TC offloads of mlx5 to handle the TC tunnel_key release and set actions. This serves a common use-case in virtualization systems where the virtual switch encapsulate packets (tunnel_key set action) sent from VMs with outer

<    4   5   6   7   8   9   10   11   12   13   >