Re: [PATCH 7/7] ARM: dts: NSP: Add bgmac entries

2016-07-08 Thread Scott Branden
Hi Jon, In Subject line, you mean add amac entries. On 16-07-08 08:56 AM, Jon Mason wrote: Add device tree entries for the ethernet devices present on the Broadcom Northstar Plus SoCs Signed-off-by: Jon Mason --- arch/arm/boot/dts/bcm-nsp.dtsi | 18

Re: [PATCH 1/6] dt-bindings: mdio-mux: Add documentation for mdio mux for NSP SoC

2016-11-09 Thread Scott Branden
One change On 16-11-09 01:33 AM, Yendapally Reddy Dhananjaya Reddy wrote: Add documentation for mdio mux available in Broadcom NSP SoC Signed-off-by: Yendapally Reddy Dhananjaya Reddy --- .../devicetree/bindings/net/brcm,mdio-mux-nsp.txt | 57

Re: [PATCH v4 2/7] Documentation: devicetree: add PHY lane swap binding

2016-11-01 Thread Scott Branden
On 16-11-01 01:59 PM, Jon Mason wrote: On Tue, Nov 01, 2016 at 09:48:26PM +0100, Andrew Lunn wrote: +- enet-phy-lane-swap: If set, indicates the PHY device requires swapping the + TX/RX lanes to function properly. Is 'requires' the right word here? The PHY performs the actual swap of the

Re: [PATCH v4 6/7] net: ethernet: bgmac: add NS2 support

2016-11-01 Thread Scott Branden
One change in this patch On 16-11-01 01:04 PM, Jon Mason wrote: Add support for the variant of amac hardware present in the Broadcom Northstar2 based SoCs. Northstar2 requires an additional register to be configured with the port speed/duplexity (NICPM). This can be added to the link callback

Re: [PATCH v3 0/6] add NS2 support to bgmac

2016-11-01 Thread Scott Branden
Hi Jon, On 16-11-01 10:51 AM, Jon Mason wrote: Changes in v3: * Clean-up the bgmac DT binding doc (per Rob Herring) * Document the lane swap binding and make it generic (Per Andrew Lunn) Where is the documentation of the lane swap binding? Changes in v2: * Remove the PHY power-on (per

Re: [PATCH 1/2] net: dsa: b53: Add compatible strings for the Cygnus-family BCM11360.

2017-04-24 Thread Scott Branden
Minor comment in line On 17-04-24 02:50 PM, Eric Anholt wrote: Cygnus is a small family of SoCs, of which we currently have devicetree for BCM11360 and BCM58300. The 11360's B53 is mostly the same as 58xx, just requiring a tiny bit of setup that was previously missing. Signed-off-by: Eric

Re: [PATCH 1/2] net: dsa: b53: Add compatible strings for the Cygnus-family BCM11360.

2017-04-24 Thread Scott Branden
On 17-04-24 04:54 PM, Eric Anholt wrote: Scott Branden <scott.bran...@broadcom.com> writes: Minor comment in line On 17-04-24 02:50 PM, Eric Anholt wrote: Cygnus is a small family of SoCs, of which we currently have devicetree for BCM11360 and BCM58300. The 11360's B53 is mostly th

Re: [PATCH v1 1/2] dt-binding: ptp: add bindings document for dte based ptp clock

2017-06-29 Thread Scott Branden
Hi Rob, On 17-06-29 03:40 PM, Rob Herring wrote: On Tue, Jun 27, 2017 at 12:10 AM, Scott Branden <scott.bran...@broadcom.com> wrote: Hi Rob/Florian, Thanks for input but still don't see any need for SoC specific compatible stings. IP revision specific yes. On 17-06-22 06:04 PM, F

Re: [PATCH v1 1/2] dt-binding: ptp: add bindings document for dte based ptp clock

2017-06-20 Thread Scott Branden
Hi Rob, On 17-06-18 07:04 AM, Rob Herring wrote: On Mon, Jun 12, 2017 at 01:26:00PM -0700, Arun Parameswaran wrote: Add device tree binding documentation for the Broadcom DTE PTP clock driver. Signed-off-by: Arun Parameswaran ---

Re: [PATCH v1 1/2] dt-binding: ptp: add bindings document for dte based ptp clock

2017-06-22 Thread Scott Branden
On 17-06-21 08:19 PM, Rob Herring wrote: On Tue, Jun 20, 2017 at 3:48 PM, Scott Branden <scott.bran...@broadcom.com> wrote: Hi Rob, On 17-06-18 07:04 AM, Rob Herring wrote: On Mon, Jun 12, 2017 at 01:26:00PM -0700, Arun Parameswaran wrote: Add device tree binding documen

Re: [PATCH v1 1/2] dt-binding: ptp: add bindings document for dte based ptp clock

2017-06-26 Thread Scott Branden
Hi Rob/Florian, Thanks for input but still don't see any need for SoC specific compatible stings. IP revision specific yes. On 17-06-22 06:04 PM, Florian Fainelli wrote: On 06/22/2017 05:42 PM, Scott Branden wrote: On 17-06-21 08:19 PM, Rob Herring wrote: On Tue, Jun 20, 2017 at 3:48 PM

Re: [PATCH 0/1] net: ethtool: add SmartNIC reset support

2017-10-18 Thread Scott Branden
+netdev@vger.kernel.org On 17-10-18 02:30 PM, Andy Gospodarek wrote: On Wed, Oct 18, 2017 at 12:31:28PM -0700, Scott Branden wrote: Hi Andrew, On 17-10-18 12:16 PM, Andrew Lunn wrote: Yes, there is also a management processor. O.K. Maybe it would be nice to add some more text

Re: [PATCH 1/1] net: ethtool: add support for reset of AP inside NIC interface.

2017-10-18 Thread Scott Branden
+netdev@vger.kernel.org On 17-10-18 09:01 AM, Scott Branden wrote: Add ETH_RESET_AP to reset the application processor inside the NIC interface. Signed-off-by: Scott Branden <scott.bran...@broadcom.com> --- include/uapi/linux/ethtool.h | 1 + 1 file changed, 1 insertion(+) diff

[PATCH 2/2] bnxt_en: Add ETH_RESET_AP support

2017-11-30 Thread Scott Branden
Add ETH_RESET_AP support handling to reset the internal Application Processor(s) of the SmartNIC card. Signed-off-by: Scott Branden <scott.bran...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 11 +++ drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.h |

[PATCH 0/2] net: ethtool: add support for ETH_RESET_AP

2017-11-30 Thread Scott Branden
Add support to reset appplication processors inside SmartNICs by defining new ETH_RESET_AP bit. And use new ETH_RESET_AP bit in bnxt ethernet driver. Scott Branden (2): net: ethtool: add support for reset of AP inside NIC interface. bnxt_en: Add ETH_RESET_AP support drivers/net/ethernet

[PATCH 1/2] net: ethtool: add support for reset of AP inside NIC interface.

2017-11-30 Thread Scott Branden
inside the NIC processor - be it a simple algorithm without an OS to as complex as hosting multiple VMs. Signed-off-by: Scott Branden <scott.bran...@broadcom.com> Reviewed-by: Andrew Lunn <and...@lunn.ch> --- include/uapi/linux/ethtool.h | 1 + 1 file changed, 1 insertion(+) diff --git a/

[PATCH] ethtool: Add ETHTOOL_RESET support via --reset command

2017-11-30 Thread Scott Branden
ags %x Signed-off-by: Scott Branden <scott.bran...@broadcom.com> --- ethtool.8.in | 55 - ethtool.c| 73 2 files changed, 127 insertions(+), 1 deletion(-) diff --git a/ethtool.8.in

ethtool-copy.h out of sync with linux header file?

2017-12-04 Thread Scott Branden
Hi Paul/John, I see a commit "ethtool: Add DMA Coalescing support" was added to ethtool-copy.h yet I cannot find the change in the ethtool.h in the linux kernel. As such, I am unable to commit a change to ethtool-copy.h to sync it with net-next.  If I sync then ethtool will fail to compile.

Re: [PATCH] ethtool: Add ETHTOOL_RESET support via --reset command

2017-12-04 Thread Scott Branden
Hi Gal, I do not understand you're comment - questions inline On 17-12-03 12:07 AM, Gal Pressman wrote: On 30-Nov-17 21:24, Scott Branden wrote: Add ETHTOOL_RESET support via --reset command. ie. ethtool --reset DEVNAME <flagname(s)> flagnames currently match the ETH_RESET_xxx names

[PATCH v3 1/3] Revert "ethtool: Add DMA Coalescing support"

2017-12-12 Thread Scott Branden
This reverts commit 5dd7bfbc5079cb375876e4e76191263fc28ae1a6. As Stephen Hemminger mentioned there is an ABI compatibility issue with this patch: https://patchwork.ozlabs.org/patch/806049/#1757846 Signed-off-by: Scott Branden <scott.bran...@broadcom.com> --- ethtool-copy.h | 2 -- eth

[PATCH v3 0/3] ethtool: add ETHTOOL_RESET support via --reset command

2017-12-12 Thread Scott Branden
: - update commit message to indicate support for ap - add symbolic support for parsing of -shared added to each component specified - cleaned up reset print information to indicate which components have and have not been reset Scott Branden (3): Revert "ethtool: Add DMA Coalescing su

[PATCH v3 3/3] ethtool: Add ETHTOOL_RESET support via --reset command

2017-12-12 Thread Scott Branden
ecific component bitfield directly using ethtool --reset DEVNAME flags %x Signed-off-by: Scott Branden <scott.bran...@broadcom.com> --- ethtool.8.in | 67 ++- ethtool.c| 113 +++ 2 files changed, 17

[PATCH v3 2/3] ethtool-copy.h: sync with net-next

2017-12-12 Thread Scott Branden
This covers kernel changes up to: commit 40e44a1e669d078946f46853808a60d29e6f0885 Author: Scott Branden <scott.bran...@broadcom.com> Date: Thu Nov 30 11:35:59 2017 -0800 net: ethtool: add support for reset of AP inside NIC interface. Add ETH_RESET_AP to reset the application pro

[PATCH v2 0/3] ethtool: add ETHTOOL_RESET support via --reset command

2017-12-05 Thread Scott Branden
Patch series to add ETHTOOL_RESET support to ethtool userspace tool. Include: - revert custom change to ethtool-copy.h that is not in linux kernel - sync ethtool-copy.h with ethtool.h in linux kernel net-next - add ETHTOOL_RESET support with up to date ethtool.h reset defines Scott Branden (3

[PATCH v2 3/3] ethtool: Add ETHTOOL_RESET support via --reset command

2017-12-05 Thread Scott Branden
ags %x Signed-off-by: Scott Branden <scott.bran...@broadcom.com> --- ethtool.8.in | 58 +- ethtool.c| 75 2 files changed, 132 insertions(+), 1 deletion(-) diff --git a/ethtool.8.in

[PATCH v2 2/3] ethtool-copy.h: sync with net-next

2017-12-05 Thread Scott Branden
This covers kernel changes up to: commit 40e44a1e669d078946f46853808a60d29e6f0885 Author: Scott Branden <scott.bran...@broadcom.com> Date: Thu Nov 30 11:35:59 2017 -0800 net: ethtool: add support for reset of AP inside NIC interface. Add ETH_RESET_AP to reset the application pro

Re: ethtool-copy.h out of sync with linux header file?

2017-12-05 Thread Scott Branden
://patchwork.ozlabs.org/patch/806049/#1757846 Thanks, Paul -Original Message- From: Scott Branden [mailto:scott.bran...@broadcom.com] Sent: Monday, December 4, 2017 12:07 PM To: linvi...@tuxdriver.com; Greenwalt, Paul <paul.greenw...@intel.com> Cc: netdev <netdev@vger.kernel.org> Subj

Re: [PATCH v2 3/3] ethtool: Add ETHTOOL_RESET support via --reset command

2017-12-05 Thread Scott Branden
Hi Michal, thanks for review - see comments On 17-12-05 01:30 PM, Michal Kubecek wrote: On Tue, Dec 05, 2017 at 12:53:23PM -0800, Scott Branden wrote: Add ETHTOOL_RESET support via --reset command. ie. ethtool --reset DEVNAME <flagname(s)> flagnames currently match the ETH_RESET_xxx

Re: [PATCH] ethtool: Add ETHTOOL_RESET support via --reset command

2017-12-05 Thread Scott Branden
On 17-12-05 12:21 AM, Gal Pressman wrote: On 04-Dec-17 22:16, Scott Branden wrote: Hi Gal, I do not understand you're comment - questions inline On 17-12-03 12:07 AM, Gal Pressman wrote: On 30-Nov-17 21:24, Scott Branden wrote: Add ETHTOOL_RESET support via --reset command. ie.  ethtool

Re: [PATCH v2 3/3] ethtool: Add ETHTOOL_RESET support via --reset command

2017-12-05 Thread Scott Branden
Hi Andrew, On 17-12-05 02:26 PM, Andrew Lunn wrote: On Tue, Dec 05, 2017 at 12:53:23PM -0800, Scott Branden wrote: Add ETHTOOL_RESET support via --reset command. ie. ethtool --reset DEVNAME <flagname(s)> flagnames currently match the ETH_RESET_xxx names: mgmt,irq,dma,filter,offload,m

Re: [PATCH v2 3/3] ethtool: Add ETHTOOL_RESET support via --reset command

2017-12-05 Thread Scott Branden
Hi Michal, Thanks - one question below hopefully someone can help with. On 17-12-05 02:29 PM, Michal Kubecek wrote: On Tue, Dec 05, 2017 at 02:06:09PM -0800, Scott Branden wrote: On 17-12-05 01:30 PM, Michal Kubecek wrote: On Tue, Dec 05, 2017 at 12:53:23PM -0800, Scott Branden wrote: Add