Re: [PATCH for bnxt_re V4 20/21] RDMA/bnxt_re: Add QP event handling

2017-01-25 Thread Selvin Xavier
On Tue, Jan 24, 2017 at 5:50 PM, Leon Romanovsky wrote: > it looks like if( ... ) return 0 Yes.. There is some code to be added on this area as a part of error reporting. We will add this once the driver is accepted. Perhaps, i will add a debug print here for now.

Re: [PATCH for bnxt_re V4 17/21] RDMA/bnxt_re: Handling dispatching of events to IB stack

2017-01-25 Thread Selvin Xavier
On Tue, Jan 24, 2017 at 5:48 PM, Leon Romanovsky wrote: > All callers to this function in this patch set qp_wait to be false. > Do you have in following patches qp_wait == true? > I'm curious because of your msleep below. Thanks for pointing it out. Driver in our internal tree

Re: linux-next: build failure after merge of the rdma tree

2017-02-14 Thread Selvin Xavier
us. He just hadn't > time to send it yet. Your patch is sufficient as well, so I may just > pull it in. Thanks again. Thanks Stephen and Doug for taking care of this. Acked-by: Selvin Xavier <selvin.xav...@broadcom.com>

Re: [PATCH V5 for-next 16/21] RDMA/bnxt_re: Support poll_cq verb

2017-02-12 Thread Selvin Xavier
On Sun, Feb 12, 2017 at 8:00 PM, Leon Romanovsky wrote: >> +static u8 __rc_to_ib_wc_status(u8 qstatus) >> +{ >> + switch (qstatus) { >> + case CQ_RES_RC_STATUS_OK: >> + return IB_WC_SUCCESS; >> + case CQ_RES_RC_STATUS_LOCAL_ACCESS_ERROR: >> +

[PATCH V5 for-next 02/21] RDMA/bnxt_re: Introducing autogenerated Host Software Interface(hsi) file

2017-02-10 Thread Selvin Xavier
avapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/infiniband/hw/bnxt_re/roce_hsi.h | 2779 ++ 1 file changed, 2779 insertions(+) diff --git a/drivers/infiniband/hw/bnxt_re/roce_hsi.h b/drivers/infiniband/hw/bnxt_re/roc

[PATCH V5 for-next 13/21] RDMA/bnxt_re: Support QP verbs

2017-02-10 Thread Selvin Xavier
min value Signed-off-by: Eddie Wai <eddie@broadcom.com> Signed-off-by: Devesh Sharma <devesh.sha...@broadcom.com> Signed-off-by: Somnath Kotur <somnath.ko...@broadcom.com> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com> Signed-off-by: S

[PATCH V5 for-next 05/21] RDMA/bnxt_re: Adding Notification Queue support

2017-02-10 Thread Selvin Xavier
ed-off-by: Devesh Sharma <devesh.sha...@broadcom.com> Signed-off-by: Somnath Kotur <somnath.ko...@broadcom.com> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/infiniband/hw/bnxt_re

[PATCH V5 for-next 00/21] Broadcom RoCE Driver (bnxt_re)

2017-02-10 Thread Selvin Xavier
this to linux-rdma tree. Thanks, Selvin Xavier v4->v5: * Removes rdev ref_count as this is not necessary. * Adds a check to see if the device is supporting RoCE * Updating the PF FW communication channel offset as per the latest FW changes * Use min_t macro to calculate the number

[PATCH V5 for-next 10/21] RDMA/bnxt_re: Support for CQ verbs

2017-02-10 Thread Selvin Xavier
Devesh Sharma <devesh.sha...@broadcom.com> Signed-off-by: Somnath Kotur <somnath.ko...@broadcom.com> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/infiniba

[PATCH V5 for-next 06/21] RDMA/bnxt_re: Support for PD, ucontext and mmap verbs

2017-02-10 Thread Selvin Xavier
: Changes the year in copyright text Signed-off-by: Eddie Wai <eddie@broadcom.com> Signed-off-by: Devesh Sharma <devesh.sha...@broadcom.com> Signed-off-by: Somnath Kotur <somnath.ko...@broadcom.com> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com&g

[PATCH V5 for-next 09/21] RDMA/bnxt_re: Support for GID related verbs

2017-02-10 Thread Selvin Xavier
adcom.com> Signed-off-by: Somnath Kotur <somnath.ko...@broadcom.com> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/infiniband/hw/bnxt_re/ib_verbs.c | 123 +

[PATCH V5 for-next 18/21] RDMA/bnxt_re: Support for DCB

2017-02-10 Thread Selvin Xavier
com> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/infiniband/hw/bnxt_re/bnxt_re.h | 3 + drivers/infiniband/hw/bnxt_re/main.c | 141 +++ drivers/infiniba

[PATCH V5 for-next 19/21] RDMA/bnxt_re: Set uverbs command mask

2017-02-10 Thread Selvin Xavier
evesh.sha...@broadcom.com> Signed-off-by: Somnath Kotur <somnath.ko...@broadcom.com> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/infiniband/hw/bnxt_re/main.c | 35 +

[PATCH V5 for-next 12/21] RDMA/bnxt_re: Support memory registration verbs

2017-02-10 Thread Selvin Xavier
-off-by: Eddie Wai <eddie@broadcom.com> Signed-off-by: Devesh Sharma <devesh.sha...@broadcom.com> Signed-off-by: Somnath Kotur <somnath.ko...@broadcom.com> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <

[PATCH V5 for-next 01/21] RDMA/bnxt_re: Add bnxt_re RoCE driver files

2017-02-10 Thread Selvin Xavier
text Signed-off-by: Eddie Wai <eddie@broadcom.com> Signed-off-by: Devesh Sharma <devesh.sha...@broadcom.com> Signed-off-by: Somnath Kotur <somnath.ko...@broadcom.com> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <

[PATCH V5 for-next 16/21] RDMA/bnxt_re: Support poll_cq verb

2017-02-10 Thread Selvin Xavier
Sharma <devesh.sha...@broadcom.com> Signed-off-by: Somnath Kotur <somnath.ko...@broadcom.com> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/infiniba

[PATCH V5 for-next 08/21] RDMA/bnxt_re: Adding support for port related verbs

2017-02-10 Thread Selvin Xavier
lt;sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/infiniband/hw/bnxt_re/ib_verbs.c | 122 +++ drivers/infiniband/hw/bnxt_re/ib_verbs.h | 7 ++ drivers/infiniband/hw/bnxt_re/main.c | 4 + 3 files changed,

[PATCH V5 for-next 14/21] RDMA/bnxt_re: Support post_send verb

2017-02-10 Thread Selvin Xavier
Enables the ib_post_send fastpath verb for posting Send work requests on QPs. v2: Fixed some sparse warnings v3: Fixes endianness related warnings reported by sparse. Changes some of the macros to inline functions. v5: Uses ETH_P_IBOE macro for RoCE ethertype Signed-off-by: Eddie Wai

[PATCH V5 for-next 11/21] RDMA/bnxt_re: Support for AH verbs

2017-02-10 Thread Selvin Xavier
evesh.sha...@broadcom.com> Signed-off-by: Somnath Kotur <somnath.ko...@broadcom.com> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/infiniband/hw/bnxt_re/ib_verbs.c | 148 ++

[PATCH V5 for-next 07/21] RDMA/bnxt_re: Support for query and modify device verbs

2017-02-10 Thread Selvin Xavier
-off-by: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/infiniband/hw/bnxt_re/bnxt_re.h | 7 +++ drivers/infiniband/hw/bnxt_re/ib_verbs.c | 90 +++ drivers/infiniba

Re: [PATCH for bnxt_re V4 03/21] RDMA/bnxt_re: register with the NIC driver

2017-02-10 Thread Selvin Xavier
On Tue, Feb 7, 2017 at 1:56 AM, Doug Ledford wrote: >> +static void bnxt_re_dev_remove(struct bnxt_re_dev *rdev) >> +{ >> + int i = BNXT_RE_REF_WAIT_COUNT; >> + >> + /* Wait for rdev refcount to come down */ >> + while ((atomic_read(>ref_count) > 1) && i--)

[PATCH V5 for-next 04/21] RDMA/bnxt_re: Enabling RoCE control path

2017-02-10 Thread Selvin Xavier
die@broadcom.com> Signed-off-by: Devesh Sharma <devesh.sha...@broadcom.com> Signed-off-by: Somnath Kotur <somnath.ko...@broadcom.com> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> ---

[PATCH V5 for-next 20/21] RDMA/bnxt_re: Add QP event handling

2017-02-10 Thread Selvin Xavier
Devesh Sharma <devesh.sha...@broadcom.com> Signed-off-by: Somnath Kotur <somnath.ko...@broadcom.com> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/infiniban

[PATCH V5 for-next 15/21] RDMA/bnxt_re: Support post_recv

2017-02-10 Thread Selvin Xavier
-by: Somnath Kotur <somnath.ko...@broadcom.com> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/infiniband/hw/bnxt_re/ib_verbs.c | 123 +++ drivers/infiniba

[PATCH V5 for-next 17/21] RDMA/bnxt_re: Handling dispatching of events to IB stack

2017-02-10 Thread Selvin Xavier
@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/infiniband/hw/bnxt_re/main.c | 59 1 file changed, 59 insertions(+) diff --git a/drivers/infiniband/hw/bnxt_re/main.c b/drivers/infiniband/hw/bnxt_re/main.c

[PATCH V5 for-next 21/21] RDMA/bnxt_re: Add bnxt_re driver build support

2017-02-10 Thread Selvin Xavier
omnath.ko...@broadcom.com> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- MAINTAINERS| 11 +++ drivers/infiniband/Kconfig | 2 ++ drivers/infiniband/

[PATCH V5 for-next 03/21] RDMA/bnxt_re: register with the NIC driver

2017-02-10 Thread Selvin Xavier
> Signed-off-by: Somnath Kotur <somnath.ko...@broadcom.com> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/infiniband/hw/bnxt_re/bnxt_re.h | 49 drivers/infi

Re: [PATCH for bnxt_re V4 10/21] RDMA/bnxt_re: Support for CQ verbs

2017-01-18 Thread Selvin Xavier
On Wed, Jan 18, 2017 at 1:49 PM, Leon Romanovsky wrote: > It is better to use already existing macros - min() > cq->max_cql = min(entries, MAX_CQL_PER_POLL); > > I afraid that you can't avoid the respinning, you have more than month > till merge window. > > Can you please remove

Re: [PATCH for bnxt_re V3 03/21] bnxt_re: register with the NIC driver

2017-01-16 Thread Selvin Xavier
On Mon, Jan 16, 2017 at 1:11 AM, Leon Romanovsky wrote: > Recently, in one of our submission to netdev and rdma, we got > a reminder that inline functions shouldn't be in *.c. Let for > the compiler to decide. > > IMHO, it should be open-coded without wrappers and honestly I

Re: [PATCH V2 00/22] Broadcom RoCE Driver (bnxt_re)

2016-12-09 Thread Selvin Xavier
On Fri, Dec 9, 2016 at 12:17 PM, Selvin Xavier <selvin.xav...@broadcom.com> wrote: > I am preparing a git repository with these changes as per Jason's > comment and will share the details later today. Please use bnxt_re branch in this git repository. https://github.com/Broadco

[PATCH V2 14/22] bnxt_re: Support post_send verb

2016-12-08 Thread Selvin Xavier
com> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/infiniband/hw/bnxtre/bnxt_qplib_fp.c| 267 drivers/infiniband/hw/bnxtre/bnxt_qplib_fp.h| 8 + drivers/infiniband/hw/b

[PATCH V2 04/22] bnxt_re: Enabling RoCE control path

2016-12-08 Thread Selvin Xavier
Signed-off-by: Devesh Sharma <devesh.sha...@broadcom.com> Signed-off-by: Somnath Kotur <somnath.ko...@broadcom.com> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/infiniband/hw/

[PATCH V2 16/22] bnxt_re: Support poll_cq verb

2016-12-08 Thread Selvin Xavier
lt;sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/infiniband/hw/bnxtre/bnxt_qplib_fp.c| 553 +++- drivers/infiniband/hw/bnxtre/bnxt_qplib_fp.h| 7 +- drivers/infiniband/hw/bnxtre/bnxt_re_ib_verbs.c | 521 +

[PATCH V2 02/22] bnxt_re: Introducing autogenerated Host Software Interface(hsi) file

2016-12-08 Thread Selvin Xavier
-by: Eddie Wai <eddie@broadcom.com> Signed-off-by: Devesh Sharma <devesh.sha...@broadcom.com> Signed-off-by: Somnath Kotur <somnath.ko...@broadcom.com> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...

[PATCH V2 05/22] bnxt_re: Adding Notification Queue support

2016-12-08 Thread Selvin Xavier
<somnath.ko...@broadcom.com> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/infiniband/hw/bnxtre/bnxt_qplib_fp.c | 160 ++ drivers/infiniband/hw/bnxtre/bnxt_qplib_f

[PATCH V2 03/22] bnxt_re: register with the NIC driver

2016-12-08 Thread Selvin Xavier
die@broadcom.com> Signed-off-by: Devesh Sharma <devesh.sha...@broadcom.com> Signed-off-by: Somnath Kotur <somnath.ko...@broadcom.com> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/

[PATCH V2 13/22] bnxt_re: Support QP verbs

2016-12-08 Thread Selvin Xavier
-off-by: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/infiniband/hw/bnxtre/bnxt_qplib_fp.c| 873 drivers/infiniband/hw/bnxtre/bnxt_qplib_fp.h| 250 +++ drivers/

[PATCH V2 21/22] bnxt_re: Add QP event handling

2016-12-08 Thread Selvin Xavier
<somnath.ko...@broadcom.com> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/infiniband/hw/bnxtre/bnxt_qplib_rcfw.c | 49 ++ 1 file changed, 49 insertions(+) d

[PATCH V2 22/22] bnxt_re: Add bnxt_re driver build support

2016-12-08 Thread Selvin Xavier
Makefile and Kconfig changes for enabling bnxt_re compilation Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/infiniband/Kconfig| 2 ++ drivers/infiniband/hw/Makefile| 1 + drivers/infiniband/hw/bnxtre/Kconfig | 9 + drivers/infiniband/hw/

[PATCH V2 09/22] bnxt_re: Support for GID related verbs

2016-12-08 Thread Selvin Xavier
lt;sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/infiniband/hw/bnxtre/bnxt_qplib_res.c | 5 + drivers/infiniband/hw/bnxtre/bnxt_qplib_res.h | 3 + drivers/infiniband/hw/bnxtre/bnxt_qplib_sp.c| 218

[PATCH V2 11/22] bnxt_re: Support for AH verbs

2016-12-08 Thread Selvin Xavier
harsha Basavapatna <sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/infiniband/hw/bnxtre/bnxt_qplib_sp.c| 94 +++ drivers/infiniband/hw/bnxtre/bnxt_qplib_sp.h| 18 +++ drivers/infiniband/hw/b

[PATCH V2 07/22] bnxt_re: Support for query and modify device verbs

2016-12-08 Thread Selvin Xavier
lt;sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/infiniband/hw/bnxtre/bnxt_qplib_res.c | 17 + drivers/infiniband/hw/bnxtre/bnxt_qplib_res.h | 1 + drivers/infiniband/hw/bnxtre/bnxt_re.h | 7 ++ drivers/infiniband/hw/

[PATCH V2 15/22] bnxt_re: Support post_recv

2016-12-08 Thread Selvin Xavier
adcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/infiniband/hw/bnxtre/bnxt_qplib_fp.c| 100 ++ drivers/infiniband/hw/bnxtre/bnxt_qplib_fp.h| 8 ++ drivers/infiniband/hw/bnxtre/bnxt_re_ib_verbs.c | 133

[PATCH V2 08/22] bnxt_re: Adding support for port related verbs

2016-12-08 Thread Selvin Xavier
lt;sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/infiniband/hw/bnxtre/bnxt_re_ib_verbs.c | 122 drivers/infiniband/hw/bnxtre/bnxt_re_ib_verbs.h | 7 ++ drivers/infiniband/hw/bnxtre/bnxt_re_main.c | 4 + 3

[PATCH V2 10/22] bnxt_re: Support for CQ verbs

2016-12-08 Thread Selvin Xavier
harsha Basavapatna <sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/infiniband/hw/bnxtre/bnxt_qplib_fp.c| 183 drivers/infiniband/hw/bnxtre/bnxt_qplib_fp.h| 47 ++ drivers/infiniband/hw/b

[PATCH V2 06/22] bnxt_re: Support for PD, ucontext and mmap verbs

2016-12-08 Thread Selvin Xavier
com> Signed-off-by: Devesh Sharma <devesh.sha...@broadcom.com> Signed-off-by: Somnath Kotur <somnath.ko...@broadcom.com> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/infinib

[PATCH V2 18/22] bnxt_re: Support for DCB

2016-12-08 Thread Selvin Xavier
die@broadcom.com> Signed-off-by: Devesh Sharma <devesh.sha...@broadcom.com> Signed-off-by: Somnath Kotur <somnath.ko...@broadcom.com> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/infini

[PATCH V2 00/22] Broadcom RoCE Driver (bnxt_re)

2016-12-08 Thread Selvin Xavier
dma repository. Thanks, Selvin Xavier Selvin Xavier (22): bnxt_re: Add bnxt_re RoCE driver files bnxt_re: Introducing autogenerated Host Software Interface(hsi) file bnxt_re: register with the NIC driver bnxt_re: Enabling RoCE control path bnxt_re: Adding Notification Queue support bnxt

[PATCH V2 01/22] bnxt_re: Add bnxt_re RoCE driver files

2016-12-08 Thread Selvin Xavier
evesh.sha...@broadcom.com> Signed-off-by: Somnath Kotur <somnath.ko...@broadcom.com> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/infiniband/hw/bnxtre/bnxt_qplib_fp.c| 37

[PATCH V2 19/22] bnxt_re: Support debugfs

2016-12-08 Thread Selvin Xavier
@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/infiniband/hw/bnxtre/bnxt_re_debugfs.c | 159 + drivers/infiniband/hw/bnxtre/bnxt_re_debugfs.h | 48 drivers/infiniband/hw/bnxtre/bnxt_re_main.c| 8 +- 3 files

[PATCH V2 12/22] bnxt_re: Support memory registration verbs

2016-12-08 Thread Selvin Xavier
omnath Kotur <somnath.ko...@broadcom.com> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/infiniband/hw/bnxtre/bnxt_qplib_sp.c| 324 drivers/infiniband/hw/b

[PATCH V2 20/22] bnxt_re: Set uverbs command mask

2016-12-08 Thread Selvin Xavier
omnath Kotur <somnath.ko...@broadcom.com> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/infiniband/hw/bnxtre/bnxt_re_main.c | 36 + 1 file changed, 36 inser

[PATCH V2 17/22] bnxt_re: Handling dispatching of events to IB stack

2016-12-08 Thread Selvin Xavier
com> Signed-off-by: Devesh Sharma <devesh.sha...@broadcom.com> Signed-off-by: Somnath Kotur <somnath.ko...@broadcom.com> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/infiniband

Re: [PATCH V2 00/22] Broadcom RoCE Driver (bnxt_re)

2016-12-12 Thread Selvin Xavier
w comments and fix the 0day compilation error and post a v3 soon. Thanks, Selvin Xavier

Re: [PATCH V2 13/22] bnxt_re: Support QP verbs

2016-12-12 Thread Selvin Xavier
On Mon, Dec 12, 2016 at 11:57 PM, Leon Romanovsky wrote: > It can help to review if you break this function into smaller pieces and > get rid of switch->switch->if construction. Thanks Leon. I will address this and your previous comments in v3 patch set.

Re: [PATCH V2 00/22] Broadcom RoCE Driver (bnxt_re)

2016-12-13 Thread Selvin Xavier
On Tue, Dec 13, 2016 at 1:29 PM, Or Gerlitz wrote: > I made some quick on-the-surface static checkers etc rub on the new > driver (Doug, I used > the bits in your github bnxt_re branch), there are bunch (tons...) of > smatch [1] and sparse [2] > complaints along with few

Re: [PATCH V2 00/22] Broadcom RoCE Driver (bnxt_re)

2016-12-12 Thread Selvin Xavier
On Mon, Dec 12, 2016 at 10:24 PM, Jonathan Toppins wrote: > CHECK drivers/infiniband/hw/bnxtre/bnxt_re_debugfs.c > CHECK drivers/infiniband/hw/bnxtre/bnxt_qplib_res.c > drivers/infiniband/hw/bnxtre/bnxt_qplib_res.c:729:6: warning: symbol > 'bnxt_qplib_cleanup_pkey_tbl'

Re: [PATCH V2 18/22] bnxt_re: Support for DCB

2016-12-12 Thread Selvin Xavier
On Sat, Dec 10, 2016 at 7:20 PM, Or Gerlitz <gerlitz...@gmail.com> wrote: > On Fri, Dec 9, 2016 at 8:48 AM, Selvin Xavier > <selvin.xav...@broadcom.com> wrote: >> This patch queries the configured RoCE APP Priority on the host >> using the dcbnl API and programs the

Re: [PATCH V2 00/22] Broadcom RoCE Driver (bnxt_re)

2016-12-12 Thread Selvin Xavier
On Mon, Dec 12, 2016 at 10:37 PM, Jason Gunthorpe <jguntho...@obsidianresearch.com> wrote: > On Sat, Dec 10, 2016 at 11:06:58AM +0530, Selvin Xavier wrote: >> On Fri, Dec 9, 2016 at 12:17 PM, Selvin Xavier >> <selvin.xav...@broadcom.com> wrote: >>

Re: [PATCH V2 00/22] Broadcom RoCE Driver (bnxt_re)

2016-12-09 Thread Selvin Xavier
On Fri, Dec 9, 2016 at 8:56 PM, David Miller <da...@davemloft.net> wrote: > From: Selvin Xavier <selvin.xav...@broadcom.com> > Date: Thu, 8 Dec 2016 22:47:54 -0800 > >> This series introduces the RoCE driver for the Broadcom >> NetXtreme-E 10/25/40/50

[PATCH 07/28] bnxt_en: Add interface to support RDMA driver.

2016-12-04 Thread Selvin Xavier
Cc: <netdev@vger.kernel.org> Signed-off-by: Michael Chan <michael.c...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/Makefile | 2 +- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 34 ++- drivers/net/ethernet/

[PATCH 05/28] bnxt_en: Reserve RDMA resources by default.

2016-12-04 Thread Selvin Xavier
served until the RDMA driver registers. Cc: David Miller <da...@davemloft.net> Cc: <netdev@vger.kernel.org> Signed-off-by: Michael Chan <michael.c...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/net/ethe

[PATCH 01/28] bnxt_en: Add bnxt_set_max_func_irqs().

2016-12-04 Thread Selvin Xavier
adcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 17 +++-- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 1 + 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b

[PATCH 02/28] bnxt_en: Enable MSIX early in bnxt_init_one().

2016-12-04 Thread Selvin Xavier
t.net> Cc: <netdev@vger.kernel.org> Signed-off-by: Michael Chan <michael.c...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 183 +++--- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 1 + 2

[PATCH 06/28] bnxt_en: Refactor the driver registration function with firmware.

2016-12-04 Thread Selvin Xavier
into 2 parts so that we can just update the async events for the RDMA driver. Cc: David Miller <da...@davemloft.net> Cc: <netdev@vger.kernel.org> Signed-off-by: Michael Chan <michael.c...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/net

[PATCH 04/28] bnxt_en: Improve completion ring allocation for VFs.

2016-12-04 Thread Selvin Xavier
adcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 8 +++- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 2 +- drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c | 14 -- 3 files changed, 12 insertions(+

[PATCH 03/28] bnxt_en: Move function reset to bnxt_init_one().

2016-12-04 Thread Selvin Xavier
reset now is in bnxt_init_one(). If we get AER, we'll do function reset as well. Cc: David Miller <da...@davemloft.net> Cc: <netdev@vger.kernel.org> Signed-off-by: Michael Chan <michael.c...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- driv

[PATCH for bnxt_re V4 00/21] Broadcom RoCE Driver (bnxt_re)

2016-12-21 Thread Selvin Xavier
uapi/rdma folder * Remove duplicate structure definitions from bnxt_re_hsi.h as it is available in the corresponding bnxt_en header file (bnxt_hsi.h) * Removed some unused code reported during code review. * Fixed few sparse warnings Selvin Xavier (21): RDMA/bnxt_re: Add bnxt_re RoCE dri

[PATCH for bnxt_re V4 01/21] RDMA/bnxt_re: Add bnxt_re RoCE driver files

2016-12-21 Thread Selvin Xavier
die@broadcom.com> Signed-off-by: Devesh Sharma <devesh.sha...@broadcom.com> Signed-off-by: Somnath Kotur <somnath.ko...@broadcom.com> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> ---

[PATCH for bnxt_re V4 17/21] RDMA/bnxt_re: Handling dispatching of events to IB stack

2016-12-21 Thread Selvin Xavier
Wai <eddie@broadcom.com> Signed-off-by: Devesh Sharma <devesh.sha...@broadcom.com> Signed-off-by: Somnath Kotur <somnath.ko...@broadcom.com> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.c

[PATCH for bnxt_re V4 18/21] RDMA/bnxt_re: Support for DCB

2016-12-21 Thread Selvin Xavier
lt;sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/infiniband/hw/bnxt_re/bnxt_re.h | 5 ++ drivers/infiniband/hw/bnxt_re/main.c | 140 +++ drivers/infiniband/hw/bnxt_re/qplib_sp.c | 37

[PATCH for bnxt_re V4 15/21] RDMA/bnxt_re: Support post_recv

2016-12-21 Thread Selvin Xavier
lt;sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/infiniband/hw/bnxt_re/ib_verbs.c | 123 +++ drivers/infiniband/hw/bnxt_re/ib_verbs.h | 2 + drivers/infiniband/hw/bnxt_re/main.c | 2 + drivers/infiniba

[PATCH for bnxt_re V4 02/21] RDMA/bnxt_re: Introducing autogenerated Host Software Interface(hsi) file

2016-12-21 Thread Selvin Xavier
avapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/infiniband/hw/bnxt_re/roce_hsi.h | 2779 ++ 1 file changed, 2779 insertions(+) diff --git a/drivers/infiniband/hw/bnxt_re/roce_hsi.h b/drivers/infiniband/hw/bnxt_re/roc

[PATCH for bnxt_re V4 10/21] RDMA/bnxt_re: Support for CQ verbs

2016-12-21 Thread Selvin Xavier
; Signed-off-by: Somnath Kotur <somnath.ko...@broadcom.com> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/infiniband/hw/bnxt_re/ib_verbs.c | 146 + drivers/infiniba

[PATCH for bnxt_re V4 16/21] RDMA/bnxt_re: Support poll_cq verb

2016-12-21 Thread Selvin Xavier
; Signed-off-by: Somnath Kotur <somnath.ko...@broadcom.com> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/infiniband/hw/bnxt_re/ib_verbs.c | 522 drivers/infiniba

[PATCH for bnxt_re V4 11/21] RDMA/bnxt_re: Support for AH verbs

2016-12-21 Thread Selvin Xavier
omnath Kotur <somnath.ko...@broadcom.com> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/infiniband/hw/bnxt_re/ib_verbs.c | 147 +++ drivers/infiniband/hw/bnxt_re

[PATCH for bnxt_re V4 14/21] RDMA/bnxt_re: Support post_send verb

2016-12-21 Thread Selvin Xavier
Enables the ib_post_send fastpath verb for posting Send work requests on QPs. v2: Fixed some sparse warnings v3: Fixes endianness related warnings reported by sparse. Changes some of the macros to inline functions. Signed-off-by: Eddie Wai Signed-off-by: Devesh

[PATCH for bnxt_re V4 08/21] RDMA/bnxt_re: Adding support for port related verbs

2016-12-21 Thread Selvin Xavier
lt;sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/infiniband/hw/bnxt_re/ib_verbs.c | 122 +++ drivers/infiniband/hw/bnxt_re/ib_verbs.h | 7 ++ drivers/infiniband/hw/bnxt_re/main.c | 4 + 3 files changed,

[PATCH for bnxt_re V4 20/21] RDMA/bnxt_re: Add QP event handling

2016-12-21 Thread Selvin Xavier
; Signed-off-by: Somnath Kotur <somnath.ko...@broadcom.com> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/infiniband/hw/bnxt_re/qplib_rcfw.c | 47 ++ 1 file c

[PATCH for bnxt_re V4 07/21] RDMA/bnxt_re: Support for query and modify device verbs

2016-12-21 Thread Selvin Xavier
-off-by: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/infiniband/hw/bnxt_re/bnxt_re.h | 7 +++ drivers/infiniband/hw/bnxt_re/ib_verbs.c | 90 +++ drivers/infiniba

[PATCH for bnxt_re V4 19/21] RDMA/bnxt_re: Set uverbs command mask

2016-12-21 Thread Selvin Xavier
evesh.sha...@broadcom.com> Signed-off-by: Somnath Kotur <somnath.ko...@broadcom.com> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/infiniband/hw/bnxt_re/main.c | 35 +

[PATCH for bnxt_re V4 21/21] RDMA/bnxt_re: Add bnxt_re driver build support

2016-12-21 Thread Selvin Xavier
omnath.ko...@broadcom.com> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- MAINTAINERS| 11 +++ drivers/infiniband/Kconfig | 2 ++ drivers/infiniband/

[PATCH for bnxt_re V4 03/21] RDMA/bnxt_re: register with the NIC driver

2016-12-21 Thread Selvin Xavier
com> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/infiniband/hw/bnxt_re/bnxt_re.h | 51 drivers/infiniband/hw/bnxt_re/main.c| 448 2 files ch

[PATCH for bnxt_re V4 09/21] RDMA/bnxt_re: Support for GID related verbs

2016-12-21 Thread Selvin Xavier
adcom.com> Signed-off-by: Somnath Kotur <somnath.ko...@broadcom.com> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/infiniband/hw/bnxt_re/ib_verbs.c | 123 +

[PATCH for bnxt_re V4 04/21] RDMA/bnxt_re: Enabling RoCE control path

2016-12-21 Thread Selvin Xavier
adcom.com> Signed-off-by: Somnath Kotur <somnath.ko...@broadcom.com> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/infiniband/hw/bnxt_re/bnxt_re.h| 15 + drivers/infiniband

[PATCH for bnxt_re V4 06/21] RDMA/bnxt_re: Support for PD, ucontext and mmap verbs

2016-12-21 Thread Selvin Xavier
. Signed-off-by: Eddie Wai <eddie@broadcom.com> Signed-off-by: Devesh Sharma <devesh.sha...@broadcom.com> Signed-off-by: Somnath Kotur <somnath.ko...@broadcom.com> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <

[PATCH for bnxt_re V4 13/21] RDMA/bnxt_re: Support QP verbs

2016-12-21 Thread Selvin Xavier
<eddie@broadcom.com> Signed-off-by: Devesh Sharma <devesh.sha...@broadcom.com> Signed-off-by: Somnath Kotur <somnath.ko...@broadcom.com> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com&

[PATCH for bnxt_re V4 12/21] RDMA/bnxt_re: Support memory registration verbs

2016-12-21 Thread Selvin Xavier
-off-by: Eddie Wai <eddie@broadcom.com> Signed-off-by: Devesh Sharma <devesh.sha...@broadcom.com> Signed-off-by: Somnath Kotur <somnath.ko...@broadcom.com> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <

[PATCH for bnxt_re V4 05/21] RDMA/bnxt_re: Adding Notification Queue support

2016-12-21 Thread Selvin Xavier
ed-off-by: Devesh Sharma <devesh.sha...@broadcom.com> Signed-off-by: Somnath Kotur <somnath.ko...@broadcom.com> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/infiniband/hw/bnxt_re

[PATCH for bnxt_re V3 12/21] bnxt_re: Support memory registration verbs

2016-12-20 Thread Selvin Xavier
-off-by: Eddie Wai <eddie@broadcom.com> Signed-off-by: Devesh Sharma <devesh.sha...@broadcom.com> Signed-off-by: Somnath Kotur <somnath.ko...@broadcom.com> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <

[PATCH for bnxt_re V3 05/21] bnxt_re: Adding Notification Queue support

2016-12-20 Thread Selvin Xavier
evesh.sha...@broadcom.com> Signed-off-by: Somnath Kotur <somnath.ko...@broadcom.com> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/infiniband/hw/bnxtre/bnxt_qplib_fp.c | 161 +

[PATCH for bnxt_re V3 06/21] bnxt_re: Support for PD, ucontext and mmap verbs

2016-12-20 Thread Selvin Xavier
omnath Kotur <somnath.ko...@broadcom.com> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/infiniband/hw/bnxtre/bnxt_qplib_res.c | 28 +++ drivers/infiniband/hw/bnxtre/bnxt_

[PATCH for bnxt_re V3 02/21] bnxt_re: Introducing autogenerated Host Software Interface(hsi) file

2016-12-20 Thread Selvin Xavier
avapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/infiniband/hw/bnxtre/bnxt_re_hsi.h | 2779 1 file changed, 2779 insertions(+) diff --git a/drivers/infiniband/hw/bnxtre/bnxt_re_hsi.h b/drivers/infiniband/hw/bnxt

[PATCH for bnxt_re V3 17/21] bnxt_re: Handling dispatching of events to IB stack

2016-12-20 Thread Selvin Xavier
Wai <eddie@broadcom.com> Signed-off-by: Devesh Sharma <devesh.sha...@broadcom.com> Signed-off-by: Somnath Kotur <somnath.ko...@broadcom.com> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.c

[PATCH for bnxt_re V3 20/21] bnxt_re: Add QP event handling

2016-12-20 Thread Selvin Xavier
; Signed-off-by: Somnath Kotur <somnath.ko...@broadcom.com> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/infiniband/hw/bnxtre/bnxt_qplib_rcfw.c | 47 ++ 1 file c

[PATCH for bnxt_re V3 04/21] bnxt_re: Enabling RoCE control path

2016-12-20 Thread Selvin Xavier
omnath Kotur <somnath.ko...@broadcom.com> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/infiniband/hw/bnxtre/bnxt_qplib_rcfw.c | 608 drivers/infiniband/hw/

[PATCH for bnxt_re V3 15/21] bnxt_re: Support post_recv

2016-12-20 Thread Selvin Xavier
lt;sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/infiniband/hw/bnxtre/bnxt_qplib_fp.c| 100 +++ drivers/infiniband/hw/bnxtre/bnxt_qplib_fp.h| 8 ++ drivers/infiniband/hw/bnxtre/bnxt_re_ib_verbs.c | 123 +++

[PATCH for bnxt_re V3 19/21] bnxt_re: Set uverbs command mask

2016-12-20 Thread Selvin Xavier
omnath Kotur <somnath.ko...@broadcom.com> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/infiniband/hw/bnxtre/bnxt_re_main.c | 35 + 1 file changed, 35 inser

[PATCH for bnxt_re V3 21/21] bnxt_re: Add bnxt_re driver build support

2016-12-20 Thread Selvin Xavier
omnath.ko...@broadcom.com> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- MAINTAINERS | 11 +++ drivers/infiniband/Kconfig| 2 ++ drivers/infiniband

[PATCH for bnxt_re V3 18/21] bnxt_re: Support for DCB

2016-12-20 Thread Selvin Xavier
lt;sriharsha.basavapa...@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com> --- drivers/infiniband/hw/bnxtre/bnxt_qplib_sp.c | 37 +++ drivers/infiniband/hw/bnxtre/bnxt_qplib_sp.h | 1 + drivers/infiniband/hw/bnxtre/bnxt_re.h | 5 + drivers/infiniband/h

  1   2   >