[PATCH] NET: [CORE] Re-enable irqs before pushing pending DMA requests

2007-06-21 Thread Shannon Nelson
This moves the local_irq_enable() call in net_rx_action() to before calling the CONFIG_NET_DMA's dma_async_memcpy_issue_pending() rather than after. This shortens the irq disabled window and allows for DMA drivers that need to do their own irq hold. Signed-off-by: Shannon Nelson [EMAIL PROTECTED

[PATCH] NET_DMA: remove unused dma_memcpy_to_kernel_iovec

2007-07-24 Thread Shannon Nelson
Al Viro pointed out that dma_memcpy_to_kernel_iovec() really was unreachable and thus unused. The code originally was there to support in-kernel dma needs, but since it remains unused, we'll pull it out. Signed-off-by: Shannon Nelson [EMAIL PROTECTED] --- drivers/dma/iovlock.c | 27

[PATCH] NET_DMA: remove unused dma_memcpy_to_kernel_iovec

2007-07-24 Thread Shannon Nelson
(repost - original eaten by vger?) Al Viro pointed out that dma_memcpy_to_kernel_iovec() really was unreachable and thus unused. The code originally was there to support in-kernel dma needs, but since it remains unused, we'll pull it out. Signed-off-by: Shannon Nelson [EMAIL PROTECTED

[PATCH] IOAT: ioatdma needs to to play nice in a multi-dma-client world

2007-08-22 Thread Shannon Nelson
Now that the DMA engine has a multi-client interface, fix the ioatdma driver to play along. At the same time, remove a couple of unnecessary reads and writes. Signed-off-by: Shannon Nelson [EMAIL PROTECTED] --- drivers/dma/ioatdma.c | 18 -- 1 files changed, 4 insertions

Re: [PATCH -mm] [RFC] I/OAT: Handle incoming udp through ioatdma

2007-11-29 Thread Shannon Nelson
Argh - mind the line breaks... sln On Nov 29, 2007 12:08 PM, Nelson, Shannon [EMAIL PROTECTED] wrote: [RFC] I/OAT: Handle incoming udp through ioatdma From: Shannon Nelson [EMAIL PROTECTED] If the incoming udp packet is larger than sysctl_udp_dma_copybreak, try pushing it through

Re: [PATCH] i40e: remove unneeded tests

2015-05-27 Thread Shannon Nelson
On Tue, May 26, 2015 at 1:26 PM, Laurent Navet laurent.na...@gmail.com wrote: The same code is executed regardless ret_code value, so these tests can be removed. Fix Coverity CID 1268789 and 1268791 Signed-off-by: Laurent Navet laurent.na...@gmail.com ---

Re: [RFC 1/2] net/ethtool: Add new coalescing parameter for queue

2015-12-08 Thread Shannon Nelson
On Mon, Dec 7, 2015 at 8:42 PM, wrote: > From: Kan Liang > > Intrdouce "queue" option for coalesce getting and setting. s/Intrdouce/Introduce/ > For coalesce getting, only the coalescing parameters from specific > queue will be passed to user space. >

Re: [RFC 1/1] ethtool: support per queue coalesce options

2015-12-08 Thread Shannon Nelson
On Mon, Dec 7, 2015 at 8:44 PM, wrote: > From: Kan Liang > > Intruduce new coalesce option "queue" to get/set coalesce value to s/Intruduce/Introduce/ [...] > diff --git a/ethtool.c b/ethtool.c > index 92c40b8..7c644db 100644 > --- a/ethtool.c > +++

Re: [PATCH RESEND v7] i40e: Look up MAC address in Open Firmware or IDPROM

2015-12-04 Thread Shannon Nelson
mac address was default or not, and in the latter > case, will trigger the calls to i40e_aq_mac_address_write() and > i40e_aq_add_macvlan(). > > Reviewed-by: Martin K. Petersen <martin.peter...@oracle.com> > Signed-off-by: Sowmini Varadhan <sowmini.varad...@oracle.com> &g

Re: [PATCH v9] i40e: Look up MAC address in Open Firmware or IDPROM

2015-12-07 Thread Shannon Nelson
Acked-by: Shannon Nelson <shannon.nel...@intel.com On Mon, Dec 7, 2015 at 1:28 PM, David Miller <da...@davemloft.net> wrote: > From: Sowmini Varadhan <sowmini.varad...@oracle.com> > Date: Mon, 7 Dec 2015 15:06:34 -0500 > >> This is the i40e equivalent of commit c76

Re: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob

2016-02-09 Thread Shannon Nelson
> bus/slot. I think you should search only there, so solving the > multiple device issue. > > Andrew -- ====== Mr. Shannon NelsonNetwork Division, Intel Corp. shannon.nel...@intel.comI don't

Re: [PATCH] i40e: remove redundant check on vsi->active_vlans

2016-02-16 Thread Shannon Nelson
& = %p\n", vsi->active_vlans); > dev_info(>pdev->dev, > "netdev_registered = %i, current_netdev_flags = 0x%04x, > state = %li flags = 0x%08lx\n", > vsi->netdev_registered, > -- > 2.7.0 > Acked-by: Shan

Re: [PATCH net-next 5/9] sunvnet: add memory barrier before check for tx enable

2017-02-03 Thread Shannon Nelson
On 2/3/2017 9:56 AM, Eric Dumazet wrote: On Fri, 2017-02-03 at 09:42 -0800, Shannon Nelson wrote: In order to allow the underlying LDC and outstanding memory operations to potentially catch up with the driver's Tx requests, add a memory barrier before checking again for available tx descriptors

Re: [PATCH net-next 9/9] ldmvsw: disable tso and gso for bridge operations

2017-02-03 Thread Shannon Nelson
On 2/3/2017 9:59 AM, Eric Dumazet wrote: On Fri, 2017-02-03 at 09:42 -0800, Shannon Nelson wrote: The ldmvsw driver is specifically for supporting the ldom virtual networking by running in the primary ldom and using the LDC to connect the remaining ldoms to the outside world via a bridge

[PATCH net-next 3/9] sunvnet: update version and version printing

2017-02-03 Thread Shannon Nelson
There have been several changes since the first version of this code, so we bump the version number. While we're at it, we can simplify the version printing a bit and drop a couple lines of code. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/sun

[PATCH net-next 8/9] ldmvsw: update and simplify version string

2017-02-03 Thread Shannon Nelson
New version and simplify the print code. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/ldmvsw.c | 14 -- 1 files changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/net/ethernet/sun/ldmvsw.c b/drivers/net/ethernet/sun/ld

[PATCH net-next 4/9] sunvnet: add driver stats for ethtool support

2017-02-03 Thread Shannon Nelson
Since we're collecting some stats in the driver code, let's support use of the ethtool driver stats facility in both sunvnet and ldmvsw. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/ldmvsw.c | 63 + drive

[PATCH net-next 1/9] sunvnet: make sunvnet common code dynamically loadable

2017-02-03 Thread Shannon Nelson
in kernels that aren't running the LDoms. This patch makes the sunvnet_common into a dynamically loadable module and makes sunvnet and ldmvsw dependent on sunvnet_common. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/Kconfig |9 ++--- drive

[PATCH net-next 9/9] ldmvsw: disable tso and gso for bridge operations

2017-02-03 Thread Shannon Nelson
by delayed packets, enough to begin triggering retransmits and affecting overall throughput. By turning off advertised support for TSO and GSO we restore stable traffic flow through the bridge. Orabug: 23293104 Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethern

[PATCH net-next 7/9] sunvnet: remove extra rcu_read_unlocks

2017-02-03 Thread Shannon Nelson
ahe...@oracle.com> Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/sunvnet_common.c |8 ++-- 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/sun/sunvnet_common.c b/drivers/net/ethernet/sun/sunvnet_common.c i

[PATCH net-next 6/9] sunvnet: straighten up message event handling logic

2017-02-03 Thread Shannon Nelson
The use of gotos for handling the incoming events made this code harder to read and support than it should be. This patch straightens out and clears up the logic. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/sunvnet_common.c

[PATCH net-next 0/9] sunvnet driver updates

2017-02-03 Thread Shannon Nelson
The sunvnet ldom virtual network driver was due for some updates and a bugfix or two. These patches address a few items left over from last year's make-over. Shannon Nelson (8): sunvnet: make sunvnet common code dynamically loadable sunvnet: update version and version printing sunvnet: add

[PATCH net-next 2/9] sunvnet: remove unused variable in maybe_tx_wakeup

2017-02-03 Thread Shannon Nelson
nother START message at the next TX and trigger the consumer to drain the dring. Signed-off-by: Sowmini Varadhan <sowmini.varad...@oracle.com> Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/sunvnet_common.c |6 +- 1 files changed,

[PATCH net-next 5/9] sunvnet: add memory barrier before check for tx enable

2017-02-03 Thread Shannon Nelson
In order to allow the underlying LDC and outstanding memory operations to potentially catch up with the driver's Tx requests, add a memory barrier before checking again for available tx descriptors. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethern

Re: [PATCH net-next 5/9] sunvnet: add memory barrier before check for tx enable

2017-02-04 Thread Shannon Nelson
On 2/3/2017 2:11 PM, Eric Dumazet wrote: Transmit completion might happen on another cpu, regardless of ldom. Therefore you need smp_rmb() here ( like mellanox/mlx4/en_tx.c) , or even smp_mb() as bnx2x does. dma_rmb() is never used in this context. In that case, it looks like there are a

Re: [PATCH v2 net-next 6/9] sunvnet: straighten up message event handling logic

2017-02-08 Thread Shannon Nelson
On 2/8/2017 7:59 AM, Sowmini Varadhan wrote: On (02/07/17 14:12), Shannon Nelson wrote: + + /* we don't expect any other bits */ + BUG_ON(port->rx_event & ~(LDC_EVENT_DATA_READY | + LDC_EVENT_RESET | + LDC_E

[PATCH v2 net-next 4/9] sunvnet: add driver stats for ethtool support

2017-02-07 Thread Shannon Nelson
Since we're collecting some stats in the driver code, let's support use of the ethtool driver stats facility in both sunvnet and ldmvsw. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/ldmvsw.c | 63 + drive

[PATCH v2 net-next 6/9] sunvnet: straighten up message event handling logic

2017-02-07 Thread Shannon Nelson
The use of gotos for handling the incoming events made this code harder to read and support than it should be. This patch straightens out and clears up the logic. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/sunvnet_common.c

[PATCH v2 net-next 7/9] sunvnet: remove extra rcu_read_unlocks

2017-02-07 Thread Shannon Nelson
ahe...@oracle.com> Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/sunvnet_common.c |8 ++-- 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/sun/sunvnet_common.c b/drivers/net/ethernet/sun/sunvnet_common.c i

[PATCH v2 net-next 2/9] sunvnet: remove unused variable in maybe_tx_wakeup

2017-02-07 Thread Shannon Nelson
nother START message at the next TX and trigger the consumer to drain the dring. Signed-off-by: Sowmini Varadhan <sowmini.varad...@oracle.com> Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/sunvnet_common.c |6 +- 1 files changed,

[PATCH v2 net-next 1/9] sunvnet: make sunvnet common code dynamically loadable

2017-02-07 Thread Shannon Nelson
in kernels that aren't running the LDoms. This patch makes the sunvnet_common into a dynamically loadable module and makes sunvnet and ldmvsw dependent on sunvnet_common. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/Kconfig |8 ++-- drive

[PATCH v2 net-next 9/9] ldmvsw: disable tso and gso for bridge operations

2017-02-07 Thread Shannon Nelson
by delayed packets, enough to begin triggering retransmits and affecting overall throughput. By turning off advertised support for TSO and GSO we restore stable traffic flow through the bridge. Orabug: 23293104 Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethern

[PATCH v2 net-next 5/9] sunvnet: add memory barrier before check for tx enable

2017-02-07 Thread Shannon Nelson
In order to allow the underlying LDC and outstanding memory operations to potentially catch up with the driver's Tx requests, add a memory barrier before checking again for available tx descriptors. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethern

[PATCH v2 net-next 8/9] ldmvsw: update and simplify version string

2017-02-07 Thread Shannon Nelson
New version and simplify the print code. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/ldmvsw.c | 14 -- 1 files changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/net/ethernet/sun/ldmvsw.c b/drivers/net/ethernet/sun/ld

[PATCH v2 net-next 3/9] sunvnet: update version and version printing

2017-02-07 Thread Shannon Nelson
There have been several changes since the first version of this code, so we bump the version number. While we're at it, we can simplify the version printing a bit and drop a couple lines of code. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/sun

[PATCH v2 net-next 0/9] sunvnet driver updates

2017-02-07 Thread Shannon Nelson
The sunvnet ldom virtual network driver was due for some updates and a bugfix or two. These patches address a few items left over from last year's make-over. v2: - changed memory barrier fix to use smp_wmb - put NETIF_F_SG back into the advertised ldmvsw hw_features Shannon Nelson (8

Re: [PATCH v2 net-next 1/9] sunvnet: make sunvnet common code dynamically loadable

2017-02-08 Thread Shannon Nelson
On 2/8/2017 11:29 AM, David Miller wrote: From: Shannon Nelson <shannon.nel...@oracle.com> Date: Tue, 7 Feb 2017 14:12:54 -0800 +static int __init sunvnet_common_init(void) +{ + pr_info("%s\n", version); + return 0; +} +module_init(sunvnet_common_init); + +st

[PATCH v3 net-next 5/9] sunvnet: add memory barrier before check for tx enable

2017-02-10 Thread Shannon Nelson
In order to allow the underlying LDC and outstanding memory operations to potentially catch up with the driver's Tx requests, add a memory barrier before checking again for available tx descriptors. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethern

[PATCH v3 net-next 7/9] sunvnet: remove extra rcu_read_unlocks

2017-02-10 Thread Shannon Nelson
ahe...@oracle.com> Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/sunvnet_common.c |8 ++-- 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/sun/sunvnet_common.c b/drivers/net/ethernet/sun/sunvnet_common.c i

[PATCH v3 net-next 2/9] sunvnet: remove unused variable in maybe_tx_wakeup

2017-02-10 Thread Shannon Nelson
nother START message at the next TX and trigger the consumer to drain the dring. Signed-off-by: Sowmini Varadhan <sowmini.varad...@oracle.com> Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/sunvnet_common.c |6 +- 1 files changed,

[PATCH v3 net-next 8/9] ldmvsw: update and simplify version string

2017-02-10 Thread Shannon Nelson
New version and simplify the print code. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/ldmvsw.c | 14 -- 1 files changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/net/ethernet/sun/ldmvsw.c b/drivers/net/ethernet/sun/ld

[PATCH v3 net-next 9/9] ldmvsw: disable tso and gso for bridge operations

2017-02-10 Thread Shannon Nelson
by delayed packets, enough to begin triggering retransmits and affecting overall throughput. By turning off advertised support for TSO and GSO we restore stable traffic flow through the bridge. Orabug: 23293104 Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethern

[PATCH v3 net-next 6/9] sunvnet: straighten up message event handling logic

2017-02-10 Thread Shannon Nelson
The use of gotos for handling the incoming events made this code harder to read and support than it should be. This patch straightens out and clears up the logic. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/sunvnet_common.c

[PATCH v3 net-next 4/9] sunvnet: add driver stats for ethtool support

2017-02-10 Thread Shannon Nelson
Since we're collecting some stats in the driver code, let's support use of the ethtool driver stats facility in both sunvnet and ldmvsw. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/ldmvsw.c | 63 + drive

[PATCH v3 net-next 3/9] sunvnet: update version and version printing

2017-02-10 Thread Shannon Nelson
There have been several changes since the first version of this code, so we bump the version number. While we're at it, we can simplify the version printing a bit and drop a couple lines of code. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/sun

[PATCH v3 net-next 0/9] sunvnet driver updates

2017-02-10 Thread Shannon Nelson
module doesn't need module_init or _exit Shannon Nelson (8): sunvnet: make sunvnet common code dynamically loadable sunvnet: update version and version printing sunvnet: add driver stats for ethtool support sunvnet: add memory barrier before check for tx enable sunvnet: straighten up

[PATCH v3 net-next 1/9] sunvnet: make sunvnet common code dynamically loadable

2017-02-10 Thread Shannon Nelson
in kernels that aren't running the LDoms. This patch makes the sunvnet_common into a dynamically loadable module and makes sunvnet and ldmvsw dependent on sunvnet_common. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/Kconfig |8 ++-- drive

Re: [PATCH v3 net-next 1/9] sunvnet: make sunvnet common code dynamically loadable

2017-02-13 Thread Shannon Nelson
On 2/12/2017 3:16 AM, Sergei Shtylyov wrote: Hello! On 2/10/2017 8:38 PM, Shannon Nelson wrote: When the sunvnet_common code was split out for use by both sunvnet and the newer ldmvsw, it was made into a static kernel library, which limits the usefulness of sunvnet and ldmvsw as loadables

Re: [PATCH v3 net-next 4/9] sunvnet: add driver stats for ethtool support

2017-02-13 Thread Shannon Nelson
On 2/11/2017 6:01 PM, David Miller wrote: From: Stephen Hemminger <step...@networkplumber.org> Date: Fri, 10 Feb 2017 16:22:08 -0800 On Fri, 10 Feb 2017 09:38:20 -0800 Shannon Nelson <shannon.nel...@oracle.com> wrote: +static void vsw_get_ethtool_stats(struct net

[PATCH v4 net-next 2/8] sunvnet: remove unused variable in maybe_tx_wakeup

2017-02-13 Thread Shannon Nelson
nother START message at the next TX and trigger the consumer to drain the dring. Signed-off-by: Sowmini Varadhan <sowmini.varad...@oracle.com> Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/sunvnet_common.c |6 +- 1 files changed,

[PATCH v4 net-next 3/8] sunvnet: update version and version printing

2017-02-13 Thread Shannon Nelson
There have been several changes since the first version of this code, so we bump the version number. While we're at it, we can simplify the version printing a bit and drop a couple lines of code. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/sun

[PATCH v4 net-next 1/8] sunvnet: make sunvnet common code dynamically loadable

2017-02-13 Thread Shannon Nelson
in kernels that aren't running the LDoms. This patch makes the sunvnet_common into a dynamically loadable module and makes sunvnet and ldmvsw dependent on sunvnet_common. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/Kconfig |8 ++-- drive

[PATCH v4 net-next 5/8] sunvnet: straighten up message event handling logic

2017-02-13 Thread Shannon Nelson
The use of gotos for handling the incoming events made this code harder to read and support than it should be. This patch straightens out and clears up the logic. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/sunvnet_common.c

[PATCH v4 net-next 7/8] ldmvsw: update and simplify version string

2017-02-13 Thread Shannon Nelson
New version and simplify the print code. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/ldmvsw.c | 14 -- 1 files changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/net/ethernet/sun/ldmvsw.c b/drivers/net/ethernet/sun/ld

[PATCH v4 net-next 4/8] sunvnet: add memory barrier before check for tx enable

2017-02-13 Thread Shannon Nelson
In order to allow the underlying LDC and outstanding memory operations to potentially catch up with the driver's Tx requests, add a memory barrier before checking again for available tx descriptors. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethern

[PATCH v4 net-next 8/8] ldmvsw: disable tso and gso for bridge operations

2017-02-13 Thread Shannon Nelson
by delayed packets, enough to begin triggering retransmits and affecting overall throughput. By turning off advertised support for TSO and GSO we restore stable traffic flow through the bridge. Orabug: 23293104 Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethern

[PATCH v4 net-next 0/8] sunvnet driver updates

2017-02-13 Thread Shannon Nelson
module doesn't need module_init or _exit v4: - dropped the statistics patch - fixed up "default" tag for SUNVNET_COMMON Shannon Nelson (7): sunvnet: make sunvnet common code dynamically loadable sunvnet: update version and version printing sunvnet: add memory barrier before ch

Re: [PATCH v4 net-next 5/8] sunvnet: straighten up message event handling logic

2017-02-13 Thread Shannon Nelson
On 2/13/2017 11:06 AM, Joe Perches wrote: On Mon, 2017-02-13 at 10:57 -0800, Shannon Nelson wrote: The use of gotos for handling the incoming events made this code harder to read and support than it should be. This patch straightens out and clears up the logic. Signed-off-by: Shannon Nelson

[PATCH v4 net-next 6/8] sunvnet: remove extra rcu_read_unlocks

2017-02-13 Thread Shannon Nelson
ahe...@oracle.com> Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/sunvnet_common.c |8 ++-- 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/sun/sunvnet_common.c b/drivers/net/ethernet/sun/sunvnet_common.c i

[PATCH] tcp: fix tcp_fastopen unaligned access complaints on sparc

2017-01-12 Thread Shannon Nelson
-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- include/linux/tcp.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/linux/tcp.h b/include/linux/tcp.h index fc5848d..95cda75 100644 --- a/include/linux/tcp.h +++ b/include/linux/tcp.h @@ -62,8 +62,8 @@

Re: [PATCH] tcp: fix tcp_fastopen unaligned access complaints on sparc

2017-01-12 Thread Shannon Nelson
On 1/12/2017 12:25 PM, Eric Dumazet wrote: On Thu, 2017-01-12 at 13:15 -0700, Rob Gardner wrote: I suspect that someplace, somebody is casting val to an int * or something like that. Then that would be the bug. Can we root cause this please ? Look in

Re: [PATCH] tcp: fix tcp_fastopen unaligned access complaints on sparc

2017-01-12 Thread Shannon Nelson
On 1/12/2017 12:41 PM, David Miller wrote: From: Shannon Nelson <shannon.nel...@oracle.com> Date: Thu, 12 Jan 2017 12:30:38 -0800 On 1/12/2017 12:25 PM, Eric Dumazet wrote: On Thu, 2017-01-12 at 13:15 -0700, Rob Gardner wrote: I suspect that someplace, somebody is casting val to

Re: [PATCH] tcp: fix tcp_fastopen unaligned access complaints on sparc

2017-01-12 Thread Shannon Nelson
On 1/12/2017 1:47 PM, David Miller wrote: From: Eric Dumazet Date: Thu, 12 Jan 2017 13:36:30 -0800 val should be an union, so that proper alignment is enforced by one member. Sure, annotating the type so that it is aligned correctly makes sense. ... and we

[PATCH v2] tcp: fix tcp_fastopen unaligned access complaints on sparc

2017-01-12 Thread Shannon Nelson
access at TPC[976490] tcp_try_fastopen+0x2d0/0x360 Cc: Eric Dumazet <eric.duma...@gmail.com> Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- v2: Use Eric's suggestion for a union in the struct include/linux/tcp.h |7 ++- net/ipv4/tcp_fastopen.c |2

Re: [PATCH v2 net-next 4/5] sunvnet: count multicast packets

2017-03-15 Thread Shannon Nelson
On 3/15/2017 1:50 AM, David Laight wrote: From: Shannon Nelson Sent: 14 March 2017 17:25 ... + if (unlikely(is_multicast_ether_addr(eth_hdr(skb)->h_dest))) + dev->stats.multicast++; I'd guess that: dev->stats.multicast += is_multicast_ether_addr(et

Re: [PATCH net-next 0/5] sunvnet: better connection management

2017-03-08 Thread Shannon Nelson
On 3/6/2017 3:15 PM, Shannon Nelson wrote: These patches remove some problems in handling of carrier state with the ldmvsw vswitch, remove an xoff misuse in sunvnet, and add stats for debug and tracking of point-to-point connections between the ldom VMs. Further testing shows a problem in one

[PATCH v2 net-next 1/5] ldmvsw: better use of link up and down on ldom vswitch

2017-03-14 Thread Shannon Nelson
the underlying LDC protocol. Similarly, we take the link down when we see the LDC_EVENT_RESET. Now when we see the ndo_open(), we reset the link to get things talking again. Orabug: 25525312 Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/ldmvsw.c

[PATCH v2 net-next 3/5] sunvnet: track port queues correctly

2017-03-14 Thread Shannon Nelson
Track our used and unused queue indexies correctly. Otherwise, as ports dropped out and returned, they all eventually ended up with the same queue index. Orabug: 25190537 Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/sunvnet_common.c

[PATCH v2 net-next 0/5] sunvnet: better connection management

2017-03-14 Thread Shannon Nelson
These patches remove some problems in handling of carrier state with the ldmvsw vswitch, remove an xoff misuse in sunvnet, and add stats for debug and tracking of point-to-point connections between the ldom VMs. v2: - added ldmvsw ndo_open to reset the LDC channel - updated copyrights Shannon

[PATCH v2 net-next 5/5] sunvnet: xoff not needed when removing port link

2017-03-14 Thread Shannon Nelson
e driver's tx_timeout handler. Simply removing these takes care of the problem. Orabug: 25190537 Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/sunvnet_common.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/

[PATCH v2 net-next 4/5] sunvnet: count multicast packets

2017-03-14 Thread Shannon Nelson
Make sure multicast packets get counted in the device. Orabug: 25190537 Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/sunvnet_common.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/net/ethernet/sun/sunvnet_commo

[PATCH v2 net-next 2/5] sunvnet: add stats to track ldom to ldom packets and bytes

2017-03-14 Thread Shannon Nelson
dual queue/port stats. This patch breaks out the traffic counts for the individual ports and gives us a little view into the state of those connections. Orabug: 25190537 Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/sunvnet

[PATCH net-next 3/5] sunvnet: track port queues correctly

2017-03-06 Thread Shannon Nelson
Track our used and unused queue indices correctly. Otherwise, as ports dropped out and returned, they all eventually ended up with the same queue index. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/sunvnet_common.c

[PATCH net-next 4/5] sunvnet: count multicast packets

2017-03-06 Thread Shannon Nelson
Make sure multicast packets get counted in the device. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/sunvnet_common.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/net/ethernet/sun/sunvnet_common.c b/drive

[PATCH net-next 2/5] sunvnet: add stats to track ldom to ldom packets and bytes

2017-03-06 Thread Shannon Nelson
dual queue/port stats. This patch breaks out the traffic counts for the individual ports and gives us a little view into the state of those connections. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/sunvnet.c| 114 ++

[PATCH net-next 5/5] sunvnet: xoff not needed when removing port link

2017-03-06 Thread Shannon Nelson
e driver's tx_timeout handler. Simply removing these takes care of the problem. Orabug: 25190537 Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/sunvnet_common.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/

[PATCH net-next 1/5] ldmvsw: better use of link up and down on ldom vswitch

2017-03-06 Thread Shannon Nelson
the underlying LDC protocol. Similarly, we take the link down when we see the LDC_EVENT_RESET. Orabug: 25525312 Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/ldmvsw.c | 10 +++--- drivers/net/ethernet/sun/sunvnet_common.c | 14 +++

Re: [PATCH net-next 1/5] ldmvsw: better use of link up and down on ldom vswitch

2017-03-06 Thread Shannon Nelson
On 3/6/2017 3:53 PM, Florian Fainelli wrote: On 03/06/2017 03:15 PM, Shannon Nelson wrote: When an ldom VM is bound, the network vswitch infrastructure is set up for it, but was being forced 'UP' by the userland switch configuration script. When 'UP' but not actually connected to a running VM

[PATCH net-next 0/5] sunvnet: better connection management

2017-03-06 Thread Shannon Nelson
These patches remove some problems in handling of carrier state with the ldmvsw vswitch, remove an xoff misuse in sunvnet, and add stats for debug and tracking of point-to-point connections between the ldom VMs. Shannon Nelson (5): ldmvsw: better use of link up and down on ldom vswitch

[PATCH net-next] ixgbe: restore normal RSS after last macvlan offload is removed

2017-08-15 Thread Shannon Nelson
type macvlan mode bridge ip link set dev mv1 up ip link del mv1 ethtool -l eth1 # are we back to the same # of queues, or stuck on 1? Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 11 +++ 1 files changed, 11 inse

Re: [net-next 15/15] i40e: synchronize nvmupdate command and adminq subtask

2017-08-14 Thread Shannon Nelson
} Perhaps I missed a patch somewhere, but I think there is still a return statement in the middle of this switch() (INIT_WAIT and WRITE_WAIT) that means you can leave the mutex locked. I thought I had seen a newer version of this patch that had this fixed sln > + mutex_unlock(>aq.arq_mutex); > return status; > } > > -- > 2.14.0 > -- == Mr. Shannon Nelson Parents can't afford to be squeamish.

[PATCH net-next] i40e: limit lan queue count in large cpu count machine

2017-07-24 Thread Shannon Nelson
some left for FD and other features. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/intel/i40e/i40e_main.c | 11 +++ 1 files changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet

[PATCH net-next] sunvnet: add support for IPv6 checksum offloads

2017-07-06 Thread Shannon Nelson
The original code didn't handle non-IPv4 packets very well, so the offload advertising had to be scaled back down to just IP. Here we add the bits needed to support TCP and UDP packets over IPv6 and turn the offload advertising back on. Orabug: 26289579 Signed-off-by: Shannon Nelson

Re: [Intel-wired-lan] [PATCH net-next RFC 0/6] Configure cloud filters in i40e via tc/flower classifier

2017-08-01 Thread Shannon Nelson
If this is an RFC patchset, then all the patches should have RFC in them. On 7/31/2017 5:36 PM, Amritha Nambiar wrote: This patch series enables configuring cloud filters in i40e using the tc/flower classifier. The only tc-filter action supported is to redirect packets to a traffic class on the

Re: [Intel-wired-lan] [PATCH 6/6] [net-next]net: i40e: Enable cloud filters in i40e via tc/flower classifier

2017-08-01 Thread Shannon Nelson
On 7/31/2017 5:38 PM, Amritha Nambiar wrote: This patch enables tc-flower based hardware offloads. tc/flower filter provided by the kernel is configured as driver specific cloud filter. The patch implements functions and admin queue commands needed to support cloud filters in the driver and adds

Re: [Intel-wired-lan] [PATCH 4/6] [net-next]net: i40e: Admin queue definitions for cloud filters

2017-08-01 Thread Shannon Nelson
On 7/31/2017 5:37 PM, Amritha Nambiar wrote: Add new admin queue definitions and extended fields for cloud filter support. Define big buffer for extended general fields in Add/Remove Cloud filters command. Signed-off-by: Amritha Nambiar Signed-off-by: Kiran Patil

Re: [Intel-wired-lan] [PATCH 5/6] [net-next]net: i40e: Clean up of cloud filters

2017-08-01 Thread Shannon Nelson
On 7/31/2017 5:38 PM, Amritha Nambiar wrote: Introduce the cloud filter datastructure and cleanup of cloud filters associated with the device. Signed-off-by: Amritha Nambiar --- drivers/net/ethernet/intel/i40e/i40e.h | 11 +++

[PATCH net-next] bnxt: add dma mapping attributes

2017-05-09 Thread Shannon Nelson
On the SPARC platform we need to use the DMA_ATTR_WEAK_ORDERING attribute in our Rx path dma mapping in order to get the expected performance out of the receive path. Adding it to the Tx path has little effect, so that's not a part of this patch. Signed-off-by: Shannon Nelson <shannon.

[PATCH v2 net-next] bnxt: add dma mapping attributes

2017-05-09 Thread Shannon Nelson
On the SPARC platform we need to use the DMA_ATTR_WEAK_ORDERING attribute in our Rx path dma mapping in order to get the expected performance out of the receive path. Adding it to the Tx path has little effect, so that's not a part of this patch. Signed-off-by: Shannon Nelson <shannon.

[PATCH net-next 0/2] ldmvsw: port removal stability

2017-05-15 Thread Shannon Nelson
Under heavy reboot stress testing we found a couple of timing issues when removing the device that could cause the kernel great heartburn, addressed by these two patches. Shannon Nelson (1): ldmvsw: stop the clean timer at beginning of remove Thomas Tai (1): ldmvsw: unregistering netdev

[PATCH net-next 1/2] ldmvsw: unregistering netdev before disable hardware

2017-05-15 Thread Shannon Nelson
omas@oracle.com> Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/ldmvsw.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/ethernet/sun/ldmvsw.c b/drivers/net/ethernet/sun/ldmvsw.c index 5a90fed..309747c 10064

[PATCH net-next 2/2] ldmvsw: stop the clean timer at beginning of remove

2017-05-15 Thread Shannon Nelson
Stop the clean timer earlier to be sure there's no asynchronous interference while stopping the port. Orabug: 25748241 Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/ldmvsw.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff

Re: [PATCH net-next] bnxt: add dma mapping attributes

2017-05-09 Thread Shannon Nelson
On 5/9/2017 5:49 PM, David Miller wrote: From: Shannon Nelson <shannon.nel...@oracle.com> Date: Tue, 9 May 2017 13:37:33 -0700 @@ -66,6 +66,12 @@ MODULE_DESCRIPTION("Broadcom BCM573xx network driver"); MODULE_VERSION(DRV_MODULE_VERSION); +#ifdef CONFIG_SPARC +#defin

Re: [PATCH net-next] bnxt: add dma mapping attributes

2017-05-09 Thread Shannon Nelson
On 5/9/2017 2:05 PM, Michael Chan wrote: On Tue, May 9, 2017 at 1:37 PM, Shannon Nelson <shannon.nel...@oracle.com> wrote: On the SPARC platform we need to use the DMA_ATTR_WEAK_ORDERING attribute in our Rx path dma mapping in order to get the expected performance out of the receiv

Re: [PATCH net-next 2/2] sunvnet: implement basic ethtool get_settings

2017-06-21 Thread Shannon Nelson
On 6/21/2017 12:06 PM, David Miller wrote: From: Shannon Nelson <shannon.nel...@oracle.com> Date: Wed, 21 Jun 2017 09:09:54 -0700 Add the get_settings callback so that both the ldmvsw and sunvnet drivers will give a little more information when asked for its basic settings. These

Re: [PATCH net-next 1/2] ldmvsw: add vio version and remote-mac to ethtool info

2017-06-21 Thread Shannon Nelson
On 6/21/2017 12:05 PM, David Miller wrote: From: Shannon Nelson <shannon.nel...@oracle.com> Date: Wed, 21 Jun 2017 09:09:53 -0700 In the ethtool -i output print the vio version and the remote-mac of the ldom that the vif device is serving as this vif info is not exposed elsewhere. The

[PATCH net-next 0/2] sunvnet: add to ethtool data

2017-06-21 Thread Shannon Nelson
specific example is that the /sys/class/net//speed attribute becomes readable. Shannon Nelson (2): ldmvsw: add vio version and remote-mac to ethtool info sunvnet: implement basic ethtool get_settings drivers/net/ethernet/sun/ldmvsw.c |8 drivers/net/ethernet/sun/sunvnet.c

[PATCH net-next 1/2] ldmvsw: add vio version and remote-mac to ethtool info

2017-06-21 Thread Shannon Nelson
In the ethtool -i output print the vio version and the remote-mac of the ldom that the vif device is serving as this vif info is not exposed elsewhere. The remote-mac address is most useful for tracking which client ldom is being served by the vif. Orabug: 26316362 Signed-off-by: Shannon Nelson

[PATCH net-next 2/2] sunvnet: implement basic ethtool get_settings

2017-06-21 Thread Shannon Nelson
readable, which makes a couple of the ldom management tools happier. Orabug: 26175474 Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/ldmvsw.c |1 + drivers/net/ethernet/sun/sunvnet.c|1 + drivers/net/ethernet/sun/sunvnet_common.c

Re: [PATCH net-next] sunvnet: restrict advertized checksum offloads to just IP

2017-06-15 Thread Shannon Nelson
On 6/15/2017 11:23 AM, David Miller wrote: Applied, but this bug must be fixed properly and ipv6 checksumming properly supported. Thanks. Understood - we just wanted first to stop the bleeding while we think about how to do this right. Thanks, sln

  1   2   3   4   >