Re: Kconfig warnings on latest GIT

2007-05-13 Thread Simon Horman
On Fri, May 11, 2007 at 01:45:37PM +0200, Johannes Berg wrote: On Fri, 2007-05-11 at 10:22 +0900, Simon Horman wrote: Actually, it was with ARCH=ia64. I have a feeling that you can get it to show up quite easily with anything other than ARCH=powerpc. Ick, I didn't know that drivers

Re: [IPV4] LVS: Allow to send ICMP unreachable responses when real-servers are removed

2007-05-14 Thread Simon Horman
On Mon, May 14, 2007 at 07:41:48PM +0200, Patrick McHardy wrote: Janusz Krzysztofik wrote: Patrick McHardy wrote: Janusz Krzysztofik wrote: ... ICMP port unreachable messages are not generated inside IPVS code, they are just sent, with help of the patch in question, from

Re: [IPV4] LVS: Allow to send ICMP unreachable responses when real-servers are removed

2007-05-17 Thread Simon Horman
On Thu, May 17, 2007 at 06:40:28PM +0200, Patrick McHardy wrote: Actually thats exactly the case that my patch handles. Why does it matter which source address the ICMP packet uses, as long as its routed properly? Agreed. In any case some better solution than the current one needs to be

Re: [PATCH 17/30] Use menuconfig objects - IPVS

2007-04-10 Thread Simon Horman
On Tue, Apr 10, 2007 at 11:25:59PM +0200, Jan Engelhardt wrote: Use menuconfigs instead of menus, so the whole menu can be disabled at once instead of going through all options. Signed-off-by: Jan Engelhardt [EMAIL PROTECTED] This seems to work fine to me. Signed-off-by: Simon

Re: Kconfig warnings on latest GIT

2007-05-09 Thread Simon Horman
On Tue, May 08, 2007 at 03:11:52PM -0500, Timur Tabi wrote: Kim Phillips wrote: On Tue, 8 May 2007 00:04:14 +0300 Ismail Dönmez [EMAIL PROTECTED] wrote: drivers/net/Kconfig:2279:warning: 'select' used by config symbol 'UCC_GETH' refers to undefined symbol 'UCC_FAST' looks like this

Re: Kconfig warnings on latest GIT

2007-05-10 Thread Simon Horman
On Thu, May 10, 2007 at 05:39:29PM +0200, Johannes Berg wrote: On Thu, 2007-05-10 at 14:10 +0900, Simon Horman wrote: drivers/macintosh/Kconfig:112:warning: 'select' used by config symbol 'PMAC_APM_EMU' refer to undefined symbol 'SYS_SUPPORTS_APM_EMULATION' Argh. Is that with ARCH=ppc

Re: Kconfig warnings on latest GIT

2007-05-10 Thread Simon Horman
On Thu, May 10, 2007 at 11:56:48AM -0500, Timur Tabi wrote: Simon Horman wrote: So my question is: in which Kconfig do I define UCC_FAST_TEMP and UCC_SLOW_TEMP? At first I thought, just put it in drivers/Kconfig, but that Kconfig does nothing but including other Kconfigs. I believe

Re: Kconfig warnings on latest GIT

2007-05-10 Thread Simon Horman
On Thu, May 10, 2007 at 08:47:05PM -0500, Kumar Gala wrote: Try this patch: That certainly resolves the problem for me. I'll see about doing something like that for the similar Kconfig problems that I see. -- Horms H: http://www.vergenet.net/~horms/ W: http://www.valinux.co.jp/en/ - To

Re: Kconfig warnings on latest GIT

2007-05-10 Thread Simon Horman
On Thu, May 10, 2007 at 09:13:34PM -0500, Kumar Gala wrote: On Fri, 11 May 2007, Simon Horman wrote: On Thu, May 10, 2007 at 08:47:05PM -0500, Kumar Gala wrote: Try this patch: That certainly resolves the problem for me. I'll see about doing something like that for the similar

Re: Kconfig warnings on latest GIT

2007-05-10 Thread Simon Horman
On Fri, May 11, 2007 at 11:27:22AM +0900, Simon Horman wrote: On Thu, May 10, 2007 at 09:13:34PM -0500, Kumar Gala wrote: On Fri, 11 May 2007, Simon Horman wrote: On Thu, May 10, 2007 at 08:47:05PM -0500, Kumar Gala wrote: Try this patch: That certainly resolves the problem

Re: [PATCH] [343/2many] MAINTAINERS - IPVS

2007-10-07 Thread Simon Horman
On Sun, Aug 12, 2007 at 11:32:48PM -0700, [EMAIL PROTECTED] wrote: Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches [EMAIL PROTECTED] diff --git a/MAINTAINERS b/MAINTAINERS index dbfdb75..a8fb231 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3300,6 +3300,8 @@ P:

IPVS: use proper timeout instead of fixed value

2007-10-29 Thread Simon Horman
be much nicer to use one of the configured timeout values. Signed-off-by: Andy Gospodarek [EMAIL PROTECTED] Acked-by: Simon Horman [EMAIL PROTECTED] --- Hi, I'd like to revisit this patch which was originally posted to netdev in May 2006. Looking through the archives as far as I can see

Re: IPVS: use proper timeout instead of fixed value

2007-10-29 Thread Simon Horman
On Mon, Oct 29, 2007 at 01:35:15AM -0700, David Miller wrote: From: Simon Horman [EMAIL PROTECTED] Date: Mon, 29 Oct 2007 16:05:55 +0900 (JST) From: Andy Gospodarek [EMAIL PROTECTED] Instead of using the default timeout of 3 minutes, this uses the timeout specific to the protocol used

[patch 0/2] ipvs: avoid overcommit on the standby, take II

2007-11-01 Thread Simon Horman
Two related patches from Rumen G. Bogdanovski to help prevent overcommit on the standby. After sending the last patchset I discovered scripts/checkpatch.pl and found that it didn't like quite a few things. I've fixed those problems and here is the result. -- Horms H:

[patch 2/2] ipvs: Syncrhonise Closing of Connections

2007-11-01 Thread Simon Horman
PROTECTED] Signed-off-by: Simon Horman [EMAIL PROTECTED] --- Thu, 01 Nov 2007 18:25:10 +0900, Horms * Redifed for net-2.6 * Ran through scripts/checkpatch.pl and fixed up everything that it complains about except the use of volatile, as its in keeping with other fields in the structure

[patch 1/2] ipvs: Bind connections on stanby if the destination exists

2007-11-01 Thread Simon Horman
- C0A80033:176F Route 1000 0 1 - C0A80032:176F Route 1000 0 1 Regards, Rumen Bogdanovski Acked-by: Julian Anastasov [EMAIL PROTECTED] Signed-off-by: Rumen G. Bogdanovski [EMAIL PROTECTED] Signed-off-by: Simon Horman [EMAIL PROTECTED] --- Thu, 01 Nov 2007

Re: [patch 2/2] ipvs: Syncrhonise Closing of Connections

2007-11-01 Thread Simon Horman
On Fri, Nov 02, 2007 at 01:36:07AM +0200, Julian Anastasov wrote: Hello, On Thu, 1 Nov 2007, Simon Horman wrote: --- net-2.6.orig/net/ipv4/ipvs/ip_vs_sync.c 2007-11-01 18:17:55.0 +0900 +++ net-2.6/net/ipv4/ipvs/ip_vs_sync.c 2007-11-01 18:20:30.0 +0900

Re: [2.6 patch] net/ipv4/ipvs/: remove unused exports

2007-11-11 Thread Simon Horman
it a different way? Acked-by: Simon Horman [EMAIL PROTECTED] --- net/ipv4/ipvs/ip_vs_conn.c |1 - net/ipv4/ipvs/ip_vs_ctl.c |1 - 2 files changed, 2 deletions(-) ad9f400d4f66ea3423f97e609d6ef2572055c603 diff --git a/net/ipv4/ipvs/ip_vs_conn.c b/net/ipv4/ipvs/ip_vs_conn.c index

Re: [PATCH] IPVS: Fix sysctl warnings about missing strategy

2007-11-14 Thread Simon Horman
with the default sysctl_data strategy. I did not touch these. Eric, IPVS team, are you ok with that change? CC: Eric W. Biederman [EMAIL PROTECTED] CC: Wensong Zhang [EMAIL PROTECTED] CC: Simon Horman [EMAIL PROTECTED] CC: Julian Anastasov [EMAIL PROTECTED] Signed-off-by: Christian Borntraeger

[patch 0/3] IPVS: Use CTL_UNNUMBERED

2007-11-14 Thread Simon Horman
Hi, this series of three patches, the first of which is by Christian Borntraeger, switches IPVS over to use CTL_UNNUMBERED, removing a lot of unused cruft. -- Horms H: http://www.vergenet.net/~horms/ W: http://www.valinux.co.jp/en/ - To unsubscribe from this list: send the line unsubscribe

[patch 2/3] IPVS: Fix sysctl warnings about missing strategy in schedulers

2007-11-14 Thread Simon Horman
the same lines as Christian Borntraeger's patch that fixes up entries with no stratergy in net/ipv4/ipvs/ip_vs_ctl.c Cc: Eric W. Biederman [EMAIL PROTECTED] Cc: Wensong Zhang [EMAIL PROTECTED] Cc: Julian Anastasov [EMAIL PROTECTED] Cc: Christian Borntraeger [EMAIL PROTECTED] Signed-off-by: Simon Horman

[patch 1/3] IPVS: Fix sysctl warnings about missing strategy

2007-11-14 Thread Simon Horman
Zhang [EMAIL PROTECTED] CC: Julian Anastasov [EMAIL PROTECTED] Signed-off-by: Christian Borntraeger [EMAIL PROTECTED] Acked-by: Simon Horman [EMAIL PROTECTED] --- include/net/ip_vs.h |4 kernel/sysctl_check.c |4 net/ipv4/ipvs/ip_vs_ctl.c |4 3 files changed

[patch 3/3] IPVS: Move remaining sysctl handlers over to CTL_UNNUMBERED

2007-11-14 Thread Simon Horman
[EMAIL PROTECTED] Signed-off-by: Simon Horman [EMAIL PROTECTED] --- include/net/ip_vs.h | 28 kernel/sysctl_check.c | 25 - net/ipv4/ipvs/ip_vs_ctl.c | 20 net/ipv4/ipvs/ip_vs_lblc.c |1 - net/ipv4

[patch 0/2] ipvs: Expose synced connections in proc

2007-11-14 Thread Simon Horman
Two patches from Rumen Bogdanovski to enhance the connection synchronisation code. Dave, please consider for inclusion, they have been aired on lvs-devel. -- Horms H: http://www.vergenet.net/~horms/ W: http://www.valinux.co.jp/en/ - To unsubscribe from this list: send the line unsubscribe

[patch 2/2] ipvs: Create synced connections with their real state

2007-11-14 Thread Simon Horman
connections have different weights in the schedulers). The backwards compatibility is preserved and the existing tools will show the true connection states even on the backup director. Signed-off-by: Rumen G. Bogdanovski [EMAIL PROTECTED] Signed-off-by: Simon Horman [EMAIL PROTECTED] diff -Naur net

[patch 1/2] ipvs: Flag synced connections and expose them in proc

2007-11-14 Thread Simon Horman
. Bogdanovski [EMAIL PROTECTED] Signed-off-by: Simon Horman [EMAIL PROTECTED] diff -Naur net-2.6_orig/net/ipv4/ipvs/ip_vs_conn.c net-2.6_work/net/ipv4/ipvs/ip_vs_conn.c --- net-2.6_orig/net/ipv4/ipvs/ip_vs_conn.c 2007-11-13 12:37:07.0 +0200 +++ net-2.6_work/net/ipv4/ipvs/ip_vs_conn.c 2007

Re: [PATCH] Use sockfd_lookup_light in the rest of the net/socket.c

2007-11-14 Thread Simon Horman
these two need. Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] This looks correct to me. Acked-by: Simon Horman [EMAIL PROTECTED] -- Horms, California Edition - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [PATCH 2/2][INET] Move the reqsk_queue_yank_listen_sk from header

2007-11-14 Thread Simon Horman
On Wed, Nov 14, 2007 at 09:11:06PM +0300, Pavel Emelyanov wrote: This function is used in the net/core/request_sock.c only. No need in keeping it in the header file. I feel like I am missing something here, but doesn't __reqsk_queue_destroy() in include/net/request_sock.h use

Re: [PATCH] IPVS: Fix sysctl warnings about missing strategy

2007-11-14 Thread Simon Horman
On Thu, Nov 15, 2007 at 02:38:32AM +0200, Julian Anastasov wrote: Hi Julian, On Tue, 13 Nov 2007, Simon Horman wrote: [snip] As for the commented out entries. They are supposed to be exposed by some other means - I believe the thinking was to comply with the don't expose stuff in proc

Re: [PATCH] IPVS: Fix sysctl warnings about missing strategy

2007-11-14 Thread Simon Horman
On Wed, Nov 14, 2007 at 06:25:00PM -0700, Eric W. Biederman wrote: Simon Horman [EMAIL PROTECTED] writes: On Thu, Nov 15, 2007 at 02:38:32AM +0200, Julian Anastasov wrote: Hi Julian, On Tue, 13 Nov 2007, Simon Horman wrote: [snip] As for the commented out entries

Re: [PATCH] IPV4 : Move ip route cache flush (secret_rebuild) from softirq to workqueue

2007-11-16 Thread Simon Horman
On Fri, Nov 16, 2007 at 05:40:27PM +0100, Eric Dumazet wrote: Hello David This patch against net-2.6.25 is another step to get a more resistant ip route cache. Thank you [PATCH] IPV4 : Move ip route cache flush (secret_rebuild) from softirq to workqueue Every 600 seconds

Re: [PATCH][IPVS] Relax the module get/put in ip_vs_app.c

2007-11-19 Thread Simon Horman
to me. Acked-by: Simon Horman [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH, take2] netfilter : struct xt_table_info diet

2007-11-19 Thread Simon Horman
kernel stack size for big NR_CPUS) Signed-off-by: Eric Dumazet [EMAIL PROTECTED] Signed-off-by: Simon Horman [EMAIL PROTECTED] --- Tue, 20 Nov 2007 15:23:33 +0900, Simon Horman [EMAIL PROTECTED] Up-port to net-2.6.25 6d20d53c3d54d80211247dbe5c9cf67fda083a88 diff --git a/include/linux/netfilter

Re: [PATCH net-2.6.25 0/4] Convert IP4 address class macros to inline functions

2007-11-19 Thread Simon Horman
On Mon, Nov 19, 2007 at 10:40:12PM -0800, Joe Perches wrote: Change LOOPBACK MULTICAST LOCAL_MCAST BADCLASS and ZERONET macros to inline functions ipv4_is_type(__be32 addr) Adds some type safety and arguably some readability No change in compiled image size Signed-off-by: Joe Perches

Re: [PATCH 52/59] net/ipv4: Add missing space

2007-11-19 Thread Simon Horman
On Mon, Nov 19, 2007 at 05:53:39PM -0800, Joe Perches wrote: Signed-off-by: Joe Perches [EMAIL PROTECTED] Acked-by: Simon Horman [EMAIL PROTECTED] --- net/ipv4/ipvs/ip_vs_core.c |2 +- net/ipv4/netfilter/iptable_raw.c |2 +- 2 files changed, 2 insertions(+), 2 deletions

Re: [PATCH 1/2] virtio: fix net driver loop case where we fail to restart

2007-11-19 Thread Simon Horman
On Mon, Nov 19, 2007 at 11:20:15AM +1100, Rusty Russell wrote: skb is only NULL the first time around: it's more correct to test for being under-budget. Signed-off-by: Rusty Russell [EMAIL PROTECTED] That looks better to me. Acked-by: Simon Horman [EMAIL PROTECTED] diff -r 2a94425ac7d5

Re: [PATCH net-2.6.25 0/4] Convert IP4 address class macros to inline functions

2007-11-19 Thread Simon Horman
On Mon, Nov 19, 2007 at 11:18:44PM -0800, Joe Perches wrote: On Tue, 2007-11-20 at 16:06 +0900, Simon Horman wrote: On Mon, Nov 19, 2007 at 10:40:12PM -0800, Joe Perches wrote: Change LOOPBACK MULTICAST LOCAL_MCAST BADCLASS and ZERONET macros to inline functions ipv4_is_type(__be32 addr

Re: [PATCH][IPVS] Fix compiler warning about unused register_ip_vs_protocol

2007-11-20 Thread Simon Horman
of the __used solution, even though strictly speaking it is a lie. Acked-by: Simon Horman [EMAIL PROTECTED] --- diff --git a/net/ipv4/ipvs/ip_vs_proto.c b/net/ipv4/ipvs/ip_vs_proto.c index e844ddb..c0e11ec 100644 --- a/net/ipv4/ipvs/ip_vs_proto.c +++ b/net/ipv4/ipvs/ip_vs_proto.c @@ -45,7

Re: [PATCH][IPVS] Don't leak sysctl tables if the scheduler registration fails

2007-12-03 Thread Simon Horman
to fail is the name collision, so I think that with some 3rd party schedulers this becomes a relevant issue. No? I guess so. Though presumably register_ip_vs_scheduler() could have other modes of failure in the future. Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] Acked-by: Simon Horman [EMAIL

Re: [PATCH][IPVS] Fix sched registration race when checking for name collision

2007-12-03 Thread Simon Horman
between the lock being re-locked for writing. The fix is to search the scheduler with the given name right under the write-locked __ip_vs_sched_lock. This looks correct to me. Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] Acked-by: Simon Horman [EMAIL PROTECTED] --- diff --git

Re: [PATCH] Updates to nfsroot documentation (take 2)

2007-12-04 Thread Simon Horman
[ CCed netdev ] On Tue, Dec 04, 2007 at 11:59:32PM -0500, Amos Waterland wrote: The difference between ip=off and ip=::off has been a cause of much confusion. Document how each behaves, and do not contradict ourselves by saying that off is the default when in fact any is the default and

Update ip command line processing

2007-12-18 Thread Simon Horman
=::off actually turns off ip autoconfiguration. This patch also notes more specifically that ip=on (aka ip=::on) is the default. Cc: Amos Waterland [EMAIL PROTECTED] Signed-off-by: Simon Horman [EMAIL PROTECTED] Index: net-2.6.25/net/ipv4/ipconfig.c

Re: Update ip command line processing

2007-12-20 Thread Simon Horman
On Thu, Dec 20, 2007 at 03:21:21PM -0800, David Miller wrote: From: Simon Horman [EMAIL PROTECTED] Date: Tue, 18 Dec 2007 17:57:32 +0900 @@ -1414,9 +1414,16 @@ late_initcall(ip_auto_config); */ static int __init ic_proto_name(char *name) { + if (!name) { + return 1

Re: [PATCH] Fix regression in ip command line processing

2008-01-06 Thread Simon Horman
On Sat, Jan 05, 2008 at 11:20:33PM -0800, David Miller wrote: From: Amos Waterland [EMAIL PROTECTED] Date: Sat, 5 Jan 2008 22:58:16 -0500 ADDRESS ASSIGNED qemu -kernel x86/arch/i386/boot/bzImage /dev/zero -append ip=on qemu -kernel x86/arch/i386/boot/bzImage /dev/zero -append ip=dhcp

Re: [PATCH net-2.6.25 2/6][IPVS] Switch to using ctl_paths.

2008-01-08 Thread Simon Horman
declaration of this path compile well. Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] Thanks, this looks good to me and I've confirmed that the same entires with the same permissions exist under /proc/sys/net/ipv4/vs before and after the change. Acked-by: Simon Horman [EMAIL PROTECTED] -- Horms

Re: [PATCH] ipvs: Make wrr no available servers error message rate-limited

2008-02-05 Thread Simon Horman
-off-by: Sven Wegener [EMAIL PROTECTED] Hi Sven, this looks good to me. Acked-by: Simon Horman [EMAIL PROTECTED] --- Actually, do we need this message at all? The wrr scheduler is the only one printing an error message in such a case. I was wondering about that too. Though I'd err

Re: [PATCH] ipvs: Make the synchronization interval controllable

2008-02-06 Thread Simon Horman
, but I'm not sure I understand why a user shouldn't be able to set it to much (rediculously) higher values. In any case, thats not a big deal. Acked-by: Simon Horman [EMAIL PROTECTED] --- Changes from the last version include the addition of the range enforcement. Also place the definitions

Re: [RFC] ipvs: Cleanup sync daemon code

2008-02-09 Thread Simon Horman
for a few days skiing, so if I am quiet you will know why. Acked-by: Simon Horman [EMAIL PROTECTED] -- Horms -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 net-next 0/2] rocker: unused parameter and const cleanups

2015-05-18 Thread Simon Horman
On Mon, May 18, 2015 at 03:47:22PM -0400, David Miller wrote: From: Simon Horman simon.hor...@netronome.com Date: Thu, 14 May 2015 12:42:54 +0900 This series provides some minor though verbose cleanup of rocker. The second patch depends on the first though it could be rebased

[PATCH v3 net-next 0/4] rocker: transaction fixes

2015-05-19 Thread Simon Horman
- Revised changelog to reflect information from Toshiaki Makita that there is a bug that can manifest - Update address and ttl regardless of the value of the transaction state * All other patches - Added acks from Scott Feldman Simon Horman (4): rocker: do not delete fdb entries

Re: [PATCH v3 net-next 3/4] rocker: do not make neighbour entry changes when preparing transactions

2015-05-20 Thread Simon Horman
On Wed, May 20, 2015 at 05:36:06PM +0900, Toshiaki Makita wrote: On 2015/05/20 16:48, Simon Horman wrote: On Wed, May 20, 2015 at 03:15:23PM +0900, Toshiaki Makita wrote: On 2015/05/20 14:48, Simon Horman wrote: ... static void _rocker_neigh_add(struct rocker *rocker

Re: [PATCH v3 net-next 3/4] rocker: do not make neighbour entry changes when preparing transactions

2015-05-20 Thread Simon Horman
On Wed, May 20, 2015 at 03:15:23PM +0900, Toshiaki Makita wrote: On 2015/05/20 14:48, Simon Horman wrote: rocker_port_ipv4_nh() and in turn rocker_port_ipv4_neigh() may be be called with trans == SWITCHDEV_TRANS_PREPARE and then trans == SWITCHDEV_TRANS_COMMIT from switchdev_port_obj_set

Re: [PATCH net-next] rocker: move netevent neigh update to processes context

2015-05-21 Thread Simon Horman
-neigh_tbl_next_index accesses and is more consistent with the rest of the driver code where non-I/O processing is done under process context with rtnl_lock held. Signed-off-by: Scott Feldman sfel...@gmail.com Hi Scott, this patch does what it says on the wrapper and in itself looks good. Reviewed-by: Simon

Re: [PATCH net-next 3/4] rocker: do not make neighbour entry changes when preparing transactions

2015-05-19 Thread Simon Horman
On Tue, May 19, 2015 at 09:11:29AM -0700, Scott Feldman wrote: On Mon, May 18, 2015 at 11:24 PM, Simon Horman simon.hor...@netronome.com wrote: rocker_port_ipv4_nh() and in turn rocker_port_ipv4_neigh() may be be called with trans == SWITCHDEV_TRANS_PREPARE and then trans

Re: [PATCH v3 net-next 3/4] rocker: do not make neighbour entry changes when preparing transactions

2015-05-20 Thread Simon Horman
On Wed, May 20, 2015 at 10:37:52AM -0700, Scott Feldman wrote: On Wed, May 20, 2015 at 5:57 AM, Simon Horman simon.hor...@netronome.com wrote: On Wed, May 20, 2015 at 01:17:36PM +0200, Jiri Pirko wrote: Wed, May 20, 2015 at 10:46:26AM CEST, simon.hor...@netronome.com wrote: On Wed, May 20

[PATCH v4 net-next 3/4] rocker: do not make neighbour entry changes when preparing transactions

2015-05-20 Thread Simon Horman
. Fixes: c4f20321d968 (rocker: support prepare-commit transaction model) Reported-by: Toshiaki Makita makita.toshi...@lab.ntt.co.jp Acked-by: Scott Feldman sfel...@gmail.com Acked-by: Jiri Pirko j...@resnulli.us Signed-off-by: Simon Horman simon.hor...@netronome.com --- v4 * Added Jiri Pirko's ack

[PATCH v4 net-next 1/4] rocker: do not delete fdb entries in rocker_port_fdb_flush() when preparing transactions

2015-05-20 Thread Simon Horman
Fixes: c4f20321d968 (rocker: support prepare-commit transaction model) Acked-by: Scott Feldman sfel...@gmail.com Acked-by: Jiri Pirko j...@resnulli.us Signed-off-by: Simon Horman simon.hor...@netronome.com --- v4 * Added Jiri Pirko's ack v3 * No change v2 * Added Scott Feldman's ack --- drivers/net

[PATCH v4 net-next 4/4] rocker: make rocker_port_internal_vlan_id_{get,put}() non-transactional

2015-05-20 Thread Simon Horman
. Acked-by: Scott Feldman sfel...@gmail.com Acked-by: Jiri Pirko j...@resnulli.us Signed-off-by: Simon Horman simon.hor...@netronome.com --- v4 * Added Jiri Pirko's ack * Dropped Fixes tag as this should not have any run-time affect and thus in my opinion is not a bug fix. I would not object

[PATCH v4 net-next 2/4] rocker: do not modify fdb table in rocker_port_fdb() when preparing transactions

2015-05-20 Thread Simon Horman
j...@resnulli.us Signed-off-by: Simon Horman simon.hor...@netronome.com --- v4 * Added Jiri Pirko's ack v3 * No change v2 * Added Scott Feldman's ack --- drivers/net/ethernet/rocker/rocker.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/rocker

[PATCH v4 net-next 0/4] rocker: transaction fixes

2015-05-20 Thread Simon Horman
Simon Horman (4): rocker: do not delete fdb entries in rocker_port_fdb_flush() when preparing transactions rocker: do not modify fdb table in rocker_port_fdb() when preparing transactions rocker: do not make neighbour entry changes when preparing transactions rocker: make

Re: [PATCH net-next v2] rocker: move netevent neigh update to processes context

2015-06-04 Thread Simon Horman
Hi Scott, Simon, just focusing on this rocker-neigh_tbl_next_index++ issue at the moment, I think the change below would make _rocker_neigh_add() safe to call without needing to put neigh_update into process context. It works because entry is stored between PREPARE and COMMIT, so once

Re: [PATCH v2 net-next] vlan: Add GRO support for non hardware accelerated vlan

2015-06-02 Thread Simon Horman
On Mon, Jun 01, 2015 at 02:56:25PM -0700, David Miller wrote: From: Eric Dumazet eric.duma...@gmail.com Date: Mon, 01 Jun 2015 07:12:37 -0700 Can we ensure offload_base contains a sensible order of expected types ? This seemed easy enough to kill, so I pushed the following into

Re: [PATCH net-next v2] rocker: move netevent neigh update to processes context

2015-06-04 Thread Simon Horman
Hi Dave, On Wed, Jun 03, 2015 at 11:38:29PM -0700, David Miller wrote: From: sfel...@gmail.com Date: Tue, 2 Jun 2015 20:43:28 -0700 From: Scott Feldman sfel...@gmail.com v2: Changes based on review: - David Miller da...@davemloft.net raise problem with system_wq not

Re: [PATCH net-next v2] rocker: move netevent neigh update to processes context

2015-06-04 Thread Simon Horman
Hi Dave, On Thu, Jun 04, 2015 at 01:34:09AM -0700, David Miller wrote: From: Simon Horman simon.hor...@netronome.com Date: Thu, 4 Jun 2015 17:20:48 +0900 What I was seeing is as follows: 1. rocker_port_ipv4_nh() is called via switchdev_port_obj_add() with trans

Re: [PATCH 2/2] sh_eth: Remove obsolete r8a779x-ether platform_device_id entries

2015-06-23 Thread Simon Horman
anymore, hence remove the corresponding platform_device_id entry. Signed-off-by: Geert Uytterhoeven geert+rene...@glider.be Acked-by: Simon Horman horms+rene...@verge.net.au --- drivers/net/ethernet/renesas/sh_eth.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet

Re: [PATCH 1/2] sh_eth: Remove obsolete r7s72100-ether platform_device_id entry

2015-06-23 Thread Simon Horman
anymore, hence remove the corresponding platform_device_id entry. Signed-off-by: Geert Uytterhoeven geert+rene...@glider.be Acked-by: Simon Horman horms+rene...@verge.net.au --- drivers/net/ethernet/renesas/sh_eth.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet

Re: [PATCH net-next] rocker: fix neigh tbl index increment race

2015-06-14 Thread Simon Horman
neigh_tbl_next_index++ COMMIT phase // use value stashed in PREPARE phase Reported-by: Simon Horman simon.hor...@netronome.com Signed-off-by: Scott Feldman sfel...@gmail.com Reviewed-by: Simon Horman simon.hor...@netronome.com --- drivers/net/ethernet/rocker/rocker.c |4

[PATCH/RFC net-next] openvswitch: allow output of MPLS packets on tunnel vports

2015-06-15 Thread Simon Horman
approach was taken in order to minimise the chance of fallout. This patch proposes relaxing one restriction which was introduced at that time. My limited testing has not isolated any side effects of this change. Signed-off-by: Simon Horman simon.hor...@netronome.com --- net/openvswitch/flow_netlink.c

[PATCH net-next v2] rocker: remove rocker parameter from functions that have rocker_port parameter

2015-05-31 Thread Simon Horman
The rocker (switch) of a rocker_port may be trivially obtained from the latter it seems cleaner not to pass the former to a function when the latter is being passed anyway. rocker_port_rx_proc() is omitted from this change as it is a hot path case. Signed-off-by: Simon Horman simon.hor

Re: [PATCH/RFC net-next] rocker: remove rocker parameter from functions that have rocker_port parameter

2015-05-31 Thread Simon Horman
On Thu, May 28, 2015 at 08:53:20AM -0700, Scott Feldman wrote: On Thu, May 28, 2015 at 2:18 AM, David Laight david.lai...@aculab.com wrote: From: Simon Horman Sent: 28 May 2015 04:23 The rocker (switch) of a rocker_port may be trivially obtained from the latter it seems cleaner

Re: [PATCH/RFC net-next] rocker: by default accept untagged packets

2015-05-26 Thread Simon Horman
Hi Scott, On Tue, May 26, 2015 at 02:04:00AM -0700, Scott Feldman wrote: On Tue, May 26, 2015 at 12:28 AM, Scott Feldman sfel...@gmail.com wrote: On Mon, May 25, 2015 at 5:55 PM, Simon Horman simon.hor...@netronome.com wrote: This will occur anyway if the 8021q module is loaded

Re: [PATCH 2/3 nf-next] netfilter: nf_tables: allow to bind table to net_device

2015-05-26 Thread Simon Horman
On Tue, May 26, 2015 at 11:58:24AM +0200, Pablo Neira Ayuso wrote: On Tue, May 26, 2015 at 09:48:41AM +0900, Simon Horman wrote: Hi Pablo, On Mon, May 25, 2015 at 02:46:41PM +0200, Pablo Neira Ayuso wrote: This patch adds the internal NFT_AF_NEEDS_DEV flag to indicate that you must

Re: [PATCH/RFC net-next] rocker: remove rocker parameter from functions that have rocker_port parameter

2015-05-28 Thread Simon Horman
On Thu, May 28, 2015 at 08:15:42AM +0200, Jiri Pirko wrote: Thu, May 28, 2015 at 05:23:17AM CEST, simon.hor...@netronome.com wrote: The rocker (switch) of a rocker_port may be trivially obtained from the latter it seems cleaner not to pass the former to a function when the latter is being

[PATCH/RFC net-next] rocker: remove rocker parameter from functions that have rocker_port parameter

2015-05-27 Thread Simon Horman
The rocker (switch) of a rocker_port may be trivially obtained from the latter it seems cleaner not to pass the former to a function when the latter is being passed anyway. Signed-off-by: Simon Horman simon.hor...@netronome.com --- drivers/net/ethernet/rocker/rocker.c | 122

Re: [PATCH/RFC net-next] rocker: by default accept untagged packets

2015-05-27 Thread Simon Horman
Hi Scott, On Wed, May 27, 2015 at 12:34:57AM -0700, Scott Feldman wrote: On Tue, May 26, 2015 at 6:07 PM, Simon Horman simon.hor...@netronome.com wrote: [snip] I have some questions about that approach: * Does that behaviour differ from other devices (that don't set

Decreasing xmit RECURSION_LIMIT

2015-05-27 Thread Simon Horman
Hi Dave, Hi All, I am wondering about your feelings about reducing the xmit RECURSION_LIMIT in net/core/dev.c. It was last changed, from 3 to 10, by you by 11a766ce915fc (net: Increase xmit RECURSION_LIMIT to 10.) where you described 3 as definitely too low. I believe this occurred in v3.6.37;

Re: [PATCH,v2 net-next] ipvs: skb_orphan in case of forwarding

2015-07-05 Thread Simon Horman
On Sun, Jul 05, 2015 at 03:19:27PM -0700, Alex Gartrell wrote: On Sun, Jul 5, 2015 at 3:13 PM, Julian Anastasov j...@ssi.bg wrote: May be the patch fixes crashes? If yes, Simon should apply it for ipvs/net tree, otherwise after the merge window... Yeah this is definitely a

[PATCH v3 net-next 1/2] rocker: remove unused rocker_port parameter from rocker_port_kfree

2015-05-24 Thread Simon Horman
Remove unused rocker_port parameter from rocker_port_kfree. Also remove the rocker_port parameter from callers of rocker_port_kfree where the parameter it is now unused. Signed-off-by: Simon Horman simon.hor...@netronome.com Acked-by: Scott Feldman sfel...@gmail.com --- v3 * Rebased v2 * Added

[PATCH v3 net-next 2/2] rocker: mark parameters and local variables as const

2015-05-24 Thread Simon Horman
Mark parameters and local variables as const where possible. Signed-off-by: Simon Horman simon.hor...@netronome.com Acked-by: Scott Feldman sfel...@gmail.com --- v3 * Rebased and updated to cover new parameters and local variables that may be const * Added Scott Feldman's Ack v2 * Make more

[PATCH v3 net-next 0/2] rocker: unused parameter and const cleanups

2015-05-24 Thread Simon Horman
to be unrelated. Accordingly I am reposting the series. * Changes v2 - v3 - Rebase and update for new variables and parameters that may be const * Changes v1 - v2 - Found quite a few more variables and parameters to make const Simon Horman (2): rocker: remove unused rocker_port parameter from

[PATCH/RFC net-next] rocker: by default accept untagged packets

2015-05-25 Thread Simon Horman
should not affect bridging, although the rules are harmlessly installed anyway. This is in keeping with the behaviour for VLANs when the 8021q modules is loaded. To aid implementation of the above provide a helper and use it to replace some existing code. Signed-off-by: Simon Horman simon.hor

Re: [PATCH 2/3 nf-next] netfilter: nf_tables: allow to bind table to net_device

2015-05-25 Thread Simon Horman
Hi Pablo, On Mon, May 25, 2015 at 02:46:41PM +0200, Pablo Neira Ayuso wrote: This patch adds the internal NFT_AF_NEEDS_DEV flag to indicate that you must attach this table to a net_device. This change is required by the follow up patch that introduces the new netdev table. Signed-off-by:

Re: [PATCH 1/3 nf-next] netfilter: default CONFIG_NETFILTER_INGRESS to y

2015-05-25 Thread Simon Horman
Hi Pablo, On Mon, May 25, 2015 at 02:46:40PM +0200, Pablo Neira Ayuso wrote: Useful to compile-test all options. Suggested-by: by Alexei Stavoroitov a...@plumgrid.com Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org There seems to be a stray by between ':' and Alexi's name. ---

[PATCH 3/4 nf-next] ipvs: add sync_maxlen parameter for the sync daemon

2015-08-21 Thread Simon Horman
. Problem reported by Dan Carpenter. Reported-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Julian Anastasov j...@ssi.bg Signed-off-by: Simon Horman ho...@verge.net.au --- include/net/ip_vs.h | 19 +++--- include/uapi/linux/ip_vs.h | 1 + net/netfilter/ipvs/ip_vs_ctl.c

[GIT PULL nf-next] Second Round of IPVS Updates for v4.3

2015-08-21 Thread Simon Horman
Hi Pablo, please consider these IPVS Updates for v4.3. I realise these are a little late in the cycle, so if you would prefer me to repost them for v4.4 then just let me know. The updates include: * A new scheduler from Raducu Deaconu * Enhanced configurability of the sync daemon from Julian

[PATCH 4/4 nf-next] ipvs: add more mcast parameters for the sync daemon

2015-08-21 Thread Simon Horman
From: Julian Anastasov j...@ssi.bg - mcast_group: configure the multicast address, now IPv6 is supported too - mcast_port: configure the multicast port - mcast_ttl: configure the multicast TTL/HOP_LIMIT Signed-off-by: Julian Anastasov j...@ssi.bg Signed-off-by: Simon Horman ho...@verge.net.au

[PATCH 2/4 nf-next] ipvs: call rtnl_lock early

2015-08-21 Thread Simon Horman
ip_mc_{join, leave}_group and ipv6_sock_mc_{join, drop}). Signed-off-by: Julian Anastasov j...@ssi.bg Signed-off-by: Simon Horman ho...@verge.net.au --- net/netfilter/ipvs/ip_vs_ctl.c | 50 +++-- net/netfilter/ipvs/ip_vs_sync.c | 2 -- 2 files changed, 33

[PATCH 1/4 nf-next] ipvs: Add ovf scheduler

2015-08-21 Thread Simon Horman
...@gmail.com Acked-by: Julian Anastasov j...@ssi.bg Signed-off-by: Simon Horman ho...@verge.net.au --- net/netfilter/ipvs/Kconfig | 11 ++ net/netfilter/ipvs/Makefile| 1 + net/netfilter/ipvs/ip_vs_ovf.c | 86 ++ 3 files changed, 98 insertions

[PATCH/RFC] openvswitch: Retain parsed IPv6 header fields in flow on error skipping extension headers

2015-08-13 Thread Simon Horman
matching on the IP protocol and IPv6 addresses of packets with malformed extension headers. Signed-off-by: Simon Horman simon.hor...@netronome.com --- * Some consideration should be given to unwanted side effects of this patch as it affects the handling of malformed packets. Signed-off-by: Simon

[PATCH nf 5/6] ipvs: fix crash with sync protocol v0 and FTP

2015-07-15 Thread Simon Horman
From: Julian Anastasov j...@ssi.bg Fix crash in 3.5+ if FTP is used after switching sync_version to 0. Fixes: 749c42b620a9 (ipvs: reduce sync rate with time thresholds) Signed-off-by: Julian Anastasov j...@ssi.bg Signed-off-by: Simon Horman ho...@verge.net.au --- net/netfilter/ipvs/ip_vs_sync.c

[PATCH nf 1/6] ipvs: fix ipv6 route unreach panic

2015-07-15 Thread Simon Horman
and simply capture the skb_dst(skb)-dev and use that for the purpose of the invocation. Signed-off-by: Alex Gartrell agartr...@fb.com Acked-by: Julian Anastasov j...@ssi.bg Signed-off-by: Simon Horman ho...@verge.net.au --- net/netfilter/ipvs/ip_vs_xmit.c | 7 +++ 1 file changed, 7 insertions

[PATCH nf 3/6] ipvs: fix crash if scheduler is changed

2015-07-15 Thread Simon Horman
name to indicate that scheduler is not assigned, a state when we drop new connections. Reported-by: Alexander Vasiliev a.vasy...@404-group.com Fixes: ceec4c381681 (ipvs: convert services to rcu) Signed-off-by: Julian Anastasov j...@ssi.bg Signed-off-by: Simon Horman ho...@verge.net.au --- net

[PATCH nf 2/6] ipvs: do not use random local source address for tunnels

2015-07-15 Thread Simon Horman
cache is refreshed. By this way we will get preferred source address from routing. Reported-by: Michael Vallaly l...@nolatency.com Fixes: 026ace060dfe (ipvs: optimize dst usage for real server) Signed-off-by: Julian Anastasov j...@ssi.bg Signed-off-by: Simon Horman ho...@verge.net.au --- net

[PATCH nf 4/6] ipvs: skb_orphan in case of forwarding

2015-07-15 Thread Simon Horman
to be true, like ip_local_out). Additionally, skb_set_owner_w is totally broken for non full-socks. Signed-off-by: Alex Gartrell agartr...@fb.com Fixes: 41063e9dd119 (ipv4: Early TCP socket demux.) Acked-by: Julian Anastasov j...@ssi.bg Signed-off-by: Simon Horman ho...@verge.net.au --- net/netfilter

[PATCH nf 6/6] ipvs: call skb_sender_cpu_clear

2015-07-15 Thread Simon Horman
From: Julian Anastasov j...@ssi.bg Reset XPS's sender_cpu on forwarding. Signed-off-by: Julian Anastasov j...@ssi.bg Fixes: 2bd82484bb4c (xps: fix xps for stacked devices) Signed-off-by: Simon Horman ho...@verge.net.au --- net/netfilter/ipvs/ip_vs_xmit.c | 6 ++ 1 file changed, 6 insertions

[PATCH nf 0/6] IPVS Fixes for v4.2

2015-07-15 Thread Simon Horman
Hi Pablo, please consider this fix for v4.2. For reasons that are not clear to me it is a bumper crop. It seems to me that they are all relevant to stable. Please let me know if you need my help to get the fixes into stable. * ipvs: fix ipv6 route unreach panic This problem appears to be

Re: [PATCH/RFC net-next] rocker: forward packets to CPU when a port in promiscuous mode

2015-07-15 Thread Simon Horman
On Wed, Jul 15, 2015 at 07:50:32AM -0700, Scott Feldman wrote: On Wed, Jul 15, 2015 at 12:54 AM, Simon Horman simon.hor...@netronome.com wrote: On Wed, Jul 15, 2015 at 12:18:20AM -0700, Scott Feldman wrote: On Tue, Jul 14, 2015 at 11:34 PM, Simon Horman simon.hor...@netronome.com wrote

[PATCH net-next] rocker: forward packets to CPU when port is joined to openvswitch

2015-07-15 Thread Simon Horman
Teach rocker to forward packets to CPU when a port is joined to Open vSwitch. There is scope to later refine what is passed up as per Open vSwitch flows on a port. This does not change the behaviour of rocker ports that are not joined to Open vSwitch. Signed-off-by: Simon Horman simon.hor

Re: [PATCH net-next v2 0/5] switchdev: avoid duplicate packet forwarding

2015-07-16 Thread Simon Horman
offload_fwd_mark generator helper rocker: add offload_fwd_mark support switchdev: update documentation for offload_fwd_mark [snip] All patches: Reviewed-by: Simon Horman simon.hor...@netronome.com -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord

Re: [RFC net-next 22/22] openvswitch: Use regular GRE net_device instead of vport

2015-07-16 Thread Simon Horman
On Fri, Jul 10, 2015 at 04:19:24PM +0200, Thomas Graf wrote: From: Pravin Shelar pshe...@nicira.com Removes all of the OVS specific GRE code and makes OVS use a GRE net_device. Signed-off-by: Pravin B Shelar pshe...@nicira.com [snip] @@ -115,6 +117,8 @@ static bool log_ecn_error = true;

  1   2   3   4   5   6   7   8   9   10   >