On Tue, 21 May 2019 08:15:36 +0200
Jiri Pirko wrote:
> + if (static_branch_unlikely(&generic_xdp_needed_key)) {
> + int ret2;
> +
> + preempt_disable();
> + rcu_read_lock();
> + ret2 = do_xdp_generic(rcu_dereference(skb->dev->xdp_prog), skb);
>
The formatting of setting mac address was confusing.
Break lines and fix highlighting.
Signed-off-by: Stephen Hemminger
---
man/man8/ip-link.8.in | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/man/man8/ip-link.8.in b/man/man8/ip-link.8.in
index d035a5c92ed5
On Mon, 20 May 2019 11:56:52 +0200
Paolo Abeni wrote:
> The mirred act admits an optional control action, defaulting
> to TC_ACT_PIPE. The parsing code currently emits an error message
> if the control action is not provided on the command line, even
> if the command itself completes with no erro
On Wed, 22 May 2019 22:56:07 +
Sunil Muthuswamy wrote:
> Currently, the hv_sock buffer size is static and can't scale to the
> bandwidth requirements of the application. This change allows the
> applications to influence the socket buffer sizes using the SO_SNDBUF and
> the SO_RCVBUF socket o
On Fri, 17 May 2019 10:59:13 -0700
David Ahern wrote:
> index 2b3dcc5dbd53..d980b86ffd42 100644
> --- a/ip/iproute.c
> +++ b/ip/iproute.c
> @@ -2035,7 +2035,11 @@ static int iproute_get(int argc, char **argv)
> if (addr.bytelen)
> addattr_l(&req
This set of patches came about while investigating XDP
generic on Azure. The split brain nature of the accelerated
networking exposed issues with the stack device model.
Stephen Hemminger (2):
netvsc: unshare skb in VF rx handler
net: core: support XDP generic on stacked devices.
drivers
t;net: xdp: support xdp generic on virtual devices")
Signed-off-by: Stephen Hemminger
---
v1 - call xdp_generic in netvsc handler
v2 - do xdp_generic in generic rx handler processing
v3 - move xdp_generic call inside the another pass loop
net/core/
Fixes: 0c195567a8f6 ("netvsc: transparent VF management")
Signed-off-by: Stephen Hemminger
---
drivers/net/hyperv/netvsc_drv.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c
index 06393b215102..9873b8679f81 100644
--- a/dri
On Thu, 23 May 2019 19:19:40 +
Saeed Mahameed wrote:
> On Thu, 2019-05-23 at 10:54 -0700, Stephen Hemminger wrote:
> > When a device is stacked like (team, bonding, failsafe or netvsc) the
> > XDP generic program for the parent device was not called.
> >
> > M
On Fri, 24 May 2019 17:05:46 +0100
John Hurley wrote:
> TC hooks allow the application of filters and actions to packets at both
> ingress and egress of the network stack. It is possible, with poor
> configuration, that this can produce loops whereby an ingress hook calls
> a mirred egress action
Begin forwarded message:
Date: Sat, 25 May 2019 04:55:19 +
From: bugzilla-dae...@bugzilla.kernel.org
To: step...@networkplumber.org
Subject: [Bug 203703] New: 5.1 regression makes r8169 Ethernet connection
inoperable if fq_codel qdisc is used
https://bugzilla.kernel.org/show_bug.cgi?id=2
On Mon, 27 May 2019 12:21:51 +0530
Arun Kumar Neelakantam wrote:
> Hi team,
>
> we are using "skb = netdev_alloc_skb(NULL, len);" which is getting
> failed sometimes for len = 16k.
>
> I suspect mostly system memory got fragmented and hence atomic memory
> allocation for 16k is failing, can y
Begin forwarded message:
Date: Tue, 28 May 2019 15:49:52 +
From: bugzilla-dae...@bugzilla.kernel.org
To: step...@networkplumber.org
Subject: [Bug 203743] New: Networking goes down when running Docker and
receiving fragmented IPv4 packets
https://bugzilla.kernel.org/show_bug.cgi?id=203743
neric on virtual devices")
Signed-off-by: Stephen Hemminger
---
v1 - call xdp_generic in netvsc handler
v2 - do xdp_generic in generic rx handler processing
v3 - move xdp_generic call inside the another pass loop
v4 - reset skb mac_len after xdp is called
net/core/
This set of patches came about while investigating XDP
generic on Azure. The split brain nature of the accelerated
networking exposed issues with the stack device model.
Stephen Hemminger (2):
netvsc: unshare skb in VF rx handler
net: core: support XDP generic on stacked devices.
drivers
Fixes: 0c195567a8f6 ("netvsc: transparent VF management")
Signed-off-by: Stephen Hemminger
---
drivers/net/hyperv/netvsc_drv.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c
index 06393b215102..9873b8679f81 100644
--- a/dri
On Fri, 24 May 2019 10:08:28 -0600
David Ahern wrote:
> On 5/24/19 2:59 AM, Nicolas Dichtel wrote:
> > Before the patch:
> > $ ip netns add foo
> > $ ip link add name veth1 address 2a:a5:5c:b9:52:89 type veth peer name
> > veth2 address 2a:a5:5c:b9:53:90 netns foo
> > RTNETLINK answers: No such
On Mon, 27 May 2019 23:03:49 +0200
Lukasz Czapnik wrote:
> sscanf truncates read port values silently without any error. As sscanf
> man says:
> (...) sscanf() conform to C89 and C99 and POSIX.1-2001. These standards
> do not specify the ERANGE error.
>
> Replace sscanf with safer get_be16 that
On Thu, 30 May 2019 16:43:20 +
Kevin 'ldir' Darbyshire-Bryant wrote:
> diff --git a/include/uapi/linux/pkt_cls.h b/include/uapi/linux/pkt_cls.h
> index 51a0496f..b0c6a49a 100644
> --- a/include/uapi/linux/pkt_cls.h
> +++ b/include/uapi/linux/pkt_cls.h
> @@ -105,7 +105,8 @@ enum tca_id {
>
On Thu, 30 May 2019 16:43:20 +
Kevin 'ldir' Darbyshire-Bryant wrote:
> ctinfo is an action restoring data stored in conntrack marks to various
> fields. At present it has two independent modes of operation,
> restoration of DSCP into IPv4/v6 diffserv and restoration of conntrack
> marks into
On Wed, 29 May 2019 20:17:38 -0700
David Ahern wrote:
> From: David Ahern
>
> Kernel now requires NLA_F_NESTED to be set on new nested
> attributes. Set NLA_F_NESTED in rta_nest.
>
> Signed-off-by: David Ahern
> ---
> lib/libnetlink.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a
On Wed, 29 May 2019 20:17:44 -0700
David Ahern wrote:
> +static struct
> +{
kernel style is:
static struct {
...
On Wed, 29 May 2019 20:17:44 -0700
David Ahern wrote:
> +
> +struct rtnl_handle rth_del = { .fd = -1 };
> +
can this be static?
On Wed, 29 May 2019 20:17:44 -0700
David Ahern wrote:
> +
> +static void print_nh_gateway(FILE *fp, const struct nhmsg *nhm,
> + const struct rtattr *rta)
> +{
> + const char *gateway = format_host_rta(nhm->nh_family, rta);
> +
> + if (is_json_context())
> +
On Wed, 29 May 2019 16:42:10 +0200
Nicolas Dichtel wrote:
> It will obviously fail. This is a follow up of the commit
> 757837230a65 ("lib: suppress error msg when filling the cache").
>
> Suggested-by: David Ahern
> Signed-off-by: Nicolas Dichtel
Looks good, thanks for following up.
Applied.
On Wed, 29 May 2019 20:52:42 +0300
Nikolay Aleksandrov wrote:
> While I fixed the mdb json output, I did overlook the text output.
> This patch returns the original text output format:
> dev port grp
> Example (old format, restored by this patch):
> dev br0 port eth8 grp 239.1.1.11 temp
>
On Thu, 30 May 2019 20:03:41 +0200
Davide Caratti wrote:
>
> +static inline int tc_skb_pull_vlans(struct sk_buff *skb,
> + unsigned int *hdr_count,
> + __be16 *proto)
> +{
> + if (skb_vlan_tag_present(skb))
> + *pro
On Thu, 30 May 2019 16:43:20 +
Kevin 'ldir' Darbyshire-Bryant wrote:
Please don't use HTML encoded mail. I.e not exchange.
> +
> + if (argc) {
> + if (matches(*argv, "dscp") == 0) {
> + NEXT_ARG();
> + char *slash;
> +
Details are a bit scarce.
The referenced commit is.
commit 7dc2bccab0ee37ac28096b8fcdc390a679a15841
Author: Maxim Mikityanskiy
Date: Tue May 21 06:40:04 2019 +
Validate required parameters in inet6_validate_link_af
Begin forwarded message:
Date: Sat, 01 Jun 2019 09:53:51 +
From
On Mon, 3 Jun 2019 21:41:43 +0100
Kevin Darbyshire-Bryant wrote:
> ctinfo is an action restoring data stored in conntrack marks to various
> fields. At present it has two independent modes of operation,
> restoration of DSCP into IPv4/v6 diffserv and restoration of conntrack
> marks into packet
On Fri, 31 May 2019 14:12:15 +0200
Davide Caratti wrote:
> while at it, fix missing square bracket near 'ptype' and a typo in the
> action description (it's -> its).
>
> Signed-off-by: Davide Caratti
Applied. Thanks
On Thu, 30 May 2019 18:32:27 +0300
Baruch Siach wrote:
> Since commit 2f1242efe9d ("devlink: Add devlink health show command") we
> use the sys/sysinfo.h header for the sysinfo(2) system call. But since
> iproute2 carries a local version of the kernel struct sysinfo, this
> causes a collision wit
On Thu, 30 May 2019 18:32:27 +0300
Baruch Siach wrote:
> Since commit 2f1242efe9d ("devlink: Add devlink health show command") we
> use the sys/sysinfo.h header for the sysinfo(2) system call. But since
> iproute2 carries a local version of the kernel struct sysinfo, this
> causes a collision wit
On Fri, 31 May 2019 11:34:46 +0200
Davide Caratti wrote:
> don't hardcode the 'pipe' control action, so that the following TDC test
>
> b776 - Replace simple action with invalid goto chain control
>
> can detect kernels that correctly validate 'goto chain' control action.
>
> CC: Andrea Claud
VM's where 30% of the
time eth0 and eth1 get swapped.
Note: udev MAC address policy is disabled on Azure images
because the netvsc and PCI VF will have the same mac address.
Fixes: af0a5646cb8d ("use the new async probing feature for the hyperv drivers")
Signed-off-by: Stephen He
On Wed, 05 Jun 2019 11:23:59 -0700
Joe Perches wrote:
> Strict 80 column limits with long identifiers are just silly.
>
> I don't know how strictly enforced the iproute2 80 column limit
> actually is, but I suggest ignoring that limit where appropriate.
Not strictly enforced, but long identifi
On Thu, 6 Jun 2019 06:49:19 -0500
Parav Pandit wrote:
> Device name on mdev bus is 36 characters long which follow standard uuid
> RFC 4122.
> This is probably the longest name that a kernel will return for a
> device.
>
> Hence increase the buffer size to 64 bytes.
>
> Acked-by: Jiri Pirko
>
On Thu, 6 Jun 2019 10:52:18 -0700
Vedang Patel wrote:
> @@ -405,6 +420,7 @@ static int taprio_print_opt(struct qdisc_util *qu, FILE
> *f, struct rtattr *opt)
> struct rtattr *tb[TCA_TAPRIO_ATTR_MAX + 1];
> struct tc_mqprio_qopt *qopt = 0;
> __s32 clockid = CLOCKID_INVALID;
> +
On Thu, 6 Jun 2019 10:52:19 -0700
Vedang Patel wrote:
> + if (tb[TCA_TAPRIO_ATTR_TXTIME_DELAY])
> + txtime_delay =
> rta_getattr_s32(tb[TCA_TAPRIO_ATTR_TXTIME_DELAY]);
> +
> + print_int(PRINT_ANY, "txtime_delay", " txtime delay %d", txtime_delay);
> +
Once again do not prin
On Wed, 5 Jun 2019 11:51:14 -0700
Stephen Hemminger wrote:
> Doing asynchronous probing can lead to reordered network device names.
> And because udev doesn't have any useful information to construct a
> persistent name, this causes VM's to sporadically boot with reordered
&g
On Thu, 6 Jun 2019 17:32:09 -0400
Roman Mashak wrote:
> The following operation fails:
> % sudo tc actions add action pipe index 1
> % sudo tc filter add dev lo parent : \
>protocol ip pref 10 u32 match ip src 127.0.0.2 \
>flowid 1:10 action gact index 1
>
> Bad action type
On Thu, 6 Jun 2019 17:32:09 -0400
Roman Mashak wrote:
> The following operation fails:
> % sudo tc actions add action pipe index 1
> % sudo tc filter add dev lo parent : \
>protocol ip pref 10 u32 match ip src 127.0.0.2 \
>flowid 1:10 action gact index 1
>
> Bad action type
--+-+-
> 5.1.0 | FAIL (bad IDR) | FAIL (bad IDR)
> 5.1.0(patched)| FAIL (no rule/bad sdata)| PASS
>
> Changes since v1:
> - reword commit message, thanks Stephen Hemminger
>
> Fixes: 087f46ee4ebd ("tc: introduce simple action")
> CC: Andrea Claudi
> CC: Marcelo Ricardo Leitner
> Signed-off-by: Davide Caratti
Applied, thanks
On Thu, 6 Jun 2019 21:13:50 +
"Patel, Vedang" wrote:
> > On Jun 6, 2019, at 12:43 PM, Stephen Hemminger
> > wrote:
> >
> > On Thu, 6 Jun 2019 10:52:18 -0700
> > Vedang Patel wrote:
> >
> >> @@ -405,6 +420,7 @@ static int taprio
Begin forwarded message:
Date: Fri, 07 Jun 2019 10:09:19 +
From: bugzilla-dae...@bugzilla.kernel.org
To: step...@networkplumber.org
Subject: [Bug 203843] New: e1000e crash when ethernet is plugged in
https://bugzilla.kernel.org/show_bug.cgi?id=203843
Bug ID: 203843
On Fri, 7 Jun 2019 12:13:13 +0200
Matteo Croce wrote:
> +void netns_restore(void)
> +{
> + if (saved_netns != -1) {
If saved_netns is -1 then it is a program bug becase
no save was done? then do something?
> + if (!setns(saved_netns, CLONE_NEWNET)) {
> + cl
icate
> nexthop group is joined by default and a second that indicates a
> specific selection by the user (e.g, ip mon nexthop route).
>
> Signed-off-by: David Ahern
Acked-by: Stephen Hemminger
Begin forwarded message:
Date: Fri, 07 Jun 2019 23:53:00 +
From: bugzilla-dae...@bugzilla.kernel.org
To: step...@networkplumber.org
Subject: [Bug 203847] New: VMware e1000 adapter doesn't get an IP address
assigned. Manually assigning one does not solve the issue
https://bugzilla.kernel.
On Fri, 7 Jun 2019 22:41:22 +0200
Matteo Croce wrote:
> When creating a new netns or executing a program into an existing one,
> the unshare() or setns() calls will change the current netns.
> In batch mode, this can run commands on the wrong interfaces, as the
> ifindex value is meaningful only
On Thu, 6 Jun 2019 16:44:26 -0700
Mahesh Bandewar wrote:
> Inclusion of 'dev' is allowed by the syntax but not handled
> correctly by the command. It produces no output for show
> command and falsely successful for change command but does
> not make any changes.
>
> can be verified with the fol
On Tue, 11 Jun 2019 00:16:12 +0200
Matteo Croce wrote:
> + printf("\nnetns: %s\n", nsname);
> + cmd_exec(argv[0], argv, true, nsname);
> return 0;
simple printf breaks JSON output.
On Tue, 11 Jun 2019 01:03:57 +0200
Matteo Croce wrote:
> On Tue, Jun 11, 2019 at 12:52 AM Matteo Croce wrote:
> >
> > On Tue, Jun 11, 2019 at 12:46 AM Stephen Hemminger
> > wrote:
> > >
> > > On Tue, 11 Jun 2019 00:16:12 +0200
> > > Matteo Cro
On Sun, 14 Jul 2019 16:57:54 +0200
Matteo Croce wrote:
> On Wed, Jul 10, 2019 at 1:18 AM Matteo Croce wrote:
> >
> > On Tue, Jul 9, 2019 at 11:38 PM Stephen Hemminger
> > wrote:
> > >
> > > On Tue, 9 Jul 2019 22:40:40 +0200
> > > Matteo Croc
On Mon, 15 Jul 2019 19:40:19 +
"Patel, Vedang" wrote:
> Hi Stephen,
>
> The kernel patches corresponding to this series have been merged. I just
> wanted to check whether these iproute2 related patches are on your TODO list.
>
> Let me know if you need any information from me on these pat
On Sat, 13 Jul 2019 11:44:07 +0200
Andrea Claudi wrote:
> parse_percent() currently allows to specify negative percentages
> or value above 100%. However this does not seems to make sense,
> as the function is used for probabilities or bandiwidth rates.
>
> Moreover, using negative values leads
On Mon, 15 Jul 2019 20:04:30 +0200
Matteo Croce wrote:
> iproute has an utility function which checks if a string is a prefix for
> another one, to allow use of abbreviated commands, e.g. 'addr' or 'a'
> instead of 'address'.
>
> This routine unfortunately considers an empty string as prefix
> o
On Wed, 10 Jul 2019 14:03:18 +0300
Tariq Toukan wrote:
> Hi,
>
> This series from Aya contains several fixes for devlink health
> dump show command with binary data.
>
> In patch 1 we replace the usage of doit with a dumpit, which
> is non-blocking and allows transferring larger amount of data.
On Wed, 10 Jul 2019 10:24:48 +0300
Leon Romanovsky wrote:
> From: Mark Zhang
>
> Update rdma_netlink.h to kernel commit 6e7be47a5345 ("RDMA/nldev:
> Allow get default counter statistics through RDMA netlink").
>
> Signed-off-by: Mark Zhang
> Signed-off-by: Leon Romanovsky
I am waiting on th
On Mon, 15 Jul 2019 15:51:41 -0700
Vedang Patel wrote:
> @@ -405,6 +420,7 @@ static int taprio_print_opt(struct qdisc_util *qu, FILE
> *f, struct rtattr *opt)
> struct rtattr *tb[TCA_TAPRIO_ATTR_MAX + 1];
> struct tc_mqprio_qopt *qopt = 0;
> __s32 clockid = CLOCKID_INVALID;
> +
On Mon, 15 Jul 2019 15:51:42 -0700
Vedang Patel wrote:
> + if (get_s32(&txtime_delay, *argv, 0)) {
Is txtime_delay of a negative value meaningful?
On Mon, 15 Jul 2019 17:15:15 -0700
Jakub Kicinski wrote:
> On Mon, 15 Jul 2019 16:37:43 -0700, Stephen Hemminger wrote:
> > On Mon, 15 Jul 2019 15:51:41 -0700
> > Vedang Patel wrote:
> > > @@ -442,6 +458,11 @@ static int taprio_print_opt(struct qdisc_util *qu,
>
On Wed, 10 Jul 2019 10:24:49 +0300
Leon Romanovsky wrote:
> From: Mark Zhang
>
> This patch presents link, id, task name, lqpn, as well as all sub
> counters of a QP counter.
> A QP counter is a dynamically allocated statistic counter that is
> bound with one or more QPs. It has several sub-cou
On Tue, 9 Jul 2019 15:16:49 +0200
Andrea Claudi wrote:
> Commit ba126dcad20e6 ("ip6tunnel: fix 'ip -6 {show|change} dev
> ' cmds") breaks IPv6 tunnel creation when dev parameter
> is used.
>
> This series revert the original commit, which mistakenly use
> dev for tunnel name, while addressing a
On Thu, 18 Jul 2019 12:55:39 -0700
Vedang Patel wrote:
> - print_string(PRINT_ANY, "deadline_mode", "deadline_mode %s",
> + print_string(PRINT_ANY, "deadline_mode", "deadline_mode %s ",
> (qopt->flags & TC_ETF_DEADLINE_MODE_ON) ? "on"
> : "off");
> + pri
On Fri, 19 Jul 2019 13:00:24 +0200
Jiri Pirko wrote:
> From: Jiri Pirko
>
> Signed-off-by: Jiri Pirko
> ---
> include/linux/netdevice.h | 10 +++-
> net/core/dev.c| 96 +++
> 2 files changed, 86 insertions(+), 20 deletions(-)
>
> diff --git a/i
On Fri, 19 Jul 2019 13:00:22 +0200
Jiri Pirko wrote:
> From: Jiri Pirko
>
> In the past, there was repeatedly discussed the IFNAMSIZ (16) limit for
> netdevice name length. Now when we have PF and VF representors
> with port names like "pfXvfY", it became quite common to hit this limit:
> 01234
On Wed, 17 Jul 2019 17:31:49 +0300
Leon Romanovsky wrote:
> From: Leon Romanovsky
>
> Changelog v0->v1:
> * Fixed typo in manual page (Gal)
> * Rebased on top of d035cc1b "ip tunnel: warn when changing IPv6 tunnel
> without tunnel name"
> * Dropped update header file because it was already
On Wed, 17 Jul 2019 18:15:31 -0700
Ivan Delalande wrote:
> Fixes: fcc16c22 ("provide common json output formatter")
> Signed-off-by: Ivan Delalande
Applied.
On Fri, 19 Jul 2019 21:17:40 +0200
Jiri Pirko wrote:
> Fri, Jul 19, 2019 at 06:29:36PM CEST, step...@networkplumber.org wrote:
> >On Fri, 19 Jul 2019 13:00:24 +0200
> >Jiri Pirko wrote:
> >
> >> From: Jiri Pirko
> >>
> >> Signed-off-by: Jiri Pirko
> >> ---
> >> include/linux/netdevice.h |
9383cdc ("etf: Add skip_sock_check")
> Reported-by: Stephen Hemminger
> Signed-off-by: Vedang Patel
> ---
> tc/q_etf.c | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/tc/q_etf.c b/tc/q_etf.c
> index c2090589bc64..307c50eed48b 10064
On Tue, 23 Jul 2019 13:25:37 +0200
Jiri Pirko wrote:
> From: Jiri Pirko
>
> One cannot depend on *argv being null in case of no arg is left on the
> command line. For example in batch mode, this is not always true. Check
> argc instead to prevent crash.
>
> Reported-by: Alex Kushnarov
> Fixes
On Tue, 23 Jul 2019 13:25:37 +0200
Jiri Pirko wrote:
> From: Jiri Pirko
>
> One cannot depend on *argv being null in case of no arg is left on the
> command line. For example in batch mode, this is not always true. Check
> argc instead to prevent crash.
>
> Reported-by: Alex Kushnarov
> Fixes
wrote:
> >>>
> >>> On 7/19/19 3:40 PM, Vedang Patel wrote:
> >>>> In iproute2 txtime-assist series, it was pointed out that print_bool()
> >>>> should be used to print binary values. This is to make it JSON friendly.
> >>>>
> >>&
;
> The change pulls in 'sys/queue.h' from libbsd in case
> system headers don't already provides it.
>
> Tested on linux-musl and linux-glibc.
>
> Bug: https://bugs.gentoo.org/690486
> CC: Stephen Hemminger
> CC: netdev@vger.kernel.org
> Signed-
On Wed, 24 Jul 2019 21:12:18 +0200
Matteo Croce wrote:
> ip link can set parameters both via the 'set' and 'change' keyword.
> In fact, 'change' is an alias for 'set'.
> Document this in the help and manpage.
>
> Fixes: 1d93483985f0 ("iplink: use netlink for link configuration")
> Signed-off-by:
On Tue, 23 Jul 2019 21:36:00 +0200
Jiri Pirko wrote:
> Tue, Jul 23, 2019 at 07:54:01PM CEST, step...@networkplumber.org wrote:
> >On Tue, 23 Jul 2019 13:25:37 +0200
> >Jiri Pirko wrote:
> >
> >> From: Jiri Pirko
> >>
> >> One cannot depend on *argv being null in case of no arg is left on the
On Tue, 23 Jul 2019 13:25:37 +0200
Jiri Pirko wrote:
> From: Jiri Pirko
>
> One cannot depend on *argv being null in case of no arg is left on the
> command line. For example in batch mode, this is not always true. Check
> argc instead to prevent crash.
>
> Reported-by: Alex Kushnarov
> Fixes
line_next.
So change the flow and don't process it. Alongside with that,
free the previous line buffer and prevent memory leak.
Also, avoid passing uninitialized memory to filters.
Fixes: 485d0c6001c4 ("tc: Add batchsize feature for filter and actions")
Signed-off-by: Jiri Pirk
Add the command alias "change" to man page.
Don't show it on usage, since it is not commonly used.
Reported-off-by: Matteo Croce
Signed-off-by: Stephen Hemminger
---
man/man8/ip-link.8.in | 5 +
1 file changed, 5 insertions(+)
diff --git a/man/man8/ip-link.8.in b/man/ma
; The change ports to list.h API and drops dependency of 'sys/queue.h'.
> The API maps one-to-one.
>
> Build-tested on linux-musl and linux-glibc.
>
> Bug: https://bugs.gentoo.org/690486
> CC: Stephen Hemminger
> CC: netdev@vger.kernel.org
> Signed-off-by: Sergei
On Fri, 26 Jul 2019 15:06:09 +0200
Antonio Borneo wrote:
> The command
> ip -details link show can0
> prints in the last line the value of the clock frequency attached
> to the name of the following value "numtxqueues", e.g.
> clock 4950numtxqueues 1 numrxqueues 1 gso_max_size
>
]
},{
"type": "unreachable",
"dst": "192.168.23.0/24",
"protocol": "boot",
"scope": "global",
"flags": [ ]
},{
"type": "prohibit",
"dst": "192.168.24.0/24",
"protocol": "boot",
"scope": "global",
"flags": [ ]
},{
"type": "blackhole",
"dst": "192.168.25.0/24",
"protocol": "boot",
"scope": "global",
"flags": [ ]
} ]
Fixes: 663c3cb23103 ("iproute: implement JSON and color output")
Acked-by: Phil Sutter
Reviewed-and-tested-by: Andrea Claudi
Signed-off-by: Matteo Croce
Signed-off-by: Stephen Hemminger
On Mon, 29 Jul 2019 13:04:09 +0200
Kurt Kanzenbach wrote:
> On Thu, Jul 04, 2019 at 02:24:26PM +0200, Kurt Kanzenbach wrote:
> > Hi,
> >
> > while using the TAPRIO Qdisc on ARM32 I've noticed that the base_time
> > parameter is
> > incorrectly configured. The problem is the utility function get_
On Mon, 22 Jul 2019 14:40:19 -0700
Shannon Nelson wrote:
> +
> +static void ionic_lif_set_netdev_info(struct lif *lif)
> +{
> + struct ionic_admin_ctx ctx = {
> + .work = COMPLETION_INITIALIZER_ONSTACK(ctx.work),
> + .cmd.lif_setattr = {
> + .opcode
For example, the routing
daemons have figured out that by using multiple threads and
turning off the netlink ACK they can update millions of routes
quickly.
Stephen Hemminger (4):
Revert "tc: Remove pointless assignments in batch()"
Revert "tc: flush after each command in batch mod
This reverts commit b133392468d1f404077a8f3554d1f63d48bb45e8.
---
tc/tc.c | 19 ---
1 file changed, 8 insertions(+), 11 deletions(-)
diff --git a/tc/tc.c b/tc/tc.c
index c115155b2234..b7b6bd288897 100644
--- a/tc/tc.c
+++ b/tc/tc.c
@@ -334,7 +334,6 @@ static int batch(const char *
This reverts commit d66fdfda71e4a30c1ca0ddb7b1a048bef30fe79e.
---
tc/tc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tc/tc.c b/tc/tc.c
index 1f23971ae4b9..c115155b2234 100644
--- a/tc/tc.c
+++ b/tc/tc.c
@@ -405,7 +405,6 @@ static int batch(const char *name)
err = do_cmd(l
This reverts commit 485d0c6001c4aa134b99c86913d6a7089b7b2ab0.
---
tc/m_action.c | 65 ++--
tc/tc.c| 199 -
tc/tc_common.h | 7 +-
tc/tc_filter.c | 129
4 files changed, 87 insertions(+), 313 de
This reverts commit 6358bbc381c6e38465838370bcbbdeb77ec3565a.
---
tc/tc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tc/tc.c b/tc/tc.c
index 64e342dd85bf..1f23971ae4b9 100644
--- a/tc/tc.c
+++ b/tc/tc.c
@@ -326,11 +326,11 @@ static int batch(const char *name)
st
Begin forwarded message:
Date: Thu, 01 Aug 2019 06:37:39 +
From: bugzilla-dae...@bugzilla.kernel.org
To: step...@networkplumber.org
Subject: [Bug 204399] New: error in handling vlan tag by raw ethernet socket
https://bugzilla.kernel.org/show_bug.cgi?id=204399
Bug ID: 204399
On Thu, 1 Aug 2019 12:12:58 +0200
Andrea Claudi wrote:
> Add json support on iptunnel and ip6tunnel.
> The plain text output format should remain the same.
>
> Signed-off-by: Andrea Claudi
> ---
> ip/ip6tunnel.c | 82 +++--
> ip/iptunnel.c | 90 +++
On Fri, 2 Aug 2019 13:14:15 +0200
Andrea Claudi wrote:
> On Thu, Aug 1, 2019 at 5:16 PM Stephen Hemminger
> wrote:
> >
> > On Thu, 1 Aug 2019 12:12:58 +0200
> > Andrea Claudi wrote:
> >
> > > Add json support on iptunnel and ip6tunnel.
> > >
On Mon, 5 Aug 2019 11:56:56 +0200
Jiri Pirko wrote:
> From: Jiri Pirko
>
> Loose the "q" from the names and name the structure fields in the same
> way rest of the code does. Also, fix list_add arg order which leads
> to segfault.
>
> Fixes: 33267017faf1 ("iproute2: devlink: port from sys/que
Both IPX and TR have not been supported for a while now.
Remove them from the /proc/sys/net documentation.
Signed-off-by: Stephen Hemminger
---
Documentation/admin-guide/sysctl/net.rst | 29 +---
1 file changed, 1 insertion(+), 28 deletions(-)
diff --git a/Documentation
IPX is no longer supported, but the example in the documentation
might useful. Replace it with IPv6.
Signed-off-by: Stephen Hemminger
---
Documentation/networking/tuntap.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/networking/tuntap.txt
b
On Sat, 3 Aug 2019 10:37:41 +0200
Patrick Talbert wrote:
> nodealy should be nodelay.
>
> Signed-off-by: Patrick Talbert
Both patches applied to current iproute2
On Tue, 6 Aug 2019 18:11:23 +0200
Greg Kroah-Hartman wrote:
> When calling debugfs functions, there is no need to ever check the
> return value. The function can work or not, but the code logic should
> never do something different based on this.
>
> Cc: Mirko Lindner
> Cc:
On Mon, 12 Aug 2019 10:31:39 +0200
Jiri Pirko wrote:
> Mon, Aug 12, 2019 at 03:37:26AM CEST, dsah...@gmail.com wrote:
> >On 8/11/19 7:34 PM, David Ahern wrote:
> >> On 8/10/19 12:30 AM, Jiri Pirko wrote:
> >>> Could you please write me an example message of add/remove?
> >>
> >> altnames a
On Mon, 12 Aug 2019 13:17:06 +0300
Ido Schimmel wrote:
> From: Ido Schimmel
>
> Commit e991c04d64c0 ("Revert "tc: Add batchsize feature for filter and
> actions"") reverted more than it should and broke shared block
> functionality. Fix this by restoring the original functionality.
>
> To repr
Begin forwarded message:
Date: Wed, 13 Jan 2021 13:37:33 +
From: bugzilla-dae...@bugzilla.kernel.org
To: step...@networkplumber.org
Subject: [Bug 211175] New: gretap does not fragment packets regardless of the
DF flag
https://bugzilla.kernel.org/show_bug.cgi?id=211175
Bug ID
1 - 100 of 6298 matches
Mail list logo
