Begin forwarded message:
Date: Tue, 16 Mar 2021 06:39:54 +
From: bugzilla-dae...@bugzilla.kernel.org
To: step...@networkplumber.org
Subject: [Bug 212299] New: RK3288-RTL8211E ethernet driver error
https://bugzilla.kernel.org/show_bug.cgi?id=212299
Bug ID: 212299
Su
On Tue, 16 Mar 2021 11:20:12 +0100
Petr Machata wrote:
> Add a helper to dump a timeval. Print by first converting to double and
> then dispatching to print_color_float().
>
> Signed-off-by: Petr Machata
> ---
> include/json_print.h | 1 +
> lib/json_print.c | 13 +
> 2 files
On Mon, 15 Mar 2021 09:30:07 +0100
"B.Arenfeld" wrote:
> Hello :-)
>
> I'm on an machine with Manjaro Linux.
> I get some error messages from shift command in the routel script:
> /usr/bin/routel: Zeile 48: shift: shift count out of range
>
> Reason are lines from "ip route list table 0" start
Begin forwarded message:
Date: Wed, 17 Mar 2021 14:14:36 +
From: bugzilla-dae...@bugzilla.kernel.org
To: step...@networkplumber.org
Subject: [Bug 212317] New: /proc/net/dev: reversed counter for network
namespaces?
https://bugzilla.kernel.org/show_bug.cgi?id=212317
Bug ID: 2
Wrap help message text at 80 characters, and put list of things
in alpha order.
Signed-off-by: Stephen Hemminger
---
Other places may need this as well.
PS: I made a version that auto-generated the text but it was too verbose
especially since many options in iproute2 are dynamically bound.
ip
On Thu, 18 Mar 2021 04:42:53 +0100
Jiri Bohac wrote:
> for_each_netdev(net, d) {
> + struct netdev_name_node *name_node;
> + list_for_each_entry(name_node, &d->name_node->list,
> list) {
> + if (!sscanf(name_node->
: Stephen Hemminger
---
ip/iplink.c | 490
1 file changed, 35 insertions(+), 455 deletions(-)
diff --git a/ip/iplink.c b/ip/iplink.c
index faafd7e89d6c..5c4dbf767100 100644
--- a/ip/iplink.c
+++ b/ip/iplink.c
@@ -33,8 +33,6 @@
#include "ip_com
On Thu, 18 Mar 2021 10:06:52 +0100
Jiri Bohac wrote:
> On Wed, Mar 17, 2021 at 09:11:08PM -0700, Stephen Hemminger wrote:
> > Rather than copy/paste same code two places, why not make a helper
> > function?
>
> I tried and in it was ugly (too many dependencies into th
Begin forwarded message:
Date: Fri, 19 Mar 2021 07:04:12 +
From: bugzilla-dae...@bugzilla.kernel.org
To: step...@networkplumber.org
Subject: [Bug 212353] New: Requesting IP_RECVTTL via setsockopt returns IP_TTL
via recvmsg()'s cmsghdr
https://bugzilla.kernel.org/show_bug.cgi?id=212353
On Sun, 9 Aug 2020 21:49:24 +0800
Hillf Danton wrote:
> +
> +static void br_workfn(struct work_struct *w)
> +{
> + struct br_work *brw = container_of(w, struct br_work, work);
> +
> + rtnl_lock();
> + brw->err = brw->set(brw->br, brw->val);
> + if (!brw->err)
> + netd
On Tue, 11 Aug 2020 09:33:04 +0300
Leon Romanovsky wrote:
> + print_color_string(PRINT_ANY, COLOR_NONE, "comm", "comm %s ", tmp);
If you don't want color then just print_string will do the same thing.
print_string(PRINT_ANY, "comm", "comm %s ", tmp);
There appears to be a reference count bug in mlx5 device on hotplug remove.
This is reproducible in Debian testing (5.7.0-2-amd64) which is a recent kernel.
Environment Windows Server 2019 (Hyper-V) with Linux guest.
Remove the SR-IOV option from virtual NIC using GUI and hit apply.
This causes ho
On Fri, 14 Aug 2020 10:46:26 +0200
Sascha Hauer wrote:
> ip maddress add|del takes a MAC address as argument, so insist on
> getting a length of ETH_ALEN bytes. This makes sure the passed argument
> is actually a MAC address and especially not an IPv4 address which
> was previously accepted and s
On Sun, 16 Aug 2020 22:24:24 +0200
Linus Lüssing wrote:
> Implement a configurable MLD Querier wake-up calls "feature" which
> works around a widely spread Android bug in connection with IGMP/MLD
> snooping.
>
> Currently there are mobile devices (e.g. Android) which are not able
> to receive an
On Thu, 6 Aug 2020 16:37:11 -0400
Murali Karicheri wrote:
> +
> + print_int(PRINT_ANY,
> + "proto",
> + "proto %d ",
> + rta_getattr_u8(tb[IFLA_HSR_PROTOCOL]));
Since this unsigned value, you probably want to use
On Tue, 11 Aug 2020 10:32:01 +0300
Leon Romanovsky wrote:
> + print_color_string(PRINT_ANY, COLOR_NONE, "ifname", "dev %s ", name);
Since this is an interface name, you might want to consider using COLOR_IFNAME?
I will go ahead and apply it as is but more work is needed here.
Use the standard color outputs for interface names
Signed-off-by: Stephen Hemminger
---
rdma/dev.c | 2 +-
rdma/link.c | 2 +-
rdma/res.c | 6 +++---
rdma/stat.c | 2 +-
4 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/rdma/dev.c b/rdma/dev.c
index a11081b82170..fd4c2376550c
There is helper function that already has no color mode.
Use it so color is only used when needed
Signed-off-by: Stephen Hemminger
---
rdma/dev.c | 14 +++---
rdma/link.c | 24
rdma/res-cmid.c | 10 +-
rdma/res-cq.c | 2 +-
rdma/res-qp.c
On Tue, 18 Aug 2020 16:17:19 -0700
Wei Wang wrote:
> + if (!oneline)
> + out("\n\tinet-sockopt: (");
> + else
> + out(" inet-sockopt: (");
> + out("recverr: %d, ", sockopt->recverr)
On Thu, 20 Aug 2020 20:52:02 -0700
Roopa Prabhu wrote:
> + if (tb[IFLA_PROTO_DOWN]) {
> + if (rta_getattr_u8(tb[IFLA_PROTO_DOWN]))
> + print_bool(PRINT_ANY,
> +"proto_down", " protodown on ", true);
In general my preference is t
On Fri, 21 Aug 2020 14:09:14 -0700
Roopa Prabhu wrote:
> On 8/20/20 10:18 PM, Roopa Prabhu wrote:
> >
> > On 8/20/20 9:36 PM, Stephen Hemminger wrote:
> >>
> >>
> >> On Thu, 20 Aug 2020 20:52:02 -0700
> >> Roopa Prabh
On Mon, 17 Aug 2020 17:17:35 -0400
Murali Karicheri wrote:
> This series enhances the iproute2 iplink module to add support
> for creating PRP device similar to HSR. The kernel part of this
> is already merged to v5.9 master
>
> v4 - addressed comment from Stephen Hemminger
>
On Sun, 23 Aug 2020 17:42:39 +0200
Linus Lüssing wrote:
> On Sun, Aug 16, 2020 at 03:08:13PM -0700, Stephen Hemminger wrote:
> > Rather than adding yet another feature to the bridge, could this hack be
> > done by
> > having a BPF hook? or netfilter module?
>
>
On Tue, 11 Jun 2019 20:05:13 +0200
Matteo Croce wrote:
> Pass the -pipe option to GCC, to use pipes instead of temp files.
> On a slow AMD G-T40E CPU we get a non negligible 6% improvement
> in build time.
>
> real1m15,111s
> user1m2,521s
> sys 0m12,465s
>
> real1m10,861s
> user
Begin forwarded message:
Date: Wed, 12 Jun 2019 07:49:06 +
From: bugzilla-dae...@bugzilla.kernel.org
To: step...@networkplumber.org
Subject: [Bug 203867] New: invalid parameter to NL_SET_ERR_MSG_ATTR() in
vxlan.c and geneve.c
https://bugzilla.kernel.org/show_bug.cgi?id=203867
Sending VLAN packets through AF_PACKET over Hyper-V netvsc driver doesn't work
now.
The question is what is best option for fixing it?
AF_PACKET handles VLAN stripping on receive, but there currently is no mechanism
for VLAN offload on transmit. Instead an application may form a raw packet with
a
On Tue, 11 Jun 2019 20:03:26 +0200
Matteo Croce wrote:
> Even if not running the testsuite, every build will leave
> a stale tc_testkenv.* file in the system temp directory.
> Conditionally create the temp file only if we're running the testsuite.
>
> Signed-off-by: Matteo Croce
> ---
> testsu
On Wed, 12 Jun 2019 19:32:29 +0200
Matteo Croce wrote:
> On Wed, Jun 12, 2019 at 6:04 PM Matteo Croce wrote:
> >
> > On Wed, Jun 12, 2019 at 5:55 PM Stephen Hemminger
> > wrote:
> > >
> > > On Tue, 11 Jun 2019 20:03:26 +0200
> > > Matteo Croce
On Sat, 15 Jun 2019 13:40:56 +0200
Denis Kirjanov wrote:
> diff --git a/include/uapi/linux/netdevice.h b/include/uapi/linux/netdevice.h
> index 86d961c9..aaa48818 100644
> --- a/include/uapi/linux/netdevice.h
> +++ b/include/uapi/linux/netdevice.h
> @@ -30,7 +30,7 @@
> #include
> #include
>
On Sun, 16 Jun 2019 14:46:02 -0700
Michael Forney wrote:
> This variable has the same name as `struct xfrm_filter filter` in
> ip/ipxfrm.c, but overrides that definition since `struct rtfilter`
> is larger.
>
> This is visible when built with -Wl,--warn-common in LDFLAGS:
>
> /usr/bin/ld:
On Fri, 14 Jun 2019 13:24:59 -0400
Pete Morici wrote:
> Signed-off-by: Pete Morici
Looks fine, applied
On Wed, 19 Jun 2019 16:14:14 +0200
Denis Kirjanov wrote:
> update if_link.h to commit 75345f888f700c4ab2448287e35d48c760b202e6
> ("ipoib: show VF broadcast address")
>
> Signed-off-by: Denis Kirjanov
This is only on net-next so the patches should target iproute2-next.
David can update from th
On Tue, 18 Jun 2019 16:49:32 +0200
Matteo Croce wrote:
> Refactor the netns and ipvrf code so less steps are needed to exec commands
> in a netns or a VRF context.
> Also remove some code which became dead. bloat-o-meter shows a tiny saving.
>
> Matteo Croce (3):
> netns: switch netns in the c
On Mon, 24 Jun 2019 19:05:52 +0200
Andrea Claudi wrote:
> 'home', 'nodad' and 'mngtmpaddr' options are IPv6-only, but
> it is possible to set them on IPv4 addresses, too. This should
> not be possible.
>
> Fix this adding a check on the protocol family before setting
> the flags, and exiting wit
On Tue, 25 Jun 2019 14:49:04 +0300
Baruch Siach wrote:
> diff --git a/devlink/devlink.c b/devlink/devlink.c
> index 436935f88bda..b400fab17578 100644
> --- a/devlink/devlink.c
> +++ b/devlink/devlink.c
> @@ -1726,9 +1726,9 @@ static void pr_out_u64(struct dl *dl, const char *name,
> uint64_t val
On Tue, 25 Jun 2019 14:49:05 +0300
Baruch Siach wrote:
> +/* Suppress linux/sysinfo.h to avoid
> + * collision of struct sysinfo definition
> + * with musl libc headers
> + */
You only need a small comment for this.
#define _LINUX_SYSINFO_H /* avoid collision with musl header */
On Tue, 25 Jun 2019 17:35:50 +0800
Hangbin Liu wrote:
> When we disable IPv6 from the start up (ipv6.disable=1), there will be
> no IPv6 route info in the dump message. If we return -1 when
> ifi->ifi_family != AF_INET6, we will get error like
>
> $ ip token list
> Dump terminated
>
> which wil
On Wed, 26 Jun 2019 06:30:44 +0300
Baruch Siach wrote:
> Hi Stephen,
>
> On Tue, Jun 25, 2019 at 11:58:06AM -0700, Stephen Hemminger wrote:
> > On Tue, 25 Jun 2019 14:49:04 +0300
> > Baruch Siach wrote:
> >
> > > diff --git a/devlink/devlink.c b/devlin
Using functions is safer than macros, and printing is not performance
critical.
Signed-off-by: Stephen Hemminger
---
devlink/devlink.c | 62 ---
1 file changed, 42 insertions(+), 20 deletions(-)
diff --git a/devlink/devlink.c b/devlink/devlink.c
On Fri, 27 Apr 2018 14:17:06 +0200
Toke Høiland-Jørgensen wrote:
> + } else if (strcmp(*argv, "datacentre") == 0) {
> + interval = 100;
> + target = 5;
> + } else if (strcmp(*argv, "lan") == 0) {
> + interval
On Fri, 27 Apr 2018 18:11:06 +0300
Ido Schimmel wrote:
> +int br_vlan_pvid_rtnl(const struct net_device *dev, u16 *p_pvid)
> +{
> + struct net_bridge_vlan_group *vg;
> +
> + ASSERT_RTNL();
> + if (netif_is_bridge_master(dev))
> + vg = br_vlan_group(netdev_priv(dev));
> +
The destination mac (destmac) is only valid if EBT_DESTMAC flag
is set. Fix by changing the order of the comparison to look for
the flag first.
Reported-by: syzbot+5c06e318fc558cc27...@syzkaller.appspotmail.com
Signed-off-by: Stephen Hemminger
---
Note: no fixes since this bug goes back to pre
On Fri, 27 Apr 2018 21:57:20 +0200
Toke Høiland-Jørgensen wrote:
> sch_cake is intended to squeeze the most bandwidth and latency out of even
> the slowest ISP links and routers, while presenting an API simple enough
> that even an ISP can configure it.
>
> Example of use on a cable ISP uplink:
On Mon, 30 Apr 2018 07:36:18 -0700
Steve Wise wrote:
> +#define nla_type(attr) ((attr)->nla_type & NLA_TYPE_MASK)
> +
> +void newline(struct rd *rd)
> +{
> + if (rd->json_output)
> + jsonw_end_array(rd->jw);
> + else
> + pr_out("\n");
> +}
> +
> +void newline_inden
On Fri, 27 Apr 2018 13:11:14 -0700
Florian Fainelli wrote:
> We have about 53 netdev_features_t bits defined and counting, add a
> build time check to catch when an u64 type will not be enough and we
> will have to convert that to a bitmap. This is done in
> register_netdevice() for convenience.
On Tue, 1 May 2018 23:57:45 +0530
Rahul Lakkireddy wrote:
> +
> +int vmcore_add_device_dump(struct vmcoredd_data *data)
> +{
> + return __vmcore_add_device_dump(data);
> +}
> +EXPORT_SYMBOL(vmcore_add_device_dump);
> +#endif /* CONFIG_PROC_VMCORE_DEVICE_DUMP
Why the stub wrapper function?
On Tue, 1 May 2018 15:43:07 +0300
Baruch Siach wrote:
> Debian does not distribute libdb4.x-dev for quite some time now. Current
> stable carries libdb5.3-dev. Update the wording accordingly.
>
> Signed-off-by: Baruch Siach
Applied both patches, not sure how many people still use arpd anyway.
On Tue, 1 May 2018 16:16:35 +0300
Ido Schimmel wrote:
> Continue parsing a multipath payload as long as another nexthop can fit
> in the payload.
>
> # ip route add 192.0.2.0/24 nexthop dev dummy0 nexthop dev dummy1
>
> Before:
> # ip route show 192.0.2.0/24
> 192.0.2.0/24
> nexthop de
On Wed, 2 May 2018 16:38:52 +0300
Leon Romanovsky wrote:
> On Mon, Apr 30, 2018 at 08:25:24AM -0700, Stephen Hemminger wrote:
> > On Mon, 30 Apr 2018 07:36:18 -0700
> > Steve Wise wrote:
> >
> > > +#define nla_type(attr) ((attr)->nla_type & NLA_TYPE_MASK)
-off-by: Stephen Hemminger
---
include/net/inet_hashtables.h| 3 +++
include/net/inet_timewait_sock.h | 2 ++
net/dccp/proto.c | 1 +
net/ipv4/inet_connection_sock.c | 1 +
net/ipv4/inet_hashtables.c | 22 +++---
net/ipv4/inet_timewait_sock.c| 8
From: Stephen Hemminger
Not used in current code.
Signed-off-by: Stephen Hemminger
---
misc/ss.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/misc/ss.c b/misc/ss.c
index 4f76999c0fee..97304cd8abfc 100644
--- a/misc/ss.c
+++ b/misc/ss.c
@@ -734,7 +734,6 @@ struct slabstat {
int
From: Stephen Hemminger
The slabinfo names changed years ago, and ss statistics were broken.
This changes to use current slab names and handle TCP IPv6.
Signed-off-by: Stephen Hemminger
---
misc/ss.c | 23 +++
1 file changed, 11 insertions(+), 12 deletions(-)
diff --git a
From: Stephen Hemminger
The output of the ss -s command has been broken for a long time
because of kernel changes (ie since 2.6).
This is an attempt to resolve most of the issues. Still don't like
the way it is using slabinfo to get the data but some of this information
would be expensiv
The tcp_memory field in /proc/net/sockstat is formatted as
a long value by kernel. Change ss to keep this as full value.
Signed-off-by: Stephen Hemminger
---
misc/ss.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/misc/ss.c b/misc/ss.c
index 22c76e34f83b..c88a25581755
From: Stephen Hemminger
Using slabinfo to try and get the number of bind_buckets no longer
works because of slab cache merging. Instead use proposed enhancment
of /proc/net/sockstat to get the same data.
Signed-off-by: Stephen Hemminger
---
misc/ss.c | 10 --
1 file changed, 4
These are keys for lookup and should be const.
Signed-off-by: Stephen Hemminger
---
misc/ss.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/misc/ss.c b/misc/ss.c
index 3ed7e66962f3..22c76e34f83b 100644
--- a/misc/ss.c
+++ b/misc/ss.c
@@ -4539,7 +4539,7 @@ static int
On Wed, 2 May 2018 14:08:53 -0700
Eric Dumazet wrote:
> On 05/02/2018 01:27 PM, Stephen Hemminger wrote:
> > The tcp_memory field in /proc/net/sockstat is formatted as
> > a long value by kernel. Change ss to keep this as full value.
> >
> > Signed-off-by: Stephen H
.
Overhead of keeping count in hash bucket head is minimal.
It is cache hot already, and the same thing is already done for
listen buckets.
Signed-off-by: Stephen Hemminger
---
v2 - use unsigned for count
get rid of leftover increment
include/net/inet_hashtables.h| 3 +++
include/net
Services
for Linux.
Signed-off-by: Stephen Hemminger
---
include/uapi/rdma/ib_user_sa.h| 77 ++
include/uapi/rdma/ib_user_verbs.h | 1210 +
.../uapi/rdma/rdma_netlink.h | 13 +
.../uapi/rdma/rdma_user_cm.h |6
On Fri, 4 May 2018 16:13:07 -0600
David Ahern wrote:
> On 5/4/18 3:56 PM, Stephen Hemminger wrote:
> > All user api headers in iproute2 should be in include/uapi
> > so that script can be used to put correct sanitized kernel headers
> > there. And the header files for rdma m
On Sat, 5 May 2018 09:17:31 -0600
David Ahern wrote:
> On 5/4/18 10:58 PM, Stephen Hemminger wrote:
> > On Fri, 4 May 2018 16:13:07 -0600
> > David Ahern wrote:
> >
> >> On 5/4/18 3:56 PM, Stephen Hemminger wrote:
> >>> All user api headers in i
On Mon, 7 May 2018 13:14:33 +0200
GhantaKrishnamurthy MohanKrishna
wrote:
> + struct opt *opts)
> +{
> + struct opt *opt;
> +
> + if (!(opt = get_opt(opts, "media"))) {
You don't need to have assignment in conditional context in this case.
Please spli
On Sun, 6 May 2018 09:16:26 -0700
Alexander Duyck wrote:
> On Sun, May 6, 2018 at 6:43 AM, Jacob S. Moroni wrote:
> > Hello,
> >
> > I have a stupid question regarding which variant of spin_lock to use
> > throughout the network stack, and inside RX handlers specifically.
> >
> > It's my underst
Begin forwarded message:
Date: Mon, 07 May 2018 16:36:49 +
From: bugzilla-dae...@bugzilla.kernel.org
To: step...@networkplumber.org
Subject: [Bug 199643] New: UBSAN: Undefined behaviour in
./include/net/route.h:240:2
https://bugzilla.kernel.org/show_bug.cgi?id=199643
Bug ID:
Begin forwarded message:
Date: Mon, 07 May 2018 16:07:24 +
From: bugzilla-dae...@bugzilla.kernel.org
To: step...@networkplumber.org
Subject: [Bug 199637] New: UBSAN: Undefined behaviour in
net/ipv4/fib_trie.c:503:6
https://bugzilla.kernel.org/show_bug.cgi?id=199637
Bug ID: 19
The eventual goal is to remove all accesses to slab statistics
by iproute2 ss command. This are preliminary steps to add two
statistics which are not working now, because of slab merging
and changes that were done years ago to allow for common inet_hash
tables.
Stephen Hemminger (2):
inet: add
using slub.
Signed-off-by: Stephen Hemminger
---
net/socket.c | 21 +++--
1 file changed, 19 insertions(+), 2 deletions(-)
diff --git a/net/socket.c b/net/socket.c
index f10f1d947c78..89ec7f41559d 100644
--- a/net/socket.c
+++ b/net/socket.c
@@ -234,6 +234,18 @@ static int
-off-by: Stephen Hemminger
---
include/net/inet_hashtables.h| 3 +++
include/net/inet_timewait_sock.h | 2 ++
net/dccp/proto.c | 1 +
net/ipv4/inet_hashtables.c | 22 +++---
net/ipv4/inet_timewait_sock.c| 8 +---
net/ipv4/proc.c
On Mon, 7 May 2018 15:10:44 -0700
Sridhar Samudrala wrote:
> This provides a generic interface for paravirtual drivers to listen
> for netdev register/unregister/link change events from pci ethernet
> devices with the same MAC and takeover their datapath. The notifier and
> event handling code i
On Mon, 7 May 2018 15:10:44 -0700
Sridhar Samudrala wrote:
> +static struct net_device *net_failover_get_bymac(u8 *mac,
> + struct net_failover_ops **ops)
> +{
> + struct net_device *failover_dev;
> + struct net_failover *failover;
> +
> +
On Mon, 7 May 2018 15:10:44 -0700
Sridhar Samudrala wrote:
> + if (netif_running(failover_dev)) {
> + err = dev_open(slave_dev);
> + if (err && (err != -EBUSY)) {
> + netdev_err(failover_dev, "Opening slave %s failed
> err:%d\n",
> +
On Tue, 8 May 2018 19:40:47 +0200
Mohammed Gamal wrote:
> On older windows hosts the net_device instance is returned to
> the caller of rndis_filter_device_add() without having the presence
> bit set first. This would cause any subsequent calls to network device
> operations (e.g. MTU change, ch
On Tue, 08 May 2018 20:17:51 +0200
Mohammed Gamal wrote:
> On Tue, 2018-05-08 at 11:13 -0700, Stephen Hemminger wrote:
> > On Tue, 8 May 2018 19:40:47 +0200
> > Mohammed Gamal wrote:
> >
> > > On older windows hosts the net_device instance is r
ndis_device->link_state ? "down" : "up");
>
> if (net_device->nvsp_version < NVSP_PROTOCOL_VERSION_5)
> - return net_device;
> + goto out;
>
> rndis_filter_query_link_speed(rndis_device, net_device);
>
Reviewed-by: Stephen Hemminger
On Mon, 7 May 2018 11:43:31 -0700
Stephen Hemminger wrote:
> The eventual goal is to remove all accesses to slab statistics
> by iproute2 ss command. This are preliminary steps to add two
> statistics which are not working now, because of slab merging
> and changes that were done
Fix simple misspelling kashkey_offset should be hashkey_offset.
Signed-off-by: Stephen Hemminger
---
drivers/net/hyperv/hyperv_net.h | 2 +-
drivers/net/hyperv/rndis_filter.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/hyperv/hyperv_net.h b/drivers/net
On Wed, 9 May 2018 10:18:23 -0700
Eric Dumazet wrote:
> On 05/09/2018 08:22 AM, Stephen Hemminger wrote:
>
> > I am not sure if these patches are worth applying.
> > The 'ss -s' command has had missing values since 2.4 kernel.
> > And the first
On Wed, 9 May 2018 10:53:58 -0700
Eric Dumazet wrote:
> On 05/09/2018 10:31 AM, Stephen Hemminger wrote:
> > On Wed, 9 May 2018 10:18:23 -0700
> > Eric Dumazet wrote:
> >
> >> On 05/09/2018 08:22 AM, Stephen Hemminger wrote:
> >>
> >>>
On Wed, 9 May 2018 11:53:50 -0700
Eric Dumazet wrote:
> On 05/09/2018 11:44 AM, Stephen Hemminger wrote:
> > On Wed, 9 May 2018 10:53:58 -0700
> > Eric Dumazet wrote:
> >
> >> On 05/09/2018 10:31 AM, Stephen Hemminger wrote:
> >>> On Wed, 9 May 201
fixing;
rather than trying to fix kernel, just trim away the no longer
valid statistics.
Signed-off-by: Stephen Hemminger
---
misc/ss.c | 103 --
1 file changed, 6 insertions(+), 97 deletions(-)
diff --git a/misc/ss.c b/misc/ss.c
index
.
Fixes: 0c195567a8f6 ("netvsc: transparent VF management")
Signed-off-by: Stephen Hemminger
---
drivers/net/hyperv/netvsc_drv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c
index ecc84954c511..da07ccdf8
On Thu, 10 May 2018 15:35:59 +0700
Naruto Nguyen wrote:
> Hello everyone,
>
> Recently, I used netperf to test the TCP performance on loopback
> interface on my 2 nodes, one is installed kernel 4.4.103 and the other
> is 3.12.61
>
> netperf -l 100 -t TCP_RR
> netperf -l 100 -t TCP_RR -- -D
>
>
On Thu, 10 May 2018 22:03:33 +0700
Naruto Nguyen wrote:
> Hi Stephen,
>
> Thanks for your responding. But as I know kernel 4.4.104 has not included
> Spectre/Meltdown fix yet, right?
Yes. 4.4.104 doesn't have KPTI.
That came in around 4.4.109
Begin forwarded message:
Date: Tue, 17 Apr 2018 18:57:20 +
From: bugzilla-dae...@bugzilla.kernel.org
To: step...@networkplumber.org
Subject: [Bug 199427] New: Wired Network interface goes repeatedly up and down
with NetworkManager
https://bugzilla.kernel.org/show_bug.cgi?id=199427
erridden by later ip commands.
Also requires exporting dev_set_alias in netdev core.
Signed-off-by: Stephen Hemminger
---
drivers/net/hyperv/rndis_filter.c | 28
net/core/dev.c| 1 +
2 files changed, 29 insertions(+)
diff --git a/drivers/net/hype
This may already be fixed.
Begin forwarded message:
Date: Wed, 18 Apr 2018 01:52:59 +
From: bugzilla-dae...@bugzilla.kernel.org
To: step...@networkplumber.org
Subject: [Bug 199429] New: smc_shutdown(net/smc/af_smc.c) has a UAF causing
null pointer vulnerability.
https://bugzilla.kernel.org
On Wed, 18 Apr 2018 13:10:49 +0800
Hangbin Liu wrote:
> Hi Stephen,
>
> The patch's subject contains fix. But the kernel feature is applied on
> net-next.
> So I'm not sure if iproute2 net-next is suitable. If you are OK with the
> patch,
> please feel free to apply it on the branch which you
On Wed, 18 Apr 2018 16:14:26 +0300
Nikolay Aleksandrov wrote:
> On 18/04/18 16:07, Joachim Nilsson wrote:
> > On Wed, Apr 18, 2018 at 03:31:57PM +0300, Nikolay Aleksandrov wrote:
> >> On 18/04/18 15:07, Joachim Nilsson wrote:
> >>> - First of all, is this patch useful to anyone
> >> Obvious
On Wed, 18 Apr 2018 13:46:20 +0200
Ursula Braun wrote:
> On 04/18/2018 04:56 AM, Stephen Hemminger wrote:
> > This may already be fixed.
> >
> > Begin forwarded message:
> >
> > Date: Wed, 18 Apr 2018 01:52:59 +
> > From: bugzilla-
On Thu, 19 Apr 2018 18:42:04 -0700
Sridhar Samudrala wrote:
> Use the registration/notification framework supported by the generic
> failover infrastructure.
>
> Signed-off-by: Sridhar Samudrala
Do what you want to other devices but leave netvsc alone.
Adding these failover ops does not reduce
ned-off-by: Stephen Hemminger
---
drivers/net/hyperv/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/hyperv/Kconfig b/drivers/net/hyperv/Kconfig
index 936968d23559..0765d5f61714 100644
--- a/drivers/net/hyperv/Kconfig
+++ b/drivers/net/hyperv/Kconfig
@@ -1,5 +1,6
The values from multicast stats are 64 bit always.
Signed-off-by: Stephen Hemminger
---
ip/ipmroute.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/ip/ipmroute.c b/ip/ipmroute.c
index 59c5b7718e18..eb6b2816324f 100644
--- a/ip/ipmroute.c
+++ b/ip/ipmroute.c
Should use print_hu not print_uint for 16 bit value.
Signed-off-by: Stephen Hemminger
---
tc/f_flower.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tc/f_flower.c b/tc/f_flower.c
index 9d4bfd2f808b..ba8eb66cdd11 100644
--- a/tc/f_flower.c
+++ b/tc/f_flower.c
@@ -1234,7
Signed-off-by: Stephen Hemminger
---
ip/ipneigh.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ip/ipneigh.c b/ip/ipneigh.c
index 4748381701e4..bd6e5c5e18ca 100644
--- a/ip/ipneigh.c
+++ b/ip/ipneigh.c
@@ -204,7 +204,7 @@ static void print_cacheinfo(const struct
necessary.
Signed-off-by: Stephen Hemminger
---
include/json_print.h | 16 +---
lib/json_print.c | 33 ++---
2 files changed, 43 insertions(+), 6 deletions(-)
diff --git a/include/json_print.h b/include/json_print.h
index 2ca7830adbd6..3d400ecf8f50 100644
Metrics are long unsigned, so use correct print function.
Signed-off-by: Stephen Hemminger
---
ip/tcp_metrics.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ip/tcp_metrics.c b/ip/tcp_metrics.c
index 72dc980c92a6..3b82a4e1d2f2 100644
--- a/ip/tcp_metrics.c
+++ b/ip
,
but that got ugly.
Stephen Hemminger (5):
ipneigh: fix missing format specifier
json: make json print_uint take unsigned int
flower: use 16 bit format where possible
tcp_metrics: use print_luint
mroute: use print_uint64
include/json_print.h | 16 +---
ip/ipmroute.c
I think this has already been addressed. But forwarding for sure.
Begin forwarded message:
Date: Mon, 23 Apr 2018 01:26:46 +
From: bugzilla-dae...@bugzilla.kernel.org
To: step...@networkplumber.org
Subject: [Bug 199469] New: Regression in 32-bit-compat dev_ioctl due to
bf4405737f9f85a06db2b0
On Fri, 20 Apr 2018 18:00:58 +0200
Jiri Pirko wrote:
> Fri, Apr 20, 2018 at 05:28:02PM CEST, step...@networkplumber.org wrote:
> >On Thu, 19 Apr 2018 18:42:04 -0700
> >Sridhar Samudrala wrote:
> >
> >> Use the registration/notification framework supported by the generic
> >> failover infrastru
On Mon, 23 Apr 2018 20:24:56 +0300
"Michael S. Tsirkin" wrote:
> On Mon, Apr 23, 2018 at 10:04:06AM -0700, Stephen Hemminger wrote:
> > > >
> > > >I will NAK patches to change to common code for netvsc especially the
> > > >three device mode
201 - 300 of 6298 matches
Mail list logo
