Re: [PATCH net] net: try harder to not reuse ifindex when moving interfaces

On Thu, 2015-10-22 at 20:56 +0200, Thomas Graf wrote: > On 10/22/15 at 07:21pm, Hannes Frederic Sowa wrote: > > Hi Thomas, > > > > On Thu, Oct 22, 2015, at 18:45, Thomas Graf wrote: > > > I understand the race but when does it occur? Whoever creates > > > the original interface owns it and is

[PATCH iproute2] ip-address: properly display zero IPv4 peer address

attribute means that the peer is 0.0.0.0. See inet_fill_ifaddr(), which does: if ((ifa->ifa_address && nla_put_in_addr(skb, IFA_ADDRESS, ifa->ifa_address)) || Signed-off-by: Thomas Haller <thal...@redhat.com> --- ip/ipaddress.c | 15 +-- 1 file changed

Re: [PATCH net] net: try harder to not reuse ifindex when moving interfaces

On Thu, 2015-10-22 at 16:52 +0200, Nicolas Dichtel wrote: > Le 21/10/2015 19:12, Hannes Frederic Sowa a écrit : > > Hello, > > > > On Wed, Oct 21, 2015, at 17:56, David Miller wrote: > > > From: Jiri Benc > > > Date: Wed, 21 Oct 2015 17:25:02 +0200 > > > > > > > On Wed, 21 Oct

Re: [PATCH net] net: try harder to not reuse ifindex when moving interfaces

t; I don't see any way the user space application can prevent this. > There > will always be a race between receiving netlink notifications and > sending config requests. > > I guess Thomas Haller can elaborate more as he ran into this. Jiri, It's really just what you said.

Re: [PATCH iproute2] ip-address: properly display zero IPv4 peer address

On Tue, 2015-11-24 at 12:44 +0100, Phil Sutter wrote: > On Mon, Nov 23, 2015 at 04:04:50PM -0800, Stephen Hemminger wrote: > > On Thu, 22 Oct 2015 10:34:28 +0200 > > Thomas Haller <thal...@redhat.com> wrote: > > > > > Kernel allows for zero IPv4 peer address

Re: commit : ppp: add rtnetlink device creation support - breaks netcf on my machine.

On Tue, 2016-12-06 at 17:12 -0600, Dan Williams wrote: > > > libnl1 rejects the IFLA_INFO_DATA attribute because it expects it > > to > > contain a sub-attribute. Since the payload size is zero it doesn't > > match the policy and parsing fails. > > > > There's no problem with libnl3 because its

[PATCH iproute2 v2] man: fix documentation for range of route table ID

Signed-off-by: Thomas Haller <thal...@redhat.com> --- Changes in v2: - "0" is not a valid table ID. man/man8/ip-route.8.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/man8/ip-route.8.in b/man/man8/ip-route.8.in index 803de3b9..705ceb20 100644 --- a/m

[PATCH iproute2] man: fix documentation for range of route table ID

Signed-off-by: Thomas Haller <thal...@redhat.com> --- man/man8/ip-route.8.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/man8/ip-route.8.in b/man/man8/ip-route.8.in index 803de3b9..9717b959 100644 --- a/man/man8/ip-route.8.in +++ b/man/man8/ip-route.8.in @@

Re: [PATCH net-next] veth: report NEWLINK event when moving the peer device in a new namespace

Hi David, On Mon, 2018-09-03 at 20:54 -0600, David Ahern wrote: > From init_net: > $ ip monitor all-nsid I thought the concern of the patch is the overhead of sending one additional RTM_NEWLINK message. This workaround has likely higher overhead. More importantly, it's so cumbersome, that I

Re: [PATCH net-next] veth: report NEWLINK event when moving the peer device in a new namespace

Hi, On Sat, 2018-09-01 at 17:45 -0600, David Ahern wrote: > On 9/1/18 3:05 AM, Lorenzo Bianconi wrote: > > > > I was thinking about the commit 38e01b30563a and then I realized I > > misread the code > > yesterday. The commit 38e01b30563a provides all relevant info but > > it > > emits the event