Signed-off-by: Uwe Kleine-König [EMAIL PROTECTED]
Cc: Andy Fleming [EMAIL PROTECTED]
---
drivers/net/phy/mdio_bus.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c
index fc2f0e6..7ff55bb 100644
--- a/drivers/net
that that needs fixing?
Best regards
Uwe
---8---
From: Uwe Kleine-König [EMAIL PROTECTED]
add Hirschmann RS422 phy
Signed-off-by: Uwe Kleine-König [EMAIL PROTECTED]
---
drivers/net/phy/Kconfig|3 ++
drivers/net/phy/Makefile |1 +
drivers/net/phy/hirschmann-rs422.c
From: Uwe Kleine-König [EMAIL PROTECTED]
It doesn't make much sense to check for bus being NULL after using
bus-mdio_lock.
Signed-off-by: Uwe Kleine-König [EMAIL PROTECTED]
Cc: Andy Fleming [EMAIL PROTECTED]
---
Hello,
I already sent this patch on November 7, 2007, but without any feedback
make the intended lines aligned in the output (not in the code)
Signed-off-by: Uwe Kleine-König [EMAIL PROTECTED]
---
net/ipv4/ipconfig.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/ipv4/ipconfig.c b/net/ipv4/ipconfig.c
index a52b585..10013cc 100644
---
on ingress shaping. I will try to work
on that, maybe shaping is good enough then?! I will report back.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe from
Hello,
On Thu, May 21, 2015 at 09:36:28AM -0400, Jamal Hadi Salim wrote:
On 05/21/15 03:07, Uwe Kleine-König wrote:
On Wed, May 20, 2015 at 05:30:40PM -0700, Eric Dumazet wrote:
On Wed, 2015-05-20 at 16:46 -0700, Cong Wang wrote:
There is very little to do on ingress side since
in its definition and
declaration file of gainfar.c.
Signed-off-by: Nicholas Krause xerofo...@gmail.com
---
drivers/net/ethernet/freescale/gianfar.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König
Hello,
On Tue, Aug 04, 2015 at 10:20:55AM -0400, Alan Stern wrote:
In that case, adding a call pm_runtime_get_noresume() is the right
thing to do.
Is this an ack for Lucas' patch?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux
l.st...@pengutronix.de
the two \n after Fixes: and before the S-o-b are unusual I think.
Other than that I tested the change on i.MX27 and it works now. The
power refcount oscillates between 1 and 2 now as expected and booting
with NFS-root works fine. So:
Tested-by: Uwe Kleine-König u.kleine-koe
...@rowland.harvard.edu
Tested-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de
Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de
---
Hello David,
I think this is fine to apply now for 4.2-rc. I just picked up the
patch, added Alan's ack and a tested-by for me to make it easier
. I'm with
Florian here.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord
pm_runtime_set_active()
is the right thing to do. But it makes no mention of have to call
pm_runtime_get_noresume(). I would of expected pm_runtime_set_active()
to set the count to the correct value.
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux
arcnet.h
> +
What about
Documentation/networking/arcnet-hardware.txt
Documentation/networking/arcnet.txt
?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To
e). The newly added line is a noop however
unless DEBUG is defined. This doesn't mean the change is bad, but at
least it's not in the scope for a trivial cleanup patch that just
converts existing code to the modern way with no intend to change
behaviour.
Best regards
Uwe
--
Pengutronix e.K.
ethphy: ethernet-phy@7 {
...
reset-gpios = < 25 GPIO_ACTIVE_LOW>;
};
};
};
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
On Thu, May 26, 2016 at 11:00:55AM +0200, Linus Walleij wrote:
> On Thu, May 12, 2016 at 8:42 PM, Uwe Kleine-König
> <u.kleine-koe...@pengutronix.de> wrote:
>
> > [added Linus Walleij to Cc, there is a question for you/him below]
> (...)
> >> +void mdio_device_
et-handling from the
driver.
>From a driver perspecitive, it would be nice if devm_gpiod_get_optional
returned NULL iff the respective gpio isn't specified even with
GPIOLIB=n, but this isn't sensible either because it would result in
quite some gpiolib code to not being conditionall
Hello,
On Fri, Mar 18, 2016 at 08:31:20PM +0100, Mason wrote:
> On 18/03/2016 20:12, Uwe Kleine-König wrote:
>
> > On Fri, Mar 18, 2016 at 04:56:21PM +0100, Sebastian Frias wrote:
> >
> >> What would you think of making at803x_link_change_notify() print a
> >
Hello Sebastian,
On Fri, Mar 18, 2016 at 04:56:21PM +0100, Sebastian Frias wrote:
> On 03/18/2016 01:54 PM, Uwe Kleine-König wrote:
> > From a driver perspecitive, it would be nice if devm_gpiod_get_optional
> > returned NULL iff the respective gpio isn't specified even wit
io is:
gpiod_set_value(priv->gpiod_reset, 1);
msleep(some_time);
gpiod_set_value(priv->gpiod_reset, 0);
and if the gpio is active low, this should be specified in the device
tree. This was done wrong in 13a56b449325 (net: phy: at803x: Add support
for hardware reset).
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
your .config or introduce a Kconfig
dependency)
- improve reset_handling_not_necessary() to return true for your case
There is nothing else.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
Hello Sebastian,
On Mon, Mar 21, 2016 at 01:48:45PM +0100, Sebastian Frias wrote:
> On 03/18/2016 08:12 PM, Uwe Kleine-König wrote:
> > On Fri, Mar 18, 2016 at 04:56:21PM +0100, Sebastian Frias wrote:
> >> On 03/18/2016 01:54 PM, Uwe Kleine-König wrote:
> >>> From a
Hello Sebastian,
On Mon, Mar 21, 2016 at 04:36:47PM +0100, Sebastian Frias wrote:
> On 03/21/2016 02:54 PM, Uwe Kleine-König wrote:
> >> - We'd also need to check that 'gpiod' is not NULL
> >
> > That is the optional part. If gpiod is NULL, you have one of the dev
an the old one. The change however breaks
existing device trees which is not so nice. Given there are no mainline
users this is probably ok though. So:
Acked-by: Uwe Kleine-König <u.kleine-koe...@pengutronix.de>
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
Hello Guenter,
[extending Cc: a bit]
On Sun, May 22, 2016 at 08:41:23AM -0700, Guenter Roeck wrote:
> On 05/22/2016 03:10 AM, Uwe Kleine-König wrote:
> >On Tue, May 17, 2016 at 09:37:11PM -0700, Guenter Roeck wrote:
> >>[9.366256] libphy: ethoc-mdio: probed
> >>[
Hello Guenter,
On Sun, May 22, 2016 at 06:06:24PM -0700, Guenter Roeck wrote:
> On 05/22/2016 11:21 AM, Uwe Kleine-König wrote:
> >On Sun, May 22, 2016 at 08:41:23AM -0700, Guenter Roeck wrote:
> >>I am not exactly in favor of forcing GPIOLIB to be enabled for every
> &
phydev->drv = phydrv;
+
/* Disable the interrupt if the PHY doesn't support it
* but the interrupt is still a valid one
*/
This doesn't make your ethernet work, but at least the driver should
fail in a clean way.
Together with enabling GPIOLIB this should put ethernet i
Hello,
On Thu, May 12, 2016 at 05:16:56PM +0300, Roger Quadros wrote:
> On 12/05/16 17:02, Roger Quadros wrote:
> > On 12/05/16 16:50, Nishanth Menon wrote:
> >> On 05/12/2016 05:00 AM, Uwe Kleine-König wrote:
> >>> The framework only asserts (for now) tha
here is no struct
device yet and this is only created after the phy id is determined. The
phy id is either read from the device tree or must be read from the phy
which might fail if reset is not deasserted.
Principally there is no reason however that the phy_id must be known
before the struct device is created however.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
eady exist which I
missed? Any further ideas/comments?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
Hello Sergei,
On Fri, May 13, 2016 at 12:35:50AM +0300, Sergei Shtylyov wrote:
> On 05/12/2016 09:42 PM, Uwe Kleine-König wrote:
> >>Index: net-next/drivers/net/phy/mdio_device.c
> >>===
> >>---
Hello Sergei,
On Fri, May 13, 2016 at 12:41:47AM +0300, Sergei Shtylyov wrote:
> On 05/12/2016 01:00 PM, Uwe Kleine-König wrote:
>
> >The framework only asserts (for now) that the reset gpio is not active.
> >
> >Signed-off-by: Uwe Kleine-König <u.k
The framework only asserts (for now) that the reset gpio is not active.
Signed-off-by: Uwe Kleine-König <u.kleine-koe...@pengutronix.de>
---
Documentation/devicetree/bindings/net/phy.txt | 3 +++
drivers/net/phy/phy_device.c | 8
2 files changed, 11 insertions(+)
a queue's bit when the queue was
emptied.
Fixes: 4d494cdc92b3 ("net: fec: change data structure to support multiqueue")
Signed-off-by: Uwe Kleine-König <u.kleine-koe...@pengutronix.de>
---
Hello,
I created this patch against net/master. If you think it's to late to
get it into 4.6 an
On Tue, Jul 26, 2016 at 05:36:49PM +0300, Grygorii Strashko wrote:
> On 07/26/2016 03:02 PM, Uwe Kleine-König wrote:
> >Hello,
> >
> >these patches are based on next-20160726. I didn't check yet how latency
> >improves by using these patches, but even if the improvm
Hello,
On Tue, Jul 26, 2016 at 05:25:58PM +0300, Grygorii Strashko wrote:
> On 07/26/2016 03:02 PM, Uwe Kleine-König wrote:
> > Allocating and preparing a dma descriptor doesn't need to happen under
> > the channel's lock. So do this before taking the channel's lock. The onl
Kleine-König <u.kleine-koe...@pengutronix.de>
---
Notes:
Changes since (implicit) v1, sent with Message-Id:
1469217534-6232-1-git-send-email-u.kleine-koe...@pengutronix.de:
- drop cpdma_state_str variable to fix build warning found by the
kbuild test robot
drive
Kleine-König <u.kleine-koe...@pengutronix.de>
---
drivers/net/ethernet/ti/davinci_cpdma.c | 119
drivers/net/ethernet/ti/davinci_cpdma.h | 2 -
drivers/net/ethernet/ti/davinci_emac.c | 96 --
3 files changed, 217 deletions(-)
diff
. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
idered these patches
low-hanging fruits. But when looking again there, I will provide some
numbers.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
Now that ipconfig learned to handle "delayed replies" in the previous
commit, there is no reason any more to delay sending a first request per
device.
Signed-off-by: Uwe Kleine-König <u.kleine-koe...@pengutronix.de>
---
net/ipv4/ipconfig.c | 9 +
1 file changed, 5
slow DHCP servers at all in some
configurations and improves boot speed in general.
The first patch is not really necessary, it only helps decoding debug messages
when there is more than one device.
Best regards
Uwe
Uwe Kleine-König (3):
net: ipconfig: Add device name to debug messages
net: ipconfi
This simplifies understanding what happens when there is more than one
device.
Signed-off-by: Uwe Kleine-König <u.kleine-koe...@pengutronix.de>
---
net/ipv4/ipconfig.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/net/ipv4/ipconfig.c b/net/ipv4/ipconfig.c
accordingly. The relevant
change then is to reset d to ic_dev on a reply to assert that the
followup request goes through the right device.
Signed-off-by: Uwe Kleine-König <u.kleine-koe...@pengutronix.de>
---
net/ipv4/ipconfig.c | 29 ++---
1 file changed, 10 insertions(
Kleine-König <u.kleine-koe...@pengutronix.de>
---
drivers/net/ethernet/ti/davinci_cpdma.c | 38 +
1 file changed, 20 insertions(+), 18 deletions(-)
diff --git a/drivers/net/ethernet/ti/davinci_cpdma.c
b/drivers/net/ethernet/ti/davinci_cpdma.c
index 5ffa04
Hello,
these patches are based on next-20160726. I didn't check yet how latency
improves by using these patches, but even if the improvment is small,
it's still a good idea to have them.
A second pair of eyes checking what I did would be great.
Best regards
Uwe
Uwe Kleine-König (2):
net
The only user of cpdma_control_set (i.e. cpsw_ndo_open) doesn't check
the return code, so it doesn't matter, which error triggers. So the
checks that are independant of the fields protected by ctlr->lock can be
moved out of the critical section.
Signed-off-by: Uwe Kleine-König <u.klei
Hello,
On Wed, Jul 27, 2016 at 05:11:54PM +0300, Grygorii Strashko wrote:
> On 07/27/2016 10:03 AM, Uwe Kleine-König wrote:
> > On Tue, Jul 26, 2016 at 05:36:49PM +0300, Grygorii Strashko wrote:
> >> On 07/26/2016 03:02 PM, Uwe Kleine-König wrote:
> >>> Hello,
>
ed. So delay freeing until after the autoconfig results are
reported.
Fixes: 2647cffb2bc6 ("net: ipconfig: Support using "delayed" DHCP replies")
Reported-by: Geert Uytterhoeven <ge...@linux-m68k.org>
Signed-off-by: Uwe Kleine-König <u.kleine-koe...@pengutronix.de>
.
Signed-off-by: Uwe Kleine-König <u.kleine-koe...@pengutronix.de>
---
drivers/net/ethernet/ti/Kconfig | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/ti/Kconfig b/drivers/net/ethernet/ti/Kconfig
index e7f0b7d95b65..9904d740d528 100644
--- a/drive
8853409aa1720 was only possible because of
2647cffb2bc6fbed163d377390eb7ca552c7c1cb.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
t work,
but instead you can pass the partitioning on the kernel commandline.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
arly in Linux is similar in spirit to doing it
> at the boot loader stage, in that it's neatly separated from the rest
> of the setup.
Sure you can do this. But it won't be accepted mainline for sure.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
en
v3.6-rc1~144^2~7^2~11 = 3143bbb42b3d ("ARM: mxs: convert apx4devkit
board to device tree")
and
v3.10-rc1~63^2~10^2~20 = f231a9fe7f80 ("ARM: dts: mxs: add enet_out
clock to devicetree")
.)
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
dow. Of course some fixes might have to go in, but these hopefully
won't disturb much.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
not be written in .ndo_set_mac_address()/
> sets the mac address unconditionally in fec_restart(...) and ensures
> consistens between fec registers and the network layer.
s/consistens/consistency/
Other than that:
Acked-by: Uwe Kleine-König <u.kleine-koe...@eckelmann.de>
Thanks
Uwe
--
On Thu, Sep 22, 2016 at 08:08:36AM +0200, Uwe Kleine-König wrote:
> Acked-by: Uwe Kleine-König <u.kleine-koe...@eckelmann.de>
huch, cut and paste borkage: This should be
Acked-by: Uwe Kleine-König <u.kleine-koe...@pengutronix.de>
of course.
Uwe
--
Instead of remembering if the page was changed, just compare the current
page to the saved one. This is easier and has the advantage to save a
register write if the page was already restored.
Signed-off-by: Uwe Kleine-König <u...@kleine-koenig.org>
---
drivers/net/phy/marvell.c | 6 ++-
clk_prepare, clk_enable and their counterparts (at least the common clk
ones, but also most others) do check for the clk being NULL anyhow (and
return 0 then), so there is no gain when the caller checks, too.
Signed-off-by: Uwe Kleine-König <u.kleine-koe...@pengutronix.de>
---
drive
Make it possible to generate trace events for mdio read and write accesses.
Signed-off-by: Uwe Kleine-König <u...@kleine-koenig.org>
---
drivers/net/phy/mdio_bus.c | 15 +++
include/trace/events/mdio.h | 40
2 files changed, 55 inse
Make it possible to generate trace events for mdio read and write accesses.
Signed-off-by: Uwe Kleine-König <u...@kleine-koenig.org>
---
Changes since (implicit) v1:
- make use of TRACE_EVENT_CONDITION
Alternatively to this patch the condition could be
+ TP_CONDITION(er
Make it possible to generate trace events for mdio read and write accesses.
Signed-off-by: Uwe Kleine-König <u...@kleine-koenig.org>
---
drivers/net/phy/mdio_bus.c | 11 +++
include/trace/events/mdio.h | 42 ++
2 files changed, 53 inse
On 11/28/2016 02:17 PM, Andrew Lunn wrote:
>> I still wonder (and didn't get an answer back when I asked about this)
>> why a comment is preferred here. For other devices I know it's usual and
>> requested by the maintainers to use:
>>
>> compatible = "exact name", "earlyer device to match
Hello Andrew,
On Mon, Nov 28, 2016 at 12:10:09AM +0100, Andrew Lunn wrote:
> > Try to see it from my perspective: I see that some vf610 device I don't
> > have (found via `git grep marvell,mv88e6` or so) uses
> > "marvell,mv88e6085". I then assume it has that device on board. How
> > would I know
Hello,
On 01/06/2017 11:47 PM, Florian Fainelli wrote:
> On 01/06/2017 02:20 PM, Andrew Lunn wrote:
>>> If one wants to rename an interface, udev rules can be used as usual.
>>
>> Hi Vivien
>>
>> Do you have some examples?
>>
>> A quick look at udevadm info suggests we can use
>>
>>
e current behavior is unchanged, and the optional "label"
> property for user ports has precedence over the enumerated name.
>
> Signed-off-by: Vivien Didelot <vivien.dide...@savoirfairelinux.com>
Acked-by: Uwe Kleine-König <u...@kleine-koenig.org>
Thanks
Uwe
signature.asc
Description: OpenPGP digital signature
is a tag linux-can-fixes-for-4.12-20170404 that contains the
commit id Marc mentioned. (Found using
git ls-remote
git://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can.git | grep ca257b9e2
.)
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
Signed-off-by: Uwe Kleine-König <u.kleine-koe...@pengutronix.de>
---
drivers/net/phy/phy_device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
index 1219eeab69d1..0780e9f9e167 100644
--- a/drivers/net/phy/ph
Hello David,
On Thu, May 25, 2017 at 10:55:11PM +0200, Uwe Kleine-König wrote:
> Instead of falling back to 00:00:00:00:00:00 generate a random address
> if none is provided via platform data or from the the device's register
s/the the/the/
should I resend for this, or can you fixup at
Instead of falling back to 00:00:00:00:00:00 generate a random address
if none is provided via platform data or from the the device's register
space.
Signed-off-by: Uwe Kleine-König <u.kleine-koe...@pengutronix.de>
---
drivers/net/ethernet/8390/ax88796.c | 6 ++
1 file changed, 6 inse
The function ax_init_dev (which is called only from the driver's .probe
function) calls free_irq in the error path without having requested the
irq in the first place. So drop the free_irq call in the error path.
Fixes: 825a2ff1896e ("AX88796 network driver")
Signed-off-by: Uwe Kl
Hello Willem,
On Sun, May 06, 2018 at 06:58:34PM +0200, Willem de Bruijn wrote:
> On Sat, May 5, 2018 at 10:57 AM, Uwe Kleine-König
> <u.kleine-koe...@pengutronix.de> wrote:
> > For testing purposes I created a veth device pair (veth0 veth1), open a
> > socket for each
same symptoms on an arm64 with 4.16 and a dsa switch.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
n hold the whole domain of u16 should be fine.
> + }
> + }
Maybe issue a warning if reading MII_CTRL1000 failed?
> }
>
> return ksz9031_center_flp_timing(phydev);
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
err = of_mdiobus_register(bp->mii_bus, np);
> if (err)
> goto err_out_free_mdiobus;
>
> @@ -606,9 +612,9 @@ static int macb_mii_init(struct macb *bp)
>
> err_out_unregister_bus:
> mdiobus_unregister(bp->mii_bus);
> +err_out_free_mdiobus:
> i
-pointer
exception.
Signed-off-by: Uwe Kleine-König
---
drivers/net/dsa/mv88e6xxx/chip.c | 21 +
1 file changed, 13 insertions(+), 8 deletions(-)
diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
index 437cd6eb4faa..9ef07a06aceb 100644
--- a/drivers
Hello,
On Sat, Jul 21, 2018 at 10:44:09PM -0700, David Miller wrote:
> From: Uwe Kleine-König
> Date: Fri, 20 Jul 2018 11:53:15 +0200
>
> > free_irq() waits until all handlers for this IRQ have completed. As the
> > relevant handler (mv88e6xxx_g1_irq_thread_fn()) take
On Sun, Jul 22, 2018 at 01:04:11PM -0700, David Miller wrote:
> From: Uwe Kleine-König
> Date: Sun, 22 Jul 2018 21:00:35 +0200
>
> > On Sat, Jul 21, 2018 at 10:44:09PM -0700, David Miller wrote:
> >> From: Uwe Kleine-König
> >> Date: Fri, 20 Jul 2018 11:53:15 +0
riptions use.
>
> Suggested-by: Uwe Kleine-König <u.kleine-koe...@pengutronix.de>
> Signed-off-by: Andrew Lunn <and...@lunn.ch>
Thanks Andrew for the respin.
Acked-by: Uwe Kleine-König <u.kleine-koe...@pengutronix.de>
Tested-by: Uwe Kleine-König <u.kleine-koe...@pengutro
Hi Andrew,
On Mon, Mar 26, 2018 at 12:02:37AM +0200, Andrew Lunn wrote:
> On Sun, Mar 25, 2018 at 11:54:24PM +0200, Uwe Kleine-König wrote:
> > On Sun, Mar 25, 2018 at 11:43:14PM +0200, Andrew Lunn wrote:
> > > By calling request_threaded_irq() with the flag IRQF_TRIGGER_FALLING
Signed-off-by: Uwe Kleine-König <u.kleine-koe...@pengutronix.de>
---
drivers/net/dsa/mv88e6xxx/chip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
index e2d3df9908e0..38fe875b9631 100644
--- a/drive
The switch name is emitted in the kernel log, so having the right name
there is nice.
Fixes: 1558727a1c1b ("net: dsa: mv88e6xxx: Add support for ethernet switch
88E6141")
Signed-off-by: Uwe Kleine-König <u.kleine-koe...@pengutronix.de>
---
drivers/net/dsa/mv88e6xxx/chip.c | 2 +-
IRQF_ONESHOT,
> dev_name(chip->dev), chip);
You could join the shortend line with the next here.
Other than that:
Acked-by: Uwe Kleine-König <u.kleine-koe...@pengutronix.de>
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
it a hardware limitation, or
> just missing from the pinctrl driver?
I didn't check yet. This is an Armada 3720, the hardware specification
is available from Marvell. I'll take a look after resending my series
with your Reviewed-by tags.
Best regards
Uwe
--
Pengutronix e.K.
Uwe
Uwe Kleine-König (3):
net: dsa: mv88e6xxx: Fix name of switch 88E6141
net: dsa: mv88e6xxx: Fix typo in a comment
net: dsa: mv88e6xxx: Fix interrupt name for g2 irq
drivers/net/dsa/mv88e6xxx/chip.c| 4 ++--
drivers/net/dsa/mv88e6xxx/global2.c | 2 +-
2 files changed, 3 insertions(+), 3
This changes the respective line in /proc/interrupts from
49: x x mv88e6xxx-g1 7 Edge mv88e6xxx-g1
to
49: x x mv88e6xxx-g1 7 Edge mv88e6xxx-g2
which makes more sense.
Reviewed-by: Andrew Lunn <and...@lunn.ch>
Signed-off-by: Uwe
Reviewed-by: Andrew Lunn <and...@lunn.ch>
Signed-off-by: Uwe Kleine-König <u.kleine-koe...@pengutronix.de>
---
drivers/net/dsa/mv88e6xxx/chip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/
The switch name is emitted in the kernel log, so having the right name
there is nice.
Fixes: 1558727a1c1b ("net: dsa: mv88e6xxx: Add support for ethernet switch
88E6141")
Reviewed-by: Andrew Lunn <and...@lunn.ch>
Signed-off-by: Uwe Kleine-König <u.kleine-koe...@pengutronix.d
This changes the respective line in /proc/interrupts from
49: x x mv88e6xxx-g1 7 Edge mv88e6xxx-g1
to
49: x x mv88e6xxx-g1 7 Edge mv88e6xxx-g2
which makes more sense.
Signed-off-by: Uwe Kleine-König <u.kleine-koe...@pengutronix
use the
gpio controller doesn't support level sensitive irqs. :-|
Looking forward to your comments
Uwe Kleine-Köníg
Uwe Kleine-König (4):
net: dsa: mv88e6xxx: Fix name of switch 88E6141
net: dsa: mv88e6xxx: Fix typo in a comment
net: dsa: mv88e6xxx: Fix interrupt name for g2 irq
net: dsa: mv88
I don't have access to the documentation of the marvell switches, but
with this change the switch driver successfully binds on the
espressobin after its device tree makes use of the switch's irq line.
---
drivers/net/dsa/mv88e6xxx/chip.c | 2 ++
1 file changed, 2 insertions(+)
diff --git
92 matches
Mail list logo
