Re: KASAN: null-ptr-deref Read in rds_ib_get_mr

On 2018/5/12 0:58, Santosh Shilimkar wrote: On 5/11/2018 12:48 AM, Yanjun Zhu wrote: On 2018/5/11 13:20, DaeRyong Jeong wrote: We report the crash: KASAN: null-ptr-deref Read in rds_ib_get_mr Note that this bug is previously reported by syzkaller. https://syzkaller.appspot.com/bug?id

Re: [rds-devel] KASAN: null-ptr-deref Read in rds_ib_get_mr

On 2018/5/11 18:46, Sowmini Varadhan wrote: On (05/11/18 15:48), Yanjun Zhu wrote: diff --git a/net/rds/ib_rdma.c b/net/rds/ib_rdma.c index e678699..2228b50 100644 --- a/net/rds/ib_rdma.c +++ b/net/rds/ib_rdma.c @@ -539,11 +539,17 @@ void rds_ib_flush_mrs(void) void *rds_ib_get_mr(struct

Re: KASAN: null-ptr-deref Read in rds_ib_get_mr

On 2018/5/11 13:20, DaeRyong Jeong wrote: We report the crash: KASAN: null-ptr-deref Read in rds_ib_get_mr Note that this bug is previously reported by syzkaller. https://syzkaller.appspot.com/bug?id=0bb56a5a48b000b52aa2b0d8dd20b1f545214d91 Nonetheless, this bug has not fixed yet, and we hope

Re: [PATCH] mlx4_core: allocate 4KB ICM chunks

On 2018/5/11 7:31, Qing Huang wrote: When a system is under memory presure (high usage with fragments), the original 256KB ICM chunk allocations will likely trigger kernel memory management to enter slow path doing memory compact/migration ops in order to complete high order memory

Re: [PATCHv2 1/1] IB/rxe: avoid double kfree_skb

Add netdev@vger.kernel.org On 2018/4/26 12:41, Zhu Yanjun wrote: When skb is sent, it will pass the following functions in soft roce. rxe_send [rdma_rxe] ip_local_out __ip_local_out ip_output ip_finish_output ip_finish_output2

Re: [PATCH 1/1] IB/rxe: avoid double kfree_skb

kfree_skb in soft roce module again. If I am wrong, please correct me. Zhu Yanjun On 2018/4/24 16:34, Yanjun Zhu wrote: Hi, all rxe_send     ip_local_out         __ip_local_out             nf_hook_slow In the above call process, nf_hook_slow drops and frees skb, then -EPERM is returned when

Re: [PATCH 1/1] IB/rxe: avoid double kfree_skb

oce, kfree_skb should not be called in this module. I will make further investigations about other error handler after ip_local_out. If I am wrong, please correct me. Any reply is appreciated. Zhu Yanjun On 2018/4/20 13:46, Yanjun Zhu wrote: On 2018/4/20 10:19, Doug Ledford wrote: On Thu, 2018-04

Re: [PATCH 1/1] IB/rxe: avoid double kfree_skb

On 2018/4/20 10:19, Doug Ledford wrote: On Thu, 2018-04-19 at 10:01 -0400, Zhu Yanjun wrote: When skb is dropped by iptables rules, the skb is freed at the same time -EPERM is returned. So in softroce, it is not necessary to free skb again. Or else, crash will occur. The steps to reproduce:

Re: [PATCH 1/1] net/mlx4_core: avoid resetting HCA when accessing an offline device

On 2018/4/17 23:37, Tariq Toukan wrote: On 16/04/2018 4:02 AM, Zhu Yanjun wrote: While a faulty cable is used or HCA firmware error, HCA device will be offline. When the driver is accessing this offline device, the following call trace will pop out. " ...    [] dump_stack+0x63/0x81    []

Re: [PATCH next-queue 2/2] ixgbe: add unlikely notes to tx fastpath expressions

On 2018/1/9 6:47, Shannon Nelson wrote: Add unlikely() to a few error checking expressions in the Tx offload handling. Suggested-by: Yanjun Zhu <yanjun@oracle.com> Hi, I am fine with this patch. I have a question. The ipsec feature is supported in ixgbevf? Thanks a lot. Zhu

Re: [PATCH v3 next-queue 08/10] ixgbe: process the Tx ipsec offload

On 2017/12/20 8:00, Shannon Nelson wrote: If the skb has a security association referenced in the skb, then set up the Tx descriptor with the ipsec offload bits. While we're here, we fix an oddly named field in the context descriptor struct. v3: added ifdef CONFIG_XFRM_OFFLOAD check around

Re: [PATCH v3 next-queue 00/10] ixgbe: Add ipsec offload

On 2017/12/21 14:39, Yanjun Zhu wrote: On 2017/12/20 7:59, Shannon Nelson wrote: This is an implementation of the ipsec hardware offload feature for the ixgbe driver and Intel's 10Gbe series NICs: x540, x550, 82599. Hi, Nelson I notice that the ipsec feature is based on x540, x550, 82599

Re: [PATCH v3 next-queue 00/10] ixgbe: Add ipsec offload

On 2017/12/20 7:59, Shannon Nelson wrote: This is an implementation of the ipsec hardware offload feature for the ixgbe driver and Intel's 10Gbe series NICs: x540, x550, 82599. Hi, Nelson I notice that the ipsec feature is based on x540, x550, 82599.  But this ixgbe driver will also work

Re: [PATCH net-next 1/1] forcedeth: remove unnecessary variable

On 2017/12/8 3:07, David Miller wrote: From: Zhu Yanjun Date: Wed, 6 Dec 2017 23:15:15 -0500 Since both tx_ring and first_tx are the head of tx ring, it not necessary to use two variables. So first_tx is removed. These are not variables, they are structure members.

Re: [PATCH 1/1] bnx2x: fix slowpath null crash

On 2017/11/8 11:27, Elior, Ariel wrote: When "NETDEV WATCHDOG: em4 (bnx2x): transmit queue 2 timed out" occurs, BNX2X_SP_RTNL_TX_TIMEOUT is set. In the function bnx2x_sp_rtnl_task, bnx2x_nic_unload and bnx2x_nic_load are executed to shutdown and open NIC. In the function bnx2x_nic_load,

Re: [PATCH 1/1] bnx2x: fix slowpath null crash

Please ignore this mail. Zhu Yanjun On 2017/11/8 9:58, root wrote: From: Zhu Yanjun When "NETDEV WATCHDOG: em4 (bnx2x): transmit queue 2 timed out" occurs, BNX2X_SP_RTNL_TX_TIMEOUT is set. In the function bnx2x_sp_rtnl_task, bnx2x_nic_unload and bnx2x_nic_load are

Re: [PATCH 1/1] forcedeth: remove tx_stop variable

Hi, all After this patch is applied, the TCP && UDP tests are made. The TCP bandwidth is 939 Mbits/sec. The UDP bandwidth is 806 Mbits/sec. So I think this patch can work well. host1 <-> host2 host1: forcedeth NIC IP: 1.1.1.107 iperf -s host2: forcedeth NIC IP:1.1.1.105 iperf -c

Re: [PATCH 1/5] rds: tcp: release the created connection

On 2017/3/27 15:37, Sowmini Varadhan wrote: On (03/27/17 03:06), Zhu Yanjun wrote: Date: Mon, 27 Mar 2017 03:06:26 -0400 From: Zhu Yanjun To: yanjun@oracle.com, santosh.shilim...@oracle.com, netdev@vger.kernel.org, linux-r...@vger.kernel.org,

Re: [PATCHv3 1/4] rds: ib: drop unnecessary rdma_reject

On 2017/3/13 14:32, Leon Romanovsky wrote: On Mon, Mar 13, 2017 at 01:43:45AM -0400, Zhu Yanjun wrote: When rdma_accept fails, rdma_reject is called in it. As such, it is not necessary to execute rdma_reject again. It is not always correct, according to the code, rdma_accept can fail and

Re: [PATCHv2 1/4] rds: ib: drop unnecessary rdma_reject

On 2017/3/13 3:43, santosh.shilim...@oracle.com wrote: On 3/12/17 12:33 PM, Leon Romanovsky wrote: On Sun, Mar 12, 2017 at 04:07:55AM -0400, Zhu Yanjun wrote: When rdma_accept fails, rdma_reject is called in it. As such, it is not necessary to execute rdma_reject again. Cc: Joe Jin

Re: [PATCH 2/5] rds: ib: replace spin_lock_irq with spin_lock_irqsave

Sorry. I have no test case to show some issue. But from Linux Kernel Development Second Edition by Robert Love. Use spin_lock_irq is dangerous since spin_unlock_irq unconditionally enables interrupts. We can assume the following scenario: --->the interrupt is disabled.

Re: [PATCH 1/1] ixgbe: add the external ixgbe fiber transceiver status

On 2017/2/10 3:08, Tantilov, Emil S wrote: -Original Message- From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On Behalf Of Zhu Yanjun Sent: Wednesday, February 08, 2017 7:03 PM To: Kirsher, Jeffrey T ; broo...@kernel.org;

[PATCHv2 1/1] r8169: fix the typo in the comment

From: Zhu Yanjun >From the realtek data sheet, the PID0 should be bit 0. Signed-off-by: Zhu Yanjun --- Change from v1 to v2: change the commit header. drivers/net/ethernet/realtek/r8169.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH 1/1] r8169: fix the typo

Hi, Please comment on this patch. Zhu Yanjun On 2016/12/29 11:11, Zhu Yanjun wrote: >From the realtek data sheet, the PID0 should be bit 0. Signed-off-by: Zhu Yanjun --- drivers/net/ethernet/realtek/r8169.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)