Re: [PATCH bpf-next v5 5/5] error-injection: Support fault injection framework

2018-01-13 Thread Akinobu Mita
2018-01-13 2:56 GMT+09:00 Masami Hiramatsu : > Support in-kernel fault-injection framework via debugfs. > This allows you to inject a conditional error to specified > function using debugfs interfaces. > > Here is the result of test script described in > Documentation/fault-injection/fault-injectio

Re: [PATCH bpf-next v4 5/5] error-injection: Support fault injection framework

2018-01-11 Thread Akinobu Mita
2018-01-12 1:15 GMT+09:00 Masami Hiramatsu : > On Thu, 11 Jan 2018 23:44:57 +0900 > Akinobu Mita wrote: > >> 2018-01-11 9:51 GMT+09:00 Masami Hiramatsu : >> > Support in-kernel fault-injection framework via debugfs. >> > This allows you to inject a conditional

Re: [PATCH bpf-next v4 5/5] error-injection: Support fault injection framework

2018-01-11 Thread Akinobu Mita
2018-01-11 9:51 GMT+09:00 Masami Hiramatsu : > Support in-kernel fault-injection framework via debugfs. > This allows you to inject a conditional error to specified > function using debugfs interfaces. > > Here is the result of test script described in > Documentation/fault-injection/fault-injectio

Re: [PATCH -next v2 3/4] net: w5100: increase TX timeout period

2016-05-16 Thread Akinobu Mita
2016-05-16 18:33 GMT+09:00 David Laight : > From: netdev-ow...@vger.kernel.org Akinobu Mita >> Sent: 14 May 2016 06:56 >> This increases TX timeout period from one second to 5 seconds which is >> the default value if the driver doesn't explicitly set >> net_devic

[PATCH -next v2 2/4] net: w5100: fix MAC filtering for W5500

2016-05-13 Thread Akinobu Mita
W5500 has different bit position for MAC filter in Socket n mode register from W5100 and W5200. Signed-off-by: Akinobu Mita Cc: Mike Sinkovsky Cc: David S. Miller --- * No changes from v1 drivers/net/ethernet/wiznet/w5100.c | 17 + 1 file changed, 13 insertions(+), 4

[PATCH -next v2 4/4] net: w5100-spi: add support to specify MAC address by device tree

2016-05-13 Thread Akinobu Mita
This adds support to specify the MAC address by 'mac-address' or 'local-mac-address' properties in the device tree. These are common properties for the Ethernet controller. Signed-off-by: Akinobu Mita Cc: Mike Sinkovsky Cc: David S. Miller --- * No changes from v1

[PATCH -next v2 3/4] net: w5100: increase TX timeout period

2016-05-13 Thread Akinobu Mita
transfer. If the packet is transmitted while RX packets are being received at a very high rate, the TX transmittion work in the workqueue is delayed and the watchdog timer is expired. Signed-off-by: Akinobu Mita Cc: Mike Sinkovsky Cc: David S. Miller --- * v2 - Remove the watchdong_timeo assi

[PATCH -next v2 0/4] net: w5100: collection of small changes

2016-05-13 Thread Akinobu Mita
This patch series is the collection of relatively small changes for w5100 driver which includes a cleanup with no functional change, two fixes, and adding a functionality. * Changes from v1 - Remove the watchdong_timeo assignment to set default tx timeout, suggested by David Miller. Akinobu

[PATCH -next v2 1/4] net: w5100: remove unused is_w5200()

2016-05-13 Thread Akinobu Mita
The is_w5200() function is not used anymore by the commit which adds the W5500 support. Signed-off-by: Akinobu Mita Cc: Mike Sinkovsky Cc: David S. Miller --- * No changes from v1 drivers/net/ethernet/wiznet/w5100.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/net/ethernet

Re: [PATCH -next 3/4] net: w5100: increase TX timeout period

2016-05-12 Thread Akinobu Mita
2016-05-12 8:49 GMT+09:00 David Miller : > From: Akinobu Mita > Date: Wed, 11 May 2016 15:30:26 +0900 > >> This increases TX timeout period from one second to 5 seconds which is >> default value defined in net/sched/sch_generic.c. >> >> The one second timeou

[PATCH -next 2/4] net: w5100: fix MAC filtering for W5500

2016-05-10 Thread Akinobu Mita
W5500 has different bit position for MAC filter in Socket n mode register from W5100 and W5200. Signed-off-by: Akinobu Mita Cc: Mike Sinkovsky Cc: David S. Miller --- drivers/net/ethernet/wiznet/w5100.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a

[PATCH -next 4/4] net: w5100-spi: add support to specify MAC address by device tree

2016-05-10 Thread Akinobu Mita
This adds support to specify the MAC address by 'mac-address' or 'local-mac-address' properties in the device tree. These are common properties for the Ethernet controller. Signed-off-by: Akinobu Mita Cc: Mike Sinkovsky Cc: David S. Miller --- drivers/net/ethernet/wi

[PATCH -next 3/4] net: w5100: increase TX timeout period

2016-05-10 Thread Akinobu Mita
while RX packets are being received at a very high rate, the TX transmittion work in the workqueue is delayed and the watchdog timer is expired. Signed-off-by: Akinobu Mita Cc: Mike Sinkovsky Cc: David S. Miller --- drivers/net/ethernet/wiznet/w5100.c | 2 +- 1 file changed, 1 insertion(

[PATCH -next 0/4] net: w5100: collection of small changes

2016-05-10 Thread Akinobu Mita
This patch series for w5100 driver includes a cleanup with no functional change, two fixes, and adding a functionality. Each change is relatively small. Akinobu Mita (4): net: w5100: remove unused is_w5200() net: w5100: fix MAC filtering for W5500 net: w5100: increase TX timeout period

[PATCH -next 1/4] net: w5100: remove unused is_w5200()

2016-05-10 Thread Akinobu Mita
The is_w5200() function is not used anymore by the commit which adds the W5500 support. Signed-off-by: Akinobu Mita Cc: Mike Sinkovsky Cc: David S. Miller --- drivers/net/ethernet/wiznet/w5100.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/net/ethernet/wiznet/w5100.c b

[PATCH -next] net: w5100: support W5500

2016-04-26 Thread Akinobu Mita
. Signed-off-by: Akinobu Mita Cc: Mike Sinkovsky Cc: David S. Miller --- drivers/net/ethernet/wiznet/Kconfig | 2 +- drivers/net/ethernet/wiznet/w5100-spi.c | 192 +++-- drivers/net/ethernet/wiznet/w5100.c | 243 +++- drivers/net/ethernet

[PATCH v3 3/5] net: w5100: enable to support sleepable register access interface

2016-04-14 Thread Akinobu Mita
register to be automatically cleared because the latency of the register access with SPI transfer can be interfered by other contexts. Signed-off-by: Akinobu Mita Cc: Mike Sinkovsky Cc: David S. Miller --- * No changes from v2 drivers/net/ethernet/wiznet/w5100.c | 190

[PATCH v3 0/5] net: w5100: add support W5100/W5200 for SPI interface

2016-04-14 Thread Akinobu Mita
ingle pointer instead of SKB queue, spotted by David S. Miller - Correct timeout period in w5100_command - Use spi_write_then_read instead of spi_write which needs DMA-safe buffer - Support W5200 Akinobu Mita (5): net: w5100: move mmiowb into register access callbacks net: w5100: add ability to su

[PATCH v3 5/5] net: w5100: support W5200

2016-04-14 Thread Akinobu Mita
and w5100-spi drivers. Signed-off-by: Akinobu Mita Cc: Mike Sinkovsky Cc: David S. Miller --- * v3 - Allocate w5200 ops specific data structure to put DMA-safe buffer - Add missing chip_id assignment for w5100_*_ops drivers/net/ethernet/wiznet/Kconfig | 2 +- drivers/net/ethernet/wiznet

[PATCH v3 1/5] net: w5100: move mmiowb into register access callbacks

2016-04-14 Thread Akinobu Mita
Instead of sprinkle mmiowb over the driver code, move it into primary register write callbacks. (w5100_write, w5100_write16, w5100_writebuf) This is a preparation for supporting SPI interface which doesn't use MMIO for accessing w5100 registers. Signed-off-by: Akinobu Mita Cc: Mike Sink

[PATCH v3 2/5] net: w5100: add ability to support other bus interface

2016-04-14 Thread Akinobu Mita
driver can use w5100 driver as core module. Signed-off-by: Akinobu Mita Cc: Mike Sinkovsky Cc: David S. Miller --- * v3 - Add comment for reg_lock - Add ability to allocate ops specific data structure drivers/net/ethernet/wiznet/w5100.c | 604 drivers/net

[PATCH v3 4/5] net: w5100: support SPI interface mode

2016-04-14 Thread Akinobu Mita
This adds new w5100-spi driver which shares the bus interface independent code with existing w5100 driver. Signed-off-by: Akinobu Mita Cc: Mike Sinkovsky Cc: David S. Miller --- * No changes from v2 drivers/net/ethernet/wiznet/Kconfig | 14 drivers/net/ethernet/wiznet/Makefile

Re: [PATCH v2 1/5] net: w5100: move mmiowb into register access callbacks

2016-04-08 Thread Akinobu Mita
2016-04-08 1:29 GMT+09:00 David Miller : > > Where is your "[PATCH v2 0/5] ..." header posting explaing what this series > is doing, at a high level, how it is doing that, and why it is doing it > that way? > > This is mandator for patch series submissions. I see. I'll surely include the explanat

[PATCH v2 2/5] net: w5100: add ability to support other bus interface

2016-04-07 Thread Akinobu Mita
driver can use w5100 driver as core module. Signed-off-by: Akinobu Mita Cc: Mike Sinkovsky Cc: David S. Miller --- * No changes from v1 drivers/net/ethernet/wiznet/w5100.c | 588 drivers/net/ethernet/wiznet/w5100.h | 26 ++ 2 files changed, 415 insertions

[PATCH v2 1/5] net: w5100: move mmiowb into register access callbacks

2016-04-07 Thread Akinobu Mita
Instead of sprinkle mmiowb over the driver code, move it into primary register write callbacks. (w5100_write, w5100_write16, w5100_writebuf) This is a preparation for supporting SPI interface which doesn't use MMIO for accessing w5100 registers. Signed-off-by: Akinobu Mita Cc: Mike Sink

[PATCH v2 4/5] net: w5100: support SPI interface mode

2016-04-07 Thread Akinobu Mita
This adds new w5100-spi driver which shares the bus interface independent code with existing w5100 driver. Signed-off-by: Akinobu Mita Cc: Mike Sinkovsky Cc: David S. Miller --- * v2 - Use spi_write_then_read instead of spi_write which needs DMA-safe buffer drivers/net/ethernet/wiznet

[PATCH v2 3/5] net: w5100: enable to support sleepable register access interface

2016-04-07 Thread Akinobu Mita
register to be automatically cleared because the latency of the register access with SPI transfer can be interfered by other contexts. Signed-off-by: Akinobu Mita Cc: Mike Sinkovsky Cc: David S. Miller --- * v2 - Use a plain single pointer instead of SKB queue, spotted by David S. Miller

[PATCH v2 5/5] net: w5100: support W5200

2016-04-07 Thread Akinobu Mita
and w5100-spi drivers. Signed-off-by: Akinobu Mita Cc: Mike Sinkovsky Cc: David S. Miller --- * New patch from this version drivers/net/ethernet/wiznet/Kconfig | 2 +- drivers/net/ethernet/wiznet/w5100-spi.c | 115 +++- drivers/net/ethernet/wiznet/w5100.c | 153

Re: [PATCH 3/4] net: w5100: enable to support sleepable register access interface

2016-04-01 Thread Akinobu Mita
2016-04-01 4:30 GMT+09:00 David Miller : > From: Akinobu Mita > Date: Thu, 31 Mar 2016 01:38:39 +0900 > >> + struct sk_buff_head tx_queue; > > The way the queueing works in this driver is that it is only possible > to have one SKB being transmitted at one time. > &

[PATCH 1/4] net: w5100: move mmiowb into register access callbacks

2016-03-30 Thread Akinobu Mita
Instead of sprinkle mmiowb over the driver code, move it into primary register write callbacks. (w5100_write, w5100_write16, w5100_writebuf) This is a preparation for supporting SPI interface which doesn't use MMIO for accessing w5100 registers. Signed-off-by: Akinobu Mita Cc: Mike Sink

[PATCH 3/4] net: w5100: enable to support sleepable register access interface

2016-03-30 Thread Akinobu Mita
SPI transfer routines are callable only from contexts that can sleep. This adds ability to tell the core driver that the interface mode cannot access w5100 register on atomic contexts. In this case, workqueue and threaded irq are required. Signed-off-by: Akinobu Mita Cc: Mike Sinkovsky Cc

[PATCH 4/4] net: w5100: support SPI interface mode

2016-03-30 Thread Akinobu Mita
This adds new w5100-spi driver which shares the bus interface independent code with existing w5100 driver. Signed-off-by: Akinobu Mita Cc: Mike Sinkovsky Cc: David S. Miller --- drivers/net/ethernet/wiznet/Kconfig | 14 drivers/net/ethernet/wiznet/Makefile| 1 + drivers/net

[PATCH 2/4] net: w5100: add ability to support other bus interface

2016-03-30 Thread Akinobu Mita
driver can use w5100 driver as core module. Signed-off-by: Akinobu Mita Cc: Mike Sinkovsky Cc: David S. Miller --- drivers/net/ethernet/wiznet/w5100.c | 588 drivers/net/ethernet/wiznet/w5100.h | 26 ++ 2 files changed, 415 insertions(+), 199 deletions

Re: [PATCH] net: add support for netdev notifier error injection

2015-11-30 Thread Akinobu Mita
2015-11-28 21:45 GMT+09:00 Nikolay Aleksandrov : > From: Nikolay Aleksandrov > > This module allows to insert errors in some of netdevice's notifier > events. All network drivers use these notifiers to signal various events > and to check if they are allowed, e.g. PRECHANGEMTU and CHANGEMTU > afte

[PATCH] sky2: check pci_register_driver() error

2007-12-15 Thread Akinobu Mita
Check pci_register_driver() error and clean up debugfs entries if error happened. Cc: Stephen Hemminger <[EMAIL PROTECTED]> Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]> --- drivers/net/sky2.c |9 - 1 file changed, 8 insertions(+), 1 deletion(-) Index: 2.6-git/driver

[PATCH] tun: use iov_length()

2007-11-17 Thread Akinobu Mita
Use iov_length() instead of tun's homemade iov_total(). Cc: Maxim Krasnyansky <[EMAIL PROTECTED]> Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]> --- drivers/net/tun.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) Index: 2.6-mm/

Re: [PATCH 1/2] eHEA: Capability flag for DLPAR support

2007-07-04 Thread Akinobu Mita
2007/7/4, Jan-Bernd Themann <[EMAIL PROTECTED]>: diff --git a/drivers/net/ehea/ehea_main.c b/drivers/net/ehea/ehea_main.c index bdb5241..f8c0908 100644 --- a/drivers/net/ehea/ehea_main.c +++ b/drivers/net/ehea/ehea_main.c @@ -2923,6 +2923,15 @@ static int check_module_parm(void) return r

[PATCH] irlan: handle out of memory errors

2006-12-19 Thread Akinobu Mita
This patch checks return values: - irlmp_register_client() - irlmp_register_service() - irlan_open() Cc: Samuel Ortiz <[EMAIL PROTECTED]> Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]> --- net/irda/irlan/irlan_common.c | 23 --- 1 file changed, 20 inse

[PATCH] irda: handle out of memory errors

2006-12-19 Thread Akinobu Mita
This patch checks return value of memory allocation functions for irda subsystem and fixes memory leaks in error cases. Cc: Samuel Ortiz <[EMAIL PROTECTED]> Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]> --- net/irda/irias_object.c | 40

[PATCH] ipcomp: fix crypto_alloc_comp() error check

2006-11-26 Thread Akinobu Mita
The return value of crypto_alloc_comp() should be checked by IS_ERR(). Cc: David Miller <[EMAIL PROTECTED]> Cc: Hideaki YOSHIFUJI <[EMAIL PROTECTED]> Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]> --- net/ipv4/ipcomp.c |2 +- net/ipv6/ipcomp6.c |2 +- 2 files cha

[PATCH] sctp: fix crypto_alloc_hash() error check

2006-11-26 Thread Akinobu Mita
The return value of crypto_alloc_hash() should be checked by IS_ERR(). Cc: David Miller <[EMAIL PROTECTED]> Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]> --- net/sctp/socket.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: work-fault-inject/net/s

Re: [PATCH 4/6] net: use bitrev8

2006-10-19 Thread Akinobu Mita
On Thu, Oct 19, 2006 at 01:39:51PM -0700, Andrew Morton wrote: > A bunch of drivers. > > > === > > --- work-fault-inject.orig/drivers/net/Kconfig > > +++ work-fault-inject/drivers/net/Kconfig > > @@ -2500,6 +2500,7 @@ config DEFXX >

[PATCH 4/6] net: use bitrev8

2006-10-18 Thread Akinobu Mita
Use bitrev8 for bmac, mace, macmace, macsonic, and skfp drivers. Cc: Jeff Garzik <[EMAIL PROTECTED]> Cc: Paul Mackerras <[EMAIL PROTECTED]> Cc: Mirko Lindner <[EMAIL PROTECTED]> Cc: Thomas Bogendoerfer <[EMAIL PROTECTED]> Signed-off-by: Akinobu Mita <[EMAIL PROTEC

[PATCH] rate limiting for socket allocation failure messages

2006-08-31 Thread Akinobu Mita
(Resending due to local mail server trouble) This patch limits the warning messages when socket allocation failures happen. It happens under memory pressure. Cc: David Miller <[EMAIL PROTECTED]> Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]> net/socket.c |3 ++- 1 fil

call panic if nl_table allocation fails

2006-08-23 Thread Akinobu Mita
This patch makes crash happen if initialization of nl_table fails in initcalls. It is better than getting use after free crash later. Cc: Patrick McHardy <[EMAIL PROTECTED]> Cc: David Miller <[EMAIL PROTECTED]> Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]> Index: work-fail

[PATCH] fix use after free in netlink_kernel_create()

2006-08-13 Thread Akinobu Mita
This patch invalidates nl_table by setting NULL when netlink initialization failed. Otherwise netlink_kernel_create() would access nl_table which has already been freed. CC: "David S. Miller" <[EMAIL PROTECTED]> Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]> net/netli

Re: sky2 prints many "hw tcp v4 csum failed"

2005-11-17 Thread Akinobu Mita
On Thu, Nov 17, 2005 at 07:26:22AM -0800, Stephen Hemminger wrote: > On Thu, 17 Nov 2005 20:14:48 +0900 > Akinobu Mita <[EMAIL PROTECTED]> wrote: > > > I'm using sky2 driver on 2.6.14-mm2. > > It works fine, but I got this message repeatedly. > > > > h

sky2 prints many "hw tcp v4 csum failed"

2005-11-17 Thread Akinobu Mita
I'm using sky2 driver on 2.6.14-mm2. It works fine, but I got this message repeatedly. hw tcp v4 csum failed I can suppress these messages by # ethtool -K eth0 tx off rx off And, These messages cannot be seen with sk98lin v8.16.2.3 (on 2.6.14-mm2 with a little changes to build it) Motherboard: