Re: [PATCH 3/9] powerpc32: checksum_wrappers_64 becomes checksum_wrappers

Hi Scott, > I wonder why it was 64-bit specific in the first place. I think it was part of a series where I added my 64bit assembly checksum routines, and I didn't step back and think that the wrapper code would be useful on 32 bit. Anton -- To unsubscribe from this list: send the line

ehea work queues

Hi, I booted 2.6.23-rc8 and noticed that ehea loves its workqueues: # ps aux|grep ehea root 3266 0.0 0.000 ?S 11:02 0:00 [ehea_driver_wq/] root 3268 0.0 0.000 ?S 11:02 0:00 [ehea_driver_wq/] root 3269 0.0 0.000 ?S 11:02 0:00

Re: select(0, ..) is valid ?

Hi Hugh, It's interesting that compat_core_sys_select() shows this kmalloc(0) failure but core_sys_select() does not. That's because core_sys_select() avoids kmalloc by using a buffer on the stack for small allocations (and 0 sure is small). Shouldn't compat_core_sys_select() do just the

Fix return code in pci-skeleton.c

We assign the return value of register_netdev to i, but return rc later on. Fix it. Signed-off-by: Anton Blanchard [EMAIL PROTECTED] --- diff --git a/drivers/net/pci-skeleton.c b/drivers/net/pci-skeleton.c index 00ca0fd..6ca4e4f 100644 --- a/drivers/net/pci-skeleton.c +++ b/drivers/net/pci

Re: [PATCH 2.6.19-rc3 2/2] ehea: 64K page support fix

Hi, +#ifdef CONFIG_PPC_64K_PAGES + /* To support 64k pages we must round to 64k page boundary */ + epas-kernel.addr = + ioremap((paddr_kernel 0x), PAGE_SIZE) + + (paddr_kernel 0x); +#else epas-kernel.addr = ioremap(paddr_kernel,

Re: [2.6.19 PATCH 2/7] ehea: pHYP interface

Hi, I asked SO to recount arguments and we've come to a conclusion that there're in fact 19 args not 18 as the name suggests. 19 args is I-N-S-A-N-E. It will be partially cleaned up by: http://ozlabs.org/pipermail/linuxppc-dev/2006-July/024556.html However it doesnt fix the fact someone

Re: [PATCH 1/6] ehea: interface to network stack

Is a conditional cheaper than a divide? In case of a misprediction I would assume it to be significantly slower and I don't know the ratio of mispredictions for this branch. A quick scan of the web shows 40 cycles for athlon64 idiv, and its similarly slow on many other cpus. Even assuming

Re: [PATCH 3/6] ehea: queue management

Hi, I agree, stubbs were removed. Thanks. What is going to be done about the debug infrastructure in the ehea driver? The entry and exit traces really need to go, and any other debug you think is important to users needs to go into debugfs or something similar. I see a similar issue in the

Re: [PATCH 1/6] ehea: interface to network stack

Hi, --- linux-2.6.18-rc4-orig/drivers/net/ehea/ehea_main.c1969-12-31 +#define DEB_PREFIX main Doesnt appear to be used. +static struct net_device_stats *ehea_get_stats(struct net_device *dev) ... + cb2 = kzalloc(H_CB_ALIGNMENT, GFP_KERNEL); I cant see where this gets freed.

Re: [PATCH 2/6] ehea: pHYP interface

Hi, --- linux-2.6.18-rc4-orig/drivers/net/ehea/ehea_phyp.c1969-12-31 16:00:00.0 -0800 +u64 ehea_h_alloc_resource_eq(const u64 hcp_adapter_handle, ... +u64 hipz_h_reregister_pmr(const u64 adapter_handle, ... +static inline int hcp_galpas_ctor(struct h_galpas *galpas, Be

Re: [PATCH 4/6] ehea: header files

Hi, drivers/net/ehea/ehea.h| 452 +#define EHEA_DRIVER_NAME IBM eHEA You are using this for ethtool get_drvinfo. Im not sure if it should match the module name, and I worry about having a space in the name. Any ideas on what we should be doing here? +#define NET_IP_ALIGN 0

Re: [PATCH 3/6] ehea: queue management

Hi, --- linux-2.6.18-rc4-orig/drivers/net/ehea/ehea_ethtool.c 1969-12-31 +static void netdev_get_pauseparam(struct net_device *dev, + struct ethtool_pauseparam *pauseparam) +{ + printk(get pauseparam\n); +} There are a number of stubbed out ethtool

Re: [PATCH 4/6] ehea: header files

--- linux-2.6.18-rc4-orig/drivers/net/ehea/ehea.h 1969-12-31 +extern void exit(int); Should be able to remove that prototype :) Anton - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: e100: checksum mismatch on 82551ER rev10

Hi, If the EEPROM has a broken checksum, the user should have an option that allows him to try and use the device anyways, end of story. Ive come across this problem a number of times on e1000 chips (to be clear it was vendor programming issues). The driver has the option to read and write

Re: [PATCH 38 of 39] IB/ipath - More changes to support InfiniPath on PowerPC 970 systems

Hi, Please fix the generic code if it doesn't provide the facility you need at the moment. Don't shoe horn it into your driver just to make up for that. Ive had 3 drivers asking for write combining recently so I agree this is a good idea. How about ioremap_wc as suggested by Willy:

Re: [PATCH 3/4] myri10ge - Driver core

Hi, We didn't get any ppc64 with PCI-E to run Linux so far. What performance drop should we expect with our current code ? We have seen 20% improvement on ppc64 running some networking workloads when forcing 128 byte alignment (instead of 16 byte alignment). DMA writes have to get cacheline

[PATCH] Allow skb headroom to be overridden

to start on a cacheline boundary, so we increase that headroom to one cacheline. Signed-off-by: Anton Blanchard [EMAIL PROTECTED] --- Index: kernel/include/linux/skbuff.h === --- kernel.orig/include/linux/skbuff.h 2006-03-22 17:53

Re: [PATCH 4/4] TCP Cubic use Newton-Raphson

Hi Stephen, Replace cube root algorithim with a faster version using Newton-Raphson. Surprisingly, doing the scaled div64_64 is faster than a true 64 bit division on 64 bit CPU's. Interesting, what cpu was this on? Was there much difference between the two methods? Anton - To unsubscribe

Re: [PATCH netdev-2.6 1/3] ixgb: TSO fixes

Hi, TSO fixes - fix rare early completion when using TSO - extra descriptor for the sentinel descriptor Is this the same bug as e1000? The extra DMA descriptor is going to be costly, especially on 10Gb. Would the e1000_unmap_and_free_tx_resource trick used in e1000 work instead? (Actually I

Re: [PATCH] disable DEBUG in ibmveth

Any chance we can get this patch in? Anton At the moment ibmveth has DEBUG enabled which is rather verbose. Disable it. Signed-off-by: Anton Blanchard [EMAIL PROTECTED] --- Index: foobar2/drivers/net/ibmveth.c === --- foobar2

Align DMA buffers to a cacheline

for various optimisations, unfortunately this means all receive packets start 16 bytes into a cacheline. By allowing this to be overridden (via the NET_SKB_PAD define), we can define the headroom to be a cacheline and maintain cacheline alignment. Signed-off-by: Anton Blanchard [EMAIL PROTECTED

ethtool phys_id sleeps for long periods with rtnl_lock taken

Hi, We had a bad ethernet card that wouldnt initialise, so I figured we could blink all other ethernets in the box to identify the bad one. I was surprised to find we could only blink one card at a time, the other ethtool processes were all blocked in D state. It turns out the ethtool ioctl

Re: [PATCH] disable DEBUG in ibmveth

The trailing 1 will cause a warning. Good point. -- At the moment ibmveth has DEBUG enabled which is rather verbose. Disable it. Signed-off-by: Anton Blanchard [EMAIL PROTECTED] Index: foobar2/drivers/net/ibmveth.c