RE: [PATCH 1/2] net: phy: Add error checks in the driver

Hi Andrew, Thanks for the review... > > - mdiobus_write(phydev->mdio.bus, priv->addr, > XILINX_GMII2RGMII_REG, val); > > + err = mdiobus_write(phydev->mdio.bus, priv->addr, > XILINX_GMII2RGMII_REG, > > + val); > > + if (err < 0) > > + return err; > >

RE: [PATCH] net: macb: add phy-handle support for the macb

Hi Andrew, Thanks for the review... > > > Agree with you my intention is if there is a MDIO bus on the > > device-tree The MAC driver should create PHY/MDIO devices using > of_mdiobus_register(). > > What you suggest is better, and is similar to what other drivers use. > > In order to

RE: [PATCH v6 3/3] net: phy: Add gmiitorgmii converter support

Hi Andrew, Thanks for the review... > > > +static int xgmiitorgmii_read_status(struct phy_device *phydev) { > > + struct gmii2rgmii *priv = phydev->priv; > > + u16 val = 0; > > + > > + priv->phy_drv->read_status(phydev); > > This can return an error, in which case phydev->speed

RE: [PATCH] net: phy: Update copyright info

Hi Andrew > > On Tue, Aug 16, 2016 at 11:58:29AM +0530, Kedareswara rao Appana wrote: > > For implementing this driver most of the inputs is provided by Andrew > > Lunn. > > > > Updating the driver with Andrew Copy right. > > > > Signed-off-by: Kedareswara rao Appana > >

RE: [PATCH] net: macb: add phy-handle support for the macb

Hi David Miller, Thanks for the review... > > From: Kedareswara rao Appana > Date: Sat, 13 Aug 2016 15:31:49 +0530 > > > @@ -445,7 +445,13 @@ static int macb_mii_init(struct macb *bp) > > dev_set_drvdata(>dev->dev, bp->mii_bus); > > > > np =

RE: [RFC PATCH v5 3/3] net: phy: Add gmiitorgmii converter support

Hi Andrew, > > > Signed-off-by: Kedareswara rao Appana > > --- > > Thanks a lot Andrew for your inputs. > > Changes for v5: > > --> Fixed return values in the probe as suggested by punnaiah. > > --> Added a mask for the converter speed as suggested by punnaiah. > > +/*

RE: [RFC PATCH v5 2/3] Documentation: DT: net: Add Xilinx gmiitorgmii converter device tree binding documentation

Hi Florian, Thanks for the review... > > On 08/09/2016 02:34 AM, Kedareswara rao Appana wrote: > > Device-tree binding documentation for xilinx gmiitorgmii converter. > > > > Signed-off-by: Kedareswara rao Appana > > --- > > Changes for v5: > > ---> Fixed

RE: [RFC PATCH v5 3/3] net: phy: Add gmiitorgmii converter support

Hi Florian, Thanks for the review... > > > > This converter sits between the MAC and the external phy MAC <==> > > GMII2RGMII <==> RGMII_PHY > > This looks good, just a few things, see below: Thanks... > > +config XILINX_GMII2RGMII > > + tristate "Xilinx GMII2RGMII converter

RE: [RFC PATCH v4 2/2] net: phy: Add gmiitorgmii converter support

Hi Punnaiah, Thanks for the review... > > + > > +#define XILINX_GMII2RGMII_REG 0x10 > > +#define BMCR_SPEED10 0x00 > > Move this macro to mii.h Sure will fix in the next version... > > > + > > +struct gmii2rgmii { > > + struct phy_device *phy_dev; > > + struct

RE: [RFC PATCH v4 1/2] Documentation: DT: net: Add Xilinx gmiitorgmii converter device tree binding documentation

Hi Michal, > On 8.8.2016 09:15, Kedareswara rao Appana wrote: > > Device-tree binding documentation for xilinx gmiitorgmii converter. > > > > Signed-off-by: Kedareswara rao Appana > > --- > > Changes for v4: > > --> Modified compatible as suggested by Rob. > > --> Removed

RE: [RFC PATCH v3 1/2] Documentation: DT: net: Add Xilinx gmiitorgmii converter device tree binding documentation

Hi Rob, Thanks for the review... > > +XILINX GMIITORGMII Converter Driver Device Tree Bindings > > + > > + > > +The Gigabit Media Independent Interface (GMII) to Reduced Gigabit > > +Media Independent Interface (RGMII) core

RE: [RFC PATCH v3 2/2] net: phy: Add gmiitorgmii converter support

Hi zhuyj, Thanks for the review... > > + switch (phydev->speed) { > + case SPEED_1000: > + val |= BMCR_SPEED1000; > + case SPEED_100: > + val |= BMCR_SPEED100; > + } > > Are there only 2 kinds of speed? Converter supports 3 different

RE: [RFC PATCH v2 1/4] Documentation: DT: net: Add Xilinx gmiitorgmii converter device tree binding documentation

Hi Florian, > > On 27/07/2016 01:05, Andrew Lunn wrote: > > Hi Appana > > > > Here is roughly what i was thinking: > > > > struct priv { > >phy_device *master; > >phy_device *slave; > >struct phy_driver *slave_drv; > > }; > > > > phy_status_clone(phy_device *master,

RE: [RFC PATCH v2 1/4] Documentation: DT: net: Add Xilinx gmiitorgmii converter device tree binding documentation

Hi Andrew, Thanks for the inputs... > > > > > > Hi Kedareswara > > > > > > > > So looking at the device tree, you have the gmiitorgmii as an mdio > > > > device. It will get probed as an mdio device, and from that you > > > > know the address on the bus. However, your driver does not > >

RE: [RFC PATCH v2 2/4] net: ethernet: xilinx: Add gmii2rgmii converter support

Hi Nicolas, > > > > #ifdef CONFIG_NET_VENDOR_XILINX > > You may need to have: > #if defined(CONFIG_NET_VENDOR_XILINX) && > defined(CONFIG_XILINX_GMII2RGMII) > > > extern int gmii2rgmii_phyprobe(struct gmii2rgmii *xphy); #else extern > > void gmii2rgmii_phyprobe(struct gmii2rgmii *xphy); > >

RE: [RFC PATCH v2 2/4] net: ethernet: xilinx: Add gmii2rgmii converter support

Hi Nicolas, Thanks for the review... > > diff --git a/include/linux/xilinx_gmii2rgmii.h > > b/include/linux/xilinx_gmii2rgmii.h > > new file mode 100644 > > index 000..b328ee7 > > --- /dev/null > > +++ b/include/linux/xilinx_gmii2rgmii.h > > @@ -0,0 +1,24 @@ > > > Here, header of

RE: [RFC PATCH 0/2] net: ethernet: Add support for gmii2rgmii converter

Hi Andrew, > On Fri, Jul 01, 2016 at 11:50:10AM +0530, Kedareswara rao Appana wrote: > > This patch series does the following > > ---> Add support for gmii2rgmii converter. > > How generic is this gmii2rgmii IP block? Could it be used with any GMII and > RGMII device? This converter does

RE: [RFC PATCH 0/2] net: ethernet: Add support for gmii2rgmii converter

Hi Florian, Thanks for the review... > Le 30/06/2016 23:20, Kedareswara rao Appana a écrit : > > This patch series does the following > > ---> Add support for gmii2rgmii converter. > > ---> Add support for gmii2rgmii converter in the macb driver. > > > > Earlier sent one RFC patch

RE: [RFC PATCH 1/2] net: ethernet: xilinx: Add gmii2rgmii converter support

Hi Florian, Thanks for the review. > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +static void xgmii2rgmii_fix_mac_speed(void *priv, unsigned int speed) > > +{ > > + struct gmii2rgmii

RE: [RFC PATCH 2/2] net: macb: Add gmii2rgmii phy converter support

Hi, > >>> +static inline void macb_hw_fix_mac_speed(struct macb *bp, > >>> + struct phy_device *phydev) > >>> +{ > >>> + if (likely(bp->converter_phy.fix_mac_speed)) > >> > >> What is the purpose of this branch bias? The code isn't in some hot > >> path, so I

RE: [RFC PATCH 2/2] net: macb: Add gmii2rgmii phy converter support

Hi Nicolas Ferre, Thanks for the quick review... > > Le 01/07/2016 08:20, Kedareswara rao Appana a écrit : > > This patch adds support for gmii2rgmii phy converter in the macb > > driver. > > Okay, I'd like more explanation here. > Hints & key words: > - dt property > - mdio

RE: [RFC PATCH] net: macb: Add gmii2rgmii converter support

Hi Florian, Thanks for the quick response... > > On June 19, 2016 10:27:17 PM MST, Kedareswara rao Appana > wrote: > >This patch adds support for gmii2rgmii converter in the macb driver. > > > >The GMII to RGMII IP core provides the > >Reduced Gigabit Media

RE: GMII2RGMII Converter support in macb driver

Thanks Phil Reid and Nicolas for your suggestions. > >> > >> > >> > >> But doing above changes making driver looks odd. > >> > >> could you please suggest any better option to add support for this IP > >> in the macb driver? > > > > Appana, > > > > I certainly can't prototype the solution based

RE: GMII2RGMII Converter support in macb driver

Hi Nicolas Ferre, > -Original Message- > From: Nicolas Ferre [mailto:nicolas.fe...@atmel.com] > Sent: Tuesday, April 12, 2016 6:52 PM > To: Appana Durga Kedareswara Rao <appa...@xilinx.com>; > netdev@vger.kernel.org; Michal Simek <mich...@xilinx.com> > Cc: P

RE: [PATCH v8] can: xilinx: Convert to runtime_pm

kernel.org; netdev@vger.kernel.org; linux-arm- > ker...@lists.infradead.org; linux-ker...@vger.kernel.org; Appana Durga > Kedareswara Rao > Subject: [PATCH v8] can: xilinx: Convert to runtime_pm > > Instead of enabling/disabling clocks at several locations in the driver, > Use the run

RE: [PATCH v7] can: xilinx: Convert to runtime_pm

Hi Marc, > -Original Message- > From: Marc Kleine-Budde [mailto:m...@pengutronix.de] > Sent: Monday, October 26, 2015 1:54 AM > To: Appana Durga Kedareswara Rao; Anirudha Sarangi; w...@grandegger.com; > Michal Simek; Soren Brinkmann > Cc: linux-...@vger.kernel.org; netd

RE: [PATCH 1/2] can: xilinx: use readl/writel instead of ioread/iowrite

Hi Marc, > -Original Message- > From: Marc Kleine-Budde [mailto:m...@pengutronix.de] > Sent: Thursday, October 22, 2015 1:52 PM > To: Arnd Bergmann; linux-arm-ker...@lists.infradead.org > Cc: Appana Durga Kedareswara Rao; Anirudha Sarangi; w...@grandegger.com; > M

RE: [PATCH 1/2] can: xilinx: use readl/writel instead of ioread/iowrite

Hi Arnd, > -Original Message- > From: Arnd Bergmann [mailto:a...@arndb.de] > Sent: Thursday, October 22, 2015 1:45 PM > To: linux-arm-ker...@lists.infradead.org > Cc: Appana Durga Kedareswara Rao; Anirudha Sarangi; w...@grandegger.com; > m...@pengutronix.de; M

RE: [PATCH 2/2] can: xilinx: fix bug in bus error handling

Hi Soren, > -Original Message- > From: Sören Brinkmann [mailto:soren.brinkm...@xilinx.com] > Sent: Thursday, October 22, 2015 10:03 PM > To: Appana Durga Kedareswara Rao > Cc: Anirudha Sarangi; w...@grandegger.com; m...@pengutronix.de; Michal > Simek; Appana Durga Keda

RE: [PATCH v6] can: xilinx: Convert to runtime_pm

Hi Soren, > -Original Message- > From: Sören Brinkmann [mailto:soren.brinkm...@xilinx.com] > Sent: Friday, October 23, 2015 3:43 AM > To: Appana Durga Kedareswara Rao > Cc: Anirudha Sarangi; w...@grandegger.com; m...@pengutronix.de; Michal > Simek; linux-...@vger.