[PATCH 4/5] resend forcedeth: tx pause watermarks

New chipsets introduced variant Rx FIFO sizes that need to be taken into account when setting up the tx pause watermarks. This patch introduces the new device feature flags based on a version and implements the new watermarks. Signed-off-by: Ayaz Abdulla [EMAIL PROTECTED] --- old/drivers/net

[PATCH 2/5] resend forcedeth: tx collision fix

This patch supports a new fix in hardware regarding tx collisions. In the cases where we are in autoneg mode and the link partner is in forced mode, we need to setup the tx deferral register differently in order to reduce collisions on the wire. Signed-off-by: Ayaz Abdulla [EMAIL PROTECTED

Re: [patch 2/4] forcedeth: fix MAC address detection on network card (regression in 2.6.23)

Andrew Morton wrote: On Tue, 05 Feb 2008 13:20:59 -0500 Jeff Garzik [EMAIL PROTECTED] wrote: Signed-off-by: Andrew Morton [EMAIL PROTECTED] NAK - this fixes one set of users, and breaks a working set of users. Need to add DMI check for the specific motherboard (dmi_check_system), and

Re: [patch 2/4] forcedeth: fix MAC address detection on network card (regression in 2.6.23)

Jeff Garzik wrote: Ayaz Abdulla wrote: Andrew Morton wrote: On Tue, 05 Feb 2008 13:20:59 -0500 Jeff Garzik [EMAIL PROTECTED] wrote: Signed-off-by: Andrew Morton [EMAIL PROTECTED] NAK - this fixes one set of users, and breaks a working set of users. Need to add DMI check

[PATCH 1/5] forcedeth: restart tx/rx

This patch fixes the issue where the transmitter and receiver must be restarted when applying new changes to certain registers. Signed-off-by: Ayaz Abdulla [EMAIL PROTECTED] --- old/drivers/net/forcedeth.c 2008-01-15 17:41:00.0 -0500 +++ new/drivers/net/forcedeth.c 2008-01-15 17:41

[PATCH 2/5] forcedeth: tx collision fix

This patch supports a new fix in hardware regarding tx collisions. In the cases where we are in autoneg mode and the link partner is in forced mode, we need to setup the tx deferral register differently in order to reduce collisions on the wire. Signed-off-by: Ayaz Abdulla [EMAIL PROTECTED

[PATCH 3/5] forcedeth: phy status fix

-by: Ayaz Abdulla [EMAIL PROTECTED] --- old/drivers/net/forcedeth.c 2008-01-15 18:38:52.0 -0500 +++ new/drivers/net/forcedeth.c 2008-01-15 19:27:55.0 -0500 @@ -327,8 +327,8 @@ NvRegMIIStatus = 0x180, #define NVREG_MIISTAT_ERROR0x0001 #define

[PATCH 4/5] forcedeth: tx pause watermarks

New chipsets introduced variant Rx FIFO sizes that need to be taken into account when setting up the tx pause watermarks. This patch introduces the new device feature flags based on a version and implements the new watermarks. Signed-off-by: Ayaz Abdulla [EMAIL PROTECTED] --- old/drivers/net

[PATCH 5/5] forcedeth: preserve registers

Various registers need to be preserved before resetting the device. Signed-off-by: Ayaz Abdulla [EMAIL PROTECTED] --- old/drivers/net/forcedeth.c 2008-01-17 16:51:40.0 -0500 +++ new/drivers/net/forcedeth.c 2008-01-20 11:56:45.0 -0500 @@ -1443,16 +1443,30 @@ { struct

Re: forcedeth oops

Jeff Garzik wrote: Andrew Brooks wrote: Hello I'm getting an oops in forcedeth whenever I shutdown, details below. I've tried kernel 2.6.16.59 and the latest forcedeth.c from nvidia.com which is package-1.23 version-0.62 date-2007/04/27. How can I download the latest

[PATCH] forcedeth: mac address mcp77/79

This patch is a critical fix for MCP77 and MCP79 devices. The feature flags were missing the define for correct mac address (DEV_HAS_CORRECT_MACADDR). Signed-off-by: Ayaz Abdulla [EMAIL PROTECTED] --- old/drivers/net/forcedeth.c 2008-01-28 10:15:28.0 -0500 +++ new/drivers/net

[PATCH 3/5] forcedeth: updated copyright section

This patch updates the copyright section to include 2007 and 2008. Signed-off-by: Ayaz Abdulla [EMAIL PROTECTED] --- old/drivers/net/forcedeth.c 2008-01-13 15:10:18.0 -0500 +++ new/drivers/net/forcedeth.c 2008-01-13 15:11:47.0 -0500 @@ -13,7 +13,7 @@ * Copyright (C) 2004

[PATCH 1/5] forcedeth: reset register fix

This patch fixes the reset register definition from 0x3C to 0x34. Signed-off-by: Ayaz Abdulla [EMAIL PROTECTED] --- old/drivers/net/forcedeth.c 2008-01-13 15:00:43.0 -0500 +++ new/drivers/net/forcedeth.c 2008-01-13 15:00:48.0 -0500 @@ -226,7 +226,7 @@ #define NVREG_MISC1_HD

[PATCH 2/5] forcedeth: checksum fix

. The IP Identification field can wrap around and cause data from new fragments to fill into older fragment slots with same IP Id. The stack would then not perform TCP/UDP checksum (after re-assembly of all fragments) since driver falsely stated it was already calculated. Signed-off-by: Ayaz

[PATCH 4/5] forcedeth: tx pause fix

This patch fixes the tx pause enable watermark flags. The new values where determined to be optimal during testing. Signed-off-by: Ayaz Abdulla [EMAIL PROTECTED] --- old/drivers/net/forcedeth.c 2008-01-13 15:12:16.0 -0500 +++ new/drivers/net/forcedeth.c 2008-01-13 15:14:55.0

[PATCH 5/5] forcedeth: multicast fix

This patch fixes the case where no multicast addresses are requested to be added to the multicast filter. The multicast mask must be set to all 1's instead of all 0's. Signed-off-by: Ayaz Abdulla [EMAIL PROTECTED] --- old/drivers/net/forcedeth.c 2008-01-13 15:15:22.0 -0500 +++ new

RE: [patch 02/10] forcedeth: power down phy when interface is down

Ed, You mention that the phy will become 100Mbit half duplex, but during nv_close, the phy setting is not modified. This might be a separate issue. Ayaz -Original Message- From: Andrew Morton [mailto:[EMAIL PROTECTED] Sent: Thursday, December 13, 2007 5:07 PM To: Ed Swierk Cc: Ayaz

RE: [patch 02/10] forcedeth: power down phy when interface is down

, 2007 4:03 PM To: [EMAIL PROTECTED] Cc: netdev@vger.kernel.org; [EMAIL PROTECTED]; [EMAIL PROTECTED]; Ayaz Abdulla Subject: [patch 02/10] forcedeth: power down phy when interface is down From: Ed Swierk [EMAIL PROTECTED] Bring the physical link down when the interface is down by placing the PHY

RE: [patch 2/8] forcedeth: fix MAC address detection on network card (regression in 2.6.23)

who have implemented it correctly. Thanks, Ayaz -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Sent: Wednesday, November 21, 2007 3:03 PM To: [EMAIL PROTECTED] Cc: netdev@vger.kernel.org; [EMAIL PROTECTED]; [EMAIL PROTECTED]; Ayaz Abdulla; [EMAIL PROTECTED] Subject

Re: [PATCH] forcedeth boot delay fix

Missed that break. Here is the corrected patch. Signed-off-by: Ayaz Abdulla [EMAIL PROTECTED] Andrew Morton wrote: On Sun, 18 Nov 2007 14:13:41 -0500 Ayaz Abdulla [EMAIL PROTECTED] wrote: This patch fixes a long boot delay in the forcedeth driver. During initialization, the timeout

[PATCH] forcedeth boot delay fix

This patch fixes a long boot delay in the forcedeth driver. During initialization, the timeout for the handshake between mgmt unit and driver can be very long. The patch reduces the timeout by eliminating a extra loop around the timeout logic. Signed-off-by: Ayaz Abdulla [EMAIL PROTECTED

[PATCH 1/2] forcedeth new mcp79 device ids

This patch adds new device ids for mcp79 devices. Signed-off-by: Ayaz Abdulla [EMAIL PROTECTED] --- old/include/linux/pci_ids.h 2007-11-07 14:14:01.0 -0500 +++ new/include/linux/pci_ids.h 2007-11-07 14:13:53.0 -0500 @@ -1237,6 +1237,10 @@ #define PCI_DEVICE_ID_NVIDIA_NVENET_33

[PATCH 2/2] forcedeth new mcp79 device ids

This patch adds new device ids and features for mcp79 devices into the forcedeth driver. Signed-off-by: Ayaz Abdulla [EMAIL PROTECTED] --- old/drivers/net/forcedeth.c 2007-11-07 14:13:47.0 -0500 +++ new/drivers/net/forcedeth.c 2007-11-07 14:13:39.0 -0500 @@ -5613,6 +5613,22

[PATCH 2/2] forcedeth new device ids

This patch adds new device ids and features for mcp77 devices into the forcedeth driver. Signed-off-by: Ayaz Abdulla [EMAIL PROTECTED] --- old/drivers/net/forcedeth.c 2007-10-23 16:47:08.0 -0400 +++ new/drivers/net/forcedeth.c 2007-10-23 16:47:11.0 -0400 @@ -5597,6 +5597,22

[PATCH 1/2] forcedeth new device ids

This patch adds new device ids for mcp77 devices. Signed-off-by: Ayaz Abdulla [EMAIL PROTECTED] --- old/include/linux/pci_ids.h 2007-10-23 16:49:46.0 -0400 +++ new/include/linux/pci_ids.h 2007-10-23 16:50:50.0 -0400 @@ -1236,6 +1236,10 @@ #define

Re: [PATCH] forcedeth: Fix MAC address detection on network card (regression in 2.6.23)

Jeff Garzik wrote: Michael Pyne wrote: Partially revert a change to mac address detection introduced to the forcedeth driver. The change was intended to correct mac address detection for newer nVidia chipsets where the mac address was stored in reverse order. One of those chipsets

MSI interrupts and disable_irq

I am trying to track down a forcedeth driver issue described by bug 9047 in bugzilla (2.6.23-rc7-git1 forcedeth w/ MCP55 oops under heavy load). I added a patch to synchronize the timer handlers so that one handler doesn't accidently enable the IRQ while another timer handler is running (see

Re: [PATCH] forcedeth: power down phy when interface is down

It seems that you are powering down the phy even if WOL is enabled. Secondly, can you powerdown the phy at the same time you start performing autoneg restart? Ed Swierk wrote: Bring the physical link down when the interface is down, by placing the PHY in power-down state. This mirrors the

[PATCH] forcedeth: mac address correct

In older chipsets, the mac address was stored in reversed order. However, in newer chipsets, the mac address is in correct order. This patch takes those newer chipsets into account and does not rely on a special bit setup by BIOS'. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] --- old/drivers

[PATCH] forcedeth: mac address correct

Resending: In older chipsets, the mac address was stored in reversed order. However, in newer chipsets, the mac address is in correct order. This patch takes those newer chipsets into account and does not rely on a special bit setup by BIOS'. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED

[PATCH 1/2] forcedeth: new device ids in pci_ids.h

This patch contains new device ids for MCP73 chipset. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] --- old/include/linux/pci_ids.h 2007-07-22 18:57:26.0 -0400 +++ new/include/linux/pci_ids.h 2007-07-22 18:57:11.0 -0400 @@ -1223,6 +1223,10 @@ #define

[PATCH 2/2] forcedeth: mcp73 device addition

This patch contains new device settings for MCP73 chipset. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] --- old/drivers/net/forcedeth.c 2007-07-22 19:02:41.0 -0400 +++ new/drivers/net/forcedeth.c 2007-07-22 19:31:56.0 -0400 @@ -5550,6 +5550,22 @@ PCI_DEVICE

[PATCH 1/3] forcedeth bug fix: cicada phy

This patch contains errata fixes for the cicada phy. It only renamed the defines to be phy specific. Signed-off-by: Ayaz Abdulla [EMAIL PROTECTED] --- old/drivers/net/forcedeth.c 2007-07-15 06:20:14.0 -0400 +++ new/drivers/net/forcedeth.c 2007-07-15 06:24:20.0 -0400 @@ -557,12

[PATCH 2/3] forcedeth bug fix: vitesse phy

This patch contains errata fixes for the vitesse phy. Signed-off-by: Ayaz Abdulla [EMAIL PROTECTED] --- old/drivers/net/forcedeth.c 2007-07-15 06:25:01.0 -0400 +++ new/drivers/net/forcedeth.c 2007-07-15 06:29:38.0 -0400 @@ -550,6 +550,7 @@ /* PHY defines */ #define

[PATCH 3/3] forcedeth bug fix: realtek phy

This patch contains errata fixes for the realtek phy. Signed-off-by: Ayaz Abdulla [EMAIL PROTECTED] --- old/drivers/net/forcedeth.c 2007-07-15 06:31:00.0 -0400 +++ new/drivers/net/forcedeth.c 2007-07-15 06:40:29.0 -0400 @@ -551,6 +551,7 @@ #define PHY_OUI_MARVELL0x5043

[PATCH 4/4] forcedeth: version bump

This patch bumps up the version. Signed-off-by: Ayaz Abdulla [EMAIL PROTECTED] --- old/drivers/net/forcedeth.c 2007-05-21 20:09:03.0 -0400 +++ new/drivers/net/forcedeth.c 2007-05-21 20:10:32.0 -0400 @@ -112,6 +112,7 @@ * 0.58: 30 Oct 2006: Added support for sideband

[PATCH 2/4] forcedeth: fix power management support

This patch fixes the power management functions. It includes lowering the phy speed to conserve power. Signed-off-by: Ayaz Abdulla [EMAIL PROTECTED] --- old/drivers/net/forcedeth.c 2007-05-01 15:32:03.0 -0400 +++ new/drivers/net/forcedeth.c 2007-05-21 19:54:39.0 -0400 @@ -812,6

[PATCH 1/4] forcedeth: add vitesse phy

This patch adds errata support for the vitesse phy. Signed-off-by: Ayaz Abdulla [EMAIL PROTECTED] --- old/drivers/net/forcedeth.c 2007-05-01 15:30:53.0 -0400 +++ new/drivers/net/forcedeth.c 2007-05-01 15:30:57.0 -0400 @@ -550,6 +550,7 @@ /* PHY defines */ #define

[PATCH 3/4] forcedeth: fix cpu irq mask

This patch fixes the cpu irq mask define to include the timer irq. Another flag check was setting up the timer bit in all cases so we didn't notice the issue. Signed-off-by: Ayaz Abdulla [EMAIL PROTECTED] --- old/drivers/net/forcedeth.c 2007-05-21 20:07:44.0 -0400 +++ new/drivers/net

Re: [patch 09/11] forcedeth: improve NAPI logic

this - tested on DESC_VER_2 hardware, with CONFIG_FORCEDETH_NAPI=y. Signed-off-by: Ingo Molnar [EMAIL PROTECTED] Cc: Ayaz Abdulla [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/net/forcedeth.c |8 1 file changed, 8 insertions(+) diff -puN drivers/net/forcedeth.c

Re: [patch 09/11] forcedeth: improve NAPI logic

Jeff Garzik wrote: Ayaz Abdulla wrote: I don't see why the NAPI handler needs to process tx packets. The ISR will handle all tx processing. It is a design choice, not a requirement. Moving non-RX interrupt processing to the NAPI handler can help as loads increase. The basic idea

RE: [patch 10/10] forcedeth: work around NULL skb dereference crash

: Monday, April 02, 2007 4:53 AM To: [EMAIL PROTECTED] Cc: [EMAIL PROTECTED]; netdev@vger.kernel.org; Ayaz Abdulla Subject: Re: [patch 10/10] forcedeth: work around NULL skb dereference crash * [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: From: Ingo Molnar [EMAIL PROTECTED] work around a NULL skb

[PATCH 1/2] forcedeth: fix nic poll

The nic poll routine was missing the call to the optimized irq routine. This patch adds the missing call for the optimized path. See http://bugzilla.kernel.org/show_bug.cgi?id=7950 for more information. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] --- orig/drivers/net/forcedeth.c2007

[PATCH 2/2] forcedeth: fix tx timeout

The tx timeout routine was waking the tx queue conditionally. However, it must call it unconditionally since the dev_watchdog has halted the tx queue before calling the timeout function. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] --- orig/drivers/net/forcedeth.c2007-03-11 20:59

[PATCH 1/3] forcedeth: fixed missing call in napi poll

The napi poll routine was missing the call to the optimized rx process routine. This patch adds the missing call for the optimized path. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] --- orig/drivers/net/forcedeth.c2007-02-20 03:17:21.0 -0500 +++ new/drivers/net/forcedeth.c

[PATCH 2/3] forcedeth: disable msix

There seems to be an issue when both MSI-X is enabled and NAPI is configured. This patch disables MSI-X until the issue is root caused. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] --- orig/drivers/net/forcedeth.c2007-02-20 03:29:04.0 -0500 +++ new/drivers/net/forcedeth.c 2007

[PATCH 3/3] forcedeth: fix checksum feature in mcp65

This patch removes checksum offload feature in mcp65 chipsets as they are not supported in hw. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] --- orig/drivers/net/forcedeth.c2007-02-20 03:30:16.0 -0500 +++ new/drivers/net/forcedeth.c 2007-02-20 03:30:29.0 -0500

[PATCH 1/3] forcedeth: fixed missing call in napi poll

The napi poll routine was missing the call to the optimized rx process routine. This patch adds the missing call for the optimized path. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] --- orig/drivers/net/forcedeth.c2007-02-19 09:13:10.0 -0500 +++ new/drivers/net/forcedeth.c

[PATCH 2/3] forcedeth: disable msix

There seems to be an issue when both MSI-X is enabled and NAPI is configured. This patch disables MSI-X until the issue is root caused. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] --- orig/drivers/net/forcedeth.c2007-02-19 09:17:02.0 -0500 +++ new/drivers/net/forcedeth.c 2007

[PATCH 3/3] forcedeth: fix checksum feature in mcp65

This patch removes checksum offload feature in mcp65 chipsets as they are not supported in hw. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] --- orig/drivers/net/forcedeth.c2007-02-19 09:17:41.0 -0500 +++ new/drivers/net/forcedeth.c 2007-02-19 09:19:43.0 -0500

Re: forcedeth problems on 2.6.20-rc6-mm3

Robert Hancock wrote: Ayaz Abdulla wrote: For all those who are having issues, please try out the attached patch. Ayaz --- This email message is for the sole use of the intended recipient(s) and may

Re: forcedeth problems on 2.6.20-rc6-mm3

David Ford wrote: On 2/5/07, *Andrew Morton* [EMAIL PROTECTED] mailto:[EMAIL PROTECTED] wrote: On Sun, 04 Feb 2007 23:48:33 -0600 Robert Hancock [EMAIL PROTECTED] mailto:[EMAIL PROTECTED] wrote: Andrew Morton wrote: On Sun, 04 Feb 2007 23:13:09 -0600 Robert Hancock

[PATCH 10/12] forcedeth: tx max work

This patch adds a limit to how much tx work can be done in each iteration of tx processing. If the max limit is reached, remaining tx completions will be handled by timer interrupt. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] --- orig/drivers/net/forcedeth.c2007-01-19 11:13

[PATCH 11/12] forcedeth: statistics supported

This patch introduces hw statistics for older devices that supported it. It breaks up the counters supported into separate versions. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] --- orig/drivers/net/forcedeth.c2007-01-21 17:33:59.0 -0500 +++ new/drivers/net/forcedeth.c 2007-01

[PATCH 12/12] forcedeth: statistics optimization

This patch optimizes the data paths that can support hw counters. It removes the sw counted statistics. This is the last patch for the optimization set. Bumping up version of driver. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] --- orig/drivers/net/forcedeth.c2007-01-21 17:38

[PATCH 8/12] forcedeth: rx data path optimization

This patch optimizes the rx data paths and cleans up the code. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] --- orig/drivers/net/forcedeth.c2007-01-19 11:08:24.0 -0500 +++ new/drivers/net/forcedeth.c 2007-01-19 11:11:04.0 -0500 @@ -1317,9 +1317,9

[PATCH 6/12] forcedeth: tx limiting

This patch optimizes the logic for tx limiting. It adds a flag to check on the completion side instead of recalculating the number of empty slots. Also, it removes the fields that were previous used for limiting since they have no value. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] --- orig

[PATCH 7/12] forcedeth: tx data path optimization

This patch optimizes the tx data paths and cleans up the code (removes vlan from descr1/2 since only valid for desc3, changes to make code easier to read, etc). Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED

[PATCH 0/12] forcedeth: optimization fixup

A few fixes have been made based on Jeff's comments. Resending patchs 5-12. Ayaz - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 9/12] forcedeth: irq data path optimization

This patch optimizes the irq data paths and cleans up the code. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] --- orig/drivers/net/forcedeth.c2007-01-19 11:11:35.0 -0500 +++ new/drivers/net/forcedeth.c 2007-01-19 11:13:25.0 -0500 @@ -2777,7 +2777,6

[PATCH 12/12] forcedeth: statistics optimization

This patch optimizes the data paths that can support hw counters. It removes the sw counted statistics. This is the last patch for the optimization set. Bumping up version of driver. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] --- orig/drivers/net/forcedeth.c2007-01-21 17:38

[PATCH 11/12] forcedeth: statistics supported

This patch introduces hw statistics for older devices that supported it. It breaks up the counters supported into separate versions. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] --- orig/drivers/net/forcedeth.c2007-01-21 17:33:59.0 -0500 +++ new/drivers/net/forcedeth.c 2007-01

[PATCH 5/12] forcedeth: optimized routines

This patch breaks up the routines into two versions, one for legacy descriptor versions (ver 1 and ver 2) and one for desc ver 3. This will make the new desc functions more leaner and further reductions will be made in next few patches. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] --- orig

Re: [PATCH 10/12] forcedeth: tx max work

Jeff Garzik wrote: Ayaz Abdulla wrote: This patch adds a limit to how much tx work can be done in each iteration of tx processing. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] What about the tail end of the work, when the limit is reached? Remember that delaying the completion of TX's

[PATCH 5/12] forcedeth: optimized routines

This patch breaks up the routines into two versions, one for legacy descriptor versions (ver 1 and ver 2) and one for desc ver 3. This will make the new desc functions more leaner and further reductions will be made in next few patches. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] --- orig

[PATCH 0/12] forcedeth optimizations

This set of patches contains optimizations for the forcedeth driver that help reduce CPU utilization and increase throughput, especially for small packet sizes. The main changes include ring accessing, tx locking, optimizing code branches, remove descriptor checks in data paths, reducing

[PATCH 7/12] forcedeth: tx data path optimization

This patch optimizes the tx data paths and cleans up the code (removes vlan from descr1/2 since only valid for desc3, changes to make code easier to read, etc). Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] --- orig/drivers/net/forcedeth.c2007-01-08 14:05:28.0 -0500 +++ new

[PATCH 8/12] forcedeth: rx data path optimization

This patch optimizes the rx data paths and cleans up the code. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] --- orig/drivers/net/forcedeth.c2007-01-08 14:06:32.0 -0500 +++ new/drivers/net/forcedeth.c 2007-01-08 14:18:37.0 -0500 @@ -1317,9 +1317,9

[PATCH 10/12] forcedeth: tx max work

This patch adds a limit to how much tx work can be done in each iteration of tx processing. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] --- orig/drivers/net/forcedeth.c2007-01-08 20:34:35.0 -0500 +++ new/drivers/net/forcedeth.c 2007-01-08 20:35:22.0 -0500 @@ -1859,14

[PATCH 11/12] forcedeth: statistics supported

This patch introduces hw statistics for older devices that supported it. It breaks up the counters supported into separate versions. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] --- orig/drivers/net/forcedeth.c2007-01-08 20:35:53.0 -0500 +++ new/drivers/net/forcedeth.c 2007-01

[PATCH 12/12] forcedeth: statistics optimization

This patch optimizes the data paths that can support hw counters. It removes the sw counted statistics. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] --- orig/drivers/net/forcedeth.c2007-01-08 18:32:08.0 -0500 +++ new/drivers/net/forcedeth.c 2007-01-08 18:42:58.0 -0500

[PATCH 1/12] forcedeth: dma access

This patch allows the hardware to fetch the tx and rx ring descriptors with 64 bytes per access instead of 32 bytes. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] --- orig/drivers/net/forcedeth.c2007-01-07 15:10:15.0 -0500 +++ new/drivers/net/forcedeth.c 2007-01-07 15:10

[PATCH 3/12] forcedeth: tx locking

This patch reduces the amount of code within the lock to only the critical sections. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] --- orig/drivers/net/forcedeth.c2007-01-07 22:30:08.0 -0500 +++ new/drivers/net/forcedeth.c 2007-01-07 22:30:02.0 -0500 @@ -1569,12

[PATCH 2/12] forcedeth: ring access

This patch modifys ring access by using pointers. This avoids computing the current index and avoids accessing the base address of the rings. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] --- orig/drivers/net/forcedeth.c2007-01-08 13:31:01.0 -0500 +++ new/drivers/net

[PATCH 4/12] forcedeth: rx skb recycle

This patch removes the code that recycled the skb on error. This will help in reducing the branches in the main data paths. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] --- orig/drivers/net/forcedeth.c2007-01-07 22:31:14.0 -0500 +++ new/drivers/net/forcedeth.c 2007-01-07 23:07

[PATCH 6/12] forcedeth: tx limiting

This patch optimizes the logic for tx limiting. It adds a flag to check on the completion side instead of recalculating the number of empty slots. Also, it removes the fields that were previous used for limiting since they have no value. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] --- orig

[PATCH 9/12] forcedeth: irq data path optimization

This patch optimizes the irq data paths and cleans up the code. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] --- orig/drivers/net/forcedeth.c2007-01-08 20:33:47.0 -0500 +++ new/drivers/net/forcedeth.c 2007-01-08 20:33:39.0 -0500 @@ -2777,7 +2777,6

[PATCH] forcedeth: sideband management fix

This patch contains a fix that implements proper communication with the sideband management unit. Also, it makes sure that the speed is correctly set for gigabit phys in the case where sideband mgmt unit initialized the phy. Refer to bug #7684 for more details. Signed-Off-By: Ayaz Abdulla

[PATCH] forcedeth: modified comment header

This patch removes comment that forcedeth is not supported by NVIDIA. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] --- orig-2.6/drivers/net/forcedeth.c2006-12-19 23:16:38.0 -0500 +++ new-2.6/drivers/net/forcedeth.c 2006-12-19 23:19:28.0 -0500 @@ -3,8 +3,7

[PATCH 2/2] forcedeth: add recoverable error support

This patch adds support to recover from a previously fatal MAC error. In the past the MAC would be hung on an internal fatal error. On new chipsets, the MAC has the ability to enter a non-fatal state and allow the driver to re-init it. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] --- orig

[PATCH 1/2] forcedeth: add mgmt unit support

This patch adds support for the mgmt unit in certain chipsets. The MAC and the mgmt unit share the PHY and therefore proper intialization procedures are needed for them to maintain coexistense. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] --- orig-2.6/drivers/net/forcedeth.c2006-10-30 16

[PATC 2/2] forcedeth: add support for new mcp67 device

This patch adds support for the new mcp67 device into forcedeth. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] --- orig-2.6/drivers/net/forcedeth.c2006-10-30 16:26:57.0 -0500 +++ new-2.6/drivers/net/forcedeth.c 2006-10-30 17:08:46.0 -0500 @@ -4927,6 +4927,22

Re: [PATCH 1/2] forcedeth: add new NVIDIA pci ids

Mgmt unit set was created first. However, it should not matter. Ayaz Jeff Garzik wrote: You sent two pairs of patches, both labelled 1/2 and 2/2. Which pair should go first, the pci ids or mgmt unit? Or does it matter? Jeff

[PATCH 1/2] forcedeth: move mac address setup/teardown

This patch moves the mac address setup/teardown to the nv_probe/nv_remove functions. This fixes WOL wakeup since on nv_close we would reverse the mac address. Also, bonding driver will reset address after nv_close is called. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] --- orig-2.6/drivers

[PATCH 2/2] forcedeth: mac address corrected

This patch will correct the mac address and set a flag to indicate that it is already corrected in case nv_probe is called again. For example, when you use kexec to restart the kernel. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] --- orig-2.6/drivers/net/forcedeth.c2006-07-06 15:06

[PATCH 2/2] forcedeth: watermark fixup

This patch defines the watermark registers and fixes up the use of this register. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] --- orig-2.6/drivers/net/forcedeth.c2006-07-06 15:04:39.0 -0400 +++ new-2.6/drivers/net/forcedeth.c 2006-07-06 15:05:00.0 -0400 @@ -271,8

[PATCH 1/2] forcedeth: deferral fixup

This patch adds the definition for the deferral registers and fixes up the use of these registers. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] --- orig-2.6/drivers/net/forcedeth.c2006-07-06 15:03:45.0 -0400 +++ new-2.6/drivers/net/forcedeth.c 2006-07-06 15:03:55.0

[PATCH 1/2] pci_ids: add new device ids

This patch adds new device ids for MCP61 and MCP65 chips. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] --- a/include/linux/pci_ids.h 2006-05-25 13:02:56.0 -0400 +++ b/include/linux/pci_ids.h 2006-05-25 13:03:09.0 -0400 @@ -1182,6 +1182,14 @@ #define

Re: Linux v2.6.17-rc4

Alistair John Strachan wrote: On Friday 12 May 2006 00:44, Linus Torvalds wrote: Ok, I've let the release time between -rc's slide a bit too much again, but -rc4 is out there, and this is the time to hunker down for 2.6.17. If you know of any regressions, please holler now, so that we don't

RE: pci_enable_msix throws up error

I noticed the same behaviour, i.e. can not use both MSI and MSIX without rebooting. I had sent a message to the maintainer of the MSI/MSIX source a few months ago and got a response that they were working on fixing it. Not sure what the progress is on it. Ayaz nvpublic -Original

[PATCH 3/4] forcedeth: fix initialization

This patch fixes the nic initialization. If the nic was in low power mode, it brings it back to normal power. Also, it utilizes a new hardware reset during the init. I am resending based on feedback, I corrected the register size mapping (again) and delay after posted write. Signed-Off-By: Ayaz

Re: [PATCH 2/4] forcedeth: add support for configuration

Ayaz Abdulla wrote: Manfred Spraul wrote: Ayaz Abdulla wrote: This patch adds support for configuration of various parameters. This includes module parameters and ethtool commands. + +if (netif_running(dev)) { +nv_start_rx(dev); +nv_start_tx(dev

Re: [PATCH 2/4] forcedeth: fix initialization

Ignore this...the patch number is wrong...I am resending it. Sorry for the confusion, Ayaz Abdulla wrote: This patch fixes the nic initialization. If the nic was in low power mode, it brings it back to normal power. Also, it utilizes a new hardware reset during the init. I am resending based

[PATCH 3/4] forcedeth: fix initialization (current)

This patch fixes the nic initialization. If the nic was in low power mode, it brings it back to normal power. Also, it utilizes a new hardware reset during the init. I am resending based on feedback, I corrected the register size mapping and delay after posted write. Signed-Off-By: Ayaz

[PATCH 4/4] forcedeth: fix multi irq issues

This patch fixes the issues with multiple irqs. I am resending based on feedback. I decoupled the dma mask for consistent memory and fixed leak with multiple irq in error path. Thanks to Manfred for catching the spin lock problem. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED

Re: [PATCH 3/4] forcedeth: fix initialization

Manfred Spraul wrote: Ayaz Abdulla wrote: + +NvRegPowerState2 = 0x600, +#define NVREG_POWERSTATE2_POWERUP_MASK0x0F11 +#define NVREG_POWERSTATE2_POWERUP_REV_A30x0001 }; If the nic has a register 0x600, then we should - ioremap enough memory. Right now, the code only remaps

Re: [PATCH 2/4] forcedeth: add support for configuration

Manfred Spraul wrote: Ayaz Abdulla wrote: This patch adds support for configuration of various parameters. This includes module parameters and ethtool commands. + +if (netif_running(dev)) { +nv_start_rx(dev); +nv_start_tx(dev); +nv_enable_irq(dev

Re: [PATCH 4/4] forcedeth: fix multi irq issues

Manfred Spraul wrote: Ayaz Abdulla wrote: if (nv_alloc_rx(dev)) { -spin_lock(np-lock); +spin_lock_irqsave(np-lock, flags); Tiny point: there is not need for irqsave(): we are in timer context, that guarantees: - bottom half disabled - interrupts enabled Just use

[PATCH 3/4] forcedeth: fix initialization

This patch fixes the nic initialization. If the nic was in low power mode, it brings it back to normal power. Also, it utilizes a new hardware reset during the init. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED

[PATCH 4/4] forcedeth: fix multi irq issues

This patch fixes the issues with multiple irqs. Thanks to Manfred for catching the spin lock problem. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] --- This email message is for the sole use of the intended

  1   2   >