On 9/11/2018 6:32 PM, Andrew Lunn wrote:
> Please take a look at all the other DT files using the Marvell
> chips. You will only ever find "marvell,mv88e6085" or
> "marvell,mv88e6190", because everything is compatible to one of these
> two.
To extend what Andrew stated above,
from looking at port_base_addr values (0x0 vs 0x10)
in drivers/net/dsa/mv88e6xxx/chip.c.
Signed-off-by: Brandon Streiff <brandon.stre...@ni.com>
---
Documentation/devicetree/bindings/net/dsa/marvell.txt | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/Documen
On 2/3/2018 3:40 PM, Andrew Lunn wrote:
> This patchset adds support for using the PTP hardware in switches
> supported by the mv88e6xxx driver. The code was produces in
> collaboration with Brandon Streiff doing the initial implementation,
> and then Richard Cochran and Andrew Lunn ma
> Oops, I had "slaveOnly" set in my PC's configuration. So layer2 seems
> to work as expected.
>
> Have you tested UDPv4? It doesn't work.
I have not. Our usage has been focused on 802.1AS; the ptp4l settings we
use are the following:
transportSpecific0x1
ptp_dst_mac
> From: Andrew Lunn [mailto:and...@lunn.ch]
> Sent: Thursday, September 28, 2017 11:57 AM
>
> It is the MAC which is doing the time stamping, not they PHY?
> So why NETWORK_PHY_TIMESTAMPING?
NETWORK_PHY_TIMESTAMPING implies NET_PTP_CLASSIFY (which I do use) and
net/core/timestamping.c (which I
> From: Andrew Lunn [mailto:and...@lunn.ch]
> Sent: Thursday, September 28, 2017 12:36 PM
>
> I assume ptp already has the core code to use pinctrl and Linux
> standard GPIOs? What does the device tree binding look like? How do
> you specify the GPIOs to use?
>
> What we want to avoid is defining
> From: Florian Fainelli [mailto:f.faine...@gmail.com]
> Sent: Thursday, September 28, 2017 12:40 PM
>
> Can we also have a fast-path bypass in case time stamping is not
> supported by the switch so we don't have to even try to classify this
> packet only to realize we don't have a port_rxtsamp()
> From: Andrew Lunn [mailto:and...@lunn.ch]
> Sent: Thursday, September 28, 2017 1:01 PM
>
> > With the write and read acquiring and then releasing the lock
> > immediately, is no there room for this sequence to be interrupted in the
> > middle and end-up returning inconsistent reads?
>
> The
> From: Andrew Lunn [mailto:and...@lunn.ch]
> Sent: Thursday, September 28, 2017 12:03 PM
>
> > + bool timeout = time_is_before_jiffies(chip->last_overflow_check +
> > + MV88E6XXX_TAI_OVERFLOW_PERIOD);
> > +
> > + if (timeout) {
>
> Why do you need
Signed-off-by: Brandon Streiff <brandon.stre...@ni.com>
---
drivers/net/dsa/mv88e6xxx/Makefile | 1 +
drivers/net/dsa/mv88e6xxx/chip.c | 16 +-
drivers/net/dsa/mv88e6xxx/chip.h | 26 ++
drivers/net/dsa/mv88e6xxx/hwtstamp.c | 535 +++
drivers/net/dsa/mv88
The Scratch/Misc register is a windowed interface that provides access
to the GPIO configuration. Provide a new method for configuration of
GPIO functions.
Signed-off-by: Brandon Streiff <brandon.stre...@ni.com>
---
drivers/net/dsa/mv88e6xxx/chip.c| 13 +++
drivers/net/dsa/mv8
This patch adds support for configuring mv88e6xxx GPIO lines as PTP
pins, so that they may be used for time stamping external events or for
periodic output.
Signed-off-by: Brandon Streiff <brandon.stre...@ni.com>
---
drivers/net/dsa/mv88e6xxx/chip.h | 4 +
drivers/net/dsa/mv88e6xxx
This patch adds support to the dsa slave network device so that
switch drivers can implement the SIOC[GS]HWTSTAMP ioctls and the
ethtool timestamp-info interface.
Signed-off-by: Brandon Streiff <brandon.stre...@ni.com>
---
include/net/dsa.h | 15 +++
net/dsa/slave.c
device_ops::rcv so that we can call the correct port_rxtstamp
method. This involved instrumenting all of the *_tag_rcv functions in
a way that's kind of a kludge and that I'm not terribly happy with.
This applies to net-next as of 14a0d032f4ec.
Feedback is appreciated.
-- brandon
Brandon
it is where that we know which switch and port the skb goes to.
On the tx side, identify PTP packets, clone them, and pass them to the
underlying switch driver before we transmit. This mimicks the behavior
of skb_tx_timestamp.
Signed-off-by: Brandon Streiff <brandon.stre...@ni.com>
---
inclu
There is a four-byte "reserved" field at octet 16 in PTPv2.
Signed-off-by: Brandon Streiff <brandon.stre...@ni.com>
---
include/linux/ptp_classify.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/ptp_classify.h b/include/linux/ptp_classify.h
index a079656
and the special "global port" values are
different between the two. This is a similar split to the differences
in the "Ingress Rate" register between models, so, like in that case,
we call the two variants "6352" and "6390" and create an ops structure
to abstract
This patch adds basic support for exposing the 32-bit timestamp counter
inside the mv88e6xxx switch code as a ptp_clock.
Signed-off-by: Brandon Streiff <brandon.stre...@ni.com>
---
drivers/net/dsa/mv88e6xxx/Kconfig | 10 +++
drivers/net/dsa/mv88e6xxx/Makefile | 1 +
drivers/net/dsa/mv8
88E6341 devices default to timestamping at the PHY, but due to a
hardware issue, timestamps via this component are unreliable. For
this family, configure the PTP hardware to force the timestamping
to occur at the MAC.
Signed-off-by: Brandon Streiff <brandon.stre...@ni.com>
---
drivers/n
> On Thu, Sep 21, 2017 at 01:05:57PM -0700, Florian Fainelli wrote:
>
>>> It looks like the macb driver still can't handle boards that don't
>>> have a PHY. Is that correct?
>>
>> Not since:
>>
>> dacdbb4dfc1a1a1378df8ebc914d4fe82259ed46 ("net: macb: add fixed-link
>> node support")
>
> Yep,
20 matches
Mail list logo
