Re: [PATCH] ibmveth: Kernel crash LSO offload flag toggle

2017-11-15 Thread Bryant G. Ly
On 11/14/17 8:47 PM, Daniel Axtens wrote: > Hi Bryant, > > This looks a bit better, but... > >> The following patch ensures that the bounce_buffer is not null >> prior to using it within skb_copy_from_linear_data. > How would this occur? > > Looking at ibmveth.c, I see bounce_buffer being freed in

[PATCH] ibmveth: Kernel crash LSO offload flag toggle

2017-11-14 Thread Bryant G. Ly
] [c004563c] start_secondary+0x33c/0x360 [76563.914572] [c000feab3f90] [c0008b6c] start_secondary_prolog+0x10/0x14 Signed-off-by: Bryant G. Ly Signed-off-by: Sivakumar Krishnasamy Cc: # 4.4+ --- drivers/net/ethernet/ibm/ibmveth.c | 10 -- 1 file changed, 8 insertions(+), 2

Re: [PATCH] ibmveth: Kernel crash LSO offload flag toggle

2017-11-14 Thread Bryant G. Ly
On 11/13/17 7:07 PM, Daniel Axtens wrote: > Hi Bryant, > > A few things: > > 1) The commit message could probably be trimmed, especially the stack > traces. Yes, I can trim it. > 2) What exactly are you changing and why does it fix the issue? I > couldn't figure that out from the commit message

[PATCH] ibmveth: Kernel crash LSO offload flag toggle

2017-11-13 Thread Bryant G. Ly
409e0014 a004 38840002 38630002 409d0014 8004 [76563.914613] ---[ end trace 5382b3d78671418e ]--- [76563.916817] [76565.916870] Kernel panic - not syncing: Fatal exception in interrupt [76565.919468] ---[ end Kernel panic - not syncing: Fatal exception in interrupt Signed-off-by: Bryant G. Ly