Jeff Garzik wrote:
Chris Lalancette wrote:
Francois Romieu wrote:
Chris Lalancette [EMAIL PROTECTED] :
[...]
Thanks for the comments. While the patch you sent will help,
there are
still other places that will have problems. For example, in
netpoll_send_skb,
we call
Francois Romieu wrote:
Chris Lalancette [EMAIL PROTECTED] :
[...]
Similar to this commit:
http://kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=d15e9c4d9a75702b30e00cdf95c71c88e3f3f51e
It's not safe in cp_start_xmit to blindly call spin_lock_irq
Francois Romieu wrote:
Chris Lalancette [EMAIL PROTECTED] :
[...]
Thanks for the comments. While the patch you sent will help, there are
still other places that will have problems. For example, in netpoll_send_skb,
we call local_irq_save(flags), then call dev-hard_start_xmit
to do that.
Signed-off-by: Chris Lalancette [EMAIL PROTECTED]
diff --git a/drivers/net/8139cp.c b/drivers/net/8139cp.c
index e2cb19b..6f93a76 100644
--- a/drivers/net/8139cp.c
+++ b/drivers/net/8139cp.c
@@ -765,17 +765,18 @@ static int cp_start_xmit (struct sk_buff *skb, struct net_device *dev
,
respectively, in cp_start_xmit(). I tested this against a fully-virtualized
Xen guest, which happens to use the 8139cp driver to talk to the emulated
hardware. I don't have a real piece of 8139cp hardware to test on, so someone
else will have to do that.
Signed-off-by: Chris Lalancette [EMAIL
Chris Lalancette wrote:
All,
Attached is a patch to fix arp_reply when you have multiple possible
routers doing ARP requests to you. Currently arp_reply always replies to the
MAC address that it was given when it starts. However, if you have multiple
routers that can ARP request you
has tested the patch and reports that it fixes the problems they were
having.
Signed-off-by: Chris Lalancette [EMAIL PROTECTED]
diff --git a/net/core/netpoll.c b/net/core/netpoll.c
index 3c58846..5833b21 100644
--- a/net/core/netpoll.c
+++ b/net/core/netpoll.c
@@ -331,6 +331,7 @@ static void
David Miller wrote:
From: Chris Lalancette [EMAIL PROTECTED]
Date: Mon, 06 Nov 2006 18:40:59 -0500
Assuming that this is just an oversight, attached is a simple
patch to compute the UDP checksum in netpoll_send_udp.
If the resulting checksum is zero, you should set it to
all 1's
of netpoll_send_udp is
netconsole (and netdump in RedHat kernels).
Assuming that this is just an oversight, attached is a simple patch to
compute the UDP checksum in netpoll_send_udp.
Signed-off-by: Chris Lalancette [EMAIL PROTECTED]
--- linux-2.6/net/core/netpoll.c.orig 2006-11-06 18:16
