Re: [PATCH RESEND] wireless: iwlwifi: fix minor code style issues

On Mon, 2017-09-25 at 13:37 +0200, Christoph Böhmwalder wrote: > Fixes three trivial issues as reported by checkpatch.pl, namely two switch/case indentation issues and one alignment issue in a multiline comment. Signed-off-by: Christoph Böhmwalder --- Why are you

Re: [GIT] Networking

On Wed, 2017-09-06 at 21:57 -0700, Linus Torvalds wrote: > On Wed, Sep 6, 2017 at 9:11 PM, Coelho, Luciano > <luciano.coe...@intel.com> wrote: > > > > This seems to be a problem with backwards-compatibility with FW version > > 27. We are now in version 31[1] a

Re: [GIT] Networking

On Wed, 2017-09-06 at 16:27 -0700, Linus Torvalds wrote: > This pull request completely breaks Intel wireless for me. > > This is my trusty old XPS 13 (9350), using Intel Wireless 8260 (rev 3a). > > That remains a very standard Intel machine with absolutely zero odd > things going on. > > The

Re: [PATCH v3] iwlwifi: Demote messages about fw flags size to info

On Thu, 2017-08-03 at 07:47 -0700, João Paulo Rechi Vita wrote: > These messages are not reporting a real error, just the fact that the > firmware knows about more flags than the driver. > > Currently these messages are presented to the user during boot if there > is no bootsplash covering the

Re: [PATCH V5 1/2] firmware: add more flexible request_firmware_async function

On Thu, 2017-08-03 at 08:23 +0300, Kalle Valo wrote: > "Luis R. Rodriguez" writes: > > > > +int request_firmware_nowait(struct module *module, bool uevent, > > > + const char *name, struct device *device, gfp_t gfp, > > > + void

Re: [PATCH] iwlwifi: Demote messages about fw flags size to info

On Fri, 2017-07-21 at 07:51 -0700, João Paulo Rechi Vita wrote: > These messages are not reporting a real error, just the fact that the > firmware knows about more flags then the driver. > > Currently these messages are presented to the user during boot if there > is no bootsplash covering the

Re: new warning at net/wireless/util.c:1236

On Thu, 2017-05-04 at 07:35 +0300, Kalle Valo wrote: > Linus Torvalds writes: > > > So my Dell XPS 13 seems to have grown a new warning as of the > > networking merge yesterday. > > > > Things still work, but when it starts warning, it generates a *lot* of > >

Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

On Mon, 2016-07-11 at 11:18 -0400, Prarit Bhargava wrote: > Didn't get any feedback or review comments on this patch.  Resending > ... > > P. Sorry, this got flooded down my inbox. > ---8<--- > > The iwlwifi driver implements a thermal zone and hwmon device, but > returns -EIO on temperature

Re: [PATCH] iwlwifi: mvm: avoid harmless -Wmaybe-uninialized warning

On Fri, 2016-05-27 at 15:07 +0200, Arnd Bergmann wrote: > gcc is apparently unablel to track the state of the local 'resp_v2' > variable across the kzalloc() function, and warns about the response > variable being used without an initialization: > > drivers/net/wireless/intel/iwlwifi/mvm/nvm.c:

Re: [PATCH 1/1] iwlwifi: rs: remove superfluous check

On Wed, 2016-05-18 at 01:31 +0200, Heinrich Schuchardt wrote: > If we dereference a variable anyway in other parts of the code, > there is no need to check against NULL in a single place. NACK.  This is not true. If lq_sta is NULL, it means that mvm_sta is also NULL.  Then we call the

Re: [GIT] Networking

On Wed, 2016-05-18 at 12:00 -0700, Linus Torvalds wrote: > On Wed, May 18, 2016 at 11:58 AM, Kalle Valo > wrote: > > > > > > It would be best if you could send a patch either directly to Dave > > or > > Linus to resolve this quickly. > I'm committing my patch myself right

Re: [GIT] Networking

On Wed, 2016-05-18 at 11:45 -0700, Linus Torvalds wrote: > On Wed, May 18, 2016 at 7:23 AM, Coelho, Luciano > <luciano.coe...@intel.com> wrote: > > > > > > I can confirm that 4.6 contains the same bug.  And reverting the > > patch > > I mentioned does so

Re: [GIT] Networking

On Wed, 2016-05-18 at 06:51 -0600, Reinoud Koornstra wrote: > On Wed, May 18, 2016 at 6:41 AM, Coelho, Luciano > <luciano.coe...@intel.com> wrote: > > > > On Wed, 2016-05-18 at 06:20 -0600, Reinoud Koornstra wrote: > > > > > > On Wed, May 18, 2016 at 4

Re: [GIT] Networking

On Wed, 2016-05-18 at 06:20 -0600, Reinoud Koornstra wrote: > On Wed, May 18, 2016 at 4:51 AM, Coelho, Luciano > <luciano.coe...@intel.com> wrote: > > > > Hi Emmanuel, Linus, > > > > > > On Wed, 2016-05-18 at 06:37 +0300, Emmanuel Grumbach wrote: &g

Re: [GIT] Networking

Hi Emmanuel, Linus, On Wed, 2016-05-18 at 06:37 +0300, Emmanuel Grumbach wrote: > On Wed, May 18, 2016 at 4:00 AM, Linus Torvalds > wrote: > > > > On Tue, May 17, 2016 at 12:11 PM, David Miller > > wrote: > > > > > > > > > Highlights: > >

Re: pull-request: wireless-drivers-next 2016-05-13

On Mon, 2016-05-16 at 17:08 +0300, Kalle Valo wrote: > Kalle Valo writes: > > > > > Kalle Valo writes: > > > > > > > > The following changes since commit > > > ede00a5ceb4d903a8c137a52bb77d574baaef8bd: > > > > > >   Merge tag

Re: linux-next: manual merge of the wireless-drivers-next tree with the net-next tree

Hi Kalle, On Mon, 2016-05-16 at 16:10 +0300, Kalle Valo wrote: > (Adding Luca and linux-wireless) > > Stephen Rothwell writes: > > > > > Today's linux-next merge of the wireless-drivers-next tree got a > > conflict in: > > > >  

Re: [PATCH] iwlwifi:Fix incorrect fallthrough in switch statement in the function iwl_mvm_check_running_scans

On Tue, 2015-09-22 at 20:24 -0400, Nicholas Krause wrote: > This fixes incorrect fallthrough in the switch statment checking > the scan type passed by the caller to iwl_mvm_check_running_scans > for the switch case IWL_MVM_SCAN_SCHED to return directly after > the call to iwl_mvm_scan_stop in