Re: [PATCH v2 net 2/3] virtio_net: fix adding vids on big-endian

On Thu, 19 Apr 2018 08:30:49 +0300 "Michael S. Tsirkin" wrote: > Programming vids (adding or removing them) still passes > guest-endian values in the DMA buffer. That's wrong > if guest is big-endian and when virtio 1 is enabled. > > Note: this is on top of a previous patch: >

Re: [PATCH v3] net: iucv: Free memory obtained by kzalloc

goto out_iucv_dev; > return 0; > > +out_iucv_dev: > + put_device(af_iucv_dev); > out_driver: > driver_unregister(_iucv_driver); > out_iucv: Reviewed-by: Cornelia Huck <coh...@redhat.com>

Re: [PATCH] net: iucv: Free memory obtained by kzalloc

On Wed, 28 Feb 2018 17:39:53 +0530 Arvind Yadav <arvind.yadav...@gmail.com> wrote: > On Wednesday 28 February 2018 05:26 PM, Cornelia Huck wrote: > > On Wed, 28 Feb 2018 17:14:55 +0530 > > Arvind Yadav <arvind.yadav...@gmail.com> wrote: > > > >> On Wed

Re: [PATCH] net: iucv: Free memory obtained by kzalloc

On Wed, 28 Feb 2018 17:14:55 +0530 Arvind Yadav <arvind.yadav...@gmail.com> wrote: > On Wednesday 28 February 2018 04:00 PM, Cornelia Huck wrote: > > On Wed, 28 Feb 2018 15:24:16 +0530 > > Arvind Yadav <arvind.yadav...@gmail.com> wrote: > > >

Re: [PATCH] net: iucv: Free memory obtained by kzalloc

On Wed, 28 Feb 2018 15:24:16 +0530 Arvind Yadav wrote: > Free memory, if afiucv_iucv_init is not successful and > removing a IUCV driver. > > Signed-off-by: Arvind Yadav > --- > net/iucv/af_iucv.c | 5 - > 1 file changed, 4

Re: [PATCH 4/6] virtio_net: allow specifying context for rx

On Thu, 30 Mar 2017 17:31:37 +0300 "Michael S. Tsirkin" <m...@redhat.com> wrote: > On Thu, Mar 30, 2017 at 09:26:51AM +0200, Cornelia Huck wrote: > > On Wed, 29 Mar 2017 23:48:54 +0300 > > "Michael S. Tsirkin" <m...@redhat.com> wrote: > >

Re: [PATCH 1/2] virtio: allow drivers to validate features

On Wed, 29 Mar 2017 20:14:44 +0300 "Michael S. Tsirkin" wrote: > Some drivers can't support all features in all configurations. At the > moment we blindly set FEATURES_OK and later FAILED. Support this better > by adding a callback drivers can use to do some early checks.

Re: [PATCH 4/6] virtio_net: allow specifying context for rx

On Wed, 29 Mar 2017 23:48:54 +0300 "Michael S. Tsirkin" wrote: > With mergeable buffers we never use s/g for rx, > so allow specifying context in that case. > > Signed-off-by: Michael S. Tsirkin > --- > drivers/net/virtio_net.c | 15 ++- > 1 file

Re: [PATCH 1/6] virtio: wrap find_vqs

On Wed, 29 Mar 2017 23:48:44 +0300 "Michael S. Tsirkin" wrote: > We are going to add more parameters to find_vqs, let's wrap the call so > we don't need to tweak all drivers every time. > > Signed-off-by: Michael S. Tsirkin > --- > drivers/block/virtio_blk.c

Re: [PATCH] linux/types.h: enable endian checks for all sparse builds

On Thu, 8 Dec 2016 04:29:39 +0200 "Michael S. Tsirkin" wrote: > By now, linux is mostly endian-clean. Enabling endian-ness > checks for everyone produces about 200 new sparse warnings for me - > less than 10% over the 2000 sparse warnings already there. Out of curiousity: Where

Re: [PATCH 3/3] tools/virtio: use {READ,WRITE}_ONCE() in uaccess.h

inux/uaccess.h | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) Reviewed-by: Cornelia Huck <cornelia.h...@de.ibm.com>

Re: [PATCH 2/3] vringh: kill off ACCESS_ONCE()

> Cc: Michael S. Tsirkin <m...@redhat.com> > Cc: k...@vger.kernel.org > Cc: linux-ker...@vger.kernel.org > Cc: netdev@vger.kernel.org > Cc: virtualizat...@lists.linux-foundation.org > --- > drivers/vhost/vringh.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Reviewed-by: Cornelia Huck <cornelia.h...@de.ibm.com>

Re: [PATCH 1/3] tools/virtio: fix READ_ONCE()

.@redhat.com> > Cc: Michael S. Tsirkin <m...@redhat.com> > Cc: linux-ker...@vger.kernel.org > Cc: virtualizat...@lists.linux-foundation.org > --- > tools/virtio/linux/compiler.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Cornelia Huck <cornelia.h...@de.ibm.com>

Re: [PATCH] virtio-net: drop legacy features in virtio 1 mode

t it to stable/downstream > kernels. > > Cc: sta...@vger.kernel.org > Signed-off-by: Michael S. Tsirkin <m...@redhat.com> > --- > drivers/net/virtio_net.c | 30 -- > 1 file changed, 20 insertions(+), 10 deletions(-) Reviewed-by: Cornelia Huck <cornelia.h...@de.ibm.com>

Re: [REGRESSION] 362899b ("macvtap: switch to use skb array") causes oops during teardown

uff *skb; > > - while ((skb = skb_array_consume(>skb_array)) != NULL) > - kfree_skb(skb); > + skb_array_cleanup(>skb_array); > } > > static int macvtap_open(struct inode *inode, struct file *file) Yes, that change fixes things for me. Tested-by: Cornelia Huck <cornelia.h...@de.ibm.com> Thanks for the quick reply!

[REGRESSION] 362899b ("macvtap: switch to use skb array") causes oops during teardown

I'm hitting the following oops during shutdown (halt command in guest) of a libvirt-managed qemu guest 100% of the time: [ 108.920486] Unable to handle kernel pointer dereference in virtual kernel address space [ 108.920492] Failing address: 6b6b6b6b6b6b6000 TEID: 6b6b6b6b6b6b6803 [

Re: [PATCH 2/2] vhost: disentangle vring endianness stuff from the core code

On Wed, 10 Feb 2016 14:08:43 +0100 Greg Kurz wrote: > But you are right, there is a bug: we should rollback if vhost_init_used() > fails. Something like below: > > err_used: > vq->private_data = oldsock; > vhost_net_enable_vq(n, vq); > +

Re: [PATCH 1/2] vhost: helpers to enable/disable vring endianness

On Wed, 10 Feb 2016 13:11:34 +0100 Greg Kurz wrote: > On Wed, 10 Feb 2016 13:21:22 +0200 > "Michael S. Tsirkin" wrote: > > > On Wed, Jan 13, 2016 at 06:09:41PM +0100, Greg Kurz wrote: > > > diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c >

Re: [PATCH 1/2] vhost: helpers to enable/disable vring endianness

rent code. > > This patch introduces helpers with explicit enable and disable semantics, > for better clarity. > > No behaviour change. > > Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> > --- > drivers/vhost/vhost.c | 28 +++- > 1 file changed, 19 insertions(+), 9 deletions(-) Reviewed-by: Cornelia Huck <cornelia.h...@de.ibm.com>

Re: [PATCH 2/2] vhost: disentangle vring endianness stuff from the core code

host/test.c |2 ++ > drivers/vhost/vhost.c | 16 +++- > drivers/vhost/vhost.h |1 + > 5 files changed, 20 insertions(+), 5 deletions(-) Reviewed-by: Cornelia Huck <cornelia.h...@de.ibm.com>

Re: [PATCH] vhost: move is_le setup to the backend

net.c |6 ++ > drivers/vhost/scsi.c |3 +++ > drivers/vhost/test.c |2 ++ > drivers/vhost/vhost.c | 12 +++----- > drivers/vhost/vhost.h |1 + > 5 files changed, 19 insertions(+), 5 deletions(-) Makes sense. Reviewed-by: Cornelia Huck <cor

Re: [PATCH] KVM: Add Kconfig option to signal cross-endian guests

...@redhat.com --- arch/arm/kvm/Kconfig | 1 + arch/arm64/kvm/Kconfig | 1 + arch/powerpc/kvm/Kconfig | 1 + drivers/net/Kconfig | 1 + drivers/vhost/Kconfig| 1 + virt/kvm/Kconfig | 3 +++ 6 files changed, 8 insertions(+) Acked-by: Cornelia Huck cornelia.h

Re: 2.6.22-git: known regressions with patches

On Thu, 19 Jul 2007 18:35:04 +0200, Michal Piotrowski [EMAIL PROTECTED] wrote: FS Subject : AFS compile broken References : http://lkml.org/lkml/2007/7/19/218 Last known good : ? Submitter : Meelis Roos [EMAIL PROTECTED] Caused-By : ? Handled-By : Cornelia

Re: [PATCH 1/5] try parent numa_node at first before using default

On Thu, 12 Jul 2007 07:47:52 +0200, Stefan Richter [EMAIL PROTECTED] wrote: The patch does nothing for all subsystems which do device_initialize(dev); dev-parent = pd; device_add(dev); Let's avoid to add infrastructure which does nothing, or only does something by

Re: [PATCH 1/5] try parent numa_node at first before using default

On Thu, 12 Jul 2007 13:30:28 +0200, Stefan Richter [EMAIL PROTECTED] wrote: So, since figuring the correct DMA device out is done by drivers themselves, they usually can figure out the correct NUMA node as well. The only precondition is that each DMA device has the correct NUMA node set.

Re: [PATCH] try parent numa_node at first before using default

On Thu, 12 Jul 2007 10:59:53 -0700, Yinghai Lu [EMAIL PROTECTED] wrote: @@ -1285,8 +1290,11 @@ int device_move(struct device *dev, struct device *new_parent) dev-parent = new_parent; if (old_parent) klist_remove(dev-knode_parent); - if (new_parent) + if

[Patch driver tree] qeth: Remove usage of subsys.rwsem

-by: Cornelia Huck [EMAIL PROTECTED] --- drivers/s390/net/qeth_proc.c |2 -- 1 files changed, 2 deletions(-) --- linux.orig/drivers/s390/net/qeth_proc.c +++ linux/drivers/s390/net/qeth_proc.c @@ -37,7 +37,6 @@ qeth_procfile_seq_start(struct seq_file struct device *dev = NULL