Re: [RFC 0/1] Appletalk AARP probe broken by receipt of own broadcasts.

2018-08-21 Thread Craig McGeachie
On 21/08/18 01:28, Andrew Lunn wrote: >> Turns out the problem is WinPCAP running on the host system (Windows >> 10). > It would be good to report this to the WinPCAP people. I hate it when > debug tools actually introduce bugs. This will take me some time. I couldn't fairly blame WinPCAP.

Re: [RFC 0/1] Appletalk AARP probe broken by receipt of own broadcasts.

2018-08-20 Thread Craig McGeachie
On 20/08/18 02:41, Andrew Lunn wrote: >> I run inside Virtualbox with the Realtek PCIe GBE Family Controller. >> >> Assuming I'm reading /sys/class/net/enp0s3/driver correctly, it's using the >> e1000 driver. > > Hi Craig Andrew, My apologies. I've wasted your time. PEBKAC. > Ah. And how do

Re: [RFC 0/1] Appletalk AARP probe broken by receipt of own broadcasts.

2018-08-18 Thread Craig McGeachie
On 19/08/18 13:32, Andrew Lunn wrote: On Sun, Aug 19, 2018 at 01:07:38PM +1200, Craig McGeachie wrote: I'm hoping I can find someone able and willing to test this patch. That requires someone still using netatalk 2.2.x with DDP, or some other DDP userspace application. This feels like

[RFC 1/1] appletalk: ignore aarp probe broadcasts that loopback.

2018-08-18 Thread Craig McGeachie
Ethertalk broadcast, and incorrectly interprets that as another node trying to claim the address. Signed-off-by: Craig McGeachie --- net/appletalk/aarp.c | 4 1 file changed, 4 insertions(+) diff --git a/net/appletalk/aarp.c b/net/appletalk/aarp.c index 49a16cee..f966cc01 100644 --- a/net

[RFC 0/1] Appletalk AARP probe broken by receipt of own broadcasts.

2018-08-18 Thread Craig McGeachie
is to disregard all received packets that have a sender address that matches the device hardware address. This is more than just probe packets, but there is no legitimate situation where an Appletalk node sends AARP packets to itself. Craig McGeachie (1): appletalk: ignore aarp probe broadcasts