[PATCH] mv643xx_eth: fix byte order when checksum offload is enabled

2008-01-19 Thread Dale Farnsworth
[EMAIL PROTECTED] Signed-off-by: Dale Farnsworth [EMAIL PROTECTED] Cc: Manish Lachwani [EMAIL PROTECTED] Cc: Tzachi Perelstein [EMAIL PROTECTED] --- Byron Bradley wrote: This patch has only been tested on two Marvell Orion based boards so it should be considered only very lightly tested

Re: [PATCH] mv643xx_eth: fix byte order when checksum offload is enabled

2008-01-19 Thread Dale Farnsworth
OK, after digesting Al Viro's comments on this, I agree with him and retract this. These multiple byte swaps sure are confusing. Byron, would you please resubmit? Thanks, -Dale On Sat, Jan 19, 2008 at 01:23:01PM -0700, Dale Farnsworth wrote: From: Byron Bradley [EMAIL PROTECTED

Re: [PATCH] add modalias info to mv643xx_eth.ko

2008-01-18 Thread Dale Farnsworth
On Fri, Jan 18, 2008 at 10:38:05AM +0100, Olaf Hering wrote: mv643xx_eth has an platform modalias file in sysfs. But the module itself has no alias: line. Autoloading fails without the alias info in the module. Signed-off-by: Olaf Hering [EMAIL PROTECTED] Acked-by: Dale Farnsworth [EMAIL

Re: [PATCH] pegasos_eth.c: Fix compile error over MV643XX_ defines

2007-10-30 Thread Dale Farnsworth
On Tue, Oct 30, 2007 at 10:36:06AM +0100, Sven Luther wrote: On Tue, Oct 30, 2007 at 03:44:59AM -0400, Luis R. Rodriguez wrote: On 10/29/07, Dale Farnsworth [EMAIL PROTECTED] wrote: On Mon, Oct 29, 2007 at 05:27:29PM -0400, Luis R. Rodriguez wrote: This commit made an incorrect

Re: [PATCH] pegasos_eth.c: Fix compile error over MV643XX_ defines

2007-10-29 Thread Dale Farnsworth
-off-by: Dale Farnsworth [EMAIL PROTECTED] -- arch/powerpc/platforms/chrp/pegasos_eth.c made use of a 3 defines there. [EMAIL PROTECTED]:~/devel/wireless-2.6$ git-describe v2.6.24-rc1-138-g0119130 This patch fixes this by internalizing 3 defines onto pegasos which are simply no longer

Re: [PATCH v4.2] FEC - fast ethernet controller for mpc52xx

2007-10-26 Thread Dale Farnsworth
for + * dma_unmap_single(), but bcom doesn't return bcom_bd of the + * finished transfer, and _unmap is empty on this platfrom. + */ Oops, you forgot to remove the above comment. :) Otherwise, Acked-by: Dale Farnsworth [EMAIL PROTECTED] Domen, thanks for all your work

Re: [PATCH v4] FEC - fast ethernet controller for mpc52xx

2007-10-25 Thread Dale Farnsworth
IRQ_HANDLED; +} -Dale Farnsworth - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4] FEC - fast ethernet controller for mpc52xx

2007-10-25 Thread Dale Farnsworth
On Thu, Oct 25, 2007 at 09:41:14PM +0200, Domen Puncer wrote: On 25/10/07 11:57 -0700, Dale Farnsworth wrote: Domen wrote: use your platform's dma mapping functions, rather than virt_to_phys() it might be the exact same implementation, inside the platform internals

Please pull bug-fixes branch of linux-2.6-mv643xx_eth.git

2007-10-23 Thread Dale Farnsworth
commit: Author: Dale Farnsworth [EMAIL PROTECTED] Date: Sat Oct 20 12:16:27 2007 -0700 mv643xx_eth: Hook up mv643xx_get_sset_count Commit b9f2c044 replaced mv643xx_get_stats_count() with mv643xx_get_sset_count(), but forgot to hook it up. drivers/net/mv643xx_eth.c:2678

Please pull features branch of linux-2.6-mv643xx_eth.git

2007-10-23 Thread Dale Farnsworth
The following changes since commit e8b8c977734193adedf2b0f607d6252c78e86394: Linus Torvalds (1): Revert kconfig: tristate choices with mixed tristate and boolean values are available in the git repository at: git://farnsworth.org/dale/linux-2.6-mv643xx_eth.git features Dale

Re: [PATCH 2/8] [MV643XX_ETH] Move ethernet register definitions into private header

2007-10-19 Thread Dale Farnsworth
On Fri, Oct 19, 2007 at 01:09:57PM +0200, Lennert Buytenhek wrote: On Fri, Oct 19, 2007 at 09:30:48AM +0100, Christoph Hellwig wrote: Isn't it a little too confusing to have two headers with the same name, one in drivers/net and one in include/linux? Perhaps we can fold the drivers/net one

Re: [PATCH,RFC] Marvell Orion SoC ethernet driver

2007-10-17 Thread Dale Farnsworth
In article [EMAIL PROTECTED] you write: Interesting. After some asking around, it appears that the mv643xx ethernet silicon block is indeed very similar to the ethernet silicon block found the in Orion ARM SoCs. We'll work on getting Orion to use mv643xx_eth. Thanks for pointing this out.

[PATCH] mv643xx_eth: Do not modify struct netdev tx_queue_len

2007-10-01 Thread Dale Farnsworth
From: Dale Farnsworth [EMAIL PROTECTED] This driver erroneously zeros dev-tx_queue_len, since mp-tx_ring_size has not yet been initialized. Actually, the driver shouldn't modify tx_queue_len at all and should leave the value set by alloc_etherdev(), currently 1000. Signed-off-by: Dale

[PATCH] mv643xx_eth: Check ETH_INT_CAUSE_STATE bit

2007-09-28 Thread Dale Farnsworth
-by: Martyn Welch [EMAIL PROTECTED] Signed-off-by: Dale Farnsworth [EMAIL PROTECTED] --- Jeff, this is a bug fix. drivers/net/mv643xx_eth.c |2 +- drivers/net/mv643xx_eth.h |4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/mv643xx_eth.c b/drivers/net

[PATCH] mv643xx_eth: Fix tx_bytes stats calculation

2007-09-14 Thread Dale Farnsworth
Reported by Corey Minyard [EMAIL PROTECTED] --- drivers/net/mv643xx_eth.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mv643xx_eth.c b/drivers/net/mv643xx_eth.c index 1799eee..6a117e9 100644 --- a/drivers/net/mv643xx_eth.c +++ b/drivers/net/mv643xx_eth.c @@

Re: kernel crashes inside MV643xx driver

2007-09-05 Thread Dale Farnsworth
On Wed, Sep 05, 2007 at 08:24:52AM -0700, Andrew Morton wrote: On Mon, 20 Aug 2007 14:38:57 +0800 gshan [EMAIL PROTECTED] wrote: Hi All, After I started the NFS server, it crashed: 3Badness in local_bh_enable at

Re: [PATCH] Merge GT/MV642xx Support into MV643xx Driver [5/8]

2007-07-19 Thread Dale Farnsworth
On Thu, Jul 19, 2007 at 04:54:45AM +, Steven J. Hill wrote: Fix 'mv643xx_eth_tx_timeout_task' function prototype. Signed-off-by: Steven J. Hill [EMAIL PROTECTED] --- --- linux-2.6.22.1/drivers/net/mv643xx_eth.c 2007-07-18 21:45:13.0 -0500 +++

Re: [PATCH] Merge GT/MV642xx Support into MV643xx Driver [4/8]

2007-07-19 Thread Dale Farnsworth
On Thu, Jul 19, 2007 at 04:53:31AM +, Steven J. Hill wrote: Add main 642xx support to 'drivers/net/mv643xx_eth.c' file. As Christoph said, this quantity of ifdefs really hurt the maintainability. Refactoring is needed. Also, since in arch/powerpc we want to have a single kernel support

Re: [PATCH] Merge GT/MV642xx Support into MV643xx Driver [6/8]

2007-07-19 Thread Dale Farnsworth
On Thu, Jul 19, 2007 at 04:55:36AM +, Steven J. Hill wrote: Fix the TX bytes statistics counter to, um, actually count. Signed-off-by: Steven J. Hill [EMAIL PROTECTED] --- --- linux-2.6.22.1/drivers/net/mv643xx_eth.c 2007-07-18 21:51:49.0 -0500 +++

Re: [PATCH] Merge GT/MV642xx Support into MV643xx Driver [7/8]

2007-07-19 Thread Dale Farnsworth
On Thu, Jul 19, 2007 at 04:56:51AM +, Steven J. Hill wrote: Get rid of global PHY spinlock. You have replaced the use of the global PHY spinlock with a per-port spinlock. However, the SMI register is shared by all ports. The global lock is needed to prevent simultaneous updates of the

Re: [PATCH] Merge GT/MV642xx Support into MV643xx Driver [8/8]

2007-07-19 Thread Dale Farnsworth
On Thu, Jul 19, 2007 at 05:02:04AM +, Steven J. Hill wrote: Fix long standing panic with regards to descriptors and locking. Signed-off-by: Steven J. Hill [EMAIL PROTECTED] --- diff -ur linux-2.6.22.1/drivers/net/mv643xx_eth.c linux-2.6.22.1-rci/drivers/net/mv643xx_eth.c ---

Re: [PATCH] Merge GT/MV642xx Support into MV643xx Driver [7/8]

2007-07-19 Thread Dale Farnsworth
On Thu, Jul 19, 2007 at 09:10:26PM -0500, Steven J. Hill wrote: Dale Farnsworth wrote: You have replaced the use of the global PHY spinlock with a per-port spinlock. However, the SMI register is shared by all ports. The global lock is needed to prevent simultaneous updates

Re: [PATCH 2/5 2.6.21-rc7] l2tp: pppol2tp changes to existing ppp kernel headers

2007-04-23 Thread Dale Farnsworth
sockaddr_pppox for binary compatibility. Also add an ioctl to allow userspace to obtain L2TP counters and state from the kernel. In my opinion, the above info is sufficiently useful to be included commit comments. -Dale Farnsworth - To unsubscribe from this list: send the line unsubscribe netdev

Re: [PATCH] Fix use of uninitialized field in mv643xx_eth

2007-03-23 Thread Dale Farnsworth
On Fri, Mar 23, 2007 at 01:30:02PM +0100, Gabriel Paubert wrote: In this driver, the default ethernet address is first set by by calling eth_port_uc_addr_get() which reads the relevant registers of the corresponding port as initially set by firmware. However that function used the port_num

[PATCH 1/2] mv643xx_eth: Fix use of uninitialized port_num field

2007-03-23 Thread Dale Farnsworth
-port_num prior to calling eth_port_uc_get_addr(). Signed-off-by: Gabriel Paubert [EMAIL PROTECTED] Signed-off-by: Dale Farnsworth [EMAIL PROTECTED] --- This fixes a serious bug and should expeditiously pushed upstream. drivers/net/mv643xx_eth.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions

[PATCH 2/2] mv643xx_eth: make eth_port_uc_addr_{get,set}() calls symmetric

2007-03-23 Thread Dale Farnsworth
-by: Dale Farnsworth [EMAIL PROTECTED] --- This is a clean-up patch that needn't be rushed upstream. -Dale drivers/net/mv643xx_eth.c | 59 +++- drivers/net/mv643xx_eth.h |4 -- 2 files changed, 13 insertions(+), 50 deletions(-) diff --git a/drivers/net

[PATCH] mv643xx_eth: add mv643xx_eth_shutdown function

2007-03-20 Thread Dale Farnsworth
From: Dale Farnsworth [EMAIL PROTECTED] mv643xx_eth_shutdown is needed for kexec. Signed-off-by: Dale Farnsworth [EMAIL PROTECTED] --- drivers/net/mv643xx_eth.c | 14 ++ 1 file changed, 14 insertions(+) Index: linux-2.6-powerpc-df/drivers/net/mv643xx_eth.c

[PATCH] mv643xx: Clear pending interrupts before calling request_irq

2007-03-07 Thread Dale Farnsworth
From: Dale Farnsworth [EMAIL PROTECTED] Signed-off-by: Dale Farnsworth [EMAIL PROTECTED] Acked-by: Giridhar Pemmasani [EMAIL PROTECTED] --- Giri, thank you very much for reporting the problem and confirming the fix. Jeff, please apply. Andrew, this patch supersedes the -mm patch

Re: [patch 18/19] mv643xx ethernet driver IRQ registration fix

2007-03-06 Thread Dale Farnsworth
On Tue, Mar 06, 2007 at 02:42:02AM -0800, [EMAIL PROTECTED] wrote: From: Giridhar Pemmasani [EMAIL PROTECTED] During initialization, mv643xx driver registers IRQ before setting up tx/rx rings. This causes kernel oops because mv643xx_poll, which gets called right after registering IRQ, calls

[PATCH 1/2] mv643xx_eth: move mac_addr inside mv643xx_eth_platform_data

2007-03-01 Thread Dale Farnsworth
The information contained within platform_data should be self-contained. Replace the pointer to a MAC address with the actual MAC address in struct mv643xx_eth_platform_data. Signed-off-by: Dale Farnsworth [EMAIL PROTECTED] --- Replaced explicit mac address comparison with a call

[PATCH 2/2] mv643xx_eth: Place explicit port number in mv643xx_eth_platform_data

2007-03-01 Thread Dale Farnsworth
mv643xx_eth_platform_data. This makes the mv643xx_eth_platform_data structure required, but that isn't an issue since all users currently provide it already. Signed-off-by: Dale Farnsworth [EMAIL PROTECTED] --- arch/mips/momentum/jaguar_atx/platform.c |8 ++ arch/mips/momentum/ocelot_3

[PATCH 1/2] mv643xx_eth: move mac_addr inside of mv643xx_eth_platform_data

2007-02-28 Thread Dale Farnsworth
The information contained within platform_data should be self-contained. Replace the pointer to a MAC address with the actual MAC address in struct mv643xx_eth_platform_data. Signed-off-by: Dale Farnsworth [EMAIL PROTECTED] Index: b/drivers/net/mv643xx_eth.c

Re: [PATCH 2/2] mv643xx_eth: Place explicit port number in mv643xx_eth_platform_data

2007-02-28 Thread Dale Farnsworth
mv643xx_eth_platform_data. This makes the mv643xx_eth_platform_data structure required, but that isn't an issue since all users currently provide it already. Signed-off-by: Dale Farnsworth [EMAIL PROTECTED] diff --git a/arch/mips/momentum/jaguar_atx/platform.c b/arch/mips/momentum/jaguar_atx

Re: [PATCH 1/2] mv643xx_eth: move mac_addr inside of mv643xx_eth_platform_data

2007-02-28 Thread Dale Farnsworth
On Wed, Feb 28, 2007 at 03:11:03PM -0800, Stephen Hemminger wrote: On Wed, 28 Feb 2007 15:40:31 -0700 Dale Farnsworth [EMAIL PROTECTED] wrote: The information contained within platform_data should be self-contained. Replace the pointer to a MAC address with the actual MAC address

Re: [RFC][NET] Alignment in mv643xx_eth

2007-02-26 Thread Dale Farnsworth
reason why we're not using dma_get_cache_alignment() instead? Not that I can think of. ACK. Dale Farnsworth - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] Eliminate user-selectable CONFIG_MV643XX_ETH_[012]

2007-02-20 Thread Dale Farnsworth
From: Dale Farnsworth [EMAIL PROTECTED] Remove the use of CONFIG_MV643XX_ETH_[012] variables on most platforms. Instead, platform-specific code enables the ports supported by the hardware. After this patch, these config variables are only used in arch/ppc, so also move them from drivers/net

[PATCH] mv643xx_eth: Fix race condition in mv643xx_eth_free_tx_descs

2007-01-23 Thread Dale Farnsworth
From Dale Farnsworth [EMAIL PROTECTED] mv643xx_eth: Fix race condition in mv643xx_eth_free_tx_descs This bug was found and isolated by Thibaut VARENE [EMAIL PROTECTED] and Jarek Poplawski [EMAIL PROTECTED]. This patch is a modification of their fixes. We acquire and release the lock for each

Re: [PATCH] Re: kernel BUG in eth_alloc_tx_desc_index at drivers/net/mv643xx_eth.c:1069!

2007-01-22 Thread Dale Farnsworth
Jarek and Thibaut, Thank you both very much for your work finding and fixing this bug. Jarek, can you verify that the following patch fixes the problem you were seeing? -Dale - Patch follows - From: Dale Farnsworth [EMAIL PROTECTED] mv643xx_eth: Fix race condition

Re: kernel BUG in eth_alloc_tx_desc_index at drivers/net/mv643xx_eth.c:1069!

2007-01-09 Thread Dale Farnsworth
passed thorough tests. Finally, using the other NIC on the box (a VIA Rhine II, 100Mbps), works absolutely fine. If you are not tired, I'd suggest two more tests: I volunteered to help :) Thank you Thibaut. Please try the following patch: From: Dale Farnsworth [EMAIL PROTECTED] Reserve

Re: [PATCH] mv643xx add missing brackets

2006-11-30 Thread Dale Farnsworth
On Thu, Nov 30, 2006 at 10:35:37AM +0100, Mariusz Kozlowski wrote: Hello, This patch adds missing brackets. Signed-off-by: Mariusz Kozlowski [EMAIL PROTECTED] include/linux/mv643xx.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ---

[PATCH] mv643xx_eth: fix unbalanced parentheses in macros

2006-11-30 Thread Dale Farnsworth
From: Mariusz Kozlowski [EMAIL PROTECTED] Signed-off-by: Mariusz Kozlowski [EMAIL PROTECTED] Signed-off-by: Dale Farnsworth [EMAIL PROTECTED] --- include/linux/mv643xx.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- linux-2.6.19-rc6-mm2-a/include/linux/mv643xx.h 2006-11

Re: [RFT] mv643xxx_eth_start_xmit oops

2006-11-10 Thread Dale Farnsworth
In article [EMAIL PROTECTED] you write: Ueimor [EMAIL PROTECTED] wrote: Stephen Hemminger [EMAIL PROTECTED] : [...] diff --git a/drivers/net/mv643xx_eth.c b/drivers/net/mv643xx_eth.c [...] It seems to propagate a leak from the initial codebase. Can you provide more detail about the leak?

[PATCH] mv643xx_eth: Fix ethtool stats

2006-10-03 Thread Dale Farnsworth
From: Maxime Bizon [EMAIL PROTECTED] Some stats reported by ethtool -S on mv643xx_eth device are cleared between each call. This patch fixes it. Signed-off-by: Maxime Bizon [EMAIL PROTECTED] Signed-off-by: Dale Farnsworth [EMAIL PROTECTED] --- Thanks Maxime. --- linux-2.6.18/drivers/net

[PATCH 1/2] mv643xx_eth: restrict to 32-bit PPC_MULTIPLATFORM

2006-09-20 Thread Dale Farnsworth
From: Dale Farnsworth [EMAIL PROTECTED] No 64-bit PPC_MULTIPLATFORM platforms use the mv643xx_eth driver, so build it only on PPC32. Signed-off-by: Dale Farnsworth [EMAIL PROTECTED] Acked-by: Sven Luther [EMAIL PROTECTED] diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index a2bd811

[PATCH 2/2] mv643xx_eth: Fix typo: RX_SKB_SIZE == ETH_RX_SKB_SIZE

2006-09-20 Thread Dale Farnsworth
From: Dale Farnsworth [EMAIL PROTECTED] Bug was introduced in commit 71d28725548be203e8b8f6ad63b1f64fd7f02d4d. How embarrassing. It wasn't caught because dma_umap_single() is defined away on arch/ppc and 32-bit arch/powerpc. Signed-off-by: Dale Farnsworth [EMAIL PROTECTED] --- Arggh

PATCH mv643xx_eth: Unmap DMA buffers in receive path

2006-09-13 Thread Dale Farnsworth
From: Dale Farnsworth [EMAIL PROTECTED] Fix a missing call to dma_unmap_single() in the receive path. Without this call, errors have been observed on non-cache-coherent systems. Signed-off-by Dale Farnsworth [EMAIL PROTECTED] --- ACK, but error: patch failed: drivers/net/mv643xx_eth.c:402

mv643xx_eth: Unmap DMA buffers in receive path

2006-09-12 Thread Dale Farnsworth
From: Dale Farnsworth [EMAIL PROTECTED] Fix a missing call to dma_unmap_single() in the receive path. Without this call, errors have been observed on non-cache-coherent systems. Signed-off-by Dale Farnsworth [EMAIL PROTECTED] --- drivers/net/mv643xx_eth.c |2 ++ 1 file changed, 2

Re: Bug report for MV643XX driver

2006-08-09 Thread Dale Farnsworth
On Wed, Aug 09, 2006 at 10:47:28AM -0400, Stuart Peloquin wrote: Kernel oops during heavy load downloads with the MV643XX driver on a PegII. I've replicated the problem on 2.6.17_gentoo-4, vanilla 2.6.17.1, vanilla 2.6.18_rc3. When downloading a large file from any fast mirror (I tested

Re: Bug report for MV643XX driver

2006-08-09 Thread Dale Farnsworth
On Wed, Aug 09, 2006 at 12:53:27PM -0400, Stuart Peloquin wrote: Hi Dale, Thank you for responding quickly. This is with gcc 4.1.1 and the config file has been added to the web directory at http://web.mit.edu/peloquin/marvell/ Please let me know if I can provide anything else. Can

[PATCH 2/2] mv643xx_eth: Fix tx_timeout to only conditionally wake tx queue

2006-04-11 Thread Dale Farnsworth
From: Dale Farnsworth [EMAIL PROTECTED] After resetting the hardware on a tx_timeout, call netif_wake_queue() only if we have free tx descriptors. Also, attempt to recover if mv643xx_eth_start_xmit() is called when there are fewer free tx descriptors than expected. The BUG_ON() call we

[PATCH 1/2] mv643xx_eth: Always free completed tx descs on tx interrupt

2006-04-05 Thread Dale Farnsworth
] Signed-off-by: Dale Farnsworth [EMAIL PROTECTED] --- drivers/net/mv643xx_eth.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: current/drivers/net/mv643xx_eth.c === --- current/drivers/net/mv643xx_eth.c (revision 51

[PATCH 2/2] mv643xx_eth: Fix tx_timeout to only conditionally wake tx queue

2006-04-05 Thread Dale Farnsworth
From: Dale Farnsworth [EMAIL PROTECTED] After resetting the hardware on a tx_timeout, call netif_wake_queue() only if we have free tx descriptors. Also, attempt to recover if mv643xx_eth_start_xmit() is called when there are fewer free tx descriptors than expected. The BUG_ON() call we

[Patch] mv643xx_eth: Cache align skb-data if CONFIG_NOT_COHERENT_CACHE

2006-03-21 Thread Dale Farnsworth
From: Dale Farnsworth [EMAIL PROTECTED] When I/O is non-cache-coherent, we need to ensure that the I/O buffers we use don't share cache lines with other data. Signed-off-by: Dale Farnsworth [EMAIL PROTECTED] --- This patch fixes red zone error messages that appear when CONFIG_SLAB_DEBUG=y

[Patch 00/10] mv643xx_eth: patches for post 2.6.16 -- 2005-03-03

2006-03-03 Thread Dale Farnsworth
06 Refactor/clean up tx queue handling 07 Move #defines of constants to mv643xx_eth.h 08 Clean up interrupt handling 09 Remove non-working feature: task level rx queue refill 10 Remove BIT0-BIT31 #defines Thanks, Dale Farnsworth - To unsubscribe from this list: send the line unsubscribe

[Patch 09/10] mv643xx_eth: Remove non-working feature: task level rx queue refill

2006-03-03 Thread Dale Farnsworth
From: Dale Farnsworth [EMAIL PROTECTED] The task level rx queue refill feature hasn't ever worked (at least in 2.6) and is of dubious value. Remove it. Signed-off-by: Dale Farnsworth [EMAIL PROTECTED] --- drivers/net/mv643xx_eth.c | 59 +++- drivers/net

[Patch 01/11] mv643xx_eth: Fix spinlock recursion bug

2006-01-27 Thread Dale Farnsworth
From: Dale Farnsworth [EMAIL PROTECTED] This patch eliminates a spinlock recursion bug introduced recently. Since eth_port_send() is always called with the lock held, we simply remove the locking inside the function itself. Signed-off-by: Dale Farnsworth [EMAIL PROTECTED] --- drivers/net

[Patch 00/11] mv643xx_eth: patch series of 2005-01-27

2006-01-27 Thread Dale Farnsworth
enable/disable code consistent cleanup 09 mv643xx: use MII library for PHY management feature 10 mv643xx: use MII library for ethtool functions feature 11 Clean up platform_data configuration cleanup Please apply. Thanks, Dale Farnsworth

[Patch 05/11] mv643xx_eth: Remove needless mp-port_mac_addr

2006-01-27 Thread Dale Farnsworth
From: Dale Farnsworth [EMAIL PROTECTED] mp-port_mac_addr is just a redundant copy of dev-dev_addr, so remove it. Signed-off-by: Dale Farnsworth [EMAIL PROTECTED] --- drivers/net/mv643xx_eth.c | 18 +++--- drivers/net/mv643xx_eth.h |3 +-- 2 files changed, 8 insertions(+), 13

[Patch 04/11] mv643xx_eth: Fix for building as a module

2006-01-27 Thread Dale Farnsworth
From: Dale Farnsworth [EMAIL PROTECTED] Enable mv643xx_eth driver to work when built as a module on mv64x60-based embedded systems. Signed-off-by: Dale Farnsworth [EMAIL PROTECTED] --- arch/ppc/syslib/mv64x60.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: linux-2.6

[Patch 02/11] mv643xx_eth: Update dev-last_rx on packet receive

2006-01-27 Thread Dale Farnsworth
From: Paolo Galtieri [EMAIL PROTECTED] Update dev-last_rx on packet receive This fix corrects errors seen during configuration of the bonding driver. Signed-off-by: Paolo Galtieri [EMAIL PROTECTED] Signed-off-by: Dale Farnsworth [EMAIL PROTECTED] --- drivers/net/mv643xx_eth.c |1 + 1 file

[Patch 06/11] mv643xx_eth: Merge unicast and multicast address filtering code

2006-01-27 Thread Dale Farnsworth
From: Dale Farnsworth [EMAIL PROTECTED] Remove duplicated code by having unicast and multicast code use a common filter table function: eth_port_set_filter_table_entry(). Signed-off-by: Dale Farnsworth [EMAIL PROTECTED] --- drivers/net/mv643xx_eth.c | 84

[Patch 07/11] mv643xx_eth: Rename mp-tx_ring_skbs to mp-tx_desc_count

2006-01-27 Thread Dale Farnsworth
From: Dale Farnsworth [EMAIL PROTECTED] tx_ring_skbs is actually a count of tx descriptors currently in use. Since there may be multiple descriptors per skb, it is not the same as the number of skbs in the ring. Also change rx_ring_skbs to rx_desc_count to be consistent. Signed-off-by: Dale

[Patch 08/11] mv643xx_eth: Make port queue enable/disable code consistent

2006-01-27 Thread Dale Farnsworth
From: Dale Farnsworth [EMAIL PROTECTED] Add and use the following functions: mv643xx_eth_port_enable_tx() mv643xx_eth_port_enable_rx() mv643xx_eth_port_disable_tx() mv643xx_eth_port_disable_rx() so that ports are enabled/disabled consistently. Signed-off-by: Dale

[Patch 09/11] mv643xx_eth: use MII library for PHY management

2006-01-27 Thread Dale Farnsworth
local driver support code. It is also useful to make the actual MII registers available to the user with maskable kernel printk messages so the MII registers are being read anyway Signed-off-by: James Chapman [EMAIL PROTECTED] Signed-off-by: Dale Farnsworth [EMAIL PROTECTED] --- drivers/net

[Patch 11/11] mv643xx_eth: Clean up platform_data configuration

2006-01-27 Thread Dale Farnsworth
From: Dale Farnsworth [EMAIL PROTECTED] We shouldn't expose the hardware register contents in platform_data. The only things we allow the user to configure are autoneg, speed, and duplex. Add specific platform_data fields for these values and remove the registers configs. Signed-off-by: Dale

[Patch 10/11] mv643xx_eth: use MII library for ethtool functions

2006-01-27 Thread Dale Farnsworth
From: James Chapman [EMAIL PROTECTED] Use the common ethtool support functions of the MII library. Add generic MII ioctl handler. Add PHY parameter speed/duplex/negotiation initialization and modification. Signed-off-by: James Chapman [EMAIL PROTECTED] Signed-off-by: Dale Farnsworth [EMAIL

Re: [Patch 00/11] mv643xx_eth: patch series of 2005-01-27

2006-01-27 Thread Dale Farnsworth
On Fri, Jan 27, 2006 at 10:32:31AM -0500, Jeff Garzik wrote: Dale Farnsworth wrote: I'll followup to this posting with the latest mv643xx_eth patches: 01 Fix spinlock recursion bug bug fix 02 Update dev-last_rx on packet receivebug fix

Re: [Patch 7/7] mv643xx_eth: use MII library for ethtool functions

2006-01-24 Thread Dale Farnsworth
On Fri, Jan 20, 2006 at 05:06:09PM -0700, I wrote: Use the common ethtool support functions of the MII library. Add generic MII ioctl handler. Add PHY parameter speed/duplex/negotiation initialization and modification. I've seen a couple of unexplained network failures with this patch (7/7),

[Patch 1/7] mv643xx_eth: Fix spinlock recursion bug

2006-01-20 Thread Dale Farnsworth
From: Dale Farnsworth [EMAIL PROTECTED] This patch eliminates a spinlock recursion bug I introduced recently. Since eth_port_send() is always called with the lock held, we simply remove the locking inside the function itself. Signed-off-by: Dale Farnsworth [EMAIL PROTECTED] drivers/net

Re: [Patch 2/7] mv643xx_eth: whitespace cleanup

2006-01-20 Thread Dale Farnsworth
From: Dale Farnsworth [EMAIL PROTECTED] Signed-off-by: Dale Farnsworth [EMAIL PROTECTED] drivers/net/mv643xx_eth.c | 92 ++ 1 file changed, 45 insertions(+), 47 deletions(-) Index: linux-2.6-mv643xx_enet/drivers/net/mv643xx_eth.c

[Patch 3/7] mv643xx_eth: fix for building as a module

2006-01-20 Thread Dale Farnsworth
From: Dale Farnsworth [EMAIL PROTECTED] Enable mv643xx_eth driver to work when built as a module on mv64x60-based embedded systems. Signed-off-by: Dale Farnsworth [EMAIL PROTECTED] arch/ppc/syslib/mv64x60.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: linux-2.6

[Patch 6/7] mv643xx_eth: use MII library for PHY management

2006-01-20 Thread Dale Farnsworth
local driver support code. It is also useful to make the actual MII registers available to the user with maskable kernel printk messages so the MII registers are being read anyway Signed-off-by: James Chapman [EMAIL PROTECTED] Acked-by: Dale Farnsworth [EMAIL PROTECTED] drivers/net/mv643xx_eth.c

[Patch 7/7] mv643xx_eth: use MII library for ethtool functions

2006-01-20 Thread Dale Farnsworth
From: James Chapman [EMAIL PROTECTED] Use the common ethtool support functions of the MII library. Add generic MII ioctl handler. Add PHY parameter speed/duplex/negotiation initialization and modification. Signed-off-by: James Chapman [EMAIL PROTECTED] Signed-off-by: Dale Farnsworth [EMAIL

Re: [Patch 09/13] mv643xx_eth: Hold spinlocks only where needed

2006-01-18 Thread Dale Farnsworth
On Wed, Jan 18, 2006 at 04:26:00PM +0100, Olaf Hering wrote: On Mon, Jan 16, Dale Farnsworth wrote: This driver has historically held a spin_lock during the entire open and stop functions and while receiving multiple packets. This is unecessarily long and holds locks during calls

Re: [Patch 09/13] mv643xx_eth: Hold spinlocks only where needed

2006-01-18 Thread Dale Farnsworth
, dhcpcd/2844 lock: dd96f148, .magic: dead4ead, .owner: dhcpcd/2844, .owner_cpu:0 BUG: spinlock lockup on CPU#0, dhcpdcd/2844, dd96f148 Olaf, would you please try the patch below. It works for me. Thanks, -Dale From: Dale Farnsworth [EMAIL PROTECTED] This patch eliminates a spinlock recursion

[Patch 00/13] mv643xx_eth: Bug Fixes

2006-01-16 Thread Dale Farnsworth
This patch series for the Marvell mv643xx ethernet controller contains primarily bug fixes. 1. Add Dale Farnsworth as a maintainer 2. 2.6.16 needs ip.h and in.h Bug fix, from Olaf Hering [EMAIL PROTECTED] 3. Fix dma_map/dma_unmap relations Bug fix, from Paolo Galtieri [EMAIL

[Patch 02/13] mv643xx_eth: 2.6.16 needs ip.h and in.h

2006-01-16 Thread Dale Farnsworth
From: Olaf Hering [EMAIL PROTECTED] Signed-off-by: Olaf Hering [EMAIL PROTECTED] Signed-off-by: Dale Farnsworth [EMAIL PROTECTED] mv643xx_eth.c |2 ++ 1 file changed, 2 insertions(+) Index: linux-2.6-mv643xx_enet/drivers/net/mv643xx_eth.c

[Patch 03/13] mv643xx_eth: Fix dma_map/dma_unmap relations

2006-01-16 Thread Dale Farnsworth
From: Paolo Galtieri [EMAIL PROTECTED] If you do a dma_map_single you must do dma_unmap_single and if you do a dma_map_page you must do a dma_unmap_page. Signed-off-by: Paolo Galtieri [EMAIL PROTECTED] Signed-off-by: Dale Farnsworth [EMAIL PROTECTED] mv643xx_eth.c | 51

[Patch 05/13] mv643xx_eth: Add multicast support

2006-01-16 Thread Dale Farnsworth
From: Dale Farnsworth [EMAIL PROTECTED] This code is adapted from code in a ppc-specific version of the driver. Signed-off-by: Dale Farnsworth [EMAIL PROTECTED] mv643xx_eth.c | 201 -- 1 file changed, 197 insertions(+), 4 deletions

[Patch 06/13] mv643xx_eth: Receive buffers require 8 byte alignment

2006-01-16 Thread Dale Farnsworth
From: Dale Farnsworth [EMAIL PROTECTED] The Marvell mv643xx ethernet hardware requires that DMA buffers be aligned to 8-byte boundaries. This patch satisfies this requirement. Buffers allocated by dev_alloc_skb() only have 4-byte alignment when slab debugging is enabled. Also, document

[Patch 07/13] mv643xx_eth: Fix handling of small, unaligned fragments

2006-01-16 Thread Dale Farnsworth
From: Paul Janzen [EMAIL PROTECTED] Fix handling of small, unaligned fragments. It also solves a potential deadlock if skb_linearize() returns -ENOMEM. Signed-off-by: Paul Janzen [EMAIL PROTECTED] Signed-off-by: Dale Farnsworth [EMAIL PROTECTED] mv643xx_eth.c | 54

[Patch 08/13] mv643xx_eth: iounmap the correct SRAM buffer

2006-01-16 Thread Dale Farnsworth
From: Dale Farnsworth [EMAIL PROTECTED] Signed-off-by: Dale Farnsworth [EMAIL PROTECTED] mv643xx_eth.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6-mv643xx_enet/drivers/net/mv643xx_eth.c === --- linux

[Patch 09/13] mv643xx_eth: Hold spinlocks only where needed

2006-01-16 Thread Dale Farnsworth
From: Dale Farnsworth [EMAIL PROTECTED] This driver has historically held a spin_lock during the entire open and stop functions and while receiving multiple packets. This is unecessarily long and holds locks during calls that may sleep. This patch reduces the size of windows where locks are held

[Patch 10/13] mv643xx_eth: Request HW checksum generation only for IPv4

2006-01-16 Thread Dale Farnsworth
skb-iph for non-ipv4-packets. Signed-off-by: Wolfram Joost [EMAIL PROTECTED] Signed-off-by: Dale Farnsworth [EMAIL PROTECTED] mv643xx_eth.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) Index: linux-2.6-mv643xx_enet/drivers/net/mv643xx_eth.c

[Patch 11/13] mv643xx_eth: Fix transmit skb accounting

2006-01-16 Thread Dale Farnsworth
From: Dale Farnsworth [EMAIL PROTECTED] Signed-off-by: Dale Farnsworth [EMAIL PROTECTED] mv643xx_eth.c |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) Index: linux-2.6-mv643xx_enet/drivers/net/mv643xx_eth.c

[Patch 12/13] mv643xx_eth: Merge open and stop helper functions

2006-01-16 Thread Dale Farnsworth
From: Dale Farnsworth [EMAIL PROTECTED] Move code from helper functions mv643xx_eth_real_open and mv643xx_eth_real_stop as they are no longer needed. Signed-off-by Dale Farnsworth [EMAIL PROTECTED] mv643xx_eth.c | 109 +++--- 1 file changed

[Patch 13/13] mv643xx_eth: Remove needless mask of extended intr register

2006-01-16 Thread Dale Farnsworth
From: Dale Farnsworth [EMAIL PROTECTED] All interrupts controlled by the extended mask register are also masked by a bit in the main mask register, so there is no need to directly manipulate the extended mask register. Signed-off-by: Dale Farnsworth [EMAIL PROTECTED] mv643xx_eth.c | 81

Re: [PATCH] Re: mv643xx_eth_start_xmit: calls skb_linearize with interrupts off

2006-01-13 Thread Dale Farnsworth
On Mon, Jan 09, 2006 at 04:43:08AM +, Paul Janzen wrote: Paul Janzen [EMAIL PROTECTED] writes: In mv643xx_eth_start_xmit: [...] spin_lock_irqsave(mp-lock, flags); [...] /* Since hardware can't handle unaligned fragments smaller * than 9 bytes, if we

[PATCH 1/4] mv643xx: Fix dma_map/dma_unmap calls

2005-12-28 Thread Dale Farnsworth
and byte_cnt fields of the pkt_info structure were not filled in by eth_tx_return_desc(). Signed-off-by: Paolo Galtieri [EMAIL PROTECTED] Signed-off-by: Dale Farnsworth [EMAIL PROTECTED] Index: linux-2.6-mv643xx_enet/drivers/net/mv643xx_eth.c

[PATCH 3/4] mv643xx: Align receive DMA buffers

2005-12-28 Thread Dale Farnsworth
From: Dale Farnsworth [EMAIL PROTECTED] The Marvell mv643xx ethernet hardware requires that DMA buffers be aligned to 8-byte boundaries. This patch satisfies this requirement. Buffers allocated by dev_alloc_skb() only have 4-byte alignment when slab debugging is enabled. Also, document

Re: [PATCH] gianfar: add netpoll api support

2005-12-12 Thread Dale Farnsworth
In article [EMAIL PROTECTED] you write: On Mon, Dec 12, 2005 at 11:54:06AM -0700, Dale Farnsworth wrote: +#ifdef CONFIG_NET_POLL_CONTROLLER +/* + * Polling - used by netconsole and other diagnostic tools + * to allow network i/o with interrupts disabled. + */ +static void

Re: [PATCH] gianfar: add netpoll api support

2005-12-12 Thread Dale Farnsworth
On Tue, Dec 13, 2005 at 12:43:28AM +, Andy Fleming wrote: On Mon, Dec 12, 2005 at 11:54:06AM -0700, Dale Farnsworth wrote: +#ifdef CONFIG_NET_POLL_CONTROLLER +/* + * Polling - used by netconsole and other diagnostic tools + * to allow network i/o with interrupts disabled. + */ +static

[PATCH] mv643xx: Disable per port bandwidth limits

2005-09-02 Thread Dale Farnsworth
The mv643xx chips support per port bandwith limits. This patch disables the bandwidth limits by clearing the MTU register. Signed-off-by: Dale Farnsworth [EMAIL PROTECTED] Index: linux-2.6.13-mm1-mv643xx-enet/drivers/net/mv643xx_eth.c

[PATCH] mv643xx: add netpoll api support

2005-09-02 Thread Dale Farnsworth
Add support for the netpoll api for use by netconsole, kgdb, etc. Signed-off-by: Dale Farnsworth [EMAIL PROTECTED] Index: linux-2.6.13-mm1-mv643xx-enet/drivers/net/mv643xx_eth.c === --- linux-2.6.13-mm1-mv643xx-enet.orig/drivers/net

[PATCH] mv643xx: fix skb memory leak

2005-09-01 Thread Dale Farnsworth
This patch fixes an skb memory leak under heavy receive load (whenever the more packets have been received than the NAPI budget allows to be processed). Signed-off-by: Dale Farnsworth [EMAIL PROTECTED] Index: linux-2.6.13-rc6-mm2-mv643xx-enet/drivers/net/mv643xx_eth.c