Re: [PATCH net] openvswitch: Fix push/pop ethernet validation

2018-10-31 Thread Gregory Rose
On 10/31/2018 10:52 AM, Jaime Caamaño Ruiz wrote: When there are both pop and push ethernet header actions among the actions to be applied to a packet, an unexpected EINVAL (Invalid argument) error is obtained. This is due to mac_proto not being reset correctly when those actions are validated.

Re: [PATCH net-next] net: ip6_gre: get ipv6hdr after skb_cow_head()

2018-07-13 Thread Gregory Rose
On 7/12/2018 10:40 PM, Prashant Bhole wrote: A KASAN:use-after-free bug was found related to ip6-erspan while running selftests/net/ip6_gre_headroom.sh It happens because of following sequence: - ipv6hdr pointer is obtained from skb - skb_cow_head() is called, skb->head memory is reallocated -

Re: [ovs-dev] [PATCH] openvswitch: make vport_ops:send()'s return type consistent

2018-05-07 Thread Gregory Rose
On 4/24/2018 6:19 AM, Luc Van Oostenryck wrote: The method struct vport_ops:send() is defined as returning an 'netdev_tx_t', which is defined as a typedef for a bitwise type and otherwise used for the start_xmit() methods. However, most openvswitch drivers use for this method dev_queue_xmit()

Re: [ovs-dev] [PATCH] openvswitch: fix internal_dev_xmit()'s return type

2018-05-07 Thread Gregory Rose
On 4/24/2018 6:17 AM, Luc Van Oostenryck wrote: The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van

Re: [pci PATCH v8 2/4] ena: Migrate over to unmanaged SR-IOV support

2018-04-20 Thread Gregory Rose
On 4/20/2018 9:30 AM, Alexander Duyck wrote: Instead of implementing our own version of a SR-IOV configuration stub in the ena driver we can just reuse the existing pci_sriov_configure_simple function. Signed-off-by: Alexander Duyck --- v5: Replaced call to

Re: [pci PATCH v8 4/4] pci-pf-stub: Add PF driver stub for PFs that function only to enable VFs

2018-04-20 Thread Gregory Rose
On 4/20/2018 9:31 AM, Alexander Duyck wrote: Add a new driver called "pci-pf-stub" to act as a "white-list" for PF devices that provide no other functionality other then acting as a means of allocating a set of VFs. For now I only have one example ID provided by Amazon in terms of devices that

Re: [pci PATCH v8 1/4] pci: Add pci_sriov_configure_simple for PFs that don't manage VF resources

2018-04-20 Thread Gregory Rose
On 4/20/2018 9:28 AM, Alexander Duyck wrote: This patch adds a common configuration function called pci_sriov_configure_simple that will allow for managing VFs on devices where the PF is not capable of managing VF resources. Signed-off-by: Alexander Duyck

Re: [PATCH net-next 2/2] openvswitch: Support conntrack zone limit

2018-04-18 Thread Gregory Rose
On 4/17/2018 5:30 PM, Yi-Hung Wei wrote: s/to commit/from committing/ s/entry/entries/ Thanks, will fix that in both patches in v2. I think this is a great idea but I suggest porting to the iproute2 package so everyone can use it. Then git rid of the OVS specific prefixes. Presuming of

Re: [PATCH net-next 2/2] openvswitch: Support conntrack zone limit

2018-04-16 Thread Gregory Rose
On 4/16/2018 11:15 AM, Yi-Hung Wei wrote: Currently, nf_conntrack_max is used to limit the maximum number of conntrack entries in the conntrack table for every network namespace. For the VMs and containers that reside in the same namespace, they share the same conntrack table, and the total # of

Re: [PATCH net-next 1/2] openvswitch: Add conntrack limit netlink definition

2018-04-16 Thread Gregory Rose
On 4/16/2018 11:15 AM, Yi-Hung Wei wrote: Define netlink messages and attributes to support user kernel communication that using conntrack limit feature. s/using/uses the/ Signed-off-by: Yi-Hung Wei --- include/uapi/linux/openvswitch.h | 62

Re: [PATCH] pci-iov: Add support for unmanaged SR-IOV

2018-02-28 Thread Gregory Rose
On 2/28/2018 9:49 AM, Alexander Duyck wrote: On Tue, Feb 27, 2018 at 2:25 PM, Alexander Duyck wrote: On Tue, Feb 27, 2018 at 1:40 PM, Alex Williamson wrote: On Tue, 27 Feb 2018 11:06:54 -0800 Alexander Duyck

Re: [PATCH iproute2 net-next] gre6: add collect metadata support

2017-12-04 Thread Gregory Rose
On 12/1/2017 3:03 PM, William Tu wrote: The patch adds 'external' option to support collect metadata gre6 tunnel. Example of L3 and L2 gre device: bash:~# ip link add dev ip6gre123 type ip6gre external bash:~# ip link add dev ip6gretap123 type ip6gretap external Hi William, one question.  Is