Re: Bug with GRE tunnel and "ip xfrm" GRE match?

Also sdding netdev for more inputs. On Wed, Oct 18, 2017 at 12:13 PM, Harsh Jain <harshjain.p...@gmail.com> wrote: > Hi keith, > > Its being a long time when I observed this issue. What I remember is , > The kernel patch which I shared was not compatible with latest kerne

[PATCH v2 2/7] crypto:chelsio: Check error code with IS_ERR macro

From: Yeshaswi M R Gowda <yesha...@chelsio.com> Check and return proper error code. Signed-off-by: Jitendra Lulla <jlu...@chelsio.com> Signed-off-by: Harsh Jain <ha...@chelsio.com> --- drivers/crypto/chelsio/chcr_algo.c | 16 1 file changed, 8 insertio

[PATCH v2 1/7] crypto:chelsio: Remove unused parameter

From: Yeshaswi M R Gowda <yesha...@chelsio.com> Remove unused parameter sent to latest fw. Signed-off-by: Harsh Jain <ha...@chelsio.com> --- drivers/crypto/chelsio/chcr_algo.c | 43 +++--- drivers/crypto/chelsio/chcr_algo.h | 12 +-- 2 files

[PATCH v2 4/7] crypto:chelsio:Use x8_ble gf multiplication to calculate IV.

gf128mul_x8_ble() will reduce gf Multiplication iteration by 8. Signed-off-by: Harsh Jain <ha...@chelsio.com> --- drivers/crypto/chelsio/chcr_algo.c | 11 +-- drivers/crypto/chelsio/chcr_crypto.h | 1 + 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/

[PATCH v2 5/7] crypto:chelsio:Remove allocation of sg list to implement 2K limit of dsgl header

Update DMA address index instead of allocating new sg list to impose 2k size limit for each entry. Signed-off-by: Harsh Jain <ha...@chelsio.com> --- drivers/crypto/chelsio/chcr_algo.c | 237 +++ drivers/crypto/chelsio/chcr_algo.h | 3 +- drivers/

[PATCH v2 7/7] crypto:chelsio: Fix memory leak

Fix memory leak when device does not support crypto. Reported-by: Dan Carpenter <dan.carpen...@oracle.com> Signed-off-by: Harsh Jain <ha...@chelsio.com> --- drivers/crypto/chelsio/chcr_core.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/cr

[PATCH v2 6/7] crypto:chelsio:Move DMA un/mapping to chcr from lld cxgb4 driver

Allow chcr to do DMA mapping/Unmapping instead of lld cxgb4. It moves "Copy AAD to dst buffer" requirement from driver to firmware. Signed-off-by: Harsh Jain <ha...@chelsio.com> --- drivers/crypto/chelsio/chcr_algo.c | 1645 ++ drivers/crypto/che

[PATCH v2 3/7] crypto:gf128mul: The x8_ble multiplication functions

It multiply GF(2^128) elements in the ble format. It will be used by chelsio driver to speed up gf multiplication. Signed-off-by: Harsh Jain <ha...@chelsio.com> --- crypto/gf128mul.c | 13 + include/crypto/gf128mul.h | 2 +- 2 files changed, 14 insertions(+), 1 de

Re: [PATCH 3/7] crypto:gf128mul: The x8_ble multiplication functions

On 03-10-2017 20:28, David Laight wrote: > From: Harsh Jain >> Sent: 03 October 2017 07:46 >> It multiply GF(2^128) elements in the ble format. >> It will be used by chelsio driver to fasten gf multiplication. >^ speed up ?? It shou

[PATCH 2/7] crypto:chelsio: Check error code with IS_ERR macro

Check and return proper error code. Signed-off-by: Harsh Jain <ha...@chelsio.com> --- drivers/crypto/chelsio/chcr_algo.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/crypto/chelsio/chcr_algo.c b/drivers/crypto/chelsio/chcr_algo.c index b

[PATCH 4/7] crypto:chelsio:Use x8_ble gf multiplication to calculate IV.

gf128mul_x8_ble() will reduce gf Multiplication iteration by 8. Signed-off-by: Harsh Jain <ha...@chelsio.com> --- drivers/crypto/chelsio/chcr_algo.c | 11 +-- drivers/crypto/chelsio/chcr_crypto.h | 1 + 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/

[PATCH 0/7]crypto:chelsio: Bugs fixes

It includes bug fix and performance improvement changes. Harsh Jain (7): crypto:gf128mul: The x8_ble multiplication functions crypto:chelsio:Use x8_ble gf multiplication to calculate IV. crypto:chelsio:Remove allocation of sg list to implement 2K limit of dsgl header

[PATCH 3/7] crypto:gf128mul: The x8_ble multiplication functions

It multiply GF(2^128) elements in the ble format. It will be used by chelsio driver to fasten gf multiplication. Signed-off-by: Harsh Jain <ha...@chelsio.com> --- crypto/gf128mul.c | 13 + include/crypto/gf128mul.h | 2 +- 2 files changed, 14 insertions(+), 1 de

[PATCH 5/7] crypto:chelsio:Remove allocation of sg list to implement 2K limit of dsgl header

Update DMA address index instead of allocating new sg list to impose 2k size limit for each entry. Signed-off-by: Harsh Jain <ha...@chelsio.com> --- drivers/crypto/chelsio/chcr_algo.c | 237 +++ drivers/crypto/chelsio/chcr_algo.h | 3 +- drivers/

[PATCH 1/7] crypto:chelsio: Remove unused parameter

Remove unused parameter sent to latest fw. Signed-off-by: Harsh Jain <ha...@chelsio.com> --- drivers/crypto/chelsio/chcr_algo.c | 43 +++--- drivers/crypto/chelsio/chcr_algo.h | 12 +-- 2 files changed, 23 insertions(+), 32 deletions(-) diff

[PATCH 6/7] crypto:chelsio:Move DMA un/mapping to chcr from lld cxgb4 driver

Allow chcr to do DMA mapping/Unmapping instead of lld cxgb4. It moves "Copy AAD to dst buffer" requirement from driver to firmware. Signed-off-by: Ganesh Goudar <ganes...@chelsio.com> Signed-off-by: Harsh Jain <ha...@chelsio.com> --- drivers/crypto/chelsio/ch

[PATCH 7/7] crypto:chelsio: Fix memory leak

Fix memory leak when device does not support crypto. Reported-by: Dan Carpenter <dan.carpen...@oracle.com> Signed-off-by: Harsh Jain <ha...@chelsio.com> --- drivers/crypto/chelsio/chcr_core.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/cr

[PATCH 6/9] chcr - Add debug counters

Count types of operation done by HW. Signed-off-by: Harsh Jain <ha...@chelsio.com> --- drivers/crypto/chelsio/chcr_algo.c | 16 +- drivers/crypto/chelsio/chcr_core.c | 2 ++ drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 1 + drivers/net/et

[PATCH 1/9] crypto: chcr - Pass lcb bit setting to firmware

GCM and CBC mode of operation requires Last Cipher Block. This patch set lcb bit in WR header when required. Signed-off-by: Harsh Jain <ha...@chelsio.com> --- drivers/crypto/chelsio/chcr_algo.c | 18 +++--- drivers/crypto/chelsio/chcr_algo.h | 4 ++-- 2 files changed, 13 inse

[PATCH 0/9] Bug fixes and ctr mode of operation

This series is based on cryptodev2.6 tree and includes bug fix ,ctr(aes), rfc3686(ctr(aes)) algo. Harsh Jain (7): crypto: chcr - Pass lcb bit setting to firmware crypto: chcr - Set fallback key crypto: chcr - Return correct error code crypto: chcr - Avoid changing request structure

[PATCH 5/9] crypto:chcr - Add ctr mode and process large sg entries for cipher

It send multiple WRs to H/W to handle large sg lists. Adds ctr(aes) and rfc(ctr(aes)) modes. Signed-off-by: Harsh Jain <ha...@chelsio.com> --- drivers/crypto/chelsio/chcr_algo.c | 786 --- drivers/crypto/chelsio/chcr_algo.h | 26 +- drivers/crypto/c

[PATCH 4/9] crypto: chcr - Avoid changing request structure

Do not update assoclen received in aead_request. Signed-off-by: Harsh Jain <ha...@chelsio.com> --- drivers/crypto/chelsio/chcr_algo.c | 37 ++--- 1 file changed, 14 insertions(+), 23 deletions(-) diff --git a/drivers/crypto/chelsio/chcr_algo.c b/drivers/

[PATCH 8/9] crypto: chcr - Ensure Destination sg entry size less than 2k

Allocate new sg list in case received destination sg list has entry greater that 2k. Signed-off-by: Harsh Jain <ha...@chelsio.com> --- drivers/crypto/chelsio/chcr_algo.c | 153 +++ drivers/crypto/chelsio/chcr_crypto.h | 6 ++ 2 files changed, 142 inse

[PATCH 3/9] crypto: chcr - Return correct error code

Return correct error instead of EINVAL. Signed-off-by: Harsh Jain <ha...@chelsio.com> --- drivers/crypto/chelsio/chcr_algo.c | 76 +- 1 file changed, 42 insertions(+), 34 deletions(-) diff --git a/drivers/crypto/chelsio/chcr_algo.c b/drivers/crypto/c

[PATCH 7/9] MAINTAINERS:Add maintainer for chelsio crypto driver

Add myself as maintainer for chcr. Signed-off-by: Harsh Jain <ha...@chelsio.com> --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 1f20176..504dc65 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3706,6 +3706,13 @@ S: Suppor

[PATCH 9/9] crypto: chcr - Select device in Round Robin fashion

When multiple devices are present in system select device in round-robin fashion for crypto operations Signed-off-by: Atul Gupta Reviewed-by: Ganesh Goudar --- drivers/crypto/chelsio/chcr_algo.c | 8 ++--

[PATCH 2/9] crypto: chcr - Fix fallback key setting

Set key of fallback tfm for rfc4309. Signed-off-by: Harsh Jain <ha...@chelsio.com> --- drivers/crypto/chelsio/chcr_algo.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/chelsio/chcr_algo.c b/drivers/crypto/chelsio/chcr_algo.c index e

Re: [PATCH 08/22] crypto: chcr: Make use of the new sg_map helper function

On Fri, Apr 14, 2017 at 3:35 AM, Logan Gunthorpe wrote: > The get_page in this area looks *highly* suspect due to there being no > corresponding put_page. However, I've left that as is to avoid breaking > things. chcr driver will post the request to LLD driver cxgb4 and

[PATCH 2/4] chcr:Set hmac_ctrl bit to use HW register HMAC_CFG[456]

Use hmac_ctrl bit value saved in setauthsize callback. Signed-off-by: Harsh Jain <ha...@chelsio.com> --- drivers/crypto/chelsio/chcr_algo.c | 24 +--- 1 files changed, 5 insertions(+), 19 deletions(-) diff --git a/drivers/crypto/chelsio/chcr_algo.c b/drivers/

[PATCH 3/4] chcr:Fix txq ids.

The patch fixes a critical issue to map txqid with flows on the hardware appropriately, if tx queues created are more than flows configured then txqid shall map within the range of hardware flows configured. This ensure that un-mapped txqid does not remain un-handled. The patch also segregated

[PATCH 4/4] chcr: Add fallback for AEAD algos

Fallback to sw when I AAD length greater than 511 II Zero length payload II No of sg entries exceeds Request size. Signed-off-by: Harsh Jain <ha...@chelsio.com> --- drivers/crypto/chelsio/chcr_algo.c | 219 ++ drivers/crypto/chelsio/chcr_

[PATCH 1/4] chcr: Increase priority of AEAD algos.

-by: Harsh Jain <ha...@chelsio.com> --- drivers/crypto/chelsio/chcr_algo.c | 12 ++-- drivers/crypto/chelsio/chcr_crypto.h |4 ++-- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/chelsio/chcr_algo.c b/drivers/crypto/chelsio/chcr_algo.c index 4

[PATCH 0/4] Bug fixes and fallback for AEAD

This series based on Herbert cryptodev-2.6. It includes bug fixes and fallback for AEAD algos. Harsh Jain (3): chcr: Increase priority of AEAD algos. chcr:Set hmac_ctrl bit to use HW register HMAC_CFG[456]. chcr: Add fallback for AEAD algos Atul Gupta (1): chcr: Fix txq ids drivers

[PATCH 1/8] crypto:chcr-Change flow IDs

Change assign flowc id to each outgoing request.Firmware use flowc id to schedule each request onto HW. FW reply may miss without this change. Reviewed-by: Hariprasad Shenai Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chcr_algo.c

[PATCH 4/8] crypto:chcr- Use cipher instead of Block Cipher in gcm setkey

1 Block of encrption can be done with aes-generic. no need of cbc(aes). This patch replaces cbc(aes-generic) with aes-generic. Signed-off-by: Harsh Jain <ha...@chelsio.com> --- drivers/crypto/chelsio/chcr_algo.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-)

[PATCH 0/8] Bug fixes

This patch series is based on Herbert's cryptodev-2.6 tree and depends on patch series "Bug Fixes for 4.10". It includes Bug Fixes. Atul Gupta (2) crypto:chcr-Change flow IDs crypto:chcr- Fix wrong typecasting Harsh Jain (8): crypto:chcr- Fix key length for RFC4106 crypt

[PATCH 8/8] crypto:chcr-Fix Smatch Complaint

Initialise variable after null check. Reported-by: Dan Carpenter <dan.carpen...@oracle.com> Signed-off-by: Harsh Jain <ha...@chelsio.com> --- drivers/crypto/chelsio/chcr_algo.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) mode change 100644 => 100755 drivers

[PATCH 7/8] crypto:chcr- Fix wrong typecasting

Typecast the pointer with correct structure. Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chcr_core.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/crypto/chelsio/chcr_core.c b/drivers/crypto/chelsio/chcr_core.c index

[PATCH 2/8] crypto:chcr- Fix key length for RFC4106

Check keylen before copying salt to avoid wrap around of Integer. Signed-off-by: Harsh Jain <ha...@chelsio.com> --- drivers/crypto/chelsio/chcr_algo.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/chelsio/chcr_algo.c b/drivers/crypto/chelsio/chcr_

[PATCH 3/8] crypto:chcr-fix itnull.cocci warnings

The first argument to list_for_each_entry cannot be NULL. Generated by: scripts/coccinelle/iterators/itnull.cocci Signed-off-by: Julia Lawall <julia.law...@lip6.fr> Signed-off-by: Fengguang Wu <fengguang...@intel.com> Signed-off-by: Harsh Jain <ha...@chelsio.com> --- driv

[PATCH 5/8] crypto:chcr: Change cra_flags for cipher algos

Change cipher algos flags to CRYPTO_ALG_TYPE_ABLKCIPHER. Signed-off-by: Harsh Jain <ha...@chelsio.com> --- drivers/crypto/chelsio/chcr_algo.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/chelsio/chcr_algo.c b/drivers/crypto/chelsio/chcr_algo.c

[PATCH 6/8] crypto:chcr- Change algo priority

Update priorities to 3000 Signed-off-by: Harsh Jain <ha...@chelsio.com> --- drivers/crypto/chelsio/chcr_crypto.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/chelsio/chcr_crypto.h b/drivers/crypto/chelsio/chcr_crypto.h index 7ec0a8f..81cfd0b

[PATCH v1 4/4] crypto:chcr-fix itnull.cocci warnings

The first argument to list_for_each_entry cannot be NULL. Generated by: scripts/coccinelle/iterators/itnull.cocci Signed-off-by: Julia Lawall <julia.law...@lip6.fr> Signed-off-by: Fengguang Wu <fengguang...@intel.com> Signed-off-by: Harsh Jain <ha...@chelsio.com> --- driv

[PATCH v1 3/4] crypto:chcr- Check device is allocated before use

Ensure dev is allocated for crypto uld context before using the device for crypto operations. Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chcr_core.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git

[PATCH v1 2/4] crypto:chcr- Fix panic on dma_unmap_sg

Save DMA mapped sg list addresses to request context buffer. Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chcr_algo.c | 49 +++- drivers/crypto/chelsio/chcr_crypto.h | 3 +++ 2 files changed, 29 insertions(+), 23 deletions(-)

[PATCH v1 1/4] crypto:chcr-Change flow IDs

Change assign flowc id to each outgoing request.Firmware use flowc id to schedule each request onto HW. FW reply may lost without this change. Reviewed-by: Hariprasad Shenai Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chcr_algo.c

[PATCH v1 0/4]crypto:chcr- Bug Fixes for 4.10

This patch series is based on Herbert's cryptodev-2.6 tree. It includes several critical bug fixes. Atul Gupta (3): crypto:chcr-Change flow IDs crypto:chcr- Fix panic on dma_unmap_sg crypto:chcr- Check device is allocated before use Julia Lawall (1): crypto:chcr-fix itnull.cocci warnings

Re: [PATCH v1 3/8] crypto:chcr- Fix key length for RFC4106

On 12-01-2017 21:39, Herbert Xu wrote: > On Fri, Jan 06, 2017 at 02:01:34PM +0530, Harsh Jain wrote: >> Check keylen before copying salt to avoid wrap around of Integer. >> >> Signed-off-by: Harsh Jain <ha...@chelsio.com> >> --- >> drivers/crypto/chelsio/

[PATCH v1 1/8] crypto:chcr-Change flow IDs

Change assign flowc id to each outgoing request.Firmware use flowc id to schedule each request onto HW. Reviewed-by: Hariprasad Shenai Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chcr_algo.c| 18 ++

[PATCH v1 8/8] crypto:chcr- Fix wrong typecasting

Typecast the pointer with correct structure. Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chcr_core.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/crypto/chelsio/chcr_core.c b/drivers/crypto/chelsio/chcr_core.c index

[PATCH v1 2/8] crypto:chcr- Fix panic on dma_unmap_sg

Save DMA mapped sg list addresses to request context buffer. Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chcr_algo.c | 49 +++- drivers/crypto/chelsio/chcr_crypto.h | 3 +++ 2 files changed, 29 insertions(+), 23 deletions(-)

[PATCH v1 6/8] crypto:chcr- Change algo priority

Update priorities to 3000 Signed-off-by: Harsh Jain <ha...@chelsio.com> --- drivers/crypto/chelsio/chcr_crypto.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/chelsio/chcr_crypto.h b/drivers/crypto/chelsio/chcr_crypto.h index 7ec0a8f..81cfd0b

[PATCH v1 3/8] crypto:chcr- Fix key length for RFC4106

Check keylen before copying salt to avoid wrap around of Integer. Signed-off-by: Harsh Jain <ha...@chelsio.com> --- drivers/crypto/chelsio/chcr_algo.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/chelsio/chcr_algo.c b/drivers/crypto/chelsio/chcr_

[PATCH v1 0/8] crypto:chcr- Bug fixes

The patch series is based on Herbert's cryptodev-2.6 tree. It include bug fixes. Atul Gupta (4): crypto:chcr-Change flow IDs crypto:chcr- Fix panic on dma_unmap_sg crypto:chcr- Check device is allocated before use crypto:chcr- Fix wrong typecasting Harsh Jain (4): crypto:chcr- Fix key

[PATCH v1 7/8] crypto:chcr- Check device is allocated before use

Ensure dev is allocated for crypto uld context before using the device for crypto operations. Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chcr_core.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git

[PATCH v1 5/8] crypto:chcr: Change cra_flags for cipher algos

Change cipher algos flags to CRYPTO_ALG_TYPE_ABLKCIPHER. Signed-off-by: Harsh Jain <ha...@chelsio.com> --- drivers/crypto/chelsio/chcr_algo.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/chelsio/chcr_algo.c b/drivers/crypto/chelsio/chcr_algo.c

[PATCH v1 4/8] crypto:chcr- Use cipher instead of Block Cipher in gcm setkey

1 Block of encrption can be done with aes-generic. no need of cbc(aes). This patch replaces cbc(aes-generic) with aes-generic. Signed-off-by: Harsh Jain <ha...@chelsio.com> --- drivers/crypto/chelsio/chcr_algo.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-)

packet encryption based on gre key value with ip xfrm command

from above system encrypt all GRE packets. I tried with kernel version 3.18 and iproute2 version.2.4. I got iproute2 patch file having changes to support filtering based on keys but didn't find corresponding kernel patch. How to encrypt Packets based on GRE key value.? Regards Harsh Jain