[PATCH] d80211: fix get_tsf call

2006-12-20 Thread Hong Liu
get_tsf passes the wrong pointer to driver. Signed-off-by: Hong Liu [EMAIL PROTECTED] diff --git a/net/d80211/ieee80211_sta.c b/net/d80211/ieee80211_sta.c index 3b55427..e48295e 100644 --- a/net/d80211/ieee80211_sta.c +++ b/net/d80211/ieee80211_sta.c @@ -2482,7 +2482,7 @@ #ifdef

[PATCH] d80211: fix softlockup in hw_scan card when rmmod

2006-12-19 Thread Hong Liu
The local-scan_work.data is not clear after scan is completed. This will cause softlockup when removing driver module because the local-scan_work is not initialized for hw_scan card and we are trying to cancel the scan_work with an uninitialized timer_list. Signed-off-by: Hong Liu [EMAIL

Re: [patch 1/2]d80211: hardware TKIP support for ipw3945

2006-11-13 Thread Hong Liu
Resend the patch according to Johannes's comments. Still put he tkip_key in tx_control structure. Signed-off-by: Hong Liu [EMAIL PROTECTED] diff --git a/include/net/d80211.h b/include/net/d80211.h index 812f2d1..cf87adc 100644 --- a/include/net/d80211.h +++ b/include/net/d80211.h @@ -159,6

[patch] d80211: fix key access race

2006-11-02 Thread Hong Liu
it :( Thanks, Hong Signed-off-by: Hong Liu [EMAIL PROTECTED] diff --git a/net/d80211/ieee80211.c b/net/d80211/ieee80211.c index 751bc76..1a1f6fb 100644 --- a/net/d80211/ieee80211.c +++ b/net/d80211/ieee80211.c @@ -99,12 +99,38 @@ struct ieee80211_key *ieee80211_key_allo return key; } -void

Re: [patch 1/2]d80211: hardware TKIP support for ipw3945

2006-10-25 Thread Hong Liu
On Tue, 2006-10-24 at 17:10, Johannes Berg wrote: On Tue, 2006-10-24 at 16:38 +0800, Hong Liu wrote: The first time when we set the TKIP key, we can set the phase1 key if the driver requires. Right. The problem is when IV16 wraps, who will generate the new phase1 key? Ok, I

about 802.11i IBSS support

2006-10-25 Thread Hong Liu
Hi, I am reading the 802.11i IBSS spec and trying to find if it is OK to add patches to d80211 to support this feature. For 802.11i IBSS to work, each STA assumes two roles: supplicant + authenticator. Usually in BSS network, authenticator is in AP. The problem is the distribution of group keys.

Re: about 802.11i IBSS support

2006-10-25 Thread Hong Liu
On Wed, 2006-10-25 at 23:48, Jouni Malinen wrote: On Wed, Oct 25, 2006 at 04:54:41PM +0800, Hong Liu wrote: I am reading the 802.11i IBSS spec and trying to find if it is OK to add patches to d80211 to support this feature. Large parts of this will be outside d80211, but yes, I think

Re: [patch 1/2]d80211: hardware TKIP support for ipw3945

2006-10-24 Thread Hong Liu
On Mon, 2006-10-23 at 20:56, Jiri Benc wrote: On Mon, 23 Oct 2006 14:48:00 +0200, Johannes Berg wrote: On Mon, 2006-10-23 at 14:40 +0200, Jiri Benc wrote: I don't like extending ieee80211_tx_control by 16 more bytes. The driver is required to store a copy of each ieee80211_tx_control

Re: [patch 1/2]d80211: hardware TKIP support for ipw3945

2006-10-24 Thread Hong Liu
On Tue, 2006-10-24 at 16:35, Johannes Berg wrote: On Tue, 2006-10-24 at 16:20 +0800, Hong Liu wrote: It's really strange bcm43xx only does phase2 mixing in hw. With all the code that does phase2 mixing, doing phase1 mixing is very cheap. Yeah, well, they have the tkip sbox in hw

[patch 1/2]d80211: hardware TKIP support for ipw3945

2006-10-20 Thread Hong Liu
ipw3945 TKIP hwcrypto only support RC4 encryption, so the stack needs to pre compute the michael MIC and the RC4key for it. Signed-off-by: Hong Liu [EMAIL PROTECTED] --- include/net/d80211.h |7 +++ net/d80211/tkip.c| 25 +++-- net/d80211/tkip.h|2

[patch 2/2] d80211: fix wep_tfm race

2006-10-20 Thread Hong Liu
this race. Signed-off-by: Hong Liu [EMAIL PROTECTED] --- net/d80211/ieee80211_i.h |3 ++- net/d80211/wep.c | 18 +- net/d80211/wpa.c |6 -- 3 files changed, 19 insertions(+), 8 deletions(-) 634c9615ce3cd06dc7f6aff05e43e61490a53472 diff --git a/net

[patch 2/2] d80211: fix wep_tfm race

2006-10-20 Thread Hong Liu
this race. Signed-off-by: Hong Liu [EMAIL PROTECTED] --- net/d80211/ieee80211_i.h |3 ++- net/d80211/wep.c | 18 +- net/d80211/wpa.c |6 -- 3 files changed, 19 insertions(+), 8 deletions(-) 634c9615ce3cd06dc7f6aff05e43e61490a53472 diff --git a/net

Re: [PATCH]d80211: fix iwconfig key [x] behavior

2006-09-22 Thread Hong Liu
On Thu, 2006-09-21 at 23:51, Jiri Benc wrote: Hi, sorry for the delay. On Fri, 01 Sep 2006 11:37:57 +0800, Hong Liu wrote: @@ -2925,7 +2932,8 @@ static int ieee80211_ioctl_giwencode(str return 0; } - erq-length = 0; + erq-length = min((int)erq-length, sdata

Re: [PATCH 2/2]d80211: add hardware scan callback

2006-09-01 Thread Hong Liu
On Fri, 2006-09-01 at 14:41, Johannes Berg wrote: On Fri, 2006-09-01 at 11:37 +0800, Hong Liu wrote: + local-sta_scanning = 1; + if (local-hw-hw_scan) + return local-hw-hw_scan(dev, ssid, ssid_len); + My question still stands, is it proper to assign sta_scanning

Re: [PATCH 2/2]d80211: add hardware scan callback

2006-08-31 Thread Hong Liu
On Thu, 2006-08-31 at 01:10, Jiri Benc wrote: On Fri, 25 Aug 2006 16:32:13 +0800, Hong Liu wrote: Add hardware scan callback to support cards like ipw3945 which implements the scan command in firmware. How ipw3945 performs scan? From the patch, it looks like it switches channels

Re: [PATCH 1/2]d80211: fix wpa_supplicant reassoc problem

2006-08-31 Thread Hong Liu
On Thu, 2006-08-31 at 00:57, Jiri Benc wrote: On Fri, 25 Aug 2006 16:32:08 +0800, Hong Liu wrote: After key negotiation completed using wpa_supplicant, wpa_supplicant can't reassoc with the AP if we reboot the AP. It always fails at the 4-way handshake. The problem is the key info

[PATCH]d80211: fix iwconfig key [x] behavior

2006-08-28 Thread Hong Liu
iwconfig key [x] behavior is not correctly handled in the stack, also modify the giwencode method to show the key info. Thanks, Hong [PATCH]d80211: fix iwconfig key [x] behavior Signed-off-by: Hong Liu [EMAIL PROTECTED] diff --git a/net/d80211/ieee80211_ioctl.c b/net/d80211/ieee80211_ioctl.c

[PATCH 1/2]d80211: fix wpa_supplicant reassoc problem

2006-08-25 Thread Hong Liu
After key negotiation completed using wpa_supplicant, wpa_supplicant can't reassoc with the AP if we reboot the AP. It always fails at the 4-way handshake. The problem is the key info is not cleared correctly. Thus when wpa_supplicant send the EAPOL-KEY packet, the d80211 stack finds the old key

[PATCH 2/2]d80211: add hardware scan callback

2006-08-25 Thread Hong Liu
Add hardware scan callback to support cards like ipw3945 which implements the scan command in firmware. Thanks, Hong diff --git a/include/net/d80211.h b/include/net/d80211.h index ba5cb4c..b369d12 100644 --- a/include/net/d80211.h +++ b/include/net/d80211.h @@ -595,6 +595,10 @@ struct

Re: [patch] ieee80211: fix not allocating IV+ICV space when usingencryption in ieee80211_tx_frame

2006-06-20 Thread Hong Liu
On Tue, 2006-06-20 at 10:26, Hong Liu wrote: We should preallocate IV+ICV space when encrypting the frame. Currently no problem shows up just because dev_alloc_skb aligns the data len to SMP_CACHE_BYTES which can be used for ICV. Thanks, Hong Please apply this new patch. The previous

[patch] ieee80211: fix not allocating IV+ICV space when using encryption in ieee80211_tx_frame

2006-06-19 Thread Hong Liu
We should preallocate IV+ICV space when encrypting the frame. Currently no problem shows up just because dev_alloc_skb aligns the data len to SMP_CACHE_BYTES which can be used for ICV. Thanks, Hong diff -urp a/net/ieee80211/ieee80211_tx.c b/net/ieee80211/ieee80211_tx.c ---