switching to proper mail client...
Dave Hansen [EMAIL PROTECTED] wrote on 15.02.2008 17:55:38:
I've been thinking about that, and I don't think you really *need* to
keep a comprehensive map like that.
When the memory is in a particular configuration (range of memory
present along with
Hi Dave,
On Monday 11 February 2008 17:47, Dave Hansen wrote:
Also, just ripping down and completely re-doing the entire mass of cards
every time a 16MB area of memory is added or removed seems like an
awfully big sledgehammer to me. I would *HATE* to see anybody else
using this driver as an
Drivers like eHEA need memory notifiers in order to
update their internal DMA memory map when memory is added
to or removed from the system.
Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED]
---
Hi,
this is the modified version with EXPORT_SYMBOL_GPL
Regards,
Jan-Bernd
drivers/base
Drivers like eHEA need memory notifiers in order to
update their internal DMA memory map when memory is added
to or removed from the system.
Patch for eHEA memory hotplug support that uses these functions:
http://www.spinics.net/lists/netdev/msg54484.html
Signed-off-by: Jan-Bernd Themann [EMAIL
On Monday 11 February 2008 11:12, Dave Hansen wrote:
On Mon, 2008-02-11 at 10:49 +0100, Jan-Bernd Themann wrote:
are you the right person to address this patch to?
You might want to check the top of the file. ;)
--- a/drivers/base/memory.c
+++ b/drivers/base/memory.c
@@ -52,11 +52,13
Drivers like eHEA need memory notifiers in order to
update their internal DMA memory map when memory is added
to or removed from the system.
Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED]
---
Hi Greg,
are you the right person to address this patch to?
Regards,
Jan-Bernd
drivers/base
On Tuesday 05 February 2008 09:56, Kostya B wrote:
1. Let's assume a driver which has a HW csum capability, however it has a
privilege to assign any value for ip_summed.
For example the driver assigns unnecessary for most of the packets, however
it fails to verify the packets less than 96
On Sunday 03 February 2008 10:48, Kostya B wrote:
Hi,
The mail is related to the way LRO manipulates the ip_summed value. Could
anybody (author) explain why to overwrite the original value of
skb-ip_summed, when it's processing by __lro_proc_skb ?
E.g. in out: label
Why not to
Add memory remove hotplug support
Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED]
---
Comment: This patch depends on the following patch that
exports the symbols
register_memory_notifier()
unregister_memory_notifier()
http://lkml.org/lkml/2008/2/1/293
drivers/net/ehea/ehea_main.c
On Monday 04 February 2008 15:46, Michael Ellerman wrote:
On Mon, 2008-02-04 at 14:04 +0100, Jan-Bernd Themann wrote:
Add memory remove hotplug support
@@ -3559,6 +3578,10 @@ int __init ehea_module_init(void)
if (ret)
ehea_info(failed registering reboot notifier
there. The arrays are
kept up-to-date during normal runtime. The crash handler fn is triggered by the
recently introduced PPC crash shutdown reg/unreg functions.
Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED]
---
drivers/net/ehea/ehea.h | 34 +-
drivers/net/ehea/ehea_main.c | 281
This patch set adds support for kdump and hotplug memory remove
to the eHEA driver.
The memory remove patch depends on the following patch that
has been posted a few days ago. That patch exports the symbols
- register_memory_notifier()
- unregister_memory_notifier()
Due to changes in the struct device_driver there is no direct
access to its kobj any longer. The kobj was used to create
sysfs links between eHEA ethernet devices and the driver.
This patch removes the affected sysfs links to resolve
the build problems.
Signed-off-by: Jan-Bernd Themann [EMAIL
Drivers like eHEA need memory notifiers in order to
update their internal DMA memory map when memory is added
to or removed from the system.
Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED]
---
Comment: eHEA patches that exploit these functions will follow
drivers/base/memory.c |2
Hi
On Friday 23 November 2007 22:54, Roel Kluin wrote:
In function ehea_poll() drivers/net/ehea/ehea_main.c:667, in a loop cqe and
cqe_skb - both struct ehea_cqe pointers - are assigned:
--
cqe = ehea_poll_rq1(pr-qp, wqe_index);
cqe_skb = ehea_poll_cq(pr-send_cq);
if (!cqe !cqe_skb)
eHEA resources that are allocated via H_CALLs have a unique identifier each.
These identifiers are necessary to free the resources. A reboot notifier
is used to free all eHEA resources before the indentifiers get lost, i.e
before kexec starts a new kernel.
Signed-off-by: Jan-Bernd Themann [EMAIL
eHEA recovery and DLPAR functions are called seldomly. The eHEA workqueues
are replaced by the kernel event queue.
Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED]
---
The patch has been built against upstream git
drivers/net/ehea/ehea.h |3 +--
drivers/net/ehea/ehea_main.c | 28
Due to stability issues in high load situations the HW queue handling
has to be changed. The HW queues are now stopped and restarted again instead
of destroying and allocating new HW queues.
Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED]
---
drivers/net/ehea/ehea.h |4 +-
drivers
Hi
On Sunday 30 September 2007 18:20, Anton Blanchard wrote:
Hi,
I booted 2.6.23-rc8 and noticed that ehea loves its workqueues:
(notice also that the ehea_driver_wq/XXX exceeds TASK_COMM_LEN).
Since they are both infrequent events and not performance critical
(memory hotplug and
Hi,
On Monday 01 October 2007 16:44, Jeff Garzik wrote:
Jan-Bernd Themann wrote:
Due to stability issues in high load situations the HW queue handling
has to be changed. The HW queues are now stopped and restarted again instead
of destroying and allocating new HW queues.
Signed-off
Hi,
On Wednesday 19 September 2007 13:54, Krishna Kumar wrote:
CPU#1: ipoib_poll(budget=100)
{
A. process 100 skbs
B. netif_rx_complete()
Process unrelated interrupts; executes slower than steps C, D, E on
CPU#2
F. ib_req_notify_cq() (no missed completions,
Update of ehea_poll function to work with new NAPI scheme.
Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED]
---
Hi David,
this patch is built upon the patches provided by Mel Gorman
(2.6.23-rc6-mm1: Build failure on ppc64 drivers/net/ehea/ehea_main.c)
and Roland Dreier
([PATCH net-2.6.24
On Wednesday 19 September 2007 17:33, Roland Dreier wrote:
One other thing I observed is that I can not unload the module as the
ref counter of the eth device is too low. I haven't tracked down the
source of this problem yet.
I suspect that this is because netif_rx_reschedule() was
Hi,
On Saturday 15 September 2007 00:12, David Miller wrote:
Ok, for now I'm going to try and deal with this by reverting
the list handling to something approximating the old NAPI
code, as per the patch below.
I've only quickly test booted into this kernel on my workstation.
So take care
Hi Stephen,
I saw that you developed most of the new NAPI interface.
I already addressed this issue a while ago. Please correct me if I got
it wrong. I think there is still a serious problem with the NAPI
changes to make NAPI polling independent of struct net_device objects.
Its about the
Update last_rx in registered device struct instead of
in the dummy device.
Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED]
---
drivers/net/ehea/ehea_main.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ehea/ehea_main.c b/drivers/net/ehea/ehea_main.c
Hi David
David Miller schrieb:
Interrupt mitigation only works if it helps you avoid interrupts.
This scheme potentially makes more of them happen.
The hrtimer is just another interrupt, a cpu locally triggered one,
but it has much of the same costs nonetheless.
So if you set this timer, it
On Wednesday 29 August 2007 10:29, David Miller wrote:
From: Jan-Bernd Themann [EMAIL PROTECTED]
Date: Wed, 29 Aug 2007 09:10:15 +0200
In the end I want to reduce the CPU utilization. And one way
to do that is LRO which also works only well if there are more
then just a very few packets
On Wednesday 29 August 2007 10:15, James Chapman wrote:
Jan-Bernd Themann wrote:
What I'm trying to improve with this approach is interrupt
mitigation for NICs where the hardware support for interrupt
mitigation is limited. I'm not trying to improve this for NICs
that work well
On Monday 27 August 2007 22:37, David Miller wrote:
From: Jan-Bernd Themann [EMAIL PROTECTED]
Date: Mon, 27 Aug 2007 11:47:01 +0200
So the question is simply: Do we want drivers that need (benefit
from) a timer based polling support to implement their own timers
each, or should
Hi
On Monday 27 August 2007 23:02, David Miller wrote:
But there are huger fish to fry for you I think. Talk to your
platform maintainers and ask for an interface for obtaining
a flat static distribution of interrupts to cpus in order to
support multiqueue NAPI better.
In your previous
On Tuesday 28 August 2007 11:22, James Chapman wrote:
So in this scheme what runs -poll() to process incoming packets?
The hrtimer?
No, the regular NAPI networking core calls -poll() as usual; no timers
are involved. This scheme simply delays the napi_complete() from the
driver so the
On Monday 27 August 2007 03:58, David Miller wrote:
From: James Chapman [EMAIL PROTECTED]
Date: Sun, 26 Aug 2007 20:36:20 +0100
David Miller wrote:
From: James Chapman [EMAIL PROTECTED]
Date: Fri, 24 Aug 2007 18:16:45 +0100
Does hardware interrupt mitigation really interact well
the physical
port state is. Thus eHEA can be considered as a switch there.
Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED]
---
drivers/net/ehea/ehea.h |5 -
drivers/net/ehea/ehea_main.c | 14 +-
2 files changed, 17 insertions(+), 2 deletions(-)
diff --git a/drivers
Update last_rx in registered device struct instead of
in the dummy device.
Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED]
---
drivers/net/ehea/ehea_main.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ehea/ehea_main.c b/drivers/net/ehea/ehea_main.c
On Monday 27 August 2007 17:51, James Chapman wrote:
In the second half of my previous reply (which seems to have been
deleted), I suggest a way to avoid this problem without using hardware
interrupt mitigation / coalescing. Original text is quoted below.
I've seen the same and I'm
Hi,
when I tried to get the eHEA driver working with the new interface,
the following issues came up.
1) The current implementation of netif_rx_schedule, netif_rx_complete
and the net_rx_action have the following problem: netif_rx_schedule
sets the NAPI_STATE_SCHED flag and adds the NAPI
Hi,
On Friday 24 August 2007 17:37, [EMAIL PROTECTED] wrote:
On Fri, Aug 24, 2007 at 03:59:16PM +0200, Jan-Bernd Themann wrote:
...
3) On modern systems the incoming packets are processed very fast.
Especially
on SMP systems when we use multiple queues we process only a few
James Chapman schrieb:
Stephen Hemminger wrote:
On Fri, 24 Aug 2007 17:47:15 +0200
Jan-Bernd Themann [EMAIL PROTECTED] wrote:
Hi,
On Friday 24 August 2007 17:37, [EMAIL PROTECTED] wrote:
On Fri, Aug 24, 2007 at 03:59:16PM +0200, Jan-Bernd Themann wrote:
...
3) On modern systems
Linas Vepstas schrieb:
On Fri, Aug 24, 2007 at 09:04:56PM +0200, Bodo Eggert wrote:
Linas Vepstas [EMAIL PROTECTED] wrote:
On Fri, Aug 24, 2007 at 03:59:16PM +0200, Jan-Bernd Themann wrote:
3) On modern systems the incoming packets are processed very fast. Especially
on SMP
On Thursday 23 August 2007 00:20, Andrew Theurer wrote:
David Miller wrote:
From: Andrew Theurer [EMAIL PROTECTED]
Date: Wed, 22 Aug 2007 16:55:03 -0500
Thanks for finally getting to test this, I thought nobody
would test this until it got merged into 2.6.24 :-/
Yes, sorry for the
Hi David,
On Thursday 23 August 2007 10:17, David Miller wrote:
From: Jan-Bernd Themann [EMAIL PROTECTED]
Date: Thu, 23 Aug 2007 08:55:29 +0200
We'd like to keep the possibility to switch back to a single queue
for now.
Please do not do this, we already have way too much
Hi David,
when trying to get our driver working with the new interface,
I found the following issue where I'm not sure how to solve it best:
netif_rx_reschedule() does not work when called after netif_rx_complete().
The problem is that netif_rx_reschedule currently adds the napi struct once
Userspace DLPAR tool expects decimal numbers to be written to
and read from sysfs entries.
Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED]
---
drivers/net/ehea/ehea_main.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ehea/ehea_main.c b/drivers
Update the module parameter description of use_mcs to
show correct default value
Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED]
---
drivers/net/ehea/ehea_main.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ehea/ehea_main.c b/drivers/net/ehea
Includes hcp_epas_dtor in eq/cq/qp destructors to unmap
HW register.
Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED]
---
drivers/net/ehea/ehea_qmr.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ehea/ehea_qmr.c b/drivers/net/ehea/ehea_qmr.c
index
the physical
port state is. Thus eHEA can be considered as a switch there.
Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED]
---
drivers/net/ehea/ehea.h |5 -
drivers/net/ehea/ehea_main.c | 14 +-
2 files changed, 17 insertions(+), 2 deletions(-)
diff --git a/drivers
Hi
On Friday 10 August 2007 00:00, David Miller wrote:
From: Auke Kok [EMAIL PROTECTED]
Date: Thu, 09 Aug 2007 09:41:17 -0700
Signed-off-by: Auke Kok [EMAIL PROTECTED]
I think this is definitely how we should handle LRO
configuration instead of the ad-hoc module parameters
current LRO
Hi Auke,
On Friday 03 August 2007 22:29, Kok, Auke wrote:
Jan-Bernd Themann wrote:
This patch shows how the generic LRO interface is used for SKB mode
Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED]
---
drivers/net/Kconfig |1 +
drivers/net/ehea/ehea.h
Hi Jörn
On Friday 03 August 2007 15:41, Jörn Engel wrote:
On Fri, 3 August 2007 14:41:19 +0200, Jan-Bernd Themann wrote:
This patch provides generic Large Receive Offload (LRO) functionality
for IPv4/TCP traffic.
LRO combines received tcp packets to a single larger tcp packet
This patch shows how the generic LRO interface is used for SKB mode
Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED]
---
drivers/net/Kconfig |1 +
drivers/net/ehea/ehea.h |9 -
drivers/net/ehea/ehea_ethtool.c | 15 +++
drivers/net/ehea/ehea_main.c
either pass
SKBs or fragment lists to the LRO engine.
Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED]
---
include/linux/inet_lro.h | 177 ++
net/ipv4/Kconfig |8 +
net/ipv4/Makefile|1 +
net/ipv4/inet_lro.c | 600
Hi,
I think this patch could be the final version for now. It has been tested
on two platforms (power and x86_64) and works very well.
Apart from David Miller and Evgeniy Polaykov, we'd like to thank especially
Andrew Gallatin for his great reviews and help to make that happen.
After some
Hi,
Thanks for finding these bugs! I'll post an updated version soon (2 patches
with no separate Kconfig patches, one LRO and one eHEA patch). See comments
below.
Thanks,
Jan-Bernd
On Monday 30 July 2007 22:32, Andrew Gallatin wrote:
I was working on testing the myri10ge patch, and I ran into
Generic Large Receive Offload for TCP traffic
Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED]
---
include/linux/inet_lro.h | 173 ++
net/ipv4/inet_lro.c | 590 ++
2 files changed, 763 insertions(+), 0 deletions(-)
create mode
Kconfig and Makefile for LRO
Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED]
---
net/ipv4/Kconfig |8
net/ipv4/Makefile |1 +
2 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig
index fb79097..d894f61 100644
--- a/net/ipv4
Hi,
this patch set contains the latest generic LRO code, a Kconfig / Makefile
and an eHEA patch demonstrating how the aggregate SKB interface has to
to be used.
Drew, could you provide a patch for the myri10ge driver to show how the
receive in page interface works?
Please check the Kconfig /
Added LRO support using the SKB aggregate interface
Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED]
---
drivers/net/ehea/ehea.h |9 -
drivers/net/ehea/ehea_ethtool.c | 15 +++
drivers/net/ehea/ehea_main.c| 82 +++---
3 files changed
Kconfig changes for LRO
Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED]
---
drivers/net/Kconfig |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index f8a602c..fec4004 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
Hi Drew,
thanks a lot for your good feedback. See comments below.
I'll try to provide an updated version next week. It would
be nice if you could post a patch for your driver once
we have addressed the issues you mentioned. Then we would
have the eHEA driver for the SKB interface, and your driver
net_poll support for eHEA added
Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED]
---
drivers/net/ehea/ehea.h |2 +-
drivers/net/ehea/ehea_main.c | 22 +-
2 files changed, 22 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ehea/ehea.h b/drivers/net/ehea
Hi,
Thanks a lot for your comments so far.
This generic LRO patch differs from the last one in several points.
A new interface for a receive in pages mode has been added and tested
with an eHEA prototype. Seems to work well.
Does this extended interface seem to be sufficient?
Below some more
Generic LRO patch
Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED]
---
include/linux/inet_lro.h | 154 +
net/ipv4/inet_lro.c | 549 ++
2 files changed, 703 insertions(+), 0 deletions(-)
create mode 100644 include/linux/inet_lro.h
Hi,
I suggest we keep the interface open for IPv6 support by adding
an additional parameter but first just get IPv4 support only
into the kernel. IPv6 support can then incrementially be added.
Would that be ok?
On Sunday 15 July 2007 11:40, David Miller wrote:
From: Christoph Hellwig [EMAIL
Hi Evgeniy
On Thursday 12 July 2007 10:01, Evgeniy Polyakov wrote:
+
+ if (tcph-cwr || tcph-ece || tcph-urg || !tcph-ack || tcph-psh
+ || tcph-rst || tcph-syn || tcph-fin)
+ return -1;
I think you do not want to break lro frame because of push flag - it is
pretty
Generic Large Receive Offload proposal
After some discussions on the mailing list concerning our LRO approach,
we agreed to provide a generic LRO patch. The algorithm is based on
the version we developed for eHEA. The performance improvements we
observed were significant.
The LRO functionality
LRO support for eHEA
Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED]
---
drivers/net/ehea/ehea.h |9 +++-
drivers/net/ehea/ehea_main.c | 102 +++---
2 files changed, 104 insertions(+), 7 deletions(-)
diff --git a/drivers/net/ehea/ehea.h b/drivers
Kconfig and Makefile changes for LRO
Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED]
---
net/ipv4/Kconfig |9 +
net/ipv4/Makefile |1 +
2 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig
index 010fbb2..25279f4 100644
--- a/net
This patch introduces a capability flag that is used by the DLPAR userspace
tool to check which DLPAR features are supported by the eHEA driver.
Missing goto has been included.
Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED]
---
drivers/net/ehea/ehea.h |8 +++-
drivers/net/ehea
and
improved throughput for small numbers of parallel TCP connections.
As this feature is considered as experimental it is switched off by default
and can be activated via a module parameter.
Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED]
---
drivers/net/ehea/ehea.h | 30
drivers/net
This patch introduces a capability flag that is used by the DLPAR userspace
tool to check which DLPAR features are supported by the eHEA driver.
Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED]
---
drivers/net/ehea/ehea.h |8 +++-
drivers/net/ehea/ehea_main.c | 17
and
improved throughput for small numbers of parallel TCP connections.
As this feature is considered as experimental it is switched off by default
and can be activated via a module parameter.
Some additional security checks have been added since the last posting.
Signed-off-by: Jan-Bernd Themann [EMAIL
Hi,
good catch.
Thanks
On Wednesday 04 July 2007 14:53, Akinobu Mita wrote:
2007/7/4, Jan-Bernd Themann [EMAIL PROTECTED]:
diff --git a/drivers/net/ehea/ehea_main.c b/drivers/net/ehea/ehea_main.c
index bdb5241..f8c0908 100644
--- a/drivers/net/ehea/ehea_main.c
+++ b/drivers/net/ehea
This patch fixes several whitespace issues.
Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED]
---
diff --git a/drivers/net/ehea/ehea.h b/drivers/net/ehea/ehea.h
index c0f81b5..abaf3ac 100644
--- a/drivers/net/ehea/ehea.h
+++ b/drivers/net/ehea/ehea.h
@@ -39,7 +39,7 @@
#include asm/io.h
Hi,
to me it seems that this patch set only include multiple transmit queue support
(for qdisc). Am I right with this observation? If so, are there also plans to
support multiple receive queues to allow the queues to be processed in parallel
on different CPUs via a standard interface? Currently,
This patch fixes several whitespace issues.
Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED]
---
diff --git a/drivers/net/ehea/ehea.h b/drivers/net/ehea/ehea.h
index c0f81b5..abaf3ac 100644
--- a/drivers/net/ehea/ehea.h
+++ b/drivers/net/ehea/ehea.h
@@ -39,7 +39,7 @@
#include asm/io.h
-by: Jan-Bernd Themann [EMAIL PROTECTED]
---
This patch applies on top of the netdev upstream branch for 2.6.22
diff --git a/drivers/net/ehea/ehea.h b/drivers/net/ehea/ehea.h
index 1405d0b..173994d 100644
--- a/drivers/net/ehea/ehea.h
+++ b/drivers/net/ehea/ehea.h
@@ -39,7 +39,7 @@ #include asm
-by: Jan-Bernd Themann [EMAIL PROTECTED]
---
This patch applies on top of the netdev upstream branch for 2.6.22
diff --git a/drivers/net/ehea/ehea.h b/drivers/net/ehea/ehea.h
index 1405d0b..173994d 100644
--- a/drivers/net/ehea/ehea.h
+++ b/drivers/net/ehea/ehea.h
@@ -39,7 +39,7 @@ #include asm
This patch includes:
- removal of unused fields in structs
- ethtool statistics cleanup
- removes unsed functionality from send path
Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED]
---
This patch applies on top of the netdev upstream branch for 2.6.22
drivers/net/ehea/ehea.h
The patch fixes bugs related to the probe / remove adapter
functionality (handling of OFDT nodes)
Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED]
---
This patch applies on top of the netdev upstream branch for 2.6.22
diff --git a/drivers/net/ehea/ehea.h b/drivers/net/ehea/ehea.h
index
This patch includes:
- code cleanup related to resource management
- extended error data gathering for resource management
- removing trailing whitespaces
Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED]
---
This patch applies on top of the netdev upstream branch for 2.6.22
drivers/net
Hi,
+static inline int ehea_hash_skb(struct sk_buff *skb, int num_qps)
+{
+ u32 tmp;
+ if ((skb-nh.iph-protocol == IPPROTO_TCP)
+skb-protocol == ETH_P_IP) {
skb-protocol has network byte order. The ETH_P_IP test should also
logically come before checking the IP
.html)
please apply.
Jan-Bernd
Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
This patch introduces functionality to dynamically add / remove
ehea ports via an userspace DLPAR tool. It creates a subnode for
each logical port in the sysfs.
Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED]
---
diff --git a/drivers/net/ehea/ehea.h b/drivers/net/ehea/ehea.h
index 42295d6
This patch provides a functionality that allows parallel
RX processing on multiple RX queues by using dummy netdevices.
Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED]
---
diff -Nurp -X dontdiff linux-2.6.21-rc1/drivers/net/ehea/ehea.h
patched_kernel/drivers/net/ehea/ehea.h
--- linux
)
As soon as discussions about splitting NAPI from netdevice
have settled and this functionality is in kernel, we'll provide
a patch for the new interface.
(see: http://www.spinics.net/lists/netdev/msg25647.html)
please apply.
Jan-Bernd
Signed-off-by: Jan-Bernd Themann [EMAIL
This patch introduces functionality to dynamically add / remove
ehea ports via an userspace DLPAR tool. It creates a subnode for
each logical port in the sysfs.
Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED]
---
diff --git a/drivers/net/ehea/ehea.h b/drivers/net/ehea/ehea.h
index 42295d6
This patch provides a functionality that allows parallel
RX processing on multiple RX queues by using dummy netdevices.
Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED]
---
diff -Nurp -X dontdiff linux-2.6.21-rc1/drivers/net/ehea/ehea.h
patched_kernel/drivers/net/ehea/ehea.h
--- linux
Hi
Also, as far as the approach of using tasklets, I think it would be
better to use the fake netdev approach to continue to use NAPI.
Basically you create a pseudo-netdev for each receive queue and have
NAPI handle the polling for you -- you could look for
drivers/net/cxgb3 for an example
.
Regards,
Jan-Bernd
Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED]
---
diff -Nurp -X dontdiff linux-2.6.21-rc1/drivers/net/ehea/ehea.h
patched_kernel/drivers/net/ehea/ehea.h
--- linux-2.6.21-rc1/drivers/net/ehea/ehea.h2007-02-26 16:17:14.0
+0100
+++ patched_kernel/drivers/net/ehea
performance improvements with ehea.
Are there any concerns about this approach?
Regards,
Jan-Bernd
Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED]
---
diff -Nurp -X dontdiff linux-2.6.21-rc1/drivers/net/ehea/ehea.h
patched_kernel/drivers/net/ehea/ehea.h
--- linux-2.6.21-rc1/drivers/net/ehea
(devspec)
Logical ports can be added / removed by writing the logical
port id into the probe_port / remove_port file located in
the lhea adapter directory.
Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED]
---
diff --git a/drivers/net/ehea/ehea.h b/drivers/net/ehea/ehea.h
index 42295d6..e595d6b
be added / removed by writing the logical
port id into the probe_port / remove_port file.
Would that interface be sufficient for the userspace application?
Regards,
Jan-Bernd
Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED]
---
diff --git a/drivers/net/ehea/ehea.h b/drivers/net/ehea/ehea.h
Hi,
This looks great! Two questions. I would assume that the of_device
results in a devspec file in the sysfs directory for the port? Also,
yes, that is true. There is a devspec file containing the ofdt path in the
port directory.
is there a way to correlate a logical port to an ethernet
Hi,
I agree with most points. Here the new design proposal:
On Wednesday 14 February 2007 23:25, John Rose wrote:
Hi-
A few high level comments, then some really insignificant ones.
First, is there a reason why we shouldn't have a sysfs entry/kobject for
each logical port? How is it
This patch enables dynamic adding / removing of ehea ports
by DLPAR tool.
Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED]
---
diff -Nurp -X dontdiff linux-2.6.20/drivers/net/ehea/ehea.h
patched_kernel/drivers/net/ehea/ehea.h
--- linux-2.6.20/drivers/net/ehea/ehea.h2007-02-12 14:44
Error recovery for QP errors: Reset QPs and dump error information
Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED]
---
drivers/net/ehea/ehea.h |2 +-
drivers/net/ehea/ehea_main.c |8 +++-
drivers/net/ehea/ehea_phyp.c | 10 ++
drivers/net/ehea/ehea_phyp.h |3
Error recovery for QP errors: Reset QPs and dump error information
Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED]
---
drivers/net/ehea/ehea.h |2 +-
drivers/net/ehea/ehea_main.c |8 +++-
drivers/net/ehea/ehea_phyp.c | 10 ++
drivers/net/ehea/ehea_phyp.h |3
Hi,
that is right, I'll send a new patch
Thanks,
Jan-Bernd
On Wednesday 25 October 2006 18:21, Anton Blanchard wrote:
Hi,
+#ifdef CONFIG_PPC_64K_PAGES
+ /* To support 64k pages we must round to 64k page boundary */
+ epas-kernel.addr =
+ ioremap((paddr_kernel
This patch fixes kzalloc parameters (GFP_ATOMIC instead of GFP_KERNEL)
Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED]
---
diff --git a/drivers/net/ehea/ehea_main.c b/drivers/net/ehea/ehea_main.c
index eb7d44d..4538c99 100644
--- a/drivers/net/ehea/ehea_main.c
+++ b/drivers/net/ehea
1 - 100 of 176 matches
Mail list logo
