this fix it would fail with a NULL pointer dereference in
efx_dequeue_buffer, with efx_enqueue_skb in the call stack.
Fixes: e9117e5099ea ("sfc: Firmware-Assisted TSO version 2")
Reported-by: Jarod Wilson <ja...@redhat.com>
Signed-off-by: Bert Kenward <bkenw...@solarflare.c
est this patch if my analysis appears sound?
This patch looks good, the original reproducing setup successfully
recovers after the original active slave goes down, even with
NetworkManager in the mix.
Reviewed-by: Jarod Wilson <ja...@redhat.com>
--
Jarod Wilson
ja...@redhat.com
suggested, use Jay's patch).
Will do, test build is just about ready here.
--
Jarod Wilson
ja...@redhat.com
to get a net-next-ish kernel into their hands, but the bonding
driver we're working with here is quite close to current net-next
already, so I'm fairly confident the same thing will happen.
--
Jarod Wilson
ja...@redhat.com
alico <vfal...@gmail.com>
CC: Andy Gospodarek <a...@greyhouse.net>
CC: netdev@vger.kernel.org
Signed-off-by: Jarod Wilson <ja...@redhat.com>
---
v2: fix incorrect git sha reference, add more testing data
drivers/net/bonding/bond_3ad.c | 2 +-
1 file changed, 1 insertion(+), 1
On 2017-05-19 5:14 PM, David Miller wrote:
From: Jarod Wilson <ja...@redhat.com>
Date: Wed, 17 May 2017 11:11:44 -0400
As of 7bb11dc9f59d and 0622cab0341c, bond slaves in a 3ad bond are not
removed from the aggregator when they are down, and the active slave count
is NOT equal to
On 2017-05-19 4:38 PM, Mahesh Bandewar (महेश बंडेवार) wrote:
On Fri, May 19, 2017 at 11:46 AM, Jarod Wilson <ja...@redhat.com> wrote:
In commit dc9c4d0fe023, the arp_target array moved from a static global
to a local variable. By the nature of static globals, the array used to
be initi
lobal variables")
CC: Mahesh Bandewar <mahe...@google.com>
CC: Jay Vosburgh <j.vosbu...@gmail.com>
CC: Veaceslav Falico <vfal...@gmail.com>
CC: Andy Gospodarek <a...@greyhouse.net>
CC: netdev@vger.kernel.org
CC: sta...@vger.kernel.org
Signed-off-by: Jarod Wilson <ja...
to produce the state where I could
see both in the same aggregator, but a number of ports count of 1.
CC: Jay Vosburgh <j.vosbu...@gmail.com>
CC: Veaceslav Falico <vfal...@gmail.com>
CC: Andy Gospodarek <a...@greyhouse.net>
CC: netdev@vger.kernel.org
Signed-off-by: Jarod Wilson <ja.
On 2017-04-26 1:28 PM, Cong Wang wrote:
On Wed, Apr 26, 2017 at 9:46 AM, Jarod Wilson <ja...@redhat.com> wrote:
On 2017-04-26 12:11 PM, Cong Wang wrote:
On Wed, Apr 26, 2017 at 8:55 AM, Jarod Wilson <ja...@redhat.com> wrote:
We already have struct sockaddr_storage that c
On 2017-04-26 12:11 PM, Cong Wang wrote:
On Wed, Apr 26, 2017 at 8:55 AM, Jarod Wilson <ja...@redhat.com> wrote:
We already have struct sockaddr_storage that could be used throughout this
set as well. We just converted a few pieces of the bonding driver over to
using it for better s
both bonding and team, rather than having different per-driver
structs, or Yet Another Address Storage implementation.
--
Jarod Wilson
ja...@redhat.com
On 2017-04-10 2:50 PM, Jarod Wilson wrote:
On 2017-04-08 7:33 PM, Jarod Wilson wrote:
I'm digging into some bug reports covering performance issues with
balance-rr, and discovered something even worse than the reporter. My
test setup has a pair of NICs, one e1000e, one e1000 (but dual e1000e
On 2017-04-08 7:33 PM, Jarod Wilson wrote:
I'm digging into some bug reports covering performance issues with
balance-rr, and discovered something even worse than the reporter. My
test setup has a pair of NICs, one e1000e, one e1000 (but dual e1000e
seems the same). When I do a test run
, anyone has some insight, I'd be happy to hear it. :)
--
Jarod Wilson
ja...@redhat.com
On 2017-04-05 9:45 PM, David Miller wrote:
From: Jarod Wilson <ja...@redhat.com>
Date: Tue, 4 Apr 2017 17:32:42 -0400
...
Applied, but:
+static inline void bond_hw_addr_copy(u8 *dst, const u8 *src, unsigned int len)
+{
+ if (len == ETH_ALEN) {
+ ether_addr_copy(ds
setup (with a mix of
e1000 and e1000e cards), running LNST's bonding tests.
CC: Jay Vosburgh <j.vosbu...@gmail.com>
CC: Veaceslav Falico <vfal...@gmail.com>
CC: Andy Gospodarek <a...@greyhouse.net>
CC: netdev@vger.kernel.org
Signed-off-by: Jarod Wilson <ja...@redhat.com>
On 2017-03-13 11:26 PM, Jarod Wilson wrote:
On 2017-03-13 10:06 PM, Jarod Wilson wrote:
On 2017-03-13 8:28 PM, Jay Vosburgh wrote:
Jarod Wilson <ja...@redhat.com> wrote:
I've got a bug report for someone using a Intel OPA devices in a
bond, and
it appears these devices have a ha
Agreed, looks like a cut-n-paste buglet.
Acked-by: Jarod Wilson <ja...@redhat.com>
--
Jarod Wilson
ja...@redhat.com
On 2017-03-22 1:21 PM, Pavel Belous wrote:
From: Pavel Belous <pavel.bel...@aquantia.com>
Since AQC-100/107/08 chips supports hardware checksums for RX we should indicate
this via NETIF_F_RXCSUM flag.
Looks good, and fixes an lnst netperf test failure.
Acked-by: Jarod Wils
f I replied to the proper version of the patch. To
reiterate, patch looks appropriate and necessary.
Reviewed-by: Jarod Wilson <ja...@redhat.com>
--
Jarod Wilson
ja...@redhat.com
appropriate and necessary fix to me.
Reviewed-by: Jarod Wilson <ja...@redhat.com>
--
Jarod Wilson
ja...@redhat.com
Cut-n-paste enablement of 802.3ad bonding on 25G NICs, which currently
report 0 as their bandwidth.
CC: Jay Vosburgh <j.vosbu...@gmail.com>
CC: Veaceslav Falico <vfal...@gmail.com>
CC: Andy Gospodarek <a...@greyhouse.net>
CC: netdev@vger.kernel.org
Signed-off-by: Jarod Wilson
On 2017-03-13 10:06 PM, Jarod Wilson wrote:
On 2017-03-13 8:28 PM, Jay Vosburgh wrote:
Jarod Wilson <ja...@redhat.com> wrote:
I've got a bug report for someone using a Intel OPA devices in a
bond, and
it appears these devices have a hardware address length of 20,
opposed to
the typ
On 2017-03-13 8:28 PM, Jay Vosburgh wrote:
Jarod Wilson <ja...@redhat.com> wrote:
I've got a bug report for someone using a Intel OPA devices in a bond, and
it appears these devices have a hardware address length of 20, opposed to
the typical 6 on ethernet. When they dump /proc/net/b
tinkered with just yet feels very
clean, on top of not actually working yet. :)
--
Jarod Wilson
ja...@redhat.com
)
Reported-by: daz...@gmail.com
Reported-by: Brad Campbell <lists2...@fnarfbargle.com>
Cc: Jarod Wilson <ja...@redhat.com>
Signed-off-by: Cong Wang <xiyou.wangc...@gmail.com>
Apologies, I'm a bit late to the party, direct CC didn't land in inbox
because of duplicate suppress
vger.kernel.org
Signed-off-by: Jarod Wilson <ja...@redhat.com>
---
drivers/net/team/team.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c
index 4a24b5d15f5a..1b52520715ae 100644
--- a/drivers/net/team/team.c
+++ b/drivers/net/team/team.c
On 2017-03-02 3:24 PM, Cong Wang wrote:
This restores the ability of setting bond device's mtu to 9000.
Fixes: 91572088e3fd ("net: use core MTU range checking in core net infra")
Reported-by: daz...@gmail.com
Reported-by: Brad Campbell <lists2...@fnarfbargle.com>
Cc:
On 2016-12-15 3:31 PM, Jarod Wilson wrote:
Rather than allocating efx_ptp_data, a buffer, a workqueue, etc., and then
ultimately deciding not to call ptp_clock_register() for non-primary
interfaces, just exit out of efx_ptp_prober() earlier. Saves a little
memory and speeds up init and teardown
...@solarflare.com
CC: Edward Cree <ec...@solarflare.com>
CC: Bert Kenward <bkenw...@solarflare.com>
CC: netdev@vger.kernel.org
Signed-off-by: Jarod Wilson <ja...@redhat.com>
---
drivers/net/ethernet/sfc/ptp.c | 32 +---
1 file changed, 17 insertions(+), 15 deleti
hernet/sfc/mcdi_port.c | 60
drivers/net/ethernet/sfc/net_driver.h | 12 +++---
3 files changed, 65 insertions(+), 42 deletions(-)
What about drivers/net/ethernet/sfc/falcon/ethtool.c? Coming in a
separate patch?
--
Jarod Wilson
ja...@redhat.com
gs the virtio-net device in compliance with VIRTIO-152.
>
> Additionally, drop the max_mtu branch - it cannot be taken since the u16
> returned by virtio_cread16 will never exceed the initial value of
> max_mtu.
>
> Cc: "Michael S. Tsirkin" <m...@redhat.com>
> Cc: Jarod
On Mon, Oct 24, 2016 at 02:42:26PM +0200, Stefan Richter wrote:
> Fixes: d894be57ca92('ethernet: use net core MTU range checking in more
> drivers')
> CC: Jarod Wilson <ja...@redhat.com>
> CC: Thomas Falcon <tlfal...@linux.vnet.ibm.com>
> Signed-off-by: Stefan Richter
v@vger.kernel.org
> CC: linux1394-de...@lists.sourceforge.net
> CC: Jarod Wilson <ja...@redhat.com>
> Signed-off-by: Stefan Richter <stef...@s5r6.in-berlin.de>
> ---
> v2: use ETH_DATA_LEN, add comment
Acked-by: Jarod Wilson <ja...@redhat.com>
--
Jarod Wilson
ja...@redhat.com
_SIZE in order to avoid distracting long/int conversions.)
>
> Fixes: b3e3893e1253('net: use core MTU range checking in misc drivers')
> CC: netdev@vger.kernel.org
> CC: linux1394-de...@lists.sourceforge.net
> CC: Jarod Wilson <ja...@redhat.com>
> Signed-off-by: Stefan
v@vger.kernel.org
> CC: linux1394-de...@lists.sourceforge.net
> CC: Jarod Wilson <ja...@redhat.com>
> Signed-off-by: Stefan Richter <stef...@s5r6.in-berlin.de>
> ---
> drivers/firewire/net.c | 8 +---
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
>
On Sun, Oct 23, 2016 at 09:17:50AM +0200, Sven Eckelmann wrote:
> On Samstag, 22. Oktober 2016 21:08:26 CEST Jarod Wilson wrote:
> [...]
> > You're going to
> > need more than just this revert though, since batman-adv calls
> > ether_setup, which will set min_mtu = 68
On Sat, Oct 22, 2016 at 09:27:59PM +0200, Stefan Richter wrote:
> Adding Cc: linux1394-devel, dropping several Ccs, no additional comment.
>
> On Oct 22 Stefan Richter wrote:
> > On Oct 20 Jarod Wilson wrote:
> > > firewire-net:
> > > - set min/max_mt
ndo_change_mtu is also used by the bridge interface.
>
> Cc: Jarod Wilson <ja...@redhat.com>
> Fixes: b3e3893e1253 ("net: use core MTU range checking in misc drivers")
> Signed-off-by: Sven Eckelmann <s...@narfation.org>
> ---
> Original patch + my comment: https:
On Fri, Oct 21, 2016 at 10:44:41AM +0200, Andrew Lunn wrote:
> On Thu, Oct 20, 2016 at 08:42:46PM -0700, Florian Fainelli wrote:
> > Le 20/10/2016 à 20:25, Jarod Wilson a écrit :
> > > These few drivers call ether_setup(), but have no ndo_change_mtu, and thus
> > >
the ether_setup() changes. Fine-tuning can come after we get
back to full feature-parity here.
CC: netdev@vger.kernel.org
Reported-by: Asbjoern Sloth Toennesen <asbj...@asbjorn.st>
CC: Asbjoern Sloth Toennesen <asbj...@asbjorn.st>
CC: R Parameswaran <parameswaran...@gmail.com>
Si
nep/netdev.c
net/dsa/slave.c
net/irda/irda_device.c
net/irda/irlan/irlan_eth.c
Honestly, I think dsa is the only one where it likely actually matters,
but I'll send a patch addressing all of those plus l2tp_eth in half a sec.
--
Jarod Wilson
ja...@redhat.com
On Thu, Oct 20, 2016 at 11:23:54PM +0300, Michael S. Tsirkin wrote:
> On Thu, Oct 20, 2016 at 01:55:21PM -0400, Jarod Wilson wrote:
...
> > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> > index fad84f3..720809f 100644
> > --- a/drivers/net/virtio_net.c
...@vger.kernel.org
CC: Maya Erez <qca_me...@qca.qualcomm.com>
CC: Simon Kelley <si...@thekelleys.org.uk>
CC: Stanislav Yakovlev <stas.yakov...@gmail.com>
CC: Johannes Berg <johan...@sipsolutions.net>
CC: Inaky Perez-Gonzalez <inaky.perez-gonza...@intel.com>
S
sw...@realtek.com>
CC: Oliver Neukum <oneu...@suse.com>
CC: Steve Glendinning <steve.glendinn...@shawell.net>
Signed-off-by: Jarod Wilson <ja...@redhat.com>
---
drivers/net/usb/asix_devices.c | 4 +---
drivers/net/usb/ax88179_178a.c | 4 +---
drivers/net/usb/cdc-phonet.c |
przak <k...@fi.muni.cz>
CC: Francois Romieu <rom...@fr.zoreil.com>
CC: Kevin Curtis <kevin.cur...@farsite.co.uk>
CC: Zhao Qiang <qiang.z...@nxp.com>
Signed-off-by: Jarod Wilson <ja...@redhat.com>
---
drivers/char/pcmcia/synclink_cs.c | 1 -
drivers/net/wan/c101.c
bu.subram...@broadcom.com>
CC: mpt-fusionlinux@broadcom.com
CC: Sebastian Reichel <s...@kernel.org>
CC: Felipe Balbi <ba...@kernel.org>
CC: Arvid Brodin <arvid.bro...@alten.se>
CC: Remi Denis-Courmont <courmi...@gmail.com>
Signed-off-by: Jarod Wilson <ja...@
@ms2.inr.ac.ru>
CC: James Morris <jmor...@namei.org>
CC: Hideaki YOSHIFUJI <yoshf...@linux-ipv6.org>
CC: Patrick McHardy <ka...@trash.net>
Signed-off-by: Jarod Wilson <ja...@redhat.com>
---
net/ipv4/ip_tunnel.c | 6 +-
net/ipv6/ip6_tunnel.c | 4 +++-
net/ipv6/ip6
.@qlogic.com>
CC: Rajesh Borundia <rajesh.borun...@qlogic.com>
CC: Timur Tabi <ti...@codeaurora.org>
CC: Anirudha Sarangi <anir...@xilinx.com>
CC: John Linn <john.l...@xilinx.com>
Signed-off-by: Jarod Wilson <ja...@redhat.com>
---
drivers/net/ethernet/alte
hat.com>
CC: Shrikrishna Khare <skh...@vmware.com>
CC: "VMware, Inc." <pv-driv...@vmware.com>
CC: Wei Liu <wei.l...@citrix.com>
CC: Paul Durrant <paul.durr...@citrix.com>
CC: David Kershner <david.kersh...@unisys.com>
Signed-off-by: Jarod Wilson <ja...@redhat.com>
CC: Roopa Prabhu <ro...@cumulusnetworks.com>
CC: Pravin B Shelar <pshe...@ovn.org>
CC: Sabrina Dubroca <s...@queasysnail.net>
CC: Patrick McHardy <ka...@trash.net>
CC: Stephen Hemminger <step...@networkplumber.org>
CC: Pravin Shelar <pshe...@nicira.com>
CC: Max
ctcm:
- min_mtu = 576, max_mtu = 65527
netiucv:
- min_mtu = 576, max_mtu = 65535
qeth:
- min_mtu = 64, max_mtu = 65535
CC: netdev@vger.kernel.org
CC: linux-s...@vger.kernel.org
CC: Ursula Braun <ubr...@linux.vnet.ibm.com>
Signed-off-by: Jarod Wilson <ja...@redhat.com>
---
driv
at commit 7b1536ef0aa0.
Jarod Wilson (9):
ethernet: use net core MTU range checking in more drivers
net: use core MTU range checking in USB NIC drivers
net: use core MTU range checking in wireless drivers
net: use core MTU range checking in WAN drivers
net: use core MTU range checking in core
On Thu, Oct 20, 2016 at 12:38:46AM +0200, Stefan Richter wrote:
> On Oct 19 Sabrina Dubroca wrote:
> > 2016-10-18, 22:33:33 -0400, Jarod Wilson wrote:
> > [...]
> > > diff --git a/drivers/firewire/net.c b/drivers/firewire/net.c
> > > index 309311b..b5f125c 100644
&
On Wed, Oct 19, 2016 at 03:10:05PM -0400, David Miller wrote:
> From: Jarod Wilson <ja...@redhat.com>
> Date: Tue, 18 Oct 2016 22:33:27 -0400
>
> > This stack of patches should get absolutely everything in the kernel
> > converted from doing their own MTU range che
On Wed, Oct 19, 2016 at 05:28:00PM +0200, Sabrina Dubroca wrote:
> 2016-10-19, 10:40:06 -0400, Jarod Wilson wrote:
> > On Wed, Oct 19, 2016 at 03:55:29PM +0200, Sabrina Dubroca wrote:
> > > 2016-10-18, 22:33:31 -0400, Jarod Wilson wrote:
...
> > I'm thinking more and more t
On Wed, Oct 19, 2016 at 02:07:47PM +, Haiyang Zhang wrote:
>
>
> > -Original Message-
> > From: Jarod Wilson [mailto:ja...@redhat.com]
> > Sent: Tuesday, October 18, 2016 10:34 PM
> > To: linux-ker...@vger.kernel.org
> > Cc: Jarod Wilson <ja
On Wed, Oct 19, 2016 at 02:17:03PM +0200, Jiri Benc wrote:
> On Tue, 18 Oct 2016 22:33:31 -0400, Jarod Wilson wrote:
> > --- a/drivers/net/vxlan.c
> > +++ b/drivers/net/vxlan.c
> > @@ -2367,43 +2367,31 @@ static void vxlan_set_multicast_list(struct
On Wed, Oct 19, 2016 at 03:55:29PM +0200, Sabrina Dubroca wrote:
> 2016-10-18, 22:33:31 -0400, Jarod Wilson wrote:
> > geneve:
> > - Merge __geneve_change_mtu back into geneve_change_mtu, set max_mtu
> > - This one isn't quite as straight-forward as others, could use some
&g
On Wed, Oct 19, 2016 at 09:38:33AM +0200, Johannes Berg wrote:
> On Tue, 2016-10-18 at 22:33 -0400, Jarod Wilson wrote:
> > - set max_mtu in wil6210 driver
> > - set max_mtu in atmel driver
> > - set min/max_mtu in cisco airo driver, remove airo_change_mtu
> > - set min
On Wed, Oct 19, 2016 at 05:03:43PM +0300, Michael S. Tsirkin wrote:
> On Wed, Oct 19, 2016 at 04:59:46PM +0300, Michael S. Tsirkin wrote:
> > On Tue, Oct 18, 2016 at 10:33:32PM -0400, Jarod Wilson wrote:
> > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
&
On Wed, Oct 19, 2016 at 04:59:46PM +0300, Michael S. Tsirkin wrote:
> On Tue, Oct 18, 2016 at 10:33:32PM -0400, Jarod Wilson wrote:
> > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> > index fad84f3..4885a42 100644
> > --- a/drivers/net/virtio_net.c
com>
CC: "Michael S. Tsirkin" <m...@redhat.com>
CC: Shrikrishna Khare <skh...@vmware.com>
CC: "VMware, Inc." <pv-driv...@vmware.com>
Signed-off-by: Jarod Wilson <ja...@redhat.com>
---
drivers/net/hyperv/hyperv_net.h | 4 ++--
drivers/net/hyperv/netvsc_d
monwunderlich.de>
CC: Antonio Quartulli <a...@unstable.cc>
Signed-off-by: Jarod Wilson <ja...@redhat.com>
---
drivers/firewire/net.c | 12 ++--
drivers/infiniband/hw/nes/nes.c | 1 -
drivers/infiniband/hw/nes/nes.h | 4 ++--
drivers/infiniband/hw/nes/
On Tue, Oct 18, 2016 at 06:28:20PM -0400, Jarod Wilson wrote:
> On Tue, Oct 18, 2016 at 11:33:27AM -0400, David Miller wrote:
> > From: Jarod Wilson <ja...@redhat.com>
> > Date: Mon, 17 Oct 2016 16:29:43 -0400
> >
> > > On Mon, Oct 17, 2016 at 04:03:41PM -0
snetworks.com>
CC: Pravin B Shelar <pshe...@ovn.org>
CC: Sabrina Dubroca <s...@queasysnail.net>
CC: Patrick McHardy <ka...@trash.net>
CC: Stephen Hemminger <step...@networkplumber.org>
CC: Pravin Shelar <pshe...@nicira.com>
Signed-of
...@vger.kernel.org
CC: Maya Erez <qca_me...@qca.qualcomm.com>
CC: Simon Kelley <si...@thekelleys.org.uk>
CC: Stanislav Yakovlev <stas.yakov...@gmail.com>
Signed-off-by: Jarod Wilson <ja...@redhat.com>
---
drivers/net/wireless/ath/wil6210/netdev.c | 17 +-
gt;
CC: Francois Romieu <rom...@fr.zoreil.com>
CC: Kevin Curtis <kevin.cur...@farsite.co.uk>
CC: Zhao Qiang <qiang.z...@nxp.com>
Signed-off-by: Jarod Wilson <ja...@redhat.com>
---
drivers/char/pcmcia/synclink_cs.c | 1 -
drivers/net/wan/c101.c| 1 -
drivers/net/w
CC: Hayes Wang <hayesw...@realtek.com>
CC: Oliver Neukum <oneu...@suse.com>
Signed-off-by: Jarod Wilson <ja...@redhat.com>
---
drivers/net/usb/lan78xx.c | 8 +++-
drivers/net/usb/r8152.c | 15 ---
drivers/net/usb/usbnet.c | 2 --
3 files changed, 15 insertion
This stack of patches should get absolutely everything in the kernel
converted from doing their own MTU range checking to the core MTU range
checking.
Jarod Wilson (6):
net: use core MTU range checking in USB NIC drivers
net: use core MTU range checking in wireless drivers
net: use core MTU
On Tue, Oct 18, 2016 at 11:33:27AM -0400, David Miller wrote:
> From: Jarod Wilson <ja...@redhat.com>
> Date: Mon, 17 Oct 2016 16:29:43 -0400
>
> > On Mon, Oct 17, 2016 at 04:03:41PM -0400, David Miller wrote:
> >> From: Jarod Wilson <ja...@redhat.com>
> &
On Tue, Oct 18, 2016 at 04:45:51PM +0300, Denis Kirjanov wrote:
> On 10/17/16, Jarod Wilson <ja...@redhat.com> wrote:
> > dl2k: min_mtu 68, max_mtu 1536 or 8000, depending on hardware
> > - Removed change_mtu, does nothing productive anymore
> >
> > sundance: mi
On Mon, Oct 17, 2016 at 04:03:41PM -0400, David Miller wrote:
> From: Jarod Wilson <ja...@redhat.com>
> Date: Mon, 17 Oct 2016 15:54:02 -0400
>
> > For the most part, every patch does the same essential thing: removes the
> > MTU range checking from the drivers' nd
On Mon, Oct 17, 2016 at 04:07:12PM -0400, Jarod Wilson wrote:
> On Mon, Oct 17, 2016 at 01:25:53PM -0400, David Miller wrote:
> > From: Jakub Kicinski <kubak...@wp.pl>
> > Date: Mon, 17 Oct 2016 18:20:49 +0100
> >
> > > Hm. I must be missing something real
nt that set, which should theoretically make this problem go away, but I
can also try to rework things if need be to restore intermediate jumbo
frames functionality. (And there are actually non-ethernet devices that
also call ether_setup and may or may not have larger than 1500 mtu that
aren't yet addressed by that follow-on set).
--
Jarod Wilson
ja...@redhat.com
9500
skge: min_mtu 60, max_mtu 9000
sky2: min_mtu 68, max_mtu 1500 or 9000, depending on hw
CC: netdev@vger.kernel.org
CC: Mirko Lindner <mlind...@marvell.com>
CC: Stephen Hemminger <step...@networkplumber.org>
CC: Thomas Petazzoni <thomas.petazz...@free-electrons.com>
Signed-of
, on top of net-next as of October 17.
Rebasing git tree with these patches can be found here:
https://github.com/jarodwilson/linux-muck
Jarod Wilson (15):
ethernet/atheros: use core min/max MTU checking
ethernet/broadcom: use core min/max MTU checking
ethernet/intel: use core min/max MTU
ev_set_mtu
ixgbe: min_mtu 68, max_mtu 9710
ixgbevf: min_mtu 68, max_mtu dependent on hardware/firmware
- Some hw can only handle up to max_mtu 1504 on a vf, others 9710
CC: netdev@vger.kernel.org
CC: intel-wired-...@lists.osuosl.org
CC: Jeff Kirsher <jeffrey.t.kirs...@intel.com>
Signed-off-
qede: min_mtu 46, max_mtu 9600
- Put define for max in qede.h
qlcnic: min_mtu 68, max_mtu 9600
CC: netdev@vger.kernel.org
CC dept-gelinuxnic...@qlogic.com
CC: Yuval Mintz <yuval.mi...@qlogic.com>
CC: Ariel Elior <ariel.el...@qlogic.com>
Signed-off-by: Jarod Wilson <ja...@redhat.co
8139cp: min_mtu 60, max_mtu 4096
8139too: min_mtu 68, max_mtu 1770
r8169: min_mtu 60, max_mtu depends on chipset, 1500 to 9k-ish
CC: netdev@vger.kernel.org
CC: Realtek linux nic maintainers <nic_s...@realtek.com>
Signed-off-by: Jarod Wilson <ja...@redhat.com>
---
drivers/net/ethe
: netdev@vger.kernel.org
CC: Jay Cliburn <jclib...@gmail.com>
CC: Chris Snook <chris.sn...@gmail.com>
Signed-off-by: Jarod Wilson <ja...@redhat.com>
---
drivers/net/ethernet/atheros/alx/hw.h | 1 -
drivers/net/ethernet/atheros/alx/main.c | 10 ++
drivers/net/ethe
Elior <ariel.el...@qlogic.com>
CC: dept-hsglinuxnic...@qlogic.com
CC: Siva Reddy Kallam <siva.kal...@broadcom.com>
CC: Prashant Sreedharan <prash...@broadcom.com>
Signed-off-by: Jarod Wilson <ja...@redhat.com>
---
drivers/net/ethernet/broadcom/b44.c |
mlx4: min_mtu 46, max_mtu depends on hardware
mlx5: min_mtu 68, max_mtu depends on hardware
CC: netdev@vger.kernel.org
CC: Tariq Toukan <tar...@mellanox.com>
CC: Saeed Mahameed <sae...@mellanox.com>
Signed-off-by: Jarod Wilson <ja...@redhat.com>
---
drivers/net/ethe
cassini: min_mtu 60, max_mtu 9000
niu: min_mtu 68, max_mtu 9216
sungem: min_mtu 68, max_mtu 1500 (comments say jumbo mode is broken)
sunvnet: min_mtu 68, max_mtu 65535
- removed sunvnet_change_mut_common as it does nothing now
CC: netdev@vger.kernel.org
Signed-off-by: Jarod Wilson <
ehea: min_mtu 68, max_mtu 9022
- remove ehea_change_mtu, it's now redundant
emac: min_mtu 46, max_mtu 1500 or whatever gets read from OF
CC: netdev@vger.kernel.org
CC: Douglas Miller <dougm...@linux.vnet.ibm.com>
Signed-off-by: Jarod Wilson <ja...@redhat.com>
---
drivers/net/ether
;bh74...@samsung.com>
CC: Girish K S <ks.g...@samsung.com>
CC: Vipul Pandya <vipul.pan...@samsung.com>
CC: Giuseppe Cavallaro <peppe.cavall...@st.com>
CC: Alexandre Torgue <alexandre.tor...@st.com>
CC: Andy Gospodarek <a...@greyhouse.net>
CC: Wingman Kwok <w-kw..
iba.co.jp>
Signed-off-by: Jarod Wilson <ja...@redhat.com>
---
drivers/net/ethernet/toshiba/ps3_gelic_net.c | 23 --
drivers/net/ethernet/toshiba/ps3_gelic_net.h | 1 -
drivers/net/ethernet/toshiba/ps3_gelic_wireless.c | 1 -
drivers/net/ethernet/toshiba/spider_
dl2k: min_mtu 68, max_mtu 1536 or 8000, depending on hardware
- Removed change_mtu, does nothing productive anymore
sundance: min_mtu 68, max_mtu 8191
CC: netdev@vger.kernel.org
CC: Denis Kirjanov <k...@linux-powerpc.org>
Signed-off-by: Jarod Wilson <ja...@redhat.com>
---
drivers/
s2io: min_mtu 46, max_mtu 9600
vxge: min_mtu 68, max_mtu 9600
CC: netdev@vger.kernel.org
CC: Jon Mason <jdma...@kudzu.us>
Signed-off-by: Jarod Wilson <ja...@redhat.com>
---
drivers/net/ethernet/neterion/s2io.c | 9 -
drivers/net/ethernet/neterion/vxge/vxge-
tworks.com>
CC: Felix Manlunas <felix.manlu...@caviumnetworks.com>
CC: Raghu Vatsavayi <raghu.vatsav...@caviumnetworks.com>
Signed-off-by: Jarod Wilson <ja...@redhat.com>
---
drivers/net/ethernet/cavium/liquidio/lio_main.c | 15 ---
drivers/net/ethernet/cavium/
@vger.kernel.org
CC: Chris Metcalf <cmetc...@mellanox.com>
Signed-off-by: Jarod Wilson <ja...@redhat.com>
---
drivers/net/ethernet/tile/tilegx.c | 21 -
drivers/net/ethernet/tile/tilepro.c | 27 +--
2 files changed, 13 insertions(+), 35 deletions(-)
Jarod Wilson (2):
net: centralize net_device min/max MTU checking
net: deprecate eth_change_mtu, remove usage
While looking into an MTU issue with sfc, I started noticing that almost
every NIC driver with an ndo_change_mtu function implemented almost
exactly the same range checks, and in many
it's mtu, you
couldn't set it above 1500 anymore. It's now getting dev->max_mtu also set
to 4096 to remedy that.
v2: fix up lantiq_etop, missed breakage due to drive not compiling on x86
CC: netdev@vger.kernel.org
Signed-off-by: Jarod Wilson <ja...@redhat.com>
---
arc
, there should be zero functional change with this patch, it just
puts the infrastructure in place. Subsequent patches will attempt to start
using said infrastructure, with theoretically zero change in
functionality.
CC: netdev@vger.kernel.org
Signed-off-by: Jarod Wilson <ja...@redhat.com>
+ i * ETH_GSTRING_LEN,
> (flags.data & (1U << i)) ? "on" : "off");
>
> - return 0;
> + rc = 0;
> +
> +err:
> + if (strings)
> + free(strings);
> + return rc;
> }
>
> static int do_sprivflags(struct cmd_context *ctx)
> --
> 2.7.4
>
--
Jarod Wilson
ja...@redhat.com
On Sun, Oct 02, 2016 at 10:43:22PM -0400, David Miller wrote:
> From: Jakub Sitnicki <j...@redhat.com>
> Date: Fri, 30 Sep 2016 11:37:24 +0200
>
> > On Wed, Sep 28, 2016 at 10:20 PM GMT, Jarod Wilson wrote:
> >> While looking into an MTU issue with sfc, I started n
it's mtu, you
couldn't set it above 1500 anymore. It's now getting dev->max_mtu also set
to 4096 to remedy that.
v2: fix up lantiq_etop, missed breakage due to drive not compiling on x86
CC: "David S. Miller" <da...@davemloft.net>
CC: netdev@vger.kernel.org
Signed-off-by: Ja
.
Jarod Wilson (2):
net: centralize net_device min/max MTU checking
net: deprecate eth_change_mtu, remove usage
arch/m68k/emu/nfeth.c | 1 -
drivers/isdn/hysdn/hysdn_net.c| 1 -
drivers/media/dvb-core/dvb_net.c | 2
l.org
Signed-off-by: Jarod Wilson <ja...@redhat.com>
---
include/linux/netdevice.h | 4
net/core/dev.c| 12 ++--
2 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 136ae6bb..fbdf923 100644
--- a/inc
1 - 100 of 231 matches
Mail list logo
