Hello,
On 01/31/2017 02:49 PM, Javier Martinez Canillas wrote:
>
> The kernelci folks pointed out that a Samsung Exynos based board was failing
> to boot when trying to mount the rootfs via NFS, due a networking issue [0].
>
> I looked at the issue and it turned out to be
-electrons.com/source/net/ipv4/ipconfig.c#L1368
[2]: http://lxr.free-electrons.com/source/net/ipv4/ipconfig.c#L202
[3]: http://lxr.free-electrons.com/source/net/core/rtnetlink.c#L68
[4]: http://lxr.free-electrons.com/source/net/core/dev.c#L7326
Best regards,
--
Javier Martinez Canillas
Open Source
table = slic_ds26522_match,
> },
> .probe = slic_ds26522_probe,
>
Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
t(void)
> -{
> - spi_unregister_driver(_ds26522_driver);
> -}
> -
> -module_init(slic_ds26522_init);
> -module_exit(slic_ds26522_exit);
> +module_spi_driver(slic_ds26522_driver);
>
Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
-emac
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/net/ethernet/qualcomm/emac/emac.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/qualcomm/emac/emac.c
b/drivers/net/ethernet/qualcomm/emac/emac.c
index 9bf3b2b82e95..4fede4b86538
alias: of:N*T*Cbrcm,bcm6328-switchC*
alias: of:N*T*Cbrcm,bcm6328-switch
alias: of:N*T*Cbrcm,bcm3384-switchC*
alias: of:N*T*Cbrcm,bcm3384-switch
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/net/dsa/b53/b53_mmap.c | 1 +
Martinez Canillas <jav...@osg.samsung.com>
---
drivers/net/dsa/bcm_sf2.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/dsa/bcm_sf2.c b/drivers/net/dsa/bcm_sf2.c
index e218887f18b7..0427009bc924 100644
--- a/drivers/net/dsa/bcm_sf2.c
+++ b/drivers/net/dsa/bcm_sf2.c
@@ -
*Chisilicon,hns-dsaf-v2C*
alias: of:N*T*Chisilicon,hns-dsaf-v2
alias: of:N*T*Chisilicon,hns-dsaf-v1C*
alias: of:N*T*Chisilicon,hns-dsaf-v1
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c |
drivers/net/ethernet/ezchip/nps_enet.ko | grep alias
$
After this patch:
$ modinfo drivers/net/ethernet/ezchip/nps_enet.ko | grep alias
alias: of:N*T*Cezchip,nps-mgt-enetC*
alias: of:N*T*Cezchip,nps-mgt-enet
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.
: of:N*T*Chisilicon,hns-mdio
alias: of:N*T*Chisilicon,mdioC*
alias: of:N*T*Chisilicon,mdio
alias: acpi*:HISI0141:*
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/net/ethernet/hisilicon/hns_mdio.c | 1 +
1 file changed, 1 ins
*Csigma,smp8642-ethernet
alias: of:N*T*Caurora,nb8800C*
alias: of:N*T*Caurora,nb8800
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/net/ethernet/aurora/nb8800.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/aurora/nb
Hello David,
I noticed that module autoload won't be working in a bunch of platform
drivers in the net subsystem and this patch series contains the fixes.
Best regards,
Javier
Javier Martinez Canillas (7):
net: nps_enet: Fix module autoload
net: ethernet: nb8800: Fix module autoload
net
cause build regressions.
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/net/wan/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wan/Kconfig b/drivers/net/wan/Kconfig
index 33ab3345d333..4e9fe75d7067 100644
--- a/drivers/n
$
After this patch:
$ modinfo drivers/net/wan/slic_ds26522.ko | grep alias
alias: spi:ds26522
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/net/wan/slic_ds26522.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/net/wan/slic_ds265
of an OF one, but that could change so it's better to always export it.
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/net/wan/slic_ds26522.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wan/slic_ds26522.c b/drivers/net/wan/slic_ds26522.c
index 53366a
Martinez Canillas <jav...@osg.samsung.com>
---
drivers/net/ethernet/sis/sis900.c | 4 ++--
drivers/net/ethernet/sis/sis900.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/sis/sis900.c
b/drivers/net/ethernet/sis/sis900.c
index 95001ee408ab..6f8527
Martinez Canillas <jav...@osg.samsung.com>
---
drivers/net/ethernet/freescale/fsl_pq_mdio.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fsl_pq_mdio.c
b/drivers/net/ethernet/freescale/fsl_pq_mdio.c
index f3c63dce1e30..446c7b
Martinez Canillas <jav...@osg.samsung.com>
---
drivers/net/ethernet/adaptec/starfire.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/adaptec/starfire.c
b/drivers/net/ethernet/adaptec/starfire.c
index 1d1069641d81..8af2c88d5b33 100644
--- a/drive
Martinez Canillas <jav...@osg.samsung.com>
---
drivers/net/ethernet/broadcom/bnx2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/bnx2.c
b/drivers/net/ethernet/broadcom/bnx2.c
index 8fc3f3c137f8..ecd357dbb1d4 100644
--- a/drivers/net/et
Martinez Canillas <jav...@osg.samsung.com>
---
drivers/net/ethernet/dlink/sundance.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/dlink/sundance.c
b/drivers/net/ethernet/dlink/sundance.c
index 58c6338a839e..79d80090eac8 100644
--- a/drivers/net/et
Martinez Canillas <jav...@osg.samsung.com>
---
drivers/net/ethernet/intel/ixgbe/ixgbe.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe.h
b/drivers/net/ethernet/intel/ixgbe/ixgbe.h
index 33c025055011..b06e32d0d22a 100644
--- a/d
Martinez Canillas <jav...@osg.samsung.com>
---
drivers/net/ethernet/amd/7990.c | 6 +++---
drivers/net/ethernet/amd/amd8111e.c | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/amd/7990.c b/drivers/net/ethernet/amd/7990.c
index dcf2a1
by helping abstract away some
of the Kconfig built-in and module enable details.
[0]: https://lkml.org/lkml/2016/9/9/323
Best regards,
Javier
Javier Martinez Canillas (15):
3c59x: use IS_ENABLED() instead of checking for built-in or module
starfire: use IS_ENABLED() instead of checking for built
Martinez Canillas <jav...@osg.samsung.com>
---
drivers/net/ethernet/i825xx/82596.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/i825xx/82596.c
b/drivers/net/ethernet/i825xx/82596.c
index befb4ac3e2b0..ce235b776793 100644
--- a/drivers/net/et
Martinez Canillas <jav...@osg.samsung.com>
---
drivers/net/ethernet/marvell/mvneta_bm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/mvneta_bm.h
b/drivers/net/ethernet/marvell/mvneta_bm.h
index e74fd44a92f7..a32de432800c 100644
--- a/drive
Martinez Canillas <jav...@osg.samsung.com>
---
drivers/net/ethernet/sfc/falcon_boards.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/sfc/falcon_boards.c
b/drivers/net/ethernet/sfc/falcon_boards.c
index 1736f4b806af..f6883b2b5da3 100644
--- a/d
Martinez Canillas <jav...@osg.samsung.com>
---
drivers/net/ethernet/stmicro/stmmac/common.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/common.h
b/drivers/net/ethernet/stmicro/stmmac/common.h
index 2533b91f1421..d3292c4a6eda
Martinez Canillas <jav...@osg.samsung.com>
---
drivers/net/wireless/intel/iwlegacy/common.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/intel/iwlegacy/common.h
b/drivers/net/wireless/intel/iwlegacy/common.h
index 726ede391cb9..3bba521d2cd9
Martinez Canillas <jav...@osg.samsung.com>
---
drivers/net/hamradio/bpqether.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/hamradio/bpqether.c b/drivers/net/hamradio/bpqether.c
index d95a50ae996d..622ab3ab9e93 100644
--- a/drivers/net/hamradio/bpqether.c
Martinez Canillas <jav...@osg.samsung.com>
---
drivers/net/ethernet/natsemi/ns83820.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/natsemi/ns83820.c
b/drivers/net/ethernet/natsemi/ns83820.c
index eb807b0dc72a..569ade6cf85c 100644
--- a/drive
Martinez Canillas <jav...@osg.samsung.com>
---
drivers/net/ethernet/3com/3c59x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/3com/3c59x.c
b/drivers/net/ethernet/3com/3c59x.c
index 25c55ab05c7d..9133e7926da5 100644
--- a/drivers/net/ethernet/3com/3
Martinez Canillas <jav...@osg.samsung.com>
---
net/atm/lec.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/net/atm/lec.c b/net/atm/lec.c
index e574a7e9db6f..5d2693826afb 100644
--- a/net/atm/lec.c
+++ b/net/atm/lec.c
@@ -31,7 +31,7 @@
#include
/* Pro
Martinez Canillas <jav...@osg.samsung.com>
---
net/appletalk/ddp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/appletalk/ddp.c b/net/appletalk/ddp.c
index f066781be3c8..10d2bdce686e 100644
--- a/net/appletalk/ddp.c
+++ b/net/appletalk/ddp.c
@@ -1278,7 +1278,7
Martinez Canillas <jav...@osg.samsung.com>
---
net/ipv4/ip_output.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c
index 65569274efb8..b913f5bf0757 100644
--- a/net/ipv4/ip_output.c
+++ b/net/ipv4/ip_output.c
@@ -490,7
regards,
Javier
Javier Martinez Canillas (8):
appletalk: use IS_ENABLED() instead of checking for built-in or module
lec: use IS_ENABLED() instead of checking for built-in or module
net: use IS_ENABLED() instead of checking for built-in or module
ipv4: use IS_ENABLED() instead of checking
Martinez Canillas <jav...@osg.samsung.com>
---
net/xfrm/xfrm_algo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/xfrm/xfrm_algo.c b/net/xfrm/xfrm_algo.c
index 250e567ba3d6..44ac85fe2bc9 100644
--- a/net/xfrm/xfrm_algo.c
+++ b/net/xfrm/xfrm_algo.c
@@ -17,7
Martinez Canillas <jav...@osg.samsung.com>
---
net/l2tp/l2tp_core.h | 2 +-
net/l2tp/l2tp_eth.c | 4 ++--
net/l2tp/l2tp_ppp.c | 4 ++--
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/net/l2tp/l2tp_core.h b/net/l2tp/l2tp_core.h
index 5871537af387..2599af6378e4 100644
--- a/ne
Martinez Canillas <jav...@osg.samsung.com>
---
net/sctp/auth.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/sctp/auth.c b/net/sctp/auth.c
index 912eb1685a5d..f99d4855d3de 100644
--- a/net/sctp/auth.c
+++ b/net/sctp/auth.c
@@ -48,7 +48,7 @@ static struct sct
Martinez Canillas <jav...@osg.samsung.com>
---
net/sched/cls_flow.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/net/sched/cls_flow.c b/net/sched/cls_flow.c
index 2c1ae549edbf..a379bae1d74e 100644
--- a/net/sched/cls_flow.c
+++ b/net/sched/cls_flow.c
@@ -29,7
Martinez Canillas <jav...@osg.samsung.com>
---
net/core/dev.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/core/dev.c b/net/core/dev.c
index c7d7db49826d..9e76d4df6ca0 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -3904,8 +3904,7 @@ static __latent_entrop
Hello Kalle,
On 09/03/2016 12:35 PM, Kalle Valo wrote:
> Javier Martinez Canillas <jav...@osg.samsung.com> wrote:
>> If request_irq() fails in mwifiex_sdio_probe_of(), only an error message
>> is printed but the actual error is not propagated to the caller function.
>&g
Hello Arend,
On 08/18/2016 03:49 PM, Arend van Spriel wrote:
>
>
> On 18-08-16 21:29, Javier Martinez Canillas wrote:
>> Hello Arend,
>>
>> Thanks a lot for your feedback.
>>
>> On 08/18/2016 03:14 PM, Arend van Spriel wrote:
>>> O
Hello Arend,
Thanks a lot for your feedback.
On 08/18/2016 03:14 PM, Arend van Spriel wrote:
> On 18-08-16 16:17, Javier Martinez Canillas wrote:
>> If request_irq() fails in mwifiex_sdio_probe_of(), only an error message
>> is printed but the actual error is not propagate
If request_irq() fails in mwifiex_sdio_probe_of(), only an error message
is printed but the actual error is not propagated to the caller function.
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/net/wireless/marvell/mwifiex/sdio.c | 1 +
1 file changed, 1 ins
Hello Kalle,
On 07/05/2016 09:09 AM, Kalle Valo wrote:
> Javier Martinez Canillas <jav...@osg.samsung.com> writes:
>
>> The commit 7311ea850079 ("mwifiex: fix AP start problem for newly added
>> interface") attempted to fix an issue when a new AP interface is
idn't fail.
This prevents the network device to be registered properly, so fix it.
Fixes: commit 7311ea850079 ("mwifiex: fix AP start problem for newly added
interface")
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/net/wireless/marvell/mwifiex/cfg80211.c
Hello Kalle,
On 06/22/2016 02:17 AM, Kalle Valo wrote:
> Javier Martinez Canillas <jav...@osg.samsung.com> writes:
>
>>>> Patch 3/3 applies cleanly even after dropping patch 2/3.
>>>> Is that Ok for you or do you want me to re-resend a v3
>>>> w
Hello Kalle,
On 06/10/2016 03:54 PM, Kalle Valo wrote:
> Javier Martinez Canillas <jav...@osg.samsung.com> writes:
>
>>> This patch (2/3) is only for code rearrangement and adds an
>>> unnecessary wrapper function. We can simply drop the patch.
>>
>> Ag
Hello Amitkumar,
On 06/10/2016 12:26 PM, Amitkumar Karwar wrote:
> Hi Kalle/Javier,
>
>> From: Javier Martinez Canillas [mailto:jav...@osg.samsung.com]
>> Sent: Friday, June 10, 2016 8:07 PM
>> To: Kalle Valo
>> Cc: linux-ker...@vger.kernel.org; Julian Calaby; She
Hello Kalle,
On 06/10/2016 10:30 AM, Kalle Valo wrote:
> Javier Martinez Canillas <jav...@osg.samsung.com> writes:
>
>> From: Shengzhen Li <s...@marvell.com>
>>
>> Most cfg80211 operations are just a wrappers to functions defined in the
>>
not warn anymore and:
$ iw phy phy0 info | grep Antennas
Available Antennas: TX 0x3 RX 0x3
Configured Antennas: TX 0x3 RX 0x3
Signed-off-by: Shengzhen Li <s...@marvell.com>
Signed-off-by: Amitkumar Karwar <akar...@marvell.com>
[javier: expand the commit message]
Signed-off-
ta_ioctl.c file.
[0]: https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1160119.html
Best regards,
Javier
Javier Martinez Canillas (1):
mwifiex: add a cfg80211 .get_tx_power operation callback
Shengzhen Li (2):
mwifiex: move .get_tx_power logic to station ioctl file
mwifiex: add g
ll.com>
[javier: update the subject line and commit message]
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/net/wireless/marvell/mwifiex/cfg80211.c | 14 +++---
drivers/net/wireless/marvell/mwifiex/main.h | 2 ++
drivers/net/wireless/marvell/
)
[] (request_firmware_work_func) from []
(process_one_work+0x124/0x338)
[] (process_one_work) from [] (worker_thread+0x38/0x4d4)
[] (worker_thread) from [] (kthread+0xdc/0xf4)
[] (kthread) from [] (ret_from_fork+0x14/0x3c)
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/net/wireless/m
)
[] (request_firmware_work_func) from []
(process_one_work+0x124/0x338)
[] (process_one_work) from [] (worker_thread+0x38/0x4d4)
[] (worker_thread) from [] (kthread+0xdc/0xf4)
[] (kthread) from [] (ret_from_fork+0x14/0x3c)
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/net/wireless/m
by someone with access to the docs, if this is supported.
Best regards,
Javier
Javier Martinez Canillas (2):
mwifiex: add a cfg80211 .get_tx_power operation callback
mwifiex: add a cfg80211 .get_antenna operation callback
drivers/net/wireless/marvell/mwifiex/cfg80211.c | 50
0x1 RX 0x1
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
Hello,
Even though this approach prevents the warning and allows to reports the
antenna values, it would be better if instead of caching the set values,
these are asked to the firmware for each .get_
Hello Julian,
Thanks a lot for your feedback and reviews.
On 06/01/2016 12:20 AM, Julian Calaby wrote:
> Hi All,
>
> On Sat, May 28, 2016 at 12:18 AM, Javier Martinez Canillas
> <jav...@osg.samsung.com> wrote:
>> The Documentation/devicetree/bindings/net/wirele
was returned by sdio_enable_func() at fail.
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/net/wireless/marvell/mwifiex/sdio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/marvell/mwifiex/sdio.c
b/drivers/net/wireless/m
also removes the assignment of sdio_disable_func() returned value
since it was overwritten anyways and what matters is to know the error
value returned by the first function that failed.
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/net/wireless/marvell/m
esn't have a node for a SDIO dev,
the following misleading error message will be printed:
[ 12.480042] mwifiex_sdio mmc2:0001:1: sdio platform data not available
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/net/wireless/marvell/mwifiex/sdio.c | 6 +++---
1
in platforms that don't have a child
node defined.
So this series fixes this issue and others I found in the .probe function
(mostly related to error handling and the error path) while looking at it.
Best regards,
Javier
Javier Martinez Canillas (8):
mwifiex: only call mwifiex_sdio_probe_of
was not the case for
the mwifiex_add_card() error path.
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/net/wireless/marvell/mwifiex/sdio.c | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/drivers/net/wireless/marvell/mwifiex/
that makes clear what the error really is. Also, returning a -1
as errno code is not correct since that's -EPERM. A -EINVAL seems to be
a more appropriate one.
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/net/wireless/marvell/mwifiex/sdio.c | 4 ++--
It's better to have the device name prefixed in the error message.
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/net/wireless/marvell/mwifiex/sdio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/marvell/mwifiex/
The Documentation/devicetree/bindings/net/wireless/marvell-sd8xxx.txt DT
binding document say that the "interrupts" property in the child node is
optional. So the property being missed shouldn't be treated as an error.
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com&g
The function can fail so the returned value should be checked
and the error propagated to the caller in case of a failure.
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/net/wireless/marvell/mwifiex/sdio.c | 9 +++--
1 file changed, 7 insertions(+), 2 del
Hello ChenYu
On Thu, May 12, 2016 at 9:49 AM, Chen-Yu Tsai <w...@csie.org> wrote:
> Hi,
>
> On Thu, May 12, 2016 at 9:40 PM, Javier Martinez Canillas
> <jav...@dowhile0.org> wrote:
>> [adding Krzysztof as cc]
>>
>> On Thu, May 12, 2016 at
[adding Krzysztof as cc]
On Thu, May 12, 2016 at 8:25 AM, Sergei Shtylyov
wrote:
> Hello.
>
>
> On 5/12/2016 10:15 AM, Uwe Kleine-König wrote:
>
>> I have a machine here where the reset pin of the phy is connected to a
>> GPIO.
>>
>> There are different
as a module.
But also the SPI id table is not correctly defined so this series fixes both
issues.
The patches have been applied on top of the next-next tree master branch:
git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master
Best regards,
Javier
Javier Martinez Canillas (2
the struct spi_device_id
.name[0] is not NULL, so not having a sentinel can cause a NULL pointer
deference error.
This patch defines the SPI id table correctly as all other SPI drivers do.
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/net/ethernet/microchip/encx24
The driver Kconfig symbol is tristate which means that it can be built as
a module but the module alias information is not added to the module info
so module autoload won't work since user-space won't have the information.
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.
Drivers needs to export the OF id table and this be built into
the module or udev won't have the necessary information to autoload
the driver module when the device is registered via OF.
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/net/ethernet/micrel/ks
patches in this series, will break
module autoloading for the drivers of devices registered using OF but
that lacks an of_match_table. I'll repost patch #18 once all the patches
in this series have landed.
[0]: https://lkml.org/lkml/2015/7/30/519
Best regards,
Javier
Javier Martinez Canillas (18
better to also export the OF table even when
is unused now to prevent breaking module loading when the core changes.
Signed-off-by: Javier Martinez Canillas jav...@osg.samsung.com
---
drivers/net/ethernet/micrel/ks8851.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet
75 matches
Mail list logo