Re: [PATCH 08/36] aio: implement io_pgetevents

Christoph Hellwig <h...@lst.de> writes: > On Tue, Mar 20, 2018 at 11:30:29AM -0400, Jeff Moyer wrote: >> > In this commit: >> > >> > http://git.infradead.org/users/hch/libaio.git/commitdiff/49f77d595210393ce7b125cb00233cf737402f56 >> >> BTW, th

Re: [PATCH 08/36] aio: implement io_pgetevents

Christoph Hellwig writes: > On Mon, Mar 19, 2018 at 07:12:41PM -0700, Darrick J. Wong wrote: >> > Note that unlike many other signal related calls we do not pass a sigmask >> > size, as that would get us to 7 arguments, which aren't easily supported >> > by the syscall

Re: [PATCH 14/36] aio: implement IOCB_CMD_POLL

the aio_buf field of the iocb. > > Unlike poll or epoll without EPOLLONESHOT this interface always works > in one shot mode, that is once the iocb is completed, it will have to be > resubmitted. > > Signed-off-by: Christoph Hellwig <h...@lst.de> Also acked this one in th

Re: [PATCH 08/36] aio: implement io_pgetevents

h aren't easily supported > by the syscall infrastructure. It seems a lot less painful to just add a > new syscall variant in the unlikely case we're going to increase the > sigset size. > > Signed-off-by: Christoph Hellwig <h...@lst.de> I acked this in the last set, so... Acked-by: J

Re: [PATCH 08/36] aio: implement io_pgetevents

h aren't easily supported > by the syscall infrastructure. It seems a lot less painful to just add a > new syscall variant in the unlikely case we're going to increase the > sigset size. > > Signed-off-by: Christoph Hellwig <h...@lst.de> Acked-by: Jeff Moyer <jmo...@redhat.com

Re: [PATCH 14/36] aio: implement IOCB_CMD_POLL

the aio_buf field of the iocb. > > Unlike poll or epoll without EPOLLONESHOT this interface always works > in one shot mode, that is once the iocb is completed, it will have to be > resubmitted. > > Signed-off-by: Christoph Hellwig <h...@lst.de> Acked-by: Jeff Moyer <jmo...@redhat.com>

Re: aio poll, io_pgetevents and a new in-kernel poll API V3

Christoph Hellwig <h...@lst.de> writes: > On Thu, Jan 18, 2018 at 11:44:03AM -0500, Jeff Moyer wrote: >> Jeff Moyer <jmo...@redhat.com> writes: >> >> > FYI, this kernel has issues. It will boot up, but I don't have >> > networking, and

Re: aio poll, io_pgetevents and a new in-kernel poll API V3

Avi Kivity <a...@scylladb.com> writes: > On 01/18/2018 05:46 PM, Jeff Moyer wrote: >> FYI, this kernel has issues. It will boot up, but I don't have >> networking, and even rebooting doesn't succeed. I'm looking into it. > > FWIW, I'm running an older version of

Re: aio poll, io_pgetevents and a new in-kernel poll API V3

Jeff Moyer <jmo...@redhat.com> writes: > FYI, this kernel has issues. It will boot up, but I don't have > networking, and even rebooting doesn't succeed. I'm looking into it. A bisect lands on: eventfd: switch to ->poll_mask. That's not super helpful, though. I did run the ltp

Re: aio poll, io_pgetevents and a new in-kernel poll API V3

FYI, this kernel has issues. It will boot up, but I don't have networking, and even rebooting doesn't succeed. I'm looking into it. -Jeff Christoph Hellwig writes: > Hi all, > > this series adds support for the IOCB_CMD_POLL operation to poll for the > readyness of file

Re: [PATCH 32/32] aio: implement io_pgetevents

Christoph Hellwig <h...@lst.de> writes: > On Tue, Jan 16, 2018 at 07:41:24PM -0500, Jeff Moyer wrote: >> I'd be willing to bet the issue is in your io_syscall6 implementation. >> You pass in arg5 where arg6 should be used. Don't feel bad, it took me >> the better part

Re: [PATCH 32/32] aio: implement io_pgetevents

Christoph Hellwig <h...@lst.de> writes: > On Wed, Jan 17, 2018 at 04:27:21AM +, Al Viro wrote: >> On Tue, Jan 16, 2018 at 07:41:24PM -0500, Jeff Moyer wrote: >> >if (sigmask) { >> > - if (copy_from_user(, sigmask, sizeof(ksigmask))) >>

Re: [PATCH 32/32] aio: implement io_pgetevents

Hi, Christoph, Christoph Hellwig writes: > On Mon, Jan 15, 2018 at 09:53:10AM +0100, Christoph Hellwig wrote: >> > pselect, as an example, crams the sigmask and size together. Why not >> > just do that? libaio can take care of setting that up. >> >> Yes, I could try that. It's

Re: [PATCH 32/32] aio: implement io_pgetevents

Christoph Hellwig writes: > This is the io_getevents equivalent of ppoll/pselect and allows to > properly mix signals and aio completions (especially with IOCB_CMD_POLL) > and atomically executes the following sequence: > > sigset_t origmask; > >

Re: [PATCH 30/32] aio: add delayed cancel support

Christoph Hellwig <h...@lst.de> writes: > On Wed, Jan 10, 2018 at 06:26:39PM -0500, Jeff Moyer wrote: >> >> The upcoming aio poll support would like to be able to complete the >> >> iocb inline from the cancellation context, but that would cause >>

Re: aio poll, io_pgetevents and a new in-kernel poll API V2

"Michael Kerrisk (man-pages)" writes: Hi, Michael, > Are there some man pages patches already for these changes? https://patchwork.kernel.org/patch/10144129/ Cheers, Jeff

Re: [PATCH 30/32] aio: add delayed cancel support

Jeff Moyer <jmo...@redhat.com> writes: > Christoph Hellwig <h...@lst.de> writes: > >> The upcoming aio poll support would like to be able to complete the >> iocb inline from the cancellation context, but that would cause >> a lock order reversal. Add support f

Re: [PATCH 30/32] aio: add delayed cancel support

text lock to avoid this reversal. > > Signed-off-by: Christoph Hellwig <h...@lst.de> Acked-by: Jeff Moyer <jmo...@redhat.com>

Re: [PATCH 29/32] aio: delete iocbs from the active_reqs list in kiocb_cancel

Christoph Hellwig <h...@lst.de> writes: > One we cancel an iocb there is no reason to keep it on the active_reqs > list, given that the list is only used to look for cancelation candidates. > > Signed-off-by: Christoph Hellwig <h...@lst.de> Acked-by: Jeff Moyer <jmo...@redhat.com>

Re: [PATCH 28/32] aio: simplify cancellation

ensure only the completion path or the cancellation path delivered the completion event. Now, the completion is always delivered via aio_complete. So yeah, we can get rid of this. Acked-by: Jeff Moyer <jmo...@redhat.com>

Re: [PATCH 27/32] aio: sanitize ki_list handling

spin_lock_irqsave(>ctx_lock, flags); > + list_add_tail(>ki_list, >active_reqs); > req->ki_cancel = cancel; So, this changes behavior from quietly overwriting the prior cancel function to not doing it. I don't think it matters one bit, though. Callers shouldn't do that. Acked-by: Jeff Moyer <jmo...@redhat.com>

Re: [PATCH 26/32] aio: refactor read/write iocb setup

ffset; > + req->ki_flags = iocb_flags(req->ki_filp); because of this. Acked-by: Jeff Moyer <jmo...@redhat.com>

Re: [PATCH 24/31] aio: remove an outdated comment in aio_complete

<h...@lst.de> Right, this should have been part of commit 599bd19bdc4c6 ("fs: don't allow to complete sync iocbs through aio_complete"). Reviewed-by: Jeff Moyer <jmo...@redhat.com> > --- > fs/aio.c | 11 ++- > 1 file changed, 2 insertions(+), 9 deletions(-) >

Re: [PATCH 23/31] aio: don't print the page size at boot time

Christoph Hellwig <h...@lst.de> writes: > The page size is in no way related to the aio code, and printing it in > the (debug) dmesg at every boot serves no purpose. > > Signed-off-by: Christoph Hellwig <h...@lst.de> Acked-by: Jeff Moyer <jmo...@redhat.com>

Re: [PATCH 6/6] add test for aio poll and io_pgetevents

Christoph Hellwig writes: > + p = fork(); > + switch (p) { [snip] > + default: > + close(pipe1[0]); > + close(pipe2[1]); > + > + io_prep_poll(, pipe2[0], POLLIN); > + > + ret = io_setup(1, ); > + if (ret) { > +

Re: libaio: resurrect aio poll and add io_pgetevents support

Christoph Hellwig writes: > Hi all, > > this series resurrects IOCB_CMD_POLL support and adds support for the > new io_pgetevents system call, as well as adding a test case. This looks good to me. There may be a couple of changes to the syscall bits, but I can take care of that.

Re: [PATCH 2/6] move _body_io_syscall to the generic syscall.h

Hi, Ben, Thanks for the quick reply. Benjamin LaHaise <b...@communityfibre.ca> writes: > On Fri, Jan 05, 2018 at 11:25:17AM -0500, Jeff Moyer wrote: >> Christoph Hellwig <h...@lst.de> writes: >> >> > This way it can be used for the fallback 6-argume

Re: [PATCH 2/6] move _body_io_syscall to the generic syscall.h

Christoph Hellwig writes: > This way it can be used for the fallback 6-argument version on > all architectures. > > Signed-off-by: Christoph Hellwig This is a strange way to do things. However, I was never really sold on libaio having to implement its own system call

Re: [PATCH 1/2] e1000: fix netpoll with NAPI

== Regarding Re: [PATCH 1/2] e1000: fix netpoll with NAPI; Mitch Williams [EMAIL PROTECTED] adds: mitch.a.williams On Wed, 2006-06-07 at 11:44 -0700, Jeff Moyer wrote: That patch locks around the tx clean routine. As such, it doesn't prevent the problem. mitch.a.williams The call

Re: [PATCH 1/2] e1000: fix netpoll with NAPI

== Regarding Re: [PATCH 1/2] e1000: fix netpoll with NAPI; Auke Kok [EMAIL PROTECTED] adds: auke-jan.h.kok Hi, auke-jan.h.kok we're not too happy with this as it puts a branch right in auke-jan.h.kok the regular receive path. We haven't ran the numbers on it auke-jan.h.kok yet but it is likely

Re: [PATCH 1/2] e1000: fix netpoll with NAPI

== Regarding Re: [PATCH 1/2] e1000: fix netpoll with NAPI; Mitch Williams [EMAIL PROTECTED] adds: mitch On Tue, 2006-06-06 at 09:52 -0400, Neil Horman wrote: I've been speaking about this fix with a Jeff Moyer, and we've come up with some concerns regarding its implementation. Specifically

Re: [PATCH 1/2] e1000: fix netpoll with NAPI

== Regarding Re: [PATCH 1/2] e1000: fix netpoll with NAPI; Auke Kok [EMAIL PROTECTED] adds: auke-jan.h.kok Jeff Moyer wrote: == Regarding Re: [PATCH 1/2] e1000: fix netpoll with NAPI; Auke Kok [EMAIL PROTECTED] adds: auke-jan.h.kok Neil Horman wrote: On Tue, Jun 06, 2006 at 09:39:25AM -0700