Re: [PATCH 05/47] net: remove cris etrax ethernet driver
On Wed, Mar 14, 2018 at 04:35:18PM +0100, Arnd Bergmann wrote: > The cris architecture is getting removed, so we don't need the > ethernet driver any more either. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> Acked-by: Jesper Nilsson <jesper.nils...@axis.com> > --- > drivers/net/Makefile |1 - > drivers/net/cris/Makefile |1 - > drivers/net/cris/eth_v10.c | 1742 > > 3 files changed, 1744 deletions(-) > delete mode 100644 drivers/net/cris/Makefile > delete mode 100644 drivers/net/cris/eth_v10.c > > diff --git a/drivers/net/Makefile b/drivers/net/Makefile > index 04c3b747812c..91e67e375dd4 100644 > --- a/drivers/net/Makefile > +++ b/drivers/net/Makefile > @@ -40,7 +40,6 @@ obj-$(CONFIG_ARCNET) += arcnet/ > obj-$(CONFIG_DEV_APPLETALK) += appletalk/ > obj-$(CONFIG_CAIF) += caif/ > obj-$(CONFIG_CAN) += can/ > -obj-$(CONFIG_ETRAX_ETHERNET) += cris/ > obj-$(CONFIG_NET_DSA) += dsa/ > obj-$(CONFIG_ETHERNET) += ethernet/ > obj-$(CONFIG_FDDI) += fddi/ > diff --git a/drivers/net/cris/Makefile b/drivers/net/cris/Makefile > deleted file mode 100644 > index b4e8932227b6.. > diff --git a/drivers/net/cris/eth_v10.c b/drivers/net/cris/eth_v10.c > deleted file mode 100644 > index 8b1a859f5140.. > -- > 2.9.0 /^JN - Jesper Nilsson -- Jesper Nilsson -- jesper.nils...@axis.com
Re: [PATCH v2 0/7] uapi: export all headers under uapi directories
On Mon, Jan 09, 2017 at 12:33:58PM +0100, Arnd Bergmann wrote: > On Friday, January 6, 2017 10:43:52 AM CET Nicolas Dichtel wrote: > > Here is the v2 of this series. The first 5 patches are just cleanup: some > > exported headers were still under a non-uapi directory. > > Since this is meant as a cleanup, I commented on this to point out a cleaner > way to do the same. > > > The patch 6 was spotted by code review: there is no in-tree user of this > > functionality. > > The last patch remove the use of header-y. Now all files under an uapi > > directory are exported. > > Very nice! > > > asm is a bit special, most of architectures export > > asm//include/uapi/asm > > only, but there is two exceptions: > > - cris which exports arch/cris/include/uapi/arch-v[10|32]; > > This is interesting, though not your problem. Maybe someone who understands > cris better can comment on this: How is the decision made about which of > the arch/user.h headers gets used? I couldn't find that in the sources, > but it appears to be based on kernel compile-time settings, which is > wrong for user space header files that should be independent of the kernel > config. I believe it's since the CRISv10 and CRISv32 are very different beasts, and that is selected via kernel config... This part of the CRIS port has been transformed a couple of times from the original layout without uapi, and there's still some legacy silliness, where some files might have been exported but never used from userspace except for some corner cases. > > - tile which exports arch/tile/include/uapi/arch. > > Because I don't know if the output of 'make headers_install_all' can be > > changed, > > I introduce subdir-y in Kbuild file. The headers_install_all target copies > > all > > asm//include/uapi/asm to usr/include/asm- but > > arch/cris/include/uapi/arch-v[10|32] and arch/tile/include/uapi/arch are not > > prefixed (they are put asis in usr/include/). If it's acceptable to modify > > the > > output of 'make headers_install_all' to export asm headers in > > usr/include/asm-/asm, then I could remove this new subdir-y and > > exports > > everything under arch//include/uapi/. > > I don't know if anyone still uses "make headers_install_all", I suspect > distros these days all use "make headers_install", so it probably > doesn't matter much. > > In case of cris, it should be easy enough to move all the contents of the > uapi/arch-*/*.h headers into the respective uapi/asm/*.h headers, they > only seem to be referenced from there. This would seem to be a reasonable change. > For tile, I suspect that would not work as the arch/*.h headers are > apparently defined as interfaces for both user space and kernel. > > > Note also that exported files for asm are a mix of files listed by: > > - include/uapi/asm-generic/Kbuild.asm; > > - arch/x86/include/uapi/asm/Kbuild; > > - arch/x86/include/asm/Kbuild. > > This complicates a lot the processing (arch/x86/include/asm/Kbuild is also > > used by scripts/Makefile.asm-generic). > > > > This series has been tested with a 'make headers_install' on x86 and a > > 'make headers_install_all'. I've checked the result of both commands. > > > > This patch is built against linus tree. I don't know if it should be > > made against antoher tree. > > The series should probably get merged through the kbuild tree, but testing > it on mainline is fine here. > > Arnd /^JN - Jesper Nilsson -- Jesper Nilsson -- jesper.nils...@axis.com
[PATCH v2] net: phy: dp83848: Support ethernet pause frames
According to the documentation, the PHYs supported by this driver
can also support pause frames. Announce this to be so.
Tested with a TI83822I.
Acked-by: Andrew F. Davis <a...@ti.com>
Signed-off-by: Jesper Nilsson <jesper.nils...@axis.com>
---
drivers/net/phy/dp83848.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/phy/dp83848.c b/drivers/net/phy/dp83848.c
index 800b39f..320d0dc 100644
--- a/drivers/net/phy/dp83848.c
+++ b/drivers/net/phy/dp83848.c
@@ -88,7 +88,9 @@ MODULE_DEVICE_TABLE(mdio, dp83848_tbl);
.phy_id = _id, \
.phy_id_mask= 0xfff0, \
.name = _name,\
- .features = PHY_BASIC_FEATURES, \
+ .features = (PHY_BASIC_FEATURES | \
+ SUPPORTED_Pause |\
+ SUPPORTED_Asym_Pause), \
.flags = PHY_HAS_INTERRUPT,\
\
.soft_reset = genphy_soft_reset,\
--
2.1.4
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nils...@axis.com
Re: [PATCH] net: phy: dp83848: Support ethernet pause frames
On Fri, Dec 02, 2016 at 08:35:23AM -0600, Andrew F. Davis wrote: > On 12/02/2016 08:22 AM, Jesper Nilsson wrote: > > According to the documentation, the PHYs supported by this driver > > can also support pause frames. Announce this to be so. > > Tested with a TI83822I. > > > > Looks like all PHYs supported by this driver do, so: > > Acked-by: Andrew F. Davis <a...@ti.com> > > > Signed-off-by: Jesper Nilsson <jesper.nils...@axis.com> > > --- > > drivers/net/phy/dp83848.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/net/phy/dp83848.c b/drivers/net/phy/dp83848.c > > index 800b39f..6e4117f 100644 > > --- a/drivers/net/phy/dp83848.c > > +++ b/drivers/net/phy/dp83848.c > > @@ -88,7 +88,8 @@ MODULE_DEVICE_TABLE(mdio, dp83848_tbl); > > .phy_id = _id, \ > > .phy_id_mask= 0xfff0, \ > > .name = _name,\ > > - .features = PHY_BASIC_FEATURES, \ > > + .features = (PHY_BASIC_FEATURES | \ > > + SUPPORTED_Pause | SUPPORTED_Asym_Pause),\ > > Aligning these may look nicer though. Agreed, will send a v2. > > .flags = PHY_HAS_INTERRUPT, \ > > \ > > .soft_reset = genphy_soft_reset,\ > > /^JN - Jesper Nilsson -- Jesper Nilsson -- jesper.nils...@axis.com
[PATCH] net: phy: dp83848: Support ethernet pause frames
According to the documentation, the PHYs supported by this driver can also support pause frames. Announce this to be so. Tested with a TI83822I. Signed-off-by: Jesper Nilsson <jesper.nils...@axis.com> --- drivers/net/phy/dp83848.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/phy/dp83848.c b/drivers/net/phy/dp83848.c index 800b39f..6e4117f 100644 --- a/drivers/net/phy/dp83848.c +++ b/drivers/net/phy/dp83848.c @@ -88,7 +88,8 @@ MODULE_DEVICE_TABLE(mdio, dp83848_tbl); .phy_id = _id, \ .phy_id_mask= 0xfff0, \ .name = _name,\ - .features = PHY_BASIC_FEATURES, \ + .features = (PHY_BASIC_FEATURES | \ + SUPPORTED_Pause | SUPPORTED_Asym_Pause),\ .flags = PHY_HAS_INTERRUPT,\ \ .soft_reset = genphy_soft_reset,\ -- 2.1.4 /^JN - Jesper Nilsson -- Jesper Nilsson -- jesper.nils...@axis.com
Re: [PATCH 10/10] mm: replace access_process_vm() write parameter with gup_flags
On Thu, Oct 13, 2016 at 01:20:20AM +0100, Lorenzo Stoakes wrote: > This patch removes the write parameter from access_process_vm() and replaces > it > with a gup_flags parameter as use of this function previously _implied_ > FOLL_FORCE, whereas after this patch callers explicitly pass this flag. > > We make this explicit as use of FOLL_FORCE can result in surprising behaviour > (and hence bugs) within the mm subsystem. > > Signed-off-by: Lorenzo Stoakes <lstoa...@gmail.com> > --- > arch/cris/arch-v32/kernel/ptrace.c | 4 ++-- For the CRIS part: Acked-by: Jesper Nilsson <jesper.nils...@axis.com> /^JN - Jesper Nilsson -- Jesper Nilsson -- jesper.nils...@axis.com
Re: [PATCH 06/10] mm: replace get_user_pages() write/force parameters with gup_flags
On Thu, Oct 13, 2016 at 01:20:16AM +0100, Lorenzo Stoakes wrote: > This patch removes the write and force parameters from get_user_pages() and > replaces them with a gup_flags parameter to make the use of FOLL_FORCE > explicit > in callers as use of this flag can result in surprising behaviour (and hence > bugs) within the mm subsystem. > > Signed-off-by: Lorenzo Stoakes <lstoa...@gmail.com> > --- > arch/cris/arch-v32/drivers/cryptocop.c | 4 +--- For the CRIS part: Acked-by: Jesper Nilsson <jesper.nils...@axis.com> /^JN - Jesper Nilsson -- Jesper Nilsson -- jesper.nils...@axis.com
