Re: cleanup unused or almost unused IOMMU APIs and the FSL PAMU driver v3

2021-04-07 Thread Joerg Roedel
On Thu, Apr 01, 2021 at 05:52:36PM +0200, Christoph Hellwig wrote: > Diffstat: > arch/powerpc/include/asm/fsl_pamu_stash.h | 12 > drivers/gpu/drm/msm/adreno/adreno_gpu.c |5 > drivers/iommu/amd/iommu.c | 23 > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 75 -

Re: cleanup unused or almost unused IOMMU APIs and the FSL PAMU driver

2021-03-04 Thread Joerg Roedel
On Mon, Mar 01, 2021 at 09:42:40AM +0100, Christoph Hellwig wrote: > Diffstat: > arch/powerpc/include/asm/fsl_pamu_stash.h | 12 > drivers/gpu/drm/msm/adreno/adreno_gpu.c |2 > drivers/iommu/amd/iommu.c | 23 > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 85 -

Re: [PATCH v1] ACPI: Switch to use generic UUID API

2017-05-04 Thread Joerg Roedel
; - obj = acpi_evaluate_dsm_typed(handle, dmar_hp_uuid, DMAR_DSM_REV_ID, > + obj = acpi_evaluate_dsm_typed(handle, &dmar_hp_uuid, DMAR_DSM_REV_ID, > func, NULL, ACPI_TYPE_BUFFER); > if (!obj) > return -ENODEV; DMAR part is Acked-by: Joerg Roedel

Re: [REGRESSION next-20170426] Commit 09515ef5ddad ("of/acpi: Configure dma operations at probe time for platform/amba/pci bus devices") causes oops in mvneta

2017-04-28 Thread Joerg Roedel
On Fri, Apr 28, 2017 at 06:48:33PM +0530, Sricharan R wrote: > Also, probably this patch now going through the iommu tree looks more apt, > as its for probe-deferral. > Joerg, is that correct ? Definitly. Please send the patch directly to me and I put it in the tree. Thanks, Joerg

Re: [REGRESSION next-20170426] Commit 09515ef5ddad ("of/acpi: Configure dma operations at probe time for platform/amba/pci bus devices") causes oops in mvneta

2017-04-27 Thread Joerg Roedel
Sricharan, On Wed, Apr 26, 2017 at 06:15:08PM +0200, Ralph Sennhauser wrote: > Commit 09515ef5ddad ("of/acpi: Configure dma operations at probe time > for platform/amba/pci bus devices") causes a kernel panic as in the log > below on an armada-385. Reverting the commit fixes the issue. Any insigh

Re: [PATCH] bnx2: Reset device during driver initialization

2016-09-09 Thread Joerg Roedel
Hi Baoquan, On Fri, Sep 09, 2016 at 04:22:25PM +0800, Baoquan He wrote: > Recently I tried to fix the kdump failure in amd iommu system again, and > now the latest code works, IO_PAGE_FAULT can't be seen any more. But on > several amd iommu system with bnx2 NIC, always IO_PAGE_FAULT will be > pri

Re: [v7, 4/5] powerpc/fsl: move mpc85xx.h to include/linux/fsl

2016-04-05 Thread Joerg Roedel
On Fri, Apr 01, 2016 at 11:07:30AM +0800, Yangbo Lu wrote: > Move mpc85xx.h to include/linux/fsl and rename it to svr.h as > a common header file. It has been used for mpc85xx and it will > be used for ARM-based SoC as well. > > Signed-off-by: Yangbo Lu > Acked-by: Wolfram Sang

[BUG] be2net breaks when dma_alloc_coherent memory is not zeroed out

2015-06-02 Thread Joerg Roedel
Hi, yesterday I bisected an issue with one of my be2net adapters and AMD IOMMU enabled. In 4.1-rc it suddenly broke and didn't initialize anymore. It turned out that the be2net driver breaks when the memory returned from dma_alloc_coherent is not zeroed out. I introduced that change to the AMD IOM

Re: [PATCH 01/02 V3] net/ipv6: seperate sit driver to extra module

2006-10-14 Thread Joerg Roedel
On Sat, Oct 14, 2006 at 01:09:39AM +0200, Jan Dittmer wrote: > David Miller wrote: > > From: Joerg Roedel <[EMAIL PROTECTED]> > > Date: Fri, 13 Oct 2006 21:17:45 +0200 > > > >> On Fri, Oct 13, 2006 at 08:12:06PM +0200, Jan Dittmer wrote: > >>> T

Re: [PATCH 01/02 V3] net/ipv6: seperate sit driver to extra module

2006-10-13 Thread Joerg Roedel
On Fri, Oct 13, 2006 at 08:12:06PM +0200, Jan Dittmer wrote: > This is missing the MODULE_LICENSE statements and taints the kernel upon > loading. License is obvious from the beginning of the file. Ah, ok. I forgot that. Thanks for the fix. > Joerg Roedel wrote: > > --- linux-2.6

[PATCH 02/02 V3] net/ipv6: seperate sit driver to extra module (addrconf.c changes)

2006-10-10 Thread Joerg Roedel
This patch contains the changes to net/ipv6/addrconf.c to remove sit specific code if the sit driver is not selected. Signed-off-by: Joerg Roedel <[EMAIL PROTECTED]> Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> diff -upr -X linux-2.6.18/Documentation/dontdiff linux-2.6.18

[PATCH 02/02 V3] net/ipv6: seperate sit driver to extra module (addrconf.c changes)

2006-10-10 Thread Joerg Roedel
This patch contains the changes to net/ipv6/addrconf.c to remove sit specific code if the sit driver is not selected. Signed-off-by: Joerg Roedel <[EMAIL PROTECTED]> Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscri

Re: [PATCH 01/02 V2] net/ipv6: seperate sit driver to extra module

2006-10-10 Thread Joerg Roedel
On Mon, Oct 09, 2006 at 09:38:56PM -0700, David Miller wrote: > Joerg, when you make resubmissions, please always restate the full > changelog and all signed-off-by lines. > > If you want to say "Changed since last version" do that seperately > at the top of the email, right before the main change

[PATCH 01/02 V3] net/ipv6: seperate sit driver to extra module

2006-10-10 Thread Joerg Roedel
This patch removes the driver of the IPv6-in-IPv4 tunnel driver (sit) from the IPv6 module. It adds an option to Kconfig which makes it possible to compile it as a seperate module. Signed-off-by: Joerg Roedel <[EMAIL PROTECTED]> diff -upr -X linux-2.6.18/Documentation/dontdiff linux-

[PATCH 02/02 V2] net/ipv6: seperate sit driver to extra module (addrconf.c changes)

2006-10-09 Thread Joerg Roedel
Decond part of the patch. It contains changes to to net/ipv6/addrconf.c to remove sit specific code if the sit driver it not selected. There are no changes to previous sumbit. This patch is resubmitted for completeness. diff -upr -X linux-2.6.18/Documentation/dontdiff linux-2.6.18-vanilla/net/ipv6

[PATCH 01/02 V2] net/ipv6: seperate sit driver to extra module

2006-10-09 Thread Joerg Roedel
This is the changed version of the patch making the sit driver configurable as a seperate module. Changes: - spelling fixes in Kconfig - changed "If unsure, say N" to "If unsure, say Y" for consistency diff -upr -X linux-2.6.18/Documentation/dontdiff linux-2.6.18-vanilla/net/ipv6/af_inet6.c linux

Re: [PATCH 01/02] net/ipv6: seperate sit driver to extra module

2006-10-06 Thread Joerg Roedel
On Fri, Oct 06, 2006 at 09:59:35PM +0900, YOSHIFUJI Hideaki / ?$B5HF#1QL@ wrote: > > + into IPv4 packets. This is usefull if you want to connect two IPv6 Argh. Bad typo. I appended the fixed patch Signed-off-by: Joerg Roedel <[EMAIL PROTECTED]> diff -upr -X linux-2.6.18/D

Re: [PATCH 01/02] net/ipv6: seperate sit driver to extra module

2006-10-06 Thread Joerg Roedel
On Fri, Oct 06, 2006 at 01:38:24PM +0200, Samuel Tardieu wrote: > >>>>> "Joerg" == Joerg Roedel <[EMAIL PROTECTED]> writes: > > Joerg> this is the submit of the patch discussed yesterday to compile > Joerg> the sit driver as a seperate module. &g

[PATCH 02/02] net/ipv6: seperate sit driver to extra module (addrconf.c changes)

2006-10-06 Thread Joerg Roedel
This patch contains the changes to net/ipv6/addrconf.c to remove sit specific code if the sit driver is not selected. Signed-off-by: Joerg Roedel <[EMAIL PROTECTED]> diff -upr -X linux-2.6.18/Documentation/dontdiff linux-2.6.18-vanilla/net/ipv6/addrconf.c linux-2.6.18/net/ipv6/addr

[PATCH 01/02] net/ipv6: seperate sit driver to extra module

2006-10-06 Thread Joerg Roedel
in a seperate patch) Signed-off-by: Joerg Roedel <[EMAIL PROTECTED]> diff -upr -X linux-2.6.18/Documentation/dontdiff linux-2.6.18-vanilla/net/ipv6/af_inet6.c linux-2.6.18/net/ipv6/af_inet6.c --- linux-2.6.18-vanilla/net/ipv6/af_inet6.c2006-09-20 05:42:06.0 +0200 +++ linux-2.6.

Re: [PATCH][RFC] net/ipv6: seperate sit driver to extra module

2006-10-05 Thread Joerg Roedel
On Thu, Oct 05, 2006 at 11:49:38AM -0400, James Morris wrote: > On Thu, 5 Oct 2006, Joerg Roedel wrote: > > > Is there a reason why the tunnel driver for IPv6-in-IPv4 is currently > > compiled into the ipv6 module? This driver is only needed in gateways > > between differe

[PATCH][RFC] net/ipv6: seperate sit driver to extra module

2006-10-05 Thread Joerg Roedel
Is there a reason why the tunnel driver for IPv6-in-IPv4 is currently compiled into the ipv6 module? This driver is only needed in gateways between different IPv6 networks. On all other hosts with ipv6 enabled it is not required. To have this driver in a seperate module will save memory on those ma

Re: [PATH] Allow mtu bigger than 1500 for ieee80211

2006-09-29 Thread Joerg Roedel
On Fri, Sep 29, 2006 at 01:56:10PM +0200, Johannes Berg wrote: > On Fri, 2006-09-29 at 11:30 +0200, Joerg Roedel wrote: > > Isn't 68 the minimum MTU required by IPv4? > > No idea, but shouldn't there be a named constant somewhere for that > then? Maybe. Other network

Re: [PATH] Allow mtu bigger than 1500 for ieee80211

2006-09-29 Thread Joerg Roedel
On Fri, Sep 29, 2006 at 09:38:21AM +0200, Johannes Berg wrote: > On Thu, 2006-09-28 at 19:57 +0200, matthieu castet wrote: > > > + if ((new_mtu < 68) || (new_mtu > IEEE80211_DATA_LEN)) > > + return -EINVAL; > > What's with that lower limit, why 68? Isn't 68 the minimum MTU required b

Re: [PATCH 02/03] net/bridge: add support for EtherIP devices

2006-09-25 Thread Joerg Roedel
On Mon, Sep 25, 2006 at 07:40:09AM -0700, Stephen Hemminger wrote: > > To get a list of all EtherIP devices, just maintain a linked list > in the private device information. Use list macros, it isn't hard. I use lists in the driver to maintain the list. The problem is to get such a list in usersp

Re: [PATCH 00/03][RESUBMIT] net: EtherIP tunnel driver

2006-09-25 Thread Joerg Roedel
On Mon, Sep 25, 2006 at 02:16:15PM +0200, Andi Kleen wrote: > On Monday 25 September 2006 13:57, Joerg Roedel wrote: > > On Mon, Sep 25, 2006 at 12:22:41PM +0200, Andi Kleen wrote: > > > > > How would you convince those old LAN games to use a MTU < 1500 which > &g

Re: [PATCH 00/03][RESUBMIT] net: EtherIP tunnel driver

2006-09-25 Thread Joerg Roedel
On Mon, Sep 25, 2006 at 12:22:41PM +0200, Andi Kleen wrote: > How would you convince those old LAN games to use a MTU < 1500 which > is needed for the tunnel? I bet they have the size hardcoded. The tunnel provides an MTU of 1500. To guarantee this, it never sets the DF flag in outgoing packets.

Re: [PATCH 00/03][RESUBMIT] net: EtherIP tunnel driver

2006-09-25 Thread Joerg Roedel
On Sun, Sep 24, 2006 at 09:07:43PM -0400, [EMAIL PROTECTED] wrote: > On Sat, 23 Sep 2006 15:27:36 +0200, Joerg Roedel said: > > > (I assume you are speaking of the position of the 3 in the header). The > > RFC is not clear at this point. It defines that the first 4 bits in the &

Re: [PATCH 02/03] net/bridge: add support for EtherIP devices

2006-09-25 Thread Joerg Roedel
On Sat, Sep 23, 2006 at 09:01:12PM -0700, Stephen Hemminger wrote: > If the device looks like a duck (Ethernet), then why does it need > a separate ARP type. There are other tools that might work without > modification if it just fully pretended to be an ether device. This solves the problem of

Re: [PATCH 00/03][RESUBMIT] net: EtherIP tunnel driver

2006-09-25 Thread Joerg Roedel
On Sat, Sep 23, 2006 at 04:35:35PM -0700, David Miller wrote: > First, the only mentioned real use of EtherIP I've seen anywhere is to > tunnel old LAN based games that used protocols other than IP :-) Thats an important use case for EtherIP, thats right :-) But people often use Ethernet over IP

Re: [PATCH 00/03][RESUBMIT] net: EtherIP tunnel driver

2006-09-23 Thread Joerg Roedel
from > contributing in the future. Surely not. I intend to further contribute even if this driver would be finally rejected :) Regards, Joerg Roedel - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 00/03][RESUBMIT] net: EtherIP tunnel driver

2006-09-23 Thread Joerg Roedel
BSD versions). This driver makes Linux interoperable with these implementations. Regards, Joerg Roedel - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 03/03][IPROUTE2] EtherIP tunnel and device support for iproute2

2006-09-23 Thread Joerg Roedel
This patch adds support for EtherIP tunnels and devices to the iproute2 userspace software package. Signed-off-by: Joerg Roedel <[EMAIL PROTECTED]> diff -urp iproute2-2.6.16-060323.orig/ip/iptunnel.c iproute2-2.6.16-060323/ip/iptunnel.c --- iproute2-2.6.16-060323.orig/ip/iptunnel.c 2005

[PATCH 02/03] net/bridge: add support for EtherIP devices

2006-09-23 Thread Joerg Roedel
This patch changes the device check in the bridge code to allow EtherIP devices to be added. Signed-off-by: Joerg Roedel <[EMAIL PROTECTED]> diff -uprN -X linux-2.6.18-vanilla/Documentation/dontdiff linux-2.6.18-vanilla/net/bridge/br_if.c linux-2.6.18/net/bridge/br_if.c --- linux-2.6.18-v

[PATCH 01/03] net: EtherIP driver, header and MAINTAINERS changes

2006-09-23 Thread Joerg Roedel
This patch contains the reworked EtherIP driver, the necessary header updates and adds an entry for EtherIP to the MAINTAINERS file. Signed-off-by: Joerg Roedel <[EMAIL PROTECTED]> diff -uprN -X linux-2.6.18-vanilla/Documentation/dontdiff linux-2.6.18-vanilla/include/linux/if_arp.h linux-

[PATCH 00/03][RESUBMIT] net: EtherIP tunnel driver

2006-09-23 Thread Joerg Roedel
general tunnel configuration support for EtherIP). Signed-off-by: Joerg Roedel <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] EtherIP tunnel driver (RFC 3378)

2006-09-19 Thread Joerg Roedel
tested it). This is the reason why my driver does not check the value of the incoming EtherIP header too. Regards, Joerg Roedel - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] EtherIP tunnel driver (RFC 3378)

2006-09-15 Thread Joerg Roedel
On Fri, Sep 15, 2006 at 09:06:02AM +1000, Philip Craig wrote: > Patrick McHardy wrote: > > Joerg Roedel wrote: > >> On Thu, Sep 14, 2006 at 11:21:22AM +1000, Philip Craig wrote: > >> > >>> Joerg Roedel wrote: > >>> > >>>>

Re: [PATCH] EtherIP tunnel driver (RFC 3378)

2006-09-14 Thread Joerg Roedel
On Thu, Sep 14, 2006 at 11:21:22AM +1000, Philip Craig wrote: > Joerg Roedel wrote: > > +To configure tunnels an extra tool is required. You can download > > +it from http://zlug.fh-zwickau.de/~joro/projects/ under the > > +EtherIP section. If unsure, say N. >

[PATCH] EtherIP tunnel driver (RFC 3378)

2006-09-11 Thread Joerg Roedel
hardware platforms (currently i386 and 32bit HP-PA) Signed-off-by: Joerg Roedel <[EMAIL PROTECTED]> diff -uprN -X linux-2.6.17.13/Documentation/dontdiff linux-2.6.17.13-vanilla/include/linux/in.h linux-2.6.17.13/include/linux/in.h --- linux-2.6.17.13-vanilla/include/linux/in.h 2006-09-09

Re: [RFC PATCH] EtherIP tunnel driver (RFC 3387)

2006-09-03 Thread Joerg Roedel
On Fri, Sep 01, 2006 at 06:24:56PM +0200, Patrick McHardy wrote: Hello Patrick, Thank you very much for reviewing my driver. I will fix the issues you mentioned. But I have some explanations and questions left. > Joerg Roedel wrote: > > + fl.oif = 0; > > + fl.nl_u.ip4_u

[RFC PATCH] EtherIP tunnel driver (RFC 3387)

2006-09-01 Thread Joerg Roedel
/etherip.tar.gz . TODO: - make it work with multicast destinations - integration into iproute Regards, Joerg Roedel Signed-off-by: Joerg Roedel <[EMAIL PROTECTED]> diff -uprN linux-2.6.17.11-vanilla/include/linux/in.h linux-2.6.17.11/include/linux/in.h --- linux-2.6.17.11-vanilla/include