[PATCH net-next 3/3] nfp: flower: include geneve as supported offload tunnel type

2018-11-07 Thread John Hurley
Offload of geneve decap rules is supported in NFP. Include geneve in the check for supported types. Signed-off-by: John Hurley Reviewed-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/flower/tunnel_conf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet

[PATCH net-next 2/3] nfp: flower: use geneve and vxlan helpers

2018-11-07 Thread John Hurley
Make use of the recently added VXLAN and geneve helper functions to determine the type of the netdev from its rtnl_link_ops. Signed-off-by: John Hurley Reviewed-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/flower/action.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions

[PATCH net-next 1/3] net: add netif_is_geneve()

2018-11-07 Thread John Hurley
Add a helper function to determine if the type of a netdev is geneve based on its rtnl_link_ops. This allows drivers that may wish to offload tunnels to check the underlying type of the device. A recent patch added a similar helper to vxlan.h Signed-off-by: John Hurley Reviewed-by: Jakub

[PATCH net-next 0/3] nfp: add and use tunnel netdev helpers

2018-11-07 Thread John Hurley
A recent patch introduced the function netif_is_vxlan() to verify the tunnel type of a given netdev as vxlan. Add a similar function to detect geneve netdevs and make use of this function in the NFP driver. Also make use of the vxlan helper where applicable. John Hurley (3): net: add

Re: [RFC net-next v2 1/8] net: sched: register callbacks for indirect tc block binds

2018-10-29 Thread John Hurley
On Sun, Oct 28, 2018 at 11:10 AM Or Gerlitz wrote: > > On Thu, Oct 25, 2018 at 3:28 PM John Hurley wrote: > > Currently drivers can register to receive TC block bind/unbind callbacks > > by implementing the setup_tc ndo in any of their given netdevs. However, > > driver

Re: [RFC net-next v2 2/8] net: add netif_is_geneve()

2018-10-29 Thread John Hurley
On Fri, Oct 26, 2018 at 9:52 AM Sergei Shtylyov wrote: > > Hello! > > On 25.10.2018 15:26, John Hurley wrote: > > > Add a helper function to determine if the type of a netdev is geneve based > > on its rtnl_link_ops. This allows drivers that may wish to ofload tunnels

Re: [RFC net-next v2 2/8] net: add netif_is_geneve()

2018-10-25 Thread John Hurley
unnels > >to check the underlying type of the device. > > > >A recent patch added a similar helper to vxlan.h > > > >Signed-off-by: John Hurley > >Reviewed-by: Jakub Kicinski > > I don't understand why this and the next patch are part of this > patchset. T

Re: [RFC net-next v2 0/8] indirect tc block cb registration

2018-10-25 Thread John Hurley
On Thu, Oct 25, 2018 at 1:58 PM Jiri Pirko wrote: > > Thu, Oct 25, 2018 at 02:26:49PM CEST, john.hur...@netronome.com wrote: > >This patchset introduces an alternative to egdev offload by allowing a > >driver to register for block updates when an external device (e.g. tunnel > >netdev) is bound

[RFC net-next v2 8/8] nfp: flower: remove unnecessary code in flow lookup

2018-10-25 Thread John Hurley
to be NULL. Signed-off-by: John Hurley Reviewed-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/flower/main.h | 3 +-- drivers/net/ethernet/netronome/nfp/flower/metadata.c | 11 +++ drivers/net/ethernet/netronome/nfp/flower/offload.c | 6 ++ 3 files changed, 6 insertions

[RFC net-next v2 5/8] nfp: flower: add infastructure for indirect TC block register

2018-10-25 Thread John Hurley
Add support structures and functions that can be used by NFP to impliment the indirect block register functionality of TC. Signed-off-by: John Hurley Reviewed-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/flower/main.c | 13 +++ drivers/net/ethernet/netronome/nfp/flower/main.h

[RFC net-next v2 6/8] nfp: flower: offload tunnel decap rules via indirect TC blocks

2018-10-25 Thread John Hurley
registration, this is triggered for already existing netdevs. This means that NFP can register for offloads from devices that exist before it is loaded (filter rules will be replayed from the TC core). Signed-off-by: John Hurley Reviewed-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/flower

[RFC net-next v2 7/8] nfp: flower: remove TC egdev offloads

2018-10-25 Thread John Hurley
Previously, only tunnel decap rules required egdev registration for offload in NFP. These are now supported via indirect TC block callbacks. Remove the egdev code from NFP. Signed-off-by: John Hurley Reviewed-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/flower/main.c | 12

[RFC net-next v2 2/8] net: add netif_is_geneve()

2018-10-25 Thread John Hurley
Add a helper function to determine if the type of a netdev is geneve based on its rtnl_link_ops. This allows drivers that may wish to ofload tunnels to check the underlying type of the device. A recent patch added a similar helper to vxlan.h Signed-off-by: John Hurley Reviewed-by: Jakub

[RFC net-next v2 4/8] nfp: flower: allow non repr netdev offload

2018-10-25 Thread John Hurley
then base its offload decision on a combination of ingress device and egress port for a rule. Signed-off-by: John Hurley Reviewed-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/flower/action.c | 14 drivers/net/ethernet/netronome/nfp/flower/main.h | 3 +- drivers/net/ethernet

[RFC net-next v2 3/8] nfp: flower: include geneve as supported offload tunnel type

2018-10-25 Thread John Hurley
Offload of geneve decap rules is supported in NFP. Include geneve in the check for supported types. Signed-off-by: John Hurley Reviewed-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/flower/tunnel_conf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet

[RFC net-next v2 0/8] indirect tc block cb registration

2018-10-25 Thread John Hurley
register for block offload rules using already existing functions. The patchset also implements this new indirect block registration in the NFP driver to allow the offloading of tunnel rules. The use of egdev offload (which is currently only used for tunnel offload) is subsequently removed. John

[RFC net-next v2 1/8] net: sched: register callbacks for indirect tc block binds

2018-10-25 Thread John Hurley
. In this case (if it is an ingress block), register and also trigger the callback meaning that any already installed rules can be replayed to the calling driver. Signed-off-by: John Hurley Signed-off-by: Jakub Kicinski --- include/net/pkt_cls.h | 56 + include/net/sch_generic.h | 3 + net

Re: [RFC 0/2] net: sched: indirect/remote setup tc block cb registering

2018-10-11 Thread John Hurley
On Wed, Oct 10, 2018 at 2:38 PM Or Gerlitz wrote: > > On Thu, Oct 4, 2018 at 8:19 PM Jakub Kicinski > wrote: > > On Thu, 4 Oct 2018 17:20:43 +0100, John Hurley wrote: > > > > > In this case the hw driver will receive the rules from the tunnel > > > > &

Re: [RFC 0/2] net: sched: indirect/remote setup tc block cb registering

2018-10-04 Thread John Hurley
On Thu, Oct 4, 2018 at 4:53 PM Or Gerlitz wrote: > > On Thu, Oct 4, 2018 at 6:44 PM John Hurley wrote: > > On Thu, Oct 4, 2018 at 3:28 PM Or Gerlitz wrote: > > > On Thu, Oct 4, 2018 at 7:55 AM Jakub Kicinski > > > wrote: > > > > > This patchset

Re: [RFC 0/2] net: sched: indirect/remote setup tc block cb registering

2018-10-04 Thread John Hurley
On Thu, Oct 4, 2018 at 3:28 PM Or Gerlitz wrote: > > On Thu, Oct 4, 2018 at 7:55 AM Jakub Kicinski > wrote: > > > > Hi! > > > > This set contains a rough RFC implementation of a proposed [1] replacement > > for egdev cls_flower offloads. I did some last minute restructuring > > and removal of

Re: [PATCH net-next 2/6] nfp: flower: allow matching on ipv4 UDP tunnel tos and ttl

2018-08-07 Thread John Hurley
On Tue, Aug 7, 2018 at 6:46 PM, Or Gerlitz wrote: > On Tue, Aug 7, 2018 at 6:35 PM, Simon Horman > wrote: >> From: John Hurley >> >> The addition of FLOW_DISSECTOR_KEY_ENC_IP to TC flower means that the ToS >> and TTL of the tunnel header can now be matched o

Re: Fwd: [PATCH 0/6] offload Linux LAG devices to the TC datapath

2018-06-26 Thread John Hurley
On Tue, Jun 26, 2018 at 3:57 PM, Or Gerlitz wrote: >> Forwarded Message >> Subject: [PATCH 0/6] offload Linux LAG devices to the TC datapath >> Date: Thu, 21 Jun 2018 14:35:55 +0100 >> From: John Hurley >> To: d...@openvswitch.org, r...@mellanox.

Re: [PATCH net-next 0/8] nfp: offload LAG for tc flower egress

2018-05-31 Thread John Hurley
On Wed, May 30, 2018 at 9:29 PM, Jiri Pirko wrote: > Wed, May 30, 2018 at 11:26:23AM CEST, john.hur...@netronome.com wrote: >>On Tue, May 29, 2018 at 11:09 PM, Jiri Pirko wrote: >>> Tue, May 29, 2018 at 04:08:48PM CEST, john.hur...@netronome.com wrote: On Sat, May 26, 2018 at 3:47 AM, Jakub

Re: [PATCH net-next 0/8] nfp: offload LAG for tc flower egress

2018-05-30 Thread John Hurley
On Tue, May 29, 2018 at 11:09 PM, Jiri Pirko wrote: > Tue, May 29, 2018 at 04:08:48PM CEST, john.hur...@netronome.com wrote: >>On Sat, May 26, 2018 at 3:47 AM, Jakub Kicinski >> wrote: >>> On Fri, 25 May 2018 08:48:09 +0200, Jiri Pirko wrote: Thu, May 24, 2018 at 04:22:47AM CEST,

Re: [PATCH net-next 0/8] nfp: offload LAG for tc flower egress

2018-05-29 Thread John Hurley
On Sat, May 26, 2018 at 3:47 AM, Jakub Kicinski wrote: > On Fri, 25 May 2018 08:48:09 +0200, Jiri Pirko wrote: >> Thu, May 24, 2018 at 04:22:47AM CEST, jakub.kicin...@netronome.com wrote: >> >Hi! >> > >> >This series from John adds bond offload to the nfp driver. Patch 5 >> >exposes the hash

Re: [PATCH net-next 8/8] nfp: flower: compute link aggregation action

2018-05-24 Thread John Hurley
On Thu, May 24, 2018 at 6:09 PM, Or Gerlitz <gerlitz...@gmail.com> wrote: > On Thu, May 24, 2018 at 5:22 AM, Jakub Kicinski > <jakub.kicin...@netronome.com> wrote: >> From: John Hurley <john.hur...@netronome.com> >> >> If the egress device of an

Re: [PATCH net-next 4/4] nfp: flower: ignore duplicate cb requests for same rule

2018-04-25 Thread John Hurley
On Wed, Apr 25, 2018 at 10:17 AM, Or Gerlitz <gerlitz...@gmail.com> wrote: > On Wed, Apr 25, 2018 at 7:17 AM, Jakub Kicinski > <jakub.kicin...@netronome.com> wrote: >> From: John Hurley <john.hur...@netronome.com> >> >> If a flower rule has a r

Re: [PATCH net-next 3/4] nfp: flower: support offloading multiple rules with same cookie

2018-04-25 Thread John Hurley
On Wed, Apr 25, 2018 at 10:13 AM, Or Gerlitz <gerlitz...@gmail.com> wrote: > On Wed, Apr 25, 2018 at 12:02 PM, John Hurley <john.hur...@netronome.com> > wrote: >> On Wed, Apr 25, 2018 at 9:56 AM, Or Gerlitz <gerlitz...@gmail.com> wrote: >>> On Wed, Apr 25,

Re: [PATCH net-next 3/4] nfp: flower: support offloading multiple rules with same cookie

2018-04-25 Thread John Hurley
On Wed, Apr 25, 2018 at 9:56 AM, Or Gerlitz <gerlitz...@gmail.com> wrote: > On Wed, Apr 25, 2018 at 11:51 AM, John Hurley <john.hur...@netronome.com> > wrote: >> On Wed, Apr 25, 2018 at 7:31 AM, Or Gerlitz <gerlitz...@gmail.com> wrote: >>> On Wed,

Re: [PATCH net-next 3/4] nfp: flower: support offloading multiple rules with same cookie

2018-04-25 Thread John Hurley
On Wed, Apr 25, 2018 at 7:31 AM, Or Gerlitz <gerlitz...@gmail.com> wrote: > On Wed, Apr 25, 2018 at 7:17 AM, Jakub Kicinski > <jakub.kicin...@netronome.com> wrote: >> From: John Hurley <john.hur...@netronome.com> >> >> When multiple netdevs are a

Re: [PATCH net 5/5] nfp: remove false positive offloads in flower vxlan

2018-04-18 Thread John Hurley
On Wed, Apr 18, 2018 at 7:18 PM, Or Gerlitz <gerlitz...@gmail.com> wrote: > On Wed, Apr 18, 2018 at 3:31 PM, John Hurley <john.hur...@netronome.com> > wrote: >> On Wed, Apr 18, 2018 at 8:43 AM, Or Gerlitz <gerlitz...@gmail.com> wrote: >>> On Fri,

Re: [PATCH net 5/5] nfp: remove false positive offloads in flower vxlan

2018-04-18 Thread John Hurley
On Wed, Apr 18, 2018 at 8:43 AM, Or Gerlitz <gerlitz...@gmail.com> wrote: > On Fri, Nov 17, 2017 at 4:06 AM, Jakub Kicinski > <jakub.kicin...@netronome.com> wrote: >> From: John Hurley <john.hur...@netronome.com> >> >> Pass information to th

Re: [RFC net-next 0/6] offload linux bonding tc ingress rules

2018-03-05 Thread John Hurley
On Mon, Mar 5, 2018 at 9:43 PM, Or Gerlitz <gerlitz...@gmail.com> wrote: > On Mon, Mar 5, 2018 at 3:28 PM, John Hurley <john.hur...@netronome.com> wrote: >> This RFC patchset adds support for offloading tc ingress rules applied to >> linux bonds. The premise of thes

Re: [RFC net-next 4/6] nfp: add ndo_set_mac_address for representors

2018-03-05 Thread John Hurley
On Mon, Mar 5, 2018 at 9:39 PM, Or Gerlitz <gerlitz...@gmail.com> wrote: > On Mon, Mar 5, 2018 at 3:28 PM, John Hurley <john.hur...@netronome.com> wrote: >> A representor hardware address does not have any meaning outside of the >> kernel netdev/networking stack. Thus t

[RFC net-next 0/6] offload linux bonding tc ingress rules

2018-03-05 Thread John Hurley
John Hurley (6): drivers: net: bonding: add tc offload infastructure to bond driver: net: bonding: allow registration of tc offload callbacks in bond drivers: net: bonding: restrict bond mods when rules are offloaded nfp: add ndo_set_mac_address for representors nfp: register repr

[RFC net-next 1/6] drivers: net: bonding: add tc offload infastructure to bond

2018-03-05 Thread John Hurley
Register an ndo and callback for linux bonds to offload TC block ingress rules. Enable tc-hw-offload to be set by the user (defaults to off). When on, the flag cannot be turned off if rules are offloaded. Signed-off-by: John Hurley <john.hur...@netronome.com> --- drivers/net/bonding/bond_

[RFC net-next 5/6] nfp: register repr ports for bond offloads

2018-03-05 Thread John Hurley
On initialisation, register nfp repr ports to receive callbacks when tc rules are offloaded to any bond they may be attached to. Callback function is the same that is used for non bonded port rule offload. Signed-off-by: John Hurley <john.hur...@netronome.com> --- drivers/net/ethernet/net

[RFC net-next 2/6] driver: net: bonding: allow registration of tc offload callbacks in bond

2018-03-05 Thread John Hurley
the rules, we don't care about whether the bond ports are on the same device or whether some of slaves are representor ports and some are not. Signed-off-by: John Hurley <john.hur...@netronome.com> --- drivers/net/bonding/bond_main.c | 195 +++- include/net/bon

[RFC net-next 4/6] nfp: add ndo_set_mac_address for representors

2018-03-05 Thread John Hurley
A representor hardware address does not have any meaning outside of the kernel netdev/networking stack. Thus there is no need for any app specific code for setting a representors hardware address, the default eth_mac_addr is sufficient. Signed-off-by: John Hurley <john.hur...@netronome.

[RFC net-next 6/6] nfp: support offloading multiple rules with same cookie

2018-03-05 Thread John Hurley
is to be attached to is considered when searching for dublicates. Conversely, when a stats update is received from the NFP card, the host context is used alongside the cookie to map to the correct host rule. Signed-off-by: John Hurley <john.hur...@netronome.com> --- drivers/net/ethernet/net

[RFC net-next 3/6] drivers: net: bonding: restrict bond mods when rules are offloaded

2018-03-05 Thread John Hurley
-by: John Hurley <john.hur...@netronome.com> --- drivers/net/bonding/bond_main.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index d9e41cf..4c146b1 100644 --- a/drivers/net/bonding/bond_main.c +++ b/drive

Re: [PATCH net-next 2/7] nfp: compile flower vxlan tunnel metadata match fields

2017-09-26 Thread John Hurley
On Tue, Sep 26, 2017 at 4:33 PM, Or Gerlitz <gerlitz...@gmail.com> wrote: > On Tue, Sep 26, 2017 at 6:11 PM, John Hurley <john.hur...@netronome.com> > wrote: >> On Tue, Sep 26, 2017 at 3:12 PM, Or Gerlitz <gerlitz...@gmail.com> wrote: >>> On Tue, Sep 26,

Re: [PATCH net-next 2/7] nfp: compile flower vxlan tunnel metadata match fields

2017-09-26 Thread John Hurley
On Tue, Sep 26, 2017 at 3:12 PM, Or Gerlitz <gerlitz...@gmail.com> wrote: > On Tue, Sep 26, 2017 at 4:58 PM, John Hurley <john.hur...@netronome.com> > wrote: >> On Mon, Sep 25, 2017 at 7:35 PM, Or Gerlitz <gerlitz...@gmail.com> wrote: >>> On Mon

Re: [PATCH net-next 2/7] nfp: compile flower vxlan tunnel metadata match fields

2017-09-26 Thread John Hurley
On Mon, Sep 25, 2017 at 7:35 PM, Or Gerlitz <gerlitz...@gmail.com> wrote: > On Mon, Sep 25, 2017 at 1:23 PM, Simon Horman > <simon.hor...@netronome.com> wrote: >> From: John Hurley <john.hur...@netronome.com> >> >> Compile ovs-tc flower vxlan metadata matc

Re: [PATCH net-next 7/7] nfp: flower vxlan neighbour keep-alive

2017-09-26 Thread John Hurley
[ Reposting in plantext only] On Mon, Sep 25, 2017 at 7:32 PM, Or Gerlitz <gerlitz...@gmail.com> wrote: > > On Mon, Sep 25, 2017 at 1:23 PM, Simon Horman > <simon.hor...@netronome.com> wrote: > > From: John Hurley <john.hur...@netronome.com> > > >