for combinations of FEC modes
* Fix: Fix uninitialized variable use at qsfp dump
John
--
John W. LinvilleSomeday the world will need a hero, and you
linvi...@tuxdriver.com might be all we have. Be ready.
the kernel in question without having to
announce themselves. The "send an email to i...@cavium.com" offer may
(or may not) be sufficient for the letter of the law. But it seems
both fragile and prone to subjective frustrations and delays for
users to obtain the sources at some future date
ing initialized at
> sff8472_parse_eeprom function, to avoid the same issue here.
>
> Fixes: a5e73bb05ee4 ("ethtool:QSFP Plus/QSFP28 Diagnostics Information
> Support")
> Signed-off-by: Eran Ben Elisha
OK, queued for next release...
--
John W. LinvilleSom
On Thu, Oct 04, 2018 at 05:06:29PM +0100, Edward Cree wrote:
> On 04/10/18 15:08, John W. Linville wrote:
> > Ping?
> >
> > On Mon, Oct 01, 2018 at 02:59:10PM -0400, John W. Linville wrote:
> >> Is this patch still RFC?
> Feel free to de-RFC and apply it.
Great
Ping?
On Mon, Oct 01, 2018 at 02:59:10PM -0400, John W. Linville wrote:
> Is this patch still RFC?
>
> On Wed, Sep 19, 2018 at 05:06:25PM +0100, Edward Cree wrote:
> > Instead of commas, just have them as separate argvs.
> >
> > The parsing state machine might loo
vname advertise foo" },
> { 1, "--set-fec devname" },
> { 0, "--set-fec devname encoding auto" },
> - { 0, "--set-fec devname encoding off," },
> - { 0, "--set-fec devname encoding baser,rs" },
> - { 0, &qu
atic struct test_case {
> { 0, "--set-eee devname tx-timer 42 advertise 0x4321" },
> { 1, "--set-eee devname tx-timer foo" },
> { 1, "--set-eee devname advertise foo" },
> + { 1, "--set-fec devname" },
> + { 0, "--se
support for action value -2 (wake-up filter)
* Fix: document WoL filters option also in help message
* Feature: ixgbe dump strings for security registers
John
--
John W. LinvilleSomeday the world will need a hero, and you
linvi...@tuxdriver.com
man page
> > but not in the output of "ethtool --help".
> >
> > Signed-off-by: Michal Kubecek
>
> Acked-by: Florian Fainelli
>
> Thanks Michal!
Yes, good eye!
John
--
John W. LinvilleSomeday the world will need a hero, and you
linvi...@tuxdriver.com might be all we have. Be ready.
4 files changed, 24 insertions(+), 8 deletions(-)
Thanks, Florian -- LGTM!
Patches merged and pushed-out, queued for next release (probably next week)...
John
--
John W. LinvilleSomeday the world will need a hero, and you
linvi...@tuxdriver.com might be all we have. Be ready.
> "/dfcxact/mtsn/J3002240/debug_yuhongw_18b_brcm/platform/modules/Run.py", line
> 384, in runmain
> 180625-11:26:57 EXC** result = func(*bares, **keywords)
> 180625-11:26:57 EXC** File
> "/dfcxact/mtsn/J3002240/debug_yuhongw_18b_brcm/repos/common/tests/broadcom_code_test.py",
> line 37, in main
> 180625-11:26:57 EXC** broadcom.verify_firmware_level(location)
> 180625-11:26:57 EXC** File
> "/dfcxact/mtsn/J3002240/debug_yuhongw_18b_brcm/repos/common/modules/Broadcom.py",
> line 180, in verify_firmware_level
> 180625-11:26:57 EXC** result, expected, actual =
> self._verify_firmware_level(location)
> 180625-11:26:57 EXC** File
> "/dfcxact/mtsn/J3002240/debug_yuhongw_18b_brcm/repos/common/modules/Broadcom.py",
> line 193, in _verify_firmware_level
> 180625-11:26:57 EXC** actual_parts = version_tuple(actual)
> 180625-11:26:57 EXC** File
> "/dfcxact/mtsn/J3002240/debug_yuhongw_18b_brcm/repos/common/modules/Broadcom.py",
> line 59, in version_tuple
> 180625-11:26:57 EXC** return tuple(int(v, base) for v in
> re.split(pattern, version))
> 180625-11:26:57 EXC** File
> "/dfcxact/mtsn/J3002240/debug_yuhongw_18b_brcm/repos/common/modules/Broadcom.py",
> line 59, in
> 180625-11:26:57 EXC** return tuple(int(v, base) for v in
> re.split(pattern, version))
> 180625-11:26:57 EXC** ValueError: invalid literal for int() with base 16: ''
> 180625-11:26:57 FAIL FAIL
> 180625-11:26:57 TESTE FAIL broadcom_code_test.py flash
>
> Globa Test Engineer
> Email: wu...@lenovo.com<mailto:wu...@lenovo.com>
>
--
John W. LinvilleSomeday the world will need a hero, and you
linvi...@tuxdriver.com might be all we have. Be ready.
in do_get_phy_tunable and do_set_phy_tunable
* Feature: Add register dump support for MICROCHIP LAN78xx
John
--
John W. LinvilleSomeday the world will need a hero, and you
linvi...@tuxdriver.com might be all we have. Be ready.
mmit IDs...
Thanks!
John
--
John W. LinvilleSomeday the world will need a hero, and you
linvi...@tuxdriver.com might be all we have. Be ready.
s.data[0]. The same
> problem also exists in do_set_phy_tunable().
>
> Fixes: b0fe96dec90f ("Ethtool: Implements
> ETHTOOL_PHY_GTUNABLE/ETHTOOL_PHY_STUNABLE and PHY downshift")
> Signed-off-by: Michal Kubecek
LGTM -- queued for next release...
--
John W. Linville
-by: Raghuram Chary J <raghuramchary.jallipa...@microchip.com>
LGTM -- queued for next release...
John
--
John W. LinvilleSomeday the world will need a hero, and you
linvi...@tuxdriver.com might be all we have. Be ready.
for the ring_cookie parameter
* Feature: Add SFF 8636 date code parsing support
John
--
John W. LinvilleSomeday the world will need a hero, and you
linvi...@tuxdriver.com might be all we have. Be ready.
ethtool: add support for extra RSS contexts and RSS
> steering filters")
> Signed-off-by: Edward Cree <ec...@solarflare.com>
LGTM -- queued for next release...
Thanks,
John
--
John W. LinvilleSomeday the world will need a hero, and you
linvi...@tuxdriver.com might be all we have. Be ready.
n | 28
> ethtool.c | 141
> +
> internal.h | 4 +-
> rxclass.c | 58
> 5 files changed, 227 insertions(+), 36 deletions(-)
>
LGTM -- queued for the next release...tha
.kel...@intel.com>
> Tested-by: Andrew Bowers <andrewx.bow...@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirs...@intel.com>
LGTM -- queued for ethtool-4.16...
Thanks!
John
--
John W. LinvilleSomeday the world will need a hero, and you
linvi...@tux
; expects. Additionally, update the displayed output to show the correct
> VF number.
>
> Signed-off-by: Jacob Keller <jacob.e.kel...@intel.com>
> Tested-by: Andrew Bowers <andrewx.bow...@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirs...@intel.com>
LGTM -
Signed-off-by: Jeff Kirsher <jeffrey.t.kirs...@intel.com>
LGTM -- queued for ethtool-4.16...
Thanks!
John
--
John W. LinvilleSomeday the world will need a hero, and you
linvi...@tuxdriver.com might be all we have. Be ready.
al Pressman <g...@mellanox.com>
LGTM -- queued for ethtool-4.16...
Thanks!
John
--
John W. LinvilleSomeday the world will need a hero, and you
linvi...@tuxdriver.com might be all we have. Be ready.
ing must be enclosed in double quotes.
> >
> > This is the case for "John W. Linville" so please add proper
> > quotes around such names and resend your patch series again.
> Thank you for spotting this! I looked at the headers and failed
> to notice any
ewer
John
--
John W. LinvilleSomeday the world will need a hero, and you
linvi...@tuxdriver.com might be all we have. Be ready.
g", CMDL_STR, _str, },
> + };
> + int changed;
> + int fecmode;
> + int rv;
> +
> + parse_generic_cmdline(ctx, , cmdline_fec,
> + ARRAY_SIZE(cmdline_fec));
> +
> + if (!fecmode_str)
> + exit_bad_args();
> +
> + fecmode = fecmode_str_to_type(fecmode_str);
> + if (!fecmode)
> + exit_bad_args();
> +
> + feccmd.cmd = ETHTOOL_SFECPARAM;
> + feccmd.fec = fecmode;
> + rv = send_ioctl(ctx, );
> + if (rv != 0) {
> + perror("Cannot set FEC settings");
> + return rv;
> + }
> +
> + return 0;
> +}
> +
> #ifndef TEST_ETHTOOL
> int send_ioctl(struct cmd_context *ctx, void *cmd)
> {
> @@ -5000,6 +5116,9 @@ static const struct option {
> " [ ap-shared ]\n"
> " [ dedicated ]\n"
> " [ all ]\n"},
> + { "--show-fec", 1, do_gfec, "Show FEC settings"},
> + { "--set-fec", 1, do_sfec, "Set FEC settings",
> + " [ encoding auto|off|rs|baser ]\n"},
> { "-h|--help", 0, show_usage, "Show this help" },
> { "--version", 0, do_version, "Show version number" },
> {}
> --
> 2.15.1
>
>
--
John W. LinvilleSomeday the world will need a hero, and you
linvi...@tuxdriver.com might be all we have. Be ready.
sfec below:
> +static int do_sfec(struct cmd_context *ctx)
> +{
> + char *fecmode_str = NULL;
> + struct ethtool_fecparam feccmd;
> + struct cmdline_info cmdline_fec[] = {
> + { "encoding", CMDL_STR, _str, },
> + };
> + int changed;
> + int fecmode;
> + int rv;
> +
> + parse_generic_cmdline(ctx, , cmdline_fec,
> + ARRAY_SIZE(cmdline_fec));
Thanks,
John
--
John W. LinvilleSomeday the world will need a hero, and you
linvi...@tuxdriver.com might be all we have. Be ready.
On Fri, Dec 15, 2017 at 09:56:51AM +0800, Zhang Kang wrote:
> Use MFLCN for 82599 and X540 HW instead of FCTRL.
>
> Signed-off-by: Zhang Kang <tjbroadr...@163.com>
> Signed-off-by: Gao Wayne <wayne@emc.com>
> Signed-off-by: Wei Net <gw_...@163.com>
Thank
+
> 12 files changed, 3260 insertions(+), 137 deletions(-)
> create mode 100644 Documentation/networking/ethtool-netlink.txt
> create mode 100644 include/linux/ethtool_netlink.h
> create mode 100644 include/uapi/linux/ethtool_netlink.h
> create mode 100644 net/core/ethtool_common.c
> create mode 100644 net/core/ethtool_common.h
> create mode 100644 net/core/ethtool_netlink.c
>
> --
> 2.15.1
>
>
--
John W. LinvilleSomeday the world will need a hero, and you
linvi...@tuxdriver.com might be all we have. Be ready.
p,dedicated,all
>
> Add -shared onto end of components to specified shared version.
>
> Alternatively, you can specific component bitfield directly using
> ethtool --reset DEVNAME flags %x
>
> Signed-off-by: Scott Branden <scott.bran...@broadcom.com>
--
John W. Linvill
an...@broadcom.com>
> Reviewed-by: Andrew Lunn <and...@lunn.ch>
> Signed-off-by: David S. Miller <da...@davemloft.net>
>
> Signed-off-by: Scott Branden <scott.bran...@broadcom.com>
--
John W. LinvilleSomeday the world will need a hero, and you
linvi...@tuxdriver.com might be all we have. Be ready.
57846
> Signed-off-by: Scott Branden <scott.bran...@broadcom.com>
--
John W. LinvilleSomeday the world will need a hero, and you
linvi...@tuxdriver.com might be all we have. Be ready.
l mapping? Preferrably
your legal name, but definitely something consistent and identifiable.
John
--
John W. LinvilleSomeday the world will need a hero, and you
linvi...@tuxdriver.com might be all we have. Be ready.
ox.com>
> Reviewed-by: Eran Ben Elisha <era...@mellanox.com>
Applied -- sorry for the delay!
John
--
John W. LinvilleSomeday the world will need a hero, and you
linvi...@tuxdriver.com might be all we have. Be ready.
lied -- sorry for the delay!
--
John W. LinvilleSomeday the world will need a hero, and you
linvi...@tuxdriver.com might be all we have. Be ready.
htool-copy.h yet I cannot find the change in the ethtool.h in the
> > > linux kernel.
> > >
> > > As such, I am unable to commit a change to ethtool-copy.h to sync it
> > > with net-next. If I sync then ethtool will fail to compile.
> > >
> > > Please advise.
> > >
> > > Thanks,
> > >
> > > Scott
> > >
> > >
>
>
--
John W. LinvilleSomeday the world will need a hero, and you
linvi...@tuxdriver.com might be all we have. Be ready.
Offload error prints
* Feature: stmmac: Add macros for number of registers
* Feature: stmmac: Add DMA HW Feature Register
John
--
John W. LinvilleSomeday the world will need a hero, and you
linvi...@tuxdriver.com might be all we have. Be ready.
y
initial feeling was like you, a no-op is not a failure. But someone
convinced me otherwise...I will now endeavour to remember who that
was and how they convinced me...
Anyone else have input here?
John
--
John W. LinvilleSomeday the world will need a hero, and you
linvi...@tuxdriver.com
f-by: Tariq Toukan <tar...@mellanox.com>
> > ---
>
>
> Hi guys
>
> I would rather remove the warning, but leave the ability to switch UFO
> on machines running old kernel but a recent ethtool.
>
> ethtool does not need to be downgraded every time w
queue and VF fields for rxclass filters
* Feature: Add support for 2500baseT/5000baseT link modes
* Fix: Fix SFF 8079 cable technology bit parsing
* Fix: sync help output for -x/-X with man page
John
--
John W. LinvilleSomeday the world will need a hero
e .tar.gz file.)
I downloaded the file from the website and verified against the
matching version of the git tree locally as well. If you have any idea
as to who is in charge of the OpenEmbedded build and can correct/remove
this complaint, then please let me know and/or have them contac
On Wed, Mar 29, 2017 at 02:56:38PM +0300, Gal Pressman wrote:
> On 27/03/2017 21:02, John W. Linville wrote:
> > On Sat, Mar 25, 2017 at 02:50:47PM -0700, Jakub Kicinski wrote:
> >> On Wed, 8 Mar 2017 16:03:51 +0200, Gal Pressman wrote:
> >>> This ethtool pat
my adbaa18b9bc1
> RSS hash key:
> Operation not supported
> RSS hash function: <--- from this patch
> toeplitz: on
> xor: off
> crc32: off
>
> Reverting my patch is probably the easiest way forward, although I find
> it more concise and easier to parse i
Implement ETHTOOL_PHY_GTUNABLE/ETHTOOL_PHY_STUNABLE and PHY
downshift
* Feature: add register dump support for fjes driver (-d option)
John
--
John W. LinvilleSomeday the world will need a hero, and you
linvi...@tuxdriver.com might be all we have. Be ready.
> - return -ENOMEM;
> + regbuf = NULL;
Any reason to prefer this over changing the declaration to include
the assignment?
void *regbuf = NULL;
> + if (reglen) {
> + regbuf = vzalloc(reglen);
> + if (!regbuf)
> + return -ENOMEM;
> + }
>
> ops->get_regs(dev, , regbuf);
>
> --
> 1.8.3.1
>
>
--
John W. LinvilleSomeday the world will need a hero, and you
linvi...@tuxdriver.com might be all we have. Be ready.
I forgot to Cc Johannes and Kalle...
On Thu, Jan 19, 2017 at 09:15:09AM -0500, John W. Linville wrote:
> On Thu, Jan 19, 2017 at 07:35:22AM -0500, David Arcari wrote:
> > On 01/18/2017 11:45 AM, David Miller wrote:
> > > From: David Arcari <darc...@redhat.com>
> >
driver-specific feature for
userland ethtool. Realistically, there are probably very few users
to care. But I can't guarantee that the number is zero.
Possible solutions:
-- break userland ethtool for at76c50x-usb
-- avoid 0-len allocation attempt (David Arcari's patch)
-- make allocator
L_PHY_STUNABLE and PHY
> downshift
>
> ethtool-copy.h | 21 +++--
> ethtool.8.in | 40
> ethtool.c | 144
> +
> 3 files changed, 202 insertions(+), 3 deletions(-)
>
> --
> 2.7.3
Merged.
--
John W. LinvilleSomeday the world will need a hero, and you
linvi...@tuxdriver.com might be all we have. Be ready.
the function call.
>
> Fixes: 08399efc6319 ("geneve: ensure ECN info is handled properly in all
> tx/rx paths")
> Signed-off-by: Sabrina Dubroca <s...@queasysnail.net>
Reviewed-by: John W. Linville <linvi...@tuxdriver.com>
--
John W. LinvilleSom
On Wed, Nov 23, 2016 at 10:24:47AM -0500, John W. Linville wrote:
> It looks like this patch somehow misses the following commit:
>
> commit 85a624403c77c3f074931aefdfced59f61b668cb
> Author: Jesse Brandeburg <jesse.brandeb...@intel.com>
> Date: Thu Oct 13 16:13:55 2016 -
htool_link_settings
> */
> #define ETHTOOL_SLINKSETTINGS0x004d /* Set ethtool_link_settings
> */
> -
> +#define ETHTOOL_PHY_GTUNABLE 0x004e /* Get PHY tunable configuration */
> +#define ETHTOOL_PHY_STUNABLE 0x004f /* Set PHY tunable configuration */
>
> /* compatibility with older code */
> #define SPARC_ETH_GSET ETHTOOL_GSET
> --
> 2.7.3
>
>
--
John W. LinvilleSomeday the world will need a hero, and you
linvi...@tuxdriver.com might be all we have. Be ready.
amp; full_advertising_wanted == NULL.
>
> Signed-off-by: Michael Chan <michael.c...@broadcom.com>
Thanks, Michael -- merging...
John
--
John W. LinvilleSomeday the world will need a hero, and you
linvi...@tuxdriver.com might be all we have. Be ready.
ol)0x
>
> Signed-off-by: Taku Izumi <izumi.t...@jp.fujitsu.com>
Thank you, Taku Izumi. I have merged this patch and will be pushing
it shortly.
I apologize for the delay.
John
--
John W. LinvilleSomeday the world will need a hero, and you
linvi...@tuxdriver.com might be all we have. Be ready.
> mechanism to avoid this situation.
>
> Signed-off-by: Pravin B Shelar <pshe...@ovn.org>
LGTM, although I reckon that Stephen's comment about RCU_INIT_POINTER
applies to this patch as well.
Either way...
Acked-by: John W. Linville <linvi...@tuxdriver.com>
&
"int",
which happens to match the actual users of nft_parse_u32_check already.
Found by Coverity, CID 1373930.
Note that commit 21a9e0f1568ea ("netfilter: nft_exthdr: fix error
handling in nft_exthdr_init()) attempted to address the issue, but
did not address the return type o
On Tue, Oct 25, 2016 at 03:08:04PM -0400, John W. Linville wrote:
> Commit 36b701fae12ac ("netfilter: nf_tables: validate maximum value of
> u32 netlink attributes") introduced nft_parse_u32_check with a return
> value of "unsigned int", yet on error it returns "
"int",
which happens to match the actual users of nft_parse_u32_check already.
Found by Coverity, CID 1373930.
Note that commit 21a9e0f1568ea ("netfilter: nft_exthdr: fix error
handling in nft_exthdr_init()) attempted to address the issue, but
did not address the return type o
: Enhancing link mode bits to support 25G/50G/100G
* Feature: add support for 1000BaseX and missing 10G link mode
* Fixes: address Coverity issues 1363118 - 1363125
John
--
John W. LinvilleSomeday the world will need a hero, and you
linvi...@tuxdriver.com
On Mon, Oct 03, 2016 at 01:54:26PM -0400, Jarod Wilson wrote:
> On Fri, Sep 30, 2016 at 03:56:16PM -0400, John W. Linville wrote:
> > Coverity issue: 1363119
> > Fixes: e1ee596326ae ("Add support for querying and setting private flags")
> >
> > S
Coverity issue: 1363119
Fixes: e1ee596326ae ("Add support for querying and setting private flags")
Signed-off-by: John W. Linville <linvi...@tuxdriver.com>
Reviewed-by: Greg Rose <gr...@lightfleet.com>
---
ethtool.c | 14 ++
1 file changed, 10 insertions(+)
Coverity issue: 1363123
Fixes: 6042804cf6ecc ("Change -k/-K options to use ETHTOOL_{G,S}FEATURES")
Signed-off-by: John W. Linville <linvi...@tuxdriver.com>
---
ethtool.c | 41 -
1 file changed, 28 insertions(+), 13 deletions(-)
diff --g
Coverity issue: 1363118
Fixes: fef1c4a19703 ("ethtool: add get permanent address option")
Signed-off-by: John W. Linville <linvi...@tuxdriver.com>
---
ethtool.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/ethtool.c b/ethtool.c
index 6287b559c699..aa3ef5ed2f75 100644
Coverity issues: 1363120, 1363121
Fixes: 6042804cf6ec ("Change -k/-K options to use ETHTOOL_{G,S}FEATURES")
Signed-off-by: John W. Linville <linvi...@tuxdriver.com>
---
ethtool.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/ethtool.c b/ethtool.c
index 0885a61097ad..094
Coverity issue: 1363119
Fixes: e1ee596326ae ("Add support for querying and setting private flags")
Signed-off-by: John W. Linville <linvi...@tuxdriver.com>
---
ethtool.c | 18 +-
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/ethtool.c b
Coverity issue: 1363122
Fixes: 6042804cf6ecc ("Change -k/-K options to use ETHTOOL_{G,S}FEATURES")
Signed-off-by: John W. Linville <linvi...@tuxdriver.com>
---
ethtool.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/ethtool.c b/ethtool.c
index 2fd3393ca5f6..840
Coverity issue: 1363124
Fixes: e1ee596326ae ("Add support for querying and setting private flags")
Signed-off-by: John W. Linville <linvi...@tuxdriver.com>
---
ethtool.c | 19 +--
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git a/ethtool.c b
issues "fixed" both
to avoid them as distractions and just to promote better coding
practices overall.
These are "fresh off the press" -- I'll re-review them again before
applying and pushing them. I appreciate any extra eyeballs that can
review them as well.
John
Coverity issue: 1363125
Fixes: 6042804cf6ec ("Change -k/-K options to use ETHTOOL_{G,S}FEATURES")
Signed-off-by: John W. Linville <linvi...@tuxdriver.com>
---
ethtool.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/ethtool.c b/ethtool.c
index 406cfd2f95
On Tue, Sep 06, 2016 at 04:55:11PM -0700, Vidya Sagar Ravipati wrote:
> From: Vidya Sagar Ravipati <vi...@cumulusnetworks.com>
>
> Man page update to include updated advertised speeds for
> 1G/10G
>
> Signed-off-by: Vidya Sagar Ravipati <vi...@cumulusnetworks.com>
thtool-copy.h:sync with net
> ethtool: add support for 1000BaseX and missing 10G link mode
>
> ethtool-copy.h | 11 +--
> ethtool.c | 19 +++
> 2 files changed, 28 insertions(+), 2 deletions(-)
>
> --
> 2.1.4
LGTM -- applied
Would you ca
On Wed, Aug 24, 2016 at 10:33:04AM -0400, John W. Linville wrote:
> On Wed, Aug 24, 2016 at 04:29:22AM +, Yuval Mintz wrote:
> > > This patch series provides following support
> > > a) Reorganized fields based out of SFF-8024 fields i.e. Identifier/
> > >
| 105 +---
> sfpid.c| 103 +---
> 10 files changed, 1945 insertions(+), 197 deletions(-)
> create mode 100644 qsfp.c
> create mode 100644 qsfp.h
> create mode 100644 sff-common.c
> create mode 100644 sff-common.h
>
> --
> 2.1.4
>
>
--
John W. LinvilleSomeday the world will need a hero, and you
linvi...@tuxdriver.com might be all we have. Be ready.
93714f964ffd1
> > which includes support for 50G base SR2
>
> What about the man-page?
I can just apply your man page patch on top.
John
--
John W. LinvilleSomeday the world will need a hero, and you
linvi...@tuxdriver.com might be all we have. Be ready.
I requested, I can simply take
your (i.e. Yuval's) patch 3/3 on top of that.
John
--
John W. LinvilleSomeday the world will need a hero, yand you
linvi...@tuxdriver.com might be all we have. Be ready.
4_Full_BIT,
> + "10baseCR4/Full" },
> + { 0, ETHTOOL_LINK_MODE_10baseLR4_ER4_Full_BIT,
> + "10baseLR4_ER4/Full" },
> };
> int indent;
> int did1, new_line_pend, i;
If my other comment wasn't clear, this is the patch I
to which I was suggesting that you could add support for
ETHTOOL_LINK_MODE_5baseSR2_Full_BIT.
John
--
John W. LinvilleSomeday the world will need a hero, and you
linvi...@tuxdriver.com might be all we have. Be ready.
sitive to indicate size used by kernel and cmd field is
> + * kernel expected size and all the other fields but cmd
> + * are 0; otherwise (handshake completed), strictly positive
> + * to indicate size used by kernel and cmd field stays
> * %ETHTOOL_GLINKSETTINGS, all o
Ping?
On Tue, Aug 02, 2016 at 03:49:57PM -0400, John W. Linville wrote:
> Are these revised patches still on their way?
>
> John
>
> On Sun, Jul 24, 2016 at 01:57:14AM -0700, Vidya Sagar Ravipati wrote:
> > Yuval,
> > I will try to resubmit the patches this
t; > > ethtool.c | 27 +++
> > > 1 file changed, 27 insertions(+)
> >
> > Hi Vidya,
> >
> > Are you re-trying your series one anytime soon?
> >
> > If not, can we simply push this [and ethtool-copy.h], as those are need
On Tue, Jul 12, 2016 at 11:34:06AM -0700, David Miller wrote:
> From: "John W. Linville" <linvi...@tuxdriver.com>
> Date: Tue, 12 Jul 2016 14:12:52 -0400
>
> > I haven't heard a strong case for why it is necessary.
>
> Stats on large scale setups/systems i
>> - More consistent output formatting
> >>>>
> >>>>That seems like a reasonable start for a TODO list. I'll bet there
> >>>>are a few people out there with other suggestions as well...?
> >>>
> >>> Before that, I would like to see ethtool migrate to use generic
> >>> netlink. Then, the new tool would be needed anyway, should exist within
> >>> iproute2 package and have similar command line syntax.
> >>>
> >>> I have some ideas about the gennetlink ethtool, have to find some time
> >>> to implement some initial part of it.
>
--
John W. LinvilleSomeday the world will need a hero, and you
linvi...@tuxdriver.com might be all we have. Be ready.
On Mon, Jul 04, 2016 at 07:18:48PM +0200, Ben Hutchings wrote:
> On Mon, 2016-06-27 at 09:51 -0400, John W. Linville wrote:
> > On Sun, Jun 26, 2016 at 06:11:41PM +0200, Ben Hutchings wrote:
> > > I've become steadily less enthusiastic and less responsive as a
> > > ma
On Thu, Jun 30, 2016 at 02:37:30PM -0500, Jorge Alberto Garcia wrote:
> El 30/06/2016 02:32 p.m., "Ben Hutchings" <b...@decadent.org.uk> escribió:
> >
> > On Thu, 2016-06-30 at 14:27 -0500, Jorge Alberto Garcia wrote:
> > > On Thu, Jun 30, 2016 a
On Mon, Jun 27, 2016 at 09:51:47AM -0400, John W. Linville wrote:
> On Sun, Jun 26, 2016 at 06:11:41PM +0200, Ben Hutchings wrote:
> > I've become steadily less enthusiastic and less responsive as a
> > maintainer over the past year or so. I no longer work on networking
> > r
I would be happy to take-on the job of ethtool maintainer,
and I look forward to getting back into a more concrete role within
the community. Any objections?
John
--
John W. LinvilleSomeday the world will need a hero, and you
linvi...@tuxdriver.com might be all we have. Be ready.
>sk.sk_family == family) {
> + geneve_get_sk_family(gs) == family) {
> return gs;
> }
> }
And back to calling it each time (as necessary inside the
list_for_each_entry).
So, it seems like geneve_get_sk_family needs to be inline -- maybe GCC
is doing that on its own? FWIW, I probably would cache the results
inside of geneve_rx like you have done in geneve_notify_add_rx_port
and geneve_notify_del_rx_port.
Thanks for the attention to geneve!
John
--
John W. LinvilleSomeday the world will need a hero, and you
linvi...@tuxdriver.com might be all we have. Be ready.
;
This time I really mean it... ;-)
Acked-by: John W. Linville <linvi...@tuxdriver.com>
--
John W. LinvilleSomeday the world will need a hero, and you
linvi...@tuxdriver.com might be all we have. Be ready.
--
To unsubscribe from this list: send the
ocation on xmit.
>
> This give a 6% speedup for unsegment traffic on geneve tunnel.
>
> Signed-off-by: Paolo Abeni <pab...@redhat.com>
> Acked-by: Hannes Frederic Sowa <han...@stressinduktion.org>
Acked-by: John W. Linville <linvi...@tuxdriver.com>
--
John W. Linville
!udp_csum);
> -
> - iptunnel_xmit_stats(err, >stats, dev->tstats);
> return NETDEV_TX_OK;
>
> tx_error:
So udp_tunnel_xmit_skb and udp_tunnel6_xmit_skb are different in this
regard? It seems so -- who knew? :-)
_Should_ they be different in this regard?
REMAIN(i), "Geneve ");
> +#endif
> if (pf->flags & I40E_FLAG_PTP)
> i += snprintf([i], REMAIN(i), " PTP");
> #ifdef I40E_FCOE
It seems like it should be " Geneve" rather than "Geneve "?
--
John W. LinvilleS
* |Virtual Network Identifier (VNI) |U| Csum start |
> * +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
> * |Variable Length Options|
> * +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
Otherwise, LGTM -- I'm really happy to see Geneve get this a
Tom Herbert <t...@herbertland.com>
Now I can drop this from my todo list... :-)
Acked-by: John W. Linville <linvi...@tuxdriver.com>
--
John W. LinvilleSomeday the world will need a hero, and you
linvi...@tuxdriver.com might be all we have. Be ready.
--
To
ed to live with existing hardware offloads, I would lean
toward a consolidated NDO. But if a different NDO per tunnel type is
preferred, I can be satisified with that.
John
--
John W. LinvilleSomeday the world will need a hero, and you
linvi...@tuxdriver.com
On Tue, Dec 01, 2015 at 04:49:28PM +0100, Hannes Frederic Sowa wrote:
> On Tue, Dec 1, 2015, at 16:44, John W. Linville wrote:
> > On Mon, Nov 30, 2015 at 09:26:51PM -0800, Tom Herbert wrote:
> > > On Mon, Nov 30, 2015 at 5:28 PM, Jesse Gross <je...@kernel.org> wrote:
>
Signed-off-by: John W. Linville <linvi...@tuxdriver.com>
---
v7 -- initial version (numbered to match earlier patches in series)
v8 -- fixup of bracing on an "else { return -EINVAL; }"
drivers/net/geneve.c | 29 ++---
1 file changed, 22 insertions(+), 7 de
Signed-off-by: John W. Linville <linvi...@tuxdriver.com>
---
v7 -- initial version (numbered to match earlier patches in series)
drivers/net/geneve.c | 28 +---
1 file changed, 21 insertions(+), 7 deletions(-)
diff --git a/drivers/net/geneve.c b/drivers/net/ge
NOTE: Link-local IPv6 addresses for remote endpoints are not supported,
since the driver currently has no capacity for binding a geneve
interface to a specific link.
Signed-off-by: John W. Linville <linvi...@tuxdriver.com>
Reviewed-by: Jesse Gross <je...@nicira.com>
---
v7:
- r
Other callers of udp_tunnel6_xmit_skb just pass 0 for the prio
argument. Jesse Gross <je...@nicira.com> suggested that prio is really
the same as IPv4's tos and should be handled the same, so this is my
interpretation of that suggestion.
Signed-off-by: John W. Linville <linvi...@tuxd
On Fri, Oct 23, 2015 at 01:48:49PM +0900, YOSHIFUJI Hideaki wrote:
> Hi,
>
> John W. Linville wrote:
> > NOTE: Link-local IPv6 addresses for remote endpoints are not supported,
> > since the driver currently has no capacity for binding a geneve
> > interface to a spe
NOTE: Link-local IPv6 addresses for remote endpoints are not supported,
since the driver currently has no capacity for binding a geneve
interface to a specific link.
Signed-off-by: John W. Linville <linvi...@tuxdriver.com>
---
v6:
- fix a typo (missing {}'s)
v5:
- wrap declaration of
Other callers of udp_tunnel6_xmit_skb just pass 0 for the prio
argument. Jesse Gross <je...@nicira.com> suggested that prio is really
the same as IPv4's tos and should be handled the same, so this is my
interpretation of that suggestion.
Signed-off-by: John W. Linville <linvi...@tuxd
NOTE: Link-local IPv6 addresses for remote endpoints are not supported,
since the driver currently has no capacity for binding a geneve
interface to a specific link.
Signed-off-by: John W. Linville <linvi...@tuxdriver.com>
---
v5:
- wrap declaration of sock6 in geneve_dev with IS_E
1 - 100 of 773 matches
Mail list logo
