Re: [PATCH] llc: dont trust payload size on test cmd

2008-02-25 Thread Joonwoo Park
3, dsize); > skb_put(skb, dsize); > } > > - End forwarded message - [PATCH] LLC: discard malfromed llc packet Discard llc packet which has invalid data size. Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]> --- net/llc/llc_input.c |7 +-- 1 files ch

Re: [PATCH] llc: fix skb size for test responses

2008-02-25 Thread Joonwoo Park
On Sun, Feb 24, 2008 at 11:07:58AM -0800, Jim Westfall wrote: > Hi > > The llc test command is used for a layer2 ping and contains a variable > length payload that we must include in the response. Use the size of the > received skb as the size of the skb we must allocate to hold the payload. >

Re: [PATCH] llc: fix skb size for test responses

2008-02-25 Thread Joonwoo Park
2008/2/25, Jim Westfall <[EMAIL PROTECTED]>: > David Miller <[EMAIL PROTECTED]> wrote [02.24.08]: > > From: Jim Westfall <[EMAIL PROTECTED]> > > Date: Sun, 24 Feb 2008 11:07:58 -0800 > > > > > Hi > > > > > > The llc test command is used for a layer2 ping and contains a variable > > > length payload

Re: Error on ip route replace command

2008-02-22 Thread Joonwoo Park
2008/2/23, Francesco Saverio Giudice <[EMAIL PROTECTED]>: > Hi All, > > I have a problem with kernel 2.6.24. > > Having a running configuration using Shorewall and restarting it I got > follow error: > RTNETLINK answers: File exists > > Tom Eastep, Shorewall creator, told me to inform you about the

[PATCH] [NETFILTER]: fix ebtable targets return

2008-02-20 Thread Joonwoo Park
The function ebt_do_table doesn't take NF_DROP as a verdict from the targets. Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]> --- net/bridge/netfilter/ebt_dnat.c |2 +- net/bridge/netfilter/ebt_redirect.c |2 +- net/bridge/netfilter/ebt_snat.c |2 +- 3 files

Re: [Bugme-new] [Bug 9920] New: kernel panic when using ebtables redirect target

2008-02-18 Thread Joonwoo Park
gt; ff 8b 5c 24 30 8b 54 24 34 8d 04 5b 8d 04 82 8b 54 24 20 <89> 28 42 89 50 > > 08 8b > > 5f 6c 01 df 89 78 04 8b 6c 24 38 8b 54 24 > > EIP: [] ebt_do_table+0x4ea/0x5d0 [ebtables] SS:ESP 0068:c0315e20 > > > > > -- > To unsubscribe from this list: send the

[PATCH] [RESENDING] netconsole: register cmdline netconsole configs to configfs

2008-02-11 Thread Joonwoo Park
eview netconsole target configs from cmdline. Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]> --- drivers/net/netconsole.c | 91 -- 1 files changed, 72 insertions(+), 19 deletions(-) diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c in

Re: [PATCH 2.6.24] fib_trie: apply fixes from fib_hash

2008-01-25 Thread Joonwoo Park
2008/1/26, Joonwoo Park <[EMAIL PROTECTED]>: > On Sat, Jan 26, 2008 at 04:40:30AM +0200, Julian Anastasov wrote: > > > > Signed-off-by: Julian Anastasov <[EMAIL PROTECTED]> > > --- > > > > Not tested, someone please check the findings >

Re: [PATCH 2.6.24] fib_trie: apply fixes from fib_hash

2008-01-25 Thread Joonwoo Park
On Sat, Jan 26, 2008 at 04:40:30AM +0200, Julian Anastasov wrote: > > Signed-off-by: Julian Anastasov <[EMAIL PROTECTED]> > --- > > Not tested, someone please check the findings > > --- linux-2.6.24/net/ipv4/fib_trie.c_orig 2008-01-25 10:45:06.0 > +0200 > + > if

Re: [Bugme-new] [Bug 9816] New: cannot replace route

2008-01-25 Thread Joonwoo Park
2008/1/26, Andrew Morton <[EMAIL PROTECTED]>: > > But whatever. It used to work. People's scripts will break. Regression. > Also I thought that 'replace with itself' should be error as like Jarek. But it used to work and patch made a regression, it's my bad :( I think Julian's recent patches

Re: [PATCH] [IPV4] route: fix locking in rt_run_flush()

2008-01-23 Thread Joonwoo Park
2008/1/24, Eric Dumazet <[EMAIL PROTECTED]>: > > Unfortunatly, your patch doesnt work on CONFIG_SMP=n (softirq will be disabled > for the whole scan of table) > > Also, some machines around there have 2^22 slots in hash table, and NR_CPUS=4, > so softirqs will be disabled for a too long time. > > P

[PATCH] [IPV4] route: fix locking in rt_run_flush()

2008-01-20 Thread Joonwoo Park
flush+0xd6/0xe0 [ 363.761917] [] fib_netdev_event+0x89/0xa0 [ 363.769361] [] notifier_call_chain+0x37/0x80 ... This patch makes rt_run_flush() to run with softirq is disabled. Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]> --- net/ipv4/route.c |6 -- 1 files changed, 4 insertions(+), 2 del

[PATCH 2/2] [IPV4] fib_trie: fix duplicated route issue

2008-01-16 Thread Joonwoo Park
http://bugzilla.kernel.org/show_bug.cgi?id=9493 The fib allows making identical routes with 'ip route replace'. This patch makes the fib return -EEXIST if replacement would cause duplication. Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]> --- net/ipv4/fib_trie.c |3 +++ 1

[PATCH 1/2] [IPV4] fib_hash: fix duplicated route issue

2008-01-16 Thread Joonwoo Park
http://bugzilla.kernel.org/show_bug.cgi?id=9493 The fib allows making identical routes with 'ip route replace'. This patch makes the fib return -EEXIST if replacement would cause duplication. Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]> --- net/ipv4/fib_hash.c |3 +++ 1

Re: [ipw3945-devel] [PATCH 2/5] iwlwifi: iwl3945 synchronize interruptand tasklet for down iwlwifi

2008-01-14 Thread Joonwoo Park
uld be called after doing synchronize_irq. To avoid races between iwl_synchronize_irq and iwl_irq_tasklet STATUS_INT_ENABLED flag is needed. Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]> --- drivers/net/wireless/iwlwifi/iwl3945-base.c | 33 ++- 1 files changed,

Re: [ipw3945-devel] [PATCH 2/5] iwlwifi: iwl3945 synchronize interruptand tasklet for down iwlwifi

2008-01-14 Thread Joonwoo Park
Joonwoo Park wrote: 2008/1/11, Chatre, Reinette <[EMAIL PROTECTED]>: On Thursday, January 10, 2008 5:25 PM, Joonwoo Park wrote: What modification are you considering? Roughly, I'm considering make synchronize_irq() be moved into iwl_disable_interrupts() and fix iwl_irq_tasket

Re: [ipw3945-devel] [PATCH 4/5] iwlwifi: iwl3945 eliminate sleepable task queue from context

2008-01-10 Thread Joonwoo Park
2008/1/11, Zhu Yi <[EMAIL PROTECTED]>: > > The version doesn't work on a .24-rc kernel. Can you compile it > with .23? > Thank you for your help, I built it. Thanks, Joonwoo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More maj

Re: [ipw3945-devel] [PATCH 4/5] iwlwifi: iwl3945 eliminate sleepable task queue from context

2008-01-10 Thread Joonwoo Park
2008/1/11, Zhu Yi <[EMAIL PROTECTED]>: > Hi Joonwoo, > > We already did something similiar in our code base. Could you please > take a look at this patch? > > http://intellinuxwireless.org/repos/?p=iwlwifi.git;a=commitdiff;h=57aa02255e9d7be5e2494683fc2793bd1d0707e2 > > Thanks, > -yi Ooops :-) I sh

Re: [ipw3945-devel] [PATCH 2/5] iwlwifi: iwl3945 synchronize interruptand tasklet for down iwlwifi

2008-01-10 Thread Joonwoo Park
Hello Reinette, 2008/1/11, Chatre, Reinette <[EMAIL PROTECTED]>: > > Could synchronize_irq() be moved into iwl_disable_interrupts() ? I am At this time, iwl_disable_interrupts() can be called with irq disabled, so for do that I think additional modification would be needed. > also wondering if w

[PATCH 5/5] iwlwifi: iwl3945 switch private workqueue to ieee80211->workqueue

2008-01-09 Thread Joonwoo Park
The ieee80211 provides workqueue for nic drivers. private workqueue dosen't need anymore TODO: remove workqueue in iwl_priv Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]> --- drivers/net/wireless/iwlwifi/iwl-3945.c |6 ++-- drivers/net/wireless/iwlwifi/iwl3945-ba

[PATCH 4/5] iwlwifi: iwl3945 eliminate sleepable task queue from context

2008-01-09 Thread Joonwoo Park
Eleminiate task queuing of iwl_pci_probe, register hw to ieee80211 immediately Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]> --- drivers/net/wireless/iwlwifi/iwl3945-base.c | 66 +- 1 files changed, 43 insertions(+), 23 deletions(-) diff --git a/drivers/net/wi

[PATCH 3/5] iwlwifi: iwl3945 fix oops while pci remove

2008-01-09 Thread Joonwoo Park
EIP: [] iwl_irq_tasklet+0x82d/0x1010 [iwl3945] SS:ESP 0068:f7c4ff1c Kernel panic - not syncing: Fatal exception in interrupt Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]> --- drivers/net/wireless/iwlwifi/iwl3945-base.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --gi

[PATCH 2/5] iwlwifi: iwl3945 synchronize interrupt and tasklet for down iwlwifi

2008-01-09 Thread Joonwoo Park
After disabling interrupts, it's possible irq & tasklet is pending or running This patch eleminates races for down iwlwifi Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]> --- drivers/net/wireless/iwlwifi/iwl3945-base.c |4 1 files changed, 4 insertions(+), 0 deletions(-

[PATCH 0/5] iwlwifi: iwl3945 fix races, getting rid of sleep from context

2008-01-09 Thread Joonwoo Park
Hello, This patchset does fix iwl3945's races and some other stuff. For now it works for just iwl3945 but if some of them is needed for iwl4965, I would work for it. patch against 2.6.24-rc7 [PATCH 1/5] iwlwifi: iwl3945 flush interrupt mask [PATCH 2/5] iwlwifi: iwl3945 synchronize interrupt and

[PATCH 1/5] iwlwifi: iwl3945 flush interrupt mask

2008-01-09 Thread Joonwoo Park
After enabling/disabling interrupts flushing is required Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]> --- drivers/net/wireless/iwlwifi/iwl-io.h |2 ++ drivers/net/wireless/iwlwifi/iwl3945-base.c |6 ++ 2 files changed, 8 insertions(+), 0 deletions(-) diff --git a/d

RE: [PATCH 25/26] [REVISED] atl1: add NAPI support

2008-01-01 Thread Joonwoo Park
Hi Jay, + if ((work_done < budget) || !netif_running(poll_dev)) { +quit_polling: + netif_rx_complete(poll_dev, napi); + + if (!test_bit(__ATL1_DOWN, &adapter->flags)) + atlx_irq_enable(adapter); + } Not enough :) If netif_running() is

[PATCH] netconsole: register cmdline netconsole configs to configfs

2007-12-25 Thread Joonwoo Park
eview netconsole target configs from cmdline. Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]> --- drivers/net/netconsole.c | 91 -- 1 files changed, 72 insertions(+), 19 deletions(-) diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c in

Re: [PATCH 1/7] [NETDEV]: e1000 Fix possible causing oops of net_rx_action

2007-12-13 Thread Joonwoo Park
2007/12/13, David Miller <[EMAIL PROTECTED]>: > From: "Joonwoo Park" <[EMAIL PROTECTED]> > Date: Thu, 13 Dec 2007 19:18:56 +0900 > > > Just blowing netif_running up is not best solution I think, it makes > > ifconfig down hang at least for e1000. > &g

Re: [RFC] net: napi fix

2007-12-13 Thread Joonwoo Park
2007/12/13, Andrew Gallatin <[EMAIL PROTECTED]>: > > If the netif_running() check is indeed required to make a device break > out of napi polling and respond to an ifconfig down, then I think the > netif_running() check should be moved up into net_rx_action() to avoid > potential for driver complex

RE: [PATCH 1/7] [NETDEV]: e1000 Fix possible causing oops of net_rx_action

2007-12-13 Thread Joonwoo Park
2007/12/12, Joonwoo Park <[EMAIL PROTECTED]>: > [NETDEV]: e1000 Fix possible causing oops of net_rx_action > returning work_done == weight as true after calling netif_rx_complete will > cause oops in net_rx_action. > I tried two types of patches for oops and ifconfig down ha

Re: [RFC] net: napi fix

2007-12-12 Thread Joonwoo Park
2007/12/13, Kok, Auke <[EMAIL PROTECTED]>: > David Miller wrote: > > From: Andrew Gallatin <[EMAIL PROTECTED]> > > Date: Wed, 12 Dec 2007 12:29:23 -0500 > > > >> Is the netif_running() check even required? > > > > No, it is not. > > > > When a device is brought down, one of the first things > > tha

Re: [PATCH 6/7] [NETDEV]: tehuti Fix possible causing oops of net_rx_action

2007-12-12 Thread Joonwoo Park
2007/12/13, David Miller <[EMAIL PROTECTED]>: > From: "Joonwoo Park" <[EMAIL PROTECTED]> > Date: Wed, 12 Dec 2007 13:01:27 +0900 > > > Any time your trying to make a caller "happy" by adjusting > a return value forcefully, it's a hack.

Re: [PATCH 7/7] [NETDEV]: myri10ge Fix possible causing oops of net_rx_action

2007-12-12 Thread Joonwoo Park
2007/12/12, Subrata Modak <[EMAIL PROTECTED]>: > Would you like to submit the Driver Test Cases to LTP ? Or, if you have > your Driver test cases written in C, we can port to LTP and have it > inside the LTP package. > You can also check out the following links for more info, and can always > ping

Re: [PATCH 1/2] [net/wireless/iwlwifi] : iwlwifi 3945 Fix raceconditional panic.

2007-12-12 Thread Joonwoo Park
2007/12/12, Andrew Morton <[EMAIL PROTECTED]>: > > Did drivers/net/wireless/iwlwifi/iwl4965-base.c get fixed in a simlar > fashion? > Hi Andrew, Both of them was applied to mainline. commit 3ae6a054553ee8b7f74bf7de8904022b26705778 Author: Joonwoo Park <[EMAIL PROTECTED]>

Re: [RFC] net: napi fix

2007-12-11 Thread Joonwoo Park
2007/12/12, Stephen Hemminger <[EMAIL PROTECTED]>: > Isn't this a better fix for all drivers, rather than peppering every > driver with the special case. This is how the logic worked up until > 2.6.24. > > > --- a/net/core/dev.c2007-12-11 12:16:20.0 -0800 > +++ b/net/core/dev.c2007-

Re: [PATCH 6/7] [NETDEV]: tehuti Fix possible causing oops of net_rx_action

2007-12-11 Thread Joonwoo Park
2007/12/12, Stephen Hemminger <[EMAIL PROTECTED]>: > On Wed, 12 Dec 2007 13:01:27 +0900 > "Joonwoo Park" <[EMAIL PROTECTED]> wrote: > > > [NETDEV]: tehuti Fix possible causing oops of net_rx_action > > > > Signed-off-by: Joonwoo Park <[EMAIL

[PATCH 2/7] [NETDEV]: e1000e Fix possible causing oops of net_rx_action

2007-12-11 Thread Joonwoo Park
[NETDEV]: e1000e Fix possible causing oops of net_rx_action Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]> --- drivers/net/e1000e/netdev.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c index 4fd2e23..8

[PATCH 1/7] [NETDEV]: e1000 Fix possible causing oops of net_rx_action

2007-12-11 Thread Joonwoo Park
[NETDEV]: e1000 Fix possible causing oops of net_rx_action returning work_done == weight as true after calling netif_rx_complete will cause oops in net_rx_action. Thanks Joonwoo Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_main.c |2 ++ 1 files chan

[PATCH 4/7] [NETDEV]: ixgbe Fix possible causing oops of net_rx_action

2007-12-11 Thread Joonwoo Park
[NETDEV]: ixgbe Fix possible causing oops of net_rx_action Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]> --- drivers/net/ixgbe/ixgbe_main.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c index 0

[PATCH 3/7] [NETDEV]: ixgb Fix possible causing oops of net_rx_action

2007-12-11 Thread Joonwoo Park
[NETDEV]: ixgb Fix possible causing oops of net_rx_action Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]> --- drivers/net/ixgb/ixgb_main.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/net/ixgb/ixgb_main.c b/drivers/net/ixgb/ixgb_main.c index 3021234..a

[PATCH 5/7] [NETDEV]: e100 Fix possible causing oops of net_rx_action

2007-12-11 Thread Joonwoo Park
[NETDEV]: e100 Fix possible causing oops of net_rx_action Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]> --- drivers/net/e100.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/net/e100.c b/drivers/net/e100.c index e1c8a0d..7cb4ed0 100644 --- a/drivers/ne

[PATCH 7/7] [NETDEV]: myri10ge Fix possible causing oops of net_rx_action

2007-12-11 Thread Joonwoo Park
[NETDEV]: myri10ge Fix possible causing oops of net_rx_action Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]> --- drivers/net/myri10ge/myri10ge.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/net/myri10ge/myri10ge.c b/drivers/net/myri10ge/myri10ge.c

[PATCH 6/7] [NETDEV]: tehuti Fix possible causing oops of net_rx_action

2007-12-11 Thread Joonwoo Park
[NETDEV]: tehuti Fix possible causing oops of net_rx_action Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]> --- drivers/net/tehuti.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/net/tehuti.c b/drivers/net/tehuti.c index 21230c9..955e749 100644 --- a/d

Re: [PATCH] [NET]: Fix Ooops of napi net_rx_action.

2007-12-11 Thread Joonwoo Park
2007/12/12, Brandeburg, Jesse <[EMAIL PROTECTED]>: > > all drivers using NAPI in 2.6.24+ (NNAPI??) must return zero here, after > calling netif_rx_complete. netif_rx_complete plus work_done != 0 causes > a bug. > Brandeburg, Don't we need to return non-zero work_done after netif_rx_complete if wo

Re: [PATCH] [NET]: Fix Ooops of napi net_rx_action.

2007-12-11 Thread Joonwoo Park
2007/12/12, Brandeburg, Jesse <[EMAIL PROTECTED]>: > Joonwoo Park wrote: > > /* If no Tx and not enough Rx work done, exit the polling mode */ > > if ((!tx_cleaned && (work_done == 0)) || > >!netif_running(poll_dev)) { > > quit_polling: &g

Re: [PATCH] [NET]: Fix Ooops of napi net_rx_action.

2007-12-11 Thread Joonwoo Park
2007/12/11, David Miller <[EMAIL PROTECTED]>: > From: "Joonwoo Park" <[EMAIL PROTECTED]> > Date: Tue, 11 Dec 2007 18:13:34 +0900 > > Joonwoo-ssi annyoung haseyo, Wow Great! :-) > How can the NAPI_STATE_SCHED bit be cleared externally yet we take >

[PATCH] [NET]: Fix Ooops of napi net_rx_action.

2007-12-11 Thread Joonwoo Park
[NET]: Fix Ooops of napi net_rx_action. Before doing list_move_tail napi poll_list, it should be ensured Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]> --- diff --git a/net/core/dev.c b/net/core/dev.c index 86d6261..74bd5ab 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -2207,7 +

Re: [PATCH] NET: ASSERT_RTNL in __dev_set_promiscuity makes debug warning

2007-12-04 Thread Joonwoo Park
2007/12/5, Herbert Xu <[EMAIL PROTECTED]>: > The idea is to not touch the unicast stuff at all on the multicast path. > > Anyway, this was discussed on netdev so please check the archives because > there is more to this than just changing the multicast handling. We also > talked about consolidatin

RE: [PATCH] NET: ASSERT_RTNL in __dev_set_promiscuity makes debug warning

2007-12-04 Thread Joonwoo Park
2007/12/5, Herbert Xu <[EMAIL PROTECTED]>: > Joonwoo Park <[EMAIL PROTECTED]> wrote: > > Hi, > > dev_set_rx_mode calls __dev_set_rx_mode with softirq disabled (by > > netif_tx_lock_bh) > > therefore __dev_set_promiscuity can be called with softirq disabl

NET: ASSERT_RTNL in __dev_set_promiscuity makes debug warning

2007-12-04 Thread Joonwoo Park
Hi, dev_set_rx_mode calls __dev_set_rx_mode with softirq disabled (by netif_tx_lock_bh) therefore __dev_set_promiscuity can be called with softirq disabled. It will cause in_interrupt() to return true and ASSERT_RTNL warning. Is there a good solution to fix it besides blowing ASSERT_RTNL up? Than

RE: [PATCH 2/2] [net/wireless/iwlwifi] : iwlwifi 4965 Fix race conditional panic.

2007-11-28 Thread Joonwoo Park
The cancel_delayed_work_sync has moved into ilw_cancel_deferred_work. Thanks Zhu Yi. [net/wireless/iwlwifi] : iwlwifi 4965 Fix race conditional panic. Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]> --- diff --git a/drivers/net/wireless/iwlwifi/iwl4965-base.c b/drivers/net/wireless/i

RE: [PATCH 1/2] [net/wireless/iwlwifi] : iwlwifi 3945 Fix raceconditional panic.

2007-11-28 Thread Joonwoo Park
[net/wireless/iwlwifi] : iwlwifi 3945 Fix race conditional panic. Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]> --- diff --git a/drivers/net/wireless/iwlwifi/iwl3945-base.c b/drivers/net/wireless/iwlwifi/iwl3945-base.c index 465da4f..e51e872 100644 --- a/drivers/net/wireless/iwlwifi/iwl

[PATCH 1/2] [net/wireless/iwlwifi] : iwlwifi 3945 Fix race conditional panic.

2007-11-28 Thread Joonwoo Park
04 00 00 <3b> 06 74 0d 43 83 fb 02 77 23 c7 45 e8 fb ff ff ff 83 c1 64 39 EIP: [] iwl_verify_inst_sparse+0x101/0x140 [iwl3945] SS:ESP 0068:dfef5f00 Thanks Joonwoo [net/wireless/iwlwifi] : iwlwifi 3945 Fix race conditional panic. Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]>

[PATCH 2/2] [net/wireless/iwlwifi] : iwlwifi 4965 Fix race conditional panic.

2007-11-28 Thread Joonwoo Park
I think 4965 may suffer it too, but I could not test. Thanks Joonwoo [net/wireless/iwlwifi] : iwlwifi 4965 Fix race conditional panic. Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]> --- diff --git a/drivers/net/wireless/iwlwifi/iwl4965-base.c b/drivers/net/wireless/iwlwifi/iwl4965-

RE: [PATCH] [NET]: Fix TX bug VLAN in VLAN

2007-11-26 Thread Joonwoo Park
2007/11/27, Herbert Xu <[EMAIL PROTECTED]>: > On Tue, Nov 27, 2007 at 02:32:49PM +0900, Joonwoo Park wrote: > > > > Thanks Herbert. > > Well.. I think patch would work propely for AF_PACKET also. > > (I did not insert BUG() macro in my patch) > > How do you

Re: [PATCH] [NET]: Fix TX bug VLAN in VLAN

2007-11-26 Thread Joonwoo Park
2007/11/26, Herbert Xu <[EMAIL PROTECTED]>: > On Fri, Nov 23, 2007 at 12:12:52PM +, Joonwoo Park wrote: > > This patch fixes http://bugzilla.kernel.org/show_bug.cgi?id=8766 > > > > Is it possible? > > BUG((veth->h_vlan_proto != htons(ETH_P_8021Q))

Re: [PATCH 4/4] atm/ambassador: kmalloc + memset conversion to kzalloc

2007-11-26 Thread Joonwoo Park
2007/11/26, Robert P. J. Day <[EMAIL PROTECTED]>: > i realized that. but all you can say is that only amb_init() calls > setup_dev() *currently*. when you're not looking, someone else might > (for whatever reason) call setup_dev() from elsewhere, and *that* call > might not zero that memory area.

Re: [PATCH 1/4] xfrm_hash: kmalloc + memset conversion to kzalloc

2007-11-26 Thread Joonwoo Park
> > i believe the more common standard for the above is: > > else if (hashdist) { > > to reduce the level of overall indentation, no? > No, it was. Because there was a memset in that indentation, but I made it by removing memset. Thanks. Joonwoo - To unsubscribe from this list: send the line "un

Re: [PATCH 3/4] fib_hash: kmalloc + memset conversion to kzalloc

2007-11-26 Thread Joonwoo Park
fib_hash: kmalloc + memset conversion to kzalloc fix to avoid memset entirely. Thanks. Joonwoo Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]> --- diff --git a/net/ipv4/fib_hash.c b/net/ipv4/fib_hash.c index 527a6e0..9d0cee2 100644 --- a/net/ipv4/fib_hash.c +++ b/net/ipv4/fib_hash.c @@ -

Re: [PATCH 2/4] fib_semantics: kmalloc + memset conversion to kzalloc

2007-11-26 Thread Joonwoo Park
fib_semantics: kmalloc + memset conversion to kzalloc fix to avoid memset entirely. Thanks. Joonwoo Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]> --- diff --git a/net/ipv4/fib_semantics.c b/net/ipv4/fib_semantics.c index 1351a26..352f8c4 100644 --- a/net/ipv4/fib_semantics.c +++ b/ne

Re: [PATCH 4/4] atm/ambassador: kmalloc + memset conversion to kzalloc

2007-11-26 Thread Joonwoo Park
2007/11/26, Robert P. J. Day <[EMAIL PROTECTED]>: > i'm not sure the above is a safe thing to do, as you're zeroing that > area, then making a function call and assuming, upon entry to the > function call, that the caller has done the right thing. i don't see > how you can count on that, depending

RE: [PATCH 1/4] xfrm_hash: kmalloc + memset conversion to kzalloc

2007-11-26 Thread Joonwoo Park
ks. Joonwoo Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]> --- diff --git a/net/xfrm/xfrm_hash.c b/net/xfrm/xfrm_hash.c index 55ab579..a2023ec 100644 --- a/net/xfrm/xfrm_hash.c +++ b/net/xfrm/xfrm_hash.c @@ -17,17 +17,14 @@ struct hlist_head *xfrm_hash_alloc(unsigned int sz)

[PATCH 2/4] fib_semantics: kmalloc + memset conversion to kzalloc

2007-11-26 Thread Joonwoo Park
fib_semantics: kmalloc + memset conversion to kzalloc Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]> Thanks. Joonwoo --- diff --git a/net/ipv4/fib_semantics.c b/net/ipv4/fib_semantics.c index 1351a26..87a1e72 100644 --- a/net/ipv4/fib_semantics.c +++ b/net/ipv4/fib_semantics.c @@ -

[PATCH 3/4] fib_hash: kmalloc + memset conversion to kzalloc

2007-11-26 Thread Joonwoo Park
fib_hash: kmalloc + memset conversion to kzalloc Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]> Thanks. Joonwoo --- diff --git a/net/ipv4/fib_hash.c b/net/ipv4/fib_hash.c index 527a6e0..2874fe7 100644 --- a/net/ipv4/fib_hash.c +++ b/net/ipv4/fib_hash.c @@ -102,10 +102,14 @@ static

[PATCH 4/4] atm/ambassador: kmalloc + memset conversion to kzalloc

2007-11-26 Thread Joonwoo Park
atm/ambassador: kmalloc + memset conversion to kzalloc Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]> Thanks. Joonwoo --- diff --git a/drivers/atm/ambassador.c b/drivers/atm/ambassador.c index b34b382..4f99ba3 100644 --- a/drivers/atm/ambassador.c +++ b/drivers/atm/ambassador.c @@ -

[PATCH 1/4] xfrm_hash: kmalloc + memset conversion to kzalloc

2007-11-26 Thread Joonwoo Park
xfrm_hash: kmalloc + memset conversion to kzalloc Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]> Thanks. Joonwoo --- diff --git a/net/xfrm/xfrm_hash.c b/net/xfrm/xfrm_hash.c index 55ab579..37795bd 100644 --- a/net/xfrm/xfrm_hash.c +++ b/net/xfrm/xfrm_hash.c @@ -17,16 +17,17 @@

[PATCH] [NET]: Fix TX bug VLAN in VLAN

2007-11-23 Thread Joonwoo Park
ET]: Fix TX bug VLAN in VLAN Fix misbehavior of vlan_dev_hard_start_xmit() for recursive encapsulations. Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]> --- diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c index 7a36878..3e34990 100644 --- a/net/8021q/vlan_dev.c +++ b/net/8021q/vlan_

FW: [PATCH 2/2] [e1000 VLAN] Disable vlan hw accel when promiscuous mode

2007-11-16 Thread Joonwoo Park
2007/11/11, Joonwoo Park <[EMAIL PROTECTED]>: > IMHO even though netdevice is in the promiscuous mode, we should receive all > of ingress packets. > This disable the vlan filtering feature when a vlan hw accel configured e1000 > device goes into promiscuous mode. > This ma

Re: [PATCH 2/2] [e1000 VLAN] Disable vlan hw accel when promiscuous mode

2007-11-13 Thread Joonwoo Park
> > I'll work e1000e too :-) > > awesome, looking forward to that. > BTW, It seems to need Patrick's unicast patch for e1000e first. I'll looking forward to that too. Thanks Joonwoo - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] M

RE: [PATCH 2/2] [e1000 VLAN] Disable vlan hw accel when promiscuous mode

2007-11-13 Thread Joonwoo Park
as applied. But the ich8lan stuff was not removed at this patch. I'll work e1000e too :-) Thanks. Joonwoo [E1000]: Disable vlan hw accel when promiscuous mode Even though netdevice is in the promiscuous mode, we should receive all of ingress packets. This disable the vlan filtering feature when

Re: [PATCH 2/2] [e1000 VLAN] Disable vlan hw accel when promiscuous mode

2007-11-12 Thread Joonwoo Park
2007/11/13, David Miller <[EMAIL PROTECTED]>: > From: Willy Tarreau <[EMAIL PROTECTED]> > Date: Tue, 13 Nov 2007 00:32:57 +0100 > > > At least, being able to disable the feature at module load time > > would be acceptable. Many people who often need to sniff on decent > > machines would always keep

Re: [PATCH 2/2] [e1000 VLAN] Disable vlan hw accel when promiscuous mode

2007-11-12 Thread Joonwoo Park
2007/11/13, Willy Tarreau <[EMAIL PROTECTED]>: > On Mon, Nov 12, 2007 at 02:57:16PM -0800, David Miller wrote: > > From: "Chris Friesen" <[EMAIL PROTECTED]> > > Date: Mon, 12 Nov 2007 16:43:24 -0600 > > > > > David Miller wrote: > > > > > > > When you select VLAN, you by definition are asking for n

[PATCH 1/2] [VLAN] Don't drop an unclassfied vlan packet as PACKET_OTHERHOST

2007-11-10 Thread Joonwoo Park
check, comments will be appreciated. Thanks. Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]> --- include/linux/if_vlan.h | 61 ++ 1 files changed, 34 insertions(+), 27 deletions(-) diff --git a/include/linux/if_vlan.h b/include/linux/if_v

[PATCH 2/2] [e1000 VLAN] Disable vlan hw accel when promiscuous mode

2007-11-10 Thread Joonwoo Park
check, comments will be appreciated. Thanks. Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_main.c | 26 -- 1 files changed, 20 insertions(+), 6 deletions(-) diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c in

[PATCH] kexec: fix pci device initialization fail after kexec (2.6.23-rc2). (Related to e1000 doesn't resume properly from standby)

2007-08-06 Thread Joonwoo Park
Hi. I think that the pci_set_power_state() has bug. The specification says that some delays is required. Simon, please can I know whether it works to you? It is seems to the things are related. Joonwoo Park. diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index 37c00f6..9f78064 100644 --- a