Re: [PATCH v3 2/2] ARM64: dts: meson-axg: enable ethernet for A113D S400 board

Yixun Lan writes: > This is tested in the S400 dev board which use a RTL8211F PHY, > and the pins connect to the 'eth_rgmii_y_pins' group. > > Reviewed-by: Neil Armstrong > Signed-off-by: Yixun Lan > --- >

Re: [PATCH v3 1/2] ARM64: dts: meson-axg: add ethernet mac controller

Yixun Lan writes: > Add DT info for the stmmac ethernet MAC which found in > the Amlogic's Meson-AXG SoC, also describe the ethernet > pinctrl & clock information here. > > Reviewed-by: Neil Armstrong > Signed-off-by: Yixun Lan

Re: [PATCH] ARM64: dts: meson-axg: add ethernet mac controller

Yixun Lan writes: > Add DT info for the stmmac ethernet MAC which found in > the Amlogic's Meson-AXG SoC, also describe the ethernet > pinctrl & clock information here. > > This is tested in the S400 dev board which use a RTL8211F PHY, > and the pins connect to the

Re: [PATCH net 5/7] net: ethernet: stmmac: dwmac-meson8b: fix probe error path

Johan Hovold <jo...@kernel.org> writes: > Make sure to disable clocks before returning on late probe errors. > > Fixes: 566e82516253 ("net: stmmac: add a glue driver for the Amlogic > Meson 8b / GXBB DWMAC") > Signed-off-by: Johan Hovold <jo...@kernel.

Re: [RFC PATCH 01/13] pinctrl: meson: Add GXL pinctrl definitions

me when I may apply it, it looks orthogonal >> to the rest of the patches. >> >> Yours, >> Linus Walleij >> > > Hi Linus, > > I'm ok to have it applied as soon as possible, but I can send a clean non-rfc > patch if needed. > Acked-by: Kevin Hilm

Re: [PATCH v3 0/5] meson: Meson8b and GXBB DWMAC glue driver

David Miller writes: > From: Martin Blumenstingl > Date: Tue, 30 Aug 2016 20:49:28 +0200 > >> On Mon, Aug 29, 2016 at 5:40 AM, David Miller wrote: >>> From: Martin Blumenstingl

Re: [PATCH 2/3] net: stmmac: add a glue driver for the Amlogic Meson 8b / GXBB DWMAC

> + ret = clk_set_rate(dwmac->m25_div_clk, clk_rate); > + if (ret) { > + clk_disable_unprepare(dwmac->m25_div_clk); > + > + dev_err(>pdev->dev, "failed to set PHY clock\n"); > + return ret; > + } In the case of success, the clock is never disabled/unprepared. You probably need a .remove function which disables the clock and then calls stmmac_pltfr_remove. > + /* enable TX_CLK and PHY_REF_CLK generator */ > + meson8b_dwmac_mask_bits(dwmac, PRG_ETH0, PRG_ETH0_TX_AND_PHY_REF_CLK, > + PRG_ETH0_TX_AND_PHY_REF_CLK); > + > + return 0; > +} [...] Otherwise, this is looking good. Also, I tested on meson-gxbb-odroidc2 and meson-gxbb-p200 by booting a debian root filesystem over NFS and all was well. Tested-by: Kevin Hilman <khil...@baylibre.com> Kevin

Re: [PATCH RFC 3/3] ARM64: dts: meson-gxbb: use the new meson8b DWMAC glue

Michael Turquette writes: > Hi Martin, > > Quoting Martin Blumenstingl (2016-06-27 04:33:49) >> On Mon, Jun 27, 2016 at 12:44 PM, Martin Blumenstingl >> wrote: >> > On Mon, Jun 27, 2016 at 11:24 AM, Carlo Caione

[PATCH] SMC91x: Use IRQ save and restore versions of spinlocks

version of spin_trylock. Signed-off-by: Kevin Hilman [EMAIL PROTECTED] Acked-by: Nicolas Pitre [EMAIL PROTECTED] --- drivers/net/smc91x.c | 42 ++ 1 files changed, 18 insertions(+), 24 deletions(-) diff --git a/drivers/net/smc91x.c b/drivers/net

[PATCH] SMC91x: don't flag spurious interrupts when polling

. Signed-off-by: Kevin Hilman [EMAIL PROTECTED] Signed-off-by: Nicolas Pitre [EMAIL PROTECTED] --- drivers/net/smc91x.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/drivers/net/smc91x.c b/drivers/net/smc91x.c index 7da7589..64ef6c1 100644 --- a/drivers/net/smc91x.c

[PATCH] SMC91x: poll_controller(): check for interrupts before calling handler

When using polling, smc_poll_controller() can call smc_interrupt() when there are likely to be no real interrups. This will trigger the spurious interrupt printk whenever the driver is being polled. Instead, check for actual interrupts before calling smc_interrupt() Signed-off-by: Kevin Hilman