ader, nothing depends on it (nor the other way around), it's just
(with the rest of the wanXL code) an old piece of a driver for an old
card.
The question is, what do we gain by messing with it?
--
Krzysztof Halasa
68360
(the original QUICC) processor. Maximum bit rate of 2 Mb/s on each sync
serial port.
It's more about delivering the .S source for the firmware, I guess.
Nobody is expected to build it. The fw is about 2.5 KB and is directly
linked with the driver.
--
Krzysztof Halasa
point,
I don't know.
Perhaps I could look at this later, but no promises (this requires
pulling on and setting up some legacy hardware).
Anyway, since the patch is safe and can solve an existing problem:
Acked-by: Krzysztof Halasa <k...@pm.waw.pl>
--
Krzysztof Halasa
s is 15+ years old.
I don't have opinion on the patch.
--
Krzysztof Halasa
Kees Cook <keesc...@chromium.org> writes:
> Several timer users needlessly reset their .function/.data fields during
> their timer callback, but nothing else changes them. Some users do not
> use their .data field at all. Each instance is removed here.
For *wan/hdlc*
Acked-by: K
Kok, Auke [EMAIL PROTECTED] writes:
Don't work by default. pci=nomsi fixes the problem.
actually does not fix anything - it just works around it by falling
back to legacy interrupts.
Actually it does, fixes the problem by working around a bug :-)
Thanks for info.
--
Krzysztof Halasa
(rev a3)
00:10.0 PCI bridge: nVidia Corporation MCP51 PCI Bridge (rev a2)
Additional details on request.
--
Krzysztof Halasa
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo
Generic HDLC now uses random_ether_addr() for generating MAC addresse
for Ethernet-alike interfaces.
Signed-off-by: Krzysztof Halasa [EMAIL PROTECTED]
diff --git a/drivers/net/wan/hdlc_fr.c b/drivers/net/wan/hdlc_fr.c
index 071a64c..7926842 100644
--- a/drivers/net/wan/hdlc_fr.c
+++ b/drivers
Removes now unneeded struct hdlc_device_desc
Signed-off-by: Krzysztof Halasa [EMAIL PROTECTED]
diff --git a/drivers/net/wan/hdlc.c b/drivers/net/wan/hdlc.c
index d553e6f..39951d0 100644
--- a/drivers/net/wan/hdlc.c
+++ b/drivers/net/wan/hdlc.c
@@ -1,7 +1,7 @@
/*
* Generic HDLC support
.
PPP (hdlc_ppp using syncppp) is still broken (by the same change as
FR), I guess the correct fix now is rewriting syncppp (for hdlc_ppp
use). No ETA :-(
Tested in action.
--
Krzysztof Halasa
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL
Fixes kernel panic in Frame Relay mode
Signed-off-by: Krzysztof Halasa [EMAIL PROTECTED]
diff --git a/drivers/net/wan/hdlc_fr.c b/drivers/net/wan/hdlc_fr.c
index 7926842..327b218 100644
--- a/drivers/net/wan/hdlc_fr.c
+++ b/drivers/net/wan/hdlc_fr.c
@@ -135,6 +135,10 @@ typedef struct
-by: Krzysztof Halasa [EMAIL PROTECTED]
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -584,7 +584,10 @@ struct net_device
static inline void *netdev_priv(const struct net_device *dev)
{
- return dev-priv;
+ return (char *)dev + ((sizeof(struct net_device
dev-priv
isn't worth it anyway.
--
Krzysztof Halasa
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
)
-~NETDEV_ALIGN_CONST);
+ return dev-priv;
}
This change caused some problems for drivers which used
netdev_priv(dev) and dev-priv for different purposes.
The following patch restores previous behaviour.
Signed-off-by: Krzysztof Halasa [EMAIL PROTECTED
(ret_fast_syscall+0x0/0x2c)
The patch would make it deadlock.
Please note that sister fr_add_pvc() uses register_netdevice().
The same applies to fr_destroy().
--
Krzysztof Halasa
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More
: timeout while initializing card
+ printk(KERN_WARNING wanXL %s: timeout while initializing card
firmware\n, pci_name(pdev));
wanxl_pci_remove_one(pdev);
return -ENODEV;
Acked-by: Krzysztof Halasa [EMAIL PROTECTED]
Thanks
shouldn't
forward them.
--
Krzysztof Halasa
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
the model? Making the ethX only carry untagged frames (even without
hw VLAN acceleration)?
--
Krzysztof Halasa
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
.
+++ linux-2.6.24/drivers/net/wan/retina.h
@@ -0,0 +1,164 @@
Short header file included by single .c - is it worth it?
Wow, really long.
--
Krzysztof Halasa
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http
Ath5k panics on ath_open() because sc-pdev is never set, fixed.
Signed-off-by: Krzysztof Halasa [EMAIL PROTECTED]
--- a/drivers/net/wireless/ath5k_base.c
+++ b/drivers/net/wireless/ath5k_base.c
@@ -2295,6 +2295,7 @@ static int __devinit ath_pci_probe(struct pci_dev *pdev,
hw-max_rssi
I'd probably leave the thing as is (i.e., BSD/GPL
= in fact BSD), unless something like 50+% of the code is rewritten -
it's mostly their hard work after all, isn't it? Not legal
requirement, though.
--
Krzysztof Halasa
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body
interrupt.
Problem solved, stupid user mistake.
I was using netif_start_queue() instead of netif_wake_queue().
--
Krzysztof Halasa
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo
. Should be easy now.
Thanks.
--
Krzysztof Halasa
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
the problem, anything 197665 and = 52825 doesn't.
197665 = 65 * 3041, 52825 = 25 * 2113.
Doing echo 25560 /proc/sys/net/core/wmem_default causes the driver
to never become TX queue full (IOW max 15 skb being transmitted),
25561 allows for TX queue full.
25560 = 16 * 1597.5.
--
Krzysztof Halasa
should always be VLAN-aware,
stripping the tag (only one) early on RX and adding it late on TX.
That means tcpdump would see packets with exactly one tag removed
(unless there was no tag), in both RX and TX.
Tcpdump would need other means to get VLAN id...
--
Krzysztof Halasa
-
To unsubscribe from
operation when using .1Q.
That is, with header reordering, of course.
Anyway, -ENOPATCH from me for now.
--
Krzysztof Halasa
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
would have to be modified.
Seems a bit of work, I know my message is missing the patch...
--
Krzysztof Halasa
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
.
--
Krzysztof Halasa
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
to restore the tag.
I'm not sure if we really want it. If needed we can disable
acceleration, can't we? While accelerated we can see the packets
(without tags) on logical devices.
However seeing unknown tags on master device (with tcpdump etc)
would certainly be useful.
--
Krzysztof Halasa
in promiscuous mode. In some sense tag is part of the mac address.
Well, in some sense maybe, though the MAC address is rather
strictly defined to be a 6-octet value. I can live with
promiscous anyway, it's really minor issue.
--
Krzysztof Halasa
-
To unsubscribe from this list: send the line
named 'ipmtu' which can be used to specify
initial MTU size when booting via nfsroot.
Isn't the whole IP autoconfig and NFS root set to die?
Why not do it in initramfs?
--
Krzysztof Halasa
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL
not.
This way each driver has only one entry, but if you know you have,
say, 1 Gb/s Ethernet card only you can select 1 Gb/s and don't
worry about 100-Mbps NVidias.
I'd include that Tulip thing, too - no need for a separate menu
(the directory is a different thing).
--
Krzysztof Halasa
-
To unsubscribe
and that's not the typical
endianess problem cross-platform drivers sometimes have.
There is different functionality required with LE mode, unless some
other arch changes are implemented (which I'm now researching, if
I have some time of course).
--
Krzysztof Halasa
-
To unsubscribe from this list: send
coherency mode right.
Personally I'd be pleased if I could run the board LE instead
of BE, with no performance penalty.
--
Krzysztof Halasa
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org
James Bottomley [EMAIL PROTECTED] writes:
drivers/ata/Kconfig has a select SCSI at the top, so if you selected
modular ATA, you'll be forced to have modular SCSI.
Or built-in.
--
Krzysztof Halasa
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message
is
something that you can't achieve with an allocator, as far as I can
see.
I'd have to put SRAM address in the board code instead. Certainly
not required at this point, and perhaps it will be never needed.
--
Krzysztof Halasa
-
To unsubscribe from this list: send the line unsubscribe netdev
Lennert Buytenhek [EMAIL PROTECTED] writes:
I have a couple of ixp23xx boards at home, but I'm not sure whether I
can give them away. I can give you remote access to them, though.
Hmm, may be interesting some day.
--
Krzysztof Halasa
-
To unsubscribe from this list: send the line unsubscribe
don't want to make them available to the
public (but sure, I don't like them in .c either, I think nobody
likes such definitions anywhere but they have to exist somewhere).
--
Krzysztof Halasa
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED
QUEUE_IRQ_SRC_NOT_NEARLY_FULL 6
+#define QUEUE_IRQ_SRC_NOT_FULL 7
Here, unlike ixp4xx_npe.c defines are in qmgr.h - that seems a bit
more natural.
Because they are public interface :-)
--
Krzysztof Halasa
-
To unsubscribe from this list: send the line unsubscribe netdev
for TX, and then crypto, and maybe other things.
Current allocator have its potential problems, but they can be
solved internally (fragmentation, be we tend to use only
128-entry queues (RX and TX-ready Ethernet pool) and short,
16-entry ones (TX) - easy to deal with).
--
Krzysztof Halasa
in a separate mail, generally
2 patches are marked v.2 and one v.3.
--
Krzysztof Halasa
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
automated process it seems, for most part at least.
--
Krzysztof Halasa
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
the SRAM map at compile time.
That would be most limiting with IMHO no visible advantage.
--
Krzysztof Halasa
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
can you complain about code readability. :-))
Well, you may have the point, but I also care about others :-)
--
Krzysztof Halasa
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo
that trivial workaround?
--
Krzysztof Halasa
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
% performance hit on LE, more, or less)?
Haven't checked yet but I'd expect something like that.
--
Krzysztof Halasa
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello,
Alexey Zaytsev [EMAIL PROTECTED] writes:
#ifndef __ASSEMBLY__
+static inline u32 ixp4xx_read_fuses(void)
Oops. You're right, of course.
--
Krzysztof Halasa
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo
Adds fuse functions to help determine installed IXP4xx CPU
components and to reset/disable/enable them (only NPE - network
coprocessors - can be reset and reenabled).
Signed-off-by: Krzysztof Halasa [EMAIL PROTECTED]
diff --git a/include/asm-arm/arch-ixp4xx/ixp4xx-regs.h
b/include/asm-arm/arch
see any bad idea here.
The original dependency was certainly, uhm, not the best one.
--
Krzysztof Halasa
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Roman Zippel [EMAIL PROTECTED] writes:
HDLC doesn't really look like simple library code, what's up with all the
HDLC_* options?
Sub-modules. Anyway, what does the patch screw exactly?
--
Krzysztof Halasa
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body
would expect them there?
How about the dependency mess (NET_ETHERNET etc.) that would be
created?
--
Krzysztof Halasa
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
:
a) initialized NPEs and downloades the firmware
b) exchanges control messages with NPEs.
--
Krzysztof Halasa
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
/xscale ?
- The MAC is used on IXP23xx, too. So the drivers for
both CPU familys only differ in the way they exchange
network packets between the NPE and the kernel.
Hmm... perhaps someone have a spare device with such IXP23xx
and wants to make it a donation for science? :-)
--
Krzysztof
for the select.
CONFIG_HDLC _is_ a simple library, though probably not the most
simple one. I really feel it's an improvement.
Attaching two patches, hopefully the double check is enough.
--
Krzysztof Halasa
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message
From: Jan Engelhardt [EMAIL PROTECTED]
Change Kconfig objects from menu, config into menuconfig so
that the user can disable the whole feature without having to
enter the menu first.
Signed-off-by: Jan Engelhardt [EMAIL PROTECTED]
Signed-off-by: Krzysztof Halasa [EMAIL PROTECTED]
---
drivers
Allow enabling WAN drivers without selecting generic HDLC first,
HDLC will be selected automatically.
Signed-off-by: Krzysztof Halasa [EMAIL PROTECTED]
--- linux/drivers/net/wan/Kconfig 2007-05-07 22:46:06.0 +0200
+++ linux/drivers/net/wan/Kconfig 2007-05-07 22:45
Adds a driver for IXP4xx built-in hardware queue manager.
Signed-off-by: Krzysztof Halasa [EMAIL PROTECTED]
diff --git a/arch/arm/mach-ixp4xx/Kconfig b/arch/arm/mach-ixp4xx/Kconfig
index 9715ef5..71ef55f 100644
--- a/arch/arm/mach-ixp4xx/Kconfig
+++ b/arch/arm/mach-ixp4xx/Kconfig
@@ -176,6
Adds a driver for built-in IXP4xx hardware Queue Manager.
Signed-off-by: Krzysztof Halasa [EMAIL PROTECTED]
diff --git a/arch/arm/mach-ixp4xx/Kconfig b/arch/arm/mach-ixp4xx/Kconfig
index 9715ef5..71ef55f 100644
--- a/arch/arm/mach-ixp4xx/Kconfig
+++ b/arch/arm/mach-ixp4xx/Kconfig
@@ -176,6
drivers v.2 - Ethernet and HSS
You guessed it, needs all of the above.
The:
[PATCH] Intel IXP4xx network drivers v.2 - QMGR
was faulty, thus v.3.
Fire again :-)
--
Krzysztof Halasa
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL
+
drivers/net/ixp4xx/ixp4xx_qmgr.c | 273 +++
drivers/net/ixp4xx/npe.h | 41 +
drivers/net/ixp4xx/qmgr.h | 124 +++
drivers/net/wan/Kconfig | 10
include/asm-arm/arch-ixp4xx/platform.h| 19
--
Krzysztof Halasa
Allow enabling WAN drivers without selecting generic HDLC first,
HDLC will be selected automatically.
Signed-off-by: Krzysztof Halasa [EMAIL PROTECTED]
diff --git a/drivers/net/wan/Kconfig b/drivers/net/wan/Kconfig
index 8897f53..3a2fe82 100644
--- a/drivers/net/wan/Kconfig
+++ b/drivers/net/wan
Adds fuse functions to help determine installed IXP4xx CPU
components and to reset/disable/enable them (only NPE - network
coprocessors - can be reset and reenabled).
Signed-off-by: Krzysztof Halasa [EMAIL PROTECTED]
diff --git a/include/asm-arm/arch-ixp4xx/ixp4xx-regs.h
b/include/asm-arm/arch
+++---
Looks good.
--
Krzysztof Halasa
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
(or anything) could help here. AFAIK the
converters have no serial numbers and no other means to
differentiate.
--
Krzysztof Halasa
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo
Sparse annotations, including two minor bugfixes.
Signed-off-by: Krzysztof Halasa [EMAIL PROTECTED]
diff --git a/drivers/net/wan/hdlc_cisco.c b/drivers/net/wan/hdlc_cisco.c
index c9664fd..a7a12d6 100644
--- a/drivers/net/wan/hdlc_cisco.c
+++ b/drivers/net/wan/hdlc_cisco.c
@@ -37,16 +37,16
if dev-hard_header = NULL (as with other protocols)?
--
Krzysztof Halasa
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Switching HDLC devices from Ethernet-framing mode caused stale ethernet
function assignments within net_device.
Signed-off-by: Krzysztof Halasa [EMAIL PROTECTED]
diff --git a/drivers/net/wan/hdlc.c b/drivers/net/wan/hdlc.c
index db354e0..f6e6b63 100644
--- a/drivers/net/wan/hdlc.c
+++ b/drivers
-tested only but it seems pretty obvious and of course I check
if the packets still flow after regular kernel upgrades (and I run
automatic tests checking all protos except X.25 from time to time as
well).
(the patch is in the next message).
Not sure if 2.6.21 material.
--
Krzysztof Halasa
Jeff Garzik [EMAIL PROTECTED] writes:
Please make sure to provides updates ensuring that it passes sparse
checks (see Documentation/sparse.txt)
Ok.
--
Krzysztof Halasa
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More
, my drivers don't.
--
Krzysztof Halasa
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
The attached patch adds an alternative driver pc300too for PCI WAN
cards PC300/RSV and PC300/X21 made by Cyclades Corp. (now Avocent Corp).
Signed-off-by: Krzysztof Halasa [EMAIL PROTECTED]
diff --git a/drivers/net/wan/Kconfig b/drivers/net/wan/Kconfig
index 21f76f5..f07aec3 100644
--- a/drivers
/e1000/e1000_82571.h | 42
Perhaps the e1000_ prefix could be dropped as redundant?
--
Krzysztof Halasa
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Jarek Poplawski [EMAIL PROTECTED] writes:
And if we talk about names:
+ Spotted by Krzysztof Halasa.
I wound't care less btw.
--
Krzysztof Halasa
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http
, len=512
Redzone: 0x5a2cf071/0x5a2cf071.
Last user: [c02b5998](kfree_skbmem+0x8/0x80)
and so on.
--
Krzysztof Halasa
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
linearized in
dev-hard_start_xmit() or equivalent path?
--
Krzysztof Halasa
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Adrian Bunk [EMAIL PROTECTED] writes:
It's still not used...
So let's unexport it again until some driver that actually uses it shows up.
Fair enough.
--
Krzysztof Halasa
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More
. Thanks.
Signed-off-by: Krzysztof Halasa [EMAIL PROTECTED]
diff --git a/drivers/net/wan/Kconfig b/drivers/net/wan/Kconfig
index b5d0d7f..d5ab9cf 100644
--- a/drivers/net/wan/Kconfig
+++ b/drivers/net/wan/Kconfig
@@ -57,44 +57,6 @@ config COSA
The driver will be compiled as a module
.
--
Krzysztof Halasa
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
This patch removes accesses to the HDLC-internal data structures
from pc300 driver, thus enabling it to compile but breaking part
of its functionality.
Signed-off-by: Krzysztof Halasa [EMAIL PROTECTED]
diff --git a/drivers/net/wan/pc300_drv.c b/drivers/net/wan/pc300_drv.c
index 56e6940..8d9b959
Jeff,
The first patch renames drivers/net/wan/hdlc_generic.c file to hdlc.c.
It has been generated with git-diff* -M. Please let me know if you
need a normal patch.
--
Krzysztof Halasa
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED
Jeff Garzik [EMAIL PROTECTED] writes:
applied 1-2
Thanks.
--
Krzysztof Halasa
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
this machine has a history of mysterious hangs (black
screen of death), though I think they are related to LAN and maybe disk
activity, not GRE/PPP/ATM/ADSL (RAM tests ok, the hardware is rather
common - i440BX etc. but who knows).
--
Krzysztof Halasa
--
VGER BF report: S 0.999877
);
__netdev_watchdog_up(dev);
- netif_tx_unlock_bh(dev);
}
static void dev_watchdog_down(struct net_device *dev)
Many thanks for looking into this. The lockdep warning is gone now.
--
Krzysztof Halasa
--
VGER BF report: H 3.43998e-11
-
To unsubscribe from this list: send the line
-
Root: Correctable- Non-Fatal- Fatal- PME-
--
Krzysztof Halasa
--
VGER BF report: U 0.5
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
[c0104c0f] do_IRQ+0x8f/0xf0
[c0102ef9] common_interrupt+0x25/0x2c
[c01018e9] cpu_idle+0x39/0x50
[c010052e] rest_init+0x1e/0x30
[c041f76e] start_kernel+0x25e/0x2c0
[c0100199] 0xc0100199
--
Krzysztof Halasa
--
VGER BF report: U 0.5
-
To unsubscribe from this list: send the line unsubscribe
you.
--
Krzysztof Halasa
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi,
One of my recent changes broke C101 carrier handling, this patch
fixes it. Also fixes an old TX underrun checking bug.
2.6.18 material. Please apply.
Thanks.
Signed-off-by: Krzysztof Halasa [EMAIL PROTECTED]
diff --git a/drivers/net/wan/c101.c b/drivers/net/wan/c101.c
index 435e91e
?
--
Krzysztof Halasa
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Krzysztof Halasa [EMAIL PROTECTED] writes:
Ok. Rozumiem, ze Jeff zrobi to w jednym, duzym batchu?
Oops, hit the wrong key.
Ok WRT both patches and assume Jeff will apply this all-at-once.
--
Krzysztof Halasa
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body
Hi,
One of my recent changes broke C101 carrier handling, this patch
fixes it. Also fixes an old TX underrun checking bug.
2.6.18 material. Please apply.
Thanks.
Signed-off-by: Krzysztof Halasa [EMAIL PROTECTED]
diff --git a/drivers/net/wan/c101.c b/drivers/net/wan/c101.c
index 435e91e
,
something like A7N8X-E?
--
Krzysztof Halasa
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
ip_output() is ok
for 2.6.18, isn't it?
What about the psched_mtu() thing? While it's not kernel panic,
I think we should fix it. I'm not sure it should return dev-mtu +
dev-hard_header_len or just dev-mtu, though.
--
Krzysztof Halasa
-
To unsubscribe from this list: send the line unsubscribe netdev
think the same.
--
Krzysztof Halasa
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
hard_header() which, in turn, does skb_push()?
How about Ethernet - is it safe? There is hard_header() which blindly
adds 14 bytes.
--
Krzysztof Halasa
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http
headers to prepend for your device, why do you set the
header building function to NULL? :-)
hdlc_fr: logical PVC devices have no headers (plain IPv4 etc. as seen
by tcpdump), but they append FR headers (4 or 10 bytes long) just
before passing the skb to physical device.
--
Krzysztof Halasa
?
If it can's be accepted I can just add an empty pvc-hard_header().
That won't make other drivers work reliably, though, and it's IMHO
hardly their author's fault. I don't think we've ever advertised
hard_header_len is valid only with non-NULL hard_header.
--
Krzysztof Halasa
-
To unsubscribe from
?
--
Krzysztof Halasa
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Krzysztof Halasa [EMAIL PROTECTED] writes:
Are you sure about that? It would mean almost devices, including
^^
Ethernet, are at risk:
almost all devices, of course.
--
Krzysztof Halasa
-
To unsubscribe from this list: send the line
the box.
A similar problem may be present in psched_mtu().
Please apply.
I think it should then be applied to stable series as well.
Signed-off-by: Krzysztof Halasa [EMAIL PROTECTED]
diff --git a/include/net/pkt_sched.h b/include/net/pkt_sched.h
index b94d1ad..3ae64ba 100644
--- a/include/net
by qdiscs. If hard_header is NULL, it sees skbs
without header.
Right, by similar problem I meant ignoring hard_header_len and not
kernel panic.
--
Krzysztof Halasa
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info
1 - 100 of 171 matches
Mail list logo