Re: [181992] ...8xx/816: net-tcp_bbr: improve DCTCP ECN delayed ACK

2018-07-25 Thread Laurent Chavey
it-Project: kernel/release/8xx > Gerrit-Branch: 816 > Gerrit-Change-Id: Ied39c2f4ef576c697b0064d6b810b47282796388 > Gerrit-Change-Number: 181992 > Gerrit-PatchSet: 1 > Gerrit-Owner: Yuchung Cheng > Gerrit-Reviewer: Greg Thelen > Gerrit-Reviewer: Laurent Chavey > Gerrit-Re

[PATCH]: bonding: Fix 802.3ad no carrier on no partner found instance

2007-06-01 Thread Laurent Chavey
(bond-first_slave).aggregator))) { if (!netif_carrier_ok(bond-dev)) { netif_carrier_on(bond-dev); return 1; On 5/31/07, Laurent Chavey [EMAIL PROTECTED] wrote: if a host configured with 802.3ad bond mode is connected to a switch

Re: [PATCH]: bonding: Fix 802.3ad no carrier on no partner found instance

2007-06-01 Thread Laurent Chavey
On 6/1/07, Jay Vosburgh [EMAIL PROTECTED] wrote: Laurent Chavey [EMAIL PROTECTED] wrote: On 5/31/07, Laurent Chavey [EMAIL PROTECTED] wrote: if a host configured with 802.3ad bond mode is connected to a switch that does not support 802.3ad, then an aggregator is selected as the active

[PATCH 2.6.21.3] bonding: Fix 802.3ad no carrier on no partner found instance

2007-06-01 Thread Laurent Chavey
Remove the requirement to have at least one configured partner to enable the operation of links. The later is necessary to have the code in compliance with section 43.3.9 of IEEE 802.3, Signed-off-by: Laurent Chavey [EMAIL PROTECTED] -- diff -ru linux-2.6.21.3/drivers/net/bonding/bond_3ad.c

bond_3ad.c: why does bond_3ad_set_carrier() check if the mac partnet mac is set.

2007-05-31 Thread Laurent Chavey
if a host configured with 802.3ad bond mode is connected to a switch that does not support 802.3ad, then an aggregator is selected as the active aggregator (first link that has carrier in the slave list). This is perfectly fine, since it lets at least one of the link become active. (this was the

Re: bond_compute_features() does not handle devices with different CSUM

2007-05-30 Thread Laurent Chavey
features = features (dev_features BOND_INTERSECT_FEATURES); On 5/30/07, Michael Buesch [EMAIL PROTECTED] wrote: On Wednesday 30 May 2007 04:47:09 Laurent Chavey wrote: proposed change. --- 2.6.20/drivers/net/bonding/bond_main.c 2007-05-29 19:43:39.010565000 -0700 +++ 2.6.20.fix

Re: bond_compute_features() does not handle devices with different CSUM

2007-05-30 Thread Laurent Chavey
) max_hard_header_len = slave-dev-hard_header_len; } On 5/30/07, Laurent Chavey [EMAIL PROTECTED] wrote: features = features (dev_features BOND_INTERSECT_FEATURES); On 5/30/07, Michael Buesch [EMAIL PROTECTED] wrote: On Wednesday 30 May 2007 04:47:09 Laurent Chavey wrote: proposed

Re: bond_compute_features() does not handle devices with different CSUM

2007-05-30 Thread Laurent Chavey
should we then move/integrate that code as part of the bonding driver ? On 5/30/07, Stephen Hemminger [EMAIL PROTECTED] wrote: On Tue, 29 May 2007 17:41:45 -0700 Laurent Chavey [EMAIL PROTECTED] wrote: kernel version = 2.6.20.1 file drivers/net/bonding/bonding_main.c function

bond_compute_features() does not handle devices with different CSUM

2007-05-29 Thread Laurent Chavey
kernel version = 2.6.20.1 file drivers/net/bonding/bonding_main.c function bond_compute_features() --- Given a system with two different NIC. One driver sets dev-features |= NETIF_F_HW_CSUM the other driver sets dev-features |= NETIF_F_IP_CSUM when enslaving the 2

Re: bond_compute_features() does not handle devices with different CSUM

2007-05-29 Thread Laurent Chavey
) max_hard_header_len = slave-dev-hard_header_len; } On 5/29/07, Laurent Chavey [EMAIL PROTECTED] wrote: kernel version = 2.6.20.1 file drivers/net/bonding/bonding_main.c function bond_compute_features() --- Given a system with two different NIC. One driver sets dev

Re: is CONFIG_NET_CLS_ACT always set ?

2007-04-24 Thread Laurent Chavey
On 4/23/07, jamal [EMAIL PROTECTED] wrote: On Mon, 2007-23-04 at 16:08 -0700, Laurent Chavey wrote: sorry for the trick question. I was simply making a modification to the skb tap code to allow tcpdump to work on the slave interface and not just the bonded one. If you dont mind: what

Re: is CONFIG_NET_CLS_ACT always set ?

2007-04-24 Thread Laurent Chavey
handle_bridge does call the tap, so my question is answer there. thanks, On 4/24/07, Laurent Chavey [EMAIL PROTECTED] wrote: On 4/23/07, jamal [EMAIL PROTECTED] wrote: On Mon, 2007-23-04 at 16:08 -0700, Laurent Chavey wrote: sorry for the trick question. I was simply making

Re: AF_PACKET how to get the original netdev from a packet received from a bonded master

2007-04-23 Thread Laurent Chavey
, Chris Leech [EMAIL PROTECTED] wrote: On 4/18/07, David Miller [EMAIL PROTECTED] wrote: From: Laurent Chavey [EMAIL PROTECTED] Date: Wed, 18 Apr 2007 16:05:27 -0700 When using PF_PACKET socket with bonded interfaces, there is no way to get the slave interface (physical interface) the packet

is CONFIG_NET_CLS_ACT always set ?

2007-04-23 Thread Laurent Chavey
if CONFIG_NET_CLS_ACT is not defined, then is the code below correct ? netif_receive_skb() --- list_for_each_entry_rcu(ptype, ptype_all, list) { if (!ptype-dev || ptype-dev == skb-dev) { if (pt_prev)

Re: is CONFIG_NET_CLS_ACT always set ?

2007-04-23 Thread Laurent Chavey
, 2007-23-04 at 14:19 -0700, Laurent Chavey wrote: if CONFIG_NET_CLS_ACT is not defined, then is the code below correct ? The simple answer is yes; Is something not working for you? It is hard to read your question my good friend because it comes out like a trick question;- It is more useful

AF_PACKET how to get the original netdev from a packet received from a bonded master

2007-04-18 Thread Laurent Chavey
When using PF_PACKET socket with bonded interfaces, there is no way to get the slave interface (physical interface) the packet was actually received on. It looks like there isn't a way to pass the original device {see packet_rcv() in ./net/packet/af_packet.c} to the socket reader. When an